Re: [edk2] [edk2-platforms PATCH] Platform D03/D05: Remove EmuVariableRuntimeDxe including

2019-01-16 Thread Ard Biesheuvel
On Wed, 16 Jan 2019 at 11:25, Star Zeng wrote: > > For https://bugzilla.tianocore.org/show_bug.cgi?id=1323, > EmuVariable will be merged to real variable driver, and > EmuVariableRuntimeDxe will be removed finally. > > As D03 and D05 are using the real variable driver VariableRuntimeDxe, > this

Re: [edk2] [PATCH edk2-platforms] Platform/Intel/MinPlatformPkg: add MmServicesTableLib resolution

2019-01-16 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, January 15, 2019 1:25 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Ard Biesheuvel > > Subject: [PATCH edk2-platforms] Platform/Intel/MinPlatformPkg: add >

Re: [edk2] [PATCH v2 09/17] MdePkg: introduce standalone MM entry point library class

2019-01-16 Thread Ard Biesheuvel
On Wed, 16 Jan 2019 at 15:56, Gao, Liming wrote: > > Ard: > I have no other comment for the changes in MdePkg. You can add my R-B for > MdePkg. Besides, I have updated our internal platform too consume new > MmServicesTableLib. > Thank you Liming. I will go through all Star's comments, and

Re: [edk2] [PATCH V3 12/17] ArmVirtXen: Use merged variable driver for emulated NV mode

2019-01-16 Thread Ard Biesheuvel
On Tue, 15 Jan 2019 at 11:29, Star Zeng wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 > Merge EmuVariable and Real variable driver. > > The real variable driver has been updated to support emulated > variable NV mode and the EmuVariableRuntimeDxe will be removed > later, so

Re: [edk2] [PATCH V3 13/17] ArmVirtXen: Link VarCheckUefiLib NULL class library instance

2019-01-16 Thread Ard Biesheuvel
On Tue, 15 Jan 2019 at 11:29, Star Zeng wrote: > > This patch is not related directly to > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 > Merge EmuVariable and Real variable driver. > > It just makes ArmVirtXen be aligned with ArmVirtQemuXXX to > link VarCheckUefiLib NULL class

Re: [edk2] EDK II Network Stack Issue

2019-01-16 Thread Karin Willers
On 2019-01-10 13:40, Karin Willers wrote: On 2019-01-07 20:27, Laszlo Ersek wrote: On 01/04/19 15:02, Karin Willers wrote: G'Day! I'm trying to get networking under edk2 up and running. I tried AppPkg/Applications/Sockets/RawIp4Tx under OVMF. The raw packet is sent out on the network, but the

Re: [edk2] [PATCH v2 09/17] MdePkg: introduce standalone MM entry point library class

2019-01-16 Thread Gao, Liming
Ard: I have no other comment for the changes in MdePkg. You can add my R-B for MdePkg. Besides, I have updated our internal platform too consume new MmServicesTableLib. Thanks Liming > -Original Message- > From: Zeng, Star > Sent: Wednesday, January 16, 2019 2:32 PM > To: Ard

Re: [edk2] [edk2-platforms PATCH] Platform HiKeyXXX: Use merged variable driver for emulated NV mode

2019-01-16 Thread Ard Biesheuvel
On Wed, 16 Jan 2019 at 11:25, Star Zeng wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 > Merge EmuVariable and Real variable driver. > > The real variable driver has been updated to support emulated > variable NV mode and the EmuVariableRuntimeDxe will be removed > later, so

Re: [edk2] [PATCH V2 10/15] ArmVirtXen: Use merged variable driver for emulated NV mode

2019-01-16 Thread Julien Grall
Hi Laszlo, On 15/01/2019 09:37, Laszlo Ersek wrote: On 01/14/19 16:19, Star Zeng wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. The real variable driver has been updated to support emulated variable NV mode and the

Re: [edk2] [PATCH edk2-platforms] Platform/Intel/MinPlatformPkg: add MmServicesTableLib resolution

2019-01-16 Thread Ard Biesheuvel
On Wed, 16 Jan 2019 at 17:05, Yao, Jiewen wrote: > > Reviewed-by: jiewen@intel.com > > > > -Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > Gao, Liming > > Sent: Wednesday, January 16, 2019 6:57 AM > > To: Ard Biesheuvel ;

Re: [edk2] [PATCH v2 04/17] Vlv2TbltDevicePkg: add MmServicesTableLib resolution

2019-01-16 Thread Ard Biesheuvel
(add Yi as well) On Wed, 16 Jan 2019 at 16:14, Gao, Liming wrote: > > Zailiang: > Could you help review this change? > > > -Original Message- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent: Monday, January 14, 2019 9:28 PM > > To: edk2-devel@lists.01.org > > Cc:

Re: [edk2] [PATCH v2 03/17] QuarkPlatformPkg: add MmServicesTableLib resolution

2019-01-16 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, January 14, 2019 9:28 PM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel ; Laszlo Ersek > ; Leif Lindholm ; Kinney, > Michael D ; Gao, Liming ; > Wang, Jian J ; Wu,

[edk2] [Patch] BaseTools: Fix the build report issue for VPD

2019-01-16 Thread Feng, Bob C
From: BobCF Make sure the PlatformAutoGen.AllPcdList always be latest, or build report will fail sometimes. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/AutoGen/AutoGen.py | 5 +++-- 1 file changed, 3

[edk2] [Patch] BaseTools: Fix build report issue.

2019-01-16 Thread Feng, Bob C
The Pcd Array feature changes the Pcd Default value data structure which is used by build report. This patch is going to update build report to adapt that change. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao ---

Re: [edk2] [PATCH edk2-platforms] Platform/Intel/MinPlatformPkg: add MmServicesTableLib resolution

2019-01-16 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gao, Liming > Sent: Wednesday, January 16, 2019 6:57 AM > To: Ard Biesheuvel ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH edk2-platforms]

Re: [edk2] [Patch] BaseTools: Fix the build report issue for VPD

2019-01-16 Thread Feng, Bob C
OK. I'll submit BZ. The two patches are to fix two issues that have different root cause, so I think two patches would be better. -Original Message- From: Gao, Liming Sent: Thursday, January 17, 2019 12:03 AM To: Feng, Bob C ; edk2-devel@lists.01.org Subject: RE: [edk2] [Patch]

Re: [edk2] [PATCH V3 15/17] QuarkMin: Use merged variable driver for emulated NV mode

2019-01-16 Thread Steele, Kelly
Reviewed-by: Kelly Steele > -Original Message- > From: Zeng, Star > Sent: January 15, 2019 02:30 > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > ; Steele, Kelly > Subject: [PATCH V3 15/17] QuarkMin: Use merged variable driver for > emulated NV mode > > REF:

Re: [edk2] EmulatorPkg build issue with macOS mojave and Xcode 10

2019-01-16 Thread Gao, Liming
Hi, I do the minimal change in Edk2 to make sure EmulatorPkg pass build in MAC. Here is the code https://github.com/lgao4/edk2/tree/XcodeEmulator. Please try to verify its functionality. If you request add this support, please enter one BZ (https://bugzilla.tianocore.org) for it. Thanks

[edk2] [Patch] BaseTools: Allow empty value for HiiPcd in Dsc

2019-01-16 Thread Feng, Bob C
https://bugzilla.tianocore.org/show_bug.cgi?id=1466 DEC file defines PCD default value and PCD supported type. DSC can configure PCD type and value. If the value is same to default value in DEC file, DSC can only configure PCD type and leave empty for value. This usage supports all type PCD

Re: [edk2] EDK II Network Stack Issue

2019-01-16 Thread Laszlo Ersek
On 01/16/19 13:57, Karin Willers wrote: > On 2019-01-10 13:40, Karin Willers wrote: >> On 2019-01-07 20:27, Laszlo Ersek wrote: >>> On 01/04/19 15:02, Karin Willers wrote: G'Day! I'm trying to get networking under edk2 up and running. I tried

[edk2] [Patch v2] BaseTools: Fix incorrect formatting of GenFds command dictionary

2019-01-16 Thread Felix Polyudov
GenFdsCommand returned dictionary with elements that are not compatible with GenFdsApi. As a result the following options were not processed by GenFdsApi: -v, -q, -d, --genfds-multi-thread, --ignore-sources The issue is introduced by commit b3497bad1221704a5dbc5da0b10f42625f1ad2ed. V2: Remove

Re: [edk2] [PATCH V3 15/17] QuarkMin: Use merged variable driver for emulated NV mode

2019-01-16 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney > -Original Message- > From: Zeng, Star > Sent: Tuesday, January 15, 2019 2:30 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > ; Steele, Kelly > > Subject: [PATCH V3 15/17] QuarkMin: Use merged variable > driver for emulated NV mode

Re: [edk2] [PATCH v2 04/17] Vlv2TbltDevicePkg: add MmServicesTableLib resolution

2019-01-16 Thread Gao, Liming
Zailiang: Could you help review this change? > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, January 14, 2019 9:28 PM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel ; Laszlo Ersek > ; Leif Lindholm ; Kinney, > Michael D ; Gao, Liming ;

Re: [edk2] [Patch] BaseTools: Fix the build report issue for VPD

2019-01-16 Thread Gao, Liming
Bob: Please submit BZ for this issue. Could we merge these two patches? Seemly, they are both build report issue. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Feng, > Bob C > Sent: Wednesday, January 16, 2019 11:30 PM >

Re: [edk2] [edk2-test][RFC] Integrating SBBR tests into SCT - A design proposal

2019-01-16 Thread Supreeth Venkatesh
Eric, SBBR test cases does not affect the normal flow of UEFI-SCT, so I don't think it causes any issues to UEFI-SCT, but will instead have added value to UEFI-SCT. However, Please carefully review the pre-processing workflow, when Sakar sends SBBR Patches. Sakar, I need more clarification on

Re: [edk2] [PATCH v2 00/17] implement standalone MM versions of the variable runtime drivers

2019-01-16 Thread Ard Biesheuvel
On Tue, 15 Jan 2019 at 09:25, Wang, Jian J wrote: > > Ard, > > For patch 1,5,6,7,8,12,13,14,15,16,17 > > Reviewed-by: Jian J Wang > Series pushed as 2f4a5a9f4c17..5072c47411b8 Thanks all. > > > -Original Message- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent:

[edk2] [PATCH v2 02/11] StandaloneMmPkg: add MM_STANDALONE MemoryAllocationLib implementation

2019-01-16 Thread Ard Biesheuvel
This MemoryAllocationLib code is based on the staging implementation of StandaloneMmPkg, with the following changes: - use correct MODULE_TYPE - include MmServicesTableLib instead of declaring gMmst directly - update code comments referring to the MM core Contributed-under: TianoCore Contribution

[edk2] [PATCH v2 01/11] StandaloneMmPkg: add HobLib implementation for MM_STANDALONE modules

2019-01-16 Thread Ard Biesheuvel
This HobLib code is based on the staging implementation of StandaloneMmPkg, with the following changes: - drop the unused AArch64/StandaloneMmCoreHobLibInternal.c source file - remove hack from HobLibConstructor() - update code comments referring the MM core Contributed-under: TianoCore

[edk2] [PATCH v2 00/11] StandaloneMmPkg: assorted fixes and improvements

2019-01-16 Thread Ard Biesheuvel
This series addresses a number of issues I ran into while bringing up the standalone MM based authenticated variable store on the SynQuacer (AArch64) platform. Patches #1 - #3 are based on Jagadeesh's patch that imports some staging code into StandaloneMmPkg, with the following changes: - drop

[edk2] [PATCH v2 03/11] StandaloneMmPkg/StandaloneMmCoreHobLib: restrict to MM_CORE_STANDALONE

2019-01-16 Thread Ard Biesheuvel
Remove MM_STANDALONE from the list of permitted modules for this library. It should only be used by the standalone MM core. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jagadeesh Ujja Signed-off-by: Ard Biesheuvel ---

Re: [edk2] [PATCH edk2-platforms] Platform/Various: drop DefaultExceptionHandlerLibBase reference

2019-01-16 Thread Ard Biesheuvel
On Wed, 16 Jan 2019 at 20:33, Leif Lindholm wrote: > > On Thu, Dec 20, 2018 at 06:31:53PM +0100, Ard Biesheuvel wrote: > > Now that DebugAgentSymbolsBaseLib from ArmPkg no longer requires > > a DefaultExceptionHandlerLib resolution, drop the overrides from > > the [LibraryClasses.SEC] sections of

[edk2] History question about Base.h and its alternate parallel name space.... Should we change it?

2019-01-16 Thread Andrew Fish via edk2-devel
I had some one ask me recently why EFI_GUID does not work with #include . I explained they needed to use GUID vs. EFI_GUID. That prompted the question of why we have 2 names for the same thing. Well the historical answer was kind of political as some team wanted to use edk2, but not

[edk2] [RFC v2] Proposal to add edk2-libc

2019-01-16 Thread Kinney, Michael D
Hello, I shared an RFC in November to add an edk2-apps repository. https://lists.01.org/pipermail/edk2-devel/2018-November/00.html Feedback in this thread discussed that there are three types of applications. Apps that use libc, UEFI Shell apps, and UEFI Applications. I would like this

Re: [edk2] [PATCH edk2-platforms] Platform/Various: drop DefaultExceptionHandlerLibBase reference

2019-01-16 Thread Leif Lindholm
On Thu, Dec 20, 2018 at 06:31:53PM +0100, Ard Biesheuvel wrote: > Now that DebugAgentSymbolsBaseLib from ArmPkg no longer requires > a DefaultExceptionHandlerLib resolution, drop the overrides from > the [LibraryClasses.SEC] sections of various platforms. > > Contributed-under: TianoCore

Re: [edk2] History question about Base.h and its alternate parallel name space.... Should we change it?

2019-01-16 Thread Kinney, Michael D
Hi Andrew, I though the reason was a bit more technical. We have a MODULE_TYPE of BASE. Library instances that use the BASE MODULE_TYPE are declaring that the library interfaces are safe to be linked against a module of any other type (SEC, PEI, DXE, SMM, DXE_RUNTIME, UEFI_DRIVER, UEFI_APP).

Re: [edk2] [PATCH v2 04/17] Vlv2TbltDevicePkg: add MmServicesTableLib resolution

2019-01-16 Thread Kinney, Michael D
Reviewed-by: Michael D Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Ard Biesheuvel > Sent: Wednesday, January 16, 2019 9:45 AM > To: Gao, Liming ; Qian, Yi > > Cc: Wu, Hao A ; edk2- > de...@lists.01.org; Kinney, Michael D

Re: [edk2] [PATCH v3] IntelFsp2Pkg: Add FspmArchConfigPpi to support Dispatch mode

2019-01-16 Thread Desimone, Nathaniel L
Reviewed-by: Nate DeSimone -Original Message- From: Chasel, Chiu Sent: Monday, January 14, 2019 10:03 PM To: edk2-devel@lists.01.org Cc: Nate DeSimone ; Star Zeng ; Chasel Chiu Subject: [PATCH v3] IntelFsp2Pkg: Add FspmArchConfigPpi to support Dispatch mode REF:

[edk2] [PATCH v2 11/11] StandaloneMmPkg/Core: permit encapsulated firmware volumes

2019-01-16 Thread Ard Biesheuvel
Standalone MM requires 4 KB section alignment for all images, so that strict permissions can be applied. Unfortunately, this results in a lot of wasted space, which is usually costly in the secure world environment that standalone MM is expected to operate in. So let's permit the standalone MM

[edk2] [PATCH v2 07/11] StandaloneMmPkg/StandaloneMmCoreEntryPoint: remove bogus ASSERT_EFI_ERROR()s

2019-01-16 Thread Ard Biesheuvel
ASSERT_EFI_ERROR (x) is a shorthand for ASSERT(!EFI_ERROR(x)), and so it should only be used with EFI_STATUS type expressions. So drop two instances that operate on other types, since neither looks particularly useful. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard

[edk2] [PATCH v2 04/11] StandaloneMmPkg/StandaloneMmCpu: fix typo Standlone -> Standalone

2019-01-16 Thread Ard Biesheuvel
Fix a couple of occurrences of typo Standlone -> Standalone Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Supreeth Venkatesh --- StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c | 2 +-

[edk2] [PATCH v2 10/11] StandaloneMmPkg/StandaloneMmCoreEntryPoint: permit the use of TE images

2019-01-16 Thread Ard Biesheuvel
TE images take up less space when using 4 KB section alignment, since the FFS/FV generation code optimizes away the redundant, nested padding. This saves 4 KB of space, which is a worthwhile improvement for code that executes in place in secure context. Contributed-under: TianoCore Contribution

[edk2] [PATCH v2 09/11] StandaloneMmPkg/Core/Dispatcher: don't copy dispatched image twice

2019-01-16 Thread Ard Biesheuvel
The dispatcher uses the PE/COFF loader to load images into the heap, but only does so after copying the entire image first, leading to two copies being made for no good reason. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH v2 06/11] StandaloneMmPkg/StandaloneMmCoreEntryPoint: use %a modifier for ASCII strings

2019-01-16 Thread Ard Biesheuvel
PE/COFF section names are ASCII strings so use %a not %s. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Supreeth Venkatesh --- StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c | 2 +- 1 file changed, 1

[edk2] [PATCH v2 05/11] StandaloneMmPkg/StandaloneMmCoreEntryPoint: add missing SerialPortLib ref

2019-01-16 Thread Ard Biesheuvel
StandaloneMmCoreEntryPoint calls SerialPortInitialize() explicitly, so add SerialPortLib to its list of LibraryClasses. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Reviewed-by: Supreeth Venkatesh ---

[edk2] [PATCH v2 08/11] StandaloneMmPkg/StandaloneMmPeCoffExtraActionLib: ignore runtime attribute

2019-01-16 Thread Ard Biesheuvel
The special handling of the EFI_IMAGE_SUBSYSTEM_EFI_RUNTIME_DRIVER attribute is only necessary for images that are relocated twice, i.e., in the context of SetVirtualAddressMap (). This does not apply to standalone MM modules, so drop the check. Drop some redundant DEBUG output while at it.

Re: [edk2] [PATCH edk2-platforms 0/8] Silicon/SynQuacer: add support for 32-bit mode

2019-01-16 Thread Ard Biesheuvel
On Tue, 15 Jan 2019 at 13:08, Leif Lindholm wrote: > > On Mon, Jan 14, 2019 at 06:01:57PM +0100, Ard Biesheuvel wrote: > > This series fixes various issues that prevent the SynQuacer/DeveloperBox > > platform from being built or executed in 32-bit mode. > > > > Ard Biesheuvel (8): > >

Re: [edk2] History question about Base.h and its alternate parallel name space.... Should we change it?

2019-01-16 Thread Felix Polyudov
I agree with Andrew. In my opinion, moving alias types to Base.h will help to overcome certain practical inconveniences without a significant impact on the ability to detect poorly written Base libraries. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] History question about Base.h and its alternate parallel name space.... Should we change it?

2019-01-16 Thread Andrew Fish via edk2-devel
> On Jan 16, 2019, at 1:19 PM, Kinney, Michael D > wrote: > > Hi Andrew, > > I though the reason was a bit more technical. We have a > MODULE_TYPE of BASE. Library instances that use the BASE > MODULE_TYPE are declaring that the library interfaces are > safe to be linked against a module

Re: [edk2] [PATCH] EmbeddedPkg/NorFlashInfoLib: convert to BASE library

2019-01-16 Thread Leif Lindholm
On Wed, Jan 02, 2019 at 02:00:44PM +0100, Ard Biesheuvel wrote: > The library's MODULE_TYPE and the module type restrictions it > defines are needlessly strict. Just change the library to BASE > type and drop the restrictions entirely. Also, drop a bogus > library dependency on DxeServicesLib. >

Re: [edk2] [PATCH v2 0/5] ArmPkg: use console for minimal 'exception occurred' message

2019-01-16 Thread Ard Biesheuvel
On Tue, 15 Jan 2019 at 09:23, Ard Biesheuvel wrote: > > When running with a graphical console, no message whatsoever is printed > when the systems hits an unexpected exception and hangs, because even > the minimal 'exception occurred' message is only sent to the serial port. > > So let's fix

Re: [edk2] [PATCH] EmbeddedPkg/NorFlashInfoLib: convert to BASE library

2019-01-16 Thread Ard Biesheuvel
On Wed, 16 Jan 2019 at 21:18, Leif Lindholm wrote: > > On Wed, Jan 02, 2019 at 02:00:44PM +0100, Ard Biesheuvel wrote: > > The library's MODULE_TYPE and the module type restrictions it > > defines are needlessly strict. Just change the library to BASE > > type and drop the restrictions entirely.

[edk2] [PATCH] ArmPkg/DefaultExceptionHandlerLib: add missing UefiLib include

2019-01-16 Thread Ard Biesheuvel
Commit 31f5388006fc ("ArmPkg/DefaultExceptionHandlerLib: use console if available") added calls to AsciiPrint() to the default exception handler code, but the ARM version did not include UefiLib.h yet (even though the .INF declares it unconditionally), resulting in build breakage. So add the

[edk2] [PATCH 2/4] SecurityPkg/PlatformSecureLibNull: permit use by MM_STANDALONE modules

2019-01-16 Thread Ard Biesheuvel
Add MM_STANDALONE to the list of module types that are permitted to link to this library. Also, since the constructor prototype is different between MM_STANDALONE and DXE_DRIVER type libraries, convert the library into BASE type. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH 1/4] CryptoPkg/SmmCryptLib: permit use by MM_STANDALONE modules

2019-01-16 Thread Ard Biesheuvel
Permit SmmCryptLib to be used by MM_STANDALONE modules Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2] [PATCH 0/4] Various Packages: add MM_STANDALONE support

2019-01-16 Thread Ard Biesheuvel
Add MM_STANDALONE to the list of permitted module types of various libraries that are required to build the standalone MM authenticated variable stack. In some cases, this requires the MODULE_TYPE to be modified to BASE, given that the constructor prototype is different between DXE/UEFI and

[edk2] [PATCH 4/4] MdePkg/UefiDevicePathLib: permit use by MM_STANDALONE modules

2019-01-16 Thread Ard Biesheuvel
Add MM_STANDALONE to the list of module types that are permitted to link to this library. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[edk2] [PATCH 3/4] MdeModulePkg/VarCheckLib: permit use by MM_STANDALONE modules

2019-01-16 Thread Ard Biesheuvel
Permit VarCheckLib and VarCheckUefiLib to be used by MM_STANDALONE modules. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf| 4 ++--

[edk2] [PATCH 3/3] FatPkg: Add GPT check in FatPei to support Capsule-on-Disk feature.

2019-01-16 Thread Chen A Chen
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1470 This feature is used for finding GPT partition, follow the following step to check. 1) Check Protective MBR. 2) Check GPT primary/backup header. 3) Check GPT primary/backup entry array. Cc: Ruiyu Ni Cc: Zhang Chao B Contributed-under:

Re: [edk2] [Patch] BaseTools: Remove EDK_SOURCE keyword from ECC Tool

2019-01-16 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Tuesday, January 15, 2019 7:03 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] BaseTools: Remove EDK_SOURCE keyword from ECC Tool > >BZ:

Re: [edk2] EmulatorPkg build issue with macOS mojave and Xcode 10

2019-01-16 Thread 唐佳诚
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1471 Thanks ChasonTang -- Original --From: "唐佳诚";Date: Thu, Jan 17, 2019 11:25 AMTo: "Gao, Liming"; "edk2-devel"; Subject: Re:RE: [edk2] EmulatorPkg build issue with macOS mojave and Xcode 10 Hi, I

Re: [edk2] EmulatorPkg build issue with macOS mojave and Xcode 10

2019-01-16 Thread Gao, Liming
Hi, NO_MSABI_VA_FUNCS flag is required. I miss to add it. I don't verify its boot. If you have any finding, please reply the mail. Thanks Liming >-Original Message- >From: 唐佳诚 [mailto:chasont...@warmbloom.com] >Sent: Thursday, January 17, 2019 11:45 AM >To: Gao, Liming ; edk2-devel

Re: [edk2] [edk2-platforms PATCH] MinPlatformPkg: Use merged variable driver for emulated NV mode

2019-01-16 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki -Original Message- From: Zeng, Star Sent: Wednesday, January 16, 2019 2:25 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Kubacki, Michael A ; Yao, Jiewen Subject: [edk2-platforms PATCH] MinPlatformPkg: Use merged variable driver for emulated NV mode

[edk2] [PATCH v1 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check.

2019-01-16 Thread Jiaxin Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1469 Since the value of Instance is retrieved from the list Entry, it can't be the NULL pointer, so just remove the unnecessary check. Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Hao A Cc: Gao Liming Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH v1 2/3] NetworkPkg/IScsiDxe: Remove unnecessary NULL pointer check.

2019-01-16 Thread Jiaxin Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1469 Since the value of AttemptConfigData is retrieved from the list Entry, it can't be the NULL pointer, so just remove the unnecessary check. Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Hao A Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH v1 3/3] NetworkPkg/DnsDxe: Remove unnecessary NULL pointer check.

2019-01-16 Thread Jiaxin Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1469 Since the value of ItemCache4/ItemCache6 is retrieved from the list Entry, it can't be the NULL pointer, so just remove the unnecessary check. Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Hao A Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH v1 0/3] Remove unnecessary NULL pointer check.

2019-01-16 Thread Jiaxin Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1469 Since the value retrieved from the list Entry can't be the NULL pointer, the unnecessary check can be removed. Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Hao A Cc: Gao Liming Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2] [Patch V2] BaseTools: Remove EDK_SOURCE keyword from GenFds tool.

2019-01-16 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Feng, Bob C >Sent: Tuesday, January 15, 2019 7:56 PM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [edk2] [Patch V2] BaseTools: Remove EDK_SOURCE keyword from

Re: [edk2] [Patch V2] BaseTools: Remove EDK_SOURCE keyword from Inf Parser.

2019-01-16 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Feng, Bob C >Sent: Tuesday, January 15, 2019 7:57 PM >To: edk2-devel@lists.01.org >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch V2] BaseTools: Remove EDK_SOURCE keyword from Inf Parser. > >BZ:

Re: [edk2] EmulatorPkg build issue with macOS mojave and Xcode 10

2019-01-16 Thread 唐佳诚
Hi, I clone your git repository and checkout XcodeEmulator branch, but failed with some error. The following are the error messages. > source ./edksetup.sh > cd EmulatorPkg > ./build.sh Building from: /Users/QianYun/Downloads/edk2 using prebuilt tools 'import sitecustomize' failed; use -v for

Re: [edk2] [Patch v2] BaseTools: Fix incorrect formatting of GenFds command dictionary

2019-01-16 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Felix Polyudov [mailto:fel...@ami.com] Sent: Thursday, January 17, 2019 12:51 AM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [Patch v2] BaseTools: Fix incorrect formatting of GenFds command

[edk2] [PATCH] MinPlatformPkg: Correct typo in INF

2019-01-16 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1468 SiliconPolicyInitLibNull.inf and SiliconPolicyUpdateLibNull.inf both had wrong BASE_NAME and LIBRARY_CLASS, so correct them to align with file naming and the purpose. Cc: Michael A Kubacki Cc: Jiewen Yao Contributed-under: TianoCore

Re: [edk2] [PATCH V2 10/15] ArmVirtXen: Use merged variable driver for emulated NV mode

2019-01-16 Thread Zeng, Star
On 2019/1/16 22:26, Julien Grall wrote: Hi Laszlo, On 15/01/2019 09:37, Laszlo Ersek wrote: On 01/14/19 16:19, Star Zeng wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. The real variable driver has been updated to support emulated

[edk2] [PATCH 2/2] MdePkg/UefiGpt.h: Add new definition for enable GPT support

2019-01-16 Thread Chen A Chen
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1470 This two new definitions are defined for GPT in FatPei diver. Cc: Liming Gao Cc: Michael D Kinney Cc: Zhang Chao B Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chen A Chen --- MdePkg/Include/Uefi/UefiGpt.h | 16

[edk2] [PATCH 1/2] FatPkg: Break down Part.c file.

2019-01-16 Thread Chen A Chen
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1470 Break down partition parsing logic to 2 parts, Eltorito and MBR. Cc: Ruiyu Ni Cc: Zhang Chao B Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Chen A Chen --- FatPkg/FatPei/Eltorito.c | 239

Re: [edk2] [PATCH] MinPlatformPkg: Correct typo in INF

2019-01-16 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki -Original Message- From: Chiu, Chasel Sent: Wednesday, January 16, 2019 4:11 PM To: edk2-devel@lists.01.org Cc: Kubacki, Michael A ; Yao, Jiewen ; Chiu, Chasel Subject: [PATCH] MinPlatformPkg: Correct typo in INF REF:

Re: [edk2] [PATCH v2 04/17] Vlv2TbltDevicePkg: add MmServicesTableLib resolution

2019-01-16 Thread Qian, Yi
Reviewed-by: Qian Yi Thanks Qian Yi > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, January 17, 2019 1:45 AM > To: Gao, Liming ; Qian, Yi > Cc: edk2-devel@lists.01.org; Sun, Zailiang ; Laszlo > Ersek ; Leif Lindholm ; > Kinney, Michael D

[edk2] [PATCH] MdePkg/UefiDebugLibStdErr: Modify supported type.

2019-01-16 Thread Jiansong Xu
From: jiansonx BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1416 Remove DXE_RUNTIME_DRIVER and DXE_SMM_DRIVER type from the supported module type list in the library INF file. Then, these library instances don't support DXE_RUNTIME_DRIVER and DXE_SMM_DRIVER type any more.

[edk2] [PATCH] MdePkg/UefiDebugLibDebugPortProtocol: Modify supported type.

2019-01-16 Thread Jiansong Xu
From: jiansonx BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1416 Remove DXE_RUNTIME_DRIVER and DXE_SMM_DRIVER type from the supported module type list in the library INF file. Then, these library instances don't support DXE_RUNTIME_DRIVER and DXE_SMM_DRIVER type any more.

Re: [edk2] [PATCH] BaseTools:Evaluation of undefined macros in dsc files

2019-01-16 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Wednesday, January 16, 2019 2:56 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH] BaseTools:Evaluation of undefined macros in dsc files

Re: [edk2] [Patch v1 4/5] BaseTools/AutoGen: move functions

2019-01-16 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Carsey, Jaben Sent: Friday, January 11, 2019 2:40 AM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Gao, Liming Subject: [Patch v1 4/5] BaseTools/AutoGen: move functions Move SplitOption and ConvertStringToByteArray from Common.Misc to

[edk2] [PATCH v2] MinPlatformPkg: Support TCO base locked by FSP

2019-01-16 Thread Chasel, Chiu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1457 Per security recommendation TCO Base should be initialized and locked by FSP and MinPlatform should support both TCO Base locked and not locked scenarios. Cc: Michael A Kubacki Cc: Jiewen Yao Contributed-under: TianoCore Contribution

Re: [edk2] [PATCH] BaseTools:build break if the Path contains SingleFile.Ext

2019-01-16 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Tuesday, January 15, 2019 5:13 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH] BaseTools:build break if the Path contains SingleFile.Ext

Re: [edk2] [PATCH V2] BaseTools:Build fail when PCD use in the [DEPEX] section of INF files

2019-01-16 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Tuesday, January 15, 2019 5:11 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH V2] BaseTools:Build fail when PCD use in the [DEPEX] section of INF files Update _FixedPcdVoidTypeDict to

Re: [edk2] [PATCH] BaseTools:The BuildOptionPcd value is wrong

2019-01-16 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Tuesday, January 15, 2019 5:14 PM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Feng, Bob C Subject: [edk2][PATCH] BaseTools:The BuildOptionPcd value is wrong In GenFds.py, Due to the second assignment, the value is

Re: [edk2] [Patch v1 2/5] BaseTools/Workspace/InfBuildData: move functions

2019-01-16 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Carsey, Jaben Sent: Friday, January 11, 2019 2:40 AM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Gao, Liming Subject: [Patch v1 2/5] BaseTools/Workspace/InfBuildData: move functions Move ProtocolValue and PpiValue from Common.Misc to

Re: [edk2] [Patch v1 1/5] BaseTools/build/build: refactor and move functions

2019-01-16 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Carsey, Jaben Sent: Friday, January 11, 2019 2:40 AM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Gao, Liming Subject: [Patch v1 1/5] BaseTools/build/build: refactor and move functions Move DataDump and DataRestore from Common.Misc to

Re: [edk2] [Patch v1 3/5] BaseTools/DscBuildData: move function

2019-01-16 Thread Feng, Bob C
Reviewed-by: Bob Feng -Original Message- From: Carsey, Jaben Sent: Friday, January 11, 2019 2:40 AM To: edk2-devel@lists.01.org Cc: Feng, Bob C ; Gao, Liming Subject: [Patch v1 3/5] BaseTools/DscBuildData: move function Move IsFieldValuieAnArray from Common.Misc to this file. There

[edk2] [PATCH] MdePkg/UefiDebugLibConOut: Modify supported type.

2019-01-16 Thread Jiansong Xu
From: jiansonx BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1416 Remove DXE_RUNTIME_DRIVER and DXE_SMM_DRIVER type from the supported module type list in the library INF file. Then, these library instances don't support DXE_RUNTIME_DRIVER and DXE_SMM_DRIVER type any more.

[edk2] [edk2-platforms PATCH] MinPlatformPkg: Use merged variable driver for emulated NV mode

2019-01-16 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. The real variable driver has been updated to support emulated variable NV mode and the EmuVariableRuntimeDxe will be removed later, so use merged variable driver for emulated NV mode. Cc: Michael

[edk2] [edk2-platforms PATCH] Platform HiKeyXXX: Use merged variable driver for emulated NV mode

2019-01-16 Thread Star Zeng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 Merge EmuVariable and Real variable driver. The real variable driver has been updated to support emulated variable NV mode and the EmuVariableRuntimeDxe will be removed later, so use merged variable driver for emulated NV mode. NOTE:

[edk2] [edk2-platforms PATCH] Platform D03/D05: Remove EmuVariableRuntimeDxe including

2019-01-16 Thread Star Zeng
For https://bugzilla.tianocore.org/show_bug.cgi?id=1323, EmuVariable will be merged to real variable driver, and EmuVariableRuntimeDxe will be removed finally. As D03 and D05 are using the real variable driver VariableRuntimeDxe, this patch removes EmuVariableRuntimeDxe including in D03.dsc and

Re: [edk2] [PATCH v1 1/2] MdeModulePkg/NetLib.h: Fix the possible NULL pointer dereference issue.

2019-01-16 Thread Wu, Jiaxin
Hi Laszlo, Thanks review the patch. > > (1) The linked list from BaseLib (LIST_ENTRY) always has at least one > element (the head element), and the list is empty if the head element > points back to itself. In other words, ForwardLink may never be NULL. > > So why is it necessary to check

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Match the nested partitions

2019-01-16 Thread Laszlo Ersek
On 01/16/19 03:16, Gary Lin wrote: > On Tue, Jan 15, 2019 at 12:58:10PM +0100, Laszlo Ersek wrote: >> On 01/15/19 10:45, Gary Lin wrote: >>> In some cases, such as MD RAID1 in Linux, the bootloader may be in a >>> nested EFI system partition partition. For example, sda1 and sdb1 are >>> combined