Re: [edk2] [PATCH 1/1] BaseTools: sync BaseTools from main trunk r18579.

2015-12-02 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Mike Maslenkin Sent: Wednesday, December 02, 2015 11:17 PM To: edk2-de...@ml01.01.org Cc: Fan, Jeff Subject: [edk2] [PATCH 1/1] BaseTools: sync

Re: [edk2] MdePkg: DebugAssert enhancement

2015-12-02 Thread Anbazhagan, Baraneedharan
Thanks. Will send a separate patch for those packages. > -Original Message- > From: Gao, Liming [mailto:liming@intel.com] > Sent: Tuesday, December 01, 2015 6:32 PM > To: Anbazhagan, Baraneedharan; edk2-devel@lists.01.org; Carsey, Jaben; Kinney, > Michael D > Subject: RE: MdePkg:

[edk2] IntelFrameworkModulePkg: DebugAssert enhancement

2015-12-02 Thread Anbazhagan, Baraneedharan
If the assert happens in a library, then it's hard to determine which module using that library is generating that assert. Use gEfiCallerBaseName in DebugAssert to display the module name. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Baraneedharan Anbazhagan

[edk2] [PATCH 1/1] BaseTools: sync BaseTools from main trunk r18579.

2015-12-02 Thread Mike Maslenkin
This patch fixes incomplete merge of multiple workspaces support. Without this patch build fails with error similar to: ~/sources/edk2> build -p MdePkg/MdePkg.dsc -t GCC48 -a X64 Build environment: Linux-3.16.7-24-desktop-x86_64-with-SuSE-13.2-x86_64 Build start time: 17:15:43, Dec.02 2015

[edk2] [PATCH v3 2/3] BaseTools/GenFw RVCT: fix relocation processing of PT_DYNAMIC sections

2015-12-02 Thread Ard Biesheuvel
Unlike GNU ld, which can be instructed to emit symbol based static relocations into fully linked binaries using the --emit-relocs command line switch, the RVCT armlink tool can only emit dynamic relocations into the PT_DYNAMIC segment. This has two consequences . we can only identify absolute

[edk2] [PATCH v3 1/3] BaseTools RVCT: use scatter file to enforce minimum section alignment

2015-12-02 Thread Ard Biesheuvel
Up until SVN r18540, GenFw created invalid PE/COFF binaries for the ARM architecture, by allowing PE/COFF .data sections to appear at offsets that were not aligned to the global PE/COFF section alignment. The reason for this was that the relocation metadata emitted by RVCT's armlink only contains

Re: [edk2] [PATCH 2/3] ArmPkg: create RVCT assembler macro to centralize EXPORT, AREA, and function label definition

2015-12-02 Thread Ard Biesheuvel
On 25 November 2015 at 20:08, Cohen, Eugene wrote: > In response to Leifs request earlier, this adds a new RVCT assembler macro to > centralize the exporting of assembly functions including the EXPORT directive > (so the linker can see it), the AREA directive (so it's in its own

Re: [edk2] [PATCH 1/3] BaseTools: add include for AutoGen.h when invoking the preprocessor with RVCT

2015-12-02 Thread Ard Biesheuvel
On 25 November 2015 at 20:06, Cohen, Eugene wrote: > Ensure that AutoGen.h is force-included when the RVCT preprocessor is invoked. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Eugene Cohen Reviewed-by: Ard Biesheuvel

Re: [edk2] [PATCH 3/3] ArmPkg: update RVCT assembly functions to use new RVCT_ASM_EXPORT macro

2015-12-02 Thread Ard Biesheuvel
On 25 November 2015 at 20:11, Cohen, Eugene wrote: > This has the effect of splitting assembly functions into their own sections > so the linker can remove unused ones to save space. > > This has been tested to build with ArmPkg.dsc with RVCT 4. > > The majority of the conversion

[edk2] asm/S assembler files

2015-12-02 Thread Michael Zimmermann
Hi, sorry if this is documented somewhere but I've always wondered what this whole assembler file situation in EDKII is about. What I mean is that there are two versions of every assembler file - for VS and GCC compilers I guess. What I've noticed though is that most of these files are almost

Re: [edk2] [PATCH 4/5] ShellPkg: add missing SHELL_STATUS cast

2015-12-02 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Wednesday, December 02, 2015 9:03 AM > To: edk2-devel@lists.01.org; ler...@redhat.com; Gao, Liming > ; Zhang, Chao B

Re: [edk2] asm/S assembler files

2015-12-02 Thread Andrew Fish
> On Dec 2, 2015, at 8:44 AM, Michael Zimmermann > wrote: > > Hi, > > sorry if this is documented somewhere but I've always wondered what this > whole assembler file situation in EDKII is about. > What I mean is that there are two versions of every assembler file -

Re: [edk2] asm/S assembler files

2015-12-02 Thread Michael Zimmermann
Does NASM support ARM and AARCH64? because according to Wikipedia it doesn't. > Not sure why the Vlv2TbltDevicePkg needed to add that assembly code? I would also point out that the inline assembly will optimize better as the compiler will always call the .S function, but the optimizer can inline

Re: [edk2] asm/S assembler files

2015-12-02 Thread Laszlo Ersek
On 12/02/15 18:37, Michael Zimmermann wrote: > Does NASM support ARM and AARCH64? because according to Wikipedia it > doesn't. It doesn't. But, I believe -- I could be wrong -- that for ARM/AARCH64 the assembly syntax has been uniquely determined anyway. (If this is not the case, I hope I'll be

Re: [edk2] Where do I find the system table address for an EFI app ?

2015-12-02 Thread Carsey, Jaben
I am pretty sure it’s there in a shell app also. What entry point lib are you using to build your app? -Jaben From: Shubha Ramani [mailto:shubharam...@yahoo.com] Sent: Wednesday, December 02, 2015 9:11 AM To: Carsey, Jaben ; edk2-devel@lists.01.org Subject: Re: [edk2]

Re: [edk2] Could not add PCI device with big memory to aarch64 VMs

2015-12-02 Thread liang yan
Hi, Laszlo, On 11/30/2015 06:45 PM, Laszlo Ersek wrote: On 12/01/15 01:46, liang yan wrote: Hello, Laszlo, On 11/30/2015 03:05 PM, Laszlo Ersek wrote: [snip] If you need more room (with large alignments), then there's no way around supporting QEMU's 64 bit aperture, VIRT_PCIE_MMIO_HIGH

Re: [edk2] [Patch] ShellPkg: Fix wrong return status for Ifconfig.c

2015-12-02 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiaxin Wu > Sent: Wednesday, December 02, 2015 12:54 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ye, Ting

Re: [edk2] Could not add PCI device with big memory to aarch64 VMs

2015-12-02 Thread Laszlo Ersek
On 12/02/15 18:28, liang yan wrote: > Hi, Laszlo, > > On 11/30/2015 06:45 PM, Laszlo Ersek wrote: >> On 12/01/15 01:46, liang yan wrote: >>> Hello, Laszlo, >>> >>> On 11/30/2015 03:05 PM, Laszlo Ersek wrote: >> [snip] >> If you need more room (with large alignments), then there's no way

Re: [edk2] [Patch 2/2] ShellPkg/mm: Fix mm to support multiple root bridge platform

2015-12-02 Thread Carsey, Jaben
I propose to rev the version of the library + 0.1 in the INF file? Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Tuesday, December 01, 2015 9:54 PM > To:

Re: [edk2] asm/S assembler files

2015-12-02 Thread Andrew Fish
> On Dec 2, 2015, at 9:37 AM, Michael Zimmermann > wrote: > > Does NASM support ARM and AARCH64? because according to Wikipedia it doesn't. > > > Not sure why the Vlv2TbltDevicePkg needed to add that assembly code? I > > would also point out that the inline assembly

Re: [edk2] [PATCH 5/5] ArmVirtPkg: use explicit KERNEL_BLOB_TYPE cast

2015-12-02 Thread Laszlo Ersek
On 12/02/15 18:02, Ard Biesheuvel wrote: > The ARM RVCT compiler does not allow implicit casts between enumerated > types and integer types. In this particular case, the STUB_FILE::Position > member is overloaded as a KERNEL_BLOB_TYPE identifier, so it does not > hurt to make that cast explicit. >

[edk2] [PATCH 2/5] MdeModulePkg: remove unreachable code

2015-12-02 Thread Ard Biesheuvel
Some compilers (like RVCT) are finicky about unreachable code, so remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c | 3 ---

[edk2] [PATCH 1/5] IntelFrameworkModulePkg: remove unreachable code

2015-12-02 Thread Ard Biesheuvel
Some compilers (like RVCT) are finicky about unreachable code, so remove it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- IntelFrameworkModulePkg/Library/GenericBdsLib/BdsConsole.c | 1 - 1 file changed, 1 deletion(-) diff

[edk2] [PATCH 4/5] ShellPkg: add missing SHELL_STATUS cast

2015-12-02 Thread Ard Biesheuvel
The prototype of ShellCommandRunIfconfig() indicates that it returns a SHELL_STATUS, so returning a EFI_STATUS requires an explicit cast. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH 3/5] SecurityPkg: put missing empty lines at the end of some header files

2015-12-02 Thread Ard Biesheuvel
Some compilers (like RVCT) reject input files that do not end in a newline. So add missing newlines to some SecurityPkg header files. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH 5/5] ArmVirtPkg: use explicit KERNEL_BLOB_TYPE cast

2015-12-02 Thread Ard Biesheuvel
The ARM RVCT compiler does not allow implicit casts between enumerated types and integer types. In this particular case, the STUB_FILE::Position member is overloaded as a KERNEL_BLOB_TYPE identifier, so it does not hurt to make that cast explicit. Contributed-under: TianoCore Contribution

Re: [edk2] EDK2 and VS2015

2015-12-02 Thread Andrew Fish
> On Dec 2, 2015, at 11:47 AM, Foster, Matthew I > wrote: > > Does anyone have any information about compiling EDK2 using Visual Studio > 2015? Is it supported? Liming proposed a patch to the mailing list on 11/30/2105 to support VS2015. You can try applying

Re: [edk2] asm/S assembler files

2015-12-02 Thread Ard Biesheuvel
On 2 December 2015 at 19:50, Michael Zimmermann wrote: >> But, I believe -- I could be wrong -- that for ARM/AARCH64 the assembly >> syntax has been uniquely determined anyway. (If this is not the case, I >> hope I'll be corrected.) > > Unfortunately not. From

[edk2] EDK2 and VS2015

2015-12-02 Thread Foster, Matthew I
Does anyone have any information about compiling EDK2 using Visual Studio 2015? Is it supported? ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch 0/2] Fix Shell mm command bugs

2015-12-02 Thread Carsey, Jaben
For the series (I made a tiny comment on the INF in the other patch email) Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Tuesday, December 01, 2015 9:54 PM > To:

Re: [edk2] asm/S assembler files

2015-12-02 Thread Michael Zimmermann
> But, I believe -- I could be wrong -- that for ARM/AARCH64 the assembly > syntax has been uniquely determined anyway. (If this is not the case, I > hope I'll be corrected.) Unfortunately not. From ArmPlatformPkg/PrePi/Arm/ to ./Library/ArmLib - there are always both asm and S files. On Wed,

Re: [edk2] [PATCH 3/3] ArmPkg: update RVCT assembly functions to use new RVCT_ASM_EXPORT macro

2015-12-02 Thread Cohen, Eugene
Ard, I just ran into this as well yesterday - I agree that the solution here is to back out the changes from the ExceptionSupport assembly or even the entire CpuDxe driver. The benefit here is for libraries containing unrelated functions and this case is neither a library (it's a driver) nor

[edk2] [Patch] BaseTools: Enhance GenFv Tool to report error message

2015-12-02 Thread Yonghong Zhu
When two vtf files in one FV image, no FV file can be generated, but it report the stack trace info. so we enhance the tool to report error message directly but not the stack trace info. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu

[edk2] [Patch] BaseTools: process the files by the priority in BUILDRULEORDER

2015-12-02 Thread Yonghong Zhu
By the BUILDRULEORDER feature to process files listed in INF [Sources] sections in priority order, if a filename is listed with multiple extensions, the tools will use only the file that matches the first extension in the space separated list. Contributed-under: TianoCore Contribution Agreement

[edk2] [Patch] BaseTools: Fix a bug in the VPD report generation

2015-12-02 Thread Yonghong Zhu
Changed the if condition to check whether current Region is FD VPD region to fix a bug in the VPD report generation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- Source/Python/build/BuildReport.py | 6 +++--- 1 file changed, 3

[edk2] [Patch] ShellPkg: Fix wrong return status for Ifconfig.c

2015-12-02 Thread Jiaxin Wu
The Ifconfig command handler tries to return an EFI_STATUS when the return type should be SHELL_STATUS. Cc: Cohen, Eugene Cc: Carsey, Jaben Cc: Ye Ting Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu

Re: [edk2] [PATCH 1/3] BaseTools/Scripts: Add ConvertUtf16ToUtf8.py script

2015-12-02 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jordan Justen > Sent: Wednesday, December 02, 2015 2:17 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Justen,

[edk2] [PATCH 1/3] BaseTools/Scripts: Add ConvertUtf16ToUtf8.py script

2015-12-02 Thread Jordan Justen
This script uses python codecs to convert .uni string files from utf-16 to utf-8. The advantages of utf-8 data: * Generally smaller files * More commonly supported by editors * Not treated as binary data in patch files Cc: Yonghong Zhu Cc: Liming Gao

[edk2] [PATCH 3/3] MdePkg: Example diff with utf-8 data

2015-12-02 Thread Jordan Justen
This patch is not intended to be checked in. Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen --- MdePkg/MdePkg.uni | 5 + 1 file changed, 5 insertions(+) diff --git a/MdePkg/MdePkg.uni

[edk2] [PATCH 2/3] MdePkg: Convert all .uni files to utf-8

2015-12-02 Thread Jordan Justen
To convert these files I ran: $ python3 BaseTools/Scripts/ConvertUtf16ToUtf8.py MdePkg Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jordan Justen ---

Re: [edk2] [PATCH 1/3] BaseTools/Scripts: Add ConvertUtf16ToUtf8.py script

2015-12-02 Thread Jordan Justen
On 2015-12-02 15:30:42, Kinney, Michael D wrote: > Jordan, > > Do the UTF-8 files generated include a BOM? https://en.wikipedia.org/wiki/Byte_order_mark#UTF-8 "The UTF-8 representation of the BOM is the byte sequence 0xEF,0xBB,0xBF." ... "The Unicode Standard permits the BOM in UTF-8, but

Re: [edk2] [Patch 2/2] ShellPkg/mm: Fix mm to support multiple root bridge platform

2015-12-02 Thread Ni, Ruiyu
Jaben, you mean to change VERSION_STRING = 1.0 to VERSION_STRING = 1.1 ? Regards, Ray -Original Message- From: Carsey, Jaben Sent: Thursday, December 3, 2015 1:27 AM To: Ni, Ruiyu ; edk2-devel@lists.01.org Cc: Ni, Ruiyu

Re: [edk2] [PATCH] MdeModulePkg: allow DxeIpl to load without permanent memory to enable S3 resume from temporary memory

2015-12-02 Thread Zeng, Star
On 2015/12/3 2:58, Cohen, Eugene wrote: Star, Do you have the patch tested on your real platforms (with and without InstallPeiMemory()? Yes, we've been running this way for a couple years. I had it on my list of changes to upstream and forgot about it until now. The only other requirement

Re: [edk2] ifconfig command issue in edk2

2015-12-02 Thread Wu, Jiaxin
Hi Shaveta, Thanks for your finding, we have rootcause the hang issue in ifconfig , and will fix it as soon as possible. Thanks. Jiaxin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ye, Ting Sent: Wednesday, December 2, 2015 9:21 AM To: Leekha

[edk2] [PATCH] ShellPkg: Make 'dh' support showing all spec defined protocols.

2015-12-02 Thread Qiu Shumin
When using 'dh' to dump all protocols installed on a handle, some of them are shown as 'UnknownDevice'. Device patch make 'dh' support all spec defined protocols. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jaben Carsey Reviewed-by: Qiu Shumin

Re: [edk2] [Patch 1/2] MdeModulePkg: Add PciSioSerialDxe driver

2015-12-02 Thread Tian, Feng
Suggest to use UINT64 for Offset field to be consistent with PciIo protocol definition. Others look good to me Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, Ruiyu Sent: Monday,

[edk2] [Patch 0/6] Fix VS2015 warnings in EDKII packages.

2015-12-02 Thread Liming Gao
VS2015 reports the following warnings in EDKII codes. 1) warning C4701: potentially uninitialized local variable used. 2) warning C4703: potentially uninitialized local pointer variable used. 3) warning C4459: declaration of 'PrivateData' hides global declaration. 4) warning C4456: declaration

[edk2] [Patch 1/6] MdePkg: Disable VS2015 warning C4701 & C4703

2015-12-02 Thread Liming Gao
C4701 & C4703 may cause false positive issues. They have been disabled in VS2013. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdePkg/Include/Ia32/ProcessorBind.h | 6 +++--- MdePkg/Include/X64/ProcessorBind.h | 6 +++--- 2 files

[edk2] [Patch 3/6] MdeModulePkg: Fix VS2015 warning C4456 in RegularExpressionDxe

2015-12-02 Thread Liming Gao
warning C4456: declaration of 'q' hides previous local declaration. Update code to use the different local variable name. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao Cc: El-Haj-Mahmoud Samer ---

[edk2] [Patch 2/6] MdeModulePkg: Fix VS2015 warning C4459 in DriverSampleDxe

2015-12-02 Thread Liming Gao
warning C4459: declaration of 'PrivateData' hides global declaration. Update DriverSampleDxe to rename global variable name to be different. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- .../Universal/DriverSampleDxe/DriverSample.c

[edk2] [Patch 4/6] MdeModulePkg: Fix VS2015 warning C4311 & C4312 in RegularExpressionDxe

2015-12-02 Thread Liming Gao
warning C4311: pointer truncation from 'void *' to 'unsigned long' warning C4312: conversion from 'unsigned long' to 'void *' of greater size Update code to convert type to UINTN first, then convert it to other type. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming

[edk2] [Patch 6/6] OvmfPkg: Fix VS2015 warning C4459 in XenBusDxe

2015-12-02 Thread Liming Gao
warning C4459: declaration of 'xs' hides global declaration. Update code to rename local variable xs to xsp to be different. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao Cc: Justen Jordan ---

Re: [edk2] Where do I find the system table address for an EFI app ?

2015-12-02 Thread Kinney, Michael D
Shubha, You can run the dmem command from the UEFI shell with no parameters, and it will show the UFI System Table address along with other standard table addresses. Shell> dmem Memory Address 0FD6E010 200 Bytes 0FD6E010: 49 42 49 20 53 59 53 54-32 00 02 00 48 00 00 00 *IBI

[edk2] [PATCH] ShellPkg: Refine the code to reduce time cost of 'map -r'

2015-12-02 Thread Qiu Shumin
In some platform 'map -r' may cost more than 1 min. This patch filter the target handles by BlockIO and SimpleFileSystem protocol to reduce the time cost. Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin

Re: [edk2] [PATCH 1/1] BaseTools: sync BaseTools from main trunk r18579.

2015-12-02 Thread Fan, Jeff
Thanks. My compare tool skipped the build directory. I think I need to use git to sync all patches. :-) Reviewed-By: Jeff Fan -Original Message- From: Mike Maslenkin [mailto:mike.maslen...@gmail.com] Sent: Wednesday, December 02, 2015 11:17 PM To:

Re: [edk2] ifconfig command issue in edk2

2015-12-02 Thread Leekha Shaveta
Thanks Jiaxin! Shell> ifconfig -s eth0 static 192.168.112 ifconfig -s eth0 static Shell> 192.169 con 'con' is not recognized as an internal or external command, operable program, or script file. These were actually not the issues. I have just quoted some examples, where we give incomplete

Re: [edk2] [Patch] MdePkg: Add Ipmi2.0 definitions head file.

2015-12-02 Thread Yao, Jiewen
Thanks. Reviewed-by: jiewen@intel.com -Original Message- From: Bu, Daocheng Sent: Wednesday, December 02, 2015 4:01 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: [Patch] MdePkg: Add Ipmi2.0 definitions head file. Add Ipmi2.0 definitions head file based on Ipmi category:

Re: [edk2] [Patch 5/6] CryptoPkg: Disable VS2015 warning C4311 in OpensslLib

2015-12-02 Thread Long, Qin
Looks good. Reviewed-by: Qin Long Best Regards & Thanks, LONG, Qin > -Original Message- > From: Gao, Liming > Sent: Thursday, December 03, 2015 1:27 PM > To: edk2-devel@lists.01.org > Cc: Long, Qin > Subject: [Patch 5/6] CryptoPkg: Disable VS2015 warning C4311 in

Re: [edk2] [PATCH] ShellPkg: Make 'dh' support showing all spec defined protocols.

2015-12-02 Thread El-Haj-Mahmoud, Samer
Reviewed-By: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu Shumin Sent: Wednesday, December 2, 2015 9:25 PM To: edk2-devel@lists.01.org Cc: Jaben Carsey ; Qiu

Re: [edk2] EDK2 and VS2015

2015-12-02 Thread Gao, Liming
Foster: VS2015 tool chain has been added into BaseTools\Conf\tools_def.template. You can pull the latest EDKII to get it. And, I also send the patch to fix VS2015 warnings in EDKII packages. Please apply them, then do VS2015 build. Thanks Liming -Original Message- From:

[edk2] [PATCH V2 1/2] SecurityPkg: AuthVariableLib: Customized SecureBoot Mode transition. Implement Customized SecureBoot Mode transition logic according to Mantis 1263, including AuditMode/DeployedM

2015-12-02 Thread Zhang, Chao B
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang, Chao --- SecurityPkg/Library/AuthVariableLib/AuthService.c | 1404 +--- .../Library/AuthVariableLib/AuthServiceInternal.h | 73 +

Re: [edk2] [Patch 3/6] MdeModulePkg: Fix VS2015 warning C4456 in RegularExpressionDxe

2015-12-02 Thread El-Haj-Mahmoud, Samer
I only reviewed this patch, not the entire series Reviewed-By: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, December 2, 2015 11:27 PM To:

Re: [edk2] [PATCH 4/5] SecurityPkg: Enable Customized Secure Boot feature

2015-12-02 Thread Zhang, Chao B
Star & Qin: Thanks a lot for your comments. I agree with 1 - 8 & will provide updated patch. For item 9, SecureBootEnble variable is not in Customized Secure Boot Mode transition scope. I prefer revisit it after this patch Thanks & Best regards Chao Zhang -Original Message- From:

[edk2] [PATCH v2 1/4] MdePkg UefiScsiLib: Add non-blocking support for SCSI Read/Write command

2015-12-02 Thread Hao Wu
Four new functions are added to UefiScsiLib: ScsiRead10CommandEx ScsiWrite10CommandEx ScsiRead16CommandEx ScsiWrite16CommandEx They support both blocking and non-blocking SCSI Read/Write operation depending on the optional parameter 'Event' passed to those APIs. When 'Event' is NULL, these four

[edk2] [PATCH v2 3/4] MdeModulePkg UfsPassThruDxe: Add Non-blocking I/O Support

2015-12-02 Thread Hao Wu
Previously, UfsPassThruPassThru function does not handle the 'Event' parameter and blocking read/write operations are always executed. This commit enables non-blocking read/write feature for UFS devices. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu

[edk2] [PATCH v2 0/4] Add BlockIO2 support for UFS

2015-12-02 Thread Hao Wu
Compared with v1, the following modifications have been made: 1. ScsiDiskDxe/ScsiDisk.c - In function ScsiDiskNotify(), fix typo passing 'Request->InBuffer' to ScsiDiskAsyncWrite10/16(). It should be 'Request->OutBuffer' instead. 2. UfsPassThruDxe/UfsPassThru.c - Close the timer event which polls

[edk2] [PATCH v2 4/4] MdeModulePkg ScsiBusDxe: Fix caller event may nerver be signaled

2015-12-02 Thread Hao Wu
For function ScsiExecuteSCSICommand(), when the 'Event' parameter is not NULL but the target SCSI device does not support non-blocking I/O, it will execute a blocking I/O operation instead. However, after the SCSI operation is done, the 'Event' is not signaled to inform the caller.

[edk2] [PATCH v2 2/4] MdeModulePkg ScsiDiskDxe: Add BlockIO2 Support

2015-12-02 Thread Hao Wu
Together with EFI_BLOCK_IO_PROTOCOL, EFI_BLOCK_IO2_PROTOCOL is installed as well in ScsiDiskDxe. Block I/O 2 functions are implemented: Reset ReadBlocksEx WriteBlocksEx FlushBlocksEx Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu ---

[edk2] [PATCH V2 0/2] Customized Secure Boot implmentation

2015-12-02 Thread Zhang, Chao B
Implement Customized Secure Boot feature accordingt to Mantis 1263. Patch includes Customized Secure Boot Mode transition, Secure Boot UI update and ImageVerificationLib logic update in AuditMode. https://mantis.uefi.org/mantis/view.php?id=1263 Zhang, Chao B (2): SecurityPkg:

Re: [edk2] [PATCH 1/3] BaseTools/Scripts: Add ConvertUtf16ToUtf8.py script

2015-12-02 Thread Kinney, Michael D
Jordan, Do the UTF-8 files generated include a BOM? Just in case someone depends on UNI files in UTF-16LE format, do you think it makes sense for this script to support conversion to from UTF-8 to UTF-16LE too? Or add a second script to that conversion? Thanks, Mike > -Original

Re: [edk2] [Patch] BaseTools: Enhance GenFv Tool to report error message

2015-12-02 Thread Laszlo Ersek
Meta-comment: when formatting a patch series with "git format-patch", please pass the "--numbered" and "--cover-letter" options to the utility. See also . (No need to resend this series just because of that, of course.) Thanks

Re: [edk2] [PATCH v2 3/3] ArmVirtPkg RVCT: build DXE_RUNTIME_DRIVER modules with 4 KB alignment

2015-12-02 Thread Laszlo Ersek
On 12/01/15 18:38, Ard Biesheuvel wrote: > This adds the RVCT armlink command line switches to build modules of type > DXE_RUNTIME_DRIVER with 4 KB PE/COFF section alignment, allowing the OS > to apply stricter permissions to the .text and .data sections. > > Contributed-under: TianoCore

Re: [edk2] [PATCH] MdeModulePkg: allow DxeIpl to load without permanent memory to enable S3 resume from temporary memory

2015-12-02 Thread Zeng, Star
Hi Eugene, On 2015/12/1 21:16, Cohen, Eugene wrote: This is a patch that enables the S3 Resume path from PEI without permanent memory installed. There is not a strict requirement that we can see to have permanent memory installed for S3 resume. We have platforms that hold PEI code (not

[edk2] [Patch] MdePkg: Add Ipmi2.0 definitions head file.

2015-12-02 Thread Daocheng Bu
Add Ipmi2.0 definitions head file based on Ipmi category: App, Storage and etc. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu CC: Jiewen Yao --- MdePkg/Include/IndustryStandard/Ipmi.h | 29 +

Re: [edk2] [PATCH 1/3] BaseTools/Scripts: Add ConvertUtf16ToUtf8.py script

2015-12-02 Thread Kinney, Michael D
Jordan, Good. I was hoping it did not add the BOM...because that would still be a binary file I think. I really appreciate you working on the reverse conversion. Mike > -Original Message- > From: Justen, Jordan L > Sent: Wednesday, December 2, 2015 4:25 PM > To: Kinney, Michael D

Re: [edk2] [PATCH] BaseTools PatchCheck.py: Support binary diff

2015-12-02 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jordan Justen Sent: Wednesday, December 02, 2015 8:24 AM To: edk2-devel@lists.01.org Cc: Justen, Jordan L; Gao, Liming Subject: [edk2] [PATCH]

Re: [edk2] [PATCH 1/5] IntelFrameworkModulePkg: remove unreachable code

2015-12-02 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, December 03, 2015 1:03 AM To: edk2-devel@lists.01.org; ler...@redhat.com; Gao, Liming; Zhang, Chao B; Carsey, Jaben; Qiu, Shumin; Fan, Jeff; Tian,

Re: [edk2] MdeModulePkg: DebugAssert enhancement

2015-12-02 Thread Gao, Liming
Baranee: Could you use CopyMem() to fill gEfiCallerBaseName instead of AsciiSPrint()? This library instance is for size optimization. So, it uses CopyMem() to fill FileName and Description. Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] MdeModulePkg: DebugAssert enhancement

2015-12-02 Thread Kinney, Michael D
Baranee, I also think the following line could be changed for smaller code gen from: + ModuleNameSize = AsciiStrLen("[") + AsciiStrLen (gEfiCallerBaseName) + AsciiStrLen("] "); To: + // + // Compute string size of module name enclosed by [] + // + ModuleNameSize = 2 + AsciiStrSize

Re: [edk2] [Patch] ShellPkg: Fix wrong return status for Ifconfig.c

2015-12-02 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Wednesday, December 02, 2015 4:54 PM To: edk2-devel@lists.01.org Cc: Carsey, Jaben; Ye, Ting; Cohen, Eugene Subject: [edk2] [Patch] ShellPkg:

Re: [edk2] [PATCH 2/5] MdeModulePkg: remove unreachable code

2015-12-02 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, December 03, 2015 1:03 AM To: edk2-devel@lists.01.org; ler...@redhat.com; Gao, Liming; Zhang, Chao B; Carsey, Jaben; Qiu, Shumin; Fan, Jeff; Tian,