Leif,
FYI, the char sign issue clang hit recently was due to mixing edk2 types with
standard C type. The edk2 type system does not assume that char is signed or
unsigned.
MdePkg/Include/X64/ProcessorBind.h
///
/// 1-byte unsigned value
///
typedef unsigned char UINT8;
///
///
On 03/19/16 02:15, David Woodhouse wrote:
> So we treat it as an opaque sequence of bytes on the way *in*, then
> make assumptions on the way *out* about what it was?
On the way in, it is assumed to be UTF-8, unless the user says
otherwise. If the user says otherwise (in i18n.commitencoding), tha
On 03/18/16 15:38, David Woodhouse wrote:
> On Tue, 2016-03-08 at 15:20 +0100, Laszlo Ersek wrote:
>> +UINT64 PciExBarBase;
> ...
>> if (mHostBridgeDevId == INTEL_Q35_MCH_DEVICE_ID) {
> ...
>> + PciExBarBase = FixedPcdGet64 (PcdPciExpressBaseAddress);
> ...
>> }
> ...
>> if
According to UEFI2.6, CapturePtr in the Captures array returned by
MatchString() should be separatedly allocated so that they can be freed by the
caller.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cecil Sheng
Reviewed-by: Samer El-Haj-Mahmoud
---
.../RegularExpress
Reviewed-by: Ruiyu Ni
>-Original Message-
>From: Zeng, Star
>Sent: Thursday, March 17, 2016 1:51 PM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu ; Tian, Feng
>Subject: [PATCH] MdeModulePkg PlatformVarCleanupLib: Locate VarCheck protocol
>when using
>
>Do not locate VarCheck protocol in
This is an emergency fix for UINT64 multiplications and divisions not
being done with the right BaseLib functions -- they break Ia32 builds.
Fixes: 30ed3422ab2de03abf7c1433ebb482f6e5e16f45
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
Notes:
This pat
Series Reviewed-by: Eugene Cohen
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf
> Of Ard Biesheuvel
> Sent: Wednesday, March 16, 2016 8:08 AM
> To: edk2-devel@lists.01.org; leif.lindh...@linaro.org
> Cc: Ard Biesheuvel
> Subject: [edk2] [PATCH
On 18/03/16 22:30, Laszlo Ersek wrote:
Unfortunately, I've run into a big issue: the DEBUG(()) macro. (To a
smaller extent, the ASSERT_EFI_ERROR() macro as well.) These macros
expand to the null replacement string when MDEPKG_NDEBUG is defined
(which is occasionally the case for RELEASE builds).
On 03/15/16 18:20, Kinney, Michael D wrote:
> David,
>
> Thanks for the suggestion. Today the git dev process requires a rebase.
> Given that this operation is transferring content from one community
> maintained feature branch in edk2-staging into edk2/master, I agree the
> option to use 'git p
I prefer UNUSED, like OPTIONAL key for parameter.
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Thursday, March 17, 2016 6:37 PM
To: Leif Lindholm ; Andrew Fish
Cc: Kinney, Michael D ; edk2-de...@ml01.01.org;
Gao, Liming
Subject: Re: [edk2] [RFC] Mde
Reviewed-by: Feng Tian
Thanks
Feng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Wednesday, March 16, 2016 9:10 PM
To: edk2-de...@ml01.01.org
Subject: [edk2] [COMMIT] MdeModulePkg: ConSplitterDxe: use U64 mult/div
wrappers
On Fri, 2016-03-18 at 13:30 +0100, Laszlo Ersek wrote:
>
> Our workflow should not be centered on github pull requests in any case,
> so I don't see the point in testing them out.
Well, thanks for destroying the test I spent this morning setting up,
because you don't believe it would have useful
Folks,
Here's the 3rd iteration based on your input. Please take one last opportunity
to review, we'll settle on this if there are no major requests by Friday of
this week.
Problem statement
=
Need place on tianocore.org where new features that are not ready for product
integr
On 03/18/2016 07:08 AM, Tian, Feng wrote:
> http://www.intel.com/technology/efi/agree_diskutil.htm
Hi,
Why the EULA for these Intel tools? Why aren't they BSD-licensed and
part of the UEFI Forum's EDK-II? Some IP of Microsoft FAT? Hasn't the
Microsoft FAT on-disk format IP since been published ye
Cc: Michael Kinney
Cc: Liming Gao
Cc: Feng Tian
Star Zeng (2):
MdeModulePkg DxeCore: Check Start consistently in CoreConvertPagesEx
MdeModulePkg DxeCore: Address boundary check for Type AllocateAddress
MdeModulePkg/Core/Dxe/Mem/Page.c | 25 +++--
1 file changed, 23 inse
Hi Long,
Thanks for your feedback.
Regarding to generated intrinsic by MSVC compiler, for example, using '=' to
assign a value to a variable bigger than UINTN, according to my experiments,
/Oi or /Oi- doesn't affect this
What /Oi affect is the intrinsic functions used in the source code.
Than
On 03/16/16 09:22, Zeng, Star wrote:
> Pushed at 30ed3422ab2de03abf7c1433ebb482f6e5e16f45.
>
> Thanks,
> Star
This patch breaks the Ia32 build of OVMF (found by Gerd's Jenkins auto-builder):
MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitterDxe/OUTPUT/ConSplitterDxe.lib(ConSplitter.obj):
When http boot download the second time without return
to the boot manager, the DHCP process will start twice
wiht the same Boot file uri and print the information twice
which we not expected. This is caused by wrong logic
of handling the device path of the boot file when loading it.
Cc: Fu Siyuan
On Fri, 2016-03-18 at 22:53 +0100, Laszlo Ersek wrote:
> It happens to display Michał's name correctly, because it fits in latin2.
Ah, OK. You got lucky on that one. Lots of names *don't* fit in
ISO8859-2.
> The extreme lengths that I had to go to were necessary to convince
> git-send-email not t
On Sat, 2016-03-19 at 01:55 +0100, Laszlo Ersek wrote:
>
> Okay, here's what I'll do. I will switch i18n.commitencoding back to
> UTF-8. And, I will add a commit-msg hook that converts the commit
> message in-place from latin2 to UTF-8, with "iconv". That should keep
> us both happy. Deal?
That s
On 03/18/16 22:13, David Woodhouse wrote:
> Rewriting it for this reason is *not* acceptable.
BTW I have no clue why not, if I keep your S-o-b in the first place, and
document the changes. In other projects maintainers rewrite
contributors' patches even, and (at best) credit the contributor with
VS2008 seems to think that the "PciExBarBase" variable (introduced in
commit 7b8fe63561b4) can be evaluated for the
AddReservedMemoryBaseSizeHob() function call with its value being
uninitialized / indeterminate. This is not the case (see
"mHostBridgeDevId"); suppress the warning.
Reported-by: Dav
On 03/18/16 17:26, Ard Biesheuvel wrote:
> On 18 March 2016 at 17:22, Laszlo Ersek wrote:
>> On 03/18/16 15:48, Gao, Liming wrote:
>>> Laszlo:
>>>
>>> I understand the request to BaseTools is that AutoGen code can pass
>>> GCC or MSFT compiler without any warning. If so, EDKII module can enable
Check for Type AllocateAddress,
if NumberOfPages is 0 or
if (NumberOfPages << EFI_PAGE_SHIFT) is above MAX_ADDRESS or
if (Start + NumberOfBytes) rolls over 0 or
if Start is above MAX_ADDRESS or
if End is above MAX_ADDRESS,
return EFI_NOT_FOUND.
Cc: Jiewen Yao
Cc: Michael Kinney
Cc: Liming Gao
C
V2:
[2/2] is updated to also handle invalid NumberOfPages.
Cc: Jiewen Yao
Cc: Michael Kinney
Cc: Liming Gao
Cc: Feng Tian
Star Zeng (2):
MdeModulePkg DxeCore: Check Start consistently in CoreConvertPagesEx
MdeModulePkg DxeCore: Address boundary check for Type AllocateAddress
MdeModulePkg
> On Mar 18, 2016, at 3:46 PM, Michael Brown wrote:
>
> On 18/03/16 22:30, Laszlo Ersek wrote:
>> Unfortunately, I've run into a big issue: the DEBUG(()) macro. (To a
>> smaller extent, the ASSERT_EFI_ERROR() macro as well.) These macros
>> expand to the null replacement string when MDEPKG_NDEBU
On 03/18/16 23:52, David Woodhouse wrote:
> On Fri, 2016-03-18 at 22:53 +0100, Laszlo Ersek wrote:
>> The extreme lengths that I had to go to were necessary to convince
>> git-send-email not to mess up Michał's CC in the email headers, picking
>> it up from the commit message. The commit message w
http://www.intel.com/technology/efi/agree_diskutil.htm
Thanks
Feng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Heyi Guo
Sent: Friday, March 18, 2016 6:23 PM
To: edk2-devel@lists.01.org
Subject: [edk2] Is there any exiting way in edk2 to format
> On Mar 18, 2016, at 5:13 PM, Laszlo Ersek wrote:
>
> On 03/19/16 00:27, Andrew Fish wrote:
>>
>>> On Mar 18, 2016, at 3:46 PM, Michael Brown wrote:
>>>
>>> On 18/03/16 22:30, Laszlo Ersek wrote:
Unfortunately, I've run into a big issue: the DEBUG(()) macro. (To a
smaller extent, t
On 03/18/2016 10:08 AM, Tian, Feng wrote:
> http://www.intel.com/technology/efi/agree_diskutil.htm
The .zip file that I eventually got from this is password-protected.
What's up with that? I can get a list of files, but most of them can't
be extracted. (Well, maybe with a zip file password-crackin
On 2016/3/17 10:02, Andrew Fish wrote:
On Mar 16, 2016, at 6:59 PM, Zeng, Star wrote:
On 2016/3/17 7:12, Andrew Fish wrote:
I was trying to move over to DxeDebugPrintErrorLevelLib, but I can't get it to
build
For example I made DXE use
DebugPrintErrorLevelLib|MdeModulePkg/Library/DxeDebug
> On Mar 18, 2016, at 7:29 AM, Gao, Liming wrote:
>
> Andrew:
> First, I suggest to enhance BaseTools to report the detail information on
> the constructor circle. Next, we can add comments in
> DxeDebugPrintErrorLevelLib library instance to note it can't be used together
> with DxeHobLib an
Bartosz:
MdePkg definition conforms to UEFI/PI and Industry specification. If it is
not in spec, it will not be added into MdePkg. For this case, it can locally be
added into OpenPlatformPkg. If you think it is valuable to be in PI spec, you
can contribute PI spec mantis to uefi.org.
Thanks
L
Some ISO images cannot be recognized properly when they are on media whose
block size is not 2048 bytes.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
---
MdeModulePkg/Universal/Disk/PartitionDxe/ElTorito.c | 12 ++--
1 file changed, 6 insertions(+), 6 del
Hi Star,
Thank you, I'll update the patch.
Sincerely,
Cecil Sheng
ISS Firmware Development
HPE Servers
-Original Message-
From: Zeng, Star [mailto:star.z...@intel.com]
Sent: Wednesday, March 16, 2016 5:04 PM
To: Sheng, Cecil (HPS SW) ; edk2-devel@lists.01.org
Cc: feng.t...@intel.com;
By default, the ARM architectures have unsigned chars, whereas the other
architectures supported by EDK2 by default have signed chars.
However, EDK2 uses -funsigned-chars on those architectures to change the
default behaviour.
Unfortunately, the ARM architectures explicitly break their default
beh
Change our resolution for the previously unused CpuExceptionHandlerLib
from the null implementation to the newly added implementation specific
to AARCH64 and ARM. This is needed since our CpuDxe will start using it
in a subsequent patch.
Contributed-under: TianoCore Contribution Agreement 1.0
Sign
In UEFI2.6, CapturePtr's in the Captures array returned by MatchString
are to be separatedly allocated so that they can be freed by the
caller.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Cecil Sheng
Reviewed-by: Samer El-Haj-Mahmoud
---
.../RegularExpressionDxe/Regul
On 03/17/16 13:34, Leif Lindholm wrote:
> On Thu, Mar 17, 2016 at 12:16:31PM +, Leif Lindholm wrote:
>> So, as further fallout from my -Weverything experiments, I've come
>> across this...
>>
>> Ia32 and X64 ProcessorBind.h (BaseTools and MdePkg) both define CHAR8 as
>> 'char'.
>> ARM and AArc
On 03/16/16 10:06, Ard Biesheuvel wrote:
> On 15 March 2016 at 14:17, Qiu Shumin wrote:
>> This patch makes Shell support -nonesting invocation option. This option
>> specifies that EFI_SHELL_PROTOCOL.Execute API nesting of a new Shell
>> instance is optional and dependent on the 'nonesting' Shell
Laszlo,
Yes! After I switched to a newer platform the system can boot to Shell very
well!
Thank you very much for your patient help.
Regards,
Ray
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Friday, March 18, 2016 3:02 PM
>To: Ni, Ruiyu
>Cc: Paolo Bonzini ;
> On Mar 18, 2016, at 2:31 PM, Blibbet wrote:
>
> On 03/18/2016 07:08 AM, Tian, Feng wrote:
>> http://www.intel.com/technology/efi/agree_diskutil.htm
>
> Hi,
>
> Why the EULA for these Intel tools?
Lee,
http://www.intel.com/technology/efi/agree_diskutil.htm
"FOR THE MICROSOFT EFI UTILITIES"
Inside the first zip there is a ReadMeFirst.txt file which contains the
password for the second zip.
On 03/18/2016 03:52 PM, Rod Smith wrote:
> On 03/18/2016 10:08 AM, Tian, Feng wrote:
>> http://www.intel.com/technology/efi/agree_diskutil.htm
> The .zip file that I eventually got from this is pas
It helps silence the same warning on VS2005 as well.
Reviewed-by: Jordan Justen
On 2016-03-18 16:35:24, Laszlo Ersek wrote:
> VS2008 seems to think that the "PciExBarBase" variable (introduced in
> commit 7b8fe63561b4) can be evaluated for the
> AddReservedMemoryBaseSizeHob() function call with
On Sat, 2016-03-19 at 00:35 +0100, Laszlo Ersek wrote:
> VS2008 seems to think that the "PciExBarBase" variable (introduced in
> commit 7b8fe63561b4) can be evaluated for the
> AddReservedMemoryBaseSizeHob() function call with its value being
> uninitialized / indeterminate. This is not the case (s
On Fri, 2016-03-18 at 23:26 +0100, Laszlo Ersek wrote:
>
> Whenever you contribute to a project, do you always start with making a
> huge noise, calling everyone around (or their rules) insane, "makes no
> sense at all", and so on?
Not at all. Some weeks I'll work on as many as a dozen or so proj
On 03/18/16 19:40, David Woodhouse wrote:
> But this is different. This is the commit messages. And what would you
> know... the last commit message in the log which isn't ASCII *isn't*
> that other one I pointed out; it's one from you (7daf2401) in which you
> commit the heinous crime of slepping
On Thu, 2016-03-17 at 21:28 +, Kinney, Michael D wrote:
>
> Yes. Use of developer github forks is supported. I had summarized
> 3 development methods earlier in this thread.
>
> 1) PR emails send to edk2-devel. There is a Wiki page that details process
> for developers and maintainer.
>
On Sat, 2016-03-19 at 01:03 +0100, Laszlo Ersek wrote:
> > So yes, I'm interested in the bug because it should be fixed. But
> > basically, you brought it upon yourself by operating in a mode that is
> > *known* to invite such errors, and was abandoned by most other people a
> > *long* time ago.
>
49 matches
Mail list logo