Re: [edk2] MdeModulePkg/UefiPxeBcDxe: Question about IcmpErrorListenHandler in PxeBcImpl.c

Hi Gary, Do you have reported the Bugzilla for this issue? If not, can you report one for it? Thank you very much! Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Guo Heyi > Sent: Monday, December 11, 2017 6:43 PM > To: Wu,

[edk2] [Patch] MdeModulePkg/IpIoDxe: Update API description to match the function implementation.

This patch updates some API descriptions in DxeIpIoLib to match the real implementation. Cc: Ye Ting Cc: Wu Jiaxin Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan ---

[edk2] [Patch] MdeModulePkg/IpIoLib: add more error handling code to DxeIpIoLib.

In DxeIpIo, there are several places not check the returned value of called functions. This patch is to add the error handling to these functions. Cc: Ye Ting Cc: Wu Jiaxin Cc: Wang Fan Contributed-under: TianoCore Contribution

[edk2] [Patch] MdeModulePkg/IpIoLib: return error instead of ASSERT if input parameter is incorrect.

This patch updates the DxeIpIoLib to return EFI_INVALID_PARAMETER instead of ASSERT if the input pointers are not correct. Cc: Ye Ting Cc: Wu Jiaxin Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

Re: [edk2] [Patch 1/2] MdeModulePkg/Dhcp4Dxe: Check Media status before starting DHCP process.

Hi Jiaxin, Thanks for the clarification. I agree with your solution to try DHCP process when upper layer don't know the media status. However, we might need add some comments there to indicate such case, that MediaPresent is TRUE does not mean media is available. Others are good to me.

Re: [edk2] [Patch 1/2] MdeModulePkg/Dhcp4Dxe: Check Media status before starting DHCP process.

Hi Ting, In such a case, DHCP process should also be trigged since DHCP doesn't have the knowledge of media status. We can't return directly since the media may be available. what do you think? Thanks, Jiaxin > -Original Message- > From: Ye, Ting > Sent: Wednesday, December 13, 2017

Re: [edk2] [PATCH] MdeModulePkg PiSmmCore: Ensure SxDispatch not NULL before dereferenced

Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Zeng, Star > Sent: Wednesday, December 13, 2017 11:28 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star; Wu, Hao A; Yao, Jiewen > Subject: [PATCH] MdeModulePkg PiSmmCore: Ensure SxDispatch not

Re: [edk2] [Patch] BaseTools: Fix the incorrect indent introduced by 37de70

Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Wednesday, December 13, 2017 10:01 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject:

Re: [edk2] [Patch 1/2] MdeModulePkg/Dhcp4Dxe: Check Media status before starting DHCP process.

Hi Jiaxin, I think the patch need be revised since it does not check the returned status of NetLibDetectMedia. If NetLibDetectMedia failed to detect the media status due to some error conditions, MediaPresent is still TRUE and DHCP will be trigged later even no media is available. Thanks,

[edk2] [PATCH] MdeModulePkg PiSmmCore: Ensure SxDispatch not NULL before dereferenced

Cc: Hao Wu Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Cleanup the resource after error happen during Ip4StartAutoConfig().

Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Tuesday, December 12, 2017 7:44 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wang, Fan ; Wu, Jiaxin

[edk2] [PATCH] OvmfPkg/VirtioScsiDxe: Allocate all required vrings at VirtioScsiInit

VirtioScsiInit() allocate only one request queue which causes the address of the other vrings to be 0. In AARCH64 virtual machines, the address of system memory starts at 0x4000 and the address of rom starts at 0. This causes an error when QEMU translates the guest physical memory of

Re: [edk2] [Patch] MdeModulePkg/Ip4Dxe: return error on memory allocate failure instead of ASSERT.

Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan Sent: Wednesday, December 13, 2017 10:43 AM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Wang, Fan ; Wu,

[edk2] [Patch] MdeModulePkg/Ip4Dxe: return error on memory allocate failure instead of ASSERT.

This patch updates the IP4 driver to use error status code instead of ASSERT if failed to allocate memory buffer. Cc: Ye Ting Cc: Wu Jiaxin Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan

Re: [edk2] [PATCH V2] UefiCpuPkg: Check invalid RegisterCpuFeature parameter

On 12/13/2017 10:35 AM, Song, BinX wrote: V2: Update function name, add more detail description. V1: Check and assert invalid RegisterCpuFeature function parameter Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1

[edk2] [PATCH V2] UefiCpuPkg: Check invalid RegisterCpuFeature parameter

V2: Update function name, add more detail description. V1: Check and assert invalid RegisterCpuFeature function parameter Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bell Song

[edk2] [Patch] MdeModulePkg/Ip4Dxe: Remove redundant code in Ip4Config2InitInstance().

Instance->Dhcp4Event is not necessary to be created in Ip4Config2InitInstance. Because it will created in Ip4StartAutoConfig() later. Cc: Ye Ting Cc: Wu Jiaxin Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [Patch] MdeModulePkg/Ip4Dxe: Clean up IP4 interface if failed to open ARP protocol.

This patch fixes a bug in Ip4ConfigProtocol, that new created IP interface is not freed if Open ARP protocol failed. Cc: Ye Ting Cc: Wu Jiaxin Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu

[edk2] [Patch] BaseTools: Fix the incorrect indent introduced by 37de70

The incorrect indent introduced by 37de70, it cause PEIM in sub FV image can't be rebased. Then it block some platform can't boot. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu ---

Re: [edk2] [PATCH] UefiCpuPkg: Check invalid RegisterCpuFeature parameter

Hi Ray, Got it, I will update a V2 patch. Best Regards, Bell Song > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, December 12, 2017 4:44 PM > To: Song, BinX ; edk2-devel@lists.01.org > Cc: ler...@redhat.com; Dong, Eric > Subject: RE:

Re: [edk2] [Patch 1/3] NetworkPkg: Update Api from NetLibDetectMedia to NetLibDetectMediaWaitTimeout.

Hi, Fan We'd better to define a macro for the timeout, instead of using 20 in each place. BestRegards Fu Siyuan > -Original Message- > From: Wang, Fan > Sent: Tuesday, December 12, 2017 4:54 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan

Re: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Cleanup the resource after error happen during Ip4StartAutoConfig().

Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Tuesday, December 12, 2017 7:44 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Wang, > Fan ; Wu, Jiaxin

Re: [edk2] [Patch 2/2] NetworkPkg/Dhcp6Dxe: Check Media status before starting DHCP process.

Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Friday, December 1, 2017 4:39 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; > Karunakar P ; Wu, Jiaxin

Re: [edk2] [Patch] MdeModulePkg/Ip4Dxe: Cleanup the resource after error happen during Ip4StartAutoConfig().

Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Tuesday, December 12, 2017 7:44 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Wang, > Fan ; Wu, Jiaxin

Re: [edk2] [Patch] MdeModulePkg/UefiPxeBcDxe: Discard the normal ICMP packets and recycle the received ICMP data.

Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Tuesday, December 12, 2017 7:27 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Heyi Guo ; Ye, > Ting > Subject: [Patch]

Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error

Thanks for the fix. Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Tuesday, December 12, 2017 9:10 PM To: Yao, Jiewen ; edk2-devel-01 Cc: Dong, Eric ;

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Add initialization to local variable

Got it. Thanks for the feedback. Regards, Jian > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, December 12, 2017 5:27 PM > To: Wang, Jian J ; edk2-devel@lists.01.org > Cc: Wu, Hao A ; Dong, Eric

[edk2] [PATCH edk2-platforms 0/2] Platform/SynQuacerEvalBoard: add some modules

For parity with DeveloperBox, add some missing modules to EVB (which is the only hardware I currently have access to) Ard Biesheuvel (2): Platform/SynQuacerEvalBoard: add RamDiskDxe driver to build Platform/SynQuacerEvalBoard: add BGRT and ConsolePrefDxe drivers

[edk2] [PATCH edk2-platforms 1/2] Platform/SynQuacerEvalBoard: add RamDiskDxe driver to build

Add the RamDiskDxe driver, which is required for HTTP booting .iso images. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 2 ++

[edk2] [PATCH edk2-platforms 2/2] Platform/SynQuacerEvalBoard: add BGRT and ConsolePrefDxe drivers

Add the drivers that make the serial and graphical console behave more intuitively. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- The BGRT driver is needed to make BootLogoLib behave (and it is already enabled for

Re: [edk2] [PATCH v3 4/6] ArmPkg/Library/CompilerIntrinsicsLib: Enable VS2017/ARM builds

Hi Pete, On 8 December 2017 at 14:06, Pete Batard wrote: > Introduce CRT assembly replacements for __rt_sdiv, __rt_udiv, > __rt_udiv64, __rt_sdiv64, __rt_srsh, memcpy and memset. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Pete Batard

Re: [edk2] [PATCH] ArmPlatformPkg: retire obsolete PCDs

On 12 December 2017 at 17:12, Leif Lindholm wrote: > On Mon, Dec 11, 2017 at 05:57:09PM +, Ard Biesheuvel wrote: >> On 11 December 2017 at 15:42, Leif Lindholm wrote: >> > On Fri, Dec 08, 2017 at 06:27:32PM +, Ard Biesheuvel wrote: >>

Re: [edk2] [PATCH edk2-platforms v3 0/2] ArmPlatformPkg PCD cleanup

\\On 12 December 2017 at 19:13, Leif Lindholm wrote: > On Tue, Dec 12, 2017 at 07:07:45PM +, Ard Biesheuvel wrote: >> Remove lots and lots of PCD assignments of obsolete PCDs that are about >> to be removed from ArmPlatformPkg. > > For the series: > Reviewed-by: Leif

Re: [edk2] [PATCH edk2-platforms v3 0/2] ArmPlatformPkg PCD cleanup

On Tue, Dec 12, 2017 at 07:07:45PM +, Ard Biesheuvel wrote: > Remove lots and lots of PCD assignments of obsolete PCDs that are about > to be removed from ArmPlatformPkg. For the series: Reviewed-by: Leif Lindholm > v3: Don't replace instances of

Re: [edk2] [PATCH v2 0/5] ArmPlatformPkg: refactor LcdGraphicsOutputDxe driver

On 12 December 2017 at 17:44, Ard Biesheuvel wrote: > On 8 December 2017 at 17:31, Ard Biesheuvel wrote: >> This is a rework of the patch 'ArmPlatformPkg: Reorganize Lcd Graphics >> Output' >> sent out by Evan on September 26 [0] >> >> I

[edk2] [PATCH edk2-platforms v3 0/2] ArmPlatformPkg PCD cleanup

Remove lots and lots of PCD assignments of obsolete PCDs that are about to be removed from ArmPlatformPkg. v3: Don't replace instances of gArmPlatformTokenSpaceGuid.PcdFirmwareVendor with gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor. First of all, the latter expects a Unicode string,

[edk2] [PATCH edk2-platforms v3 2/2] Platform Silicon: remove obsolete ArmPlatformPkg PCD assignments

Remove unused ArmPlatformPkg PCDs from all platform descriptions. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/ARM/JunoPkg/ArmJuno.dsc | 13 -

[edk2] [PATCH edk2-platforms v3 1/2] Platform/ARM/VExpressPkg: use dedicated PCD for fastboot product name

Before retiring the gArmPlatformTokenSpaceGuid.PcdFirmwareVendor PCD, replace the only remaining and vaguely non-pointless reference with a new dedicated PCD defined in VExpressPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH edk2-platforms 0/8] SynQuacer updates

On 12 December 2017 at 18:20, Leif Lindholm wrote: > On Tue, Dec 12, 2017 at 10:37:59AM +, Ard Biesheuvel wrote: >> A round of updates for Socionext SynQuacer: >> >> - enable CPU idle states in the DT, so that the OS can put cores to sleep >> using PSCI (#1) >> -

Re: [edk2] [PATCH edk2-platforms 2/8] Platform/Socionext/SynQuacer: expose build number as firmware version

On Tue, Dec 12, 2017 at 06:28:31PM +, Ard Biesheuvel wrote: > On 12 December 2017 at 18:24, Leif Lindholm wrote: > > On Tue, Dec 12, 2017 at 06:20:00PM +, Ard Biesheuvel wrote: > >> On 12 December 2017 at 18:17, Leif Lindholm > >>

Re: [edk2] [PATCH edk2-platforms 2/8] Platform/Socionext/SynQuacer: expose build number as firmware version

On 12 December 2017 at 18:24, Leif Lindholm wrote: > On Tue, Dec 12, 2017 at 06:20:00PM +, Ard Biesheuvel wrote: >> On 12 December 2017 at 18:17, Leif Lindholm wrote: >> > On Tue, Dec 12, 2017 at 10:38:01AM +, Ard Biesheuvel wrote: >>

Re: [edk2] [PATCH edk2-platforms 2/8] Platform/Socionext/SynQuacer: expose build number as firmware version

On Tue, Dec 12, 2017 at 06:20:00PM +, Ard Biesheuvel wrote: > On 12 December 2017 at 18:17, Leif Lindholm wrote: > > On Tue, Dec 12, 2017 at 10:38:01AM +, Ard Biesheuvel wrote: > >> Expose the contents of the .DSC macro BUILD_NUMBER via the > >> PCD

Re: [edk2] [PATCH edk2-platforms 0/8] SynQuacer updates

On Tue, Dec 12, 2017 at 10:37:59AM +, Ard Biesheuvel wrote: > A round of updates for Socionext SynQuacer: > > - enable CPU idle states in the DT, so that the OS can put cores to sleep > using PSCI (#1) > - add the build number to PCDs that end up in user visible strings (#2) > - fix a PCIe

Re: [edk2] [PATCH edk2-platforms 2/8] Platform/Socionext/SynQuacer: expose build number as firmware version

On 12 December 2017 at 18:17, Leif Lindholm wrote: > On Tue, Dec 12, 2017 at 10:38:01AM +, Ard Biesheuvel wrote: >> Expose the contents of the .DSC macro BUILD_NUMBER via the >> PCD gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString (if > 1), >> and as the FMP

Re: [edk2] [PATCH edk2-platforms 2/8] Platform/Socionext/SynQuacer: expose build number as firmware version

On Tue, Dec 12, 2017 at 10:38:01AM +, Ard Biesheuvel wrote: > Expose the contents of the .DSC macro BUILD_NUMBER via the > PCD gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString (if > 1), > and as the FMP system firmware version (for capsule update). > > Also, set the firmware vendor to

Re: [edk2] [PATCH edk2-platforms 5/8] Silicon/SynQuacer: disable PCI RC #0 DT node if disabled

On Tue, Dec 12, 2017 at 06:09:13PM +, Ard Biesheuvel wrote: > On 12 December 2017 at 17:50, Leif Lindholm wrote: > > On Tue, Dec 12, 2017 at 05:35:15PM +, Ard Biesheuvel wrote: > >> On 12 December 2017 at 17:32, Leif Lindholm > >>

Re: [edk2] [PATCH edk2-platforms 8/8] Silicon/SynQuacer/PlatformDxe: retrain PCIe switch links to Gen2 speed

On Tue, Dec 12, 2017 at 05:51:18PM +, Ard Biesheuvel wrote: > On 12 December 2017 at 17:47, Leif Lindholm wrote: > > On Tue, Dec 12, 2017 at 10:38:07AM +, Ard Biesheuvel wrote: > >> For some reason, the Asmedia 118x PCIe switch needs a little help to > >> make

Re: [edk2] [PATCH edk2-platforms 5/8] Silicon/SynQuacer: disable PCI RC #0 DT node if disabled

On 12 December 2017 at 17:50, Leif Lindholm wrote: > On Tue, Dec 12, 2017 at 05:35:15PM +, Ard Biesheuvel wrote: >> On 12 December 2017 at 17:32, Leif Lindholm wrote: >> > Suggested subject tweak: >> > Silicon/SynQuacer: disable PCI RC #0

Re: [edk2] [PATCH edk2-platforms v2 0/2] Platform/ARM: move to new LCD graphics driver

On 12 December 2017 at 17:13, Leif Lindholm wrote: > On Fri, Dec 08, 2017 at 05:31:38PM +, Ard Biesheuvel wrote: >> This is the edk2-platforms counterpart to the series against EDK2 that >> refactors the LCD graphics output driver, and moves platform specific glue >>

Re: [edk2] [PATCH edk2-platforms 8/8] Silicon/SynQuacer/PlatformDxe: retrain PCIe switch links to Gen2 speed

On 12 December 2017 at 17:47, Leif Lindholm wrote: > On Tue, Dec 12, 2017 at 10:38:07AM +, Ard Biesheuvel wrote: >> For some reason, the Asmedia 118x PCIe switch needs a little help to >> make sure that the downstream links train at Gen2 speed. So add a >> PCI I/O

Re: [edk2] [PATCH edk2-platforms 5/8] Silicon/SynQuacer: disable PCI RC #0 DT node if disabled

On Tue, Dec 12, 2017 at 05:35:15PM +, Ard Biesheuvel wrote: > On 12 December 2017 at 17:32, Leif Lindholm wrote: > > Suggested subject tweak: > > Silicon/SynQuacer: disable PCI RC #0 DT node if disabled -> > > Silicon/SynQuacer: disable PCI RC DT node if RC disabled.

Re: [edk2] [PATCH edk2-platforms v2 1/2] Platform: switch to MdeModulePkg's version of PcdFirmwareVendor

On Tue, Dec 12, 2017 at 05:19:41PM +, Ard Biesheuvel wrote: > On 12 December 2017 at 17:17, Leif Lindholm wrote: > > On Fri, Dec 08, 2017 at 06:27:11PM +, Ard Biesheuvel wrote: > >> ArmPlatformPkg defines a PcdFirmwareVendor PCD that is hardly ever > >> used.

Re: [edk2] [PATCH edk2-platforms 8/8] Silicon/SynQuacer/PlatformDxe: retrain PCIe switch links to Gen2 speed

On Tue, Dec 12, 2017 at 10:38:07AM +, Ard Biesheuvel wrote: > For some reason, the Asmedia 118x PCIe switch needs a little help to > make sure that the downstream links train at Gen2 speed. So add a > PCI I/O protocol notifier that implements this for each PCIe downstream > port that is

Re: [edk2] [PATCH v2 0/5] ArmPlatformPkg: refactor LcdGraphicsOutputDxe driver

On 8 December 2017 at 17:31, Ard Biesheuvel wrote: > This is a rework of the patch 'ArmPlatformPkg: Reorganize Lcd Graphics Output' > sent out by Evan on September 26 [0] > > I have split it up for easier review, and droppped then changes to VExpress > specific

Re: [edk2] [PATCH] MdePkg: correct and clarify documentation of VA_LIST in Base.h

On 12/12/17 16:01, Gao, Liming wrote: > Laszlo: > Thanks! > > Reviewed-by: Liming Gao Thanks! Pushed it as e3e40c83fd2c. Zenith432, thanks for the contribution -- for your next patch; please send the updated versions as separate top-level postings, such as [PATCH v2],

Re: [edk2] [PATCH edk2-platforms 7/8] Silicon/Socionext/SynQuacer/DeviceTree: expose SCP serial port to the OS

Suggested subject tweak: Silicon/Socionext/SynQuacer/DeviceTree: expose SCP serial port to the OS -> Silicon/Socionext/SynQuacer: add UART #0 node to DT with that: Reviewed-by: Leif Lindholm On Tue, Dec 12, 2017 at 10:38:06AM +, Ard Biesheuvel wrote: > From:

Re: [edk2] [PATCH edk2-platforms 5/8] Silicon/SynQuacer: disable PCI RC #0 DT node if disabled

On 12 December 2017 at 17:32, Leif Lindholm wrote: > Suggested subject tweak: > Silicon/SynQuacer: disable PCI RC #0 DT node if disabled -> > Silicon/SynQuacer: disable PCI RC DT node if RC disabled. > Ack. It's out of date, as you probably suspected > The code below

Re: [edk2] [PATCH edk2-platforms 5/8] Silicon/SynQuacer: disable PCI RC #0 DT node if disabled

Suggested subject tweak: Silicon/SynQuacer: disable PCI RC #0 DT node if disabled -> Silicon/SynQuacer: disable PCI RC DT node if RC disabled. The code below will disable either #0 or #1 node if not enabled by Pcd. On Tue, Dec 12, 2017 at 10:38:04AM +, Ard Biesheuvel wrote: > If PCIe RC #0

Re: [edk2] [PATCH edk2-platforms 3/8] Silicon/SynQuacerPciHostBridgeLib: stall for 150 ms during PERST#

On Tue, Dec 12, 2017 at 10:38:02AM +, Ard Biesheuvel wrote: > Attempt to adhere more closely to the PCIe spec by ensuring that PERST# > remains asserted for at least 100 ms. Give it a good margin, and delay > for 150 ms; the additional boot time delay is not going to be noticeable > by anyone

Re: [edk2] [PATCH edk2-platforms v2 1/2] Platform: switch to MdeModulePkg's version of PcdFirmwareVendor

On 12 December 2017 at 17:17, Leif Lindholm wrote: > On Fri, Dec 08, 2017 at 06:27:11PM +, Ard Biesheuvel wrote: >> ArmPlatformPkg defines a PcdFirmwareVendor PCD that is hardly ever >> used. Let's switch to the equivalent one in MdeModulePkg so we can >> remove the

Re: [edk2] [PATCH edk2-platforms v2 1/2] Platform: switch to MdeModulePkg's version of PcdFirmwareVendor

On Fri, Dec 08, 2017 at 06:27:11PM +, Ard Biesheuvel wrote: > ArmPlatformPkg defines a PcdFirmwareVendor PCD that is hardly ever > used. Let's switch to the equivalent one in MdeModulePkg so we can > remove the one in ArmPlatformPkg. > > Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] [PATCH v2 1/5] ArmPlatformPkg: introduce LcdHwLib library class

On 12 December 2017 at 17:12, Leif Lindholm wrote: > On Mon, Dec 11, 2017 at 05:56:37PM +, Ard Biesheuvel wrote: >> On 11 December 2017 at 17:32, Leif Lindholm wrote: >> > On Fri, Dec 08, 2017 at 05:31:24PM +, Ard Biesheuvel wrote: >>

Re: [edk2] [PATCH edk2-platforms v2 0/2] Platform/ARM: move to new LCD graphics driver

On Fri, Dec 08, 2017 at 05:31:38PM +, Ard Biesheuvel wrote: > This is the edk2-platforms counterpart to the series against EDK2 that > refactors the LCD graphics output driver, and moves platform specific glue > out of the main repository. For the series: Reviewed-by: Leif Lindholm

Re: [edk2] [PATCH] ArmPlatformPkg: retire obsolete PCDs

On Mon, Dec 11, 2017 at 05:57:09PM +, Ard Biesheuvel wrote: > On 11 December 2017 at 15:42, Leif Lindholm wrote: > > On Fri, Dec 08, 2017 at 06:27:32PM +, Ard Biesheuvel wrote: > >> Retire a whole bunch of ArmPlatformPkg PCDs that are either related > >> to the

Re: [edk2] [PATCH v2 1/5] ArmPlatformPkg: introduce LcdHwLib library class

On Mon, Dec 11, 2017 at 05:56:37PM +, Ard Biesheuvel wrote: > On 11 December 2017 at 17:32, Leif Lindholm wrote: > > On Fri, Dec 08, 2017 at 05:31:24PM +, Ard Biesheuvel wrote: > >> Add the declaration and include file for the new LcdHwLib library class, > >>

Re: [edk2] [PATCH] MdePkg: correct and clarify documentation of VA_LIST in Base.h

Laszlo: Thanks! Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, December 12, 2017 6:39 PM > To: Zenith432 ;

Re: [edk2] [PATCH edk2-platforms 5/8] Silicon/SynQuacer: disable PCI RC #0 DT node if disabled

On 12 December 2017 at 10:38, Ard Biesheuvel wrote: > If PCIe RC #0 is not enabled (due to the fact that the slot is not > populated), set its DT node 'status' property to 'disabled' so that > the OS will not attempt to attach to it. > > This means we will need to

Re: [edk2] Timebased Auth Variable driver should ensure AuthAlgorithm is SHA256 before further verification

Hello LONG, Quin, Thank you very much for the quick response. From the discussion it is clear to me where the problem is and how the data can be signed using signtool to prevent this. Do you know if there are any updates to the Linux tools (e.g. efitools) that allow supporting UEFI 2.6 in an

Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error

On 12/12/17 13:54, Yao, Jiewen wrote: > Thanks ,Laszlo. > Reviewed-by: jiewen@intel.com Thanks! > Since it breaks the build, can we check in as soon as possible? Sure; commit dfc5a4dec602. Thanks! Laszlo >> -Original Message- >> From: edk2-devel

Re: [edk2] [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error

Thanks ,Laszlo. Reviewed-by: jiewen@intel.com Since it breaks the build, can we check in as soon as possible? Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Tuesday, December 12, 2017 8:47 PM

[edk2] [PATCH] MdeModulePkg/PiSmmCore: fix GCC build error

> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c: In function > 'SmmReadyToBootHandler': > MdeModulePkg/Core/PiSmmCore/PiSmmCore.c:323:14: error: passing argument > 3 of 'SmmLocateProtocol' from incompatible pointer type [-Werror] > ); > ^ > In file included from

[edk2] [Patch] MdeModulePkg/Ip4Dxe: Cleanup the resource after error happen during Ip4StartAutoConfig().

Cc: Ye Ting Cc: Fu Siyuan Cc: Wang Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- .../Universal/Network/Ip4Dxe/Ip4Config2Impl.c | 46 +- 1 file

[edk2] [Patch] MdeModulePkg/UefiPxeBcDxe: Discard the normal ICMP packets and recycle the received ICMP data.

This patch is to discard the normal ICMP packets and recycle the received ICMP data to avoid the memory leak. Cc: Siyuan Fu Cc: Heyi Guo Cc: Ye Ting Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiaxin Wu

Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

On 12 December 2017 at 10:56, Wu, Hao A wrote: > Hi Ard, > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard >> Biesheuvel >> Sent: Tuesday, December 12, 2017 3:00 PM >> To: edk2-devel@lists.01.org >> Cc: Ni, Ruiyu;

Re: [edk2] [PATCH v4 0/2] quirks handling for SDHCI controllers

Hi Ard, > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard > Biesheuvel > Sent: Tuesday, December 12, 2017 3:00 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu; Tian, Feng; Ard Biesheuvel; Wu, Hao A; Leif Lindholm; Kinney, > Michael D; Zeng,

Re: [edk2] [PATCH] EmbeddedPkg/PrePiLib: add support for v2 sections

On 12 December 2017 at 06:52, M1cha wrote: > From: Michael Zimmermann > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Michael Zimmermann Reviewed-by: Ard Biesheuvel

Re: [edk2] [PATCH] MdePkg: correct and clarify documentation of VA_LIST in Base.h

On 12/12/17 11:24, Zenith432 wrote: > Below is an amended patch. > > I changed the wording in the notes a little to exclude a non-variadic > function using VA_START, and to remind that VA_COPY should also be > paired with VA_END. > > Also, if GCC gets its VA_COPY repaired, documentation may

[edk2] [PATCH edk2-platforms 5/8] Silicon/SynQuacer: disable PCI RC #0 DT node if disabled

If PCIe RC #0 is not enabled (due to the fact that the slot is not populated), set its DT node 'status' property to 'disabled' so that the OS will not attempt to attach to it. This means we will need to switch from the default DtPlatformDtbLoaderLib to a special one for our platform.

[edk2] [PATCH edk2-platforms 2/8] Platform/Socionext/SynQuacer: expose build number as firmware version

Expose the contents of the .DSC macro BUILD_NUMBER via the PCD gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString (if > 1), and as the FMP system firmware version (for capsule update). Also, set the firmware vendor to 'Linaro Enterprise Group', to distinguish our builds from builds by other

[edk2] [PATCH edk2-platforms 3/8] Silicon/SynQuacerPciHostBridgeLib: stall for 150 ms during PERST#

Attempt to adhere more closely to the PCIe spec by ensuring that PERST# remains asserted for at least 100 ms. Give it a good margin, and delay for 150 ms; the additional boot time delay is not going to be noticeable by anyone anyway. So split the init routine in a pre and post part, and put the

[edk2] [PATCH edk2-platforms 1/8] Silicon/SynQuacer: enable CPU idle states in device tree

It appears that whatever was preventing us from using CPU idle with PSCI low power states has disappeared, so let's enable the low power states in the DT. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH edk2-platforms 7/8] Silicon/Socionext/SynQuacer/DeviceTree: expose SCP serial port to the OS

From: Masahisa KOJIMA In order to be able to use UART #0 on the DeveloperBox's 96boards low speed connector, expose it to the OS by adding a node to the device tree. This requires a CM3 firmware build that makes the SCP detach from the serial port after boot.

[edk2] [PATCH edk2-platforms 8/8] Silicon/SynQuacer/PlatformDxe: retrain PCIe switch links to Gen2 speed

For some reason, the Asmedia 118x PCIe switch needs a little help to make sure that the downstream links train at Gen2 speed. So add a PCI I/O protocol notifier that implements this for each PCIe downstream port that is present on the system. Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH edk2-platforms 6/8] Silicon/SynQuacerEvalBoard: enable PCI #0 only when card is detected

The EVB does not boot if PCI RC #0 has no card inserted, and will hang in the PCIe initialization code. So let's check the presence detect GPIO, and only enable PCI RC #0 if it is asserted. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH edk2-platforms 4/8] Silicon/SynQuacerPciHostBridgeLib: enable RCs based on PCD setting

In order to accommodate the EVB, whose PCIe RC #0 should not be touched by software if no card is inserted, add a PCD that tells the PCIe driver code which RCs should be initialized and exposed to the PCI host bridge driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH edk2-platforms 0/8] SynQuacer updates

A round of updates for Socionext SynQuacer: - enable CPU idle states in the DT, so that the OS can put cores to sleep using PSCI (#1) - add the build number to PCDs that end up in user visible strings (#2) - fix a PCIe detection issue in the DeveloperBox x16 slot, by keeping PERST# asserted

Re: [edk2] [PATCH] MdePkg: correct and clarify documentation of VA_LIST in Base.h

Below is an amended patch. I changed the wording in the notes a little to exclude a non-variadic function using VA_START, and to remind that VA_COPY should also be paired with VA_END. Also, if GCC gets its VA_COPY repaired, documentation may change to allow to using VA_COPY inside non-EFIAPI

Re: [edk2] [Patch 0/3 V2] BaseTools: Fix some bugs about hash value enable

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Tuesday, December 12, 2017 3:27 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch 0/3 V2] BaseTools: Fix some bugs about

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Add initialization to local variable

Hello Jian, On 12/12/17 04:28, Jian J Wang wrote: > The purpose of the patch is just to avoid complaining from compiler and > static check tool. > > Cc: Eric Dong > Cc: Wu Hao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by:

Re: [edk2] [PATCH] MdePkg: correct and clarify documentation of VA_LIST in Base.h

Hi, On 12/10/17 10:32, Zenith432 wrote: > This is to resolve bug 457. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zenith432 > --- > MdePkg/Include/Base.h | 24 > 1 file changed, 20 insertions(+), 4 deletions(-) I'm commenting on this

[edk2] [Patch 3/3] ShellPkg: Update Api from NetLibDetectMedia to NetLibDetectMediaWaitTimeout.

Since new Api NetLibDetectMediaWaitTimeout was involved to support connecting state handling, and it is forward compatible. So apply this Api in ShellPkg. Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Jiaxin Contributed-under: TianoCore

[edk2] [Patch 2/3] MdeModulePkg: Update Api from NetLibDetectMedia to NetLibDetectMediaWaitTimeout.

Since new Api NetLibDetectMediaWaitTimeout was involved to support connecting state handling, and it is forward compatible. So apply this Api in MdeModulePkg. Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Jiaxin Contributed-under: TianoCore

[edk2] [Patch 1/3] NetworkPkg: Update Api from NetLibDetectMedia to NetLibDetectMediaWaitTimeout.

Since new Api NetLibDetectMediaWaitTimeout was involved to support connecting state handling, and it is forward compatible. So apply this Api in Network. Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Jiaxin Contributed-under: TianoCore

[edk2] [Patch 0/3] *** SUBJECT HERE ***

This patch updates the Api NetLibDetectMedia to NetLibDetectMediaWaitTimeout. Wang Fan (3): NetworkPkg: Update Api from NetLibDetectMedia to NetLibDetectMediaWaitTimeout. MdeModulePkg: Update Api from NetLibDetectMedia to NetLibDetectMediaWaitTimeout. ShellPkg: Update Api from

Re: [edk2] [PATCH] MdeModulePkg PiSmmIpl: Add missing update to the prototype

Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Zeng, Star Sent: Tuesday, December 12, 2017 4:16 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Bi, Dandan ; Yao, Jiewen Subject:

Re: [edk2] [PATCH] UefiCpuPkg: Check invalid RegisterCpuFeature parameter

> -Original Message- > From: Song, BinX > Sent: Monday, December 11, 2017 6:00 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Cc: ler...@redhat.com; Dong, Eric > Subject: RE: [edk2] [PATCH] UefiCpuPkg: Check invalid RegisterCpuFeature > parameter >

Re: [edk2] [PATCH] SecurityPkg:Tcg2Smm: Update Interrupt resource name

Reviewed-by: Long Qin Best Regards & Thanks, LONG, Qin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang, Chao B Sent: Tuesday, December 12, 2017 3:41 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen

Re: [edk2] [PATCH] MdePkg: correct and clarify documentation of VA_LIST in Base.h

On 12/12/17 02:32, Gao, Liming wrote: > Laszlo: > Have you any comments for this patch? Seemly, you discussed this topic in > bugzillar. Thanks for the ping, I'll comment under the thread starter message. Thanks! Laszlo >> -Original Message- >> From: edk2-devel

Re: [edk2] [PATCH] UefiCpuPkg/CpuDxe: Add initialization to local variable

Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Wang, Jian J > Sent: Tuesday, December 12, 2017 11:28 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Wu, Hao A > Subject: [PATCH] UefiCpuPkg/CpuDxe: Add initialization to local variable > >

[edk2] [PATCH] MdeModulePkg PiSmmIpl: Add missing update to the prototype

It is missing to update the prototype of SmmCommunicationCommunicate() in d1632f694be027dee87dd18fa8172d674221face. This patch is to add it. Cc: Dandan Bi Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng

  1   2   >