Re: [edk2] [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition.

2018-05-17 Thread Zeng, Star
Got it. Good information. Thanks, Star -Original Message- From: Marvin H?user [mailto:marvin.haeu...@outlook.com] Sent: Thursday, May 17, 2018 7:45 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Kinney, Michael D ; Gao, Liming

[edk2] How to retrieve HII form's default value

2018-05-17 Thread methavanitpong.pipat
Hi, I'm working on changing SynQuacer/PlatformDxe initial HII configuration. In the current implementation, SynQuacerPlatformSettings HII variable doesn't set its initial value from PcdPlatfromSettings. * PcdPlatformSettings is initially set with value in dsc at build time *

[edk2] [PATCH v1 1/2] BaseTools: refactor to remove functions

2018-05-17 Thread Jaben Carsey
refactoring almost identical functions to delete and use the other. Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey ---

[edk2] [PATCH v1 2/2] BaseTools: Cleanup unneeded code

2018-05-17 Thread Jaben Carsey
Cc: Liming Gao Cc: Yonghong Zhu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jaben Carsey --- BaseTools/Source/Python/AutoGen/AutoGen.py | 335 +---

[edk2] [PATCH v1 0/2] BaseTools: cleanup for speed

2018-05-17 Thread Jaben Carsey
the first patch merges 2 almost identical functions by moving optional output to the WorkspaceCommon version and then calls it from AutoGen. the second patch is lots of small cleanups. Jaben Carsey (2): BaseTools: refactor to remove functions BaseTools: Cleanup unneeded code

Re: [edk2] Query regarding hole in EFI Memory Map

2018-05-17 Thread Prakhya, Sai Praneeth
> Hey Sai and others, > > I did not verify this is actually the case for QEMU, but the mentioned range > is > usually the SMRAM ASEG. > SMRAM ranges are not reported in the Memory Map by-design. > Thanks for educating us on this Marvin :) Regards, Sai

Re: [edk2] Ram initialization sequence in edk2

2018-05-17 Thread Rebecca Cran
On 05/17/2018 06:10 AM, Laszlo Ersek wrote: The memory controller (or other silicon) initialization code is usually one of the most proprietary parts of any platform firmware. It's pretty unlikely you can get the source for it from anyone else than the platform manufacturer, and that's assuming

Re: [edk2] Extracting vendor blobs from edk2-coreboot payload

2018-05-17 Thread Blibbet
On 05/15/2018 03:36 PM, Anatol Pomozov wrote: > [...] Is there a simple tool that allows to extract these Intel blobs from > Build/CorebootPayloadPkgX64/RELEASE_GCC5/FV/UEFIPAYLOAD.fd ? I expect most Tianocore tools focus on creating blobs, not reversing them. If EDK2 has tools like this, I'd

Re: [edk2] [PATCH 0/4] RFC: ovmf: Add support for TPM Physical Presence interface

2018-05-17 Thread Laszlo Ersek
On 05/17/18 16:43, Marc-André Lureau wrote: > On Wed, May 16, 2018 at 11:29 AM, Laszlo Ersek wrote: >> - the "xfuncname"-related settings, so that git diff hunk headers @@ >> are useful for DSC and INF files too, >> > > This is already in my .git/config, I hope it takes

[edk2] [PATCH v2 1/4] OvmfPkg: add Tcg2PhysicalPresenceLibNull when !TPM2_ENABLE

2018-05-17 Thread marcandre . lureau
From: Marc-André Lureau This NULL library will let us call Tcg2PhysicalPresenceLibProcessRequest() unconditionally from BdsPlatform when building without TPM2_ENABLE. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marc-André Lureau

[edk2] [PATCH v2 3/4] OvmfPkg: add Tcg2PhysicalPresenceLibQemu

2018-05-17 Thread marcandre . lureau
From: Marc-André Lureau Cloned "SecurityPkg/Library/DxeTcg2PhysicalPresenceLib" and: - removed all the functions that are unreachable from Tcg2PhysicalPresenceLibProcessRequest() - replaced everything that's related to the TCG2_PHYSICAL_PRESENCE*_VARIABLE

[edk2] [PATCH v2 4/4] OvmfPkg/PlatformBootManagerLib: process TPM PPI request

2018-05-17 Thread marcandre . lureau
From: Marc-André Lureau Call Tcg2PhysicalPresenceLibProcessRequest() to process pending PPI requests from PlatformBootManagerAfterConsole(). Laszlo understanding of edk2 is that the PPI operation processing was meant to occur *entirely* before End-Of-Dxe, so that

[edk2] [PATCH v2 2/4] OvmfPkg/IndustryStandard: add QemuTpm.h header

2018-05-17 Thread marcandre . lureau
From: Marc-André Lureau Add some common macros and type definitions corresponding to the QEMU TPM interface. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marc-André Lureau ---

Re: [edk2] [PATCH 0/4] RFC: ovmf: Add support for TPM Physical Presence interface

2018-05-17 Thread Marc-André Lureau
Hi On Thu, May 17, 2018 at 9:54 AM, Laszlo Ersek wrote: > On 05/15/18 14:30, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> Hi, >> >> The following series adds basic TPM PPI 1.3 support for OVMF-on-QEMU >> with TPM2 (I haven't

Re: [edk2] [PATCH 0/4] RFC: ovmf: Add support for TPM Physical Presence interface

2018-05-17 Thread Marc-André Lureau
Hi On Wed, May 16, 2018 at 11:29 AM, Laszlo Ersek wrote: > Hi Marc-André, > > On 05/15/18 14:30, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> Hi, >> >> The following series adds basic TPM PPI 1.3 support for OVMF-on-QEMU >>

Re: [edk2] [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: Support unspecified local Timezone.

2018-05-17 Thread Carsey, Jaben
Still looks good to me. Ray? > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Marvin Häuser > Sent: Thursday, May 17, 2018 5:43 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu >

Re: [edk2] [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition.

2018-05-17 Thread Marvin Häuser
Hey Jaben, Done. Regards, Marvin. > -Original Message- > From: Carsey, Jaben > Sent: Thursday, May 17, 2018 12:32 AM > To: Marvin Häuser ; edk2- > de...@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming >

[edk2] [PATCH v2] EmulatorPkg/SmbiosLib: Declare the correct library class.

2018-05-17 Thread Marvin Häuser
Currently, SmbiosLib declares the PcdLib library class. Update the declaration to declare SmbiosLib. V2: - Do not change the copyright date as requested. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser ---

[edk2] [PATCH v2] ShellPkg/UefiShellLevel2CommandsLib: Support unspecified local Timezone.

2018-05-17 Thread Marvin Häuser
EFI_RUNTIME_SERVICES.GetTime() might return an unspecified Timezone, such as when SetTime() has not been called after the PC-AT CMOS RTC was cut off power. Consider this case by not attempting Timezone translations for when it is invalid. V2: - Do not change the copyright date as requested. -

[edk2] [PATCH v2] MdePkg: Update MmSwDispatch.h's references to SmmSw2Dispatch.

2018-05-17 Thread Marvin Häuser
MmSwDispatch.h current refers to the deprecated SmmSw2Dispatch protocol. Replace those references with the new MmSwDispatch name. V2: - Do not change the copyright date as requested. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser

[edk2] [PATCH v2] MdePkg/Hpet: Add Event Timer Block ID definition.

2018-05-17 Thread Marvin Häuser
This patch adds the HPET Event Timer Block ID definition that can be found in the IA-PC HPET Specification, section 3.2.4. V2: - Do not change the copyright date as requested. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser ---

[edk2] [PATCH v2] MdePkg/UefiFileHandleLib: Fix the Root directory determination.

2018-05-17 Thread Marvin Häuser
The current implementation of the FileHandleGetFileName() function assumes that the Root directory always has the FileName '\0'. However, the only requirement the UEFI specification defines is that a prepended '\\' must be supported to access files and folders relative to the Root directory. This

[edk2] [PATCH v2] MdePkg/UefiFileHandleLib: Fix potential NULL dereference.

2018-05-17 Thread Marvin Häuser
Move the NULL-check in FileHandleGetInfo() to directly after the allocation to prevent potential NULL dereferences. V2: - Do not change the copyright date as requested. - Added R-bs from V1 as no functional changes have been made. Contributed-under: TianoCore Contribution Agreement 1.1

Re: [edk2] Ram initialization sequence in edk2

2018-05-17 Thread Laszlo Ersek
On 05/17/18 13:50, Tasniya Begum Kankudti wrote: > Dear Sir/ Madam > > We are using OpenQ660 Board. we suspect that edk2 is the bootloader > for the same. We are unable to find the ram initialization code in > edk2 bootloader. Please help us to find the respective ram > initialization code.

[edk2] Ram initialization sequence in edk2

2018-05-17 Thread Tasniya Begum Kankudti
Dear Sir/ Madam We are using OpenQ660 Board. we suspect that edk2 is the bootloader for the same. We are unable to find the ram initialization code in edk2 bootloader. Please help us to find the respective ram initialization code. Please do write back waiting for your reply. Thanks and

Re: [edk2] [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition.

2018-05-17 Thread Marvin H?user
Hey Star, Actually the definition added is part of the definition of the ACPI Table header. I think there might be confusion because the first 32 bits match the first 32 bits of the Capabilities register. However, they are defined separately and the ACPI field lacks the upper 32 bits. Thanks,

Re: [edk2] Proposition of a BmEnumerateBootOptions() hook.

2018-05-17 Thread Marvin Häuser
Thanks for your comment, Comments are inline Regards, Marvin. > -Original Message- > From: Ni, Ruiyu > Sent: Thursday, May 17, 2018 9:58 AM > To: Marvin Häuser ; Laszlo Ersek > ; edk2-devel@lists.01.org > Cc: Dong, Eric

Re: [edk2] [PATCH 1/2] OvmfPkg/QemuVideoDxe: Add SubClass field to QEMU_VIDEO_CARD

2018-05-17 Thread Laszlo Ersek
On 05/17/18 11:21, Gerd Hoffmann wrote: > Then check for PCI_CLASS_DISPLAY_VGA using the new field. > This allows to enable/disable non-vga display classes per > card entry. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Gerd Hoffmann > --- >

Re: [edk2] [PATCH 4/4] ovmf: process TPM PPI request in AfterConsole()

2018-05-17 Thread Laszlo Ersek
On 05/15/18 14:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Call Tcg2PhysicalPresenceLibProcessRequest() to process pending PPI > requests from PlatformBootManagerAfterConsole(). > > Laszlo understanding of edk2 is that the PPI operation

Re: [edk2] [PATCH 3/4] ovmf: replace SecurityPkg with OvfmPkg Tcg2PhysicalPresenceLibQemu

2018-05-17 Thread Laszlo Ersek
On 05/15/18 14:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Cloned "SecurityPkg/Library/DxeTcg2PhysicalPresenceLib" and: > > - removed all the functions that are unreachable from > Tcg2PhysicalPresenceLibProcessRequest() > > - replaced

[edk2] [PATCH 2/2] OvmfPkg/QemuVideoDxe: Enable DISPLAY_OTHER pci class for qemu stdvga

2018-05-17 Thread Gerd Hoffmann
This makes QemuVideo bind to the secondary-vga device. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Gerd Hoffmann --- OvmfPkg/QemuVideoDxe/Driver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/OvmfPkg/QemuVideoDxe/Driver.c

[edk2] [PATCH 1/2] OvmfPkg/QemuVideoDxe: Add SubClass field to QEMU_VIDEO_CARD

2018-05-17 Thread Gerd Hoffmann
Then check for PCI_CLASS_DISPLAY_VGA using the new field. This allows to enable/disable non-vga display classes per card entry. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Gerd Hoffmann --- OvmfPkg/QemuVideoDxe/Qemu.h | 1 +

Re: [edk2] [PATCH 0/4] RFC: ovmf: Add support for TPM Physical Presence interface

2018-05-17 Thread Laszlo Ersek
On 05/17/18 09:54, Laszlo Ersek wrote: > On 05/15/18 14:30, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> Hi, >> >> The following series adds basic TPM PPI 1.3 support for OVMF-on-QEMU >> with TPM2 (I haven't tested TPM1, for lack of interest).

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3-UDK2017] Update SYSTEM_CONFIGURATION and EFI_GLOBAL_NVS_AREA.

2018-05-17 Thread zwei4
Add item in SYSTEM_CONFIGURATION and EFI_GLOBAL_NVS_AREA for reporting UART 1 as PNP0501 COM. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: zwei4 --- Vlv2DeviceRefCodePkg/AcpiTablesPCAT/GloblNvs.asl | 5 +++--

Re: [edk2] [PATCH 2/4] ovmf: add QemuTpm.h header

2018-05-17 Thread Laszlo Ersek
On 05/15/18 14:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add some common macros and type definitions corresponding to the QEMU > TPM interface. > > Signed-off-by: Marc-André Lureau > --- >

Re: [edk2] [PATCH] MdePkg/SmmPeriodicSmiLib: Get Periodic SMI Context More Robustly

2018-05-17 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Ruiyu Ni >Sent: Wednesday, May 09, 2018 5:37 PM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Gao, Liming

Re: [edk2] [PATCH] MdePkg/UefiFileHandleLib: Fix potential NULL dereference.

2018-05-17 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of Marvin > Häuser > Sent: Sunday, May 6, 2018 4:22 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming

Re: [edk2] [PATCH] ShellPkg/UefiShellLevel2CommandsLib: Support unspecified local Timezone.

2018-05-17 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of Marvin > Häuser > Sent: Sunday, May 6, 2018 4:23 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu

Re: [edk2] [PATCH] ShellPkg/UefiShellCommandLib: Do not error-exit when PlatformLang is missing.

2018-05-17 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Marvin Häuser > Sent: Sunday, May 6, 2018 8:07 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu > Subject: [PATCH]

Re: [edk2] Proposition of a BmEnumerateBootOptions() hook.

2018-05-17 Thread Ni, Ruiyu
Thanks/Ray > -Original Message- > From: edk2-devel On Behalf Of Marvin > Häuser > Sent: Wednesday, May 16, 2018 1:15 AM > To: Laszlo Ersek ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Dong, Eric

Re: [edk2] [PATCH 1/4] ovmf: add and link with Tcg2PhysicalPresenceLibNull when !TPM2_ENABLE

2018-05-17 Thread Laszlo Ersek
On 05/15/18 14:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This NULL library will let us call > Tcg2PhysicalPresenceLibProcessRequest() unconditionally from > BdsPlatform when building without TPM2_ENABLE. > > Signed-off-by: Marc-André

Re: [edk2] [PATCH 0/4] RFC: ovmf: Add support for TPM Physical Presence interface

2018-05-17 Thread Laszlo Ersek
On 05/15/18 14:30, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Hi, > > The following series adds basic TPM PPI 1.3 support for OVMF-on-QEMU > with TPM2 (I haven't tested TPM1, for lack of interest). > > PPI test runs successfully with Windows

Re: [edk2] [PATCH 0/4] RFC: ovmf: Add support for TPM Physical Presence interface

2018-05-17 Thread Laszlo Ersek
On 05/16/18 11:29, Laszlo Ersek wrote: > Hi Marc-André, > > On 05/15/18 14:30, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> Hi, >> >> The following series adds basic TPM PPI 1.3 support for OVMF-on-QEMU >> with TPM2 (I haven't tested TPM1, for

[edk2] [Patch][edk2-platforms/devel-IntelAtomProcessorE3900] Change ReadMe.MD

2018-05-17 Thread Guo, Mang
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang --- Platform/ReadMe.MD | 133 + ReadMe.MD | 8 +--- 2 files changed, 13 insertions(+), 128 deletions(-) diff --git