Re: [edk2] [PATCH 2/2] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Clear C-bit when SEV is active

Hi Brijesh, you provided a lot of information (and it seems like your analysis was advancing in parallel with your email -- I too do that sometimes :) ), so it's not easy for me to write a concise response. * Regarding the C-bit that covers the relocated save state area (esp. considering that

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacer: add stage 2 override translation tables for PCIe

On 27 February 2018 at 17:36, Leif Lindholm wrote: > > On Tue, Feb 27, 2018 at 05:19:59PM +, Ard Biesheuvel wrote: >> On 27 February 2018 at 13:47, Ard Biesheuvel >> wrote: >> > The Designware PCIe IP in the SynQuacer SoC needs a little

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 02/27/18 18:33, Ard Biesheuvel wrote: > On 27 February 2018 at 16:10, Ard Biesheuvel > wrote: >> On 27 February 2018 at 16:09, Laszlo Ersek wrote: >>> On 02/27/18 15:21, Ard Biesheuvel wrote: On 27 February 2018 at 10:43, Laszlo Ersek

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 27 February 2018 at 16:09, Laszlo Ersek wrote: > On 02/27/18 15:21, Ard Biesheuvel wrote: >> On 27 February 2018 at 10:43, Laszlo Ersek wrote: >>> On 02/27/18 10:23, Ard Biesheuvel wrote: On 27 February 2018 at 01:50, Guo Heyi

[edk2] [PATCH 2/5] MdePkg/SPI: Add missing definitions.

The PI Specification lack a bunch of definitions required to implement the protocol stack. Add definitions with bit values, ordered in the same way as in the specification. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser ---

[edk2] [PATCH 3/5] MdePkg/SPI: Cleanup the protocol headers.

Cleanup the SPI protocol headers according to the following criteria: * Add SPI COnfiguration protocol EDK2-style GUID name. * Add spaces between setences, as done in several places across the codebase to improve readability. * Remove spaces above comment bodys. The empty comments are

[edk2] [PATCH 1/5] MdePkg/SPI: Change function definitions to match their descriptions.

The PI specification is not continuous with function headers and descriptions for the SPI protocols. Correct and comment these mistakes. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser ---

[edk2] [PATCH 4/5] MdePkg/LegacySpiSmmFlash.h: Add missing include directive.

Include SpiSmmNorFlash.h from LegacySpiSmmFlash.h to match the non-SMM counterpart. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser --- MdePkg/Include/Protocol/LegacySpiSmmFlash.h | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2] [PATCH] MdePkg/UefiLib: Add 'OUT' decorator where necessary.

The functions AddUnicodeString() and AddUnicodeString2() might return a new value into their parameter UnicodeStringTable, hence add the appropiate 'OUT' decorator. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser ---

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacer: add stage 2 override translation tables for PCIe

On 27 February 2018 at 13:47, Ard Biesheuvel wrote: > The Designware PCIe IP in the SynQuacer SoC needs a little help to > appear sane to the OS. Not only does it lack a true root port, and > therefore does not perform any filtering whatsoever of type 0 config > TLPs

[edk2] [PATCH 2/2] MdeModulePkg/BaseSerialPortLib16550: Prevent truncating constant values.

The toolcahin VS2015x86 issues warnings when truncating constant values. Explicitely cast such to avoid it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser --- MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.c

[edk2] [PATCH 1/2] MdeModulePkg/PciBusDxe: Prevent truncating constant values.

The toolcahin VS2015x86 issues warnings when truncating constant values. Explicitely cast such to avoid it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser --- MdeModulePkg/Bus/Pci/PciBusDxe/PciResourceSupport.c | 4 ++-- 1 file

[edk2] [PATCH 5/5] MdePkg/LegacySpiSmmFlash.h: Add the missing SpiSmmIo header.

Add the missing header for the SPI SMM IO protocol. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser --- MdePkg/Include/Protocol/SpiSmmIo.h | 25 1 file changed, 25 insertions(+) diff --git

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 02/27/18 12:30, Guo Heyi wrote: > On Tue, Feb 27, 2018 at 11:43:35AM +0100, Laszlo Ersek wrote: >> On 02/27/18 10:23, Ard Biesheuvel wrote: >>> On 27 February 2018 at 01:50, Guo Heyi wrote: Hi Ard, Sorry for the late of seeing this patch. I have one

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 02/27/18 15:21, Ard Biesheuvel wrote: > On 27 February 2018 at 10:43, Laszlo Ersek wrote: >> On 02/27/18 10:23, Ard Biesheuvel wrote: >>> On 27 February 2018 at 01:50, Guo Heyi wrote: Hi Ard, Sorry for the late of seeing this patch. I

[edk2] [PATCH 2/2] MdePkg/UefiSpec.h: Ensure safe bitwise operations.

As per the C standard, bit-level operations on signed integers are either undefined or implementation-defined. Hence, use the BIT definitions from Base.h where applicable and mark the others as unsigned. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser

[edk2] [PATCH 1/2] MdePkg/Base.h: Ensure safe bitwise operations.

As per the C standard, bit-level operations on signed integers are either undefined or implementation-defined. Hence, mark all BIT defines and shifts as unsigned to safely allow such operations. For the SIGNATURE macros, add several casts to account for int promotions, which might be signed.

[edk2] [PATCH] UefiCpuPkg/SecMain: Add NORETURN decorator to SecStartup().

The function SecStartup() is not supposed to return. Hence, add the NORETURN decorator. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser --- UefiCpuPkg/SecCore/SecMain.c | 6 ++ UefiCpuPkg/SecCore/SecMain.h | 1 + 2 files

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacer: add stage 2 override translation tables for PCIe

On Tue, Feb 27, 2018 at 05:19:59PM +, Ard Biesheuvel wrote: > On 27 February 2018 at 13:47, Ard Biesheuvel > wrote: > > The Designware PCIe IP in the SynQuacer SoC needs a little help to > > appear sane to the OS. Not only does it lack a true root port, and > >

Re: [edk2] [PATCH] UefiCpuPkg/SecMain: Add NORETURN decorator to SecStartup().

On 02/27/18 17:50, Marvin Häuser wrote: > The function SecStartup() is not supposed to return. Hence, add the > NORETURN decorator. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marvin Haeuser > --- > UefiCpuPkg/SecCore/SecMain.c | 6

[edk2] [PATCH] BaseTools/tools_def: use separate PP definition for DTC

Clang's preprocessor behaves differently from GCC's, and produces intermediate device tree source that still contains #pragma pack() and other directives that the device tree compiler chokes on. For assembling device tree sources, it matters very little which preprocessor is being used, so let's

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 27 February 2018 at 17:47, Laszlo Ersek wrote: > On 02/27/18 18:33, Ard Biesheuvel wrote: >> On 27 February 2018 at 16:10, Ard Biesheuvel >> wrote: >>> On 27 February 2018 at 16:09, Laszlo Ersek wrote: On 02/27/18 15:21,

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 27 February 2018 at 16:10, Ard Biesheuvel wrote: > On 27 February 2018 at 16:09, Laszlo Ersek wrote: >> On 02/27/18 15:21, Ard Biesheuvel wrote: >>> On 27 February 2018 at 10:43, Laszlo Ersek wrote: On 02/27/18 10:23, Ard

Re: [edk2] [Patch] MdePkg SafeIntLib: Update API definition to use the same output name

Reviewed-By: Bret Barkelew bret.barke...@microsoft.com - Bret From: Kinney, Michael D Sent: Wednesday, January 31, 2018 11:29 AM To: Gao, Liming; edk2-devel@lists.01.org; Kinney, Michael

Re: [edk2] [PATCH edk2-platforms] Silicon/SynQuacer: add stage 2 override translation tables for PCIe

On Tue, Feb 27, 2018 at 05:45:09PM +, Ard Biesheuvel wrote: > >> > +[Sources] > >> > + Stage2Tables.S > >> > + > >> > +[Packages] > >> > + MdePkg/MdePkg.dec > >> > + Silicon/Socionext/SynQuacer/SynQuacer.dec > >> > + > >> > +[BuildOptions] > >> > + *_*_*_OBJCOPY_PATH == objcopy > >> > +

Re: [edk2] [PATCH 2/2] MdeModulePkg/BaseSerialPortLib16550: Prevent truncating constant values.

Hi Marvin, On 02/27/18 17:49, Marvin Häuser wrote: > The toolcahin VS2015x86 issues warnings when truncating constant > values. Explicitely cast such to avoid it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marvin Haeuser > --- >

Re: [edk2] [PATCH 2/2] MdeModulePkg/BaseSerialPortLib16550: Prevent truncating constant values.

Hey Laszlo, Thanks for your... detailed explanation. :) I actually submitted another patch to prevent what you explained - "[edk2] [PATCH 1/2] MdePkg/Base.h: Ensure safe bitwise operations.", which marks all BIT defines (and more) as unsigned. Most definitely I should have mentioned it in the

Re: [edk2] [PATCH 2/2] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Clear C-bit when SEV is active

Hi Laszlo, On 2/27/18 11:17 AM, Laszlo Ersek wrote: > Hi Brijesh, > > you provided a lot of information (and it seems like your analysis was > advancing in parallel with your email -- I too do that sometimes :) ), > so it's not easy for me to write a concise response. > > * Regarding the C-bit

Re: [edk2] [PATCH] MdePkg/BaseSafeIntLib: Fix VS IA32 NOOPT target build failure

Reviewed-By: Bret Barkelew bret.barke...@microsoft.com - Bret From: Hao Wu Sent: Monday, February 12, 2018 6:09 PM To: edk2-devel@lists.01.org Cc: Hao Wu; Michael D Kinney;

Re: [edk2] [PATCH] BaseTools/tools_def: use separate PP definition for DTC

On 27 February 2018 at 18:33, Leif Lindholm wrote: > On Tue, Feb 27, 2018 at 05:51:32PM +, Ard Biesheuvel wrote: >> Clang's preprocessor behaves differently from GCC's, and produces >> intermediate device tree source that still contains #pragma pack() >> and other

Re: [edk2] [PATCH 1/2] MdeModulePkg/PciBusDxe: Prevent truncating constant values.

On 02/27/18 17:49, Marvin Häuser wrote: > The toolcahin VS2015x86 issues warnings when truncating constant > values. Explicitely cast such to avoid it. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marvin Haeuser > --- >

Re: [edk2] [Patch v2 0/3] MdeModulePkg: Add Boot Logo 2 Protocol

Reviewed-by: Sean Brogan -Original Message- From: Kinney, Michael D Sent: Thursday, February 15, 2018 2:52 PM To: edk2-devel@lists.01.org Cc: Sean Brogan ; Bret Barkelew ;

Re: [edk2] [PATCH 2/2] MdePkg/UefiSpec.h: Ensure safe bitwise operations.

Hey Laszlo, Thanks for your reply. Comments are inline. Regards, Marvin. > -Original Message- > From: Laszlo Ersek > Sent: Tuesday, February 27, 2018 7:59 PM > To: Marvin Häuser ; edk2- > de...@lists.01.org > Cc:

Re: [edk2] [PATCH] BaseTools/tools_def: use separate PP definition for DTC

On Tue, Feb 27, 2018 at 07:02:06PM +, Ard Biesheuvel wrote: > On 27 February 2018 at 18:58, Leif Lindholm wrote: > > On Tue, Feb 27, 2018 at 06:36:08PM +, Ard Biesheuvel wrote: > >> On 27 February 2018 at 18:33, Leif Lindholm > >>

Re: [edk2] [PATCH 1/2] MdePkg/Base.h: Ensure safe bitwise operations.

Hey Laszlo, Thank you very much for your review, again. Comments are inline. Regards, Marvin. > -Original Message- > From: Laszlo Ersek > Sent: Tuesday, February 27, 2018 8:54 PM > To: Marvin Häuser ; edk2- > de...@lists.01.org > Cc:

Re: [edk2] [PATCH] BaseTools/tools_def: use separate PP definition for DTC

On Tue, Feb 27, 2018 at 05:51:32PM +, Ard Biesheuvel wrote: > Clang's preprocessor behaves differently from GCC's, and produces > intermediate device tree source that still contains #pragma pack() > and other directives that the device tree compiler chokes on. > > For assembling device tree

Re: [edk2] [PATCH] BaseTools/tools_def: use separate PP definition for DTC

On 27 February 2018 at 18:58, Leif Lindholm wrote: > On Tue, Feb 27, 2018 at 06:36:08PM +, Ard Biesheuvel wrote: >> On 27 February 2018 at 18:33, Leif Lindholm wrote: >> > On Tue, Feb 27, 2018 at 05:51:32PM +, Ard Biesheuvel wrote: >>

Re: [edk2] [PATCH edk2-platforms] Platform/96Boards/Secure96Dxe: remove /plugin/ from .dts

On Tue, Feb 27, 2018 at 06:26:19PM +, Ard Biesheuvel wrote: > Even though the Secure96 device tree source is strictly an overlay, we > managed to express it in a way that does not rely on unresolved symbols > and other tricks that are only implemented in fairly recent versions of > the device

[edk2] [Patch v2] MdePkg/Include/IndustryStandard: Add PCI Express 4.0 header file

v2: The structure is updated to include all the fields defined in the PCI-E specification. The header includes Physical Layer PCI Express Extended Capability definitions described in section 7.7.5 of PCI Express Base Specification rev. 4.0. Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [PATCH 1/2] MdeModulePkg/PciBusDxe: Prevent truncating constant values.

> On Feb 27, 2018, at 10:42 AM, Laszlo Ersek wrote: > > On 02/27/18 17:49, Marvin Häuser wrote: >> The toolcahin VS2015x86 issues warnings when truncating constant >> values. Explicitely cast such to avoid it. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >>

Re: [edk2] [PATCH 2/2] MdePkg/UefiSpec.h: Ensure safe bitwise operations.

Hi Marvin, a request in advance: could you turn on threading (and *shallow* threading at that) in your git-send-email config? The way you sent these patches, they are not collected in a single thread; the patches are scattered across the archive / my edk2-devel folder. To the patch: On 02/27/18

Re: [edk2] [PATCH 1/2] MdeModulePkg/PciBusDxe: Prevent truncating constant values.

Hello Andrew, Thanks for your input. I already submitted a patch to do that: "[edk2] [PATCH 1/2] MdePkg/Base.h: Ensure safe bitwise operations." Would be great if you took a look. Thanks, Marvin. From: af...@apple.com Sent: Tuesday, February 27, 2018 7:50 PM To: Laszlo Ersek

Re: [edk2] [PATCH] BaseTools/tools_def: use separate PP definition for DTC

On Tue, Feb 27, 2018 at 06:36:08PM +, Ard Biesheuvel wrote: > On 27 February 2018 at 18:33, Leif Lindholm wrote: > > On Tue, Feb 27, 2018 at 05:51:32PM +, Ard Biesheuvel wrote: > >> Clang's preprocessor behaves differently from GCC's, and produces > >>

Re: [edk2] [PATCH 1/2] MdePkg/Base.h: Ensure safe bitwise operations.

On 02/27/18 17:47, Marvin Häuser wrote: > As per the C standard, bit-level operations on signed integers are > either undefined or implementation-defined. Hence, mark all BIT > defines and shifts as unsigned to safely allow such operations. Sigh, this is why threading is important in patch sets.

[edk2] [PATCH V2]BaseTools: Fix flexible PCD single quote and double quote bugs

V2: 1. Fix parse DSC file split PCD Value {'9','a','#'} build error 2. Fix parse --pcd gUefiOvmfPkgTokenSpaceGuid.test10="\'A\'" build error, If PCD type is UINT8 or UINT16 or UINT32 or UINT64 V1: 1. Argument --pcd format as below: Some examples that to match --pcd format and DSC format

Re: [edk2] [RFC v4 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On 27 February 2018 at 08:48, Ni, Ruiyu wrote: > On 2/27/2018 10:09 AM, Heyi Guo wrote: >> >> PCI address translation is necessary for some non-x86 platforms. On >> such platforms, address value (denoted as "device address" or "address >> in PCI view") set to PCI BAR registers

[edk2] [PATCH edk2-platforms 2/5] Silicon/SynQuacer: tweak PCI I/O windows for ACPI/Linux support

ACPI is not able to describe PCI resource windows that involve both type and address translation (i.e., for I/O windows on architectures that do not support port I/O natively), and so the ACPI/Linux code has a hard time performing the resource allocation in such cases. For instance, the secondary

[edk2] [PATCH edk2-platforms 5/5] Silicon/SynQuacer/PlatformDxe: add ACPI description of eMMC

Expose a separate ACPI description of the SynQuacer eMMC controller when both ACPI and eMMC support have been enabled in the HII menu. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH edk2-platforms 4/5] Silicon/SynQuacer/PlatformDxe: add option to enable ACPI mode

Create a HII menu option to choose between device tree and ACPI platform descriptions. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c | 32

[edk2] [PATCH edk2-platforms 3/5] Silicon/SynQuacer: add ACPI drivers and tables

Add the ACPI tables describing various parts of the SynQuacer SoC and its peripherals, and the drivers to expose them to the EvalBoard and DeveloperBox platforms. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel ---

[edk2] [PATCH edk2-platforms 0/5] SynQuacer ACPI support

This implements ACPI support for the SynQuacer platforms. Note that supporting ACPI on this SoC is non-trivial, due to the quirky DesignWare RCs and the pre-ITS that sits between the PCIe RCs and the GICv3. However, the most important issue has been addressed by modifying the static SMMU

Re: [edk2] [RFC v4 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On 2/27/2018 5:33 PM, Guo Heyi wrote: Hi Ray, Thanks for your comments. It seems comments 10 and 12 are the major issue; let's discuss that first. 1. In current implementation, namely PciBusDxe and PciHostBridgeDxe both in MdeModulePkg, Address parameter passed to RootBridgeIoMemRead comes

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

On 02/27/18 06:48, Ni, Ruiyu wrote: > On 2/27/2018 8:48 AM, Guo Heyi wrote: >> Hi Laszlo, >> >> I agree the current patch makes the code ugly, and turning the logic >> into a >> normal loop should be the perfect solution. If Ray also agrees on it, >> I can try >> to do that. >> >> Thanks and

[edk2] [Patch] BaseTools: Resolve BaseTools C tool build failure

New GUID definition is conflicted with GUID in Windows Kits guiddef.h. GUID definition will be defined when it is undefined. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao --- BaseTools/Source/C/GenFv/GenFvInternalLib.c | 2 +-

[edk2] [PATCH edk2-platforms 1/5] Platform/Socionext/DeveloperBox: fix PCIe slot to B/D/F mapping

Fix the static B/D/F specifiers that refer to the pair of x1 PCIe slots on the DeveloperBox PCB. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Silicon/Socionext/SynQuacer/Include/Platform/Pcie.h | 4 ++-- 1 file changed, 2

Re: [edk2] [patch v2] MdePkg/BaseSafeIntLib: Fix VS2015 IA32 NOOPT build failure

On 02/27/18 02:47, Dandan Bi wrote: > v2: Add [LibraryClasses] section in INF file and refine coding style. > > There are VS2015 NOOPT IA32 build failure like below in BaseSafeIntLib. > XXX.lib(XXX.obj): error LNK2001: unresolved external symbol __allmul > XXX.lib(XXX.obj): error LNK2001:

Re: [edk2] [RFC v1 1/1] MdeModulePkg/Usb: Use Pcd for UsbBootIoBlocks

On 2/27/2018 5:25 PM, Ming Huang wrote: On 2018/2/27 13:25, Ni, Ruiyu wrote: I don't prefer to add PCD, unless we cannot find: 1. spec content to describe the max/min blocks There is no spec about the max/min blocks in my mind. I had checked this in several pdf document like Universal

Re: [edk2] [RFC v4 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On 27 February 2018 at 09:59, Ni, Ruiyu wrote: > On 2/27/2018 5:33 PM, Guo Heyi wrote: >> >> Hi Ray, >> >> Thanks for your comments. It seems comments 10 and 12 are the major issue; >> let's >> discuss that first. >> >> 1. In current implementation, namely PciBusDxe and

Re: [edk2] [RFC v4 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On 2/27/2018 10:09 AM, Heyi Guo wrote: PCI address translation is necessary for some non-x86 platforms. On such platforms, address value (denoted as "device address" or "address in PCI view") set to PCI BAR registers in configuration space might be different from the address which is used by CPU

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 27 February 2018 at 01:50, Guo Heyi wrote: > Hi Ard, > > Sorry for the late of seeing this patch. I have one question: why don't we > implement a runtime serial port lib, which will switch UART base address in > virtual address map change? I think this will be useful when

Re: [edk2] [RFC v1 1/1] MdeModulePkg/Usb: Use Pcd for UsbBootIoBlocks

On 2018/2/27 13:25, Ni, Ruiyu wrote: > I don't prefer to add PCD, unless we cannot find: > 1. spec content to describe the max/min blocks There is no spec about the max/min blocks in my mind. I had checked this in several pdf document like Universal Serial Bus Mass Storage Class Specification

Re: [edk2] [RFC v4 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

Hi Ray, Thanks for your comments. It seems comments 10 and 12 are the major issue; let's discuss that first. 1. In current implementation, namely PciBusDxe and PciHostBridgeDxe both in MdeModulePkg, Address parameter passed to RootBridgeIoMemRead comes from PciIoMemRead(). 2. In PciIoMemRead(),

Re: [edk2] [PATCH] UefiCpuPkg/CpuExceptionHandlerLib: fix incorrect init of exception stack

On 02/27/18 06:19, Jian J Wang wrote: > The field KnownGoodStackTop in CPU_EXCEPTION_INIT_DATA is initialized to > the start address of array mNewStack. This is wrong. It must be the end > of mNewStack. This patch fixes this mistake. > > Cc: Ruiyu Ni > Cc: Eric Dong

Re: [edk2] [PATCH] MdePkg/Include/IndustryStandard: Add PCI Express 4.0 header file

Felix: Structure PCI_EXPRESS_EXTENDED_CAPABILITIES_PHYSICAL_LAYER_16_0 is not same to the one defined in spec. Could you define the complete structure? Thanks Liming >-Original Message- >From: Felix Polyudov [mailto:fel...@ami.com] >Sent: Monday, February 26, 2018 10:20 PM >To:

Re: [edk2] [RFC PATCH edk2-non-osi] Platform/DeveloperBox: add prebuilt binary containing stage 2 page tables

On Fri, Feb 23, 2018 at 01:28:58PM +, Ard Biesheuvel wrote: > Now that the secure firmware image BL31 has been moved back into secure > memory where it belongs, we can no longer keep the stage2 translation > tables in the same image, given that EL2 is non-secure. > > So instead, let's put

Re: [edk2] [PATCH] EmbeddedPkg/Drivers: add virtual keyboard driver

On Mon, Feb 26, 2018 at 04:52:36PM +0800, Haojian Zhuang wrote: > The virtual keyboard could simulate a keyboard. User could simulate > a key value when pattern is matched. How? This is over 2000 lines of new code, please give a little bit more description of what it does and how it is intended

Re: [edk2] [PATCH 1/2] OvmfPkg/AmdSevDxe: Clear the C-bit from SMM Saved State

Hi Laszlo, Apologies for late response. I needed to do some investigation on SMM before responding to you. On 2/22/18 5:20 AM, Laszlo Ersek wrote: > Hi Brijesh! > > (adding Paolo and Mike; more comments below) > > On 02/21/18 17:52, Brijesh Singh wrote: >> When OVMF is built with SMM, SMMSaved

Re: [edk2] [PATCH 2/2] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Clear C-bit when SEV is active

On 2/22/18 6:08 AM, Laszlo Ersek wrote: > On 02/21/18 17:52, Brijesh Singh wrote: >> Commit:24e4ad7 (OvmfPkg: Add AmdSevDxe driver) added a driver which runs >> early in PEI phase and clears the C-bit from all MMIO regions (including > s/PEI/DXE/ > > >> Qemu Flash). When SMM is enabled, we build

Re: [edk2] [Patch] BaseTools: Resolve BaseTools C tool build failure

Please help to update copyright year when push the patch. thanks. Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Tuesday, February 27, 2018 4:57 PM

[edk2] [PATCH edk2-platforms] Silicon/SynQuacer: add stage 2 override translation tables for PCIe

The Designware PCIe IP in the SynQuacer SoC needs a little help to appear sane to the OS. Not only does it lack a true root port, and therefore does not perform any filtering whatsoever of type 0 config TLPs that are not intended for the link peer, it also has trouble issuing 64-bit wide MMIO

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 02/27/18 10:23, Ard Biesheuvel wrote: > On 27 February 2018 at 01:50, Guo Heyi wrote: >> Hi Ard, >> >> Sorry for the late of seeing this patch. I have one question: why don't we >> implement a runtime serial port lib, which will switch UART base address in >> virtual

Re: [edk2] [Patch V3] DSC spec: Add flexible PCD value format into spec

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Monday, February 26, 2018 4:05 PM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Shaw, Kevin W

Re: [edk2] [RFC] Add Platform Include path in modules

Hi, For the first one, the same PCD can be configured to the different value for the different SkuId. Here is wiki on structure pcd enable step and examples. https://github.com/lgao4/edk2/wiki/StructurePcd-Enable-Steps TestPkg in https://github.com/lgao4/edk2/tree/UDK2018 has the sample

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On Tue, Feb 27, 2018 at 11:43:35AM +0100, Laszlo Ersek wrote: > On 02/27/18 10:23, Ard Biesheuvel wrote: > > On 27 February 2018 at 01:50, Guo Heyi wrote: > >> Hi Ard, > >> > >> Sorry for the late of seeing this patch. I have one question: why don't we > >> implement a

Re: [edk2] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: limit recursive call depth

Thanks Ray and Laszlo, I will create v2 according to your comments. Regards, Heyi On Tue, Feb 27, 2018 at 11:29:18AM +0100, Laszlo Ersek wrote: > On 02/27/18 06:48, Ni, Ruiyu wrote: > > On 2/27/2018 8:48 AM, Guo Heyi wrote: > >> Hi Laszlo, > >> > >> I agree the current patch makes the code

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On Sat, Feb 24, 2018 at 02:25:14PM +, Ard Biesheuvel wrote: > Commit 4bf95a9f361e ("MdeModulePkg/ResetSystemRuntimeDxe: Add more > debug message") broke the DEBUG build for all platforms that rely on > MMIO mapped UART devices, since it introduces a DEBUG() print that > may trigger at runtime,

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 27 February 2018 at 10:39, Leif Lindholm wrote: > On Sat, Feb 24, 2018 at 02:25:14PM +, Ard Biesheuvel wrote: >> Commit 4bf95a9f361e ("MdeModulePkg/ResetSystemRuntimeDxe: Add more >> debug message") broke the DEBUG build for all platforms that rely on >> MMIO

Re: [edk2] [RFC v4 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On Tue, Feb 27, 2018 at 05:59:48PM +0800, Ni, Ruiyu wrote: > On 2/27/2018 5:33 PM, Guo Heyi wrote: > >Hi Ray, > > > >Thanks for your comments. It seems comments 10 and 12 are the major issue; > >let's > >discuss that first. > > > >1. In current implementation, namely PciBusDxe and

Re: [edk2] [RFC v4 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

Hi all, I believe we have come to conclusion for major parts, so I'm going to send out formal patches instead of RFC from now on, as well as applying changes to the existing implementations of PciHostBridgeLib in the tree. Thanks for your comments and advice. Heyi On Tue, Feb 27, 2018 at

Re: [edk2] [PATCH edk2-platforms 1/2] Platform, Silicon: use DxeRuntimeDebugLibSerialPort for runtime DXE drivers

On 27 February 2018 at 10:43, Laszlo Ersek wrote: > On 02/27/18 10:23, Ard Biesheuvel wrote: >> On 27 February 2018 at 01:50, Guo Heyi wrote: >>> Hi Ard, >>> >>> Sorry for the late of seeing this patch. I have one question: why don't we >>> implement a

[edk2] [PATCH] Maintainers.txt: Add Jiewen to be co-maintainer of SecurityPkg.

From: Jiewen Yao Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jiewen Yao --- Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt

Re: [edk2] [Patch 1/4] BaseTools: Fixed the pcd value override issue.

Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Wednesday, February 28, 2018 1:59 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch 1/4] BaseTools: Fixed the pcd

Re: [edk2] [Patch v2] MdePkg/Include/IndustryStandard: Add PCI Express 4.0 header file

Good day, Please consider for compatibility with some toolchains, byte-packed structs and unions must be decorated with the define 'PACKED'. Thanks, Marvin. > -Original Message- > From: edk2-devel On Behalf Of Felix > Polyudov > Sent: Tuesday, February

Re: [edk2] 'fastboot boot' TPL

Are you sure? If you look at this file: https://github.com/tianocore/edk2/blob/master/EmbeddedPkg/Application/AndroidFastboot/AndroidFastbootApp.c The DataReady Event is a TPL_CALLBACK event. >From there the call chain goes as follows: AcceptCmd -> HandleBoot -> BootAndroidBootImg ->

Re: [edk2] 'fastboot boot' TPL

Violating the spec is undefined behavior. If it works that is bad luck, or good luck depending on your point of view. Sent from my iPhone > On Feb 27, 2018, at 11:33 PM, Michael Zimmermann > wrote: > > Are you sure? > > If you look at this file: >

Re: [edk2] [RFC v4 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On Wed, Feb 28, 2018 at 03:25:03PM +0800, Ni, Ruiyu wrote: > On 2/28/2018 10:29 AM, Ni, Ruiyu wrote: > >On 2/27/2018 7:44 PM, Guo Heyi wrote: > >>Hi all, > >> > >>I believe we have come to conclusion for major parts, so I'm going to > >>send out > >>formal patches instead of RFC from now on, as

Re: [edk2] 'fastboot boot' TPL

I feel like both of you misunderstood my intention. As I said in my initial mail, I'm not arguing the spec - I know that StartImage must be called from TPL_APPLICATION. I'm just discussing a bug inside EmbeddedPkg/Application/AndroidFastboot - because they actually do call StartImage from

Re: [edk2] [PATCH] BaseTools: Fix report not used --pcd value incorrectly

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Tuesday, February 27, 2018 3:38 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH]

Re: [edk2] [PATCH V2]BaseTools: Fix flexible PCD single quote and double quote bugs

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Tuesday, February 27, 2018 4:43 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH

Re: [edk2] [PATCH] EmbeddedPkg/Drivers: add virtual keyboard driver

On 02/27/2018 08:28 PM, Leif Lindholm wrote: > On Mon, Feb 26, 2018 at 04:52:36PM +0800, Haojian Zhuang wrote: >> The virtual keyboard could simulate a keyboard. User could simulate >> a key value when pattern is matched. > > How? This is over 2000 lines of new code, please give a little bit >

Re: [edk2] [patch v2] MdePkg/BaseSafeIntLib: Fix VS2015 IA32 NOOPT build failure

Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Tuesday, February 27, 2018 9:47 AM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Gao, Liming ; > Kinney, Michael D >

Re: [edk2] [RFC v4 1/3] MdeModulePkg/PciHostBridgeDxe: Add support for address translation

On 2/27/2018 7:44 PM, Guo Heyi wrote: Hi all, I believe we have come to conclusion for major parts, so I'm going to send out formal patches instead of RFC from now on, as well as applying changes to the existing implementations of PciHostBridgeLib in the tree. Thanks for your comments and

Re: [edk2] [PATCH] BaseTools/tools_def: use separate PP definition for DTC

Reviewed-by: Liming Gao > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, February 28, 2018 4:01 AM > To: Ard Biesheuvel > Cc: edk2-devel@lists.01.org; Gao, Liming ; Zhu,

Re: [edk2] [PATCH 2/2] MdeModulePkg/BaseSerialPortLib16550: Prevent truncating constant values.

Could simply use 0xFFFC for this case? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin H?user Sent: Wednesday, February 28, 2018 2:56 AM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Laszlo Ersek

Re: [edk2] [PATCH] MdePkg/UefiLib: Add 'OUT' decorator where necessary.

Please also update the one in IntelFrameworkPkg UefiLib. > -Original Message- > From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] > Sent: Wednesday, February 28, 2018 12:47 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming >

[edk2] [Patch] BaseTools: Enhance FV info report file path to support absolute path

When generate build report, Tool will get the info like size, Fv Name, etc from the xx.Fv.txt file and add these info into the build report. This patch support the xx.Fv.txt to use absolute file path format since user may provide specified FV path. Contributed-under: TianoCore Contribution

[edk2] 'fastboot boot' TPL

>From looking at the code it seems to me that StartImage is called from TPL_CALLBACK. According to the Spec StartImage can only be called from https://lists.01.org/mailman/listinfo/edk2-devel

Re: [edk2] [Patch] BaseTools: Enhance FV info report file path to support absolute path

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Wednesday, February 28, 2018 11:11 AM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Enhance FV info report

Re: [edk2] [Patch] BaseTools: Fix a bug override Pcd by DSC Components section

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Monday, February 26, 2018 3:49 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Fix a bug override Pcd by DSC

[edk2] [Patch 1/4] BaseTools: Fixed the pcd value override issue.

1. the issue in the overriding value from command line. 2. dec fully value < dec field assign value < dsc fully value < dsc field assign value Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao ---

  1   2   >