[edk2] [PATCH 1/3] BaseTools/header.makefile: add "-Wno-stringop-truncation"

gcc-8 (which is part of Fedora 28) enables the new warning "-Wstringop-truncation" in "-Wall". This warning is documented in detail at ; the introduction says > Warn for calls to bounded string manipulation functions such as strncat, >

[edk2] [PATCH 0/3] BaseTools: let the C-language build utils compile with gcc-8

Repo: https://github.com/lersek/edk2.git Branch: basetools_gcc8 Once these patches are applied to the build flags and the source code of the build utilities themselves, OVMF builds fine with gcc-8, using the GCC5 toolchain settings without any changes. Regression-tested with gcc-4.8 / x86_64.

[edk2] [PATCH 3/3] BaseTools/GenVtf: silence false "stringop-overflow" warning with memcpy()

gcc-8 (which is part of Fedora 28) enables the new warning "-Wstringop-overflow" in "-Wall". This warning is documented in detail at ; the introduction says > Warn for calls to string manipulation functions such as memcpy and > strcpy that

[edk2] [Patch] BaseTools: Fix the bug to search Fv.txt file relative to workspace

when the SECTION FV_IMAGE = $(XX)/XX.Fv, the Fv file should relative to WORKSPACE, so when we search the XX.Fv.txt file, we should search the path relative to workspace first. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu ---

Re: [edk2] [Patch v3] MdePkg/Include/IndustryStandard: Add PCI Express 4.0 header file

Reviewed-by: Liming Gao > -Original Message- > From: Felix Polyudov [mailto:fel...@ami.com] > Sent: Friday, March 2, 2018 11:49 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > ;

[edk2] [Patch] BaseTools: Pcd Value override issue.

For the case that the structure PCD has no value assignment in DSC, but has value assignment in command line. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao ---

Re: [edk2] How to handle pflash backed OVMF FW upgrade and live migration best?

* Laszlo Ersek (ler...@redhat.com) wrote: > CC Dave > > On 03/01/18 12:21, Thomas Lamprecht wrote: > > Hi, > > > > I'm currently evaluating how to update the firmware (OVMF) code image > > without impacting a KVM/QEMU VM on live migration. I.e., the FW code lives > > under

Re: [edk2] [PATCH edk2-platforms v2 06/18] ARM/VExpressPkg: Add and update debug ASSERTS

On 28 February 2018 at 20:27, Evan Lloyd wrote: > Hi Leif, Ard. > Can I get you two argue out the pros and cons of the "ASSERT(FALSE)" debate, > please. I can argue the cons if you like. For the pros, you'll have to wait for Leif to return from holiday (in a week or two

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: put mReservedApLoopFunc in executable memory

Regards, Jian > -Original Message- > From: Ni, Ruiyu > Sent: Friday, March 02, 2018 7:58 PM > To: Laszlo Ersek ; Wang, Jian J ; > edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: Re: [PATCH] UefiCpuPkg/MpInitLib: put

[edk2] [PATCH] ShellPkg/ConsoleLogger: Fix a typo in UpdateDisplayFromHistory()

Within function UpdateDisplayFromHistory(): When getting a character with different attribute with the current one, the statement to compare the character with a 'NULL' char should be: *StringSegmentEnd != CHAR_NULL rather than: StringSegmentEnd != CHAR_NULL This commit resolves this typo.

Re: [edk2] [Patch] BaseTools: Correct Structure Pcd value in the report

Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Friday, March 2, 2018 10:53 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: Correct Structure Pcd

[edk2] [PATCH v2] MdePkg/DevicePathFromText: Fix byte orders of iSCSI.Lun

Per UEFI spec, iSCSI.Lun is a 8-byte array with byte #0 in the left. It means "0102030405060708" should be converted to: UINT8[8] = {01, 02, 03, 04, 05, 06, 07, 08} or UINT64 = {0807060504030201} Today's implementation wrongly uses the reversed order. Contributed-under: TianoCore

Re: [edk2] [PATCH v2] MdePkg/DevicePathFromText: Fix byte orders of iSCSI.Lun

Reviewed-by: Liming Gao > -Original Message- > From: Ni, Ruiyu > Sent: Saturday, March 3, 2018 1:11 PM > To: edk2-devel@lists.01.org > Cc: Lin, Jie ; Gao, Liming ; Zhu, > Yonghong > Subject: [PATCH

[edk2] [Patch V2] BaseTools: DSC Components section support flexible PCD

From: Yunhua Feng DSC Components section support flexible PCD, and for binary driver, we need patch this value. Update the split char ',' not ', ' because some value may have space, while others may not have this space. Cc: Liming Gao Cc: Yonghong

Re: [edk2] [PATCH] BaseTools: Dsc/Fdf conditional statement parse issue

Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: Feng, YunhuaX Sent: Thursday, March 01, 2018 8:42 PM To: edk2-devel@lists.01.org Cc: Zhu, Yonghong ; Gao, Liming Subject: [PATCH]

Re: [edk2] [Patch] BaseTools: Pcd Value override issue.

Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Friday, March 2, 2018 11:52 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch] BaseTools: Pcd Value override issue.

Re: [edk2] [Patch] BaseTools: Fix the bug to search Fv.txt file relative to workspace

Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Saturday, March 3, 2018 1:09 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch] BaseTools: Fix the bug to search

Re: [edk2] [Patch V2] BaseTools: DSC Components section support flexible PCD

Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Saturday, March 3, 2018 9:12 AM > To: edk2-devel@lists.01.org > Cc: Feng, YunhuaX ; Gao, Liming > Subject: [Patch V2] BaseTools: DSC Components

Re: [edk2] [PATCH] ShellPkg/ConsoleLogger: Fix a typo in UpdateDisplayFromHistory()

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: Wu, Hao A > Sent: Saturday, March 3, 2018 11:05 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Carsey, Jaben > ; Ni, Ruiyu > Subject:

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: put mReservedApLoopFunc in executable memory

Thanks/Ray > -Original Message- > From: Wang, Jian J > Sent: Saturday, March 3, 2018 9:32 AM > To: Ni, Ruiyu ; Laszlo Ersek ; > edk2-devel@lists.01.org > Cc: Dong, Eric > Subject: RE: [PATCH] UefiCpuPkg/MpInitLib: put

Re: [edk2] [PATCH 0/5] Fix UsbMassStorage driver for device compatibility

Reviewed-by: Star Zeng Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Friday, March 2, 2018 7:55 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH 0/5] Fix UsbMassStorage driver for device

[edk2] [PATCH] MdeModulePkg UsbMass: Correct comment about TPL for BLOCK IO APIs

Current BLOCK IO API code is using TPL_CALLBACK, but comment is saying TPL_NOTIFY. Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassImpl.c | 6 +++--- 1 file

[edk2] [Patch 2/2] BaseTools: Fix byte orders when handling 8-byte array

Per UEFI spec, FibreEx.WWN, FibreEx.Lun, SasEx.Address, SasEx.Lun and iSCSI.Lun are all 8-byte array with byte #0 in the left. It means "0102030405060708" should be converted to: UINT8[8] = {01, 02, 03, 04, 05, 06, 07, 08} or UINT64 = {0807060504030201} Today's implementation wrongly uses

[edk2] [Patch 1/2] BaseTools: Fix bug when converting iSCSI node

If protocol string is not specified, default TCP(0) should be used. Today's implementation wrongly sets to 1 for this case. Copy the fix solution from MdePkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu ---

Re: [edk2] [Patch 1/2] BaseTools: Fix bug when converting iSCSI node

Reviewed-by: Liming Gao Please update commit message with MdePkg Fix hash value. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Saturday, March 3, 2018 3:36 PM > To: edk2-devel@lists.01.org >

Re: [edk2] [PATCH] MdeModulePkg UsbMass: Correct comment about TPL for BLOCK IO APIs

On 3/3/2018 3:31 PM, Star Zeng wrote: Current BLOCK IO API code is using TPL_CALLBACK, but comment is saying TPL_NOTIFY. Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng ---

Re: [edk2] [Patch 2/2] BaseTools: Fix byte orders when handling 8-byte array

On 3/3/2018 3:35 PM, Yonghong Zhu wrote: Per UEFI spec, FibreEx.WWN, FibreEx.Lun, SasEx.Address, SasEx.Lun The commit message is wrong. and iSCSI.Lun are all 8-byte array with byte #0 in the left. It means "0102030405060708" should be converted to: UINT8[8] = {01, 02, 03, 04, 05, 06, 07,

Re: [edk2] [PATCH 1/7] SecurityPkg/Tcg2Pei: drop Tcg2PhysicalPresenceLib dependency

On 02/24/18 01:09, Yao, Jiewen wrote: > Reviewed-by: jiewen@intel.com Given that Jiewen co-maintains SecurityPkg as of commit 3db2823f1e27 ("Maintainers.txt: Add Jiewen to be co-maintainer of SecurityPkg.", 2018-03-02), I pushed this patch in isolation: commit a39e72267034. However,

Re: [edk2] [PATCH v1 4/4] edk2-platforms: created RDK Qemu platform for RDK UEFI applications

On 12 February 2018 at 10:31, Moorthy Baskaravenkatraman wrote: > From: Kalyan Nagabhirava > > Linaro and RDK are working on standardizing the boot process for RDK > STB boxes using Uefi. Implmented couple of

[edk2] [Patch] BaseTools: Correct Structure Pcd value in the report

The patch "Fixed build failed issue" changed structure Pcd Object, so we need update build report to correct structure Pcd Value. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/build/BuildReport.py | 72

Re: [edk2] [PATCH 3/3] UefiCpuPkg S3ResumePei: Signal S3SmmInitDone

On 03/02/18 06:15, Star Zeng wrote: > Cc: Jiewen Yao > Cc: Eric Dong > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- >

[edk2] [Patch 2/2] BaseTools: Fixed build failed issue.

Case 1. A Pcd has no default sku setting in DSC. Case 2. Build as Single SKU. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao --- BaseTools/Source/Python/Workspace/DscBuildData.py | 21

Re: [edk2] [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: Init PCI aperture to 0

On 03/01/18 11:48, Guo Heyi wrote: > On Thu, Mar 01, 2018 at 11:17:30AM +0100, Laszlo Ersek wrote: >> On 03/01/18 07:57, Heyi Guo wrote: >>> diff --git a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c >>> b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c >>> index 31c63ae19e0a..aaf101dfcb0e 100644

[edk2] [Patch 1/2] BaseTools: Fixed Pcd value override issue.

1. Handle the Pcd maxsize issue for the case that the length of Pcd value from CommandLine bigger that its maxsize 2. The Pcd value override in commandline. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Bob Feng Cc: Liming Gao

Re: [edk2] [PATCH 4/7] ovmf: link with Tcg2Pei module

On 03/01/18 16:08, Marc-André Lureau wrote: > Hi > > On Mon, Feb 26, 2018 at 10:38 AM, Laszlo Ersek wrote: >> On 02/23/18 14:23, marcandre.lur...@redhat.com wrote: >>> From: Marc-André Lureau >>> >>> This module will initialize TPM device, measure

Re: [edk2] [PATCH 01/20] OvmfPkg/MemEncryptSevLib: rewrap to 79 characters width

Hi Mike, On 03/02/18 01:33, Kinney, Michael D wrote: > Laszlo, > > Sorting #includes looks strange to me. > > We usually include the top level environment include > first (e.g. ) and then the libs, protocols, > ppis, GUIDs grouped together. > > If it is a lib module, the produced libs are

Re: [edk2] [PATCH v5 2/6] OvmfPkg/PciHostBridgeLib: Init PCI aperture to 0

On 03/01/18 13:03, Ni, Ruiyu wrote: > On 3/1/2018 6:20 PM, Laszlo Ersek wrote: >> On 03/01/18 07:57, Heyi Guo wrote: >>> Use ZeroMem to initialize all fields in temporary >>> PCI_ROOT_BRIDGE_APERTURE variables to zero. This is not mandatory but >>> is helpful for future extension: when we add new

Re: [edk2] [PATCH 2/7] ovmf: link with Tcg2ConfigPei module

On 03/01/18 15:59, Marc-André Lureau wrote: > Hi > > On Fri, Feb 23, 2018 at 6:31 PM, Laszlo Ersek wrote: >> (6) Now, I realize Tcg2Pei *apparently* depends on >> gEfiPeiReadOnlyVariable2PpiGuid (i.e., read-only variable access in the >> PEI phase) as well. That's a bug in

Re: [edk2] [PATCH 6/7] ovmf: link with Tcg2ConfigDxe module

On 03/01/18 17:59, Stefan Berger wrote: > On 02/26/2018 04:58 AM, Laszlo Ersek wrote: >> On 02/23/18 14:23, marcandre.lur...@redhat.com wrote: >>> From: Marc-André Lureau >>> >>> The module allows to tweak and interact with the TPM. Note that many >>> actions are

Re: [edk2] [PATCH 2/2] MdePkg/DevicePathFromText: Fix byte orders when handling 8-byte array

Reviewed-by: Liming Gao > -Original Message- > From: Ni, Ruiyu > Sent: Friday, March 2, 2018 7:52 PM > To: edk2-devel@lists.01.org > Cc: Lin, Jie ; Gao, Liming ; Zhu, > Yonghong > Subject: [PATCH

Re: [edk2] [PATCH 1/2] MdePkg/DevicePathFromText: Fix bug when converting iSCSI node

Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Friday, March 2, 2018 7:52 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 1/2] MdePkg/DevicePathFromText: Fix bug

Re: [edk2] [PATCH 00/20] OvmfPkg: SEV: decrypt the initial SMRAM save state map for SMBASE relocation

On 3/2/18 5:53 AM, Laszlo Ersek wrote: > On 03/02/18 02:16, Brijesh Singh wrote: >> >> On 3/1/18 6:03 PM, Laszlo Ersek wrote: >>> I also tried to test the series with SEV guests (again with Brijesh's v2 >>> 2/2 patch applied on top). Unfortunately, I didn't get good results with >>> or without

Re: [edk2] [Qemu-devel] [PATCH 6/7] ovmf: link with Tcg2ConfigDxe module

On 03/02/2018 06:12 AM, Laszlo Ersek wrote: On 03/01/18 17:59, Stefan Berger wrote: On 02/26/2018 04:58 AM, Laszlo Ersek wrote: On 02/23/18 14:23, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau The module allows to tweak and interact with the TPM.

Re: [edk2] [Patch 1/2] BaseTools: Fixed Pcd value override issue.

Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of BobCF > Sent: Friday, March 2, 2018 6:11 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [Patch 1/2]

Re: [edk2] [Patch 2/2] BaseTools: Fixed build failed issue.

Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Friday, March 2, 2018 6:11 PM > To: edk2-devel@lists.01.org > Cc: Feng, Bob C ; Gao, Liming > Subject: [Patch 2/2] BaseTools: Fixed build failed

Re: [edk2] [PATCH 00/20] OvmfPkg: SEV: decrypt the initial SMRAM save state map for SMBASE relocation

On 03/02/18 02:16, Brijesh Singh wrote: > > > On 3/1/18 6:03 PM, Laszlo Ersek wrote: >> I also tried to test the series with SEV guests (again with Brijesh's v2 >> 2/2 patch applied on top). Unfortunately, I didn't get good results with >> or without SMM. Without SMM, the guest OS boots to a

[edk2] [PATCH 2/5] MdeModulePkg/UsbMass: Revert "map -r" media change detection fix

This reverts commit a662afb5b023a187ef638d3cb0e0c313ad39a7fc. * MdeModulePkg/UsbStorage: Fix "map -r" cannot detect media change The above commit fixed the following issue: When system boots to Shell without CDROM inside USB CDROM drive, and then user inserts the CDROM with Eltorito file system,

[edk2] [PATCH 1/5] MdeModulePkg/UsbMass: Revert POWER_ON(29h) ASC handling logic

This reverts commit 6461344c318cd43a5494c0302e142a0cbe386d52. * MdeModulePkg/UsbMass: Fix hot-plug USB CDROM can't be recognized UsbBootExecCmd() only calls UsbBootRequestSense() to get sense key when CMD fails. When POWER ON (29h) ASC returns from REQUEST SENSE, implementation should retry the

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: put mReservedApLoopFunc in executable memory

On 3/2/2018 7:45 PM, Laszlo Ersek wrote: On 03/02/18 06:58, Jian J Wang wrote: if PcdDxeNxMemoryProtectionPolicy is enabled for EfiReservedMemoryType of memory, #PF will be triggered for each APs after ExitBootServices in SCRT test. The root cause is that AP wakeup code executed at that time is

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: put mReservedApLoopFunc in executable memory

On 03/02/18 06:58, Jian J Wang wrote: > if PcdDxeNxMemoryProtectionPolicy is enabled for EfiReservedMemoryType > of memory, #PF will be triggered for each APs after ExitBootServices > in SCRT test. The root cause is that AP wakeup code executed at that > time is stored in memory of type

[edk2] [PATCH 0/2] Bug fix in DevicePathLib regarding converting from text

Ruiyu Ni (2): MdePkg/DevicePathFromText: Fix bug when converting iSCSI node MdePkg/DevicePathFromText: Fix byte orders when handling 8-byte array .../Library/UefiDevicePathLib/DevicePathFromText.c | 36 +- 1 file changed, 22 insertions(+), 14 deletions(-) --

[edk2] [PATCH 2/2] MdePkg/DevicePathFromText: Fix byte orders when handling 8-byte array

Per UEFI spec, FibreEx.WWN, FibreEx.Lun, SasEx.Address, SasEx.Lun and iSCSI.Lun are all 8-byte array with byte #0 in the left. It means "0102030405060708" should be converted to: UINT8[8] = {01, 02, 03, 04, 05, 06, 07, 08} or UINT64 = {0807060504030201} Today's implementation wrongly uses

[edk2] [PATCH 1/2] MdePkg/DevicePathFromText: Fix bug when converting iSCSI node

If protocol string is not specified, default TCP(0) should be used. Today's implementation wrongly sets to 1 for this case. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Yonghong Zhu ---

[edk2] [PATCH 4/5] MdeModulePkg/UsbMass: remove unnecessary RestoreTPL() call

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Star Zeng --- MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git

[edk2] [PATCH 3/5] MdeModulePkg/UsbMass: Add more debug message

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Star Zeng --- MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassBoot.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[edk2] [PATCH 5/5] MdeModulePkg/UsbMass: Retry CMD for MediaChanged sense key

When a USB device reports failure for a CMD and REQUEST SENSE returns Media Changed key, UsbBootExecCmdWithRetry() stops to retry CMD and returns EFI_MEDIA_CHANGED to caller. For this case, the CMD should be retried until success, getting NoMedia sense key or timeout. The patch updates

[edk2] [PATCH 0/5] Fix UsbMassStorage driver for device compatibility

#1 and #2 are to revert the two commits made by me several weeks ago. #3 and #4 doesn't impact functionality. #5 is the real fix. I have verified the fix by trying different USB keys and one USB DVD ROM. Ruiyu Ni (5): MdeModulePkg/UsbMass: Revert POWER_ON(29h) ASC handling logic

Re: [edk2] How to handle pflash backed OVMF FW upgrade and live migration best?

CC Dave On 03/01/18 12:21, Thomas Lamprecht wrote: > Hi, > > I'm currently evaluating how to update the firmware (OVMF) code image > without impacting a KVM/QEMU VM on live migration. I.e., the FW code lives > under /usr/share/OVMF/OVMF_CODE.fd and gets passed to the QEMU command with: > >

Re: [edk2] [PATCH 00/20] OvmfPkg: SEV: decrypt the initial SMRAM save state map for SMBASE relocation

On 03/01/2018 06:03 PM, Laszlo Ersek wrote: ... I regression-tested my usual non-SEV guests (with Brijesh's v2 2/2 patch applied on top, from the above-referenced series), which covers i440fx (no SMM, X64), q35 (SMM, IA32 and IA32X64), Fedora and Windows, normal boot and S3. I also tried to

[edk2] [Patch v3] MdePkg/Include/IndustryStandard: Add PCI Express 4.0 header file

v3: LaneEqualizationControl is changed to be an array. v2: The structure is updated to include all the fields defined in the PCI-E specification. The header includes Physical Layer PCI Express Extended Capability definitions described in section 7.7.5 of PCI Express Base Specification rev.