On 10.06.24 20:14, 'Christopher Obbard' via EFI Boot Guard wrote:
> Hi,
>
> I have been doing some testing with efibootguard, it seems like efibootguard
> fails to enable the watchdog on some of my hardware. I am testing this with a
> recent Linux build with all kernel watchdog drivers not built
On 07.06.24 14:53, 'Christopher Obbard' via EFI Boot Guard wrote:
> Add watchdog support for Intel Braswell SoC. This has been tested on a
> generic mini PC containing an Intel Celeron N3150 which is a Braswell SoC.
>
> Signed-off-by: Christopher Obbard
> ---
> drivers/watchdog/itco.c | 7
On 16.05.24 13:47, Tobias Schaffner wrote:
> This series adds the station id of the BX-56A and allows to run the
> driver for all configurations of the BX-56A and BX-59A.
>
> As the host bridge device id varies over the different configurations,
> we only depend on the pci vendor and station id.
On 16.05.24 12:13, Sjoerd Simons wrote:
> Hey,
>
> On Thu, 2024-05-16 at 12:00 +0200, Jan Kiszka wrote:
>> On 16.05.24 11:52, 'Sjoerd Simons' via EFI Boot Guard wrote:
>>> This adds support for Tiger lake LP, Jasper lake, Alder lake
>>> (various
>>> va
On 16.05.24 17:50, 'Shivaschandra KL' via EFI Boot Guard wrote:
> Signed-off-by: K L, Shivaschandra
> Tested-by: K L, Shivaschandra
>
Thanks for testing! This is at least how I interpret this reply. Did you
only test patch 1 or the whole series?
Also note that only the tested-by tag is
On 16.05.24 11:52, 'Sjoerd Simons' via EFI Boot Guard wrote:
> This adds support for Tiger lake LP, Jasper lake, Alder lake (various
> variants), Raptor lake, Meteor lake (various variants) and Birch
> Stream devices using the relevant pci-ids and chip namings from the
> linux kernel.
>
> Tested
On 16.05.24 11:18, Tobias Schaffner wrote:
> This series adds the station id of the BX-56A and allows to run the
> driver for all configurations of the BX-56A and BX-59A.
>
> As the host bridge device id varies over the different configurations,
> we only depend on the pci vendor and station id.
On 13.05.24 15:23, 'Storm, Christian' via EFI Boot Guard wrote:
> From: Christian Storm
>
> Use objcopy with target=efi-app for
> * x86 across the board(s)
> * aarch64 with gnu-efi > 3.0.15
>
> Use objcopy with binary copy mode for
> * arm
> * riscv64
> * aarch64 with gnu-efi = 3.0.15
>
> This
On 14.05.24 08:38, shrikant bobade wrote:
> Hello Tobias,
>
> We have a BX-59A/BX-56A device, during integration using efibootguard
> v0.16 we have found the BX-56A showing unsupported watchdog for
> "w83627hf", can you please assist hear these patches will help us get
> watchdog integrated well
Fix arm + riscv support for gnu-efi > 3.0.15
Use --no-warn-rwx-segments only when needed
Earl Chew (4):
Use CK_NOFORK for tests to simplify use of gdb
Support check-valgrind
Support additional boot delay before starting image
Support --with-env-file-name
Jan Kiszka
On 28.04.24 17:54, 'Earl Chew' via EFI Boot Guard wrote:
> Allow configuration to override the default ENV_FILE_NAME
> and FAT_ENV_FILENAME to support scenarios with multiple
> distributions or architectures.
>
> For multiple distributions, https://wiki.debian.org/UEFI explains:
>
>> Debian
On 21.04.24 21:44, Jan Kiszka wrote:
> On 19.04.24 14:24, 'Mathieu Alexandre-Tetreault' via EFI Boot Guard wrote:
>>>> enum iTCO_versions {
>>>> @@ -92,7 +93,12 @@ static const iTCO_regs iTCO_version_regs[] = {
>>>>},
>>>> [ITCO
On 19.04.24 14:24, 'Mathieu Alexandre-Tetreault' via EFI Boot Guard wrote:
>>> enum iTCO_versions {
>>> @@ -92,7 +93,12 @@ static const iTCO_regs iTCO_version_regs[] = {
>>> },
>>> [ITCO_V4] =
>>> {
>>> - /* Not implemented yet */
>>> + .pmc_base_reg = 0x10,
>>> +
On 17.04.24 17:38, 'Mathieu Tetreault' via EFI Boot Guard wrote:
> Signed-off-by: Mathieu Tetreault
> ---
> drivers/watchdog/itco.c | 15 ++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/itco.c b/drivers/watchdog/itco.c
> index 9252014..c20b1b6
On 13.04.24 02:47, 'Earl Chew' via EFI Boot Guard wrote:
> Jan,
>
>> Can you be a bit more specific why you need to have this configurable?
>
> I'm looking to support multiple distributions.
>
> https://wiki.debian.org/UEFI
>
>> Debian installs grub-efi for its EFI bootloader, as:
>>
>>
On 08.04.24 16:40, Jan Kiszka wrote:
> On 27.03.24 09:19, Tobias Schaffner wrote:
>> The simatic IPC BX-56A shares the same nct6116 superio chip as the
>> BX-59A. Allow efibootguard to configure the w83627hf watchdog for BX-56A
>> by adding its station id.
>>
>>
On 27.03.24 09:19, Tobias Schaffner wrote:
> The simatic IPC BX-56A shares the same nct6116 superio chip as the
> BX-59A. Allow efibootguard to configure the w83627hf watchdog for BX-56A
> by adding its station id.
>
> Signed-off-by: Tobias Schaffner
> ---
> drivers/watchdog/w83627hf_wdt.c | 3
On 27.03.24 09:19, Tobias Schaffner wrote:
> Now that we solely depend on the vendor pci id the station id will be
> compared for a large number of pci device ids. Cache the station id to
> avoid retreiving it from SMBIOSTable every time.
>
> Signed-off-by: Tobias Schaffner
> ---
>
On 06.04.24 01:01, 'Earl Chew' via EFI Boot Guard wrote:
> Allow configuration to override the default ENV_FILE_NAME
> to support scenarios with multiple distributions or architectures.
Can you be a bit more specific why you need to have this configurable?
>
> Signed-off-by: Earl Chew
> ---
>
ich I have here, where all configs are
>> set to OK, even though one is FAILED ?
>
> Good question. I guess there are reasons for the current behavior :) Jan
> Kiszka might remember the reason. I can only guess; maybe it is meant to
> prepare the standby BGENV for the next up
On 12.03.24 12:09, 'Storm, Christian' via EFI Boot Guard wrote:
> From: Christian Storm
>
> GNU binutils 2.39 introduced a warning for LOAD segments with RWX
> permissions. Due to the default Werror, the build fails for non-
> x86 machines when using binutils >= 2.39 and gnu-efi <= 3.0.15.
> x86
On 12.03.24 09:48, 'Storm, Christian' via EFI Boot Guard wrote:
>>> From: Christian Storm
>>>
>>> With gnu-efi >= 3.0.16, the binary format assemblage
>>> doesn't work anymore due to lds and crt0 changes.
>>>
>>> Hence, with gnu-efi >= 3.0.16, use the efi-app target.
>>> For gnu-efi == 3.0.15,
On 12.03.24 09:11, 'Storm, Christian' via EFI Boot Guard wrote:
> From: Christian Storm
>
> With gnu-efi >= 3.0.16, the binary format assemblage
> doesn't work anymore due to lds and crt0 changes.
>
> Hence, with gnu-efi >= 3.0.16, use the efi-app target.
> For gnu-efi == 3.0.15, still use the
On 11.03.24 09:43, 'Storm, Christian' via EFI Boot Guard wrote:
> From: Christian Storm
>
> Make the CI build print out commands executed to
> allow for better contextualization of build errors.
>
> Signed-off-by: Christian Storm
> ---
> .github/workflows/main.yaml | 10 +-
> 1 file
On 09.03.24 11:08, 'Storm, Christian' via EFI Boot Guard wrote:
> Hi Jan,
>
>
From: Christian Storm
With gnu-efi >= 3.0.16, the binary format assemblage for
arm doesn't work anymore due to lds and crt0 changes.
Hence, with gnu-efi >= 3.0.16 and binutils >= 2.38,
On 09.03.24 09:00, 'Jan Kiszka' via EFI Boot Guard wrote:
> On 07.03.24 12:09, 'Storm, Christian' via EFI Boot Guard wrote:
>> From: Christian Storm
>>
>> With gnu-efi >= 3.0.16, the binary format assemblage for
>> arm doesn't work anymore due to lds and crt0 chan
On 07.03.24 12:09, 'Storm, Christian' via EFI Boot Guard wrote:
> From: Christian Storm
>
> With gnu-efi >= 3.0.16, the binary format assemblage for
> arm doesn't work anymore due to lds and crt0 changes.
>
> Hence, with gnu-efi >= 3.0.16 and binutils >= 2.38, use the
> efi-app-${ARCH} target.
On 08.03.24 16:18, Maxime Roussin-Bélanger wrote:
>
>
> On Thu, Mar 7, 2024 at 2:48 AM Maxime Roussin-Bélanger
> <mailto:maxime.roussinbelan...@gmail.com>> wrote:
>
>
>
> On Thu, Mar 7, 2024 at 02:22 Jan Kiszka <mailto:jan.kis...@siemens.com>
On 07.03.24 00:18, Maxime Roussin-Bélanger wrote:
> Hi,
>
> We're encountering an issue with efibootguard failing to start with the
> poky nanbield branch, which works fine on the mickledore branch using
> the qemux86_64 machine.
>
> ```
> KVM internal error. Suberror: 1
> extra data[0]:
From: Jan Kiszka
Resolves warnings about deprecated Node.js.
Signed-off-by: Jan Kiszka
---
.github/workflows/coverity.yaml | 2 +-
.github/workflows/main.yaml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/coverity.yaml b/.github/workflows
On 24.02.24 18:49, 'Earl Chew' via EFI Boot Guard wrote:
> Apologies, this update was attached to the wrong email thread.
>
No problem, I found it.
In general it is better anyway to start a new thread when sending a new
version of a patch or patch series.
Jan
> On 2024-02-24 09:42, Earl Chew
On 29.02.24 11:31, 'Storm, Christian' via EFI Boot Guard wrote:
> From: Christian Storm
>
> For gnu-efi < 3.0.17, efilib.h reads
> VOID CopyMem (
> IN VOID *Dest,
> IN CONST VOID *Src,
> IN UINTNlen
> )
> while for gnu-efi >= 3.0.17, it reads
>
_id, UINT16 pci_device_id,
> - UINTN timeout)
> +static EFI_STATUS init(EFI_PCI_IO *pci_io, UINT16 pci_vendor_id,
> +UINT16 pci_device_id, UINTN timeout)
> {
> EFI_STATUS status;
> UINT32 value;
> @@ -88,3 +87,5 @@ init(EFI_PCI_IO *pci_
On 24.02.24 18:51, 'Earl Chew' via EFI Boot Guard wrote:
> Support a configuration option to insert a delay before
> starting the image to give the operator a chance to capture
> diagnostic messages.
>
> Signed-off-by: Earl Chew
> ---
> configure.ac | 17 +
> main.c | 2
On 19.02.24 05:10, 'Earl Chew' via EFI Boot Guard wrote:
> Jan,
>
>> Why do you do this twice? You already detect this case during configure
>> time.
>
> The runtime check ensures that the argument to BS->Stall() never overflows.
> Having said that, perhaps this would be more fitting, and then
On 16.02.24 03:14, 'Earl Chew' via EFI Boot Guard wrote:
> Support a configuration option to insert a delay before
> starting the image to give the operator a chance to capture
> diagnostic messages.
>
> Signed-off-by: Earl Chew
> ---
> configure.ac | 17 +
> main.c | 4
On 14.02.24 05:06, 'Earl Chew' via EFI Boot Guard wrote:
> Use AX_VALGRIND_CHECK in configure.ac to enable support
> for check-valgrind target that uses valgrind when running
> unit tests.
>
> Signed-off-by: Earl Chew
> ---
> .github/workflows/main.yaml| 3 ++-
> Makefile.am
On 12.02.24 16:41, 'Earl Chew' via EFI Boot Guard wrote:
> Jan,
>
> On 2024-02-12 00:25, Jan Kiszka wrote:
>>> + for (UINTN delay = ENV_BOOT_DELAY; delay; --delay)
>>> + BS->Stall(1000 * 1000);
>>
>> Why this loop? Stall() should be us
On 12.02.24 16:27, 'Earl Chew' via EFI Boot Guard wrote:
> On 2024-02-12 00:17, Jan Kiszka wrote:
>> On 06.02.24 16:47, 'Earl Chew' via EFI Boot Guard wrote:
>>> make check -j $(nproc)
>>> + make check-valgrind -j $(nproc)
>>
>> T
On 09.02.24 08:01, 'Storm, Christian' via EFI Boot Guard wrote:
> Implemented as compile-time switch, enabling silent boot
> suppresses informational messages by EFI Boot Guard so
> that, e.g., EFI splash screens are not overwritten.
> Warning and error messages will still be printed.
>
>
On 08.02.24 17:23, 'Earl Chew' via EFI Boot Guard wrote:
> Support a configuration option to insert a delay before
> starting the image to give the operator a chance to capture
> diagnostic messages.
>
> Signed-off-by: Earl Chew
> ---
> configure.ac | 15 +++
> main.c | 3 +++
On 01.02.24 05:42, 'Earl Chew' via EFI Boot Guard wrote:
> Run tests in the main process, rather than forking a
> new process per test. This simplifies the use of gdb
> to diagnose test failures.
>
> Signed-off-by: Earl Chew
> ---
> tools/tests/test_ebgenv_api.c | 179
On 06.02.24 16:47, 'Earl Chew' via EFI Boot Guard wrote:
> Use AX_VALGRIND_CHECK in configure.ac to enable support
> for check-valgrind target that uses valgrind when running
> unit tests.
>
> Signed-off-by: Earl Chew
> ---
> .github/workflows/main.yaml| 3 ++-
> Makefile.am
On 07.02.24 09:33, Storm, Christian (T CED OES-DE) wrote:
> Hi,
>
>>> From: Christian Storm
>>>
>>> libcheck is used in tools/tests which is not
>>> dependent on the bootloader EFI being built.
>>>
>>> Signed-off-by: Christian Storm
>>> ---
>>> configure.ac | 3 ++-
>>> 1 file changed, 2
On 06.02.24 16:47, 'Earl Chew' via EFI Boot Guard wrote:
> Use AX_VALGRIND_CHECK in configure.ac to enable support
> for check-valgrind target that uses valgrind when running
> unit tests.
>
> Signed-off-by: Earl Chew
> ---
> .github/workflows/main.yaml| 3 ++-
> Makefile.am
On 30.01.24 09:38, Pavel Löbl wrote:
>
>
> On Tuesday, January 30, 2024 at 7:43:10 AM UTC+1 Jan Kiszka wrote:
>
> On 30.01.24 02:42, Pavel Löbl wrote:
> > Hi,
> >
> > I'm considering using EFI boot in some upcoming ARM based embedded
> &
On 30.01.24 02:42, Pavel Löbl wrote:
> Hi,
>
> I'm considering using EFI boot in some upcoming ARM based embedded
> system deployment. As it seems it's the future on ARM now. What I miss a
> bit is to get the whole update mechanism picture, as EFI Boot Guard is
> only one piece in the chain. So I
On 18.01.24 14:11, 'Jan Kiszka' via EFI Boot Guard wrote:
> On 18.01.24 11:04, 'Quirin Gylstorff' via EFI Boot Guard wrote:
>> From: Dandan Zhang
>>
>> This adds loongarch64 support.
>>
>> Signed-off-by: Quirin Gylstorff
I need Dandan's signed off as well.
On 18.01.24 11:04, 'Quirin Gylstorff' via EFI Boot Guard wrote:
> From: Dandan Zhang
>
> This adds loongarch64 support.
>
> Signed-off-by: Quirin Gylstorff
> ---
> Hi,
>
> this was send with Debian bug
> 1060884.https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1060886.
>
> Kind regards
>
On 15.01.24 16:28, 'Earl Chew' via EFI Boot Guard wrote:
> After making a backup of my EFI ESP partition in another partition, I
> was surprised to
> find that efibootguard would no longer boot.
>
> The relevant part of env/fatvars.c is:
>
> if (numHandles > ENV_NUM_CONFIG_PARTS) {
>
On 15.01.24 15:50, Earl Chew wrote:
> Jan,
>
>> Are you trying to catch the messages from a screen, or are they
>> overwritten on a UART by the succeeding EFI app?
>
> Yes, in my case, cleared/overwritten by the next EFI app.
>
EFI provider is U-Boot or a PC firmware? The former has now
On 15.01.24 00:20, 'Earl Chew' via EFI Boot Guard wrote:
> While debugging an issue, it was helpful to have a short delay before
> the StartImage() handoff in order to read/capture the efibootguard
> messages.
>
Are you trying to catch the messages from a screen, or are they
overwritten on a
On 08.01.24 16:02, 'Storm, Christian' via EFI Boot Guard wrote:
> From: Christian Storm
>
> libcheck is used in tools/tests which is not
> dependent on the bootloader EFI being built.
>
> Signed-off-by: Christian Storm
> ---
> configure.ac | 3 ++-
> 1 file changed, 2 insertions(+), 1
On 08.12.23 16:33, 'Michael Adler' via EFI Boot Guard wrote:
> This commit updates the script shebang from /bin/bash to /usr/bin/env
> bash, thereby improving the portability of the scripts across different
> Unix-like systems. For example, NixOS and FreeBSD do not place the bash
> shell in the
On 08.12.23 16:32, 'Michael Adler' via EFI Boot Guard wrote:
> This commit changes the default verbosity setting for the FAT parser to
> false, aligning it with the general efibootguard behavior where
> verbosity is not enabled by default. Users can still opt-in for verbose
> output by using the
On 07.12.23 13:28, 'Jan Kiszka' via EFI Boot Guard wrote:
> On 07.12.23 11:37, 'Michael Adler' via EFI Boot Guard wrote:
>> This commit changes the default verbosity setting for the FAT parser to
>> false, aligning it with the general efibootguard behavior where
>> ver
On 07.12.23 11:37, 'Michael Adler' via EFI Boot Guard wrote:
> This commit changes the default verbosity setting for the FAT parser to
> false, aligning it with the general efibootguard behavior where
> verbosity is not enabled by default. Users can still opt-in for verbose
> output by using the
On 29.11.23 18:06, Root Mailer wrote:
> Hi there,
>
> one of our systems has this watchdog:
>
> https://elixir.bootlin.com/linux/v6.7-rc3/source/drivers/watchdog/advantech_ec_wdt.c
>
> Would it be possible to port the Linux driver code to ebg? It seems to
> use ISA, is this a problem or can it
On 22.11.23 11:09, Root Mailer wrote:
> As a first step I dumped the registers at the end of the init() function
> here:
>
> https://github.com/siemens/efibootguard/blob/master/drivers/watchdog/itco.c#L341
>
> Result:
>
> TCO_RLD: 0x64
> TCOv1_TMR: 0x0
> TCO_DAT_IN: 0x0
> TCO_DAT_OUT: 0x0
>
;
> <https://elixir.bootlin.com/linux/v6.7-rc1/source/drivers/watchdog/iTCO_wdt.c#L165>
>
> On Friday, November 10, 2023 at 7:57:55 PM UTC+1 Jan Kiszka wrote:
>
> On 09.11.23 15:55, Root Mailer wrote:
> > Yes in Linux it seems to work. We tested this by fo
On 13.11.23 10:31, 'Quirin Gylstorff' via EFI Boot Guard wrote:
> From: Felix Moessbauer
>
> These flags require libc support which we do not have in the EFI part.
> As distro builders inject the hardening flags into CFLAGS, which is fine
> for the userspace part, but for EFI we need to override
_Watchdog_Funktion
>
Then something is wrong with what the EBG driver does, possibly around
clearing the no-reboot flag. Someone near to a hardware would have to
sit down and compare, e.g. if EBG is using the same addresses for that
flag change as Linux does.
Jan
> On Thursday, November 9, 2023 at 2:1
On 08.11.23 14:51, Root Mailer wrote:
> Watchdog is now (allegedly) supported, thanks for that. Unfortunately,
> it does not work as expected.
>
> We set watchdog timeout to 30 seconds via "bg_setenv --part=0/1
> --watchdog=30". Looks good:
>
> Screenshot from 2023-11-08 10-02-55.png
>
> We
On 02.11.23 11:06, Root Mailer wrote:
> Hi Jan,
>
> here the "lspci -nn" output, unfortunately only as a picture:
>
> Screenshot from 2023-11-02 11-02-22.png
>
> I guess it's the SMBus controller. Apparently there are multiple PCI IDs
> for Tiger Lake. Currently you support Tiger Lake H [1] and
On 31.10.23 15:44, Root Mailer wrote:
> Hi,
>
> I'm using the Debian Bookworm Package efibootguard (0.13-2+deb12u1) on a
> Tiger Lake platform (i7-1185G7E). The watchdog is set to 60 seconds in
> BIOS/UEFI.
>
> I set the watchdog to 30 seconds via
>
> bg_setenv --watchdog=30
>
> but ebg says
From: Jan Kiszka
This reverts commit 67a9fe98318ee0471ae0f07597f9bed4cf75c82d.
Fixed at Ubuntu by now, even broken without it.
Signed-off-by: Jan Kiszka
---
It built yesterday, I swear...
Fortunately nothing affecting the released code directly.
.github/workflows/main.yaml | 1 -
1 file
memory leak in partition probing
efi: implement systemd boot loader interface
libebgenv: only probe config on root dev (opt-out)
port verbose option over to ebg_set_opt
tools: add "-A/--all" option to auto completion
Jan Kiszka (11):
tests: Silence cppchec
From: Jan Kiszka
We added a new function in 8df7c6ecad5c, not removing any yet. Therefore
bump 'current' and 'age' according to [1]
[1]
https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
Signed-off-by: Jan Kiszka
---
Makefile.am | 2 +-
1 file changed, 1
Hi all,
with the recent patches in next, I'm tempted to tag a release next week.
If you have anything cooking that should go in, speak up now - or wait
for the next one.
Jan
--
Siemens AG, Technology
Linux Expert Center
--
You received this message because you are subscribed to the Google
From: Jan Kiszka
This is analogous to ipc4x7e_wdt.c.
Signed-off-by: Jan Kiszka
---
scripts/cppcheck.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/cppcheck.sh b/scripts/cppcheck.sh
index 1267f21..b01421f 100755
--- a/scripts/cppcheck.sh
+++ b/scripts/cppcheck.sh
@@ -44,6 +44,7
From: Jan Kiszka
Moving the test to the end avoids the need to initialize timerstatus.
And it also no longer confuses cppcheck 2.10.
Signed-off-by: Jan Kiszka
---
drivers/watchdog/ipmi_wdt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/watchdog/ipmi_wdt.c
From: Jan Kiszka
These are there because of the file format.
Signed-off-by: Jan Kiszka
---
scripts/cppcheck.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/cppcheck.sh b/scripts/cppcheck.sh
index b01421f..af5f337 100755
--- a/scripts/cppcheck.sh
+++ b/scripts
From: Jan Kiszka
This allows the local execution of cppcheck with the same parameters
used in CI, specifically the same exceptions.
Signed-off-by: Jan Kiszka
---
.github/workflows/main.yaml | 54 +---
scripts/cppcheck.sh | 70
From: Jan Kiszka
This allows to pull in smbios_find_struct only into builds which need
them (x86). And it also avoids filling the main folder with driver-only
code.
Signed-off-by: Jan Kiszka
---
Makefile.am | 6 +-
drivers/utils/smbios.c | 41
From: Jan Kiszka
This is only needed by x86 drivers.
Signed-off-by: Jan Kiszka
---
Makefile.am | 2 +-
simatic.c => drivers/utils/simatic.c | 0
2 files changed, 1 insertion(+), 1 deletion(-)
rename simatic.c => drivers/utils/simatic.c (100%)
diff
From: Jan Kiszka
tools/ebgpart.c:380:11: style: Condition 'devfile' is always true
[knownConditionTrueFalse]
} while (devfile);
^
While resolving this, also reduce the scope of devfile (would be the
next warning).
Signed-off-by: Jan Kiszka
---
tools/ebgpart.c | 7 +++
1 file
them.
Jan
Jan Kiszka (7):
scripts: Factor out cppcheck.sh from CI job
cppcheck: Add exception for new warning in w83627hf_wdt.c
watchdog: ipmi_wdt: Avoid pointless check at loop entry
libebgenv: Address cppcheck style complaint
cppcheck: Suppress unusedStructMember in kernel-stub/fdt.c
On 19.10.23 17:30, 'Cedric Hombourger' via EFI Boot Guard wrote:
> Re-use the w83627hf code from the Linux kernel to support the
> NCT6116 chip found on the SIMATIC IPC BX-59A. The code was
> greatly simplified to only support that particular chip.
>
> The original intent was to use WDAT for this
On 19.10.23 14:11, 'Michael Adler' via EFI Boot Guard wrote:
> - Transition from string-based to enum-based file system type handling.
> - Eliminates string allocations, reducing potential for allocation failures.
> - Avoids error-prone string matching, improving performance and accuracy.
>
>
ing other platforms to either use
> iTCO or WDAT). The code to extract the station ID from DMI
> tables is moved to its own compile unit (simatic.c) so it may
> be shared between the ipc4x7e_wdt and w83627hf_wdt drivers.
>
> Changes between v1 and v2:
> - rename ipcbx59a_wdt.c t
On 19.10.23 11:46, 'Michael Adler' via EFI Boot Guard wrote:
> Resolves a regression from commit b23816ab9626 where efibootguard would
> skip config file probing for an entire device upon encountering a
> partition with an indeterminable FAT bit size.
>
> Additionally, simplified the
On 19.10.23 10:22, 'cedric.hombour...@siemens.com' via EFI Boot Guard wrote:
> On 19/10/2023 10:17, Kiszka, Jan (T CED) wrote:
>> On 19.10.23 09:31, 'Cedric Hombourger' via EFI Boot Guard wrote:
>>> Re-use the w83627hf code from the Linux kernel to support the
>>> NCT6116 chip found on the SIMATIC
On 19.10.23 09:31, 'Cedric Hombourger' via EFI Boot Guard wrote:
> Re-use the w83627hf code from the Linux kernel to support the
> NCT6116 chip found on the SIMATIC IPC BX-59A. The code was
> greatly simplified to only support that particular chip.
>
> The original intent was to use WDAT for this
On 19.10.23 05:41, 'Felix Moessbauer' via EFI Boot Guard wrote:
> The tools recently got the --all option to probe on all devices. This
> option also needs to be added ot the shell autocompletion.
>
> Reported-by: Michael Adler
> Signed-off-by: Felix Moessbauer
> ---
> completion/common.py | 1
On 18.10.23 20:50, Root Mailer wrote:
> Why doesn't bg_gen_unified_kernel take the kernelargs variable?
> Currently I need to know the root=/dev/xxx device when creating the
> unified-kernel.efi, but can't change it dynamically via bg_setenv.
As the command line is under the protection of the UKI
On 18.10.23 12:45, Michael Adler wrote:
> On Wed, 18 Oct 2023 14:56:16 +0800
> Hi Felix,
>
> I think you forgot to add the new CLI options to completion/common.py.
> This (and the other *.py files) is used to generate the shell
> completions for the userspace tools.
>
Good point. Please fix
On 18.10.23 11:00, Michael Adler wrote:
> Hi Jan,
>
>> This looks fishy: We are now adding a partition in read_GPT_entries to
>> the list which is NOT a FAT partition. Why should that be correct?
>
> it looks fishy because it's not so obvious what's actually going on. It took
> me a while to
On 18.10.23 08:56, Felix Moessbauer wrote:
> Dear Devs,
>
> this series changes how configuration environments are located.
> By that, accidential collisions with environments from other media
> (e.g. USB drives) can be avoided. For the recovery use-case, we
> provide an option to override this.
On 17.10.23 17:42, 'Michael Adler' via EFI Boot Guard wrote:
> This fixes a regression introduced in commit b23816ab9626 which results
> in efibootguard skipping the config file probing of the whole device if
> it encounters some partition for which it could not determine the FAT
> bit size.
>
>
On 17.10.23 14:59, 'Jan Kiszka' via EFI Boot Guard wrote:
> On 17.10.23 12:34, 'Felix Moessbauer' via EFI Boot Guard wrote:
>> When probing partitions, the mountpoint string is allocated on the heap.
>> Normally the mountpoint is freed during unmounting. But for partitions
>
On 17.10.23 09:01, 'Felix Moessbauer' via EFI Boot Guard wrote:
> This patch deprecated the ebg_beverbose function and ports the logic
> over to the ebg_set_opt_bool infrastructure. By that, the interface can
> be simplified.
>
> Signed-off-by: Felix Moessbauer
> ---
> env/env_api.c
On 17.10.23 09:01, 'Felix Moessbauer' via EFI Boot Guard wrote:
> This patch limits the probing of ebg config environments to the block
> device the bootloader was started on. This setting can be overwritten by
> configuring using the new API ebg_set_opt before creating / opening the
>
On 17.10.23 12:34, 'Felix Moessbauer' via EFI Boot Guard wrote:
> When probing partitions, the mountpoint string is allocated on the heap.
> Normally the mountpoint is freed during unmounting. But for partitions
> that are already mounted, we also need to free the mountpoint str.
>
>
On 17.10.23 13:49, Root Mailer wrote:
> Hi,
>
> are Ice Lake watchdogs (Intel Xeon) supported by drivers/watchdog/itco.c
> and just not listed there yet?
>
We need someone to come forward with the PCI IDs of the affected
chipsets (usually the LPC controller) and then test the outcome on real
On 16.10.23 12:44, 'Felix Moessbauer' via EFI Boot Guard wrote:
> This patch limits the probing of ebg config environments to the block
> device the bootloader was started on. This setting can be overwritten by
> configuring using the new API ebg_set_opt before creating / opening the
>
On 16.10.23 12:44, 'Felix Moessbauer' via EFI Boot Guard wrote:
> This patch deprecated the ebg_beverbose function and ports the logic
> over to the ebg_set_opt_bool infrastructure. By that, the interface can
> be simplified.
>
> Signed-off-by: Felix Moessbauer
> ---
> env/env_api.c
On 16.10.23 08:55, Storm, Christian (T CED SES-DE) wrote:
> Hi,
>
>> This patch implements the LoaderDevicePartUUID part of the systemd boot
>> loader interface to pass data from the loader to the OS / systemd. The
>> data is passed via EFI variables which are set by the first-stage loader
>>
On 16.10.23 04:48, Felix Moessbauer wrote:
> Dear Devs,
>
> this series changes how configuration environments are located.
> By that, accidential collisions with environments from other media
> (e.g. USB drives) can be avoided. For the recovery use-case, we
> provide an option to override this.
On 16.10.23 08:20, MOESSBAUER, Felix (T CED INW-CN) wrote:
> On Mon, 2023-10-16 at 08:03 +0200, Jan Kiszka wrote:
>> On 16.10.23 04:46, 'Felix Moessbauer' via EFI Boot Guard wrote:
>>> When probing partitions, the mountpoint string is allocated on the
>>> heap.
>>
On 16.10.23 04:48, Felix Moessbauer wrote:
> With the recent change in libebgenv to only search on the current boot
> device (default), the provided tools could no longer be used for
> recovery. To solve this, we add a command line option to all tools to
> explicitly enable the system-wide search
1 - 100 of 731 matches
Mail list logo
