Re: Plain old line-breaking

2005-08-19 Thread Luca Furini
Peter B. West wrote: Is there any design documentation about plain old line Knuth breaking, as implemented by Luca? I see lots of stuff in the Wiki about page breaking, but can't see the original. As Jeremias told, there isn't much official documentation about the basics of the new breaking

Re: svn commit: r227219 - /xmlgraphics/fop/trunk/src/documentation/content/xdocs/compliance.ihtml

2005-08-03 Thread Luca Furini
Jeremias Maerki wrote: Initial values for Trunk column. No guarantees! Jeremias, Manuel, you have done a great job! I find it very useful and stimulating to have such a comprehensive to do list at hand! Just a few notes: [page-number-citation] [Trunk] After the page number is known, no

Re: svn commit: r226973

2005-08-02 Thread Luca Furini
Adjusting verticals spaces (coming from space-before and space-after properties) in order to fill the region, whenever possible I have done a few tests before committing, with spaces on blocks and on lists (both in the list-block and in the list-items) and it seems to work; should you find

Re: DO NOT REPLY [Bug 35937] - [PATCH] Support for FormattingResults ported from 0.20.5 to 1.0

2005-08-02 Thread Luca Furini
Jeremias Maerki wrote: I agree with the actual concept but I actually want something more general in the long-term. There are various aspects that I'd like to provide to embedders: - Number of pages over all and Number of pages for every page-sequence (obviously) - Callbacks on layout

Re: svn commit: r225580 - /xmlgraphics/fop/trunk/test/layoutengine/testcases/page-master4.xml

2005-07-29 Thread Luca Furini
Jeremias Maerki wrote: Add margin on simple-page-master as additional feature. ATM, doesn't this raise a PropertyException saying that Border and padding for a region must be 0? The XSL 1.0 Recommendation states that borders and padding are not allowed with a page-reference-area (6.4.12

Re: DO NOT REPLY [Bug 35534] - fo document output is placed in page margins

2005-07-27 Thread Luca Furini
Jeremias Maerki wrote: The situation is now improved here. The missing glues are now produced but if there are shrink and stretch possibilities the spaces are currently not adjusted, i.e. differing .minimum/.optimum/.maximum values on space-before and space-after may produce undesirable

Re: multi-column layout and footnotes

2005-06-28 Thread Luca Furini
Jeremias Maerki wrote: I just hope this breaking-up of the span-reference-areas won't cause too many problems with keeping the footnotes working. I'm a bit worried about that. We'll see. I was thinking about this too: the texbook, speaking about footnotes and columns, says something

Re: Fop Viewer

2005-06-15 Thread Luca Furini
Jeremias Maerki wrote: I'll review his patch tomorrow. I'll also take care of the german and french translations. I can take care of the italian translation. Regards Luca

Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr StaticContentLayoutmanager.java LineLayoutManager.java AbstractLayoutManager.java TextLayoutManager.java LayoutManagerMapping.java ContentLayo

2005-06-14 Thread Luca Furini
Glen Mazza wrote: Are you sure here? We had two versions of addALetterSpaceTo() -- the version in ILLM which takes a List (I didn't touch that one), and a old (?) version from AbstractLayoutManager that takes a KnuthElement. It is that latter version that I removed--it wasn't being called

Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr StaticContentLayoutManager.java LineLayoutManager.java AbstractLayoutManager.java TextLayoutManager.java LayoutManagerMapping.java ContentLayo

2005-06-10 Thread Luca Furini
Thanks for your optimization work, Glen. Just a note: the method addALetterSpaceTo() is defined in the interface InlineLevelLayoutManager and is still used. It is called by LineLM.collectInlineKnuthElements(), if the last element returned by a child LM and the first returned by the next child LM

Footnotes handling debug

2005-05-31 Thread Luca Furini
I'm trying to correct the footnotes handling, as the testfile footnotes2.xml does not pass yet. I succeeded in handling a page-dependent footnote separator, with the reasonable (at least IMO) assumption that the separator bpd does not change, but there is a check I don't understand: [...]

Re: Footnotes working!

2005-05-30 Thread Luca Furini
Andreas L. Delmelle wrote: Yeah, as an example: try reading some Postmodern Philosophy... Many pages that are filled for 75% with footnotes offering comments/notes on the ideas that appear on the other 25% (even pages containing nothing *but* footnotes, continued from a previous page). I

Re: Markers: Determining the last generated area for a LM

2005-05-24 Thread Luca Furini
Jeremias Maerki wrote: The isfirst and islast parameters must be set correctly. Currently, I don't see a reliable way to determine these values. For example, there's some code in AreaAdditionUtils that sets IS_FIRST and IS_LAST flags on the layout context but I found this doesn't work

Footnotes working!

2005-05-17 Thread Luca Furini
Footnotes should be working now. At the moment the page breaking algorithm is quite strict: it tries to insert every footnote in the same page where their citation is (the last footnote body could be split, and partially deferred to the next page). The recommendation seems to suggest that it

Applying Finn Bock's patch (again) :-)

2005-05-02 Thread Luca Furini
I realized just a few days ago that the breaking algorithm (in the BreakingAlgorithm class) is not fully patched with Finn's great refactoring of the Knuth code (bug 32612). I must admit that this is due to my laziness: when I was playing with Knuth's algorithm for page breaking I applied to my

Re: Problems with break conditions and empty pages

2005-04-22 Thread Luca Furini
Glen Mazza wrote : # Andreas L. Delmelle wrote: 1.) If FOP is processing a block on the middle of page 17 with a break-before value of even-page, FOP is supposed to render this block at the top of page 18 instead. I agree. 2.) If FOP is processing a block on the middle of page *18* with

Problems with break conditions and empty pages

2005-04-21 Thread Luca Furini
It seems there is a bug affecting the creation of the right kind of page for documents containing blocks with break-* = odd-page or even-page. If break-before = odd-page *each* page with some content is odd; even pages are all empty. If break-before = even-page the content is placed only on even

Re: Some doubts about lists

2005-04-15 Thread Luca Furini
Andreas L. Delmelle wrote: IIC, what is meant is: the space-* of the contained blocks should be seen as _content_ of the list-item, such that they are not ignored, but their values are _included_ in the total BPD without influencing the spacing between previous and following list-items.

Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr/list ListItemLayoutManager.java

2005-04-15 Thread Luca Furini
I wrote: Creating a combined list for label and body I forgot to mention that this work is mainly based on Jeremias' code for tables. There is only a significant difference while computing the first step: +if (backupHeights[0] == 0 backupHeights[1] == 0) { +// this is

Some doubts about lists

2005-04-14 Thread Luca Furini
Working on lists, I found a couple of paragraphs in the recommendation whose meaning is not fully clear to me. Section 6.8.3. (fo:list-item) states that: the block-progression-dimension of the content-rectangle of an area generated by the fo:list-item is just large enough so that the

Re: cvs commit: xml-fop/src/java/org/apache/fop/layoutmgr FlowLayoutManager.java

2005-04-13 Thread Luca Furini
Glen Mazza wrote: Hi Luca, 1.) Can the corresponding setting of these values on fo:root (642-643 of [1]) in PSLM now be removed? (I think so...because what is set on fo:flow will be used instead of fo:root.) I agree with you. The method LengthBase.getBaseLength() (which is called by

Re: Creating combined element lists for a table row from cell element lists

2005-03-29 Thread Luca Furini
Jeremias Maerki wrote: I thought I could come up with a combined element list for this one, too, but so far I haven't managed. At last I'm here! I start with a question I could not find an answer to: is row splitting allowed by default and forbidden using keep-together, or is it forbidden

<    1   2