[Freeciv-Dev] (PR#17191) Fixes for tutorial

2007-07-12 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=17191 Committed changes to 2.1 branch as r13098 and trunk as r13099. Final patches attached. Doing no spelling fixing since I don't know how that impacts translation. Two spelling errors in tutorial.sav remain in 2.1 branch. Keeping this

[Freeciv-Dev] (PR#15260) GTK2: interface quirks being observer

2007-07-12 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=15260 Committed to trunk as r13100 and S2_1 as r13101. gtk2 client: Deactivate irrelevant reports for observers. Make sure that some shortcut keys (F1..F11 and shift+arrows) work for observers. Some reindentation in the touched function.

Re: [Freeciv-Dev] (PR#39450) Make rule names available in the scripting api

2007-07-12 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39450 Thanks for replying to this, you are the one who knows the related code well. 2007/7/13, William Allen Simpson [EMAIL PROTECTED]: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39450 Ulrik Sverdrup wrote: So we would have

[Freeciv-Dev] (PR#39441) tracking release 2.0.10

2007-07-11 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39441 Further about savegame compatibility: In 2.1 we introduced the $..$ delimiter for secfiles for code blocks. First it was read-only, but that caused ticket 39442: So I built upon that in

[Freeciv-Dev] (PR#13215) AI choice problems in civ1 ruleset

2007-07-11 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=13215 (PR#13215) AI choice problems in civ1 ruleset (PR#39399) 2.1 Ancients modpack bug Combined these tickets; both the civ1 and ancients rulesets have a 'simplified' list of alternatives in the early game which gives this behaviour from the

[Freeciv-Dev] (PR#39382) civ1 and civ2 rulesets crash, no sea barbarians, bad tech Never

2007-07-11 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39382 To resolve the last item in this bug, the bad tech Never message for the civ1 ruleset; trunk requires a req for Airbase that is always false. Here is a small patch. (The requirement None is always active, and negated it is never active)

[Freeciv-Dev] (PR#39450) Make rule names available in the scripting api

2007-07-10 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39450 Make rule names available in the scripting api. Right now, in a callback in lua; for example: hut_entered_callback(punit) there is no way to get the rule name of punit, only the reverse by find.unit_type('Settlers') and similar.

[Freeciv-Dev] (PR#17187) Move hut code into lua script

2007-07-10 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=17187 Updated the patch to the latest revision trunk. The patch is almost ready but depends on #39450: Make rule names available in the scripting api; right now there is no way to tell the user Your %s was killed by barbarians Expanded the

[Freeciv-Dev] (PR#39442) Lua script newlines not restored correctly from save

2007-07-10 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39442 Committed to S2_1 as r13087 and trunk as r13088 (PR#39442) Lua script newlines not restored correctly from save Make escaped an attribute of entry so that it can be carried over from load to save Changed moutstr so that it takes a

[Freeciv-Dev] (PR#39451) Add signal emit to scripting api

2007-07-10 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39451 Allow signals to be emitted from Lua scripts. Add a wrapper for script_signal_emit to the signal module. ___ Freeciv-dev mailing list Freeciv-dev@gna.org

[Freeciv-Dev] (PR#15260) GTK2: interface quirks being observer

2007-07-10 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=15260 Consolidated the above posted patches, ready for commit to trunk and S2_1 disable_reports.diff end_phase.diff observer_keys.diff Changed the observer keys handling a bit: Now the shift-arrow keys to scroll the mapview work as well, just

[Freeciv-Dev] (PR#17191) Fixes for tutorial

2007-07-10 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=17191 [wsimpson - Tir. 10. Jul. 2007 22:00:55]: To be consistent with other naming conventions, that should be: has_unit_type_name(unit, rule_name) because its argument is a unit, not a utype. === Likewise, function

[Freeciv-Dev] (PR#36323) 2.1 svn bugs

2007-07-10 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=36323 [EMAIL PROTECTED] - Søn. 25. Feb. 2007 08:48:03]: Interesting glitch. Did you USE to have a city there? Nope, nowhere near. I've seen this glitch a few times since as well. Save games don't have history to determine the cause?

[Freeciv-Dev] (PR#39413) Effects-ize the calendar

2007-07-10 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39413 New version of the patch; now split up into three parts: effects_timeline_startyear_v3.diff startyear server option effects_timeline_doc_ruleset_v3.diff MinYear Req type, Effects and modifications to game_next_year

[Freeciv-Dev] (PR#39449) Implement Create Player and Create Barbarians in scripting api

2007-07-09 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39449 Implement functions (actions) in the scripting api to create new players and specifically also create new barbarian players. This would allow us to move some of the barbarian logic to scripting. Ideas taken from

[Freeciv-Dev] (PR#39398) 2.1.0-beta4 Fantasy modpack crash

2007-07-08 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39398 Commited the attached patch to S2_1 r13074 and trunk r13075 As this is probably the cause of this crash (letting player gold go below 0) this bug could be marked closed. (PR#39398): 2.1.0-beta4 Fantasy modpack crash Make sure only

[Freeciv-Dev] (PR#39442) Lua script newlines not restored correctly from save

2007-07-08 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39442 Patch that applies to S2_1 and trunk r13075 attached. Make escaped an attribute of entry so that it can be carried over from load to save; change moutstr so that it takes a full_escapes argument just like minstr. Also changed moutstr to

[Freeciv-Dev] (PR#39395) Backport cursor fix from trunk to 2.1 branch

2007-07-08 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39395 Already fixed in trunk as #37801. I am proposing this very similar patch to fix; Modified since there is no update_mouse_cursor in S2_1. ___ Freeciv-dev mailing list Freeciv-dev@gna.org

[Freeciv-Dev] (PR#13019) Meta-Ticket: Improved scripting

2007-07-08 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=13019 Reopen to continue adding to the scripting API These are low hanging fruit api_actions, and use server/unittools and server/citytools remove_unit to immediately remove a unit upgrade_unit to upgrade a unit if possible (free) remove_city

[Freeciv-Dev] (PR#34228) [tutorial] no message on city growth beyond size 3

2007-07-06 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34228 [dmarks - Søn. 21. Jan. 2007 11:05:14]: Running the tutorial (in beta2/windows build): The message for growth to size 3 works fine, but nothing happens for size 5. I didn't try further growth. A quick look at the Lua code

[Freeciv-Dev] (PR#39440) [patch] gtk2 client menu switches Add to city and Build City

2007-07-06 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39440 [wsimpson - Fre. 06. Jul. 2007 12:58:48]: OK. I made a small revision after checking the other routines, as the decision whether the menu items exists and the default is already made earlier by can_unit_add_or_build_city(), no

[Freeciv-Dev] (PR#39443) Rfe: Add cutom UnitFlags

2007-07-06 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39443 To help modpack authors, we should add Custom1 etc unitflags to freeciv; with effects there is nothing special that neccessarily has to be coded to make a new unitflag meaningful. It can be useful to add 1-5 custom unitflags so that

Re: [Freeciv-Dev] (PR#39434) Crash in 2.1 in vsnprintf, probably related to unit_name_translation changes

2007-07-03 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39434 Now I suspect it is simply that punit is not a valid pointer after server_remove_unit(punit); and we should extract the unit type of the punit before destroying it? Or is this a sign of something else at fault here? In the simple case,

Re: [Freeciv-Dev] (PR#39434) Crash in 2.1 in vsnprintf, probably related to unit_name_translation changes

2007-07-03 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39434 This patch reinstates the ptype local variable that is needed after punit is wiped to print the user messages. Patch against S2_1 r13044 Index: server/unittools.c === ---

[Freeciv-Dev] (PR#19204) superfluous call to set_client_page() in clinet.c?

2007-07-02 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=19204 I reported the bug '#39423: Takes two clicks to cancel gtk client in Start New Game, Tutorial, etc in 2.1', it is a byproduct of this bug, so it should be marked dependant or invalid. I just think that this should be handled in the

[Freeciv-Dev] (PR#39422) [patch] Scroll city style selector

2007-06-28 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39422 More city styles (PR#15716) and larger (amplio) city style graphics means that some alternate rulesets for freeciv have so many styles that the window gets too large, even on my 1024x768 monitor (small though). Here is a patch to make

Re: [Freeciv-Dev] (PR#39413) Effects-ize the calender

2007-06-27 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39413 Here is a small doc and a patch to trunk r13023. It is ready for comment or commit if wanted. On my wishlist is to get the startyear patch into the 2.1 branch Ulrik # Using Effects for the Calendar # For default ruleset and flexibility

[Freeciv-Dev] (PR#11785) ruleset field

2007-06-27 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=11785 In S2_1 (and trunk I think), the ruleset field is also not completely updated. If the civclient is loaded with ./civ -r ancients.serv, the ruleset chooser still always displays default. ___

Re: [Freeciv-Dev] (PR#39413) Effects-ize the calender

2007-06-26 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39413 Hello freeciv-dev I have worked on this yesterday and today and I'm mostly done with the first parts. So far I have coded against trunk and written up some documentation for the changes. I'll clean it up and post the work when I have

Re: [Freeciv-Dev] (PR#39417) Crash in sanitycheck on barbarian created on mountain in S2_1

2007-06-25 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39417 2007/6/25, Ulrik Sverdrup [EMAIL PROTECTED]: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39417 In a game played with the ancients modpack on S2_1 I went back to a save and found a reproducable crasher from that point

Re: [Freeciv-Dev] (PR#39417) Crash in sanitycheck on barbarian created on mountain in S2_1

2007-06-25 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39417 2007/6/25, Marko Lindqvist [EMAIL PROTECTED]: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39417 On 6/25/07, Ulrik Sverdrup [EMAIL PROTECTED] wrote: I'm sorry this is of course in the ruleset, the Warships sea unit

Re: [Freeciv-Dev] (PR#39413) Effects-ize the calender

2007-06-24 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39413 2007/6/24, Per I. Mathisen [EMAIL PROTECTED]: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39413 On Sat, 23 Jun 2007, Ulrik Sverdrup wrote: We need a more flexible calender for rulesets, and with effects I think we have

Re: [Freeciv-Dev] (PR#39413) Effects-ize the calender

2007-06-24 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39413 2007/6/24, Per I. Mathisen [EMAIL PROTECTED]: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39413 On Sun, 24 Jun 2007, Ulrik Sverdrup wrote: I'm looking at the patch from #2912 now and can review it. Do you or anyone know

[Freeciv-Dev] (PR#39411) [patch] gov icons in tech tree show up misaligned

2007-06-23 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39411 Due to a bug where sheight is not fetched before a sprite but after, gov sprites can show up misaligned. Mystery why this doesn't happen with default ruleset. It does show up with ancients modpack 2.1.0-1 and ampcients tileset. What it

[Freeciv-Dev] (PR#39413) Effects-ize the calender

2007-06-23 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39413 We need a more flexible calender for rulesets, and with effects I think we have a quite efficient way to do it. My idea was that we need a relatively easy way to do this so that it actually happens. 1. Implement 'startyear' server

[Freeciv-Dev] (PR#39413) [patch] server 'startyear' command

2007-06-23 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39413 This is a small implementation of the startyear server command, that sets the year the game starts. Some abstraction done in game.h: Added GAME_MIN_YEAR and GAME_MAX_YEAR, and use them to define GAME_MAX_/GAME_MIN_ for end year and

Re: [Freeciv-Dev] (PR#39409) Technology tree (reqtree.c) edge colors

2007-06-23 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39409 Here is an improved and more tested patch. This still uses the three categories for edges. It adds one color for inactive, unknown edges that are gray. Active edges use the unreachable_goal color (just reusing to simplify). No lists,

[Freeciv-Dev] (PR#39408) Main gtk_notebook still allows page switching with pageup/down

2007-06-19 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39408 Using ctrl+pgup or ctrl+pgdn you can switch pages in the main gtk_notebook (main menu, start game, scenario, load and map view pages) mouse scrolling is disabled in the code but these keybindings are not. This bug leads to access to

[Freeciv-Dev] (PR#39404) 2.1 Crash in handle_mouse_cursor when loading save

2007-06-18 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39404 Encountered this crash when going to 'Load saved game', Ok, start 2.1 svn rev 13004 I can't reproduce the crash. The crash involved switching active application while waiting for the save to load, I think. Crash right after loading

[Freeciv-Dev] (PR#39347) overview size and window resize

2007-06-14 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39347 I've analyzed this bug in S2_1 to try to fix it. I think I understand it now. This is in short what happens: overview (minimap) + sidepanel (unit info) + chatbox together request more space vertically than (I) have (1024px). chatbox per

Re: [Freeciv-Dev] (PR#39385) suggestion: Buy column on Cities report preliminary patch

2007-06-08 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39385 I don't understand your changes to the first functions, but I have some comments on the other changes. I did this with the field width wrong as well, but I think we should reserve a width up to 5 for build costs. I can imagine wonders

[Freeciv-Dev] (PR#39385) Preliminary patch

2007-06-07 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39385 Here is a preliminary patch. I don't know the code around this, but it seems to be well designed, so this should be all there is to it. It is a patch to client/cityrepdata.c in the S2_1 branch and it builds fine and seems to work

[Freeciv-Dev] (PR#39371) [OS X] Apostrophe in path to freeciv and it can't start

2007-05-17 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39371 There seems to be a problem in the launch script for Freeciv in the Mac OS X installation. Apparently an apostrophe (') in the path to the application is not escaped in the startup script and causes syntax error, and no error is shown

Re: [Freeciv-Dev] (PR#39353) AutoReply: Boats cannot cross borders in alliance

2007-04-23 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39353 attached patch Index: common/player.c === --- common/player.c (revision 12927) +++ common/player.c (arbetskopia) @@ -741,7 +741,7 @@ const struct player *pplayer2) {

Re: [Freeciv-Dev] (PR#39353) AutoReply: Boats cannot cross borders in alliance

2007-04-23 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39353 Now I am not sure I understand this, but the code in svn seems to have a bug in players_non_invade(): it should return true while at peace, but false for all others (like alliance). So I just suggest a simple change like this, so you can

Re: [Freeciv-Dev] (PR#39346) Dithering and smooth graphics should be toggleable

2007-04-18 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39346 2007/4/18, Jason Dorje Short [EMAIL PROTECTED]: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39346 Ulrik Sverdrup wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39346 Comparing 2.1 beta 4 to 2.0, 2.1 looks

Re: [Freeciv-Dev] (PR#39344) Crash in 2.1beta4, SIGSEGV with 0x0fe16fec in strlen () from /lib/libc.so.6

2007-04-17 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39344 2007/4/17, Jason Dorje Short [EMAIL PROTECTED]: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39344 Ulrik Sverdrup wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39344 Attached a savegame that crashes

Re: [Freeciv-Dev] (PR#39344) Crash in 2.1beta4, SIGSEGV with 0x0fe16fec in strlen () from /lib/libc.so.6

2007-04-17 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39344 2007/4/17, Jason Dorje Short [EMAIL PROTECTED]: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39344 Ulrik Sverdrup wrote: I tried compiling current svn and trying the civserver with the same savegame, and it still crashes

[Freeciv-Dev] (PR#39346) Dithering and smooth graphics should be toggleable

2007-04-17 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39346 Comparing 2.1 beta 4 to 2.0, 2.1 looks better because of changed drawing code. 2.1 has smoohter edges and looks better. Significan is however the big regression in drawing performance between 2.0 and 2.1. In 2.1, right-clicking around

[Freeciv-Dev] (PR#39345) 2.1.0-beta4 gtk2+ client doesn't auto center on enemy combat and moves

2007-04-16 Thread Ulrik Sverdrup
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39345 2.1.0-beta4 gtk2+ client doesn't autofocus on enemy combat and moves When playing, regardless of having ticked the relevant auto center tickboxes, the client doesn't center on enemy moves or combat.. You always have to follow it via the

<    1   2   3   4