Update of patch #4460 (project freeciv):
Status: Ready For Test = Done
Open/Closed:Open = Closed
___
Reply to this item at:
Follow-up Comment #9, patch #4460 (project freeciv):
Patch for S2_5 is correct.
Patch for TRUNK only misses the change to description of mausoleum. I attach
the fix as a diff patch: Civ2civ3v6-fix1.patch
Please tell me if this is the right way to create patches, becuse I have
noticed your
Follow-up Comment #10, patch #4460 (project freeciv):
Now it may seem that I contradict myself, but I merged your fix to the main
patch.
1) Patch must be correct so if my patch was not true to the subject civ2civ3
ruleset update to v6, it needed fixing.
2) In most cases we want just one patch
Follow-up Comment #11, patch #4460 (project freeciv):
I see there is no contradiction, I understand that you requested one ticket
(not just one patch) per logical change.
I remade the whole patch including the fix, then I noticed the result was so
different from your patch, that I decided to
Follow-up Comment #12, patch #4460 (project freeciv):
Let me clarify that the readme inside the patch is correct, no need to change
it.
I just wanted to update the info of this ticket
Changes:
- Enabled Tech Upkeep, and multiplied by number of Cities.
- If a city supports more Military Units
Follow-up Comment #8, patch #4460 (project freeciv):
Thank you cazfi.
I uploaded a .zip here instead of a diff patch because I wanted to know the
opinion of the developers about the changes, and as you have explained, to
know the best procedure to include them in the trunk.
My next planned step
Follow-up Comment #2, patch #4460 (project freeciv):
Hi Davide.
I already included in this patch your fix to research lab description. I'll
add the info about mfg plant for next patch.
It seems you are using for Greatturn-08 what we called v2.4-4, the same rules
present in this repository (for
Follow-up Comment #3, patch #4460 (project freeciv):
I'd appreciate if civ2civ3 development would really happen as part of freeciv
development, instead of being drawn in as big lumps. Especially you should
make it as a patch from the beginning (i.e. have to version to match against).
One patch
Follow-up Comment #4, patch #4460 (project freeciv):
I understand what you say, and I'm here in part to learn the procedures you
use to develop freeciv. But it is hard for me to find the best way to
procedure when I have to work on so many versions of the ruleset, when only
the latest one is
Update of patch #4460 (project freeciv):
Status:None = In Progress
Assigned to:None = cazfi
Planned Release: = 2.5.0, 2.6.0
Follow-up Comment #6, patch #4460 (project freeciv):
That is what I just made with S2_5 rev#24276 (sorry, I forgot
to say), and the result is this patch.
If you've made the changes to files in svn, then creation of the patch should
be as easy as saying svn diff civ2civ3v6.patch
But as there
Update of patch #4460 (project freeciv):
Status: In Progress = Ready For Test
___
Follow-up Comment #7:
Attached is a version for TRUNK. It took some work to solve the conflicts
while applying the
URL:
http://gna.org/patch/?4460
Summary: civ2civ3 ruleset update to v6
Project: Freeciv
Submitted by: bardo
Submitted on: vie 31 ene 2014 17:04:40 GMT
Category: rulesets
Priority: 5 - Normal
Follow-up Comment #1, patch #4460 (project freeciv):
Hi bardo :)
at Greatturn we've applied some customizations to the ruleset which you might
be interested in. See here http://greatturn.org/rulesets/?a=summaryp=GT08.
Strictly speaking of bug fixes, we also fixed two incorrect help-texts,
14 matches
Mail list logo
