[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Update of bug #18835 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 

___

Follow-up Comment #63:

after the gtk3 version is applied this ticket will now be closed

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #56, bug #18835 (project freeciv):

> > Likely unrelated, but as this patch dropped mnemonics in a few places,
why is it 
> > still calling gtk_image_menu_item_new_with_mnemonic or setting 
> > "use-underline" there ? 
>
> I will check this. 

Fixed in the new file (3). I will commit this one shortly; all remaining
issues should get new tickets.

(file #14781)
___

Additional Item Attachment:

File name: 0017-gtk3-redo-layout-of-the-diplomacy-dialog-vertical.patch
Size:21 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #55, bug #18835 (project freeciv):

I did found an small bug in the patch - there is an unused variable, which is
fixed in this updated version of the 3rd file.

> Likely unrelated, but as this patch dropped mnemonics in a few places, why
is it
> still calling gtk_image_menu_item_new_with_mnemonic or setting
> "use-underline" there ?

I will check this.

> As for the gtk3 warnings, initially I thought it's something regarding the
length of
> the labels, but now I think it might be related to the size of the flags -
but that's still
> a guess.

OK; but is seems to be nothing dangerous.

> On gtk3 warnings topic: ever since 3.2.2, there's a new compile warning for
the
> dialog  construct freeciv is using - now gtk_dialog_new_with_buttons wishes
for
> at least one button and a proper NULL sentinel.

The gtk version I use is 3.2.1 (opensuse 12.1). I will have to wait till a
rpm package for the next version is ready.

(file #14664)
___

Additional Item Attachment:

File name: 0002-gtk3-redo-layout-of-the-diplomacy-dialog-vertical.patch
Size:22 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[anonymous]

Follow-up Comment #54, bug #18835 (project freeciv):

Likely unrelated, but as this patch dropped mnemonics in a few places, why is
it still calling gtk_image_menu_item_new_with_mnemonic or setting
"use-underline" there ?

As for the gtk3 warnings, initially I thought it's something regarding the
length of the labels, but now I think it might be related to the size of the
flags - but that's still a guess.

On gtk3 warnings topic: ever since 3.2.2, there's a new compile warning for
the dialog construct freeciv is using - now gtk_dialog_new_with_buttons wishes
for at least one button and a proper NULL sentinel.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Update of bug #18835 (project freeciv):

 Planned Release:2.4.0, 2.3.2 => 2.4.0, 2.3.2, 2.5.0

___

Follow-up Comment #53:

commited to S2_3, S2_4 and trunk; the ticket is not closed as the gtk3
version is missing. It compiles but reportes some errors. I do not know if
they are related to this code as it is the first time I got a relly working
gtk3 client. They seem to be unrelated but please check:


(freeciv-gtk3:10064): Gtk-CRITICAL **:
gtk_widget_get_preferred_width_for_height: assertion `height >= 0' failed

(freeciv-gtk3:10064): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to
allocate widget with width 120 and height -1


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #43, bug #18835 (project freeciv):

version for gtk3 (it does apply; not compile tested)

- only patch 1 had to be changed (gtk2 => gtk3 in strings)

(file #14575, file #14576, file #14577)
___

Additional Item Attachment:

File name: 0001-gtk2-add-option-to-gui_dialog_new-to-skip-check-of-p.patch
Size:9 KB
File name: 0003-gtk2-redo-layout-of-the-diplomacy-dialog-vertical.patch
Size:21 KB
File name: 0002-gtk2-diplomacy-in-a-horizontal-notebook.patch Size:10 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Marko Lindqvist]

Follow-up Comment #42, bug #18835 (project freeciv):

> Can these patches be applied to gtk3

I would have tested if it compiles, but patch doesn't even apply to (S2_4)
gtk3-client.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Update of bug #18835 (project freeciv):

Severity:1 - Wish => 3 - Normal 
 Planned Release:   2.4.0, 2.3.2? => 2.4.0, 2.3.2   

___

Follow-up Comment #41:

updated patch files:
- part 1: file #14294 
- part 2: file #14295 
- part 3: new file (from this comment; includes file #14548 and file #14549;
additional some code cleanup)

Can these patches be applied to gtk3 or do they use some function which is
not defined in gtk3 or depreciated? I will try to get gtk3 but do not know if
I will be succesfull

(file #14569)
___

Additional Item Attachment:

File name: 0003-gtk2-redo-layout-of-the-diplomacy-dialog-vertical.patch
Size:21 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #40, bug #18835 (project freeciv):

> Can't break it now; thanks.
OK; this will be commited as soon as 2.3.1 is released

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Jacob Nevins]

Follow-up Comment #39, bug #18835 (project freeciv):

Can't break it now; thanks.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #38, bug #18835 (project freeciv):

Thanks for testing; here are two small fixes on top of the last patches:

> New bug (may have existed in previous patch): clicking the "x"
> button on the overall "Diplomacy [N]" tab has no effect.
It's new bug - I did change the handling of the dialog response. It is fixed
by:
0004-gtk2-fix-response-code-of-meeting-dialog-s.patch

> Detaching overall "Diplomacy [N]" tab from main notebook
> (comment #25) still has same trouble as before, I'm afraid,
> including the segfault.
There were some missing checks if the dialog exists; fixed by
0005-gtk2-add-checks-if-dialog-exists-prevents-segfault.patch


(file #14548, file #14549)
___

Additional Item Attachment:

File name: 0004-gtk2-fix-response-code-of-meeting-dialog-s.patch Size:2 KB
File name: 0005-gtk2-add-checks-if-dialog-exists-prevents-segfault.patch
Size:1 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #37, bug #18835 (project freeciv):

Thanks for the detailed description! I will have time to test this on Sunday
evening.

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Jacob Nevins]

Follow-up Comment #36, bug #18835 (project freeciv):

I've tested the latest patches on trunk r20527. Results:
* Closing individual meeting tab with ESC trouble (comment #26) is fixed
* Detaching individual meeting tab trouble (comment #30) is fixed
* Detaching overall "Diplomacy [N]" tab from main notebook (comment #25)
still has same trouble as before, I'm afraid, including the segfault.
* New bug (may have existed in previous patch): clicking the "x" button on
the overall "Diplomacy [N]" tab has no effect.

About comment #25: from your comment #31, I think perhaps I didn't explain
the steps to reproduce clearly enough. They are:
* Meet with nation A (via Nations > Diplomacy > Meet), bringing up a
"Diplomacy [1]" tab containing a "A" sub-tab.
* Detach the "Diplomacy [1]" tab from the main notebook by double-clicking on
the "Diplomacy [1]" label. This gives a separate window with a "Cancel all
meetings" button (like file #14446, only with a slightly different layout, of
course).
* Close this new window with the window manager's "X" button. There is now no
"Diplomacy [1]" window or tab, and no "A" window or tab.
* Try again to meet with nation A: nothing happens.
* Try to meet with nation B: segfault.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #35, bug #18835 (project freeciv):

I think this patch set is working fine and an improvement if playing with a
large number of nations. Now to the question: there and when should this patch
be applied?

* S2_3: Not for 2.3.1 but for the next release - so after 2.3.1 has taged.

* S2_4/trunk: at the same time as S2_3

The patch set touches only the gtk2 client but I think it can easily be
ported to the gtk3 client. As I can't compile it at the moment help is needed
for this part.

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #34, bug #18835 (project freeciv):

and the patch file missing in comment #32

(file #14456)
___

Additional Item Attachment:

File name: 0004-gtk2-redo-layout-of-the-diplomacy-dialog-vertical.patch
Size:19 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #33, bug #18835 (project freeciv):

and a screenshoot - I hope there a no bug left! Any further ideas?

On problem is that the count (Diplomacy [x]) will not be updated if a meeting
tab is detached. But I think this will not be used often.

(file #14455)
___

Additional Item Attachment:

File name: dipl_dialog_2006.jpg   Size:109 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #32, bug #18835 (project freeciv):

updated version (includes patches from comment #31):


[gtk2] redo layout of the diplomacy dialog (vertical)

see gna bug #18835 (part 3)

changes 20111029:

- put content of the diplomatic tab into a scroll window else the height of
the window will increase to much for a high number of contacts
- fix buttons; move them directly below the dialog entries (not at the end of
the widget)

changes 2005:
- increase size of gold input dialog
- fix comments
- add buttons in the main notebook for meetings
- raise also the main meetings dialog

changes 2006:
- fix short keys in diplotic dialog; idea by Jacob Nevins 
- fix response (usage of ESC from meetings tab or main tab)
- make label list scrollable
- remove extra box - not needed as labels can be scrolled
- sort labels (nations) alphabetically


order of patches:
- part 1: file #14294
- part 2: file #14295
- part 3: new file (from this comment)

one should also apply fix for bug #18880


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #31, bug #18835 (project freeciv):

Could you test the two attached patches on top of the patches listed in
comment #24?

0005-gtk2-fix-short-keys-in-diplotic-dialog.patch
=> fix keyboard shortcuts; (Re)add buttons for each meetings dialog (ineeded
if it is separated)

0006-gtk2-fix-response-usage-of-ESC-from-meetings-tab-or-.patch
=> shoud fix the ESC bugs; please test! I could not reproduce the segfault-
if the main meetings tab is searated it gets a header of 'Diplomacy [n]' which
changes if meetings are added / removed.

(file #14449, file #14450)
___

Additional Item Attachment:

File name: 0005-gtk2-fix-short-keys-in-diplotic-dialog.patch Size:3 KB
File name: 0006-gtk2-fix-response-usage-of-ESC-from-meetings-tab-or-.patch
Size:4 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Jacob Nevins]

Follow-up Comment #30, bug #18835 (project freeciv):

For the avoidance of doubt: in coment #25 I was talking about detaching the
whole "Diplomacy [N]" tab from the main tab notebook by double-clicking on
"Diplomacy [N]".

It hadn't even occurred to me that the tabs for individual meetings could be
detached from the "Diplomacy [N]" notebook, but it turns out they can, by
double-clicking on e.g. "Mayas". Doing this and then closing the detached
window given similar trouble to using ESC, per comment #26.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #29, bug #18835 (project freeciv):

> Er, and I meant to say, it looks fine to me in all those
> layouts.
Thanks for testing this! About the bugs:

> If I detach the "Diplomacy [N]" tab as a separate window and
> then close it: 
> 
> Unlike other tabs, it doesn't go back into the notebook. (This
> may be deliberate.) 
It is not. The reason could be that I added another dialog arround it (the
new notebook).

> It's no longer possible to meet with a partner with whom a
> meeting was in progress -- selecting "Meet" does nothing
> obvious. 
After detaching the meetings dialog? It seems to be that the dialog is not
correctly destroyed after using ESC. This would explain this behaviour

> Trying to Meet someone who I wasn't already meeting with
> causes a segfault (gui_dialog_set_title (dlg=0x0, "Diplomacy
> [7]") -- in this case there were 6 meetings open before, so
> despite the notebook disappearing, it still thinks they're
> open in some sense). 
> I suspect the "Diplomacy [N]" dialog is getting "lost". 
I agree and will check there it is ...

> The other, more minor issue is keyboard shortcuts
I did not checked these as I do not use them. I think I will follow your
proposal.

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Jacob Nevins]

Follow-up Comment #28, bug #18835 (project freeciv):

Er, and I meant to say, it looks fine to me in all those layouts.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Jacob Nevins]

Follow-up Comment #27, bug #18835 (project freeciv):

> Please also check differen screen layouts as part 4 changes the 
> rrangement of the elements. Does it is OK for small screens, 
> widescreens, etc.
Here are some screenshots with various layout options. In each case, the
window is shrunk as small as it can go without scrollbars appearing.
* "Big" (widgets for small displays not set): messages/chat are:
** "Split": file #14445
** "Separate": file #1
** "Merged": file #14443
* "Small" (widgets for small displays set): messages/chat are:
** "Split": file #14442
** "Separate": file #14441 (*default*)
** "Merged": file #14440
* Diplomacy tab detached as new window: file #14446

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Jacob Nevins]

Additional Item Attachment, bug #18835 (project freeciv):

File name: big-merged.png Size:70 KB
File name: big-separate.png   Size:97 KB
File name: big-split.png  Size:103 KB
File name: detached.png   Size:61 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Jacob Nevins]

Additional Item Attachment, bug #18835 (project freeciv):

File name: small-merged.png   Size:64 KB
File name: small-separate.png Size:111 KB
File name: small-split.pngSize:109 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Jacob Nevins]

Follow-up Comment #26, bug #18835 (project freeciv):

> (I think I've got into a situation with symptom 2 but without 
> the segfault for new meetings, as well, but I don't know how I 
> did that.)
Figured it out. Pressing "Esc" while on the "Diplomacy [N]" tab closes the
current meeting and changes focus to the Nations tab, but the Diplomacy tab
title doesn't change to "Diplomacy [N-1]". The Messages tab doesn't say
"Meeting with [foo] cancelled". At this point it's not possible to meet with
whoever that meeting was with. (It's possible to get the "Diplomacy [N]"
dialog down to the point where it has _no_ meeting tabs by doing this.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Jacob Nevins]

Update of bug #18835 (project freeciv):

 Planned Release:   2.4.0, 2.3.1? => 2.4.0, 2.3.2?  

___

Follow-up Comment #25:

Playing with the patch, it looks good. I think it could go to S2_3, but at
this point I think I'd like to wait until after 2.3.1, so that it can get some
time in test before a release.

Some things I've found in testing (with trunk r20457):

If I detach the "Diplomacy [N]" tab as a separate window and then close it:
0 Unlike other tabs, it doesn't go back into the notebook. (This may be
deliberate.)
0 It's no longer possible to meet with a partner with whom a meeting was in
progress -- selecting "Meet" does nothing obvious.
0 Trying to Meet someone who I wasn't already meeting with causes a segfault
(gui_dialog_set_title (dlg=0x0, "Diplomacy [7]") -- in this case there were 6
meetings open before, so despite the notebook disappearing, it still thinks
they're open in some sense).
I suspect the "Diplomacy [N]" dialog is getting "lost".

(I think I've got into a situation with symptom 2 but without the segfault
for new meetings, as well, but I don't know how I did that.)

The other, more minor issue is keyboard shortcuts -- there are clashes (some
pre-existing):
* Two "_Add Clause..." clash with each other
*  Two "_Gold" clash with each other and "_Game" menu 
*  "_Cancel meeting", "_Cancel all meetings" clash with each other and with
"_Combat" menu 
Keyboard shortcuts are a pain, and I've convinced myself that taking into
account the existing shortcuts on the menubar, Messages and Chat tabs, there's
no way of getting a unique set of shortcuts.
We could abandon shortcuts for the "Add Clause" and "Gold" widgets, and do 
"Cancel _meeting" and "Cancel _all meetings" . The Diplomacy tab isn't very
keyboard-accessible anyway (no way to switch to it).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Update of bug #18835 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #24:

update the last part of the patch

- part 1: file #14294 
- part 2: file #14295 
- part 3: new file (from this comment)

one should also apply fix for bug #18880

changes:
- remove option; this layout would be default
- move buttons to main tab; thus they are visible all the time
- add button 'Cancel all' (others are 'Accept' and 'Cancel')
- some code cleanup

(file #14436)
___

Additional Item Attachment:

File name: 0004-gtk2-redo-layout-of-the-diplomacy-dialog-vertical.patch
Size:16 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Karl Goetz]

Follow-up Comment #23, bug #18835 (project freeciv):

have to say the vertical thing is *much* preferable to the horizontal tabs
for large numbers of nations. the vertical scroll thing is slightly annoying,
but if playing with a mouse is tolerable. (I don't think the UI has enough
room for a second row of nations, so we can skip that idea)
I think diplomacy feels nicer if chat has been floated (so the dipl takes up
the whole area), but since it s annoying having chat floated while playing i
guess thats just how things are :)
I definitely like the large clauses window, only problem is the distance that
the player has to scroll in order to accept it the clauses. Is it possible to
move the accept/cancel buttons?

Thanks for working on those patches, i'd probably be happy with them 'as is'
(at least for a broader audience).


If anyone wants me to upload the source packages i'm using for testing
somewhere i can (eg, if they want to build them on ubuntu/debian/a deriv).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Karl Goetz]

Follow-up Comment #22, bug #18835 (project freeciv):

Thanks for the link to bug #18781, i'm now cc'd. I'll download the patch and
try it out today.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Update of bug #18835 (project freeciv):

  Status:  Ready For Test => In Progress

___

Follow-up Comment #21:

> By the way, saving that freeciv save file i notice that it
> truncates out everything after the first '.'. Is that a known
> bug, or should i open a ticket? (the original name was
> freeciv2.3.0-hacked)
there is a ticket for this: see bug #18781

The patch does some changes on top of all other patches; it is work in
progress.

> First is that the gold adjustment arrows seem to sit over the
> right hand side of the gold box (i circled that). 
was it better in the old version (I did not change this).
 
> Second is the size of the 'clauses' window. is that fixed so
> it scales into small screens? i'd have thought it would make
> more sense to have that maybe twice the size it is now (given
> the amount of space i have free on the bottom of my screen). 
better now?

Ideally the Accept and Cancel buttons would belong to the vertical notebook;
in this version they are at the button - hard to find if there are lots of
meetings.

Please test (size 2; aifill 60; meetings with 30+ nations and check the
layout)!

(file #14387)
___

Additional Item Attachment:

File name: dipl_dialog-S2_3-addon-2001.patch Size:6 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Karl Goetz]

Follow-up Comment #20, bug #18835 (project freeciv):

By the way, saving that freeciv save file i notice that it truncates out
everything after the first '.'. Is that a known bug, or should i open a
ticket? (the original name was freeciv2.3.0-hacked)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Karl Goetz]

Follow-up Comment #19, bug #18835 (project freeciv):

Looks like the debian patch regarding unity was the cause. switched your new
patch to the top of the patch que, disabled the unity patch and it built.

And works :)

It looks good, just wondering if what i'm seeing is specific to my screen.
I've attached two screenshots, one with touching and one without.

First is that the gold adjustment arrows seem to sit over the right hand side
of the gold box (i circled that).

Second is the size of the 'clauses' window. is that fixed so it scales into
small screens? i'd have thought it would make more sense to have that maybe
twice the size it is now (given the amount of space i have free on the bottom
of my screen).

I'll attach the images and the save game (its just a game at the first move
with all the nations stuck on an island).

(file #14370, file #14371, file #14372)
___

Additional Item Attachment:

File name: freeciv2.3.0_scaled_drawn.png  Size:139 KB
File name: freeciv2.sav.bz2   Size:13 KB
File name: freeciv2.3.0_scaled_untouched.png Size:129 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #18, bug #18835 (project freeciv):

I did had a look into the debian patches - they do not change much. The
attched file is for 2.3.0 and tested ...

Please report how it works / looks like in non-default settings (small
screen, ...)

(file #14360)
___

Additional Item Attachment:

File name: dipl_dialog-S2_3-all.patch Size:24 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Karl Goetz]

Follow-up Comment #17, bug #18835 (project freeciv):

I added it last in the patch series the 2.3.0 debian patches have. (Its
entirely possible one of those is buggering things up, as we have various
patches applied to the client UIs).

http://anonscm.debian.org/gitweb/?p=pkg-games/freeciv.git;a=tree;f=debian/patches;h=520c743a2f2f98d60024dbb3776170a055858e73;hb=2d3aa6563d918ddca4d3a69c7621a30d5c36f839

I think this link will show the 2.3.0-1 packaging, which is what currently
lives in testing/unstable.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #16, bug #18835 (project freeciv):

> Unfortunately the UI doesn't appear to have changed. Did i need
> to apply other patches too? 
I did check if the patch applies to the current S2_3 branch. You have a plain
2.3.0 source tarball?

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Karl Goetz]

Follow-up Comment #15, bug #18835 (project freeciv):

Based on the debian 2.3.0 packaging I tried to build a package with the all
in one dipl patch applied. I've had to modify the patch to cityrep.c diff a
little, but it compiled up with the changes. Unfortunately the UI doesn't
appear to have changed. Did i need to apply other patches too?

I'm not overly worried, I don't ever have more 3 diplomacy windows open at
once :)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Matthias Pfafferodt]

Follow-up Comment #14, bug #18835 (project freeciv):

> Re comment #9: off-hand, I don't see why this would need to be
> optional. But I haven't checked all layout variants.
I'm not sure about all the possible layout variants; especially as we did lot
to support small screens. But if it is working, no new option has to be added.
I would like input from others. I will now focus on the transport patches
after fixing bug #18776 (and bug #18886).

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

[Jacob Nevins]

Update of bug #18835 (project freeciv):

 Summary: please support vertical tabs => Make many diplomacy
dialogs easier to manage (e.g. using vertical tabs)


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev