Re: [Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units

2007-12-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 Daniel Markstedt wrote: I agree that this was done in too hasty a fashion. William, if you wanted this code gone so badly, you could at least have presented some kind of roadmap for reimplementation. There is no *need* for

Re: [Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units

2007-12-03 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 William Allen Simpson wrote: (1) You have two ways of doing the same thing. Should be fixed. (2) One of them has not worked for about two years, and certainly was not tested at the time it was committed. I'm quite sure it worked

Re: [Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units

2007-12-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 Jason Dorje Short wrote: William Allen Simpson wrote: (2) One of them has not worked for about two years, and certainly was not tested at the time it was committed. I'm quite sure it worked when it was committed. Here's the patch

Re: [Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units

2007-12-03 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 William Allen Simpson wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 Jason Dorje Short wrote: William Allen Simpson wrote: (2) One of them has not worked for about two years, and certainly was not tested at the

Re: [Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units

2007-12-03 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 Pepeto _ wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 [EMAIL PROTECTED] - Lun. Déc. 03 18:45:11 2007]: William Allen Simpson wrote: (2) One of them has not worked for about two years, and certainly was not

Re: [Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units

2007-12-02 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 Jason Dorje Short wrote: No need to read the code, just ask anyone who plays multiplayer. The code itself is canonical. The quickselect is intended to pick a quick unit from the current stack to do a quick action. Wrong. The

Re: [Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units

2007-12-02 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 Committed S2_1 revision 14112. Committed S2_2 revision 14113. Committed trunk revision 14114. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units

2007-12-02 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 William Allen Simpson wrote: Since this was broken (by you in PR#14365) circa Dec 2005, and has had only one report (Aug 2007) in two (2) years, it is clearly not a commonly used command. It has never worked. It was never

Re: [Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units

2007-12-02 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 Jason Dorje Short wrote: Also, it makes no technical sense to delete an existing keyboard command that duplicates a mouse command. We still have exactly the same problem we had before but without the keyboard shortcut for it.

Re: [Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units

2007-12-02 Thread Daniel Markstedt
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 On 12/3/07, Jason Dorje Short [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 William Allen Simpson wrote: Since this was broken (by you in PR#14365) circa Dec 2005, and has had only one

Re: [Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units

2007-12-02 Thread Jason Dorje Short
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 William Allen Simpson wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 Jason Dorje Short wrote: Also, it makes no technical sense to delete an existing keyboard command that duplicates a mouse command. We still

Re: [Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units

2007-12-01 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39602 Yet another of the myriad bugs introduced by PR#14365. I'm so sick and tired of cleaning up this battlegroup mess! These keys are undocumented intercepts (just as ESC) that appear only in the gui-gtk2 client. They are not in any menu.