Re: [Geoserver-devel] milestone release roll call

2015-05-22 Thread Niels Charlier
Hi Jody, I think discussions have been resolved. For the time being we do not plan any move away from restful in geoserver and we will keep the user/role stuff as a bonus feature of geofence-server for now until it is reimplemented in restful. Just the spring bean issue (see other email)

Re: [Geoserver-devel] geofence-server broken due to changes in GeoServerTestSupport

2015-05-22 Thread Niels Charlier
On 22-05-15 12:28, Andrea Aime wrote: Before I spend a lot of more time on this I wanted to check if you guys had an easy solution. I noticed the commit adds a lot of 'lazy-init=false' to the bean definitions. Now the problem is that this regards beans defined in the geofence

[Geoserver-devel] geofence-server broken due to changes in GeoServerTestSupport

2015-05-22 Thread Niels Charlier
Hello Andrea and Jody, There are two tests in geofence-server that are based on GeoServerTestSupport to initialize the spring context. They used to work fine but only since recently they started breaking, and I traced it back to this commit you guys did:

Re: [Geoserver-devel] geofence-server broken due to changes in GeoServerTestSupport

2015-05-22 Thread Niels Charlier
it must at least be made optional somehow because at this point it is already too late to change when oneTimeSetUp is run in my derived class. Regards Niels On 22-05-15 13:51, Andrea Aime wrote: On Fri, May 22, 2015 at 1:23 PM, Niels Charlier ni...@scitus.be mailto:ni...@scitus.be wrote

Re: [Geoserver-devel] geofence-server broken due to changes in GeoServerTestSupport

2015-05-22 Thread Niels Charlier
On 22-05-15 16:28, Andrea Aime wrote: On Fri, May 22, 2015 at 4:26 PM, Niels Charlier ni...@scitus.be mailto:ni...@scitus.be wrote: I would recommend removing that line altogether since it seems a malfunction to me. Otherwise it must at least be made optional somehow because

Re: [Geoserver-devel] User REST API discussion

2015-05-26 Thread Niels Charlier
Hello Jody, I asked about this on the list though, and Christian said he wasn't implementing any user/group control. I can't see anything about that in the proposal either. Regards Niels On 05/26/2015 10:18 PM, Jody Garnett wrote: As per this meeting minuets I have an action item to catch up

[Geoserver-devel] ResourceStore API change proposal

2015-08-13 Thread Niels Charlier
After some further discussion with Jody, I've cooked up the following proposal for ResourceStore API changes: https://github.com/geoserver/geoserver/wiki/GSIP-132---ResourceStore-API-changes. Please don't hesitate to give feedback. Kind Regards Niels

Re: [Geoserver-devel] ResourceStore API change proposal

2015-08-13 Thread Niels Charlier
On 13-08-15 15:02, Andrea Aime wrote: On Thu, Aug 13, 2015 at 1:13 PM, Niels Charlier ni...@scitus.be mailto:ni...@scitus.be wrote: After some further discussion with Jody, I've cooked up the following proposal for ResourceStore API changes: https://github.com/geoserver/geoserver

Re: [Geoserver-devel] ResourceStore API change proposal

2015-08-19 Thread Niels Charlier
On 14-08-15 19:21, Andrea Aime wrote: Hi, +0, already added. Thanks One question, I see this: bean id=resourceStore class=org.geoserver.platform.resource.ResourceStoreProxy property name=delegate ref=dataDirectoryResourceStore/ /bean But I believe you want to allow a JDBC based

Re: [Geoserver-devel] Resource.delete discussion

2015-08-19 Thread Niels Charlier
On 12-08-15 17:57, Niels Charlier wrote: Hmmm. That is a good point. But FileSystemResource.delete doesn't acquire a lock. Is that normal? Either way, we can get the locks recursively first. Best to keep sql queries as efficient as possible. Hi Jody, you never responded to this. Should

[Geoserver-devel] combining rasters to make one

2015-06-29 Thread Niels Charlier
Hi, I was wondering if there exists any tool in the geotools/geoserver framework to do the following: Given two rasters A[x,y] and B[x,y] you want to output a single layer with colors C[x,y] = some_calculation(A[x,y], B[x,y]) which can be expressed in a simple CQL expression. I thought of

Re: [Geoserver-devel] gdal_translate config file and resource locks

2015-08-06 Thread Niels Charlier
Hi Jody, Makes sense. It looks to me like the PR does use the ResourceListener rather than FileWatcher. Ideally, the resource.lock() should also be used to have a uniform API for locking. Regards Niels On 05-08-15 19:53, Jody Garnett wrote: Quick question Niels since we were discussing

[Geoserver-devel] Resource.delete discussion

2015-08-12 Thread Niels Charlier
Hi Jody, To follow up on the github discussion regarding the resources delete API. As I understand we have three methods to delete resources: 1. Resource.delete() - non recursive (until last PR), returns false if file doesn't exist 2. ResourceStore.remove

Re: [Geoserver-devel] Resource.delete discussion

2015-08-12 Thread Niels Charlier
On 12-08-15 17:35, Jody Garnett wrote: We should also make the return value consistent. The return value was chosen for consistency with File.delete(). Much like making Resource method compatible with File, the return value made it easier to migrate code that made direct use of File. Then

Re: [Geoserver-devel] gdal_translate config file and resource locks

2015-08-06 Thread Niels Charlier
, and then released it on close(). Not sure if I did not successfully or not - you are welcome to review. Point being that locks are involved in resource access; so me may need to look out for deadlock. -- Jody Garnett On 6 August 2015 at 04:24, Niels Charlier ni...@scitus.be mailto:ni...@scitus.be wrote

Re: [Geoserver-devel] ResourceStore API change proposal

2015-08-14 Thread Niels Charlier
the URI (including the trailing period), saving it as a draft, then hover over the link while viewing the email in the Drafts folder. You should see that the trailing period is honoured in the URI shown in the Thunderbird status bar. Kind regards, Ben. On 14/08/15 01:25, Niels Charlier wrote

Re: [Geoserver-devel] Jdbc resource store

2015-07-27 Thread Niels Charlier
Jody, On 07/24/2015 10:28 PM, Jody Garnett wrote: Still we may be thinking in a different direction. The initial import from data directory to JDBCConfig is a one time journey. After that the idea is to manage via REST API (yes ResourceStore still needs a REST API). It sounds like you are

[Geoserver-devel] Jdbc resource store

2015-07-21 Thread Niels Charlier
Hi Kevin and Gabriel, I have a few questions regarding the jdbc resource store and the resource store API in general that I'd like to hear your opinion on. Including the mailing list because others might have thoughts on this. 1) The ResourceStore does not appear to provide anything for

Re: [Geoserver-devel] Jdbc resource store

2015-07-24 Thread Niels Charlier
On 23-07-15 18:45, Jody Garnett wrote: I implemented replacement watchers as part of the migration? Are they not working for you ... And that code should still work, the directory will get unpacked - but it is not any kind of fun. If the changes are picked up and written to the db

Re: [Geoserver-devel] Jdbc resource store

2015-07-23 Thread Niels Charlier
Hi Jody, On 23-07-15 17:53, Jody Garnett wrote: Have a look at the examples I linked to. We need a second QA pass through the codebase to remove references to files (and deprecate methods like getOrCreateDirectory). For the first pass I just implemented them all in terms of Resource - but

Re: [Geoserver-devel] Jdbc resource store

2015-07-23 Thread Niels Charlier
On 23-07-15 07:05, Jody Garnett wrote: Directories do not exist until needed, just like resources are not created until needed. We worked hard to simplify all the common checks including that one :) So for a file system resource store if you create a resource using resource.out() the file (and

Re: [Geoserver-devel] Jdbc resource store

2015-07-23 Thread Niels Charlier
On 23-07-15 10:16, Niels Charlier wrote: On 23-07-15 07:05, Jody Garnett wrote: Directories do not exist until needed, just like resources are not created until needed. We worked hard to simplify all the common checks including that one :) So for a file system resource store if you create

Re: [Geoserver-devel] Resources port

2015-10-27 Thread Niels Charlier
a ResourceStore, should it not take the baseDirectory from it somehow. Niels On 27-10-15 14:21, Niels Charlier wrote: Hello Jody, Thanks for your email! That clarifies at least which direction we should be going with some of these issues. A few remaining important points: 1. Can you fill me

Re: [Geoserver-devel] Resources port

2015-10-27 Thread Niels Charlier
-132 <https://github.com/geoserver/geoserver/wiki/GSIP-132> (unless that is completed already). On 7 October 2015 at 05:28, Niels Charlier <ni...@scitus.be <mailto:ni...@scitus.be>> wrote: Hi Jody, Gabriel, Kevin I have been porting all modules to use th

[Geoserver-devel] LayergroupInfo changes

2015-10-27 Thread Niels Charlier
Hi, I want to propose some minor API changes for the catalog, will make a proper proposal but just wanted to check already if I can expect this to be an issue or not. 1. Move property [AttributionInfo attribution] from LayerInfo to PublishedInfo, so that Layergroups can have this as well. 2.

Re: [Geoserver-devel] resource store and base directory discussion

2015-11-17 Thread Niels Charlier
On 17-11-15 02:45, Jody Garnett wrote: > public GeoServerResourceLoader(ResourceStore resourceStore) { > if( resourceStore instanceof FileSystemResourceStore){ > FileSystemResourceStore files = (FileSystemResourceStore) > resourceStore; > this.baseDirectory =

Re: [Geoserver-devel] LayergroupInfo changes

2015-11-07 Thread Niels Charlier
Jody, Where's the template? I copy pasted the titles from the most recent proposal. Regards Niels On 11/06/2015 05:06 PM, Jody Garnett wrote: I updated the page with +1, but your proposal may of used the old template? -- Jody Garnett On 6 November 2015 at 11:46, Niels Charlier <

[Geoserver-devel] Fwd: Re: Resources port

2015-11-04 Thread Niels Charlier
2015 14:28:47 +0100 From: Niels Charlier <ni...@scitus.be> To: Jody Garnett <jody.garn...@gmail.com> CC: Gabriel Roldan <grol...@boundlessgeo.com>, Kevin Smith <ksm...@boundlessgeo.com>, Geoserver-devel <geoserver-devel@lists.sourceforge.net> Jody, Small a

Re: [Geoserver-devel] LayergroupInfo changes

2015-11-06 Thread Niels Charlier
https://github.com/geoserver/geoserver/wiki/GSIP-135 Let me know what you think. Kind Regards Niels On 27-10-15 19:09, Jody Garnett wrote: Yeah okay I like that. I had a proposal a while back to organize our pages with consistent headings (like GetCapabilities for all the title, abstract,

Re: [Geoserver-devel] Direct Download links from CSW

2015-10-07 Thread Niels Charlier
entries to be added where I wouldn't add 2 x thousands null values. Best Regards, Daniele On Fri, Sep 25, 2015 at 12:49 PM, Niels Charlier <ni...@scitus.be <mailto:ni...@scitus.be>> wrote: Hi Daniele, The way the builder works now that it is required that the counts of

[Geoserver-devel] Resources port

2015-10-07 Thread Niels Charlier
Hi Jody, Gabriel, Kevin I have been porting all modules to use the resources system consistently and only use files when necessary (usually external library). I still stumbled upon two minor questions/issues I wanted to discuss. 1. Usage of the "data" directory. At the moment the import from

[Geoserver-devel] clustering / db config

2015-07-08 Thread Niels Charlier
Hello, In order to facilitate clustering, we are planning to get rid of ALL remaining file-based configurations in geoserver and move them to a db, like was already done for the catalog with jdbcconfig. Not entirely clear yet what all entails yet, but I'm doing some research and investigating

Re: [Geoserver-devel] clustering / db config

2015-07-09 Thread Niels Charlier
started a JDBCresourceStore he should be able to share with you. On a related not we can still hunt down some file use and change it to use inputstream for direct blob access. On Wed, Jul 8, 2015 at 12:56 PM Niels Charlier ni...@scitus.be mailto:ni...@scitus.be wrote: Hello, In order

Re: [Geoserver-devel] Direct Download links from CSW

2015-09-25 Thread Niels Charlier
Hi Daniele, The way the builder works now that it is required that the counts of the mappings match in order to know which URL to map to which protocol inside each OnlineResource. If you want to programmatically add an extra OnlineResource, you need to add an extra protocol mapping as well.

Re: [Geoserver-devel] Build failed in Jenkins: GeoServer-Master #2430

2015-12-03 Thread Niels Charlier
And windows continues to pester us... Now that is a little bit of mystery :O On 03-12-15 11:10, winbu...@geo-solutions.it wrote: > See > > > Changes: > > [niels] GEOS-7331 - Build failure in >

Re: [Geoserver-devel] Build failed in Jenkins: GeoServer-Master #2440

2015-12-06 Thread Niels Charlier
been received in error. The sender does not give any warranty > or accept liability as the content, accuracy or completeness of sent > messages and accepts no responsibility for changes made after they > were sent or for other risks which arise as a result of e-mail > transmissio

Re: [Geoserver-devel] GeoServer Winbuild failures

2015-12-06 Thread Niels Charlier
Torben, Thanks for your help! It appears I made the same mistake a few times. Regards Niels On 12/04/2015 10:51 PM, Torben Barsballe wrote: > Given that I have access to a Windows development environment, I will > see if I can fix some the test failures we are seeing (currently in > the Core

[Geoserver-devel] new community module: jdbcstore

2015-12-09 Thread Niels Charlier
We'd like to create a new community module: jdbcstore, which implements the resource store (normally the data directory) as a jdbc database with BLOBs in it. Kind Regards Niels --

Re: [Geoserver-devel] Build failed in Jenkins: GeoServer-Master #2440

2015-12-04 Thread Niels Charlier
When does this build again? I committed a patch Regards Niels On 04-12-15 09:57, winbu...@geo-solutions.it wrote: > See > > -- > [...truncated 54059 lines...] > [INFO] GeoServer LDAP

Re: [Geoserver-devel] new community module: jdbcstore

2015-12-10 Thread Niels Charlier
? (Like would you ever want one without the other?) -- Jody Garnett On 9 December 2015 at 08:39, Niels Charlier <ni...@scitus.be <mailto:ni...@scitus.be>> wrote: We'd like to create a new community module: jdbcstore, which implements the resource store (normally the da

[Geoserver-devel] (jdbc) resource store: platform additions

2015-12-16 Thread Niels Charlier
Hi Everyone, We have a pull request for the jdbc resource store (as well as some additional resources port commits ) See https://github.com/geoserver/geoserver/pull/1361 It has been fully reviewed by Ben, but there is some new resources related stuff added to the platform module that I wanted

Re: [Geoserver-devel] cleaning up file references complete?

2016-01-07 Thread Niels Charlier
On 07-01-16 03:43, Jody Garnett wrote: Reviewing the technical debt pages - can mark our previous cleaning up file references page as complete? -- Jody Garnett Yep. Cheers Niels

Re: [Geoserver-devel] GSIP-136 Resource Notification Dispatcher

2016-01-07 Thread Niels Charlier
Looks good to me. I have updated the PR already to match the API change you made. Kind Regards Niels On 07-01-16 03:46, Jody Garnett wrote: This is a follow up to pull request #1361 introducing some new public API:

Re: [Geoserver-devel] (jdbc) resource store: platform additions

2015-12-23 Thread Niels Charlier
On 22-12-15 23:00, Jody Garnett wrote: > > Think you are missing the idea - in most cases these resources are not > unpacked on disk and are retrieved by JDBCResourceStore. I do not know > what that will do to performance - but that is why JDBCResourceStore > is a community module. If we need

Re: [Geoserver-devel] (jdbc) resource store: platform additions

2015-12-18 Thread Niels Charlier
Hi Jody, Thanks for your review. On 17-12-15 00:36, Jody Garnett wrote: > - architecture reason: I was trying to have ResourceStore be the > single source of truth for resources (including change notification). > Is there a reason why this should change? Yes and no. There is a very clear

Re: [Geoserver-devel] (jdbc) resource store: platform additions

2015-12-18 Thread Niels Charlier
On 18-12-15 16:04, Niels Charlier wrote: > >> - yeah I know you did not write this - just added one that takes a >> URL (do you really need both?) > > Yes, you do. The fromURL(String) method accepts things that would be > rejected by a normal URL parser, abolishi

Re: [Geoserver-devel] (jdbc) resource store: platform additions

2015-12-21 Thread Niels Charlier
distribution (in a cluster, recorded in an audit log). On 18 December 2015 at 07:04, Niels Charlier <ni...@scitus.be <mailto:ni...@scitus.be>> wrote: no problem: because this isn't being enforced. The ResourceStore already provides the API needed for adding handlers

Re: [Geoserver-devel] (jdbc) resource store: platform additions

2015-12-21 Thread Niels Charlier
I'd suggest merging ResourceLoader and GeoServerDataDirectory. Both of them provide mostly a lot of convenience methods and a little bit of extra logic on top of the ResourceStore. We can remove a lot of the depecrated stuff now. On 19-12-15 01:43, Jody Garnett wrote: And utility methods ...

Re: [Geoserver-devel] (jdbc) resource store: platform additions

2015-12-22 Thread Niels Charlier
Hi Jody, The requirement is that if a resource listener is placed on a resource, any change to that resource should be notified, also if that change occurred in another instance of Geoserver in a clustered environment. Just like the FileBasedResources notify all changes to a file. I would not

Re: [Geoserver-devel] resource store and base directory discussion

2015-11-20 Thread Niels Charlier
Hi Jody, I have made a few minor edits to https://github.com/geoserver/geoserver/wiki/Cleaning-up-File-References Now we just need to decide which of the two possibilities we prefer. I really don't mind which one. Regards Niels On 18-11-15 01:48, Jody Garnett wrote: Here is a branch where

[Geoserver-devel] Proposal: ResourceStore Rest API

2016-01-13 Thread Niels Charlier
Please offer feedback for the following proposal: https://github.com/geoserver/geoserver/wiki/GSIP-137 Kind Regards Niels -- Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM +

Re: [Geoserver-devel] Proposal: ResourceStore Rest API

2016-01-13 Thread Niels Charlier
that exists return 405 -- Jody Garnett On 13 January 2016 at 03:47, Niels Charlier <ni...@scitus.be <mailto:ni...@scitus.be>> wrote: Please offer feedback for the following proposal: https://github.com/geoserver/geoserver/wiki/GSIP-137 Kind Regar

Re: [Geoserver-devel] GSIP-136 Resource Notification Dispatcher

2016-01-18 Thread Niels Charlier
Thanks Ben, I'll make a new PR as soon as we figured out the proposal Cheers Niels On 01/17/2016 06:18 PM, Ben Caradoc-Davies wrote: > And it might be best to clean up after me by cherry-picking the two > commits that were left on PR #1361 (with GSIP-136 in their title) onto > master. >

Re: [Geoserver-devel] GSIP-136 Resource Notification Dispatcher

2016-01-18 Thread Niels Charlier
This change is fine by me, my original idea was to keep the API as unaffected as possible and keep the dispatcher something running in the background, optionally. But - that means that the FileSystemRS also will need a ResourceNotificationDispatcher. The FileSystemWatcher almost implements

Re: [Geoserver-devel] GSIP-136 Resource Notification Dispatcher

2016-01-16 Thread Niels Charlier
Does it make sense that the proposal gets rejected with only +1 and 0 votes? If people are saying 0 it means that they don't particularly care one way or the other. Normally in elections, parliaments and referenda you only need half of the non-neutral votes, with a minimum participation

Re: [Geoserver-devel] Proposal: ResourceStore Rest API

2016-01-14 Thread Niels Charlier
I've changed the proposal. I will research the HEAD proposal, but I'll support ?metadata anyway (as it is extendible) Regards Niels On 14-01-16 00:03, Jody Garnett wrote: Correct, and tricky - wonder if our rest library supports that :) Still human navigable html output our Json is not a bad

Re: [Geoserver-devel] Proposal: ResourceStore Rest API

2016-01-14 Thread Niels Charlier
There is a difference at this moment. However, there is no way to create an empty directory from nothing. It can only exist if all of its children are deleted. I like your suggestion. That would imply that a directory is automatically deleted when it becomes empty. This goes back to the

[Geoserver-devel] DEMStore community module

2016-02-10 Thread Niels Charlier
I'd like permission to create a new community module called "demstore". This is a store specialised for Digital Elevation Models. The idea is to merge different granules that may be of different resolution and quality. It will be built on top of the mosaicstore with extra features such as - more

Re: [Geoserver-devel] missing geofence component on atlassian jira

2016-02-05 Thread Niels Charlier
liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc. On Fri, Jan 29, 2016 at 9:18 AM, Niels Charlier wrote: > Subject says it all...

Re: [Geoserver-devel] Proposal: ResourceStore Rest API

2016-01-29 Thread Niels Charlier
Can we get a re-vote on this please? We have made changes. On 26-01-16 22:41, Niels Charlier wrote: Yes On 01/26/2016 09:48 PM, Jody Garnett wrote: So Niels would you like people to review and vote on this now? -- Jody Garnett On 14 January 2016 at 08:38, Niels Charlier <ni...@scitus

Re: [Geoserver-devel] GSIP-137 ResourceStore REST API Proposal

2016-01-29 Thread Niels Charlier
Andrea, have I addressed your questions well enough with my changes? Do we agree on removing POST altogether (have not yet changed this in the proposal yet)? Niels On 27-01-16 11:29, Niels Charlier wrote: > Hi Andrea, > > Thanks for your review. > > On 27-01-16 10:48, Andrea Ai

[Geoserver-devel] missing geofence component on atlassian jira

2016-01-29 Thread Niels Charlier
Subject says it all... can someone with privileges add this? Cheers Niels -- Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month

Re: [Geoserver-devel] GSIP-137 ResourceStore REST API Proposal

2016-02-03 Thread Niels Charlier
HI Ben, Thanks for your review! On 02/02/2016 08:37 PM, Ben Caradoc-Davies wrote: > +1. Looking pretty good. Observations: Cool thanks, that makes it approved then. > > - Instead of metadata, it would be (arguably) more RESTful to support > a HEAD operation. You have a header for Last-Modified,

Re: [Geoserver-devel] GSIP-137 ResourceStore REST API Proposal

2016-02-02 Thread Niels Charlier
On 30-01-16 12:08, Andrea Aime wrote: The ResourceMetadata xml representation should be follow the same resource interlinking approach as our main REST API, for example: Modified. I'd remove POST, two ways to do exactly the same things seem redundant to me, not sure what other think...

Re: [Geoserver-devel] Proposal: ResourceStore Rest API

2016-02-02 Thread Niels Charlier
on filename extension - a bit risky but would allow people to see PNG files in their browser. -- Jody Garnett On 27 January 2016 at 03:06, Niels Charlier <ni...@scitus.be <mailto:ni...@scitus.be>> wrote: On 14-01-16 00:01, Robert Coup wrote: HEAD /resource/path/

Re: [Geoserver-devel] GSIP-137 ResourceStore REST API Proposal

2016-02-02 Thread Niels Charlier
resource with the REST API or on the file system is identical. Regards Niels On 02-02-16 11:44, Andrea Aime wrote: On Tue, Feb 2, 2016 at 11:26 AM, Niels Charlier <ni...@scitus.be <mailto:ni...@scitus.be>> wrote: Writing the above I actually raised one more question: what

Re: [Geoserver-devel] GSIP-136 Resource Notification Dispatcher

2016-02-02 Thread Niels Charlier
So, if that has been fixed does that mean we can get an additional +1? :) On 31-01-16 19:18, Jody Garnett wrote: Right, I can delete the "listen to root" idea. I had the idea that we could listen to the root folder (as an alternative to this proposal) and be advised of all resource changes.

Re: [Geoserver-devel] GSIP 139 - GeoServer Resource Browser GUI

2016-02-24 Thread Niels Charlier
Thanks, Jody. Comments inline. On 23-02-16 20:01, Jody Garnett wrote: > I untangled your bullet points, and seperate out the images so I could > see what you intended for each button/dialog. This results in some > duplication of text, but was easier (for me at least) to follow. > Please review

Re: [Geoserver-devel] GSIP 139 - GeoServer Resource Browser GUI

2016-02-24 Thread Niels Charlier
On 23-02-16 18:55, Jody Garnett wrote: > Looks good Niels, UI proposals are always tough (and change in the > telling when you start implementing). > > Not sure if you need a download button, often clicking on the file in > the list should download it? Or if the idea is to check several things

Re: [Geoserver-devel] GSIP 139 - GeoServer Resource Browser GUI

2016-02-24 Thread Niels Charlier
On 24-02-16 11:07, Jody Garnett wrote: Thanks for the discussion, have a look again at the bullet points (I am sure I missed something in refactoring your page). Had to fix a few small mistakes, but looks fine otherwise. - Consider using "Path" rather than "Directory" (consistent

[Geoserver-devel] GSIP 139 - GeoServer Resource Browser GUI

2016-02-23 Thread Niels Charlier
HI, I have made a proposal for the resource store GUI: https://github.com/geoserver/geoserver/wiki/GSIP-139 Please let me know what you think. Kind Regards Niels -- Site24x7 APM Insight: Get Deep Visibility into

Re: [Geoserver-devel] Issues running JDBCResourceStore

2016-02-23 Thread Niels Charlier
On 23-02-16 06:53, Jody Garnett wrote: Some comments supplied for 510. - Removed ResourceStore interface from GeoServerDataDirectory where it wasn't really being used. I got the impression from Jody that this whole class might be heading towards deprecation anyway (correct me if

Re: [Geoserver-devel] Issues running JDBCResourceStore

2016-02-23 Thread Niels Charlier
n seems to work fine and is alright by me. I created a PR for it: https://github.com/geoserver/geoserver/pull/1495 On Tue, Feb 16, 2016 at 1:10 AM, Niels Charlier <ni...@scitus.be <mailto:ni...@scitus.be>> wrote: Yeah, as he explained that is complic

Re: [Geoserver-devel] java 8, spring asm compatibility troubles...

2016-02-25 Thread Niels Charlier
Yeah geofence-server is not using context:component-scan. Beans are still declared manually. It is only using for the MVC annotations inside the controllers. Regards Niels On 02/25/2016 10:11 AM, Andrea Aime wrote: Hi, found this one on the net:

Re: [Geoserver-devel] Build failed in Jenkins: GeoServer-Master #2667

2016-02-24 Thread Niels Charlier
Thanks for these fixes, Ben! On 24-02-16 02:12, Ben Caradoc-Davies wrote: > Niels, > > I think I have the Windows Resource.lastmodified failure fixed: > > [GEOS-7436] Invalid directory timestamp assumptions in ResourceTest > break build on Windows >

Re: [Geoserver-devel] Proposal: ResourceStore Rest API

2016-01-27 Thread Niels Charlier
On 14-01-16 00:01, Robert Coup wrote: > HEAD /resource/path/to/directory > > Last-Modified: > > Content-Type: application/x-directory > > HEAD /resource/path/to/directory/file.png > > ETag: > > Content-Length: 12345 > > Last-Modified: > > Content-Type: image/png > > Rob :) Some comments on the

Re: [Geoserver-devel] GSIP-137 ResourceStore REST API Proposal

2016-01-27 Thread Niels Charlier
Hi Andrea, Thanks for your review. On 27-01-16 10:48, Andrea Aime wrote: > Hi Jody, > -1 for the moment, but only because the proposal is incomplete. > > Bits that should be addressed before making it go forward: > * Show the XML and JSON representations of the various resources and > commands

Re: [Geoserver-devel] Issues running JDBCResourceStore

2016-02-16 Thread Niels Charlier
Yeah, as he explained that is complicated by the fact that GeoServerDataDirectory and GeoServerResourceLoader are also resource store, but never "the" resource store (in fact, they depend upon it). Solution #1 Use of a Spring "alias". An alias as higher priority than a normal name. However

Re: [Geoserver-devel] Build failed in Jenkins: GeoServer-Master #2635

2016-02-16 Thread Niels Charlier
Hi Ben, I solved an issue in the test with Italian dates on the windows server, but testDirectoryHTML is still failing on windows, and it appears to be the same problem as when we tested with |ISO-8859-15 |before we fixed the template charset issue. it could be anything though, because it

Re: [Geoserver-devel] ResourceTest failure on Windows

2016-02-17 Thread Niels Charlier
Thanks for the fix, Ben! That was indeed an error. Glad you got to the bottom of it. On 17-02-16 06:16, Ben Caradoc-Davies wrote: > Aha! Revealing logged stack trace included below. > > Niels, at ResourceResource:275, instead of java.nio.file.Paths.get, > did you intend to use

Re: [Geoserver-devel] Build failed in Jenkins: GeoServer-Master #2635

2016-02-17 Thread Niels Charlier
On 16-02-16 21:14, Ben Caradoc-Davies wrote: > The encoding of the child href is very thin (only ampersand is > replaced). Encoding " to might give a better error message. And > what about percent-encoding? What happens to spaces or # or other > characters in resource names? You have a

Re: [Geoserver-devel] ResourceTest failure on Windows

2016-02-17 Thread Niels Charlier
H odd. Hard to find if we cannot reproduce it. Seems like the build has passed. On 17-02-16 09:58, Ben Caradoc-Davies wrote: > Andrea, > > I do not think that this can be ascribed to precision problems unless > File.lastModified() on Windows is unstable. > > The test compares the

Re: [Geoserver-devel] ResourceStore REST implementation

2016-02-18 Thread Niels Charlier
Hi Ben, I've made a new PR with percentage encoding as well as following your suggestion of a full URL in the resource-parent. I also found that * percentage decoding isn't happening automatically, had to add this as well to actually support the percentage encoded paths. * a bug in the URL

Re: [Geoserver-devel] ResourceStore REST implementation

2016-02-18 Thread Niels Charlier
On 18-02-16 11:23, Robert Coup wrote: Personally I'd say "no", because it's pointing to the parent /resource /rather than it's representation. /?format=/ is a bit of a hack, /Accept:/ headers are how it's /supposed/ to work in the ideal world ;) Accept: headers are supported as an

[Geoserver-devel] Proposal: GeoServer Resource Browser GUI

2016-03-10 Thread Niels Charlier
Hi, Following up on the REST API for resources, we also would like a GUI: https://github.com/geoserver/geoserver/wiki/GSIP-139 Please vote / criticise / comment. Kind Regards Niels -- Transform Data into Opportunity.

Re: [Geoserver-devel] Proposal: GeoServer Resource Browser GUI

2016-03-14 Thread Niels Charlier
So... is anyone going to vote for this proposal? Regards Niels On 12-03-16 21:24, Justin Deoliveira wrote: I’ll reply to the spring4 thread with the latest. On Thu, Mar 10, 2016 at 1:32 PM Jody Garnett > wrote: My

Re: [Geoserver-devel] Proposal: GeoServer Resource Browser GUI

2016-03-14 Thread Niels Charlier
and grow its way up to supported land. Cheers Andrea On Mon, Mar 14, 2016 at 11:57 AM, Niels Charlier <ni...@scitus.be <mailto:ni...@scitus.be>> wrote: So... is anyone going to vote for this proposal? Regards Niels On 12-03-16 21:24, Justin Deoliveira wrot

Re: [Geoserver-devel] geofence spring-4-upgrade

2016-04-07 Thread Niels Charlier
I still nobody doing rest api against docs? I am willing to work on that (or part of it). Regards Niels On 05-04-16 23:51, Jody Garnett wrote: You can always check the wiki page for latest testing status, put your initial next to

Re: [Geoserver-devel] geofence spring-4-upgrade

2016-04-07 Thread Niels Charlier
Hey Simone and Damiano, You might want to apply my patch for LDAP first to solve a small issue I encountered while testing with OpenLDAP. The issue was that an exception was thrown when attempting to log on without having "Bind user before searching for groups" ticked. The reason was that it

[Geoserver-devel] resource browser (resource store GUI)

2016-04-13 Thread Niels Charlier
Hi, I have working version of the resource browser. I didn't follow the proposal exactly. I decided to follow Andrea's suggestion to use a copy-paste system, but with a pop-up form for paste in which you can fill in a new directory if necessary. I still have to write the unit tests before

Re: [Geoserver-devel] geofence spring-4-upgrade

2016-04-11 Thread Niels Charlier
rfault.com/questions/693279/disable-anonymous-bind-to-an-active-directory-on-windows-server-2012r2 On Thu, Apr 7, 2016 at 2:52 PM, Niels Charlier <ni...@scitus.be <mailto:ni...@scitus.be>> wrote: Hey Simone and Damiano, You might want to apply my patch for LDAP first to sol

Re: [Geoserver-devel] Proposal: GeoServer Resource Browser GUI

2016-03-19 Thread Niels Charlier
these things a custom UI. Regards Niels On 03/19/2016 08:08 PM, Andrea Aime wrote: On Sat, Mar 19, 2016 at 3:42 PM, Niels Charlier <ni...@scitus.be <mailto:ni...@scitus.be>> wrote: If you are using JDBCConfig, there is no support for direct file editing of the ca

Re: [Geoserver-devel] Proposal: GeoServer Resource Browser GUI

2016-03-19 Thread Niels Charlier
Hello Andrea, Thanks for your review! Responses are inline. On 16-03-16 19:46, Andrea Aime wrote: At the same time, it means that the GUI needs to work fine with the file system... like, what if there is a very large number of files (styles, layers, whatever), is the UI going to scale up

Re: [Geoserver-devel] Proposal: GeoServer Resource Browser GUI

2016-03-23 Thread Niels Charlier
2016 at 10:47, Niels Charlier <ni...@scitus.be <mailto:ni...@scitus.be>> wrote: On 19-03-16 15:42, Niels Charlier wrote: Same goes for copy trying to imagine what one might want to copy... maybe ftl templates? Those are normally not renamed, but... they are norm

Re: [Geoserver-devel] Proposal: GeoServer Resource Browser GUI

2016-03-23 Thread Niels Charlier
On 19-03-16 15:42, Niels Charlier wrote: Same goes for copy trying to imagine what one might want to copy... maybe ftl templates? Those are normally not renamed, but... they are normally transferred in triplets. Have you considered a clipboard like approach instead, accumulate more than

Re: [Geoserver-devel] Proposal: GeoServer Resource Browser GUI

2016-03-28 Thread Niels Charlier
Asking permission for new community module "gs-web-resources" Regards Niels On 23-03-16 20:42, Niels Charlier wrote: Okay I'll just make a community module, that is fine by me Regards Niels On 03/23/2016 07:30 PM, Jody Garnett wrote: I am sorry the "lack" of a empty

Re: [Geoserver-devel] App-Schema online tests

2016-03-28 Thread Niels Charlier
ests it looks like this is an undocumented requirement? Was this tablespace maybe included by default in an earlier version of oracle? Thanks, Torben On Tue, May 12, 2015 at 5:15 AM, Niels Charlier <ni...@scitus.be <mailto:ni...@scitus.be>> wrote:

Re: [Geoserver-devel] Hazelcast/JDBConfig clustering issues caused by HTTP 302 response and unique wicket resource IDs

2016-04-29 Thread Niels Charlier
On 28-04-16 02:48, Jody Garnett wrote: > And we should report this to Jira :( > https://osgeo-org.atlassian.net/browse/GEOS-7526 I am working on reproducing the issue. Regards Niels -- Find and fix application

Re: [Geoserver-devel] 2.9 release round up

2016-05-20 Thread Niels Charlier
I can see your point, but I am personally not 100% convinced. I understand that the files are not copied to a new location by the importer module and may in fact well already be in the data directory (= the resource store). On the other hand, it does regard data rather than configurations and

Re: [Geoserver-devel] Following up on Demo Page fix

2016-05-18 Thread Niels Charlier
t;file" is actually a "config" file used by the GeoTools DataStore. -- Jody Garnett On 18 May 2016 at 06:02, Niels Charlier <ni...@scitus.be <mailto:ni...@scitus.be>> wrote: On 17-05-16 19:45, Jody Garnett wrote: > One thing that gives me concern is

<    1   2   3   4   5   6   >