Change in osmo-hlr[master]: hlr.c: forward GSUP messages between clients

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13006 ) Change subject: hlr.c: forward GSUP messages between clients .. Patch Set 11: argh, @osmith, I think I undid some of your modifications by

Change in osmo-hlr[master]: use new OSMO_IMSI_BUF_SIZE

2019-04-11 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13589 to look at the new patch set (#2). Change subject: use new OSMO_IMSI_BUF_SIZE .. use new OSMO_IMSI_BUF_

Change in osmo-hlr[master]: hlr.c: forward GSUP messages between clients

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded a new patch set (#11) to the change originally created by osmith. ( https://gerrit.osmocom.org/13006 ) Change subject: hlr.c: forward GSUP messages between clients .. hlr.c: forward GSUP messages betwe

Change in osmo-hlr[master]: GSUP routing: use Message Class IE

2019-04-11 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13588 to look at the new patch set (#2). Change subject: GSUP routing: use Message Class IE .. GSUP routing: use Message Cl

Change in osmo-ttcn3-hacks[master]: msc: f_tc_sgsap_mt_sms_and_reject: shorter delay

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. ( https://gerrit.osmocom.org/13615 ) Change subject: msc: f_tc_sgsap_mt_sms_and_reject: shorter delay .. Abandoned -- To view, visit https://gerrit.osmocom.org/13615 To unsubscribe, or fo

Change in osmo-ttcn3-hacks[master]: msc: mo and mt voice call tests: add lots of missing parts

2019-04-11 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13616 to look at the new patch set (#4). Change subject: msc: mo and mt voice call tests: add lots of missing parts .. msc:

Change in osmo-ttcn3-hacks[master]: msc: f_call_hangup: ignore MDCX

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. ( https://gerrit.osmocom.org/13168 ) Change subject: msc: f_call_hangup: ignore MDCX .. Abandoned -- To view, visit https://gerrit.osmocom.org/13168 To unsubscribe, or for help writing ma

Change in osmo-ttcn3-hacks[master]: msc: f_call_hangup: ignore MDCX

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13168 ) Change subject: msc: f_call_hangup: ignore MDCX .. Patch Set 1: actually it was removed completely. -- To view, visit https://gerrit.osmo

Change in osmo-ttcn3-hacks[master]: msc: f_call_hangup: ignore MDCX

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13168 ) Change subject: msc: f_call_hangup: ignore MDCX .. Patch Set 1: sorry, forgot about this one for a while. It is now absorbed in the the com

Change in libosmocore[master]: GSUP: add inter-MSC handover related msgs and IEs

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12860 ) Change subject: GSUP: add inter-MSC handover related msgs and IEs .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/128

Change in libosmocore[master]: add identifier sanitation for setting FSM instance ids

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13574 ) Change subject: add identifier sanitation for setting FSM instance ids .. add identifier sanitation for setting FSM instance ids We

Change in libosmocore[master]: add osmo_{escape, quote}_str_buf2() for standard args ordering

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13573 ) Change subject: add osmo_{escape,quote}_str_buf2() for standard args ordering .. add osmo_{escape,quote}_str_buf2() for standard arg

Change in libosmocore[master]: add osmo_{escape, quote}_str_buf2() for standard args ordering

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13573 ) Change subject: add osmo_{escape,quote}_str_buf2() for standard args ordering .. Patch Set 4: Code-Review+2 re-apply previous +2 after triv

Change in libosmocore[master]: tweak OSMO_STRBUF_APPEND(), add OSMO_STRBUF_APPEND_NOLEN()

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13594 ) Change subject: tweak OSMO_STRBUF_APPEND(), add OSMO_STRBUF_APPEND_NOLEN() .. tweak OSMO_STRBUF_APPEND(), add OSMO_STRBUF_APPEND_NOL

Change in osmo-msc[master]: large refactoring: support inter-BSC and inter-MSC Handover

2019-04-11 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13137 to look at the new patch set (#6). Change subject: large refactoring: support inter-BSC and inter-MSC Handover .. lar

Change in libosmo-sccp[master]: add caller-owns-msgb variant osmo_sccp_user_sap_down_nofree()

2019-04-11 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13277 to look at the new patch set (#2). Change subject: add caller-owns-msgb variant osmo_sccp_user_sap_down_nofree() .. a

Change in osmo-ttcn3-hacks[master]: msc: mo and mt voice call tests: add lots of missing parts

2019-04-11 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13616 to look at the new patch set (#3). Change subject: msc: mo and mt voice call tests: add lots of missing parts .. msc:

Change in osmo-ttcn3-hacks[master]: msc: f_tc_sgsap_mt_sms_and_reject: expect SMPP messages (REALLY?)

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. ( https://gerrit.osmocom.org/13614 ) Change subject: msc: f_tc_sgsap_mt_sms_and_reject: expect SMPP messages (REALLY?) .. Abandoned -- To view, visit https://gerrit.osmocom.org/13614 To

Change in osmo-ttcn3-hacks[master]: msc: clear the failed SMS when a test is done

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13613 ) Change subject: msc: clear the failed SMS when a test is done .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/1

Change in osmo-ttcn3-hacks[master]: msc: expect only one Paging on failed MT SMS

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13192 ) Change subject: msc: expect only one Paging on failed MT SMS .. msc: expect only one Paging on failed MT SMS An MSC might decide to

Change in osmo-ttcn3-hacks[master]: msc: clear the failed SMS when a test is done

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13613 ) Change subject: msc: clear the failed SMS when a test is done .. msc: clear the failed SMS when a test is done If an MT SMS is trig

Change in osmo-ttcn3-hacks[master]: msc: expect only one Paging on failed MT SMS

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13192 ) Change subject: msc: expect only one Paging on failed MT SMS .. Patch Set 3: Code-Review+2 I just merged an osmo-msc change that will proba

Change in osmo-ttcn3-hacks[master]: msc: clear the failed SMS when a test is done

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13613 ) Change subject: msc: clear the failed SMS when a test is done .. Patch Set 1: I just merged an osmo-msc change that will probably cause puz

Change in osmo-msc[master]: vlr_subscr: use osmo_use_count

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13136 ) Change subject: vlr_subscr: use osmo_use_count .. vlr_subscr: use osmo_use_count Depends: Ife31e6798b4e728a23913179e346552a7dd338c0

Change in osmo-msc[master]: enable osmo_fsm_term_safely(), apply logging changes

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13592 ) Change subject: enable osmo_fsm_term_safely(), apply logging changes .. enable osmo_fsm_term_safely(), apply logging changes Start

Change in osmo-msc[master]: gsm_04_08_cc: improve logging for CC trans

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13593 ) Change subject: gsm_04_08_cc: improve logging for CC trans .. gsm_04_08_cc: improve logging for CC trans Pass trans around more fun

Change in osmo-msc[master]: sms queue: avoid repeated Paging for a failed SMS

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13173 ) Change subject: sms queue: avoid repeated Paging for a failed SMS .. sms queue: avoid repeated Paging for a failed SMS So far, sms_

Change in osmo-msc[master]: sms queue: avoid repeated Paging for a failed SMS

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13173 ) Change subject: sms queue: avoid repeated Paging for a failed SMS .. Patch Set 5: Code-Review+2 applying +1+1 == +2 -- To view, visit htt

Change in osmo-bsc[master]: lchan activation: add explicit encryption info to activation

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13582 ) Change subject: lchan activation: add explicit encryption info to activation .. lchan activation: add explicit encryption info to ac

Change in osmo-msc[master]: add LOG_TRANS, proper context for all transactions

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13139 ) Change subject: add LOG_TRANS, proper context for all transactions .. Patch Set 5: This change is ready for review. -- To view, visit htt

Change in osmo-bsc[master]: fix inter-BSC-HO-incoming for AoIP (1/2)

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13584 ) Change subject: fix inter-BSC-HO-incoming for AoIP (1/2) .. fix inter-BSC-HO-incoming for AoIP (1/2) Move the HO_ST_WAIT_MGW_ENDPOI

Change in osmo-bsc[master]: Handover Request: also parse Chosen Algorithm IE, pass to lchan activ...

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/13583 ) Change subject: Handover Request: also parse Chosen Algorithm IE, pass to lchan activation .. Handover Request: also parse Chosen A

Change in osmo-ttcn3-hacks[master]: msc: f_tc_sgsap_mt_sms_and_reject: shorter delay

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13615 Change subject: msc: f_tc_sgsap_mt_sms_and_reject: shorter delay .. msc: f_tc_sgsap_mt_sms_and_reject: shorter delay Change-Id: I4b2a588bcd2

Change in osmo-ttcn3-hacks[master]: msc: clear the failed SMS when a test is done

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13613 Change subject: msc: clear the failed SMS when a test is done .. msc: clear the failed SMS when a test is done If an MT SMS is triggered and

Change in osmo-ttcn3-hacks[master]: msc: mo and mt voice call tests: add lots of missing parts

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13616 Change subject: msc: mo and mt voice call tests: add lots of missing parts .. msc: mo and mt voice call tests: add lots of missing parts Bot

Change in osmo-ttcn3-hacks[master]: msc: f_tc_sgsap_mt_sms_and_reject: expect SMPP messages (REALLY?)

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13614 Change subject: msc: f_tc_sgsap_mt_sms_and_reject: expect SMPP messages (REALLY?) .. msc: f_tc_sgsap_mt_sms_and_reject: expect SMPP messages

Change in osmo-ttcn3-hacks[master]: msc: expect only one Paging on failed MT SMS

2019-04-11 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13192 to look at the new patch set (#3). Change subject: msc: expect only one Paging on failed MT SMS .. msc:

Change in osmo-msc[master]: GSUP: include terminating nul in inter-MSC source/destination name

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13612 Change subject: GSUP: include terminating nul in inter-MSC source/destination name .. GSUP: include terminating nul in inter-MSC source/dest

Build failure of network:osmocom:nightly/libosmo-netif in xUbuntu_17.10/x86_64

2019-04-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/xUbuntu_17.10/x86_64 Package network:osmocom:nightly/libosmo-netif failed to build in xUbuntu_17.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last

Change in osmo-msc[master]: large refactoring: support inter-BSC and inter-MSC Handover

2019-04-11 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13137 to look at the new patch set (#5). Change subject: large refactoring: support inter-BSC and inter-MSC Handover .. lar

Change in osmo-msc[master]: sms queue: avoid repeated Paging for a failed SMS

2019-04-11 Thread Neels Hofmeyr
Hello Vadim Yanitskiy, Keith Whyte, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13173 to look at the new patch set (#5). Change subject: sms queue: avoid repeated Paging for a failed SMS .

Change in osmo-msc[master]: rename bscconfig.h to config.h, cleanup

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13138 ) Change subject: rename bscconfig.h to config.h, cleanup .. Patch Set 4: This change is ready for review. -- To view, visit https://gerrit

Change in osmo-msc[master]: large refactoring: support inter-BSC and inter-MSC Handover

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13137 ) Change subject: large refactoring: support inter-BSC and inter-MSC Handover .. Patch Set 4: This change is ready for review. -- To view,

Change in libosmocore[master]: add OSMO_IMSI_BUF_SIZE

2019-04-11 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13575 to look at the new patch set (#4). Change subject: add OSMO_IMSI_BUF_SIZE .. add OSMO_IMSI_BUF_SIZE Va

Change in libosmocore[master]: add gsm0808_create_common_id()

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13611 Change subject: add gsm0808_create_common_id() .. add gsm0808_create_common_id() Change-Id: Id055df109cf67754854641ce6486523027f4d801 --- M

Change in libosmocore[master]: add gsm0808_create_common_id()

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. ( https://gerrit.osmocom.org/13611 ) Change subject: add gsm0808_create_common_id() .. Abandoned accidental push -- To view, visit https://gerrit.osmocom.org/13611 To unsubscribe, or fo

Change in libosmocore[master]: contrib/voicecall-shark

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. ( https://gerrit.osmocom.org/13610 ) Change subject: contrib/voicecall-shark .. Abandoned accidental push -- To view, visit https://gerrit.osmocom.org/13610 To unsubscribe, or for help w

Change in libosmocore[master]: GSUP: add Message Class IE

2019-04-11 Thread Neels Hofmeyr
Hello Vadim Yanitskiy, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13576 to look at the new patch set (#4). Change subject: GSUP: add Message Class IE .. GSUP:

Change in libosmocore[master]: contrib/voicecall-shark

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/13610 Change subject: contrib/voicecall-shark .. contrib/voicecall-shark Change-Id: Ia3cdefe16b9e929d2836ca837db6f6107f7ed9eb --- A contrib/voicec

Change in libosmocore[master]: add osmo_{escape, quote}_str_buf2() for standard args ordering

2019-04-11 Thread Neels Hofmeyr
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13573 to look at the new patch set (#4). Change subject: add osmo_{escape,quote}_str_buf2() for standard args ordering ...

Change in libosmocore[master]: add gsm0808_create_handover_request_ack2 to add AoIP RTP addr

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13259 ) Change subject: add gsm0808_create_handover_request_ack2 to add AoIP RTP addr .. Patch Set 9: (1 comment) https://gerrit.osmocom.org/#/c/1

Change in libosmocore[master]: GSUP: add Class IE

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13576 ) Change subject: GSUP: add Class IE .. Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/13576/3/src/gsm/gsup.c File src/gsm/gsup.c:

Change in libosmocore[master]: GSUP: add Class IE

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13576 ) Change subject: GSUP: add Class IE .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/13576/3/include/osmocom/gsm/gsup.h File incl

Change in libosmocore[master]: GSUP: add Class IE

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13576 ) Change subject: GSUP: add Class IE .. Patch Set 3: (2 comments) I appreciate the review, but in this case... https://gerrit.osmocom.org/#

Change in libosmocore[master]: add OSMO_IMSI_SIZE

2019-04-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13575 ) Change subject: add OSMO_IMSI_SIZE .. Patch Set 3: interesting, I see "size" as synonymous with "buf_size". Even more generally appropriat

Change in osmo-ggsn[master]: ggsn: More logging from PCO handling (e.g. in case of malconfiguration)

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13609 ) Change subject: ggsn: More logging from PCO handling (e.g. in case of malconfiguration) .. Patch Set 3: Code-Review+2 (1 comment) http

Change in osmo-ggsn[master]: ggsn: Add minimalistic PAP support

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13608 ) Change subject: ggsn: Add minimalistic PAP support .. Patch Set 3: Code-Review-1 (7 comments) -1 because it should be ntohs. https://g

Change in osmo-ggsn[master]: ggsn.c: Refactor PCO processing during PDP activation

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13606 ) Change subject: ggsn.c: Refactor PCO processing during PDP activation .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13606/

Change in osmo-ttcn3-hacks[master]: ggsn: Add TC_pdp4_act_deact_ipcp_pap_broken()

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13564 ) Change subject: ggsn: Add TC_pdp4_act_deact_ipcp_pap_broken() .. Patch Set 5: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c

Change in osmo-ttcn3-hacks[master]: library: Add PAP_Types for PPP Authentication Protocol (RFC 1334)

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13607 ) Change subject: library: Add PAP_Types for PPP Authentication Protocol (RFC 1334) .. Patch Set 1: Code-Review+2 -- To view, visit http

Change in osmo-ttcn3-hacks[master]: ggsn: Verify that there are no duplicate PCO protocolIDs

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13563 ) Change subject: ggsn: Verify that there are no duplicate PCO protocolIDs .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmoc

Change in osmo-ttcn3-hacks[master]: ggsn: Add TC_pdp4_act_deact_ipcp_pap_broken()

2019-04-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13564 to look at the new patch set (#5). Change subject: ggsn: Add TC_pdp4_act_deact_ipcp_pap_broken() .. ggsn: Add TC_pdp4

Change in osmo-gsm-manuals[master]: Add debian packaging for osmo-gsm-manuals-dev

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13599 ) Change subject: Add debian packaging for osmo-gsm-manuals-dev .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/13599/2/debia

Change in osmo-gsm-manuals[master]: Makefile.am: proper noarch pkgconfig install dir

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13598 ) Change subject: Makefile.am: proper noarch pkgconfig install dir .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom

Change in osmo-ggsn[master]: ggsn: Add minimalistic PAP support

2019-04-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13608 ) Change subject: ggsn: Add minimalistic PAP support .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/13608/3/ggsn/ggsn.c File ggsn

Change in osmo-ggsn[master]: ggsn.c: Refactor PCO processing during PDP activation

2019-04-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13606 to look at the new patch set (#3). Change subject: ggsn.c: Refactor PCO processing during PDP activation .. ggsn.c: R

Change in osmo-ggsn[master]: ggsn.c: Refactor PCO processing during PDP activation

2019-04-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13606 ) Change subject: ggsn.c: Refactor PCO processing during PDP activation .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13606/1/gg

Change in osmo-ggsn[master]: ggsn: Add minimalistic PAP support

2019-04-11 Thread Harald Welte
Harald Welte has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/13608 ) Change subject: ggsn: Add minimalistic PAP support .. ggsn: Add minimalistic PAP support Some modems are configured to use PAP as an additiona

Change in osmo-ggsn[master]: ggsn: More logging from PCO handling (e.g. in case of malconfiguration)

2019-04-11 Thread Harald Welte
Harald Welte has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/13609 ) Change subject: ggsn: More logging from PCO handling (e.g. in case of malconfiguration) .. ggsn: More logging from PCO handling (e.g. in case

Change in osmo-gsm-manuals[master]: Makefile.common.inc: add {, un}install targets

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13597 ) Change subject: Makefile.common.inc: add {,un}install targets .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/13597/1/build

Change in osmo-ggsn[master]: ggsn: More logging from PCO handling (e.g. in case of malconfiguration)

2019-04-11 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13609 Change subject: ggsn: More logging from PCO handling (e.g. in case of malconfiguration) .. ggsn: More logging from PCO handling (e.g. in case

Change in osmo-ttcn3-hacks[master]: library: Add PAP_Types for PPP Authentication Protocol (RFC 1334)

2019-04-11 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13607 Change subject: library: Add PAP_Types for PPP Authentication Protocol (RFC 1334) .. library: Add PAP_Types for PPP Authentication Protocol (

Change in osmo-ggsn[master]: ggsn: Add minimalistic PAP support

2019-04-11 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13608 Change subject: ggsn: Add minimalistic PAP support .. ggsn: Add minimalistic PAP support Some modems are configured to use PAP as an addition

Change in osmo-ttcn3-hacks[master]: ggsn: Add TC_pdp4_act_deact_ipcp_pap_broken()

2019-04-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13564 to look at the new patch set (#4). Change subject: ggsn: Add TC_pdp4_act_deact_ipcp_pap_broken() .. ggsn: Add TC_pdp4

Change in osmo-gsm-manuals[master]: check-depends.sh: don't depend on git binary

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13596 ) Change subject: check-depends.sh: don't depend on git binary .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org

Change in osmo-gsm-manuals[master]: build/unix-time-to-fmt.py: use default python ver

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13595 ) Change subject: build/unix-time-to-fmt.py: use default python ver .. Patch Set 1: Code-Review+2 Oh so actually print() with parenthesis

Change in osmo-gsm-manuals[master]: build/unix-time-to-fmt.py: use default python ver

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13595 ) Change subject: build/unix-time-to-fmt.py: use default python ver .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/

Change in libosmocore[master]: add OSMO_IMSI_SIZE

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13575 ) Change subject: add OSMO_IMSI_SIZE .. Patch Set 3: I had the same thought as Vadim when I saw the name first time. BTW, I recall speaki

Change in osmo-hlr[master]: osmo-hlr: allow configuring db path from cfg file

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13586 ) Change subject: osmo-hlr: allow configuring db path from cfg file .. Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.osmoco

Change in osmo-hlr[master]: osmo-hlr: allow configuring db path from cfg file

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13586 ) Change subject: osmo-hlr: allow configuring db path from cfg file .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13586/1/sr

Change in osmo-bts[master]: pcu_sock: use %zu conversion specifier for printing sizeof() result

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13267 ) Change subject: pcu_sock: use %zu conversion specifier for printing sizeof() result .. Patch Set 4: (1 comment) https://gerrit.osmocom

Change in osmo-ggsn[master]: ggsn.c: Refactor PCO processing during PDP activation

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13606 ) Change subject: ggsn.c: Refactor PCO processing during PDP activation .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13606/

Change in osmo-ggsn[master]: ggsn.c: Refactor PCO processing during PDP activation

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13606 ) Change subject: ggsn.c: Refactor PCO processing during PDP activation .. Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/13606

Change in osmo-ggsn[master]: ggsn: Remove magic numbers from pco_contains_proto()

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13567 ) Change subject: ggsn: Remove magic numbers from pco_contains_proto() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osm

Change in osmo-ttcn3-hacks[master]: ggsn: Verify that there are no duplicate PCO protocolIDs

2019-04-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13563 to look at the new patch set (#3). Change subject: ggsn: Verify that there are no duplicate PCO protocolIDs .. ggsn:

Change in osmo-ggsn[master]: ggsn: Remove magic numbers from pco_contains_proto()

2019-04-11 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13567 ) Change subject: ggsn: Remove magic numbers from pco_contains_proto() .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13567/1/ggs

Change in osmo-ggsn[master]: process_pco() const-ify 'apn' argument

2019-04-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13566 ) Change subject: process_pco() const-ify 'apn' argument .. process_pco() const-ify 'apn' argument Change-Id: I2a96b0fbe077c7c49342553

Change in osmo-ggsn[master]: ggsn: Fix build_ipcp_pco() in presence of invalid IPCP content

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13570 ) Change subject: ggsn: Fix build_ipcp_pco() in presence of invalid IPCP content .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#

Change in osmo-ggsn[master]: ggsn: Remove magic numbers from ipcp_contains_option()

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13569 ) Change subject: ggsn: Remove magic numbers from ipcp_contains_option() .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13569

Change in osmo-ggsn[master]: ggsn: const-ify input / read-only arguments of PCO related functions

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13568 ) Change subject: ggsn: const-ify input / read-only arguments of PCO related functions .. Patch Set 1: Code-Review+2 -- To view, visit h

Change in osmo-ggsn[master]: ggsn: Remove magic numbers from pco_contains_proto()

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13567 ) Change subject: ggsn: Remove magic numbers from pco_contains_proto() .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13567/1

Change in osmo-ggsn[master]: process_pco() const-ify 'apn' argument

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13566 ) Change subject: process_pco() const-ify 'apn' argument .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13566

Change in osmo-ggsn[master]: ggsn.c: Refactor PCO processing during PDP activation

2019-04-11 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13606 Change subject: ggsn.c: Refactor PCO processing during PDP activation .. ggsn.c: Refactor PCO processing during PDP activation The existing P

Change in osmo-hlr[master]: hlr.c: forward GSUP messages between clients

2019-04-11 Thread osmith
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13006 to look at the new patch set (#10). Change subject: hlr.c: forward GSUP messages between clients .. hl

Change in osmo-ttcn3-hacks[master]: ggsn: Verify that there are no duplicate PCO protocolIDs

2019-04-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13563 to look at the new patch set (#2). Change subject: ggsn: Verify that there are no duplicate PCO protocolIDs .. ggsn:

Change in osmo-hlr[master]: hlr.c: forward GSUP messages between clients

2019-04-11 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13006 ) Change subject: hlr.c: forward GSUP messages between clients .. Patch Set 8: (3 comments) https://gerrit.osmocom.org/#/c/13006/8/src/hlr.c File sr

Change in osmo-hlr[master]: hlr.c: forward GSUP messages between clients

2019-04-11 Thread osmith
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13006 to look at the new patch set (#9). Change subject: hlr.c: forward GSUP messages between clients .. hlr

Change in osmo-ci[master]: nightly-packages: Build latest tag of limesuite

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13605 Change subject: nightly-packages: Build latest tag of limesuite .. nightly-packages: Build latest tag of limesuite Like we actually do al

Change in osmo-ci[master]: nightly-packages: Remove unused variable

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13603 Change subject: nightly-packages: Remove unused variable .. nightly-packages: Remove unused variable Change-Id: Ic120dbc134cba9bd77098ab1

Change in osmo-ci[master]: nightly-packages: Move some code and rename some vars to look similar...

2019-04-11 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13604 Change subject: nightly-packages: Move some code and rename some vars to look similar to latest-packages .. nightly-packages: Move some c

  1   2   >