Patch Set 2:
while I think that we should never use NULL contexts anywhere, this might be a
good help in catching NULL-ctx allocations.
so yes, let's enable null tracking everywhere?
Related: I have a patch pending to get osmocom logging out of the NULL ctx ...
not submitted yet
Patch Set 2: Code-Review+1
(1 comment)
where is the jenkins.sh change to go along with this, in osmo-ci? mention
change-id in the commit log.
https://gerrit.osmocom.org/#/c/7275/2/example/resources.conf.prod
File example/resources.conf.prod:
Line 45: net_device: enp2s0
keeping the
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7274
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I20f9e8d97775293925205e4ea576d814214bf1a8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7272
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I054db78e6a71514133e4e3c3158342b74af44201
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 2:
(1 comment)
> (1 comment)
>
> where is the jenkins.sh change to go along with this, in osmo-ci?
> mention change-id in the commit log.
Well the commits to osmo-ci to add the yml jenkins jobs are still in gerrit
waiting for lynxis to rewrite them after some commetns from you
Review at https://gerrit.osmocom.org/7276
restore sending of optional MM info messages
Since commit 2483f1b050496eda7f8707327204251c57212906 the function
gsm48_tx_mm_info() was not called anymore. No MM info messages were
transmitted to phones even if MM info messages were enabled via VTY.
Patch Set 3: Code-Review+2
(4 comments)
this is just peanuts comments, feel free to decide yourself
https://gerrit.osmocom.org/#/c/7167/3/src/osmo_gsm_tester/powersupply.py
File src/osmo_gsm_tester/powersupply.py:
Line 23: class PowerSupply(log.Origin, metaclass=ABCMeta):
what's the rationale
Patch Set 3: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/#/c/7160/3/src/osmo_gsm_tester/bts.py
File src/osmo_gsm_tester/bts.py:
Line 26: class Bts(log.Origin, metaclass=ABCMeta):
could you explain ABCMeta? What does it help us with?
Line 45: # PUBLIC - INTERNAL API
what now, public
Patch Set 3:
(4 comments)
https://gerrit.osmocom.org/#/c/7167/3/src/osmo_gsm_tester/powersupply.py
File src/osmo_gsm_tester/powersupply.py:
Line 23: class PowerSupply(log.Origin, metaclass=ABCMeta):
> what's the rationale for the meta class to inherit from? It's enough to jus
It makes it
Patch Set 3: Code-Review+1
(1 comment)
I'd say this commit is small enough to be joined with the commit that is
actually using it.
https://gerrit.osmocom.org/#/c/7166/3/src/osmo_gsm_tester/pcu.py
File src/osmo_gsm_tester/pcu.py:
Line 51: ###
...so many lines wasted by
Patch Set 3: Code-Review+1
(1 comment)
if you must, but...
https://gerrit.osmocom.org/#/c/7159/3/src/osmo_gsm_tester/bts_osmo.py
File src/osmo_gsm_tester/bts_osmo.py:
Line 80: def ready_for_pcu(self):
from a python doc point of view, nothing has changed at all. If a function is
Patch Set 3: Code-Review+1
(1 comment)
same cosmetic difference in opinion...
https://gerrit.osmocom.org/#/c/7158/3/src/osmo_gsm_tester/pcu.py
File src/osmo_gsm_tester/pcu.py:
Line 30: ##
don't see why this comment. I'm allowed to instantiate a Pcu class and use it
as I might, am
Harald Welte has submitted this change and it was merged.
Change subject: vlr_ciph_result: fix use after free of imeisv
..
vlr_ciph_result: fix use after free of imeisv
Define the struct vlr_ciph_result member .imeisv not as a
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7264
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90cfb952a7dec6d104200872164ebadb25d0260d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+1
Great finding!
--
To view, visit https://gerrit.osmocom.org/7264
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90cfb952a7dec6d104200872164ebadb25d0260d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Patch Set 1:
I would like to see a separate patch for the L1CTL change:
diff --git a/include/l1ctl_proto.h b/include/l1ctl_proto.h
index 17065349..9d548bc4 100644
--- a/include/l1ctl_proto.h
+++ b/include/l1ctl_proto.h
@@ -281,6 +281,7 @@ struct l1ctl_dm_freq_req {
struct l1ctl_crypto_req {
Review at https://gerrit.osmocom.org/7265
configure.ac: add --enable-track-null option
This option allows one to enable tracking the use of talloc NULL
memory contexts. Useful when you want to observe not only the
application root context, but also other contexts, e.g. not
exposed by
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7260
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69ee2de921979f8bfaa8b501c6b05db1717b0c36
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review-1
I also see some changes to common/l1ctl.c. Let's merge those independent of
the branch/merge. Basically, I would like to see all changes to existing code
as separate commits, and the merge should then just contain trxcon + fake_trx
--
To view, visit
Patch Set 1:
I'm inclined to merge this but:
* why not always enable NULL tracking in all osmocom programs?
* why not fix the code to not make NULL context allocations?
--
To view, visit https://gerrit.osmocom.org/7265
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7262
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8071aaf2be217207261ad698f87344f7ca15ccc4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: ipaccess-config: Add missing path with log error
..
ipaccess-config: Add missing path with log error
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: ipaccess-config: Improve handling of last parameter
..
ipaccess-config: Improve handling of last parameter
Check exact number of parameters to avoid
Harald Welte has submitted this change and it was merged.
Change subject: ipaccess-config: Enable logging all categories to print errors
..
ipaccess-config: Enable logging all categories to print errors
log_parse_category_mask
Review at https://gerrit.osmocom.org/7266
remove *.default from [EXECUTE] in *.default files
The problem is that the .cfg file cannot override the [EXECUTE]
provided list of tests
Change-Id: I7e1e0499b3b32014b25ae4b515263f57a4ea6daf
---
M bsc/BSC_Tests.cfg
M bsc/BSC_Tests.default
M
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7266
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e1e0499b3b32014b25ae4b515263f57a4ea6daf
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: remove *.default from [EXECUTE] in *.default files
..
remove *.default from [EXECUTE] in *.default files
The problem is that the .cfg file cannot
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7265
to look at the new patch set (#2).
common/main.c: track talloc NULL contexts by default
In order to be able to introspect not only the root application
context, but also all other
Patch Set 16:
(2 comments)
https://gerrit.osmocom.org/#/c/6509/16/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:
Line 705: if (decode_lai([lai_offset], >lai.plmn.mcc,
>lai.plmn.mnc, >lai.lac) != 0)
> error here: lai_offset is unset in the first loop, and uses the value of
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7148
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81bb4251d18fce978d27849b621b20f541caab0b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Makefile.am: Avoid using subdir if arch is not required
..
Makefile.am: Avoid using subdir if arch is not required
There's no need in going a level
Harald Welte has submitted this change and it was merged.
Change subject: Build Transceiver52M/common as an .la lib
..
Build Transceiver52M/common as an .la lib
Stop picking files from that directory on different places as it
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#17).
support for more cell ID list types in libosmocore
Introduce gsm0808_dec_cell_id_list2() with supports additional types
Patch Set 1:
Hi Harald,
> * why not always enable NULL tracking in all osmocom programs?
I thought that this could slowdown the program somehow, but after
looking at the source code of talloc, I can say that this doesn't
affect performance. Good idea.
> * why not fix the code to not make NULL
Review at https://gerrit.osmocom.org/7268
restore sending of optional MM info messages
Since commit 2483f1b050496eda7f8707327204251c57212906 the function
gsm48_tx_mm_info() was not called anymore. No MM info messages were
transmitted to phones even if MM info messages were enabled via VTY.
Patch Set 1: Code-Review-1
not sure if this works, just want to see -Werror build results on jenkins
--
To view, visit https://gerrit.osmocom.org/7267
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: jenkins.sh: add --enable-werror to configure flags
..
jenkins.sh: add --enable-werror to configure flags
Change-Id:
Patch Set 1: Code-Review+2
switching on strict -Werror builds on osmo-mgw.
--
To view, visit https://gerrit.osmocom.org/7269
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3af8d0fe9247c22d57dbe70fc80a58ee7297f75
Gerrit-PatchSet: 1
Review at https://gerrit.osmocom.org/7270
bts: Verify the PCU protocol interface version
Change-Id: If2033720a38879cd2f4c4f8d3fe3fed1468da3cb
---
M bts/BTS_Tests.ttcn
M library/PCUIF_Types.ttcn
2 files changed, 50 insertions(+), 5 deletions(-)
git pull
Review at https://gerrit.osmocom.org/7267
jenkins: enable -Werror everywhere
Change-Id: I6b6e11d1b10e3940488404074e1e9347a90e88a5
---
M contrib/jenkins_bts_trx.sh
M contrib/jenkins_lc15.sh
M contrib/jenkins_oct.sh
M contrib/jenkins_oct_and_bts_trx.sh
M contrib/jenkins_sysmobts.sh
5 files
Stefan Sperling has submitted this change and it was merged.
Change subject: support for more cell ID list types in libosmocore
..
support for more cell ID list types in libosmocore
Introduce gsm0808_dec_cell_id_list2() with
Harald Welte has submitted this change and it was merged.
Change subject: Track libosmocore API change in osmo-msc.
..
Track libosmocore API change in osmo-msc.
struct gsm0808_cell_id_list in libosmocore is deprecated by
Patch Set 17: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/6509/17/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:
Line 699: const size_t elemlen = sizeof(struct gsm48_loc_area_id) +
sizeof(*ci_be);
how about "emellen" ;) lol
--
To view, visit
Review at https://gerrit.osmocom.org/7269
jenkins.sh: add --enable-werror to configure flags
Change-Id: If3af8d0fe9247c22d57dbe70fc80a58ee7297f75
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/69/7269/1
Patch Set 1:
as stated in the redmine issue: What about open networks that don't do
authentication (e.g. because they don't issue their own sims and don't have the
private key data)?
I have outlined very specifically when I believe it should be sent, please try
to implement that.
--
To
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.osmocom.org/7268
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc413956595588e0832dad2d758de1db8dd5529d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7168
to look at the new patch set (#3).
WIP: Introduce ip.access nanobts support
Change-Id: Ibaea025b3a503dfe897d36701234445de6d49f82
---
M example/defaults.conf
M
Review at https://gerrit.osmocom.org/7271
PCUIF_Types: Upgrade to PCU interface v9
Change-Id: If024bbe51d91666fcfe9d3458d85ff269c327a7c
---
M library/PCUIF_Types.ttcn
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7271
to look at the new patch set (#2).
PCUIF_Types: Upgrade to PCU interface v9
Change-Id: If024bbe51d91666fcfe9d3458d85ff269c327a7c
---
M library/PCUIF_Types.ttcn
1 file changed, 3
Review at https://gerrit.osmocom.org/7272
default-suites.conf: Add nanobts related tests
Change-Id: I054db78e6a71514133e4e3c3158342b74af44201
---
M example/default-suites.conf
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
default-suites.conf: Add nanobts related tests
Change-Id: I054db78e6a71514133e4e3c3158342b74af44201
---
M example/default-suites.conf
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/72/7272/2
diff --git
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7168
to look at the new patch set (#4).
Introduce ip.access nanobts support
Change-Id: Ibaea025b3a503dfe897d36701234445de6d49f82
---
M example/defaults.conf
M
Review at https://gerrit.osmocom.org/7273
trans_free: safeguard against a still running CC timer on free
Make sure to deactivate trans.cc.timer when freeing a CC transaction.
Log an error if should be necessary.
This prevents a segfault when we receive a BSSMAP Clear Request from BSC during
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7271
to look at the new patch set (#3).
PCUIF_Types: Upgrade to PCU interface v9
Change-Id: If024bbe51d91666fcfe9d3458d85ff269c327a7c
---
M library/PCUIF_Types.ttcn
1 file changed, 4
Patch Set 4: Code-Review+1
(8 comments)
mainly good, with a few questions...
https://gerrit.osmocom.org/#/c/7168/4/src/osmo_gsm_tester/bts_nanobts.py
File src/osmo_gsm_tester/bts_nanobts.py:
Line 36: if conf.get('addr', None) is None:
conf.get('addr') is identical to passing None
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/7198/1/.gitignore
File .gitignore:
Line 10: M3UA_CNL113537/src/src
> those src/src shouldn't be created in the first place. please fix the scrip
k, didn't know about that, will try
Line 13: bsc-nat/BSSAP_CodecPort.ttcn
> as stated
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/7199/1/.gitignore
File .gitignore:
Line 620: bsc-nat/BSC_MS_ConnectionHandler.cc
> If you want to have gitignore (I'm still not convinced), then the best appr
I absolutely need gitignore, because I use git status all the time (what branch
Review at https://gerrit.osmocom.org/7274
modem: get IMSI from ofono
There's no need to specify the IMSI manually in resource config
and it's also prone to errors. Let's take it from ofono.
Add a 'sim' feature to allow modem to auto-discover it,
otherwise if not supported leave that feature
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7265
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e9381902dace7dfd37f98b657e4697b5afcff96
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: common/main.c: track talloc NULL contexts by default
..
common/main.c: track talloc NULL contexts by default
In order to be able to introspect not only
Harald Welte has submitted this change and it was merged.
Change subject: bts: Verify the PCU protocol interface version
..
bts: Verify the PCU protocol interface version
Change-Id: If2033720a38879cd2f4c4f8d3fe3fed1468da3cb
Harald Welte has submitted this change and it was merged.
Change subject: PCUIF_Types: Upgrade to PCU interface v9
..
PCUIF_Types: Upgrade to PCU interface v9
Change-Id: If024bbe51d91666fcfe9d3458d85ff269c327a7c
---
M
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7271
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If024bbe51d91666fcfe9d3458d85ff269c327a7c
Gerrit-PatchSet: 3
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7270
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2033720a38879cd2f4c4f8d3fe3fed1468da3cb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1:
I don't know why one would run git status all the time. I probably use it once
to twice per week, and whether I tyoe "../rmlinks.sh && git status" or "git
status" hardly makes any difference. Takes like 3 seconds more.
I also really don't think it's worth spending time
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7276
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice5963d84253eb8c803cd2dfa8b25a4db5382827
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: restore sending of optional MM info messages
..
restore sending of optional MM info messages
Since commit 2483f1b050496eda7f8707327204251c57212906 the
Review at https://gerrit.osmocom.org/7275
example: Maintain different resources.conf for RnD and prod
We still want to maintain this file in the same osmo-gsm-tester repo
because we frequently neef to update the config when adding new
features.
Until now only 1 file was maintained (which was
example: Maintain different resources.conf for RnD and prod
We still want to maintain this file in the same osmo-gsm-tester repo
because we frequently neef to update the config when adding new
features.
Until now only 1 file was maintained (which was used for RnD setup), and
then when runnin in
Stefan Sperling has abandoned this change.
Change subject: restore sending of optional MM info messages
..
Abandoned
As explained by Harald, we will need a different approach.
--
To view, visit
70 matches
Mail list logo
