Change in osmo-msc[master]: vty: add command to show all known BSC

2018-11-13 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11711 ) Change subject: vty: add command to show all known BSC .. Patch Set 1: Somewhat related is gerrit 11746 which saves CI which we could print as well

Change in osmo-sgsn[master]: fix bogus error check in gprs_sndcp_comp_create()

2018-11-13 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11730 ) Change subject: fix bogus error check in gprs_sndcp_comp_create() .. Patch Set 1: (1 comment)

Change in osmo-dev[master]: gits: use @{u} to get upstream branch, not origin/%s

2018-11-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11756 ) Change subject: gits: use @{u} to get upstream branch, not origin/%s .. Patch Set 1: (1 comment) Nice! besides catching the git stderr this looks

Change in osmo-ttcn3-hacks[master]: MSC_Tests: remove unused control interface

2018-11-13 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/11690 ) Change subject: MSC_Tests: remove unused control interface .. Patch Set 2: > Then the test startup should be able to decide which handler has a >

Change in osmo-dev[master]: gits: fix git_can_fast_forward: use arg instead of HEAD

2018-11-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11755 ) Change subject: gits: fix git_can_fast_forward: use arg instead of HEAD .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-dev[master]: gitignore: update src/ whitelist

2018-11-13 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11759 Change subject: gitignore: update src/ whitelist .. gitignore: update src/ whitelist gits has replaced most shell scripts from src. Add gits and

Change in osmo-dev[master]: gitignore: add make/ and net/ (with exceptions)

2018-11-13 Thread osmith
Hello Neels Hofmeyr, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11741 to look at the new patch set (#2). Change subject: gitignore: add make/ and net/ (with exceptions) .. gitignore: add

Change in osmo-ttcn3-hacks[master]: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover

2018-11-13 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/11733 ) Change subject: BSC_Tests: expect a HANDOVER PERFORMED message on internal handover .. Patch Set 1: > (1 comment) 3GPP TS 48.008 says 3.2.1.25

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-dev[master]: gitignore: add make/ and net/ (with exceptions)

2018-11-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11741 ) Change subject: gitignore: add make/ and net/ (with exceptions) .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/11741/1/.gitignore

Change in osmo-bsc[master]: fix: send RR Release (e.g. after BSSMAP Clear Cmd)

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11664 ) Change subject: fix: send RR Release (e.g. after BSSMAP Clear Cmd) .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-bsc[master]: abis_rsl.c: drop unused enum sacch_deact

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11665 ) Change subject: abis_rsl.c: drop unused enum sacch_deact .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: vlr: drop unused is_ps parameter in vlr_subscr_req_lu()

2018-11-13 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/11761 Change subject: vlr: drop unused is_ps parameter in vlr_subscr_req_lu() .. vlr: drop unused is_ps parameter in vlr_subscr_req_lu() the function

Change in osmo-msc[master]: vlr: use unused is_ps parameter in vlr_subscr_req_lu()

2018-11-13 Thread dexter
dexter has abandoned this change. ( https://gerrit.osmocom.org/11563 ) Change subject: vlr: use unused is_ps parameter in vlr_subscr_req_lu() .. Abandoned Abandonned in favor of a different approach:

Change in osmo-msc[master]: move project specific manuals to their own repos

2018-11-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11726 ) Change subject: move project specific manuals to their own repos .. Patch Set 1: (2 comments) > I associate 'man' with the unix manpages. IIUC we

Change in osmo-bsc[master]: gsm0408_rcvmsg: Release lchan if L3 fails to complete

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11606 ) Change subject: gsm0408_rcvmsg: Release lchan if L3 fails to complete .. Patch Set 2: (1 comment)

Change in osmo-msc[master]: vlr: drop unused is_ps parameter in vlr_subscr_req_lu()

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11761 ) Change subject: vlr: drop unused is_ps parameter in vlr_subscr_req_lu() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-dev[master]: gits: when asking for reset --hard, also offer push -f

2018-11-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11758 ) Change subject: gits: when asking for reset --hard, also offer push -f .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-sgsn[master]: fix bogus error check in gprs_sndcp_comp_create()

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11730 ) Change subject: fix bogus error check in gprs_sndcp_comp_create() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 2: (4 comments)

Change in osmo-bsc[master]: lchan: release in error: fix missing messages / events

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11666 ) Change subject: lchan: release in error: fix missing messages / events .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-gsm-manuals[master]: Makefile.asciidoc.inc: make clean: also rm *.html

2018-11-13 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/11723 ) Change subject: Makefile.asciidoc.inc: make clean: also rm *.html .. Makefile.asciidoc.inc: make clean: also rm *.html HTML files get

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. Patch Set 1: > In that case the best would be to store the date into the

Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

2018-11-13 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/11728 ) Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED .. Patch Set 1: (2 comments) > (2 comments) (making sure all

Change in osmo-gsm-tester[master]: templates: osmo-pcu: Set log level from dbg to info

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11760 ) Change subject: templates: osmo-pcu: Set log level from dbg to info .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: templates: osmo-pcu: Set log level from dbg to info

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11760 ) Change subject: templates: osmo-pcu: Set log level from dbg to info .. templates: osmo-pcu: Set log level from dbg to info

Change in osmo-bsc[master]: lchan release: always Deact SACCH

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11667 ) Change subject: lchan release: always Deact SACCH .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11667 To

Change in osmo-bsc[master]: cosmetic: lchan: introduce sub-struct lchan->release.*

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11668 ) Change subject: cosmetic: lchan: introduce sub-struct lchan->release.* .. Patch Set 1: (3 comments)

Change in osmo-bsc[master]: cosmetic: abis_rsl.c: drop uneccesary braces

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11669 ) Change subject: cosmetic: abis_rsl.c: drop uneccesary braces .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: lchan: set cause for 4 instances of release_in_error = true

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11670 ) Change subject: lchan: set cause for 4 instances of release_in_error = true .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-gsm-tester[master]: process: launch_sync: allow non success return

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11748 ) Change subject: process: launch_sync: allow non success return .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: nanobts: ipacces-config: Use process.launch_sync helper

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11749 ) Change subject: nanobts: ipacces-config: Use process.launch_sync helper .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: templates: osmo-pcu: Set log level from dbg to info

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11760 Change subject: templates: osmo-pcu: Set log level from dbg to info .. templates: osmo-pcu: Set log level from dbg to info Otherwise

Change in osmo-gsm-tester[master]: nanobts: ipacces-config: Use process.launch_sync helper

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11749 ) Change subject: nanobts: ipacces-config: Use process.launch_sync helper .. nanobts: ipacces-config: Use process.launch_sync

Change in osmo-bsc[master]: handover_fsm: send HANDOVER PERFORMED msg on internal ho

2018-11-13 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/11734 ) Change subject: handover_fsm: send HANDOVER PERFORMED msg on internal ho .. Patch Set 1: (3 comments) > (1 comment) See 3GPP TS 48.008,

Change in osmo-dev[master]: gits: remove code dup: ask_reset_hard()

2018-11-13 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11757 ) Change subject: gits: remove code dup: ask_reset_hard() .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11757/1/src/gits File

Change in osmo-bsc[master]: gsm0408_rcvmsg: Release lchan if L3 fails to complete

2018-11-13 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11606 ) Change subject: gsm0408_rcvmsg: Release lchan if L3 fails to complete .. Patch Set 2: Code-Review-1 (1 comment)

Change in osmo-gsm-tester[master]: process: Move standalone run_local_sync as method of Process

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11747 ) Change subject: process: Move standalone run_local_sync as method of Process .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-tester[master]: process: launch_sync: allow non success return

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11748 ) Change subject: process: launch_sync: allow non success return .. process: launch_sync: allow non success return Change-Id:

Change in osmo-gsm-tester[master]: process: Move standalone run_local_sync as method of Process

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11747 ) Change subject: process: Move standalone run_local_sync as method of Process .. process: Move standalone run_local_sync as

Change in osmo-gsm-manuals[master]: Makefile: move dep-check code to check-depends.sh

2018-11-13 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/11737 ) Change subject: Makefile: move dep-check code to check-depends.sh .. Makefile: move dep-check code to check-depends.sh Make it possible

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler: introduce ctrl interface

2018-11-13 Thread dexter
Hello daniel, Max, Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11697 to look at the new patch set (#5). Change subject: BSC_ConnectionHandler: introduce ctrl interface

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler: make VTY interface available

2018-11-13 Thread dexter
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11701 to look at the new patch set (#3). Change subject: BSC_ConnectionHandler: make VTY interface available

Change in osmo-gsm-manuals[master]: unix-time-to-fmt.py: fix crash without argument

2018-11-13 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/11724 ) Change subject: unix-time-to-fmt.py: fix crash without argument .. unix-time-to-fmt.py: fix crash without argument Print "unknown" to

Change in osmo-gsm-manuals[master]: merge_doc.xsl: move from libosmocore.git

2018-11-13 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/11736 ) Change subject: merge_doc.xsl: move from libosmocore.git .. merge_doc.xsl: move from libosmocore.git Allow building manuals without the

Change in libosmocore[master]: merge_doc.xsl: move to osmo-gsm-manuals.git

2018-11-13 Thread osmith
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/11739 ) Change subject: merge_doc.xsl: move to osmo-gsm-manuals.git .. merge_doc.xsl: move to osmo-gsm-manuals.git Allows building the manuals

Change in osmo-bsc[master]: show dynamic timeslot details in 'show timeslot' vty command

2018-11-13 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11762 Change subject: show dynamic timeslot details in 'show timeslot' vty command .. show dynamic timeslot details in 'show timeslot' vty

Change in osmo-ttcn3-hacks[master]: attempt to fix a race condition in BSC test's f_ts_dyn_mode_get

2018-11-13 Thread Stefan Sperling
Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11763 Change subject: attempt to fix a race condition in BSC test's f_ts_dyn_mode_get .. attempt to fix a race condition in BSC test's

Change in osmo-bsc[master]: show dynamic timeslot details in 'show timeslot' vty command

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11762 ) Change subject: show dynamic timeslot details in 'show timeslot' vty command .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-gsm-manuals[master]: Makefile.common.inc: add publish target

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11740 ) Change subject: Makefile.common.inc: add publish target .. Patch Set 1: Code-Review+1 > I'm confused, don't we already publish the manuals

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler: introduce ctrl interface

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11697 ) Change subject: BSC_ConnectionHandler: introduce ctrl interface .. Patch Set 5: Code-Review+2 -- To view, visit

Build failed in Jenkins: master-asn1c ยป a1=default,a2=default,a3=default,osmocom-master-debian9 #306

2018-11-13 Thread jenkins
See -- [...truncated 3.67 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host

Change in osmo-ttcn3-hacks[master]: bsc: handle RR Release messages

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11660 ) Change subject: bsc: handle RR Release messages .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11660 To

Change in osmo-ttcn3-hacks[master]: bsc: check channel release message presence

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11662 ) Change subject: bsc: check channel release message presence .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: cosmetic: abis_rsl.c: drop uneccesary braces

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11669 ) Change subject: cosmetic: abis_rsl.c: drop uneccesary braces .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bts[master]: osmo-bts-trx: print TRX socket addresses in 'show transceiver'

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11764 ) Change subject: osmo-bts-trx: print TRX socket addresses in 'show transceiver' .. Patch Set 1: Code-Review-1 (1 comment)

Change in osmo-bsc[master]: lchan: set cause for 4 instances of release_in_error = true

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11670 ) Change subject: lchan: set cause for 4 instances of release_in_error = true .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: vty: add command to show all known BSC

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11711 ) Change subject: vty: add command to show all known BSC .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11711 To

Change in osmo-bsc[master]: lchan release: always Deact SACCH

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11667 ) Change subject: lchan release: always Deact SACCH .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11667 To

Change in osmo-ttcn3-hacks[master]: bsc: TC_chan_act_ack_est_ind_noreply: use f_expect_chan_rel

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11659 ) Change subject: bsc: TC_chan_act_ack_est_ind_noreply: use f_expect_chan_rel .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: bsc: handle Deact SACCH messages

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11661 ) Change subject: bsc: handle Deact SACCH messages .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11661 To

Change in osmo-bsc[master]: fix: send RR Release (e.g. after BSSMAP Clear Cmd)

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11664 ) Change subject: fix: send RR Release (e.g. after BSSMAP Clear Cmd) .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: lchan: release in error: fix missing messages / events

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11666 ) Change subject: lchan: release in error: fix missing messages / events .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: abis_rsl.c: drop unused enum sacch_deact

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11665 ) Change subject: abis_rsl.c: drop unused enum sacch_deact .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11665

Change in osmo-msc[master]: vty: add command to show all known BSC

2018-11-13 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11711 ) Change subject: vty: add command to show all known BSC .. vty: add command to show all known BSC Change-Id:

Change in osmo-ttcn3-hacks[master]: attempt to fix a race condition in BSC test's f_ts_dyn_mode_get

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11763 ) Change subject: attempt to fix a race condition in BSC test's f_ts_dyn_mode_get .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: move project specific manuals to their own repos

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11726 ) Change subject: move project specific manuals to their own repos .. Patch Set 1: I agree that 'man' is a bad naming choice. Call it

Change in osmo-ttcn3-hacks[master]: bsc: remove flush from f_expect_chan_rel

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11658 ) Change subject: bsc: remove flush from f_expect_chan_rel .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11658

Change in osmo-sgsn[master]: fix bogus error check in gprs_sndcp_comp_create()

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11730 ) Change subject: fix bogus error check in gprs_sndcp_comp_create() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-bts[master]: osmo-bts-trx: print TRX socket addresses in 'show transceiver'

2018-11-13 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11764 Change subject: osmo-bts-trx: print TRX socket addresses in 'show transceiver' .. osmo-bts-trx: print TRX socket addresses in 'show transceiver'

Change in osmo-bsc[master]: show dynamic timeslot details in 'show timeslot' vty command

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11762 ) Change subject: show dynamic timeslot details in 'show timeslot' vty command .. Patch Set 1: I think you should be able to see the

Change in osmo-sgsn[master]: use enums consistently instead of falling back to int

2018-11-13 Thread Stefan Sperling
Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11656 ) Change subject: use enums consistently instead of falling back to int .. Patch Set 2: I have confirmed that TTCN3 SGSN test results are

Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler: make VTY interface available

2018-11-13 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11701 ) Change subject: BSC_ConnectionHandler: make VTY interface available .. Patch Set 3: Code-Review-1 (1 comment)

Change in osmo-bts[master]: bts-trx: trx_if: Use struct to store CTRL msg parsed responses

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11765 Change subject: bts-trx: trx_if: Use struct to store CTRL msg parsed responses .. bts-trx: trx_if: Use struct to store CTRL msg parsed

Change in osmo-bts[master]: common: Implement OML for trx_set_available(1)

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11767 Change subject: common: Implement OML for trx_set_available(1) .. common: Implement OML for trx_set_available(1) Related: OS#3692

Change in osmo-bts[master]: bts-trx: setup timer once at creation time

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11766 Change subject: bts-trx: setup timer once at creation time .. bts-trx: setup timer once at creation time Change-Id:

Change in osmo-bts[master]: bts-trx: Allow re-try without exit if POWERON fails in osmo-trx

2018-11-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11768 Change subject: bts-trx: Allow re-try without exit if POWERON fails in osmo-trx .. bts-trx: Allow re-try without exit if POWERON fails in

Change in osmo-bts[master]: bts-trx: trx_if: Use struct to store CTRL msg parsed responses

2018-11-13 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11765 ) Change subject: bts-trx: trx_if: Use struct to store CTRL msg parsed responses .. Patch Set 1: (1 comment)