[
https://issues.apache.org/jira/browse/GIRAPH-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115239#comment-13115239
]
Avery Ching commented on GIRAPH-12:
---
Are hadoop metrics better than simply using Runtime?
[
https://issues.apache.org/jira/browse/GIRAPH-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13116259#comment-13116259
]
Avery Ching commented on GIRAPH-12:
---
I wonder if Runtime methods measure the stack sizes
[
https://issues.apache.org/jira/browse/GIRAPH-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117011#comment-13117011
]
Avery Ching commented on GIRAPH-12:
---
If the default stack size is 1 MB, then for instance
[
https://issues.apache.org/jira/browse/GIRAPH-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117569#comment-13117569
]
Avery Ching commented on GIRAPH-10:
---
This is definitely an open question here. Here's a
[
https://issues.apache.org/jira/browse/GIRAPH-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117891#comment-13117891
]
Avery Ching commented on GIRAPH-43:
---
Yeah, this kind of sucks. One thing we could do is
[
https://issues.apache.org/jira/browse/GIRAPH-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123304#comment-13123304
]
Avery Ching commented on GIRAPH-49:
---
This would be nice. Not sure about fb, since it's
[
https://issues.apache.org/jira/browse/GIRAPH-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123935#comment-13123935
]
Avery Ching commented on GIRAPH-48:
---
Yeah, Eclipse automatically does that. The main
[
https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13125217#comment-13125217
]
Avery Ching commented on GIRAPH-47:
---
I was thinking about the later approach that you
[
https://issues.apache.org/jira/browse/GIRAPH-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13127169#comment-13127169
]
Avery Ching commented on GIRAPH-52:
---
Here's a related issue
[
https://issues.apache.org/jira/browse/GIRAPH-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13127626#comment-13127626
]
Avery Ching commented on GIRAPH-53:
---
Thanks for reporting the issue. A few questions:
[
https://issues.apache.org/jira/browse/GIRAPH-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13127702#comment-13127702
]
Avery Ching commented on GIRAPH-53:
---
Also, I wonder if it's related to the counter
[
https://issues.apache.org/jira/browse/GIRAPH-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13129063#comment-13129063
]
Avery Ching commented on GIRAPH-58:
---
+1. Looks good to me. =) You'll need to follow the
[
https://issues.apache.org/jira/browse/GIRAPH-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134723#comment-13134723
]
Avery Ching commented on GIRAPH-53:
---
No, the map tasks are held for the duration of the
[
https://issues.apache.org/jira/browse/GIRAPH-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13136402#comment-13136402
]
Avery Ching commented on GIRAPH-66:
---
Actually, let me add it to slideshare and do it that
[
https://issues.apache.org/jira/browse/GIRAPH-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13136428#comment-13136428
]
Avery Ching commented on GIRAPH-66:
---
+1 on your patch.
I totally misunderstood what
[
https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139871#comment-13139871
]
Avery Ching commented on GIRAPH-36:
---
Tried out your stuff Jake. Unittests passed for me.
[
https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140279#comment-13140279
]
Avery Ching commented on GIRAPH-36:
---
Jake,
Your suggestion on 1) will work, but couldn't
[
https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140974#comment-13140974
]
Avery Ching commented on GIRAPH-36:
---
Regarding 1) I think it would be safer for use to
[
https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141573#comment-13141573
]
Avery Ching commented on GIRAPH-36:
---
Since this is a somewhat large change, can you also
[
https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141965#comment-13141965
]
Avery Ching commented on GIRAPH-36:
---
+1.
Jake, just re-ran with your new patch. Passed
[
https://issues.apache.org/jira/browse/GIRAPH-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142870#comment-13142870
]
Avery Ching commented on GIRAPH-72:
---
Ah, you can set the base rpc port by the way, sorry
[
https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13144735#comment-13144735
]
Avery Ching commented on GIRAPH-47:
---
I agree with the proxy approach of WorkerContext so
[
https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13145694#comment-13145694
]
Avery Ching commented on GIRAPH-47:
---
Sorry, Claudio, my bad. I still had remnants of
[
https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13145868#comment-13145868
]
Avery Ching commented on GIRAPH-47:
---
+1
Thanks Claudio. I'm going to commit on your
[
https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13145879#comment-13145879
]
Avery Ching commented on GIRAPH-47:
---
I filed issue
[
https://issues.apache.org/jira/browse/GIRAPH-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147226#comment-13147226
]
Avery Ching commented on GIRAPH-11:
---
I started it so long ago that the merge was brutal
[
https://issues.apache.org/jira/browse/GIRAPH-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147913#comment-13147913
]
Avery Ching commented on GIRAPH-73:
---
Hi Sebastian,
Thanks for the refactoring and for
[
https://issues.apache.org/jira/browse/GIRAPH-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147975#comment-13147975
]
Avery Ching commented on GIRAPH-74:
---
Well, if you vote to halt, your compute() is never
[
https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149876#comment-13149876
]
Avery Ching commented on GIRAPH-80:
---
Since
public abstract void compute(IteratorM
[
https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149891#comment-13149891
]
Avery Ching commented on GIRAPH-80:
---
Seems reasonable to me. Having the option of
[
https://issues.apache.org/jira/browse/GIRAPH-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150663#comment-13150663
]
Avery Ching commented on GIRAPH-74:
---
Claudio, are you synced to svn? The commit of
[
https://issues.apache.org/jira/browse/GIRAPH-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150668#comment-13150668
]
Avery Ching commented on GIRAPH-61:
---
Currently, the master knows whenever an active
[
https://issues.apache.org/jira/browse/GIRAPH-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150673#comment-13150673
]
Avery Ching commented on GIRAPH-78:
---
+1, this would be a great memory optimization.
[
https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150864#comment-13150864
]
Avery Ching commented on GIRAPH-45:
---
It's going to be a bit complicated to store the
[
https://issues.apache.org/jira/browse/GIRAPH-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150867#comment-13150867
]
Avery Ching commented on GIRAPH-83:
---
While you can decouple everything from vertex, I
[
https://issues.apache.org/jira/browse/GIRAPH-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151405#comment-13151405
]
Avery Ching commented on GIRAPH-68:
---
Looks good Hyunsik, a few comments.
Probably want
[
https://issues.apache.org/jira/browse/GIRAPH-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151603#comment-13151603
]
Avery Ching commented on GIRAPH-91:
---
By the way, rb allows you to download the diff
[
https://issues.apache.org/jira/browse/GIRAPH-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151736#comment-13151736
]
Avery Ching commented on GIRAPH-92:
---
I agree this could be useful.
Couple of format
[
https://issues.apache.org/jira/browse/GIRAPH-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151782#comment-13151782
]
Avery Ching commented on GIRAPH-78:
---
Actually the more I think about it, this might not
[
https://issues.apache.org/jira/browse/GIRAPH-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151844#comment-13151844
]
Avery Ching commented on GIRAPH-91:
---
Arun, we can certainly try other data structure for
[
https://issues.apache.org/jira/browse/GIRAPH-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151848#comment-13151848
]
Avery Ching commented on GIRAPH-93:
---
I think RCFile initially, then other formats in
[
https://issues.apache.org/jira/browse/GIRAPH-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151866#comment-13151866
]
Avery Ching commented on GIRAPH-93:
---
Specifically, we have a lot of data stored in Hive
[
https://issues.apache.org/jira/browse/GIRAPH-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152203#comment-13152203
]
Avery Ching commented on GIRAPH-96:
---
The general issue of overloading our memory and
[
https://issues.apache.org/jira/browse/GIRAPH-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152488#comment-13152488
]
Avery Ching commented on GIRAPH-84:
---
ternary is fine with me. I think we use it in the
[
https://issues.apache.org/jira/browse/GIRAPH-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13153927#comment-13153927
]
Avery Ching commented on GIRAPH-84:
---
Claudio, once a committer +1's something they can
[
https://issues.apache.org/jira/browse/GIRAPH-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155334#comment-13155334
]
Avery Ching commented on GIRAPH-99:
---
Thanks Kohei, glad to see you working on Giraph!
[
https://issues.apache.org/jira/browse/GIRAPH-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13161031#comment-13161031
]
Avery Ching commented on GIRAPH-100:
Anyone? =)
Data input sampling
[
https://issues.apache.org/jira/browse/GIRAPH-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13161219#comment-13161219
]
Avery Ching commented on GIRAPH-100:
Sorry Jakob, I'll try to stop doing formatting
[
https://issues.apache.org/jira/browse/GIRAPH-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13161243#comment-13161243
]
Avery Ching commented on GIRAPH-100:
Ah, I see. We should file another JIRA to create
[
https://issues.apache.org/jira/browse/GIRAPH-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162640#comment-13162640
]
Avery Ching commented on GIRAPH-10:
---
Hi Claudio, great stuff!
A couple of questions.
I
[
https://issues.apache.org/jira/browse/GIRAPH-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162929#comment-13162929
]
Avery Ching commented on GIRAPH-10:
---
Thanks for the revised diff. I have some
[
https://issues.apache.org/jira/browse/GIRAPH-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163050#comment-13163050
]
Avery Ching commented on GIRAPH-10:
---
Much improved Claudio.
A couple more minor
[
https://issues.apache.org/jira/browse/GIRAPH-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166430#comment-13166430
]
Avery Ching commented on GIRAPH-103:
Also, I updated my affiliation to Facebook.
[
https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169756#comment-13169756
]
Avery Ching commented on GIRAPH-45:
---
I've been thinking about this a bit more. I don't
[
https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170613#comment-13170613
]
Avery Ching commented on GIRAPH-45:
---
You might not need the BTree for indexing the
[
https://issues.apache.org/jira/browse/GIRAPH-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170631#comment-13170631
]
Avery Ching commented on GIRAPH-93:
---
Just wanted to update that I did get this to work
[
https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170651#comment-13170651
]
Avery Ching commented on GIRAPH-80:
---
By the way Sebastian, you can run the Hadoop tests
[
https://issues.apache.org/jira/browse/GIRAPH-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170803#comment-13170803
]
Avery Ching commented on GIRAPH-103:
No one wants to take a quick look? It's very
[
https://issues.apache.org/jira/browse/GIRAPH-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170831#comment-13170831
]
Avery Ching commented on GIRAPH-93:
---
Argh, since HCatalog is not published to maven, this
[
https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170857#comment-13170857
]
Avery Ching commented on GIRAPH-57:
---
Emergency fix to allow trunk to compile on certain
[
https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171073#comment-13171073
]
Avery Ching commented on GIRAPH-45:
---
I think that a read messages-by-vertex at a time
[
https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171404#comment-13171404
]
Avery Ching commented on GIRAPH-45:
---
Ah, thank you for clarifying that. The only minor
[
https://issues.apache.org/jira/browse/GIRAPH-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171797#comment-13171797
]
Avery Ching commented on GIRAPH-73:
---
Most of these changes look good, but I'm not sure I
[
https://issues.apache.org/jira/browse/GIRAPH-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171898#comment-13171898
]
Avery Ching commented on GIRAPH-105:
Thanks for the reworking! +1.
[
https://issues.apache.org/jira/browse/GIRAPH-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173512#comment-13173512
]
Avery Ching commented on GIRAPH-111:
I'm not clear on why this is necessary. Couldn't
[
https://issues.apache.org/jira/browse/GIRAPH-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173931#comment-13173931
]
Avery Ching commented on GIRAPH-108:
Actually, I'll let Jakob take a first crack at
[
https://issues.apache.org/jira/browse/GIRAPH-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181566#comment-13181566
]
Avery Ching commented on GIRAPH-119:
Minor nit
@Override
public
[
https://issues.apache.org/jira/browse/GIRAPH-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181570#comment-13181570
]
Avery Ching commented on GIRAPH-118:
Seems reasonable. Please make sure to update the
[
https://issues.apache.org/jira/browse/GIRAPH-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181894#comment-13181894
]
Avery Ching commented on GIRAPH-118:
+1, looks good!
Clarify
[
https://issues.apache.org/jira/browse/GIRAPH-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184655#comment-13184655
]
Avery Ching commented on GIRAPH-123:
Works for me. Thanks Jakob.
[
https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13188578#comment-13188578
]
Avery Ching commented on GIRAPH-126:
Agree with Jakob. Thanks Andrei, every memory
[
https://issues.apache.org/jira/browse/GIRAPH-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13188588#comment-13188588
]
Avery Ching commented on GIRAPH-126:
Actually, looking at it some more, does this
[
https://issues.apache.org/jira/browse/GIRAPH-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13189574#comment-13189574
]
Avery Ching commented on GIRAPH-127:
I think this functionality is very useful and
[
https://issues.apache.org/jira/browse/GIRAPH-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13190351#comment-13190351
]
Avery Ching commented on GIRAPH-124:
Nice, Claudio. I haven't had a chance to fully
[
https://issues.apache.org/jira/browse/GIRAPH-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13192388#comment-13192388
]
Avery Ching commented on GIRAPH-130:
It would be great to enforce this checking
[
https://issues.apache.org/jira/browse/GIRAPH-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13192887#comment-13192887
]
Avery Ching commented on GIRAPH-129:
As long as mvn compile doesn't build the javadoc,
[
https://issues.apache.org/jira/browse/GIRAPH-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13193579#comment-13193579
]
Avery Ching commented on GIRAPH-128:
Anyone want to review? I think this will be very
[
https://issues.apache.org/jira/browse/GIRAPH-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13195286#comment-13195286
]
Avery Ching commented on GIRAPH-128:
Thanks for taking a look. I forgot to upload the
[
https://issues.apache.org/jira/browse/GIRAPH-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13196727#comment-13196727
]
Avery Ching commented on GIRAPH-134:
+1, looks good! Excited for the release.
[
https://issues.apache.org/jira/browse/GIRAPH-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13197650#comment-13197650
]
Avery Ching commented on GIRAPH-136:
I can verify the error message is improved, but
[
https://issues.apache.org/jira/browse/GIRAPH-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13198070#comment-13198070
]
Avery Ching commented on GIRAPH-136:
Okay, hopefully that gets addressed at some
[
https://issues.apache.org/jira/browse/GIRAPH-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13199585#comment-13199585
]
Avery Ching commented on GIRAPH-136:
+1, much better.
First try.
$ ./bin/giraph
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13199938#comment-13199938
]
Avery Ching commented on GIRAPH-40:
---
By the way Claudio, I think several IDEs have
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13199935#comment-13199935
]
Avery Ching commented on GIRAPH-40:
---
What I meant and am working on, is failing the build
[
https://issues.apache.org/jira/browse/GIRAPH-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203900#comment-13203900
]
Avery Ching commented on GIRAPH-139:
I agree the main() and run() code should be
[
https://issues.apache.org/jira/browse/GIRAPH-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203967#comment-13203967
]
Avery Ching commented on GIRAPH-139:
sounds good to me.
Change
[
https://issues.apache.org/jira/browse/GIRAPH-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204213#comment-13204213
]
Avery Ching commented on GIRAPH-144:
I'm working on this, should have a fix by
[
https://issues.apache.org/jira/browse/GIRAPH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205047#comment-13205047
]
Avery Ching commented on GIRAPH-142:
Looks fine, could we just add a check somewhere
[
https://issues.apache.org/jira/browse/GIRAPH-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205598#comment-13205598
]
Avery Ching commented on GIRAPH-139:
+1
Looks good to me.
Change
[
https://issues.apache.org/jira/browse/GIRAPH-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205947#comment-13205947
]
Avery Ching commented on GIRAPH-148:
Jakob, this header is formatted slightly
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205976#comment-13205976
]
Avery Ching commented on GIRAPH-40:
---
Here are some examples of one problem: Checkstyle
[
https://issues.apache.org/jira/browse/GIRAPH-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205992#comment-13205992
]
Avery Ching commented on GIRAPH-148:
It will with checkstyle (see GIRAPH-40). We will
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206291#comment-13206291
]
Avery Ching commented on GIRAPH-40:
---
Thank you for the feedback Claudio. I'll continue
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207188#comment-13207188
]
Avery Ching commented on GIRAPH-40:
---
So for the first example, we need to follow that
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207203#comment-13207203
]
Avery Ching commented on GIRAPH-40:
---
I'm not a checkstyle expert, but I don't think so. I
[
https://issues.apache.org/jira/browse/GIRAPH-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207211#comment-13207211
]
Avery Ching commented on GIRAPH-148:
+1.
giraph-site.xml needs
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209727#comment-13209727
]
Avery Ching commented on GIRAPH-40:
---
Can another committer please look at this as per
[
https://issues.apache.org/jira/browse/GIRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13209801#comment-13209801
]
Avery Ching commented on GIRAPH-40:
---
Thanks so much for the reviews Jakob and Sebastian.
[
https://issues.apache.org/jira/browse/GIRAPH-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13210025#comment-13210025
]
Avery Ching commented on GIRAPH-150:
By the way, here was the full stack trace:
[
https://issues.apache.org/jira/browse/GIRAPH-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13216047#comment-13216047
]
Avery Ching commented on GIRAPH-85:
---
please make sure it passes 'mvn verify' as well.
1 - 100 of 138 matches
Mail list logo
