[jira] [Commented] (GIRAPH-12) Investigate communication improvements

2011-09-26 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13115239#comment-13115239 ] Avery Ching commented on GIRAPH-12: --- Are hadoop metrics better than simply using Runtime?

[jira] [Commented] (GIRAPH-12) Investigate communication improvements

2011-09-28 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13116259#comment-13116259 ] Avery Ching commented on GIRAPH-12: --- I wonder if Runtime methods measure the stack sizes

[jira] [Commented] (GIRAPH-12) Investigate communication improvements

2011-09-28 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117011#comment-13117011 ] Avery Ching commented on GIRAPH-12: --- If the default stack size is 1 MB, then for instance

[jira] [Commented] (GIRAPH-10) Aggregators are not exported

2011-09-29 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117569#comment-13117569 ] Avery Ching commented on GIRAPH-10: --- This is definitely an open question here. Here's a

[jira] [Commented] (GIRAPH-43) GiraphJob: Counter Limit is not set

2011-09-29 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117891#comment-13117891 ] Avery Ching commented on GIRAPH-43: --- Yeah, this kind of sucks. One thing we could do is

[jira] [Commented] (GIRAPH-12) Investigate communication improvements

2011-10-04 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13120607#comment-13120607 ] Avery Ching commented on GIRAPH-12: --- You should commit =). There hasn't been any

[jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

2011-10-05 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121448#comment-13121448 ] Avery Ching commented on GIRAPH-47: --- Sorry if I wasn't clear, but we could do away with

[jira] [Commented] (GIRAPH-49) Create automated multi-build test

2011-10-07 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123304#comment-13123304 ] Avery Ching commented on GIRAPH-49: --- This would be nice. Not sure about fb, since it's

[jira] [Commented] (GIRAPH-48) All tests failing under non-secure build

2011-10-10 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123912#comment-13123912 ] Avery Ching commented on GIRAPH-48: --- This issue affect all versions of Hadoop I believe.

[jira] [Commented] (GIRAPH-48) All tests failing under non-secure build

2011-10-10 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123935#comment-13123935 ] Avery Ching commented on GIRAPH-48: --- Yeah, Eclipse automatically does that. The main

[jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

2011-10-11 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13125217#comment-13125217 ] Avery Ching commented on GIRAPH-47: --- I was thinking about the later approach that you

[jira] [Commented] (GIRAPH-52) There should be a scheme to limit the counter

2011-10-13 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13127169#comment-13127169 ] Avery Ching commented on GIRAPH-52: --- Here's a related issue

[jira] [Commented] (GIRAPH-52) There should be a scheme to limit the counter

2011-10-14 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13127301#comment-13127301 ] Avery Ching commented on GIRAPH-52: --- Anything is probably better than the adhoc counter

[jira] [Commented] (GIRAPH-52) There should be a scheme to limit the counter

2011-10-14 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13127302#comment-13127302 ] Avery Ching commented on GIRAPH-52: --- By the way Zhiwei, I've added you as a contributor

[jira] [Commented] (GIRAPH-53) Unable to read additional data from server session, likely server has closed socket

2011-10-14 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13127626#comment-13127626 ] Avery Ching commented on GIRAPH-53: --- Thanks for reporting the issue. A few questions:

[jira] [Commented] (GIRAPH-53) Unable to read additional data from server session, likely server has closed socket

2011-10-14 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13127702#comment-13127702 ] Avery Ching commented on GIRAPH-53: --- Also, I wonder if it's related to the counter

[jira] [Commented] (GIRAPH-37) Implement Netty-backed rpc solution

2011-10-16 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13128357#comment-13128357 ] Avery Ching commented on GIRAPH-37: --- Jakob, this is a big patch, thanks for taking the

[jira] [Commented] (GIRAPH-58) Update site with Arun Suresh's updated Id and Email

2011-10-17 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13129063#comment-13129063 ] Avery Ching commented on GIRAPH-58: --- +1. Looks good to me. =) You'll need to follow the

[jira] [Commented] (GIRAPH-61) Worker's early failure will cause the whole system fail

2011-10-24 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134716#comment-13134716 ] Avery Ching commented on GIRAPH-61: --- If you actually have enough resources (memory), then

[jira] [Commented] (GIRAPH-53) Unable to read additional data from server session, likely server has closed socket

2011-10-24 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134723#comment-13134723 ] Avery Ching commented on GIRAPH-53: --- No, the map tasks are held for the duration of the

[jira] [Commented] (GIRAPH-66) Add presentations section to website

2011-10-26 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13136402#comment-13136402 ] Avery Ching commented on GIRAPH-66: --- Actually, let me add it to slideshare and do it that

[jira] [Commented] (GIRAPH-66) Add presentations section to website

2011-10-26 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13136428#comment-13136428 ] Avery Ching commented on GIRAPH-66: --- +1 on your patch. I totally misunderstood what

[jira] [Commented] (GIRAPH-66) Add presentations section to website

2011-10-26 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13136522#comment-13136522 ] Avery Ching commented on GIRAPH-66: --- It's on slideshare.

[jira] [Commented] (GIRAPH-50) Require Maven 3 in order to work with munging plugin

2011-10-28 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138892#comment-13138892 ] Avery Ching commented on GIRAPH-50: --- +1 =). I was able to try it on 3.0.3 and confirmed

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-10-30 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139871#comment-13139871 ] Avery Ching commented on GIRAPH-36: --- Tried out your stuff Jake. Unittests passed for me.

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-10-31 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140279#comment-13140279 ] Avery Ching commented on GIRAPH-36: --- Jake, Your suggestion on 1) will work, but couldn't

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-11-01 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140974#comment-13140974 ] Avery Ching commented on GIRAPH-36: --- Regarding 1) I think it would be safer for use to

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-11-01 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141573#comment-13141573 ] Avery Ching commented on GIRAPH-36: --- Since this is a somewhat large change, can you also

[jira] [Commented] (GIRAPH-36) Ensure that subclassing BasicVertex is possible by user apps

2011-11-02 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141965#comment-13141965 ] Avery Ching commented on GIRAPH-36: --- +1. Jake, just re-ran with your new patch. Passed

[jira] [Commented] (GIRAPH-64) Create VertexRunner to make it easier to run users' computations

2011-11-02 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141969#comment-13141969 ] Avery Ching commented on GIRAPH-64: --- Anyone want to take a crack at reviewing this? If

[jira] [Commented] (GIRAPH-64) Create VertexRunner to make it easier to run users' computations

2011-11-02 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142780#comment-13142780 ] Avery Ching commented on GIRAPH-64: --- I don't know how to make reviewboard do it

[jira] [Commented] (GIRAPH-72) Running multiple Giraph jobs on the same cluster can lead to port collisions

2011-11-03 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142870#comment-13142870 ] Avery Ching commented on GIRAPH-72: --- Ah, you can set the base rpc port by the way, sorry

[jira] [Commented] (GIRAPH-64) Create VertexRunner to make it easier to run users' computations

2011-11-03 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143314#comment-13143314 ] Avery Ching commented on GIRAPH-64: --- Jakob, pulled the diff from your last rb (updating

[jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

2011-11-05 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13144618#comment-13144618 ] Avery Ching commented on GIRAPH-47: --- do we still want WorkerContext.preApplication() to

[jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

2011-11-05 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13144735#comment-13144735 ] Avery Ching commented on GIRAPH-47: --- I agree with the proxy approach of WorkerContext so

[jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

2011-11-06 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13145035#comment-13145035 ] Avery Ching commented on GIRAPH-47: --- Claudio, Just checked out your diff. Overall looks

[jira] [Commented] (GIRAPH-64) Create VertexRunner to make it easier to run users' computations

2011-11-07 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13145687#comment-13145687 ] Avery Ching commented on GIRAPH-64: --- $ mvn --version Apache Maven 3.0.3 (r1075438;

[jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

2011-11-07 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13145694#comment-13145694 ] Avery Ching commented on GIRAPH-47: --- Sorry, Claudio, my bad. I still had remnants of

[jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

2011-11-07 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13145868#comment-13145868 ] Avery Ching commented on GIRAPH-47: --- +1 Thanks Claudio. I'm going to commit on your

[jira] [Commented] (GIRAPH-47) Export Worker's Context/State to vertices through pre/post/Application/Superstep

2011-11-07 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13145879#comment-13145879 ] Avery Ching commented on GIRAPH-47: --- I filed issue

[jira] [Commented] (GIRAPH-11) Improve the graph distribution of Giraph

2011-11-09 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147226#comment-13147226 ] Avery Ching commented on GIRAPH-11: --- I started it so long ago that the merge was brutal

[jira] [Commented] (GIRAPH-73) A little refactoring

2011-11-10 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147913#comment-13147913 ] Avery Ching commented on GIRAPH-73: --- Hi Sebastian, Thanks for the refactoring and for

[jira] [Commented] (GIRAPH-74) GIRAPH-36 missed a couple of liners when passing from Vertex to BasicVertex

2011-11-10 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147919#comment-13147919 ] Avery Ching commented on GIRAPH-74: --- Some of this I also addressed in GIRAPH-11 =). I

[jira] [Commented] (GIRAPH-74) GIRAPH-36 missed a couple of liners when passing from Vertex to BasicVertex

2011-11-10 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147968#comment-13147968 ] Avery Ching commented on GIRAPH-74: --- Either the vertex will keep track of it or the user

[jira] [Commented] (GIRAPH-74) GIRAPH-36 missed a couple of liners when passing from Vertex to BasicVertex

2011-11-10 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147975#comment-13147975 ] Avery Ching commented on GIRAPH-74: --- Well, if you vote to halt, your compute() is never

[jira] [Commented] (GIRAPH-64) Create VertexRunner to make it easier to run users' computations

2011-11-14 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149810#comment-13149810 ] Avery Ching commented on GIRAPH-64: --- Given that Jake is doing the review, I'll let him

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-11-14 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149876#comment-13149876 ] Avery Ching commented on GIRAPH-80: --- Since public abstract void compute(IteratorM

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-11-14 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149891#comment-13149891 ] Avery Ching commented on GIRAPH-80: --- Seems reasonable to me. Having the option of

[jira] [Commented] (GIRAPH-11) Improve the graph distribution of Giraph

2011-11-14 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150097#comment-13150097 ] Avery Ching commented on GIRAPH-11: --- Ran local tests, MR tests, and ran the page rank

[jira] [Commented] (GIRAPH-74) GIRAPH-36 missed a couple of liners when passing from Vertex to BasicVertex

2011-11-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150663#comment-13150663 ] Avery Ching commented on GIRAPH-74: --- Claudio, are you synced to svn? The commit of

[jira] [Commented] (GIRAPH-61) Worker's early failure will cause the whole system fail

2011-11-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150668#comment-13150668 ] Avery Ching commented on GIRAPH-61: --- Currently, the master knows whenever an active

[jira] [Commented] (GIRAPH-78) Be smarter about multiple instances of the same vertex

2011-11-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150673#comment-13150673 ] Avery Ching commented on GIRAPH-78: --- +1, this would be a great memory optimization.

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

2011-11-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150864#comment-13150864 ] Avery Ching commented on GIRAPH-45: --- It's going to be a bit complicated to store the

[jira] [Commented] (GIRAPH-83) Is Vertex correct yet?

2011-11-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150867#comment-13150867 ] Avery Ching commented on GIRAPH-83: --- While you can decouple everything from vertex, I

[jira] [Commented] (GIRAPH-68) Implement a Graph Generator

2011-11-16 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151405#comment-13151405 ] Avery Ching commented on GIRAPH-68: --- Looks good Hyunsik, a few comments. Probably want

[jira] [Commented] (GIRAPH-91) Large-memory improvements (Memory reduced vertex implementation, fast failure, added settings)

2011-11-16 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151603#comment-13151603 ] Avery Ching commented on GIRAPH-91: --- By the way, rb allows you to download the diff

[jira] [Commented] (GIRAPH-92) Need outputformat for just vertex ID and value

2011-11-16 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151736#comment-13151736 ] Avery Ching commented on GIRAPH-92: --- I agree this could be useful. Couple of format

[jira] [Commented] (GIRAPH-78) Be smarter about multiple instances of the same vertex

2011-11-16 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151782#comment-13151782 ] Avery Ching commented on GIRAPH-78: --- Actually the more I think about it, this might not

[jira] [Commented] (GIRAPH-91) Large-memory improvements (Memory reduced vertex implementation, fast failure, added settings)

2011-11-16 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151844#comment-13151844 ] Avery Ching commented on GIRAPH-91: --- Arun, we can certainly try other data structure for

[jira] [Commented] (GIRAPH-93) Hive input / output format

2011-11-16 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151848#comment-13151848 ] Avery Ching commented on GIRAPH-93: --- I think RCFile initially, then other formats in

[jira] [Commented] (GIRAPH-93) Hive input / output format

2011-11-16 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151866#comment-13151866 ] Avery Ching commented on GIRAPH-93: --- Specifically, we have a lot of data stored in Hive

[jira] [Commented] (GIRAPH-96) Support for Graphs with Huge adjacency lists

2011-11-17 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152203#comment-13152203 ] Avery Ching commented on GIRAPH-96: --- The general issue of overloading our memory and

[jira] [Commented] (GIRAPH-84) Simplify boolean expressions in BspRecordReader

2011-11-17 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152488#comment-13152488 ] Avery Ching commented on GIRAPH-84: --- ternary is fine with me. I think we use it in the

[jira] [Commented] (GIRAPH-84) Simplify boolean expressions in BspRecordReader

2011-11-20 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13153927#comment-13153927 ] Avery Ching commented on GIRAPH-84: --- Claudio, once a committer +1's something they can

[jira] [Commented] (GIRAPH-99) Make AdjacencyListVertexReader and its constructor public

2011-11-22 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13155334#comment-13155334 ] Avery Ching commented on GIRAPH-99: --- Thanks Kohei, glad to see you working on Giraph!

[jira] [Commented] (GIRAPH-100) Data input sampling and testing improvements

2011-12-01 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13161031#comment-13161031 ] Avery Ching commented on GIRAPH-100: Anyone? =) Data input sampling

[jira] [Commented] (GIRAPH-100) Data input sampling and testing improvements

2011-12-01 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13161219#comment-13161219 ] Avery Ching commented on GIRAPH-100: Sorry Jakob, I'll try to stop doing formatting

[jira] [Commented] (GIRAPH-100) Data input sampling and testing improvements

2011-12-01 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13161243#comment-13161243 ] Avery Ching commented on GIRAPH-100: Ah, I see. We should file another JIRA to create

[jira] [Commented] (GIRAPH-102) Create an exception class for Giraph

2011-12-01 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13161356#comment-13161356 ] Avery Ching commented on GIRAPH-102: As a part of this issue, go through the

[jira] [Commented] (GIRAPH-100) Data input sampling and testing improvements

2011-12-01 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13161357#comment-13161357 ] Avery Ching commented on GIRAPH-100: I added another JIRA

[jira] [Commented] (GIRAPH-10) Aggregators are not exported

2011-12-04 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162640#comment-13162640 ] Avery Ching commented on GIRAPH-10: --- Hi Claudio, great stuff! A couple of questions. I

[jira] [Commented] (GIRAPH-10) Aggregators are not exported

2011-12-05 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162929#comment-13162929 ] Avery Ching commented on GIRAPH-10: --- Thanks for the revised diff. I have some

[jira] [Commented] (GIRAPH-10) Aggregators are not exported

2011-12-05 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163050#comment-13163050 ] Avery Ching commented on GIRAPH-10: --- Much improved Claudio. A couple more minor

[jira] [Commented] (GIRAPH-103) Added properties for commonly used package version to pom.xml

2011-12-09 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166430#comment-13166430 ] Avery Ching commented on GIRAPH-103: Also, I updated my affiliation to Facebook.

[jira] [Commented] (GIRAPH-104) Save half of maximum memory used from messaging

2011-12-13 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168646#comment-13168646 ] Avery Ching commented on GIRAPH-104: The reduction in the maximum amount of heap used

[jira] [Commented] (GIRAPH-104) Save half of maximum memory used from messaging

2011-12-13 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168936#comment-13168936 ] Avery Ching commented on GIRAPH-104: Messaging pattern was from RandomMessageBenchmark

[jira] [Commented] (GIRAPH-104) Save half of maximum memory used from messaging

2011-12-13 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168938#comment-13168938 ] Avery Ching commented on GIRAPH-104: By the way, here's example output from the

[jira] [Commented] (GIRAPH-57) Provide PutMsgs RPC call

2011-12-13 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169147#comment-13169147 ] Avery Ching commented on GIRAPH-57: --- Added a new request called putVertexIdMessagesList

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

2011-12-14 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169756#comment-13169756 ] Avery Ching commented on GIRAPH-45: --- I've been thinking about this a bit more. I don't

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170398#comment-13170398 ] Avery Ching commented on GIRAPH-80: --- Guys, GIRAPH-104 has been committed, the svn commit

[jira] [Commented] (GIRAPH-57) Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170489#comment-13170489 ] Avery Ching commented on GIRAPH-57: --- Anyone wanna review? This is a pretty

[jira] [Commented] (GIRAPH-57) Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170602#comment-13170602 ] Avery Ching commented on GIRAPH-57: --- I only ran mvn package =(. I need to remember to do

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170613#comment-13170613 ] Avery Ching commented on GIRAPH-45: --- You might not need the BTree for indexing the

[jira] [Commented] (GIRAPH-93) Hive input / output format

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170631#comment-13170631 ] Avery Ching commented on GIRAPH-93: --- Just wanted to update that I did get this to work

[jira] [Commented] (GIRAPH-80) Don't expose the list holding the messages in BasicVertex

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170651#comment-13170651 ] Avery Ching commented on GIRAPH-80: --- By the way Sebastian, you can run the Hadoop tests

[jira] [Commented] (GIRAPH-103) Added properties for commonly used package version to pom.xml

2011-12-15 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170803#comment-13170803 ] Avery Ching commented on GIRAPH-103: No one wants to take a quick look? It's very

[jira] [Commented] (GIRAPH-93) Hive input / output format

2011-12-16 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170831#comment-13170831 ] Avery Ching commented on GIRAPH-93: --- Argh, since HCatalog is not published to maven, this

[jira] [Commented] (GIRAPH-57) Add new RPC call (putVertexIdMessagesList) to batch putMsgList RPCs together

2011-12-16 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170857#comment-13170857 ] Avery Ching commented on GIRAPH-57: --- Emergency fix to allow trunk to compile on certain

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

2011-12-16 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171073#comment-13171073 ] Avery Ching commented on GIRAPH-45: --- I think that a read messages-by-vertex at a time

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

2011-12-16 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171273#comment-13171273 ] Avery Ching commented on GIRAPH-45: --- Ah, I get it. You always dump the whole map of

[jira] [Commented] (GIRAPH-45) Improve the way to keep outgoing messages

2011-12-16 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171404#comment-13171404 ] Avery Ching commented on GIRAPH-45: --- Ah, thank you for clarifying that. The only minor

[jira] [Commented] (GIRAPH-105) BspServiceMaster.checkWorkers() should return empty lists instead of null

2011-12-18 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171793#comment-13171793 ] Avery Ching commented on GIRAPH-105: I totally agree that the NPE is messy for a

[jira] [Commented] (GIRAPH-73) A little refactoring

2011-12-18 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171797#comment-13171797 ] Avery Ching commented on GIRAPH-73: --- Most of these changes look good, but I'm not sure I

[jira] [Commented] (GIRAPH-105) BspServiceMaster.checkWorkers() should return empty lists instead of null

2011-12-18 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171898#comment-13171898 ] Avery Ching commented on GIRAPH-105: Thanks for the reworking! +1.

[jira] [Commented] (GIRAPH-111) Refactor I/O to be independent of Map/Reduce

2011-12-20 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173512#comment-13173512 ] Avery Ching commented on GIRAPH-111: I'm not clear on why this is necessary. Couldn't

[jira] [Commented] (GIRAPH-108) Refactor code to run independently of Map/Reduce

2011-12-20 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173931#comment-13173931 ] Avery Ching commented on GIRAPH-108: Actually, I'll let Jakob take a first crack at

[jira] [Commented] (GIRAPH-113) Change cast to Vertex used in prepareSuperstep() to BasicVertex

2011-12-21 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13174274#comment-13174274 ] Avery Ching commented on GIRAPH-113: I agree that GIRAPH-83 and GIRAPH-95 need to be

[jira] [Commented] (GIRAPH-114) Inconsistent message map handling in BasicRPCCommunications.LargeMessageFlushExecutor

2011-12-21 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13174283#comment-13174283 ] Avery Ching commented on GIRAPH-114: +1, nice find! The whole RPC thing is a bit

[jira] [Commented] (GIRAPH-117) DefaultWorkerContext should preserve the method signatures of WorkerContext

2012-01-02 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13178510#comment-13178510 ] Avery Ching commented on GIRAPH-117: +1, looks fine to me.

[jira] [Commented] (GIRAPH-119) VertexCombiner should work on IterableM instead of ListM

2012-01-06 Thread Avery Ching (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181566#comment-13181566 ] Avery Ching commented on GIRAPH-119: Minor nit @Override public

  1   2   >