On 07/09/13 22:03, Lee Carver wrote:
As noted in several forums, a recommended way to move trees between
repositories
is to use git-filter-branch to revise the history for a single tree:
http://gbayer.com/development/moving-files-from-one-git-repository-to-anoth
er-preserving-history/
http://sta
Hi Elia. Sorry, but I have to give my NAK to this patch.
On 09/11/2013 04:46 PM, Elia Pinto wrote:
Git use, as many project that use autoconf, private m4 macros.
When not using automake, and just relying on autoconf, the macro
files are not picked up by default.
A possibility, as git do today
The configure option to disable threading is '--disable-pthreads',
not '--without-pthreads'.
Signed-off-by: Stefano Lattarini
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index f3462d9..2f43393 100644
---
Hello list.
In the last year or so, I developed a personal idiom of using a
naming scheme of "@/BRANCH-NAME/"to "save" the older versions
of branches I'm going to rebase (interactively or not). Here is an
idealized example of my use case:
$ git co --help
`git co' is aliased to `checkout'
[re-sending to the list, sorry Junio for the duplicate mail]
On 08/14/2013 07:05 PM, Junio C Hamano wrote:
> Stefano Lattarini writes:
>
>> My problems is that some new automagical interpretation of the bare
>> @' character (introduced after 1.8.3) has destroyed my use
On 08/14/2013 09:57 PM, Junio C Hamano wrote:
> Johannes Sixt writes:
>
> [SNIP]
>
>> Stefano's use-case, where @/foo is turned into HEAD/foo,
>> indicates a bug.
>>
>> In my opinion, the topic, which touches a central part of ref
>> handling, was a bit hurried (and this report is a symptom of it
(Going through old mail today, sorry for the late reply)
On 08/01/2013 12:10 AM, Junio C Hamano wrote:> Stefan Beller
writes:
>
>> On 07/31/13 00:28, Junio C Hamano wrote:
>>>
>>> we could just do
>>>
>>> #define OPT_CMDMODE(s, l, v, h) \
>>> { OPTION_CMDMODE, (s), (l), (v), NULL, \
>>>
On 11/11/2012 12:11 AM, Felipe Contreras wrote:
> On Sat, Nov 10, 2012 at 11:39 PM, Junio C Hamano wrote:
>> Felipe Contreras writes:
>>
>>> On Sat, Nov 10, 2012 at 3:37 PM, Torsten Bögershausen wrote:
The short version:
echo -n doesn't seem to be portable.
The following works for
On 11/11/2012 01:58 AM, Felipe Contreras wrote:
>
> It doesn't seem like zsh listens to that variable in sh mode:
> $ zsh -c 'emulate sh; NULLCMD=foobar; > content'
>
Right; "emulate sh" by itself is probably enough today (autoconf, trying
to make its generated scripts extra-portable, tends to ac
On 11/14/2012 12:18 PM, Quintin Ronan wrote:
> Hello,
>
> I’m trying to compile git 1.7 on a HPUX server using make.
> The ./configure worked well :
>
> [SNIP]
>
> But when i run make (with –d) it simply doesn’t work with a message
> which isn’t really helpfull :
>
> [SNIP]
> Make: line 313:
Hi David. One minor but important correction ...
On 11/25/2012 12:51 PM, David Lang wrote:
>
> You may think that C and Bash are poor choices, but that is what the
> community is familar with.
>
Actually, it is C and POSIX shell -- not merely bash. Indeed, the shell
code in Git is expected to wo
On 12/02/2012 02:17 PM, Torsten Bögershausen wrote:
> The test suite needs to be run on different platforms.
> As it may be difficult for contributors to catch syntax
> which work on GNU/linux, but is unportable, make a quick check
> for the most common problems.
> "sed -i", "echo -n" or "array in
Consistently use a single space before and after the "=" (or ":=", "+=",
etc.) in assignments to make macros. Granted, this was not a big deal,
but I did find the needless inconsistency quite distracting.
Signed-off-by: Stefano Latt
Hi Junio, Marc.
On 12/07/2012 10:08 PM, Junio C Hamano wrote:
> Marc Branchaud writes:
>
>> It's FreeBSD 7.2, which I know is an obsolete version but I'm not able to
>> upgrade the machine. I believe FreeBSD's sh is, or is derived from, dash.
>
> Finally. Yes, as you suspected, I am perfectly
On 12/15/2012 07:35 PM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> Stefano Lattarini writes:
>>
>>> And this is clearly stressed by Linus in the COPYING file. So make it
>>> clear in the README as well, to avoid possible misunderstandings.
>
On 12/15/2012 08:39 PM, Junio C Hamano wrote:
> Stefano Lattarini writes:
>
>> On 12/15/2012 07:35 PM, Junio C Hamano wrote:
>>> ...
>>> -Git is an Open Source project covered by the GNU General Public License.
>>> +Git is an Open Source project covered
On 12/21/2012 04:12 AM, Junio C Hamano wrote:
> From: Adam Spiers
>
> Yellow seems a more appropriate color than bold green when
> considering the universal traffic lights coloring scheme, where
> green conveys the impression that everything's OK, and amber that
> something's not quite right.
>
H
On 12/21/2012 04:46 PM, Junio C Hamano wrote:
>
> [SNIP]
>
> The only thing the additional knowledge adds seems to be to give
> rationale for the old choice of "bold green"---it was not chosen
> from thin-air but can be viewed as following the automake/autotest
> scheme, and other systems cannot ag
On 01/02/2013 09:48 AM, Jonathan Nieder wrote:
> Jeff King wrote:
>
>> It seems I am late to the party. But FWIW, this looks the most sane to
>> me of the patches posted in this thread.
>
> Thanks. config.status runs ./configure itself, though, so the rule
> should actually be
>
> config.
On 01/02/2013 05:50 PM, Junio C Hamano wrote:
> Stefano Lattarini writes:
>
>> On 01/02/2013 09:48 AM, Jonathan Nieder wrote:
>>> Jeff King wrote:
>>>
>>>> It seems I am late to the party. But FWIW, this looks the most sane to
>>>> me of t
On 01/02/2013 09:25 PM, Junio C Hamano wrote:
> Stefano Lattarini writes:
>
>>> ifdef AUTOCONFIGURED
>>> -config.status: configure
>>> - $(QUIET_GEN)if test -f config.status; then \
>>> +# We avoid depending on 'configure' here, because i
On 01/03/2013 07:27 PM, Greg Troxel wrote:
>
> Junio C Hamano writes:
>
>> I forgot to mention that we also ship configure (and keep track of
>> configure.ac) so that optionally people can let autoconf machinery
>> to create config.mak.autogen to be included at the same place as
>> handcrafted c
to use color, to
> + `true` or `auto` (this is the default since Git 2.0) if you
> + want such output to use color when written to the terminal.
>
> column.ui::
> Specify whether supported commands should output in columns.
> diff --git a/color.c b/color.
On 05/26/2013 10:05 PM, Stefan Beller wrote:
> Reported by cppcheck.
>
> Signed-off-by: Stefan Beller
> ---
> fast-import.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fast-import.c b/fast-import.c
> index 5f539d7..0142e3a 100644
> --- a/fast-import.c
> +++ b/fast-i
On 05/26/2013 10:14 PM, Stefan Beller wrote:
> It's not done very often.
>
Of course; it's done only in those places where GCC gave spurious
warnings. And it's done for no other reason that to silence said
warnings.
> [SNIP] rest of message
Regards,
Stefano
--
To unsubscribe from this list: se
On 05/29/2013 06:16 AM, Felipe Contreras wrote:
> Signed-off-by: Felipe Contreras
> ---
> git-rebase.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/git-rebase.sh b/git-rebase.sh
> index 76900a0..9b5d78b 100755
> --- a/git-rebase.sh
> +++ b/git-rebase.sh
> @@ -335,6 +335,7 @@ skip)
>
On 05/30/2013 03:34 PM, Felipe Contreras wrote:
> Before overwriting the destination index, first let's discard it's
>
s/it's/its/
> contents.
>
> [SNIP]
Regards,
Stefano
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More
On 06/04/2013 05:46 PM, Jason Gross wrote:
> I get "*** glibc detected *** git: double free or corruption
> (fasttop): 0x01fab820 ***" reliably on the following set of
> commands. I'm working on a remote machine where I don't have
> administrative privileges, so I can't update from git 1.7
[Sorry for the full quote, but sometimes, repetita iuvant]
On 06/09/2013 11:42 PM, Michael Haggerty wrote:
> On 06/09/2013 09:11 PM, Johan Herland wrote:
>> [...]
>> FWIW, I'd like to express my support for the opinions expressed by
>> Jonathan, Jeff and Thomas. They accurately describe my impress
On 06/10/2013 07:15 AM, Felipe Contreras wrote:
> On Sun, Jun 9, 2013 at 6:40 PM, Stefano Lattarini
> wrote:
>
>> I do accuse Felipe's *attitude* to bring on and nourish such
>> unpleasantness toxicity. His technical merits and the possible
>> qualitie
Signed-off-by: Stefano Lattarini
---
Documentation/RelNotes/1.8.2.1.txt | 2 +-
Documentation/RelNotes/1.8.3.txt | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/RelNotes/1.8.2.1.txt
b/Documentation/RelNotes/1.8.2.1.txt
index 1354ad0..769a6fc 100644
Mostly suggested by codespell <https://github.com/lucasdemarchi/codespell>
Signed-off-by: Stefano Lattarini
---
Documentation/git-credential.txt | 2 +-
Documentation/git-remote-ext.txt | 2 +-
Documentation/git-svn.txt
Most typos suggested by codespell:
<https://github.com/lucasdemarchi/codespell>
Grammaros pointed out by Eric Sunshine.
Helped-by: Eric Sunshine
Signed-off-by: Stefano Lattarini
---
Documentation/git-credential.txt | 2 +-
Documentation/git-remote-e
Hi Junio.
On 04/12/2013 02:45 AM, Junio C Hamano wrote:
> Stefano Lattarini writes:
>
> How much of this stuff have interact with real changes that are in
> flight, with various doneness cooking in different integration
> branches?
>
I don't know, since I only follow t
On 04/18/2013 02:05 AM, Felipe Contreras wrote:
> This has never worked, since it's inception the code simply skips all
>
s/it's/its/ (sorry for nitpicking)
> the refs, essentially telling fast-export to do nothing.
>
> Let's at least tell the user what's going on.
>
> [SNIP]
>
Regards,
Stefa
nction cannot return value
cc: acomp failed for zlib.c
Signed-off-by: Stefano Lattarini
---
zlib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/zlib.c b/zlib.c
index bbaa081..61e6df0 100644
--- a/zlib.c
+++ b/zlib.c
@@ -189,7 +189,7 @@ void git_deflate_init_gzip(gi
On 04/22/2013 06:48 PM, Junio C Hamano wrote:
> Stefano Lattarini writes:
>
>> Do this by removing a couple of useless return statements. Without this
>> change, compilation with Sun C Compiler 5.9 (SunOS_i386 Patch 124868-15
>> 2010/08/11) fails with the following
On 04/22/2013 11:41 PM, Eric Sunshine wrote:
> On Mon, Apr 22, 2013 at 12:18 PM, Stefano Lattarini
> wrote:
>> zlib: fix compilation failures with Sun C Compilaer
>
> s/Compilaer/compiler/
>
Oops, well spotted. Junio, can you fix this locally?
Thanks, and sorry for the s
On 04/25/2013 08:19 PM, Ramkumar Ramachandra wrote:
> Felipe Contreras wrote:
>> diff --git a/contrib/remote-helpers/git-remote-bzr
>> b/contrib/remote-helpers/git-remote-bzr
>> index aa7bc97..82bf7c7 100755
>> --- a/contrib/remote-helpers/git-remote-bzr
>> +++ b/contrib/remote-helpers/git-remote-
On 05/04/2013 02:31 AM, Felipe Contreras wrote:
> Turns out fast-export throws bad 'reset' commands because of a behavior
> in transport-helper that is not even needed.
>
> We should ignore them, otherwise we will threat
>
s/threat/treat/
> them as branches and fail.
>
> This was fixed in v1.8.2
On 08/25/2012 02:56 PM, Tim Chase wrote:
> On 08/24/12 23:29, Junio C Hamano wrote:
>> Tim Chase writes:
>>> If the documented purpose of "diff -p" (and by proxy
>>> diff.{type}.xfuncname) is to show the name of the *function*
>>> containing the changed lines,
>>
>> Yeah, the documentation is
: Stefano Lattarini
---
configure.ac | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/configure.ac b/configure.ac
index df7e376..450bbe7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7,8 +7,9 @@
#
# Cause the line "VAR=VAL&q
BST([VAR], [VAL])" in configure.ac and adding the
'VAR = @VAR@' definition in config.mak.in. Less duplication, less margin
for error, less possibility of confusion.
While at it, fix some formatting issues in configure.ac that unnecessarily
obscured the code flow.
On 09/11/2012 07:27 PM, Junio C Hamano wrote:
> Stefano Lattarini writes:
>
>> Thanks to our 'GIT_CONF_SUBST' layer in configure.ac, a make variable 'VAR'
>> can be defined to a value 'VAL' at ./configure runtime in our build system
>
On 09/11/2012 09:52 PM, Junio C Hamano wrote:
> Stefano Lattarini writes:
>
>> On 09/11/2012 07:27 PM, Junio C Hamano wrote:
>>
>>> These two hunks suggest that you may be favoring spaces, but other
>>> places you seem to use tabs, so...
>>>
>>
On 09/17/2012 10:11 PM, Jeff King wrote:
> On Mon, Sep 17, 2012 at 12:50:37PM +0100, Adam Spiers wrote:
>
>> The end result of these changes is that:
>>
>> - red is _only_ used for things which have gone unexpectedly wrong:
>> test failures, unexpected test passes, and failures with the
>>
Hi Adam.
On 09/20/2012 11:08 AM, Adam Spiers wrote:
> Skipped tests indicate incomplete test coverage. Whilst this is
> not a test failure or other error, it's still not complete
> success, so according to the universal traffic lights coloring
> scheme, yellow/brown seems more suitable than green
On 09/21/2012 09:58 PM, Ramkumar Ramachandra wrote:
> Hi again,
>
> Ramkumar Ramachandra wrote:
>> I was able to reproduce the problem on all my machines, and I consider
>> this very disturbing. However, I was successfully able to corner the
>> issue. I have an overtly long $PATH that's not getti
On 09/21/2012 10:49 PM, Jeff King wrote:
>
> Oh. It sounds like setting $SHELL to zsh is really the problem, then. If
> it is not Bourne-compatible when called as "zsh", then it really should
> be called in a way that turns on compatibility mode (bash will do this
> when called as "sh", but you can
On 09/22/2012 07:47 PM, Jeff King wrote:
> On Sat, Sep 22, 2012 at 03:03:58PM +0200, Stefano Lattarini wrote:
>
>> On 09/21/2012 10:49 PM, Jeff King wrote:
>>>
>>> Oh. It sounds like setting $SHELL to zsh is really the problem, then. If
>>> it is not Bourn
On 10/02/2012 09:21 AM, Ramkumar Ramachandra wrote:
> Hi,
>
> I've often found the '**' (extended) shell glob useful for matching
> any string crossing directory boundaries: it's especially useful if
> you only have a toplevel .gitignore, as opposed to a per-directory
> .gitignore. Unfortunately,
Wl,-rpath,
> else
>AC_CACHE_CHECK([if linker supports -rpath], git_cv_ld_rpath, [
> SAVE_LDFLAGS="${LDFLAGS}"
> @@ -420,7 +420,7 @@ else
> LDFLAGS="${SAVE_LDFLAGS}"
>])
>if test "$git_cv_ld_rpath" = &qu
Hi Andreas. I hope you don't mind my nitpickiness, but ...
On 10/16/2012 06:28 PM, Andreas Schwab wrote:
> Michael J Gruber writes:
>
>> Some test want to use the time command (not the shell builtin) and test
>> for its availability at /usr/bin/time.
>
> An alternative way to suppress the buil
On 10/30/2012 11:17 PM, Elia Pinto wrote:
> Thanks. I know that posix support these usages, but exists some
> traditional shell that not support it.
>
True, but those shells are not POSIX shells -- the major example that
comes to mind is the accursed Solaris /bin/sh.
Since Git assumes a POSIX shel
On 11/02/2012 03:02 AM, Felipe Contreras wrote:
> It's way simpler. It exerceises the same features of remote helpers.
> It's easy to read and understand. It doesn't depend on python.
>
> It does _not_ exercise the python remote helper framework; there's
> another tool and another test for that.
>
On 11/02/2012 03:02 AM, Felipe Contreras wrote:
> Doesn't make a difference for the tests, but it does for the ones
> seeking reference.
>
> Signed-off-by: Felipe Contreras
> ---
> git-remote-testgit | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/git-remote-testgit b/git-
On 11/02/2012 04:42 PM, Felipe Contreras wrote:
> On Fri, Nov 2, 2012 at 2:55 PM, Stefano Lattarini
> wrote:
>
>>> +#!/bin/bash
>>>
>> I think git can't assume the existence of bash unconditionally, neither
>> in its scripts, nor in its tests (the exc
On 11/02/2012 04:46 PM, Felipe Contreras wrote:
>
> In the end I liked this approach much better.
>
> If you have a solution for this that works in POSIX shell, I'll be
> glad to consider it, but for the moment, I think a simple, easy to
> understand and maintain code is more important, and if it
On 11/02/2012 05:19 PM, Felipe Contreras wrote:
>
> [SNIP]
>
> As things are the options are:
>
> 1) Remove this code and move to POSIX sh. People looking for reference
> might scratch their heads as to why 'git push' is not showing the
> update.
> 2) Keep this code and remain in bash.
>
> Until
On 07/12/2012 01:30 AM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> I think the other tests in t/ prefer to unquote it so that we would
>> ignore spaces around "wc -l" output, i.e.
>>
>> test $(wc -l >
>> Thanks for a report.
>
> -- >8 --
> Subject: [PATCH] t1512: ignore whitespaces
preparatory changes.
The series as general or as clean as it could actually be, but it's
enough to scratch the itch that motivated me to write it.
Thanks,
Stefano
Stefano Lattarini (7):
autoconf: GIT_CONF_APPEND_LINE: change signature
autoconf: GIT_CONF_APPEND_LINE -> GIT_CO
From:
GIT_CONF_APPEND_LINE([VAR=VAL])
to:
GIT_CONF_APPEND_LINE([VAR], [VAL])
This is only a preparatory change in view of future refactorings.
No semantic change is intended. In fact, the generated configure
file doesn't change at all.
Signed-off-by: Stefano Latt
expected.
Signed-off-by: Stefano Lattarini
---
configure.ac | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/configure.ac b/configure.ac
index 14c7960..789926f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3,10 +3,10 @@
## Definitions of private
They are merely useless now, but would get in the way of future changes.
No semantic change is intended.
Signed-off-by: Stefano Lattarini
---
configure.ac | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/configure.ac b/configure.ac
index 789926f..9472f6b 100644
This will allow "./config.status --recheck; ./config.status" to work
correctly as a mean of reconfiguring the tree with the same configure
argument used in the previous "./configure" invocation.
Signed-off-by: Stefano Lattarini
---
configure.ac | 25 -
They are merely useless now, but would get in the way of future changes.
No semantic change is intended.
Signed-off-by: Stefano Lattarini
---
configure.ac | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 9472f6b..5fb9734 100644
--- a
manual
configuration won't be negatively impacted.
Signed-off-by: Stefano Lattarini
---
Makefile | 12
configure.ac | 2 ++
2 files changed, 14 insertions(+)
diff --git a/Makefile b/Makefile
index 88a76a3..f4e8fac 100644
--- a/Makefile
+++ b/Makefile
@@ -2158,6 +2158,18 @@
f '$HOME', thus installing git in the user's home
directory -- definitely unexpected.
Signed-off-by: Stefano Lattarini
---
Makefile | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 285c660..88a76a3 100644
--- a/Makefile
+++ b/Makefile
On 07/19/2012 08:56 AM, Matthieu Moy wrote:
> Stefano Lattarini writes:
>
>> for example, an autotools old-timer that has run:
>>
>> ./configure --prefix /opt/git
>>
>> in the past, without running "make distclean" afterwards, would
>> ex
On 07/19/2012 02:29 AM, Junio C Hamano wrote:
>
> The inconsistency between the existing one that does not quote the
> string that is not substituted, i.e.
>
> GIT_UC_PROGRAM[]_PATH=$withval
>
> and the new one that quotes _PATH, i.e.
>
> GIT_CONF_SUBST(GIT_UC_PROGRAM[_PATH], [])
>
On 07/19/2012 02:13 AM, Junio C Hamano wrote:
> Stefano Lattarini writes:
>
>> The new name fits better with the macro signature, and underlines the
>> similarities with the autoconf-provided macro AC_SUBST (which will be
>> made even more pronounced in planned future co
> Except for miniscule nits in the the bottom two, I didn't find
> anything objectionable---nicely done.
>
Thanks.
Here is the re-roll, which should address all the reported nits.
Stefano Lattarini (7):
autoconf: GIT_CONF_APPEND_LINE: change signature
autoconf: GIT_CO
From:
GIT_CONF_APPEND_LINE([VAR=VAL])
to:
GIT_CONF_APPEND_LINE([VAR], [VAL])
This is only a preparatory change in view of future refactorings.
No semantic change is intended. In fact, the generated configure
file doesn't change at all.
Signed-off-by: Stefano Latt
expected.
Signed-off-by: Stefano Lattarini
---
configure.ac | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/configure.ac b/configure.ac
index 5f63269..02b9a49 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3,8 +3,8 @@
## Definitions of private
They are merely useless now, but would get in the way of future changes.
No semantic change is intended.
Signed-off-by: Stefano Lattarini
---
configure.ac | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/configure.ac b/configure.ac
index 02b9a49..200776f 100644
This will allow "./config.status --recheck; ./config.status" to work
correctly as a mean of reconfiguring the tree with the same configure
argument used in the previous "./configure" invocation.
Signed-off-by: Stefano Lattarini
---
configure.ac | 28 +---
manual
configuration won't be negatively impacted.
Signed-off-by: Stefano Lattarini
---
Makefile | 12
configure.ac | 2 ++
2 files changed, 14 insertions(+)
diff --git a/Makefile b/Makefile
index 88a76a3..f4e8fac 100644
--- a/Makefile
+++ b/Makefile
@@ -2158,6 +2158,18 @@
f '$HOME', thus installing git in the user's home
directory -- definitely unexpected.
Signed-off-by: Stefano Lattarini
---
Makefile | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 285c660..88a76a3 100644
--- a/Makefile
+++ b/Makefile
They are merely useless now, but would get in the way of future changes.
No semantic change is intended.
Signed-off-by: Stefano Lattarini
---
configure.ac | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 200776f..b453ba5 100644
--- a
On 07/19/2012 09:43 AM, Matthieu Moy wrote:
> Stefano Lattarini writes:
>
>> Should I add "Acked-by: Matthieu Moy" then? (Sorry if it's a dumb
>> question, but I'm not sure which the preferred policy is around here).
>
> Not necessarily needed if t
On 07/19/2012 07:24 PM, Junio C Hamano wrote:
> Stefano Lattarini writes:
>
>> On 07/19/2012 02:29 AM, Junio C Hamano wrote:
>>>
>>> The inconsistency between the existing one that does not quote the
>>> string that is not substituted, i.e.
>>>
&g
On 07/21/2012 05:50 PM, Jiang Xin wrote:
> Since we have additional shell wrappers (gettextln and eval_gettextln)
> for gettext, we need to take into account these wrapers
>
s/wrapers/wrappers/
Regards,
Stefano
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a me
On 07/21/2012 05:50 PM, Jiang Xin wrote:
> Gettext message in a shell script should not start with '-', one
> workaround is adding '--' between gettext and the message, like:
>
> gettext -- "--exec option ..."
>
> But due to a bug in the xgettext extraction, xgettext can not
> extract the act
On 07/21/2012 05:50 PM, Jiang Xin wrote:
> The obsolete LONG_USAGE variable has the following message in it:
>
> A'\''--B'\''--C'\''
>
> And such complex LONG_USAGE message will breaks xgettext when extract
>
s/extract/extracting/ I think.
> l10n messages. But if remove single quotes from th
On 07/21/2012 05:50 PM, Jiang Xin wrote:
> Signed-off-by: Jiang Xin
> ---
> git-am.sh | 11 +--
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/git-am.sh b/git-am.sh
> index b6a53..20c1a 100755
> --- a/git-am.sh
> +++ b/git-am.sh
> @@ -92,7 +92,7 @@ safe_to_abort () {
On 07/21/2012 05:50 PM, Jiang Xin wrote:
> Gettext message
>
s/message/messages/ I think.
> should not start with '-' nor '--'. Since the '-d' and
> '--dotest' options are not exist
>
s/are not/do not/
> in OPTIONS_SPEC variable,
>
s/OPTIONS_SPEC/the OPTIONS_SPEC/
> so it's safe to remove the bl
Hi Junio.
On 07/19/2012 09:50 AM, Stefano Lattarini wrote:
> Those filed
>
Oops, this should read "files", not "filed" ...
> hold variables, settings and information set by the
> configuration process run by './configure'; in Autotools-based
> b
Hi Junio. I've just noticed a minor typo in the commit message ...
On 07/19/2012 09:50 AM, Stefano Lattarini wrote:
> This provides a reduced but still useful sibling of the Automake's
> "automatic Makefile rebuild" feature. It's important to note that
> we
Some grammatical nits about the commit message. I hope this doesn't
come across as too picky/annoying ... And you might want to wait for
a native to confirm whether these nits are actually all warranted.
On 07/24/2012 10:00 AM, Jiang Xin wrote:
> Run
>
s/Run/Running/
> command 'git rev-parse --
On 07/24/2012 08:59 AM, Jiang Xin wrote:
> Since we have additional shell wrappers (gettextln and eval_gettextln)
> for gettext, we need to take into account these wrappers when run
>
s/when run/when running/ or s/when we run/.
Sorry for not spotting that in my first review!
> 'make pot' to extra
On 07/24/2012 08:59 AM, Jiang Xin wrote:
> Mark strings in git-rebase.sh for translation.
>
> Some test scripts are affected by this update, and would fail if are
>
s/if are/if/
> tested with GETTEXT_POISON switch turned on. Use i18n-specific test
>
s/Use/Using/, or s/Use/Use of/
> functions, su
On 07/24/2012 08:59 AM, Jiang Xin wrote:
> Gettext message in a shell script should not start with '-', one
>
I think using a semicolon instead of a comma after "one" here would
be clearer.
> workaround is adding '--' between gettext and the message, like:
>
> gettext -- "--exec option ..."
>
On 07/24/2012 08:59 AM, Jiang Xin wrote:
> Mark strings in merge-recursive for translation.
>
> Some test scripts are affected by this update, and would fail if are
> tested with GETTEXT_POISON switch turned on. Use i18n-specific test
> functions, such as test_i18ngrep in the related test scripts
Sorry to be so nit-picky, but ...
On 07/25/2012 05:53 AM, Jiang Xin wrote:
> Mark strings in 'git-am.sh' for translation. In the last chunk, I
> changed '$1' to '-b/--binary' for this reason:
>
> * First, if there is a variable in the l10n message, we could not use
>gettext. Because the vari
On 07/25/2012 05:14 AM, David Aguilar wrote:
> Symlinks are not ubiquitous on Windows so make --no-symlinks the default.
>
> Signed-off-by: David Aguilar
> ---
> I don't have cygwin so I can't verify this one myself.
> Is 'cygwin' really the value of $^O there?
>
Apparently yes:
$ uname -rso
On 02/20/2013 02:39 AM, Jiang Xin wrote:
>
> [SNIP]
>
> I am not familiar with autoconf. After clone autoconf and check,
> I cannot find a neat way to change "htmldir" default location to
> use ${datarootdir} (just like mandir).
>
This one-line change should be enough to do what you want:
diff
>From a pristine master checkout:
$ make configure && ./configure make
... # All successfull
$ touch configure.ac
$ make
GEN config.status
make[1]: Entering directory `/storage/home/stefano/git/src'
GEN config.status
make[2]: Entering directory `/storage/home/stefano/git/src'
On 02/20/2013 11:42 AM, Jiang Xin wrote:
> 2013/2/20 Stefano Lattarini :
>> On 02/20/2013 02:39 AM, Jiang Xin wrote:
>>>
>>> [SNIP]
>>>
>>> I am not familiar with autoconf. After clone autoconf and check,
>>> I cannot find a neat way to chan
98 matches
Mail list logo
