Re: [gwt-contrib] Re: Make GWT template javascript suitable for XHTML

The best way would be to upload a patch to http:// gwt-code-reviews.appspot.com/ . That makes it much easier to understand the diffs. Le 1 août 2010 11:07, Henri hfman...@gmail.com a écrit : I updated function computeScriptBase() in IFrameTemplate.js to work with DOM javascript functions

[gwt-contrib] Re: Enhancement for issue 4870 (issue732801)

LGTM with a nit. http://gwt-code-reviews.appspot.com/732801/diff/1/2 File user/src/com/google/gwt/user/client/rpc/StatusCodeException.java (right): http://gwt-code-reviews.appspot.com/732801/diff/1/2#newcode47 user/src/com/google/gwt/user/client/rpc/StatusCodeException.java:47: /** the

[gwt-contrib] Re: Enhancement for issue 4870 (issue732801)

http://gwt-code-reviews.appspot.com/732801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enhancement for issue 4870 (issue732801)

lgtm http://gwt-code-reviews.appspot.com/732801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: First pass at keyboard navigation (currently only for CellTable) (issue710802)

http://gwt-code-reviews.appspot.com/710802/diff/1/9 File user/src/com/google/gwt/user/cellview/client/CellTable.java (right): http://gwt-code-reviews.appspot.com/710802/diff/1/9#newcode527 user/src/com/google/gwt/user/cellview/client/CellTable.java:527: focusable.focus(); I think we should only

[gwt-contrib] Enhancement for issue 4870 (issue711802)

Reviewers: zundel, Description: Enhancement for issue 4870 Please review this at http://gwt-code-reviews.appspot.com/711802/show Affected files: M user/src/com/google/gwt/user/client/rpc/StatusCodeException.java Index: user/src/com/google/gwt/user/client/rpc/StatusCodeException.java

[gwt-contrib] Re: Enhancement for issue 4870 (issue711802)

lgtm http://gwt-code-reviews.appspot.com/711802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: First pass at keyboard navigation (currently only for CellTable) (issue710802)

http://gwt-code-reviews.appspot.com/710802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add a file check to handle edge cases like broken symbolic links when scanning directories for r... (issue711803)

Reviewers: scottb, Description: Add a file check to handle edge cases like broken symbolic links when scanning directories for resources. Review by: sco...@google.com Please review this at http://gwt-code-reviews.appspot.com/711803/show Affected files: M

[gwt-contrib] Re: First pass at keyboard navigation (currently only for CellTable) (issue710802)

LGTM http://gwt-code-reviews.appspot.com/710802/diff/1013/10009 File user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java (right): http://gwt-code-reviews.appspot.com/710802/diff/1013/10009#newcode536 user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java:536: Extra

[gwt-contrib] Re: First pass at keyboard navigation (currently only for CellTable) (issue710802)

Actually CellTreeNodeView is still work in progress and won't be submitted as part of the current CL. Sorry for the confusion. On Mon, Aug 2, 2010 at 12:14 PM, jlaba...@google.com wrote: LGTM http://gwt-code-reviews.appspot.com/710802/diff/1013/10009 File

[gwt-contrib] Remove 1.6isms from RequestFactory, and fix DynaTableRf (id's (issue721804)

Reviewers: bobv, Description: Remove 1.6isms from RequestFactory, and fix DynaTableRf (id's still must be Long, and at the moment it actually counts). Review by: robertvaw...@google.com Please review this at http://gwt-code-reviews.appspot.com/721804/show Affected files: M

[gwt-contrib] Re: Remove 1.6isms from RequestFactory, and fix DynaTableRf (id's (issue721804)

LGTM. http://gwt-code-reviews.appspot.com/721804/diff/1/2 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/domain/Person.java (right): http://gwt-code-reviews.appspot.com/721804/diff/1/2#newcode31 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/domain/Person.java:31: id

[gwt-contrib] Re: Adding support for non-propagating events in Cell based widgets. In modern browsers, we make the... (issue720801)

http://gwt-code-reviews.appspot.com/720801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change the way we include the User Auth files, keeping more of them (issue721803)

LGTM The problem with this approach is that it's so hugely prescriptive — there is one and only one way to deal with user auth in RequestFactory. I think it will do to get the conversation started in M3, but we'll need to find something more flexible before we ship.

[gwt-contrib] Re: Clean up JdtCompiler by moving out test-only code. (issue731801)

LGTM http://gwt-code-reviews.appspot.com/731801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removes the unnecessary ErrorCompilationUnit. (issue730801)

LGTM http://gwt-code-reviews.appspot.com/730801/diff/2001/3003 File dev/core/src/com/google/gwt/dev/javac/CompilationUnitImpl.java (right): http://gwt-code-reviews.appspot.com/730801/diff/2001/3003#newcode74 dev/core/src/com/google/gwt/dev/javac/CompilationUnitImpl.java:74: return hasErrors;

[gwt-contrib] Re: Support for custom MenuItem, MenuItemSeparator and MenuBar. (issue702803)

Actually, one tweak if you don't mind. http://gwt-code-reviews.appspot.com/702803/diff/1/3 File user/src/com/google/gwt/uibinder/elementparsers/MenuBarParser.java (right): http://gwt-code-reviews.appspot.com/702803/diff/1/3#newcode36

[gwt-contrib] Re: Change the way we include the User Auth files, keeping more of them (issue721803)

On 2010/08/02 17:32:43, Ray Ryan wrote: LGTM The problem with this approach is that it's so hugely prescriptive —nbsp;there is one and only one way to deal with user auth in RequestFactory. I think it will do to get the conversation started in M3, but we'll need to find something more

[gwt-contrib] Re: Change the way we include the User Auth files, keeping more of them (issue721803)

http://gwt-code-reviews.appspot.com/721803/diff/1/7 File bikeshed/src/com/google/gwt/sample/expenses/server/domain/GaeUserInformation.java (right): http://gwt-code-reviews.appspot.com/721803/diff/1/7#newcode72 bikeshed/src/com/google/gwt/sample/expenses/server/domain/GaeUserInformation.java:72:

[gwt-contrib] Finish modernizing the DynaTableRF sample to use an event-based application model. (issue733802)

Reviewers: Ray Ryan, Description: Finish modernizing the DynaTableRF sample to use an event-based application model. Patch by: bobv Review by: rjrjr Please review this at http://gwt-code-reviews.appspot.com/733802/show Affected files: M

[gwt-contrib] Re: Change the way we include the User Auth files, keeping more of them (issue721803)

On 2010/08/02 17:55:43, unnurg wrote: http://gwt-code-reviews.appspot.com/721803/diff/1/7 File bikeshed/src/com/google/gwt/sample/expenses/server/domain/GaeUserInformation.java (right): http://gwt-code-reviews.appspot.com/721803/diff/1/7#newcode72

[gwt-contrib] Re: Add the ability to change the size of a widget in the (issue719802)

http://gwt-code-reviews.appspot.com/719802/diff/1/2 File user/src/com/google/gwt/user/client/ui/DockLayoutPanel.java (right): http://gwt-code-reviews.appspot.com/719802/diff/1/2#newcode315 user/src/com/google/gwt/user/client/ui/DockLayoutPanel.java:315: public void setWidgetSize(Widget widget,

[gwt-contrib] Re: Change the way we include the User Auth files, keeping more of them (issue721803)

On 2010/08/02 18:10:21, unnurg wrote: On 2010/08/02 17:55:43, unnurg wrote: http://gwt-code-reviews.appspot.com/721803/diff/1/7 File bikeshed/src/com/google/gwt/sample/expenses/server/domain/GaeUserInformation.java (right): http://gwt-code-reviews.appspot.com/721803/diff/1/7#newcode72

[gwt-contrib] Re: Change the way we include the User Auth files, keeping more of them (issue721803)

http://gwt-code-reviews.appspot.com/721803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change the way we include the User Auth files, keeping more of them (issue721803)

On 2010/08/02 18:14:47, unnurg wrote: On 2010/08/02 18:10:21, unnurg wrote: On 2010/08/02 17:55:43, unnurg wrote: http://gwt-code-reviews.appspot.com/721803/diff/1/7 File bikeshed/src/com/google/gwt/sample/expenses/server/domain/GaeUserInformation.java (right):

[gwt-contrib] Re: Finish modernizing the DynaTableRF sample to use an event-based application model. (issue733802)

http://gwt-code-reviews.appspot.com/733802/diff/1/3 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DayCheckBox.java (right): http://gwt-code-reviews.appspot.com/733802/diff/1/3#newcode38 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DayCheckBox.java:38:

[gwt-contrib] Re: Change the way we include the User Auth files, keeping more of them (issue721803)

LGTM On Mon, Aug 2, 2010 at 11:26 AM, unn...@google.com wrote: On 2010/08/02 18:14:47, unnurg wrote: On 2010/08/02 18:10:21, unnurg wrote: On 2010/08/02 17:55:43, unnurg wrote: http://gwt-code-reviews.appspot.com/721803/diff/1/7 File

[gwt-contrib] Re: Enhancement for issue 4870 (issue732801)

I didn't realize issue 4870 existed or I would have commented on it long ago. In our world, we like to set the HTTP response code to a non-SC_OK response when the RPC service throws an Exception. This way we can easily grep our access.log for failed responses. An the Exception might be whatever

[gwt-contrib] SpeedTracerLogger: Don't throw exceptions on missed events. Instead, try to recover gracefully. (issue674805)

Reviewers: zundel, Description: SpeedTracerLogger: Don't throw exceptions on missed events. Instead, try to recover gracefully. Review by: zun...@google.com Please review this at http://gwt-code-reviews.appspot.com/674805/show Affected files: M

[gwt-contrib] Re: SpeedTracerLogger: Don't throw exceptions on missed events. Instead, try to recover gracefully. (issue674805)

http://gwt-code-reviews.appspot.com/674805/diff/1/2 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/674805/diff/1/2#newcode310 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:310: This is

[gwt-contrib] Re: Change the way we include the User Auth files, keeping more of them (issue721803)

http://gwt-code-reviews.appspot.com/721803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Put in a new fix for DevMode logging that uses bytecode rewriting rather than swapping out (issue725801)

LGTM http://gwt-code-reviews.appspot.com/725801/diff/12001/13006 File dev/core/src/com/google/gwt/dev/shell/rewrite/UseMirroredClasses.java (right): http://gwt-code-reviews.appspot.com/725801/diff/12001/13006#newcode43 dev/core/src/com/google/gwt/dev/shell/rewrite/UseMirroredClasses.java:43: {

[gwt-contrib] Made the error messages thrown in case of GWTTestCase timeouts more informative, as requested in (issue734801)

Reviewers: mmendez, Description: Made the error messages thrown in case of GWTTestCase timeouts more informative, as requested in http://code.google.com/p/google-web-toolkit/issues/detail?id=4099 Patch by: amitmanjhi Review by: mmendez Please review this at

[gwt-contrib] Re: Clean up JdtCompiler by moving out test-only code. (issue731801)

I'm going to have to abandon this change. Turns out the api-checker tool uses this API. :( http://gwt-code-reviews.appspot.com/731801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add SpeedTracerLogger instrumentation to DevMode (issue704802)

Reviewers: zundel, Description: Add SpeedTracerLogger instrumentation to DevMode Please review this at http://gwt-code-reviews.appspot.com/704802/show Affected files: M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M

[gwt-contrib] Re: SpeedTracerLogger: Don't throw exceptions on missed events. Instead, try to recover gracefully. (issue674805)

http://gwt-code-reviews.appspot.com/674805/diff/1/2 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/674805/diff/1/2#newcode310 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:310: On

[gwt-contrib] Re: Add SpeedTracerLogger instrumentation to DevMode (issue704802)

http://gwt-code-reviews.appspot.com/704802/diff/1/15 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/DevModeEventType.java (right): http://gwt-code-reviews.appspot.com/704802/diff/1/15#newcode24 dev/core/src/com/google/gwt/dev/util/log/speedtracer/DevModeEventType.java:24: public enum

[gwt-contrib] Re: Change RequestFactory based requests: (issue674804)

Overall, looks good. Thanks for the patch Fred. Minor refactoring suggestions below. Instead of making checkContentType and checkCharacterEncoding public and deprecated, would it be better to add another option of expectedContentType to readContentAsUtf8, and just do everything there? (the

[gwt-contrib] Re: Put in a new fix for DevMode logging that uses bytecode rewriting rather than swapping out (issue725801)

http://gwt-code-reviews.appspot.com/725801/diff/12001/13004 File dev/core/src/com/google/gwt/dev/shell/GWTBridgeImpl.java (right): http://gwt-code-reviews.appspot.com/725801/diff/12001/13004#newcode26 dev/core/src/com/google/gwt/dev/shell/GWTBridgeImpl.java:26: protected static

[gwt-contrib] Re: SpeedTracerLogger: Don't throw exceptions on missed events. Instead, try to recover gracefully. (issue674805)

On 2010/08/02 19:30:20, zundel wrote: http://gwt-code-reviews.appspot.com/674805/diff/1/2 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/674805/diff/1/2#newcode310

[gwt-contrib] Re: SpeedTracerLogger: Don't throw exceptions on missed events. Instead, try to recover gracefully. (issue674805)

LGTM http://gwt-code-reviews.appspot.com/674805/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add SpeedTracerLogger instrumentation to DevMode (issue704802)

lgtm, make sure ModuleDefLoader.java is synced up. http://gwt-code-reviews.appspot.com/704802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add SpeedTracerLogger instrumentation to DevMode (issue704802)

the only real change in this is the ModuleDefLoader stuff. the rest is sync'ing to HEAD and rietveld bugginess http://gwt-code-reviews.appspot.com/704802/diff/6001/4002 File dev/core/src/com/google/gwt/dev/Compiler.java (right):

[gwt-contrib] Re: Add SpeedTracerLogger instrumentation to DevMode (issue704802)

http://gwt-code-reviews.appspot.com/704802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Create a red dev mode glass panel when hosted mode fails to load your module, similar to the gra... (issue730802)

LGTM, but we should prefix the method with __gwt_ for namespacing. http://gwt-code-reviews.appspot.com/730802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Create a red dev mode glass panel when hosted mode fails to load your module, similar to the gra... (issue730802)

http://gwt-code-reviews.appspot.com/730802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Finish modernizing the DynaTableRF sample to use an event-based application model. (issue733802)

http://gwt-code-reviews.appspot.com/733802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Finish modernizing the DynaTableRF sample to use an event-based application model. (issue733802)

New patch uploaded. http://gwt-code-reviews.appspot.com/733802/diff/1/3 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DayCheckBox.java (right): http://gwt-code-reviews.appspot.com/733802/diff/1/3#newcode38

[gwt-contrib] Re: Finish modernizing the DynaTableRF sample to use an event-based application model. (issue733802)

LGTM This is turning into a pretty nice sample! http://gwt-code-reviews.appspot.com/733802/diff/1020/8001 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java (right): http://gwt-code-reviews.appspot.com/733802/diff/1020/8001#newcode76

[gwt-contrib] Re: Change RequestFactory based requests: (issue674804)

http://gwt-code-reviews.appspot.com/674804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change RequestFactory based requests: (issue674804)

How's this? http://gwt-code-reviews.appspot.com/674804 On Mon, Aug 2, 2010 at 5:46 PM, fre...@google.com wrote: http://gwt-code-reviews.appspot.com/674804/show -- Fred Sauer Developer Advocate Google Inc. 1600 Amphitheatre Parkway Mountain View, CA 94043 fre...@google.com --

[gwt-contrib] Re: Change RequestFactory based requests: (issue674804)

I like the refactoring. Some more nits below. Please feel free to submit after fixing them. LGTM http://gwt-code-reviews.appspot.com/674804/diff/9001/10002 File user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java (right):

[gwt-contrib] Re: Change RequestFactory based requests: (issue674804)

http://gwt-code-reviews.appspot.com/674804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change RequestFactory based requests: (issue674804)

LGTM http://gwt-code-reviews.appspot.com/674804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change RequestFactory based requests: (issue674804)

http://gwt-code-reviews.appspot.com/674804/diff/9001/10002 File user/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java (right): http://gwt-code-reviews.appspot.com/674804/diff/9001/10002#newcode96

[gwt-contrib] Re: Change RequestFactory based requests: (issue674804)

http://gwt-code-reviews.appspot.com/674804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8451 committed - Rolling back the following change due to failing tests...

Revision: 8451 Author: fre...@google.com Date: Fri Jul 30 15:19:42 2010 Log: Rolling back the following change due to failing tests Add two new ClientBundle DataResource annotations: 1. @DoNotEmbed which allows a DataResource to be designated as not embeddable 2. @MimeType(String) which allows