[gwt-contrib] [conference]

2010-09-09 Thread nicolas de loof
For info, I'll speak at JugSummerCamp http://www.jugsummercamp.org/ conference tomorrow on GWT 2. Long live GWT :D Nicolas -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] [conference]

2010-09-09 Thread Joel Webber
Allez Nicolas! Le 9 septembre 2010 09:18, nicolas de loof nicolas.del...@gmail.com a écrit : For info, I'll speak at JugSummerCamp http://www.jugsummercamp.org/ conference tomorrow on GWT 2. Long live GWT :D Nicolas -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --

Re: [gwt-contrib] incubator and compatability with gwt 2.1

2010-09-09 Thread Isaac Truett
There isn't one. Incubator is dead. On Thu, Sep 9, 2010 at 7:10 AM, Cameron Braid came...@braid.com.au wrote: What is the plan to bring incubator into compatability with gwt 2.1 ? Cheers Cameron -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --

[gwt-contrib] [google-web-toolkit] r8737 committed - Fix bug 2822942 Remove calls to System.currentTimeMillis in tests...

2010-09-09 Thread codesite-noreply
Revision: 8737 Author: zh...@google.com Date: Thu Sep 9 05:17:25 2010 Log: Fix bug 2822942 Remove calls to System.currentTimeMillis in tests Review at http://gwt-code-reviews.appspot.com/849801 http://code.google.com/p/google-web-toolkit/source/detail?r=8737 Modified:

[gwt-contrib] Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-09 Thread rjrjr
Reviewers: bobv, jlabanca, Description: Adds dual key (type + source) handler binding to EventBus. RequestFactory sets the class of a proxy type as the source for EntityProxyChange events, so that subscribers can still listen for events only of specific proxy types. It is no longer necessary

[gwt-contrib] Re: Uibinder parser api

2010-09-09 Thread Thomas Broyer
On Sep 9, 1:45 pm, Konstantin.Scheglov konstantin.scheg...@gmail.com wrote: If anyone wants to submit a patch to make it possible to subclass UiBinderGenerator and tweak its parsers that way, s.t. you can provide an alternative replace-with rule for your custom subclass, I'd be in favor of

Re: [gwt-contrib] Re: Uibinder parser api

2010-09-09 Thread Ray Ryan
It's not about the lack of a plugin mechanism, it's about discomfort with an api that requires people to emit lines of java too much, and lack of time to clean it up. On Thu, Sep 9, 2010 at 9:22 AM, Thomas Broyer t.bro...@gmail.com wrote: On Sep 9, 1:45 pm, Konstantin.Scheglov

[gwt-contrib] Adds a cheesey uncaught exception handler to DynaTableRF. (issue832802)

2010-09-09 Thread rjrjr
Reviewers: bobv, Description: Adds a cheesey uncaught exception handler to DynaTableRF. Please review this at http://gwt-code-reviews.appspot.com/832802/show Affected files: M samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DynaTableRf.java Index:

[gwt-contrib] Re: Adds a cheesey uncaught exception handler to DynaTableRF. (issue832802)

2010-09-09 Thread bobv
LGTM http://gwt-code-reviews.appspot.com/832802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Converts two new files from dos EOL format to unix EOL format. (issue854801)

2010-09-09 Thread kprobst
Reviewers: kjin, Description: Converts two new files from dos EOL format to unix EOL format. Review by: k...@google.com Please review this at http://gwt-code-reviews.appspot.com/854801/show Affected files: M user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorGenerator.java M

[gwt-contrib] Re: Converts two new files from dos EOL format to unix EOL format. (issue854801)

2010-09-09 Thread kjin
LGTM http://gwt-code-reviews.appspot.com/854801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-09 Thread bobv
http://gwt-code-reviews.appspot.com/841804/diff/1/4 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/SummaryWidget.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/4#newcode185

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-09 Thread bobv
Comments for SimpleEventBus. http://gwt-code-reviews.appspot.com/841804/diff/1/24 File user/src/com/google/gwt/event/shared/SimpleEventBus.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/24#newcode36 user/src/com/google/gwt/event/shared/SimpleEventBus.java:36: // Add and remove

[gwt-contrib] Enum name obfuscation option. Addresses issue 2387369 (issue827802)

2010-09-09 Thread jbrosenberg
Reviewers: scottb, cromwellian, robertvawter, Description: Enum name obfuscation option. Addresses issue 2387369 Public: Enum name obfuscation. Added configuration property (compiler.enum.obfuscate.names) to optionally obfuscatate enum names from production output. Please review this at

[gwt-contrib] Re: Add ListEditor adapter implemented on top of a new CompositeEditor core (issue848801)

2010-09-09 Thread rjrjr
I think LGTM, but could you help me understand CompositeEditor and CompositeEditor.Chain first? http://gwt-code-reviews.appspot.com/848801/diff/1/2 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/AddressEditor.java (right):

[gwt-contrib] Re: Add SafeHtml support to UI widgets (2) (issue847801)

2010-09-09 Thread pdr
http://gwt-code-reviews.appspot.com/847801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Update HistoryTest to ensure that non-safari browsers also: (issue855801)

2010-09-09 Thread fredsa
Reviewers: scottb, Description: Update HistoryTest to ensure that non-safari browsers also: - run testHistory - verify the current hash value as part of testTokenEscaping and testTokenNonescaping Please review this at http://gwt-code-reviews.appspot.com/855801/show Affected files: M

[gwt-contrib] Delay start of history token transitions in HistoryTest.testHistory() so that when tokens are lo... (issue850802)

2010-09-09 Thread fredsa
Reviewers: kathrin, Description: Delay start of history token transitions in HistoryTest.testHistory() so that when tokens are lost during subsequent parts of the test, History.back() does not go back too far (i.e. before the web page containing the test module), which would cause subsequent

[gwt-contrib] Re: Delay start of history token transitions in HistoryTest.testHistory() so that when tokens are lo... (issue850802)

2010-09-09 Thread kprobst
LGTM http://gwt-code-reviews.appspot.com/850802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update HistoryTest to ensure that non-safari browsers also: (issue855801)

2010-09-09 Thread scottb
LGTM http://gwt-code-reviews.appspot.com/855801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add ListEditor adapter implemented on top of a new CompositeEditor core (issue848801)

2010-09-09 Thread bobv
http://gwt-code-reviews.appspot.com/848801/diff/1/5 File user/src/com/google/gwt/editor/client/CompositeEditor.java (right): http://gwt-code-reviews.appspot.com/848801/diff/1/5#newcode20 user/src/com/google/gwt/editor/client/CompositeEditor.java:20: * some other type. * An interface that

[gwt-contrib] Move the packages to include in the javadoc out of the build.xml file and into a properties file. (issue856801)

2010-09-09 Thread bobv
Reviewers: fabbott, Description: Move the packages to include in the javadoc out of the build.xml file and into a properties file. Patch by: bobv Review by: fabbott Please review this at http://gwt-code-reviews.appspot.com/856801/show Affected files: M doc/build.xml A

[gwt-contrib] Re: Adds a -strict option to the GWT compiler. If this option is specified, (issue853801)

2010-09-09 Thread Scott Blum
High-level comments: - CompilationState doesn't really need the extra API, because you can always just iterate through the returned collection looking for errors. Arguably, this would take a few extra cycles, but I've kinda been wanting to move the error reporting out CompilationState anyway

[gwt-contrib] Re: Enum name obfuscation option. Addresses issue 2387369 (issue827802)

2010-09-09 Thread Scott Blum
LGTM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enum name obfuscation option. Addresses issue 2387369 (issue827802)

2010-09-09 Thread jbrosenberg
http://gwt-code-reviews.appspot.com/827802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: TypeSerializerCreator generates pure Java code path for DevMode. (issue831801)

2010-09-09 Thread scottb
Fix for inaccessible types, and also fix a generics issue. http://gwt-code-reviews.appspot.com/831801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r8739 committed - Allow Checkbox to accept null as valid....

2010-09-09 Thread codesite-noreply
Revision: 8739 Author: cromwell...@google.com Date: Thu Sep 9 10:59:13 2010 Log: Allow Checkbox to accept null as valid. Review at http://gwt-code-reviews.appspot.com/831803 Review by: rj...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8739 Modified:

[gwt-contrib] Re: Enum name obfuscation option. Addresses issue 2387369 (issue827802)

2010-09-09 Thread bobv
Foodback from IM discussion. http://gwt-code-reviews.appspot.com/827802/diff/4001/5007 File user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java (right): http://gwt-code-reviews.appspot.com/827802/diff/4001/5007#newcode76

[gwt-contrib] JsArray enhancement

2010-09-09 Thread Sebastian
I wanted to provide a patch for JsArray* to support common methods like sort and reverse. I found the issue http://code.google.com/p/google-web-toolkit/issues/detail?id=2793 which is not completed and wants to provide all ECMA methods. I had a look at the existing patch and found code that I

[gwt-contrib] Re: Fix memory leaks in DevMode (issue766803)

2010-09-09 Thread conroy
For posterity, this issue was superceded by http://gwt-code-reviews.appspot.com/826802/show On 2010/08/23 20:29:44, conroy wrote: Discussed in person with jat and scottb: Tests are failing for this change because the ThreadLocal assumptions don't actually hold under JUnit. As a result, I'm

[gwt-contrib] Improve locale handling for default scripts and languages where some (issue851802)

2010-09-09 Thread jat
Reviewers: pdr, Description: Improve locale handling for default scripts and languages where some scripts are written RTL even if the language isn't RTL in general. Patch by: jat Review by: pdr Please review this at http://gwt-code-reviews.appspot.com/851802/show Affected files: A

[gwt-contrib] Re: Add ListEditor adapter implemented on top of a new CompositeEditor core (issue848801)

2010-09-09 Thread Ray Ryan
LGTM On Thu, Sep 9, 2010 at 12:04 PM, b...@google.com wrote: http://gwt-code-reviews.appspot.com/848801/diff/1/5 File user/src/com/google/gwt/editor/client/CompositeEditor.java (right): http://gwt-code-reviews.appspot.com/848801/diff/1/5#newcode20

[gwt-contrib] [google-web-toolkit] r8741 committed - Adds a cheesey uncaught exception handler to DynaTableRF....

2010-09-09 Thread codesite-noreply
Revision: 8741 Author: rj...@google.com Date: Thu Sep 9 13:25:50 2010 Log: Adds a cheesey uncaught exception handler to DynaTableRF. Review at http://gwt-code-reviews.appspot.com/832802 Review by: robertvaw...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8741

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-09 Thread rjrjr
I believe I've addressed what should be addressed. What say you? http://gwt-code-reviews.appspot.com/841804/diff/1/4 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/SummaryWidget.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/4#newcode185

[gwt-contrib] Re: Adds dual key (type + source) handler binding to EventBus. (issue841804)

2010-09-09 Thread bobv
LGTM http://gwt-code-reviews.appspot.com/841804/diff/1/19 File user/src/com/google/gwt/event/shared/AbstractEventBus.java (right): http://gwt-code-reviews.appspot.com/841804/diff/1/19#newcode8 user/src/com/google/gwt/event/shared/AbstractEventBus.java:8: public abstract class AbstractEventBus

[gwt-contrib] Re: Move the packages to include in the javadoc out of the build.xml file and into a properties file. (issue856801)

2010-09-09 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/856801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update HistoryTest to ensure that non-safari browsers also: (issue855801)

2010-09-09 Thread fredsa
http://gwt-code-reviews.appspot.com/855801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Renamed getStableId() to stableId() (issue857801)

2010-09-09 Thread amitmanjhi
Reviewers: rjrjr, Description: Renamed getStableId() to stableId() Patch by: amitmanjhi Review (and suggested) by: rjrjr Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/857801/show Affected files: M

[gwt-contrib] Re: Update HistoryTest to ensure that non-safari browsers also: (issue855801)

2010-09-09 Thread scottb
Still LGTM. May want to file a bug against HtmlUnit. http://gwt-code-reviews.appspot.com/855801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Renamed getStableId() to stableId() (issue857801)

2010-09-09 Thread rjrjr
LGTM On 2010/09/10 00:37:20, amitmanjhi wrote: http://gwt-code-reviews.appspot.com/857801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enum name obfuscation option. Addresses issue 2387369 (issue827802)

2010-09-09 Thread jbrosenberg
http://gwt-code-reviews.appspot.com/827802/diff/4001/5007 File user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java (right): http://gwt-code-reviews.appspot.com/827802/diff/4001/5007#newcode76 user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java:76: //

[gwt-contrib] Re: Add SafeHtml support to UI widgets (2) (issue847801)

2010-09-09 Thread xtof
LGTM! http://gwt-code-reviews.appspot.com/847801/diff/8002/13005 File user/src/com/google/gwt/user/client/ui/Anchor.java (right): http://gwt-code-reviews.appspot.com/847801/diff/8002/13005#newcode117 user/src/com/google/gwt/user/client/ui/Anchor.java:117: this(html.asString(), true); This is

[gwt-contrib] [google-web-toolkit] r8743 committed - Removed the incomplete check that slipped in the last commit....

2010-09-09 Thread codesite-noreply
Revision: 8743 Author: amitman...@google.com Date: Thu Sep 9 16:14:51 2010 Log: Removed the incomplete check that slipped in the last commit. Patch by: amitmanjhi Review by: cromwellian (tbr) http://code.google.com/p/google-web-toolkit/source/detail?r=8743 Modified:

[gwt-contrib] [google-web-toolkit] r8744 committed - Delay start of history token transitions in HistoryTest.testHistory() ...

2010-09-09 Thread codesite-noreply
Revision: 8744 Author: fre...@google.com Date: Thu Sep 9 17:05:41 2010 Log: Delay start of history token transitions in HistoryTest.testHistory() so that when tokens are lost during subsequent parts of the test, History.back() does not go back too far (i.e. before the web page containing