[gwt-contrib] Switch RequestFactory to use the real ConstraintViolation instead of the hacky Violation interface. (issue1422809)

2011-04-21 Thread bobv
Reviewers: rjrjr, Message: Request requested. http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java File user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java (right):

[gwt-contrib] Add RequestContext.append() to allow actions across different domain service types to be combine... (issue1423805)

2011-04-21 Thread bobv
Reviewers: rjrjr, Description: Add RequestContext.append() to allow actions across different domain service types to be combined in a single HTTP request. Patch by: bobv Review by: rjrjr Please review this at http://gwt-code-reviews.appspot.com/1423805/ Affected files: M

[gwt-contrib] Re: Treats last modified time of jar file entries differently for purposes of computing staleness. (issue1422802)

2011-04-21 Thread zundel
http://gwt-code-reviews.appspot.com/1422802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Treats last modified time of jar file entries differently for purposes of computing staleness. (issue1422802)

2011-04-21 Thread zundel
This greatly simplifies the patch. I'm not sure the extra complexity and time spent to recover cached units by calculating their content ID again is worth it, given the infrequency of jar file updates in the wild.. http://gwt-code-reviews.appspot.com/1422802/ --

[gwt-contrib] Re: Treats last modified time of jar file entries differently for purposes of computing staleness. (issue1422802)

2011-04-21 Thread jbrosenberg
LGTM I think this is in practice a safe compromise. If a file within a jar changes, then all things in the jar will appear to be updated, but I think this is reasonable. Can refine in the future, to try to detect whether the date of an entry is 0 (or somehow invalid), and only revert to the

[gwt-contrib] Re: Move single jso logic from BasicWebModeCompiler to JavaToJavaScriptCompiler. (issue1428802)

2011-04-21 Thread bobv
LGTM http://gwt-code-reviews.appspot.com/1428802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding benchmarks to measure the performance of updating na existing tables. Also refactored Wid... (issue1419801)

2011-04-21 Thread rjrjr
Jaime, can you take this? http://gwt-code-reviews.appspot.com/1419801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding benchmarks to measure the performance of updating na existing tables. Also refactored Wid... (issue1419801)

2011-04-21 Thread jlabanca
Jaime and I are going to look at the benchmarks when we have more time. http://gwt-code-reviews.appspot.com/1419801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: MobileWebApp sample. Showcases GWT providing a single app providing specialized views for Deskto... (issue1427803)

2011-04-21 Thread jlabanca
I forgot to check during the review, but we usually put the .project, .classpath, .checkstyle, .settings, and war directory in trunk/eclipse/samples/MobileWebApp http://gwt-code-reviews.appspot.com/1427803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Structural changes to UiBinder to make fields accessible via getters (issue1420804)

2011-04-21 Thread rjrjr
http://gwt-code-reviews.appspot.com/1420804/diff/7001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right):

[gwt-contrib] Re: Switch RequestFactory to use the real ConstraintViolation instead of the hacky Violation interface. (issue1422809)

2011-04-21 Thread Ray Ryan
Nick, could you take a look at this too? In particular see the bottom of http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java On Thu, Apr 21, 2011 at 6:57 AM, b...@google.com wrote: Reviewers: rjrjr, Message:

Re: [gwt-contrib] Re: Wrap low-priorty log calls with an 'if' test to avoid unnecessary calls (issue1426802)

2011-04-21 Thread Eric Ayers
On Thu, Apr 21, 2011 at 1:50 PM, Daniel Rice (דניאל רייס) r...@google.com wrote:  I ran a Showcase compile with log level 'info' 4 times each way, and took the average of the 3 best times for each way: Without 'if' tests: 396 seconds With 'if' tests: 350 seconds wow, this is fantastic.

[gwt-contrib] Re: MobileWebApp sample. Showcases GWT providing a single app providing specialized views for Deskto... (issue1427803)

2011-04-21 Thread Rodrigo Chandia
Yes, I'll make a patch with those files. I held on that until I could test GPE with the fix for the validation jars On Thu, Apr 21, 2011 at 1:42 PM, jlaba...@google.com wrote: I forgot to check during the review, but we usually put the .project, .classpath, .checkstyle, .settings, and war

[gwt-contrib] Re: Switch RequestFactory to use the real ConstraintViolation instead of the hacky Violation interface. (issue1422809)

2011-04-21 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java File user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java (right):

[gwt-contrib] Re: Treats last modified time of jar file entries differently for purposes of computing staleness. (issue1422802)

2011-04-21 Thread scottb
LVGTM http://gwt-code-reviews.appspot.com/1422802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10050 committed - Move single jso logic from BasicWebModeCompiler to JavaToJavaScriptCom...

2011-04-21 Thread codesite-noreply
Revision: 10050 Author: gwt.mirror...@gmail.com Date: Thu Apr 21 12:23:11 2011 Log: Move single jso logic from BasicWebModeCompiler to JavaToJavaScriptCompiler. http://gwt-code-reviews.appspot.com/1428802 Review by: robertvaw...@google.com

[gwt-contrib] Re: Structural changes to UiBinder to make fields accessible via getters (issue1420804)

2011-04-21 Thread hermes
http://gwt-code-reviews.appspot.com/1420804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add RequestContext.append() to allow actions across different domain service types to be combine... (issue1423805)

2011-04-21 Thread rjrjr
LGTM Wow. Wow. This is a very big deal, and from such a simple change! The patch includes its own demonstration of why it matters. Look at RequestFactoryTestBase. It's an asynchronous test that can't declare itself to be finished until two separate reset() messages are acknowledged by the

[gwt-contrib] Re: Structural changes to UiBinder to make fields accessible via getters (issue1420804)

2011-04-21 Thread hermes
http://gwt-code-reviews.appspot.com/1420804/diff/7001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right):

[gwt-contrib] Re: Structural changes to UiBinder to make fields accessible via getters (issue1420804)

2011-04-21 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/1420804/diff/7001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right):

[gwt-contrib] Re: MobileWebApp sample. Showcases GWT providing a single app providing specialized views for Deskto... (issue1427803)

2011-04-21 Thread rjrjr
I just realized that I don't like the name of this sample. It's not just about being a mobile app. It's about being a well architected one, which provides both a mobile and desktop UI. Shall we call it tasks instead? http://gwt-code-reviews.appspot.com/1427803/ --

[gwt-contrib] no warnings in mobile sample (issue1427806)

2011-04-21 Thread rjrjr
Reviewers: rchandia, Description: no warnings in mobile sample Please review this at http://gwt-code-reviews.appspot.com/1427806/ Affected files: M samples/mobilewebapp/src/com/google/gwt/sample/mobilewebapp/client/MobileWebAppShellBase.java M

[gwt-contrib] Re: no warnings in mobile sample (issue1427806)

2011-04-21 Thread rjrjr
Review, please. http://gwt-code-reviews.appspot.com/1427806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10052 committed - Add RequestContext.append() to allow actions across different domain s...

2011-04-21 Thread codesite-noreply
Revision: 10052 Author: gwt.mirror...@gmail.com Date: Thu Apr 21 15:19:33 2011 Log: Add RequestContext.append() to allow actions across different domain service types to be combined in a single HTTP request. Patch by: bobv Review by: rjrjr Review at

[gwt-contrib] Re: Add RequestContext.append() to allow actions across different domain service types to be combine... (issue1423805)

2011-04-21 Thread bobv
r10052 http://gwt-code-reviews.appspot.com/1423805/diff/1/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java File user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java (right):

[gwt-contrib] Re: Switch RequestFactory to use the real ConstraintViolation instead of the hacky Violation interface. (issue1422809)

2011-04-21 Thread bobv
r10053 http://gwt-code-reviews.appspot.com/1422809/diff/1/user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java File user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java (right):

[gwt-contrib] Re: Add RequestContext.append() to allow actions across different domain service types to be combine... (issue1423805)

2011-04-21 Thread t . broyer
On 2011/04/21 19:36:37, rjrjr wrote: LGTM Wow. Wow. This is a very big deal, and from such a simple change! Which to me leaves the question: is our usage described at [1] an intended use case, that's here to stay? or simply a fortunate unspecified behavior, and we should change our code to

[gwt-contrib] Re: no warnings in mobile sample (issue1427806)

2011-04-21 Thread rchandia
LGTM http://gwt-code-reviews.appspot.com/1427806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: no warnings in mobile sample (issue1427806)

2011-04-21 Thread rjrjr
r10054 http://gwt-code-reviews.appspot.com/1427806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Create a utility class for checking assignability of types for use (issue1420808)

2011-04-21 Thread jat
Reviewers: rjrjr, Description: Create a utility class for checking assignability of types for use in finding compatible constructors/methods. Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/1420808/ Affected files: M

[gwt-contrib] Re: Create a utility class for checking assignability of types for use (issue1420808)

2011-04-21 Thread rjrjr
Thanks John, this will be really handy. http://gwt-code-reviews.appspot.com/1420808/diff/1/user/src/com/google/gwt/uibinder/rebind/TypeOracleUtils.java File user/src/com/google/gwt/uibinder/rebind/TypeOracleUtils.java (right):

[gwt-contrib] Re: Create a utility class for checking assignability of types for use (issue1420808)

2011-04-21 Thread jat
http://gwt-code-reviews.appspot.com/1420808/diff/1/user/src/com/google/gwt/uibinder/rebind/TypeOracleUtils.java File user/src/com/google/gwt/uibinder/rebind/TypeOracleUtils.java (right):

[gwt-contrib] Re: Create a utility class for checking assignability of types for use (issue1420808)

2011-04-21 Thread jat
http://gwt-code-reviews.appspot.com/1420808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Create a utility class for checking assignability of types for use (issue1420808)

2011-04-21 Thread Ray Ryan
On Thu, Apr 21, 2011 at 6:54 PM, j...@google.com wrote: http://gwt-code-reviews.appspot.com/1420808/diff/1/user/src/com/google/gwt/uibinder/rebind/TypeOracleUtils.java File user/src/com/google/gwt/uibinder/rebind/TypeOracleUtils.java (right):

[gwt-contrib] Re: Create a utility class for checking assignability of types for use (issue1420808)

2011-04-21 Thread jat
http://gwt-code-reviews.appspot.com/1420808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Create a utility class for checking assignability of types for use (issue1420808)

2011-04-21 Thread jat
http://gwt-code-reviews.appspot.com/1420808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Create a utility class for checking assignability of types for use (issue1420808)

2011-04-21 Thread Ray Ryan
LGTM On Thu, Apr 21, 2011 at 9:24 PM, j...@google.com wrote: http://gwt-code-reviews.appspot.com/1420808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors