http://gwt-code-reviews.appspot.com/130806/diff/1/2
File dev/core/src/com/google/gwt/core/ext/ServletContainerLauncher.java
(left):
http://gwt-code-reviews.appspot.com/130806/diff/1/2#oldcode26
Line 26:
Can you add an implementation note here that in order to preserve
backwards compatibility:
I agree with Lex about the node-building functions.
While those few can be technically static, I don't see how making them
so improves any dependencies anywhere. (I.E. I don't see any cases where
we no longer have to pass around a JProgram). It also seems like a weird
dichotomy for some of the
LGTM
http://gwt-code-reviews.appspot.com/312804/diff/1/2
File user/test/com/google/gwt/dev/jjs/test/CoverageTest.java (left):
http://gwt-code-reviews.appspot.com/312804/diff/1/2#oldcode185
user/test/com/google/gwt/dev/jjs/test/CoverageTest.java:185:
assertEquals(c, e.getMessage());
The
/JTypeOracle.java:880: //
TODO(tobyr) I don't know under what situations it is safe to assume
On 2010/06/03 20:48:04, bobv wrote:
Block comment.
Scott will do. :)
http://gwt-code-reviews.appspot.com/589801/diff/1/7
File dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java
(right):
http://gwt
What about also making Object.getClass() final? That can't be a breaking
API change, because people had to be compiling against the JRE in any
case, right?
http://gwt-code-reviews.appspot.com/658802/diff/1/3
File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
(right):
Reviewers: scottb,
Description:
Add numeric types required for autoboxing support to INDEX_TYPES_SET.
Please review this at http://gwt-code-reviews.appspot.com/658803/show
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
Index:
LGTM, with some nits.
http://gwt-code-reviews.appspot.com/675801/diff/1/3
File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
(right):
http://gwt-code-reviews.appspot.com/675801/diff/1/3#newcode701
dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java:701:
paramIt =
LGTM
http://gwt-code-reviews.appspot.com/676801/diff/1/4
File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java
(right):
http://gwt-code-reviews.appspot.com/676801/diff/1/4#newcode424
dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java:424:
// JsniMethodRef
Reviewers: scottb,
Description:
Do some cleanup on BuildTypeMap.
Please review this at http://gwt-code-reviews.appspot.com/691801/show
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/692801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/691801/diff/1/2
File dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java (right):
http://gwt-code-reviews.appspot.com/691801/diff/1/2#newcode497
dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java:497:
typeMap.get(superInterfaceBinding);
On
Reviewers: scottb,
Description:
Add first-class support for [array].length in the compiler.
Review by: sco...@google.com
Please review this at http://gwt-code-reviews.appspot.com/702801/show
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/ast/JVisitor.java
M
http://gwt-code-reviews.appspot.com/702801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/702801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/702801/diff/7001/8001
File dev/core/src/com/google/gwt/dev/jjs/ast/JArrayLength.java (right):
http://gwt-code-reviews.appspot.com/702801/diff/7001/8001#newcode26
dev/core/src/com/google/gwt/dev/jjs/ast/JArrayLength.java:26: * This can
only be null if the
http://gwt-code-reviews.appspot.com/702801/diff/17001/18004
File dev/core/src/com/google/gwt/dev/jjs/impl/ExpressionAnalyzer.java
(right):
http://gwt-code-reviews.appspot.com/702801/diff/17001/18004#newcode98
dev/core/src/com/google/gwt/dev/jjs/impl/ExpressionAnalyzer.java:98:
accessesField =
Reviewers: scottb,
Description:
Add some missing ASM classes
Review by: sco...@google.com
Please review this at http://gwt-code-reviews.appspot.com/699802/show
Affected files:
A dev/core/src/com/google/gwt/dev/asm/commons/JSRInlinerAdapter.java
A
Reviewers: robertvawter, mmendez,
Description:
Fixes a bug in the finally handling of doExecuteCommands which
unilaterally squashes exceptions. (Early returns from a finally block
via return statements or exceptions override pending exceptions).
Please review this at
Reviewers: scottb,
Description:
More steps toward separate compilation.
Please review this at http://gwt-code-reviews.appspot.com/702802/show
Affected files:
M dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java
M dev/core/src/com/google/gwt/dev/jdt/BasicWebModeCompiler.java
M
Reviewers: scottb,
Description:
Ensure bridgeMethods is initialized, even when constructed from other
subtypes, such as MissingTypeBinding.
Please review this at http://gwt-code-reviews.appspot.com/708802/show
Affected files:
M
LGTM
http://gwt-code-reviews.appspot.com/729801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/725801/diff/12001/13004
File dev/core/src/com/google/gwt/dev/shell/GWTBridgeImpl.java (right):
http://gwt-code-reviews.appspot.com/725801/diff/12001/13004#newcode26
dev/core/src/com/google/gwt/dev/shell/GWTBridgeImpl.java:26: protected
static
LGTM
http://gwt-code-reviews.appspot.com/725801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/752801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/752801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: scottb,
Description:
Support adding code-gen/runtime related classes directly to the
secondary JDT compilation for the GWT AST.
Please review this at http://gwt-code-reviews.appspot.com/830801/show
Affected files:
M dev/core/src/com/google/gwt/dev/jdt/BasicWebModeCompiler.java
Reviewers: zundel, scottb,
Description:
Reduces class and JSNI loading for RPC in devmode.
- Makes GwtScriptOnly work with JSNI methods.
- Modifies the RPC generator to tag native methods with GwtScriptOnly.
- Modifies the RPC generator to defer class loads of FieldSerializers
until needed.
http://gwt-code-reviews.appspot.com/1215801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1215801/diff/1/4
File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
(right):
http://gwt-code-reviews.appspot.com/1215801/diff/1/4#newcode231
dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:231:
http://gwt-code-reviews.appspot.com/1215801/diff/1/4
File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
(right):
http://gwt-code-reviews.appspot.com/1215801/diff/1/4#newcode231
dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:231:
http://gwt-code-reviews.appspot.com/1236801/diff/22001/6004
File
dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/22001/6004#newcode30
dev/core/src/com/google/gwt/dev/javac/rebind/CachedClientDataMap.java:30:
public
to confirm that. For example, a generator could use an annotation on a
private field to control behavior, right? Where do you think you're
excluding non-public members?
On 2011/01/04 21:39:06, tobyr wrote:
I think you need to reword this, since you're building the signature
based on
the type's
Overall LGTM with a few changes.
http://gwt-code-reviews.appspot.com/1254801/diff/14001/15001
File dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java
(right):
http://gwt-code-reviews.appspot.com/1254801/diff/14001/15001#newcode792
SGTM and code LGTM
On 2011/01/07 19:04:37, scottb wrote:
That seems good to me as a mid-term goal. Wouldn't this still be a
useful
stop-gap moving in that direction but with the current servlet spec?
On Fri, Jan 7, 2011 at 1:41 PM, Toby Reyelts mailto:to...@google.com
wrote:
It sounds
http://gwt-code-reviews.appspot.com/1264801/diff/1/2
File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (left):
http://gwt-code-reviews.appspot.com/1264801/diff/1/2#oldcode418
dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:418: public
synchronized void refresh(TreeLogger logger) {
http://gwt-code-reviews.appspot.com/1264801/diff/1/2
File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (left):
http://gwt-code-reviews.appspot.com/1264801/diff/1/2#oldcode418
dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java:418: public
synchronized void refresh(TreeLogger logger) {
On
LGTM
http://gwt-code-reviews.appspot.com/1268801/diff/1/2
File dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java (right):
http://gwt-code-reviews.appspot.com/1268801/diff/1/2#newcode29
dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java:29: * Returns
the equivalent of {...@link
Almost there
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40001
File dev/core/src/com/google/gwt/core/ext/typeinfo/JRealClassType.java
(right):
http://gwt-code-reviews.appspot.com/1236801/diff/39001/40001#newcode28
dev/core/src/com/google/gwt/core/ext/typeinfo/JRealClassType.java:28:
addByteCode(byte[] byteCode);
Sorted confusion out offline. In a nutshell, we should remove
addByteCode (not getTypeStrongHash).
On 2011/01/25 00:48:19, jbrosenberg wrote:
On 2011/01/24 19:14:07, tobyr wrote:
Why is this method in the public interface? Can we just remove it
and leave
LGTM given changes to ServletContainerLaunch and removal of
SecureServletContainerLauncher.
http://gwt-code-reviews.appspot.com/1324801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
SG, but why not extract it to a shared class instead of copying? The
index is immutable, and you'll end up building it twice (non-trivial
cost) with this change as it's currently written - once for
AbstractCompiler and once for JdtCompiler (right?).
LGTM now. I'll let you and Bob sort out the rest.
http://gwt-code-reviews.appspot.com/1236801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/01/26 23:15:56, scottb wrote:
I plan to kill AbstractCompiler soon :D
Ok, it's up to you then. I feel squirrely about committing something in
that state unless the next change is literally just hours out.
http://gwt-code-reviews.appspot.com/1318802/show
--
Overall LGTM.
http://gwt-code-reviews.appspot.com/1336801/diff/1/2
File dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java
(right):
http://gwt-code-reviews.appspot.com/1336801/diff/1/2#newcode84
dev/core/src/com/google/gwt/dev/resource/impl/DefaultFilters.java:84:
private static
The diffs are really large, but I think it's mostly due to the changes
in ordering. Unfortunately, I think this is an inherent drawback to the
forced-ordering in our coding style, given the current state-of-the-art
of diff tools. (I.E. simple changes in names or modifiers produce huge
diffs).
Reviewers: jat,
Description:
Speed up DevMode by getting rid of excessive JS to Java calls.
Please review this at http://gwt-code-reviews.appspot.com/1337801/show
Affected files:
M user/src/com/google/gwt/i18n/client/Dictionary.java
Index:
On 2011/01/31 23:11:33, jbrosenberg wrote:
http://gwt-code-reviews.appspot.com/1338801/diff/1/3
File
dev/core/src/com/google/gwt/core/ext/GeneratorContextExtWrapper.java
(right):
http://gwt-code-reviews.appspot.com/1338801/diff/1/3#newcode89
Strange issue with Rietveld and TypeSerializer. Maybe this second upload
will be better.
http://gwt-code-reviews.appspot.com/1310807/diff/1/2
File user/src/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java
(right):
http://gwt-code-reviews.appspot.com/1310807/diff/1/2#newcode39
http://gwt-code-reviews.appspot.com/1310807/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://en.wikipedia.org/wiki/Nota_bene
On 2011/02/04 23:06:26, jbrosenberg wrote:
LGTM (but what's NB:?)
http://gwt-code-reviews.appspot.com/1310807/diff/2003/4002
File
user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java
(right):
http://gwt-code-reviews.appspot.com/1310806/diff/1/3
File
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java
(right):
http://gwt-code-reviews.appspot.com/1310806/diff/1/3#newcode841
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java:841:
//
http://gwt-code-reviews.appspot.com/1310806/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1310806/diff/1/3
File
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java
(right):
http://gwt-code-reviews.appspot.com/1310806/diff/1/3#newcode1537
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java:1537:
private
http://gwt-code-reviews.appspot.com/1329802/diff/1004/5
File dev/core/src/com/google/gwt/dev/javac/CompiledClass.java (right):
http://gwt-code-reviews.appspot.com/1329802/diff/1004/5#newcode47
dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:47: private
transient long cacheToken;
I'm
http://gwt-code-reviews.appspot.com/1338806/diff/1/2
File user/src/com/google/gwt/dom/client/Document.java (right):
http://gwt-code-reviews.appspot.com/1338806/diff/1/2#newcode51
user/src/com/google/gwt/dom/client/Document.java:51: private static
native Document nativeGet() /*-{
On 2011/02/08
LGTM
http://gwt-code-reviews.appspot.com/1352805/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: zundel, jbrosenberg,
Description:
Records names of JSNI calls and callbacks in SpeedTracer events.
Please review this at http://gwt-code-reviews.appspot.com/1356806/show
Affected files:
M dev/core/src/com/google/gwt/dev/shell/ModuleSpaceOOPHM.java
M
LGTM
http://gwt-code-reviews.appspot.com/1365801/diff/1/dev/core/src/com/google/gwt/dev/javac/Dependencies.java
File dev/core/src/com/google/gwt/dev/javac/Dependencies.java (right):
On 2011/02/28 14:33:36, zundel wrote:
There should be nothing but formatting changes in these files, due to
the recent
update of gwt-format.xml for Eclipse's code formatter.
Things look really poorly formatted. Discussing face to face.
http://gwt-code-reviews.appspot.com/1368802/
--
LGTM
http://gwt-code-reviews.appspot.com/1368802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1375802/diff/5002/dev/core/src/com/google/gwt/dev/DevMode.java
File dev/core/src/com/google/gwt/dev/DevMode.java (right):
http://gwt-code-reviews.appspot.com/1375802/diff/5002/dev/core/src/com/google/gwt/dev/DevMode.java#newcode417
http://gwt-code-reviews.appspot.com/1412801/diff/1/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java
File dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java
(right):
http://gwt-code-reviews.appspot.com/1412801/diff/3003/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java
File dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java
(right):
LGTM
http://gwt-code-reviews.appspot.com/1415802/diff/1/dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java
File dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java
(right):
http://gwt-code-reviews.appspot.com/1416801/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
File
dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
(left):
Does MockCompilationUnit need to be updated too?
http://gwt-code-reviews.appspot.com/1422802/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
(right):
On 2011/04/20 18:00:37, zundel wrote:
LGTM
http://gwt-code-reviews.appspot.com/1420805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1427807/diff/1/dev/core/src/com/google/gwt/dev/util/log/dashboard/DashboardNotifier.java
File
dev/core/src/com/google/gwt/dev/util/log/dashboard/DashboardNotifier.java
(right):
http://gwt-code-reviews.appspot.com/1428805/diff/1/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java
File dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java (right):
LGTM
Nice change. I like this better.
http://gwt-code-reviews.appspot.com/1428805/diff/1/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java
File dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java (right):
LGTM
Nice change. I like this better.
http://gwt-code-reviews.appspot.com/1428805/diff/1/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java
File dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java (right):
LGTM
Nice change. I like this better.
http://gwt-code-reviews.appspot.com/1428805/diff/1/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java
File dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java (right):
LGTM
Nice change. I like this better.
(This failed last time. This might be a duplicate).
http://gwt-code-reviews.appspot.com/1428805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1428811/diff/1/dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java
File dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java
(right):
is explained at
http://code.google.com/webtoolkit/makinggwtbetter.html. There are
instructions for setting up Eclipse formatting settings in svn (under
the eclipse folder). You should be using autoformat to get the correct
formatting.
On 2011/05/05 16:45:54, tobyr wrote:
Is your Eclipse
Formatting changes look good. Just one more nit.
http://gwt-code-reviews.appspot.com/1427807/diff/15015/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
File
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
(right):
)
On 2011/05/06 19:03:11, tobyr wrote:
I'd rather see a test that throws an exception if both are set. That
way it's
not a silent failure.
LGTM
http://gwt-code-reviews.appspot.com/1427807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1443801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Nice. LGTM
http://gwt-code-reviews.appspot.com/1439801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/05/11 20:54:26, zundel wrote:
On 2011/05/11 20:20:07, zundel wrote:
I ran the eclipse autoformatter and edited one comment that got
trashed.
FYI, I went ahead and committed this change.
LGTM
http://gwt-code-reviews.appspot.com/1444802/
--
http://gwt-code-reviews.appspot.com/1441804/diff/1/user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java
File user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java
(right):
LGTM
http://gwt-code-reviews.appspot.com/1448801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
First set of comments
http://gwt-code-reviews.appspot.com/1448808/diff/6001/dev/core/src/com/google/gwt/dev/CompileModule.java
File dev/core/src/com/google/gwt/dev/CompileModule.java (right):
Reviewers: rdayal,
Description:
Adds support for runtime evaluation of JavaScriptObject methods from a
debugger. Primarily intended as support API for debuggers, but
developers can also use it directly in a debugger (for example, in watch
windows or breakpoint expressions).
Review by:
LGTM
http://gwt-code-reviews.appspot.com/1450812/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM with a few comments.
http://gwt-code-reviews.appspot.com/1448808/diff/8042/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
(right):
LGTM
http://gwt-code-reviews.appspot.com/1453805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1454807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1446818/diff/1/user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java
File user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java
(right):
LGTM
http://gwt-code-reviews.appspot.com/1461801/diff/4002/dev/core/src/com/google/gwt/dev/ArchivePreloader.java
File dev/core/src/com/google/gwt/dev/ArchivePreloader.java (right):
LGTM
http://gwt-code-reviews.appspot.com/1461801/diff/4007/dev/core/src/com/google/gwt/dev/ArchivePreloader.java
File dev/core/src/com/google/gwt/dev/ArchivePreloader.java (right):
LGTM
http://gwt-code-reviews.appspot.com/1462805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1466804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1464803/diff/5/dev/core/src/com/google/gwt/dev/CompileModule.java
File dev/core/src/com/google/gwt/dev/CompileModule.java (right):
http://gwt-code-reviews.appspot.com/1464803/diff/5/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode211
/src/com/google/gwt/dev/CompileModule.java:251: for
(CompilationUnit unit : archive.getUnits().values()) {
On 2011/06/23 17:06:21, zundel wrote:
On 2011/06/23 16:50:31, tobyr wrote:
I think you want to drop this for loop, by changing the above
declaration to:
SetString archivedUnits = new
On 2011/06/23 19:18:27, gfotos wrote:
Testing to see if a message gets sent to gwt-contrib.
http://gwt-code-reviews.appspot.com/1462808/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1462809/diff/1/user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
File
user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
(right):
LGTM
http://gwt-code-reviews.appspot.com/1462809/diff/2003/user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
File
user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
(right):
LGTM
http://gwt-code-reviews.appspot.com/1463809/diff/1/user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
File
user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java
(right):
LGTM
http://gwt-code-reviews.appspot.com/1467808/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
1 - 100 of 113 matches
Mail list logo
