else if (d->type >=
0xf0 && d->type <= 0xfe) {
+ printf("OEM
GUID Definition\n");
+ }
+ else {
printf("Invali
Here is the patch as an attachment in case it gets mangled in gmail..
thanks
dan
From 050b9f11f47a2c6ab3a8168519977410d77f20e2 Mon Sep 17 00:00:00 2001
From: Dan Gora
Date: Thu, 28 Jul 2016 18:00:22 -0300
Subject: Add support for PICMG 3.1 R2.0 Link Types and Link Classes.
PICMG 3.1 R2.0
PICMG 3.1 R2.0 introduces new a new Link Class field in the FRU
Link Descriptors which is the upper 4 bits of the Link Type field.
This new Link Class field specifies SERDES lanes with 10.3125Gbd
signalling rate.
It also introduces the new Base-KX and Base-KX4 types which are the
new IEEE replacem
The Pigeon Point Systems IPMI code only supports a maximum payload
data size of 37 bytes over the payload serial, KCS, SMB and LAN
interfaces, so we need to limit the maximum request size to 37 bytes
in the openIPMI plugin to prevent the KCS interface from overflowing
and stalling when HPM1 upgrade
atest/
dg:speedy:latest(master) => ls
ipmitool/
dg:speedy:latest(master) =>
There's no reason to have that extra ipmitool directory.
thanks
dan
--
Dan Gora
Software Engineer
Adax, Inc.
Av Dona Maria Alves, 1070 Casa 5
Centro
Ubatuba, SP
CEP 11680-000
Brasil
Tel
Hi Zdenek,
On Tue, Aug 13, 2013 at 8:17 AM, Zdenek Styblik
wrote:
>>> There are still those(two) scanf() patches left. I want to look at
>>> these closer, because it seems tricky to handle scanf() correctly.
>>
>> It's really not _that_ tricky. It returns the number of things that
>> it scanned
[patches:#74] Improve help message for 'ipmitool picmg policy set'
Status: open
Created: Tue Aug 06, 2013 09:26 PM UTC by Dan Gora
Last Updated: Tue Aug 06, 2013 09:26 PM UTC
Owner: nobody
A quick patch to improve the help message for ipmitool picmg policy
set. The previous help m
On Tue, Aug 6, 2013 at 3:32 PM, Zdenek Styblik wrote:
> On Tue, Aug 6, 2013 at 8:16 PM, Dan Gora wrote:
>> As for me, I'd like to try and get the changes to be able to remove
>> the -Wno-unused-return flag from the Makefile since that breaks
>> builds. There are sev
As for me, I'd like to try and get the changes to be able to remove
the -Wno-unused-return flag from the Makefile since that breaks
builds. There are several patches pending to be merged for that (ID
65: Fixes for configure.in for cross compilation).
I also have two patches for ipmi_picmg.c that
Hi Zdenek,
Sorry it took so long to get back to this...
On Thu, Jul 25, 2013 at 3:11 PM, Zdenek Styblik
wrote:
> DCMI is some M$ server power management thing or whatnot. I believe
> trying out similar code snippet should be enough to verify it works as
> expected.
> Please, can you test http://
version control? Why should you start doing it? Read more to find out.
> http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
> ___
> Ipmitool-devel mailing list
> Ipmitool-devel@lists.sourceforge.net
> https:/
On Thu, Jul 25, 2013 at 3:11 PM, Zdenek Styblik
wrote:
>> Both. The gcc compiler cannot pick out used, but uninitialized fields
>> from a structure (other compilers might), but IMHO it's better to
>> explicitly initialize the structure near where it's going to be used
>> so that people can see th
On Thu, Jul 25, 2013 at 11:59 AM, Zdenek Styblik
wrote:
> On Thu, Jul 25, 2013 at 4:52 PM, Dan Gora wrote:
>> On Thu, Jul 25, 2013 at 1:40 AM, Zdenek Styblik
>> wrote:
>>> Hi,
>>>
>>> attached is a patch to mitigate possible int *flows via user inp
On Thu, Jul 25, 2013 at 1:40 AM, Zdenek Styblik
wrote:
> Hi,
>
> attached is a patch to mitigate possible int *flows via user input.
> It's pretty much no brainer except those shifts. Therefore I'd
> appreciate if somebody could give it a look.
> Are those shifts correct?
> Will they work correctl
On Thu, Jul 25, 2013 at 7:06 AM, Zdenek Styblik
wrote:
> Dan,
>
> I agree that some changes aren't as best as they could be, eg.
> checking some return values, and I admit there is still some work
> left. I hope code got simpler and compiler shut. Anyone is free to
> iterate on these changes and m
, 2013 at 1:44 PM, Zdenek Styblik
wrote:
> Hello all,
>
> attached are re-works of three functions in 'lib/ipmi_ekanalyzer.c'.
> These are based on patches Dan has uploaded/attached to ticket in
> question.
> Please, somebody do the review, wave the flag, so we can get
On Wed, Jul 17, 2013 at 4:28 PM, Dan Gora wrote:
>> Strange since you're the one whom created the ticket in the first
>> place. But SF.net acts in very strange ways.
>
> I think that you can change tickets because you're an Admin. Since
> I'm a nobody, I c
On Wed, Jul 17, 2013 at 4:21 PM, Zdenek Styblik
wrote:
> On Wed, Jul 17, 2013 at 9:11 PM, Dan Gora wrote:
>> On Wed, Jul 17, 2013 at 4:06 PM, Zdenek Styblik
>> wrote:
>>
>>>> I posted 6 patches back on Apr 29, 2013 to fix the issues we had with
>>>&
On Wed, Jul 17, 2013 at 4:06 PM, Zdenek Styblik
wrote:
>> I posted 6 patches back on Apr 29, 2013 to fix the issues we had with
>> removing the -Wno-unused-result flag from CFLAGS that never got
>> reviewed or acked or anything. This was issue #3608759, now is issue
>> #65 http://sourceforge.net
cs Pro today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
> ___
> Ipmitool-devel mailing list
> Ipmitool-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
--
Dan Gora
Software Engineer
I've tested these changes on my ATCA system and confirm that they work
and that they fix reading sensor records directly from AMC cards from
the ATCA carrier card's payload CPU, so ack'd by me...
thanks
dan
On Wed, May 1, 2013 at 10:01 AM, Jim Mankovich wrote:
> All,
>
> I've completed all the
Sorry.. that should say "6 patches"...
Let me know if there are still compilation warnings on other systems.
I've tested Suse 12.1, Ubuntu 12.10, Cavium SDK 1.8.1 and Cavium SDK
2.3.0.
thanks
dan
On Mon, Apr 29, 2013 at 9:01 PM, Dan Gora wrote:
> Hi All,
>
> Following
Patch 6: Fix compilation warnings in ipmi_hpmfwupg.c
On Mon, Apr 29, 2013 at 9:01 PM, Dan Gora wrote:
> Hi All,
>
> Following are 5 patches to fix the compilation warnings which appear
> in newer gcc versions (gcc 4.7.2 currently only seen in Ububtu 12.10
> AFAIK) when -Wno-u
Patch 5: Fix compilation warning in imbapr.c
On Mon, Apr 29, 2013 at 9:01 PM, Dan Gora wrote:
> Hi All,
>
> Following are 5 patches to fix the compilation warnings which appear
> in newer gcc versions (gcc 4.7.2 currently only seen in Ububtu 12.10
> AFAIK) when -Wno-unused-re
Patch 4: Fix warnings in ipmi_fwum.c
On Mon, Apr 29, 2013 at 9:01 PM, Dan Gora wrote:
> Hi All,
>
> Following are 5 patches to fix the compilation warnings which appear
> in newer gcc versions (gcc 4.7.2 currently only seen in Ububtu 12.10
> AFAIK) when -Wno-unused-return is r
Patch 3: Fix warnings in ipmi_ekanalyzer.c
Index: lib/ipmi_ekanalyzer.c
===
RCS file: /cvsroot/ipmitool/ipmitool/lib/ipmi_ekanalyzer.c,v
retrieving revision 1.20
diff -r1.20 ipmi_ekanalyzer.c
2373,2376c2373,2375
Patch 2: Fix more compilation warnings in ipmi_fru.c
From 92207611b0f311aeb4915256a00bc0380b0a292f Mon Sep 17 00:00:00 2001
From: Dan Gora
Date: Mon, 29 Apr 2013 19:58:44 -0300
Subject: [PATCH 2/6] Fix compilation warnings in lib/ipmi_fru.c.
Fixed some printf formatting warnings.
---
ipmitool
Patch 1 for lib/ipmi_fru.c based on
On Mon, Apr 29, 2013 at 9:01 PM, Dan Gora wrote:
> Hi All,
>
> Following are 5 patches to fix the compilation warnings which appear
> in newer gcc versions (gcc 4.7.2 currently only seen in Ububtu 12.10
> AFAIK) when -Wno-unused-return is r
Hi All,
Following are 5 patches to fix the compilation warnings which appear
in newer gcc versions (gcc 4.7.2 currently only seen in Ububtu 12.10
AFAIK) when -Wno-unused-return is removed from the compilation flags.
-Wno-unused-return basically _has_ to come out. A few compilation
warnings are b
Here's a quick patch to fix this.
thanks
dan
commit b1f38c34edc679eac03613b6ceb5825deca2e854
Author: Dan Gora
Date: Wed Apr 24 19:09:54 2013 -0300
[debian] ipmitool: Fix compilation bug on big endian machines.
On big endian machines the compilation would fail because BSW
from
around the #include .
thanks
dan
On Thu, Apr 4, 2013 at 4:14 PM, Zdenek Styblik wrote:
> On Thu, Apr 4, 2013 at 7:21 PM, Dan Gora wrote:
>> Ok, never mind.. it was.. Sorry about that.. I originally did all the
>> changes against 1.8.12, then ported them to the tip of the C
Ok, sorry about _this_ email The previous results were accurate after all...
thanks
dan
On Wed, Apr 24, 2013 at 5:03 PM, Dan Gora wrote:
> Hi Jim,
>
> Please ignore the results from my last email.. I think that I have your
> patch applied to the wrong version of the source
Hi Jim,
Please ignore the results from my last email.. I think that I have your
patch applied to the wrong version of the source Let me start this
all over again before we go any further..
Sorry about that.
thanks
dan
-
On Wed, Apr 24, 2013 at 12:52 PM, Jim Mankovich wrote:
> The first major difference between TOB (What you call CVS ROOT) and TOB plus
> my
> patch is the fact that on a PICMG platform, my patch will always perform a
> PICMG
> address discovery, whereas TOB would only do this if you specified '-m
Hi guys,
I'm working on coming up with a set of test cases to test this patch,
but I'm going to need some help with making sure that everything is
sane and valid.
First off, can you describe, Jim, what was the problem was initially
in 1.8.12 exactly? What were you trying to read and how were you
On Mon, Apr 22, 2013 at 7:43 AM, Zdenek Styblik
wrote:
> On Fri, Mar 22, 2013 at 1:17 AM, Dan Gora wrote:
>> Format the records a little more clearly by adding offsets.
>>
>
> Please, can you post output of proposed change? I'm not convinced
> removing '\t'
On Mon, Apr 22, 2013 at 2:40 PM, Jim Mankovich wrote:
>
> I fully agree with Dan in that there is no good reason to change existing
> indentation for code. It simply obfuscates real changes and makes
> application
> of patches problematic.
>
> -- Jim Mankovich | jm...@hp.com (US Mountain Time)
On Mon, Apr 22, 2013 at 2:09 PM, Dmitry Bazhenov wrote:
> Hello, all,
>
> We would like to submit several new features into the mainline before
> еру next release. They are: direct serial interface drivers (Terminal
> and Basic Mode), HPM.2 long message support (automatic detection of
> inbound an
On Mon, Apr 22, 2013 at 5:24 AM, Zdenek Styblik
wrote:
>
> Hello,
>
> hopefully, I haven't missed anything important from this patch. I
> think it's safe to say one lesson, and "rule", from this patch is not
> to mix fixes and indentation/formatting changes together.
> Anyway, that's not the reaso
Fixed bug introduced in CVS revision 1.15 of lib/ipmi_tsol.c where
an error case was missing braces, so it would always fail.
---
ipmitool/lib/ipmi_tsol.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/ipmitool/lib/ipmi_tsol.c b/ipmitool/lib/ipmi_tsol.c
index 9beb84b..6
Hi All,
This patch fixes a bug introduced in CVS revision 1.70 of src/plugins/lan/lan.c.
Looks like someone forgot to put in braces around the 'if'.
thanks
dan
From: Dan Gora
Date: Thu, 18 Apr 2013 17:38:45 -0300
Subject: [PATCH] Fix bug in plugins/lan/lan.c introduced in CVS revi
On Thu, Apr 4, 2013 at 6:03 PM, Jim Mankovich wrote:
> I don't have any problem with the code formatting. I personally
> leave code formatting alone in ipmitool for any code I don't explicitly
> need to make a functional change to.
>
I do too.. really... I do have better things to do with my ti
On Thu, Apr 4, 2013 at 5:40 PM, Dan Gora wrote:
>> consider it to be better formatting, nor better readable, and not
>> consistent. Because that space should be there ') {'.
And really, if you going to argue with me about joining the closing
parenthesis and an opening b
On Thu, Apr 4, 2013 at 5:35 PM, Zdenek Styblik wrote:
> On Thu, Apr 4, 2013 at 10:17 PM, Dan Gora wrote:
>> On Thu, Apr 4, 2013 at 5:14 PM, Zdenek Styblik
>> wrote:
>>> On Thu, Apr 4, 2013 at 10:07 PM, Zdenek Styblik
>>> wrote:
>>>> On
On Thu, Apr 4, 2013 at 5:23 PM, Zdenek Styblik wrote:
>
> Really *shrug*. (now, you knew it had to come some time) Sometimes I
> even ask myself whether 80 chars width is still relevant nowadays.
yes! It is!
> Relevant for majority, that is. And I don't mean only code formatting
> now, but outp
On Thu, Apr 4, 2013 at 5:14 PM, Zdenek Styblik wrote:
> On Thu, Apr 4, 2013 at 10:07 PM, Zdenek Styblik
> wrote:
>> On Thu, Apr 4, 2013 at 10:00 PM, Dan Gora wrote:
>> [...]
>>>> What? How's that relevant what number we use for tab stops? It's
>
On Thu, Apr 4, 2013 at 5:07 PM, Zdenek Styblik wrote:
> Again, we're not using spaces for indentation. Although you can set %
> vi; to auto-magically convert tabs into spaces. So when you press
> tabulator key it inserts white spaces. We're not using it.
Again, I have no idea what you are talkin
On Thu, Apr 4, 2013 at 4:57 PM, Zdenek Styblik wrote:
> On Thu, Apr 4, 2013 at 9:51 PM, Dan Gora wrote:
>> On Thu, Apr 4, 2013 at 4:47 PM, Jim Mankovich wrote:
>>>
>>> I would advocate always using tab for indentation. Then you can change it
>>> to be
On Thu, Apr 4, 2013 at 4:52 PM, Zdenek Styblik wrote:
> Sure. I've found two issues with help "update". The first is, I don't
> like new help output very much, to be honest. That doesn't mean you
Well it would help if you could actually say what you don't like about
it. I think that it's much cl
On Thu, Apr 4, 2013 at 4:47 PM, Jim Mankovich wrote:
>
> I would advocate always using tab for indentation. Then you can change it
> to be any number of spaces in your editor. This is what I generally do,
> and for
> many of the files in ipmitool I set my editor to have a tab stop of 4 so
> th
On Thu, Apr 4, 2013 at 4:40 PM, Zdenek Styblik wrote:
> On Thu, Apr 4, 2013 at 9:23 PM, Dan Gora wrote:
>> On Thu, Apr 4, 2013 at 4:13 PM, Zdenek Styblik
>> wrote:
>>>> So that the lines don't wrap around 80 columns... I'm trying to
>>>> impr
0x44)
Note that long lines are broken up so that things don't go past 80
columns and the help has been clarified and updated. It's not just
messing with the formatting of the code.
thanks
dan
On Thu, Apr 4, 2013 at 1:52 PM, Dan Gora wrote:
> On Thu, Apr 4, 2013 at 9:48 AM, Zdenek Styb
Ok, never mind.. it was.. Sorry about that.. I originally did all the
changes against 1.8.12, then ported them to the tip of the CVS tree.
I didn't see that this was already fixed.
thanks
dan
On Thu, Apr 4, 2013 at 2:19 PM, Dan Gora wrote:
> On Thu, Apr 4, 2013 at 8:57 AM, Zdenek
On Thu, Apr 4, 2013 at 8:57 AM, Zdenek Styblik wrote:
> On Fri, Mar 22, 2013 at 1:08 AM, Dan Gora wrote:
>> The BSWAP_32 macro was added for big endian machines in these files,
>> but the author forgot to include the necessary header file which
>> defines it.
>>
On Thu, Apr 4, 2013 at 10:35 AM, Zdenek Styblik
wrote:
> On Fri, Mar 22, 2013 at 1:12 AM, Dan Gora wrote:
>> This code was moved to ipmi_main.c from open.c and in the change a bug
>> was introduced where the PICMG Get Device Locator command would not
>> be run unless th
On Thu, Apr 4, 2013 at 9:48 AM, Zdenek Styblik wrote:
> On Fri, Mar 22, 2013 at 1:15 AM, Dan Gora wrote:
>> Fixed the formatting of the help command to make it clearer what
>> options the sdr command has.
>>
>
> Ok, I did take a closer look at this diff:
> 1
On Wed, Apr 3, 2013 at 6:40 AM, Zdenek Styblik wrote:
> On Tue, Apr 2, 2013 at 9:04 PM, Dan Gora wrote:
>> Actually I just remembered another reason why I hate the stdint.h types:
>>
>> When compiling on Ubuntu 12.10:
>>
>> ../../lib/ipmi_delloem.c: In function
or a
project like ipmitool which has a pretty limited set of processors
which it has to support.
Anyways, mini-rant against stdint.h over
thanks
dan
On Mon, Apr 1, 2013 at 3:43 PM, Zdenek Styblik wrote:
> On Mon, Apr 1, 2013 at 8:08 PM, Dan Gora wrote:
>> On Mon, Apr 1, 2013 at 3
On Mon, Apr 1, 2013 at 4:18 PM, Zdenek Styblik wrote:
> lprintf(LOG_ERR, "Sensor Type %s not found.", type);
>
> I presume this is "help" context, but I definitely should check it in
> application context:
> lprintf(LOG_NOTICE, "Sensor Types:");
> for (x = 1; x < SENSOR_TYPE_MAX; x += 2) {
>
On Mon, Apr 1, 2013 at 3:53 PM, Jim Mankovich wrote:
> Dan, Z,
>
> I use gcc 4.6.3 with a fairly recent linux stable kernel release.
>
> Here is an example of why I would like the -Wno-unused-result flag to
> remain. Notice that if you take the
> TOB kernel and compile with a pretty recent compi
On Mon, Apr 1, 2013 at 4:10 PM, Zdenek Styblik wrote:
>> Here's the patched code:
>>
>> FILE * input_file;
>> unsigned char data;
>> unsigned char last_record = 0;
>> unsigned int multi_offset;
>> int record_count = 0;
>>
>> input_file = fopen ( file
On Mon, Apr 1, 2013 at 3:54 PM, Zdenek Styblik wrote:
> Dan,
>
> here is what I see wrong with this patch:
>
> * it touches/modifies more than just help
> * ``printf("Sensor Type %s not found.\n", type);'' -> ``lprintf(LOG_ERR,
> ...);''
>
> I find the following, despite not covered/modified by t
On Mon, Apr 1, 2013 at 3:48 PM, Zdenek Styblik wrote:
> On Fri, Mar 22, 2013 at 1:17 AM, Dan Gora wrote:
>> If the offset was greater than 127, then the multi_offset would end
>> up being a negative value, which is not what we want.
>>
>
> Dan,
>
> I actually do
On Mon, Apr 1, 2013 at 3:12 PM, Zdenek Styblik wrote:
> On Mon, Apr 1, 2013 at 8:03 PM, Dan Gora wrote:
> [...]
>>
>> I agree, but I think that it's better to fix the warnings if at all
>> possible. Of course adding -Werror would force people to deal with
>> t
On Mon, Apr 1, 2013 at 3:04 PM, Zdenek Styblik wrote:
> On Mon, Apr 1, 2013 at 7:52 PM, Dan Gora wrote:
>> yes because the structure is only 3 bytes long. Recall that a long is
>> 8 bytes on 64 bit machines. An unsigned int is always 4 bytes (unless
>> we're
On Mon, Apr 1, 2013 at 2:51 PM, Jim Mankovich wrote:
> Dan,
>
> Without this compile flag, there are many warning messages with the new gcc
> versions.
Are there? I just compiled it without -Wno-unused-result with gcc
4.6.2 and I only see three warnings:
../../lib -I.. -I../../include-g -O2
Hi Jim,
(I'm going to cc the ipmitool-devel list so that other people can see
your review and we don't have duplicate your work)
On Mon, Apr 1, 2013 at 2:24 PM, Jim Mankovich wrote:
> Dan,
>
> Here are a couple of comments/questions on your code changes in this patch
> set. I did
> not seen an
On Mon, Mar 25, 2013 at 4:54 PM, Zdenek Styblik
wrote:
> Because not every free() case needs this patch, I guess. I went
> through the sources again and it looks ok to me.
Agreed.. I didn't see anything wrong with any of it, but to prove that
nothing is missing is a harder question...
>> I guess
Hi Zdenek,
On Fri, Mar 22, 2013 at 9:12 AM, Zdenek Styblik
wrote:
> Hello all,
>
> attached is a rather large diff which sets all pointers in ipmitool to
> NULL right after free() is called. The aim of the patch is not to
> investigate whether there these pointers are being freed elsewhere
> agai
Added a '^' character to the ID field which will be set if the
component can be upgraded with the specified file with the 'hpm check
' subcommand.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_hpmfwupg.c | 40 ++--
1 files changed,
Fixed a bug where the carrier connectivity point to point descriptor
was not being displayed properly when compiled on big endian machines.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_ekanalyzer.c | 39 ---
1 files changed, 24 insertions(+), 15 deletions
Changed to ipmi_ek_display_carrier_connectivity.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_ekanalyzer.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/ipmitool/lib/ipmi_ekanalyzer.c b/ipmitool/lib/ipmi_ekanalyzer.c
index 6c77c7e..8f1d2f4 100644
--- a
00 | 2.00 1000 | ---.-- |
| 1|H8S-AMCc B/L | 2.00 | ---.-- | ---.-- |
| 2|H8S-AMCc F/I | 2.00 1000 | ---.-- | ---.-- |
--
(*) Component requires Payload Cold Reset
Sig
HpmDisplayUpgrade before we transfer any data to ensure
that we get 0% printed before the transfer starts.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_hpmfwupg.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/ipmitool/lib/ipmi_hpmfwupg.c b/ipmitool/lib/ipmi_hpmfwupg.c
index bc0bddc
most
significant byte of the int (ie byte 0) on big endian machines.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_ekanalyzer.c | 17 +++--
1 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/ipmitool/lib/ipmi_ekanalyzer.c b/ipmitool/lib/ipmi_ekanalyzer.c
index 2fcf4e5
Previous versions had two values for "Watchdog" in the list which
means that users could not perform 'ipmitool sdr type "Watchdog"'
and get the IPMI v1.0 and later version of the watchdog sensor (ie
0x23 instead of 0x11).
Signed-off-by: Dan Gora
---
ipmitool/incl
There is no point in putting the size of things in hex.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_hpmfwupg.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ipmitool/lib/ipmi_hpmfwupg.c b/ipmitool/lib/ipmi_hpmfwupg.c
index a89e97e..7704104 100644
--- a/ipmitool/lib
Update the help menu for the ipmitool hpm command. Fix the formatting
and explain better the options.
Changed the option 'upgrade all' to 'upgrade force'.
This makes it clearer that the user is overriding the version check
that 'upgrade ' performs.
Signed-off-b
Update HpmfwupgPreUpgradeCheck to check if the Aux version is also
different when it compares the Image version to the active and
rollback versions.
Fixed the indenting and style of HpmfwupgPreUpgradeCheck to make it
more readable.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_hpmfwupg.c
| 2.00 0F00 |
| 1|H8S-AMCc B/L | 2.00 | ---.-- |
| 2|H8S-AMCc F/I | 2.00 1000 | ---.-- |
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_hpmfwupg.c | 78
FRU_PICMGEXT_AMC_CHANNEL_DESC_RECORD_SIZE and
FRU_PICMGEXT_AMC_LINK_DESC_RECORD_SIZE defines instead of sizeof for
these structures.
Updated ipmi_ek_create_amc_p2p_record() and
ipmi_ek_display_amc_p2p_record() to read data in the correct byte order
on both big and little endian machines.
Signed-off-by: Dan Gora
---
ipmitool
Here are the patches for series 7
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
We now will print the decoded strings as well as the error value for
error response codes from the target.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_hpmfwupg.c | 60 --
1 files changed, 46 insertions(+), 14 deletions(-)
diff --git a/ipmitool/lib
Here are the patches for Series 9
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
Fixed the hpm upgstatus command to print the results of the command
without having to specify -v to enable verbose operation.
It's not clear that this command is even useful to the user at all.
Perhaps it should be removed entirely.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_hpmfw
Format the records a little more clearly by adding offsets.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_ekanalyzer.c | 10 ++
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/ipmitool/lib/ipmi_ekanalyzer.c b/ipmitool/lib/ipmi_ekanalyzer.c
index 2da4650..34b6cb6 100644
ion and
to properly set the file_offset and end the while loop if a Custom
board_type was found.
Previous versions were also abusing the board_length variable,
treating it as an int and using it to break out of the loop.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_ekanalyze
Performing postfix (or prefix) increments (ie ++var or var++) in the
arguments to printf is inherently non-portable and may give different
results on different platforms.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_ekanalyzer.c | 55 ---
1 files changed
If the offset was greater than 127, then the multi_offset would end
up being a negative value, which is not what we want.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_ekanalyzer.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/ipmitool/lib/ipmi_ekanalyzer.c b
ipmi_ekanalyzer_fru_file2structure would return ERROR_STATUS even if
it finished sucessfully.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_ekanalyzer.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/ipmitool/lib/ipmi_ekanalyzer.c b/ipmitool/lib/ipmi_ekanalyzer.c
value for the type.
Add the hex value for the sensor type to displays so that the user
can correlate sensor type values with their hex values without having
to look them up in the IPMI spec.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_sdr.c | 36 ++--
1 files
Here are the patches for Series 8.
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
___
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_ekanalyzer.c | 167
1 files changed, 84 insertions(+), 83 deletions(-)
diff --git a/ipmitool/lib/ipmi_ekanalyzer.c b/ipmitool/lib/ipmi_ekanalyzer.c
index 34b6cb6..9fd4be1 100644
--- a/ipmitool/lib
Fixed the formatting of the help command to make it clearer what
options the sdr command has.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_sdr.c | 71 +--
1 files changed, 44 insertions(+), 27 deletions(-)
diff --git a/ipmitool/lib/ipmi_sdr.c b
Change the amc channel descriptor ports to be displayed in decimal
instead of hex. This matches the fru -v output in ipmitool.
Add decimal value of Link Asymetric Match values. So people don't have to
look up the value in the source or in the PIGMG spec.
Signed-off-by: Dan Gora
---
ipm
Here are the patches for Series 6
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
Remove two unused local variables from ipmi_ekanalyzer_ekeying_match().
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_ekanalyzer.c |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/ipmitool/lib/ipmi_ekanalyzer.c b/ipmitool/lib/ipmi_ekanalyzer.c
index 8f1d2f4..18ccb9a
Rewrote ipmi_ek_display_chassis_info_area,
ipmi_ek_display_product_info_area, and
ipmi_ekanalyzer_fru_file2structure to reverse the checks of error
conditions to reduce the amount of indentation required.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_ekanalyzer.c | 326
Cleaned up the formatting a bit to fit on an 80 column screen.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_hpmfwupg.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/ipmitool/lib/ipmi_hpmfwupg.c b/ipmitool/lib/ipmi_hpmfwupg.c
index 46bcb31..d9ced65 100644
with the -m option.
Signed-off-by: Dan Gora
---
ipmitool/lib/ipmi_main.c | 14 +-
1 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/ipmitool/lib/ipmi_main.c b/ipmitool/lib/ipmi_main.c
index ce98ef4..a2f3500 100644
--- a/ipmitool/lib/ipmi_main.c
+++ b/ipmitool/lib
1 - 100 of 115 matches
Mail list logo
