[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2019-11-12 Thread Andrei Sereda (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972953#comment-16972953 ] Andrei Sereda commented on CALCITE-2457: Does it mean we can use JUnit5 functionality now ?  >

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2019-11-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972909#comment-16972909 ] Julian Hyde commented on CALCITE-2457: -- [~vladimirsitnikov], Is this fixed in master? If so, what

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2019-11-12 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972818#comment-16972818 ] Vladimir Sitnikov commented on CALCITE-2457: Switch to JUnit5 executor is made as a part of

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2019-03-18 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795255#comment-16795255 ] Vladimir Sitnikov commented on CALCITE-2457: [~sereda], I think the case is just "not

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2019-03-18 Thread Andrei Sereda (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795248#comment-16795248 ] Andrei Sereda commented on CALCITE-2457: [~vladimirsitnikov] generally I agree with you

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2019-03-18 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795243#comment-16795243 ] Vladimir Sitnikov commented on CALCITE-2457: {quote}I don't see how Junit 5 and refactoring

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2019-03-18 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795235#comment-16795235 ] Vladimir Sitnikov commented on CALCITE-2457: # I don't see much a problem there. For

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2019-03-18 Thread Andrei Sereda (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795191#comment-16795191 ] Andrei Sereda commented on CALCITE-2457: Following dev list

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2019-02-26 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778644#comment-16778644 ] Vladimir Sitnikov commented on CALCITE-2457: I don't know. For instance, Extensions for

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2019-02-26 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778638#comment-16778638 ] Julian Hyde commented on CALCITE-2457: -- I don't see how Junit 5 and refactoring JdbcTest /

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2019-02-26 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778609#comment-16778609 ] Vladimir Sitnikov commented on CALCITE-2457: JUnit5 can live side by side, and adding some

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2019-02-26 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778598#comment-16778598 ] Julian Hyde commented on CALCITE-2457: -- I don't feel any urgency - junit 4 has everything I need. 

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2019-02-23 Thread Andrei Sereda (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776018#comment-16776018 ] Andrei Sereda commented on CALCITE-2457: [~vladimirsitnikov] do you think it is time to upgrade

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-09-14 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615331#comment-16615331 ] Vladimir Sitnikov commented on CALCITE-2457: On top of that, if there was an implementation

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-09-14 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615330#comment-16615330 ] Vladimir Sitnikov commented on CALCITE-2457:  {quote}Are we running at risk in adopting it

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-09-14 Thread Andrei Sereda (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615323#comment-16615323 ] Andrei Sereda commented on CALCITE-2457: [~vladimirsitnikov], JUnit5 would definitely help me

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-09-14 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615272#comment-16615272 ] Vladimir Sitnikov commented on CALCITE-2457: [~asereda], yeah, and it seems to have

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-09-11 Thread Andrei Sereda (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611549#comment-16611549 ] Andrei Sereda commented on CALCITE-2457: [~vladimirsitnikov] Junit5 v 5.3.1 [was already

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-08-09 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575269#comment-16575269 ] Vladimir Sitnikov commented on CALCITE-2457: {quote}This discussion is missing one

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-08-09 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575236#comment-16575236 ] Julian Hyde commented on CALCITE-2457: -- This discussion is missing one important consideration:

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-08-09 Thread Andrei Sereda (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575175#comment-16575175 ] Andrei Sereda commented on CALCITE-2457: I guess the advantage is that you can [write

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-08-09 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575102#comment-16575102 ] Vladimir Sitnikov commented on CALCITE-2457: {quote}assertThat(Sql.create("select * from

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-08-09 Thread Andrei Sereda (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575028#comment-16575028 ] Andrei Sereda commented on CALCITE-2457: It should be relatively easy to create Subject for

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-08-09 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574409#comment-16574409 ] Vladimir Sitnikov commented on CALCITE-2457: {quote}For failure you don't like error

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-08-08 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573862#comment-16573862 ] Vladimir Sitnikov commented on CALCITE-2457: {quote}If we were to upgrade to Junit 5, would

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-08-08 Thread Andrei Sereda (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573809#comment-16573809 ] Andrei Sereda commented on CALCITE-2457: For failure you don't like error message ? Or is it

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-08-08 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573799#comment-16573799 ] Julian Hyde commented on CALCITE-2457: -- If we were to upgrade to Junit 5, would we need to modify

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-08-08 Thread Andrei Sereda (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573731#comment-16573731 ] Andrei Sereda commented on CALCITE-2457: To add context information you can use

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-08-08 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573410#comment-16573410 ] Vladimir Sitnikov commented on CALCITE-2457: [~asereda], that is an interesting point. I've

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-08-08 Thread Andrei Sereda (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573369#comment-16573369 ] Andrei Sereda commented on CALCITE-2457: While we're at testing infrastructure discussion what

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-08-08 Thread Andrei Sereda (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573277#comment-16573277 ] Andrei Sereda commented on CALCITE-2457: I think surefire parallel execution of tests

[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5

2018-08-08 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573016#comment-16573016 ] Enrico Olivelli commented on CALCITE-2457: -- You will have to upgrade to latest maven surefire