[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972953#comment-16972953
]
Andrei Sereda commented on CALCITE-2457:
Does it mean we can use JUnit5 functionality now ?
>
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972909#comment-16972909
]
Julian Hyde commented on CALCITE-2457:
--
[~vladimirsitnikov], Is this fixed in master? If so, what
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972818#comment-16972818
]
Vladimir Sitnikov commented on CALCITE-2457:
Switch to JUnit5 executor is made as a part of
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795255#comment-16795255
]
Vladimir Sitnikov commented on CALCITE-2457:
[~sereda], I think the case is just "not
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795248#comment-16795248
]
Andrei Sereda commented on CALCITE-2457:
[~vladimirsitnikov] generally I agree with you
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795243#comment-16795243
]
Vladimir Sitnikov commented on CALCITE-2457:
{quote}I don't see how Junit 5 and refactoring
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795235#comment-16795235
]
Vladimir Sitnikov commented on CALCITE-2457:
# I don't see much a problem there. For
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795191#comment-16795191
]
Andrei Sereda commented on CALCITE-2457:
Following dev list
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778644#comment-16778644
]
Vladimir Sitnikov commented on CALCITE-2457:
I don't know. For instance, Extensions for
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778638#comment-16778638
]
Julian Hyde commented on CALCITE-2457:
--
I don't see how Junit 5 and refactoring JdbcTest /
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778609#comment-16778609
]
Vladimir Sitnikov commented on CALCITE-2457:
JUnit5 can live side by side, and adding some
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778598#comment-16778598
]
Julian Hyde commented on CALCITE-2457:
--
I don't feel any urgency - junit 4 has everything I need.
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776018#comment-16776018
]
Andrei Sereda commented on CALCITE-2457:
[~vladimirsitnikov] do you think it is time to upgrade
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615331#comment-16615331
]
Vladimir Sitnikov commented on CALCITE-2457:
On top of that, if there was an implementation
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615330#comment-16615330
]
Vladimir Sitnikov commented on CALCITE-2457:
{quote}Are we running at risk in adopting it
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615323#comment-16615323
]
Andrei Sereda commented on CALCITE-2457:
[~vladimirsitnikov], JUnit5 would definitely help me
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615272#comment-16615272
]
Vladimir Sitnikov commented on CALCITE-2457:
[~asereda], yeah, and it seems to have
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611549#comment-16611549
]
Andrei Sereda commented on CALCITE-2457:
[~vladimirsitnikov] Junit5 v 5.3.1 [was already
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575269#comment-16575269
]
Vladimir Sitnikov commented on CALCITE-2457:
{quote}This discussion is missing one
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575236#comment-16575236
]
Julian Hyde commented on CALCITE-2457:
--
This discussion is missing one important consideration:
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575175#comment-16575175
]
Andrei Sereda commented on CALCITE-2457:
I guess the advantage is that you can [write
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575102#comment-16575102
]
Vladimir Sitnikov commented on CALCITE-2457:
{quote}assertThat(Sql.create("select * from
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575028#comment-16575028
]
Andrei Sereda commented on CALCITE-2457:
It should be relatively easy to create Subject for
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574409#comment-16574409
]
Vladimir Sitnikov commented on CALCITE-2457:
{quote}For failure you don't like error
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573862#comment-16573862
]
Vladimir Sitnikov commented on CALCITE-2457:
{quote}If we were to upgrade to Junit 5, would
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573809#comment-16573809
]
Andrei Sereda commented on CALCITE-2457:
For failure you don't like error message ? Or is it
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573799#comment-16573799
]
Julian Hyde commented on CALCITE-2457:
--
If we were to upgrade to Junit 5, would we need to modify
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573731#comment-16573731
]
Andrei Sereda commented on CALCITE-2457:
To add context information you can use
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573410#comment-16573410
]
Vladimir Sitnikov commented on CALCITE-2457:
[~asereda], that is an interesting point. I've
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573369#comment-16573369
]
Andrei Sereda commented on CALCITE-2457:
While we're at testing infrastructure discussion what
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573277#comment-16573277
]
Andrei Sereda commented on CALCITE-2457:
I think surefire parallel execution of tests
[
https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573016#comment-16573016
]
Enrico Olivelli commented on CALCITE-2457:
--
You will have to upgrade to latest maven surefire
32 matches
Mail list logo