YuyuZha0 commented on a change in pull request #443: Optimize string split
methods: 1. Use ThreadLocal to make reuse of th…
URL: https://github.com/apache/commons-lang/pull/443#discussion_r317862813
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
aremily commented on issue #94: Crypto 137 windows compile
URL: https://github.com/apache/commons-crypto/pull/94#issuecomment-525085354
I checked in my edits. I think I caught everything. I added the console
output from the test runs in the different environments to assist with your
garydgregory commented on a change in pull request #33: Add missing Java 9 and
Java 11 class file attributes.
URL: https://github.com/apache/commons-bcel/pull/33#discussion_r317837449
##
File path: src/main/java/org/apache/bcel/classfile/Visitor.java
##
@@ -131,6 +131,11
garydgregory commented on a change in pull request #33: Add missing Java 9 and
Java 11 class file attributes.
URL: https://github.com/apache/commons-bcel/pull/33#discussion_r317837449
##
File path: src/main/java/org/apache/bcel/classfile/Visitor.java
##
@@ -131,6 +131,11
garydgregory commented on a change in pull request #33: Add missing Java 9 and
Java 11 class file attributes.
URL: https://github.com/apache/commons-bcel/pull/33#discussion_r317837449
##
File path: src/main/java/org/apache/bcel/classfile/Visitor.java
##
@@ -131,6 +131,11
[
https://issues.apache.org/jira/browse/POOL-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916200#comment-16916200
]
Gary Gregory commented on POOL-326:
---
[~psteitz]
May you please copy the performance code you are using in
[
https://issues.apache.org/jira/browse/POOL-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916184#comment-16916184
]
Gary Gregory commented on POOL-326:
---
I did the ISE bit in [POOL-374] since it is related to this issue
[
https://issues.apache.org/jira/browse/POOL-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916184#comment-16916184
]
Gary Gregory edited comment on POOL-326 at 8/26/19 10:36 PM:
-
I did the ISE bit
[
https://issues.apache.org/jira/browse/POOL-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Gregory closed POOL-375.
-
Fix Version/s: 2.7.1
Resolution: Fixed
In git master.
> Update optional library cglib from 3.2.12
[
https://issues.apache.org/jira/browse/POOL-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Gregory closed POOL-374.
-
Fix Version/s: 2.7.1
Resolution: Fixed
In git master.
>
Gary Gregory created POOL-375:
-
Summary: Update optional library cglib from 3.2.12 to 3.3.0
Key: POOL-375
URL: https://issues.apache.org/jira/browse/POOL-375
Project: Commons Pool
Issue Type:
Gary Gregory created POOL-374:
-
Summary:
org.apache.commons.pool2.impl.GenericKeyedObjectPool.returnObject(K, T) should
throw IllegalStateException instead of NullPointerException when a key is not
found in the pool map
Key:
[
https://issues.apache.org/jira/browse/VFS-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916171#comment-16916171
]
Gary Gregory edited comment on VFS-727 at 8/26/19 10:06 PM:
[~elmuerte],
I
[
https://issues.apache.org/jira/browse/VFS-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916171#comment-16916171
]
Gary Gregory commented on VFS-727:
--
[~elmuerte],
I merged the PR. TY.
Gary
> Creation of singleton file
[
https://issues.apache.org/jira/browse/VFS-727?focusedWorklogId=301407=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301407
]
ASF GitHub Bot logged work on VFS-727:
--
Author: ASF GitHub Bot
garydgregory merged pull request #69: VFS-727: Replaced VFS.getManager() calls
to more local FileSystemManager access.
URL: https://github.com/apache/commons-vfs/pull/69
This is an automated message from the Apache Git
ecki commented on issue #69: VFS-727: Replaced VFS.getManager() calls to more
local FileSystemManager access.
URL: https://github.com/apache/commons-vfs/pull/69#issuecomment-524970494
I agree that we should not use the static getManager method at all, and it
is probably best to deal with
[
https://issues.apache.org/jira/browse/POOL-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916026#comment-16916026
]
Gary Gregory commented on POOL-326:
---
Roger that. Then we can make the following part of the solution:
coveralls commented on issue #448: Lang 1482
URL: https://github.com/apache/commons-lang/pull/448#issuecomment-524967253
[![Coverage
Status](https://coveralls.io/builds/25351224/badge)](https://coveralls.io/builds/25351224)
Coverage increased (+0.2%) to 95.416% when pulling
[
https://issues.apache.org/jira/browse/LANG-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916016#comment-16916016
]
Peter Verhas commented on LANG-696:
---
getShortClass name will return the name of the class without the
[
https://issues.apache.org/jira/browse/POOL-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916015#comment-16916015
]
Phil Steitz commented on POOL-326:
--
It should throw ISE, as stated in the javadoc for returnObject.
The
garydgregory commented on a change in pull request #398: Add ComparableUtils
URL: https://github.com/apache/commons-lang/pull/398#discussion_r317720783
##
File path: src/test/java/org/apache/commons/lang3/ComparableUtilsTest.java
##
@@ -0,0 +1,178 @@
+/*
+ * Licensed to
verhas commented on a change in pull request #443: Optimize string split
methods: 1. Use ThreadLocal to make reuse of th…
URL: https://github.com/apache/commons-lang/pull/443#discussion_r317719269
##
File path: src/main/java/org/apache/commons/lang3/StringUtils.java
##
@@
[
https://issues.apache.org/jira/browse/POOL-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915993#comment-16915993
]
Gary Gregory commented on POOL-326:
---
Pardon my lack of deep analysis, but should we not guard against
verhas commented on a change in pull request #448: Lang 1482
URL: https://github.com/apache/commons-lang/pull/448#discussion_r317709154
##
File path: src/main/java/org/apache/commons/lang3/Functions.java
##
@@ -143,164 +151,141 @@
}
/**
- * Converts the
verhas commented on a change in pull request #448: Lang 1482
URL: https://github.com/apache/commons-lang/pull/448#discussion_r317708414
##
File path: src/main/java/org/apache/commons/lang3/Functions.java
##
@@ -549,10 +584,26 @@ public static RuntimeException
verhas commented on a change in pull request #448: Lang 1482
URL: https://github.com/apache/commons-lang/pull/448#discussion_r317707283
##
File path: src/test/java/org/apache/commons/lang3/FunctionsTest.java
##
@@ -434,4 +492,9 @@ public void testTryWithResources() {
verhas opened a new pull request #448: Lang 1482
URL: https://github.com/apache/commons-lang/pull/448
mainly code clean up
extra tests that were missing
rethrow now corrects stack trace showing the location where the rethrow was
called
(nobody cares that an exception was thrown
PascalSchumacher commented on a change in pull request #398: Add ComparableUtils
URL: https://github.com/apache/commons-lang/pull/398#discussion_r317684506
##
File path: src/test/java/org/apache/commons/lang3/ComparableUtilsTest.java
##
@@ -0,0 +1,178 @@
+/*
+ * Licensed
markro49 commented on issue #33: Add missing Java 9 and Java 11 class file
attributes.
URL: https://github.com/apache/commons-bcel/pull/33#issuecomment-524919585
working on java 11 failures
This is an automated message from
[
https://issues.apache.org/jira/browse/BCEL-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915887#comment-16915887
]
Mark Roberts commented on BCEL-325:
---
Pull request https://github.com/apache/commons-bcel/pull/33 fixes
markro49 opened a new pull request #33: Add missing Java 9 and Java 11 class
file attributes.
URL: https://github.com/apache/commons-bcel/pull/33
Add support for several class file attributes added for Java 9 and Java 11.
At some point, may wish to add additional getters and setters.
[
https://issues.apache.org/jira/browse/POOL-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915885#comment-16915885
]
Phil Steitz commented on POOL-326:
--
Here is stack trace of the NPE
{noformat}
[java]
[
https://issues.apache.org/jira/browse/VFS-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915882#comment-16915882
]
Michiel Hendriks commented on VFS-727:
--
Already ahead of you, wanted to create a ticket number to refer
[
https://issues.apache.org/jira/browse/VFS-727?focusedWorklogId=301284=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301284
]
ASF GitHub Bot logged work on VFS-727:
--
Author: ASF GitHub Bot
elmuerte opened a new pull request #69: VFS-727: Replaced VFS.getManager()
calls to more local FileSystemManager access.
URL: https://github.com/apache/commons-vfs/pull/69
All except the call in org.apache.commons.vfs2.provider.HostFileNameParser
have been replaced to locally reachable
[
https://issues.apache.org/jira/browse/VFS-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915869#comment-16915869
]
Gary Gregory commented on VFS-727:
--
[~elmuerte],
We welcome patches on GitHub ;)
Gary
> Creation of
Michiel Hendriks created VFS-727:
Summary: Creation of singleton file system manager from providers
Key: VFS-727
URL: https://issues.apache.org/jira/browse/VFS-727
Project: Commons VFS
Issue
[
https://issues.apache.org/jira/browse/POOL-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915806#comment-16915806
]
Gary Gregory commented on POOL-326:
---
[~psteitz]
Curious: do you have a stack trace to post here?
>
[
https://issues.apache.org/jira/browse/GEOMETRY-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915767#comment-16915767
]
Gilles commented on GEOMETRY-60:
I'd prefer that we [follow this proposal on the
ham1 closed pull request #440: Fix static code issues
URL: https://github.com/apache/commons-lang/pull/440
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/LANG-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Verhas updated LANG-1482:
---
Description:
The implementation of the methods {{asRunnable()}}, {{asConsumer()}},
{{asCallable()}},
Peter Verhas created LANG-1482:
--
Summary: Functions
Key: LANG-1482
URL: https://issues.apache.org/jira/browse/LANG-1482
Project: Commons Lang
Issue Type: Bug
Components: lang.*
[
https://issues.apache.org/jira/browse/LANG-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915675#comment-16915675
]
Peter Verhas commented on LANG-1480:
As for the Travis issue:
I fixed the import * to the original as
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=301150=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301150
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
coveralls edited a comment on issue #446: LANG-1480 getAbbreviatedName
refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#issuecomment-523879388
[![Coverage
[
https://issues.apache.org/jira/browse/LANG-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Verhas updated LANG-1480:
---
Comment: was deleted
(was: I updated the code to contain only the changes that are related to the
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=301145=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301145
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915665#comment-16915665
]
Peter Verhas commented on LANG-1480:
I updated the code to contain only the changes that are related
[
https://issues.apache.org/jira/browse/LANG-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915664#comment-16915664
]
Peter Verhas commented on LANG-1480:
I updated the code to contain only the changes that are related
coveralls edited a comment on issue #446: LANG-1480 getAbbreviatedName
refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#issuecomment-523879388
[![Coverage
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=301144=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301144
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
coveralls edited a comment on issue #446: LANG-1480 getAbbreviatedName
refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#issuecomment-523879388
[![Coverage
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=301142=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301142
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
coveralls edited a comment on issue #446: LANG-1480 getAbbreviatedName
refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#issuecomment-523879388
[![Coverage
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=301141=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301141
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
coveralls edited a comment on issue #446: LANG-1480 getAbbreviatedName
refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#issuecomment-523879388
[![Coverage
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=301134=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301134
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
coveralls edited a comment on issue #446: LANG-1480 getAbbreviatedName
refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#issuecomment-523879388
[![Coverage
verhas commented on a change in pull request #446: LANG-1480 getAbbreviatedName
refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#discussion_r317534659
##
File path: src/main/java/org/apache/commons/lang3/ClassUtils.java
##
@@
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=301132=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301132
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=301130=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301130
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=301128=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301128
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=301129=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301129
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
coveralls edited a comment on issue #446: LANG-1480 getAbbreviatedName
refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#issuecomment-523879388
[![Coverage
coveralls edited a comment on issue #446: LANG-1480 getAbbreviatedName
refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#issuecomment-523879388
[![Coverage
coveralls edited a comment on issue #446: LANG-1480 getAbbreviatedName
refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#issuecomment-523879388
[![Coverage
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=301127=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301127
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
coveralls edited a comment on issue #446: LANG-1480 getAbbreviatedName
refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#issuecomment-523879388
[![Coverage
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=301125=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301125
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
kinow commented on a change in pull request #446: LANG-1480 getAbbreviatedName
refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#discussion_r317530498
##
File path: src/main/java/org/apache/commons/lang3/ClassUtils.java
##
@@
[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=301114=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301114
]
ASF GitHub Bot logged work on LANG-1480:
Author: ASF GitHub Bot
verhas commented on a change in pull request #446: LANG-1480 getAbbreviatedName
refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#discussion_r317522502
##
File path: src/main/java/org/apache/commons/lang3/ClassUtils.java
##
@@
Stzx commented on a change in pull request #434: Fixed a problem when parsing
Chinese using the ToStringStyle.JSON_STYLE
URL: https://github.com/apache/commons-lang/pull/434#discussion_r317503278
##
File path: src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java
[
https://issues.apache.org/jira/browse/LANG-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915513#comment-16915513
]
Bruno P. Kinoshita commented on LANG-1480:
--
Peter, if this is fixing the code, and bringing the
[
https://issues.apache.org/jira/browse/LANG-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915512#comment-16915512
]
Bruno P. Kinoshita commented on LANG-1478:
--
It was pointed in the mailing list that this is
[
https://issues.apache.org/jira/browse/LANG-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915506#comment-16915506
]
Peter Verhas commented on LANG-1480:
Here more than there. This is a change that, imho, should NOT go
[
https://issues.apache.org/jira/browse/LANG-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915505#comment-16915505
]
Peter Verhas commented on LANG-1478:
It is not only that case. It is in every case where `a.b.c.ddd.
[
https://issues.apache.org/jira/browse/COMPRESS-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915504#comment-16915504
]
Juha Syrjälä commented on COMPRESS-491:
---
Related discussion:
Juha Syrjälä created COMPRESS-491:
-
Summary: Deflate64CompressorInputStream.read(byte[]) works
incorrectly
Key: COMPRESS-491
URL: https://issues.apache.org/jira/browse/COMPRESS-491
Project: Commons
80 matches
Mail list logo