[jira] [Closed] (FLINK-12328) Invalid Express

2019-04-25 Thread chauncy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chauncy closed FLINK-12328. --- Resolution: Invalid > Invalid Express > --- > > Key: FLINK-12328 >

[GitHub] [flink] zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-25 Thread GitBox
zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#discussion_r278806215 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-25 Thread GitBox
zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#discussion_r278804998 ## File path:

[GitHub] [flink] xuefuz commented on issue #8275: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on issue #8275: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8275#issuecomment-486919103 This is to replace PR https://github.com/apache/flink/pull/8212. cc: @JingsongLi @KurtYoung

[jira] [Commented] (FLINK-11974) Introduce StreamOperatorFactory to help table perform the whole Operator CodeGen

2019-04-25 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826621#comment-16826621 ] Kurt Young commented on FLINK-11974: Regarding #2: I'm wondering why we want to git rid of setup()

[GitHub] [flink] zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-25 Thread GitBox
zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#discussion_r278800356 ## File path:

[GitHub] [flink] xuefuz commented on issue #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on issue #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#issuecomment-486913258 I had to rebase my fork to resolve the conflicts. Doing so, however, I had to do a forced push, which avoided this PR. I created a

[GitHub] [flink] flinkbot commented on issue #8275: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
flinkbot commented on issue #8275: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8275#issuecomment-486912987 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-25 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r278782559 ## File path: docs/dev/table/tableApi.md

[GitHub] [flink] xuefuz opened a new pull request #8275: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz opened a new pull request #8275: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8275 ## What is the purpose of the change As a followup for FLINK-11474 and its PR#8007, this PR adds additional catalog APIs for

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-25 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r278795877 ## File path:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-25 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r278796916 ## File path:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-25 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r278782653 ## File path:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-25 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r278793531 ## File path:

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-25 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r278793705 ## File path:

[jira] [Commented] (FLINK-12319) StackOverFlowError in cep.nfa.sharedbuffer.SharedBuffer

2019-04-25 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826610#comment-16826610 ] Liya Fan commented on FLINK-12319: -- Hi [~mpf], thanks again for the additional information.  It seems

[GitHub] [flink] Kejian-Li opened a new pull request #8274: [FLIKN-12306][Runtime] Change the name of variable log into LOG

2019-04-25 Thread GitBox
Kejian-Li opened a new pull request #8274: [FLIKN-12306][Runtime] Change the name of variable log into LOG URL: https://github.com/apache/flink/pull/8274 ## What is the purpose of the change A trivial improvement that changes the name of variable "log" into "LOG" to

[GitHub] [flink] flinkbot commented on issue #8274: [FLIKN-12306][Runtime] Change the name of variable log into LOG

2019-04-25 Thread GitBox
flinkbot commented on issue #8274: [FLIKN-12306][Runtime] Change the name of variable log into LOG URL: https://github.com/apache/flink/pull/8274#issuecomment-486910585 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[jira] [Commented] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-04-25 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826608#comment-16826608 ] vinoyang commented on FLINK-11935: -- Yes, what do you think? > Remove DateTimeUtils pull-in and fix

[jira] [Commented] (FLINK-12334) change to MockStreamTask breaks OneInputStreamOperatorTestHarness

2019-04-25 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826606#comment-16826606 ] Liya Fan commented on FLINK-12334: -- Hi [~cre...@gmail.com], thanks for opening this issue. Would you

[jira] [Commented] (FLINK-11611) Translate the "Batch Examples" page into Chinese

2019-04-25 Thread Xin Ma (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826605#comment-16826605 ] Xin Ma commented on FLINK-11611: Hi [~jark] I have completed the first translation. > Translate the

[jira] [Comment Edited] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-04-25 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826601#comment-16826601 ] Rong Rong edited comment on FLINK-11935 at 4/26/19 2:57 AM: hmm. I might've

[jira] [Commented] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-04-25 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826601#comment-16826601 ] Rong Rong commented on FLINK-11935: --- hmm. I might've misunderstood some details. Are you suggesting

[jira] [Commented] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-04-25 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826599#comment-16826599 ] vinoyang commented on FLINK-11935: -- Hi [~walterddr] Actually, my idea is to keep it as an option, let

[GitHub] [flink] shixiaogang commented on issue #8269: [FLINK-12285][test] Harden savepoint relevant test cases by explicitly canceling test job

2019-04-25 Thread GitBox
shixiaogang commented on issue #8269: [FLINK-12285][test] Harden savepoint relevant test cases by explicitly canceling test job URL: https://github.com/apache/flink/pull/8269#issuecomment-486906606 > most of these should have no positive effect since the `MiniClusterResource` is shut down

[jira] [Updated] (FLINK-11611) Translate the "Batch Examples" page into Chinese

2019-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11611: --- Labels: pull-request-available (was: ) > Translate the "Batch Examples" page into Chinese

[GitHub] [flink] flinkbot commented on issue #8273: [FLINK-11611] [docs] Translate the "Batch Examples" page into Chinese

2019-04-25 Thread GitBox
flinkbot commented on issue #8273: [FLINK-11611] [docs] Translate the "Batch Examples" page into Chinese URL: https://github.com/apache/flink/pull/8273#issuecomment-486905909 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] luvex opened a new pull request #8273: [FLINK-11611] [docs] Translate the "Batch Examples" page into Chinese

2019-04-25 Thread GitBox
luvex opened a new pull request #8273: [FLINK-11611] [docs] Translate the "Batch Examples" page into Chinese URL: https://github.com/apache/flink/pull/8273 ## What is the purpose of the change This pull request translates the batch example page into Chinese. ##

[jira] [Comment Edited] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-04-25 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826516#comment-16826516 ] Rong Rong edited comment on FLINK-11935 at 4/26/19 2:19 AM: Hi [~yanghua], I

[jira] [Comment Edited] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-04-25 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826516#comment-16826516 ] Rong Rong edited comment on FLINK-11935 at 4/26/19 2:18 AM: Hi [~yanghua], I

[GitHub] [flink] xuefuz closed pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz closed pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] KurtYoung commented on a change in pull request #8179: [FLINK-12200] [Table-planner] Support UNNEST for MAP types

2019-04-25 Thread GitBox
KurtYoung commented on a change in pull request #8179: [FLINK-12200] [Table-planner] Support UNNEST for MAP types URL: https://github.com/apache/flink/pull/8179#discussion_r278783132 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8179: [FLINK-12200] [Table-planner] Support UNNEST for MAP types

2019-04-25 Thread GitBox
KurtYoung commented on a change in pull request #8179: [FLINK-12200] [Table-planner] Support UNNEST for MAP types URL: https://github.com/apache/flink/pull/8179#discussion_r278782753 ## File path:

[GitHub] [flink] Myasuka commented on a change in pull request #8272: [FLINK-12274] Fix documentation to enable Queryable State

2019-04-25 Thread GitBox
Myasuka commented on a change in pull request #8272: [FLINK-12274] Fix documentation to enable Queryable State URL: https://github.com/apache/flink/pull/8272#discussion_r278782171 ## File path: docs/dev/stream/state/queryable_state.md ## @@ -69,10 +69,12 @@ response back

[GitHub] [flink] Myasuka commented on a change in pull request #8272: [FLINK-12274] Fix documentation to enable Queryable State

2019-04-25 Thread GitBox
Myasuka commented on a change in pull request #8272: [FLINK-12274] Fix documentation to enable Queryable State URL: https://github.com/apache/flink/pull/8272#discussion_r278782171 ## File path: docs/dev/stream/state/queryable_state.md ## @@ -69,10 +69,12 @@ response back

[GitHub] [flink] Myasuka commented on a change in pull request #8272: [FLINK-12274] Fix documentation to enable Queryable State

2019-04-25 Thread GitBox
Myasuka commented on a change in pull request #8272: [FLINK-12274] Fix documentation to enable Queryable State URL: https://github.com/apache/flink/pull/8272#discussion_r278782170 ## File path: docs/dev/stream/state/queryable_state.md ## @@ -69,10 +69,12 @@ response back

[GitHub] [flink] JingsongLi commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
JingsongLi commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278782161 ## File path:

[GitHub] [flink] JingsongLi commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
JingsongLi commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278782143 ## File path:

[GitHub] [flink] tianchen92 commented on issue #8219: [FLINK-10441]Don't log warning when creating upload directory

2019-04-25 Thread GitBox
tianchen92 commented on issue #8219: [FLINK-10441]Don't log warning when creating upload directory URL: https://github.com/apache/flink/pull/8219#issuecomment-486890525 Thanks for your reply @zentol, I have resolved the comments, please have a look.

[GitHub] [flink] flinkbot edited a comment on issue #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
flinkbot edited a comment on issue #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#issuecomment-484544644 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[GitHub] [flink] JingsongLi commented on issue #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
JingsongLi commented on issue #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#issuecomment-486890255 @xuefuz please resolve the conflicts This is an automated

[GitHub] [flink] JingsongLi commented on issue #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
JingsongLi commented on issue #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#issuecomment-486890214 @flinkbot attention @KurtYoung This is an automated message

[GitHub] [flink] flinkbot edited a comment on issue #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-25 Thread GitBox
flinkbot edited a comment on issue #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#issuecomment-486582161 Thanks a lot for your contribution to the Apache Flink project. I'm

[jira] [Commented] (FLINK-11935) Remove DateTimeUtils pull-in and fix datetime casting problem

2019-04-25 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826516#comment-16826516 ] Rong Rong commented on FLINK-11935: --- Hi [~yanghua], I understand what you said. I think to summarize

[GitHub] [flink] flinkbot commented on issue #8272: [FLINK-12274] Fix documentation to enable Queryable State

2019-04-25 Thread GitBox
flinkbot commented on issue #8272: [FLINK-12274] Fix documentation to enable Queryable State URL: https://github.com/apache/flink/pull/8272#issuecomment-486846727 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[jira] [Updated] (FLINK-12274) Fix documentation to enable Queryable State

2019-04-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12274: --- Labels: pull-request-available (was: ) > Fix documentation to enable Queryable State >

[GitHub] [flink] PierreZ opened a new pull request #8272: [FLINK-12274] Fix documentation to enable Queryable State

2019-04-25 Thread GitBox
PierreZ opened a new pull request #8272: [FLINK-12274] Fix documentation to enable Queryable State URL: https://github.com/apache/flink/pull/8272 ## What is the purpose of the change Queryable state, since 1.8, now need to be enable through configuration. This add the right

[jira] [Created] (FLINK-12334) change to MockStreamTask breaks OneInputStreamOperatorTestHarness

2019-04-25 Thread Cliff Resnick (JIRA)
Cliff Resnick created FLINK-12334: - Summary: change to MockStreamTask breaks OneInputStreamOperatorTestHarness Key: FLINK-12334 URL: https://issues.apache.org/jira/browse/FLINK-12334 Project: Flink

[GitHub] [flink] xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278722515 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278722430 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278722342 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278722293 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278722212 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278721994 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278721918 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs

2019-04-25 Thread GitBox
xuefuz commented on a change in pull request #8212: [FLINK-11519][table] Add function related catalog APIs URL: https://github.com/apache/flink/pull/8212#discussion_r278720766 ## File path:

[GitHub] [flink] bowenli86 commented on issue #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-25 Thread GitBox
bowenli86 commented on issue #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#issuecomment-486795425 Thanks @zentol for the feedbacks! I've addressed them by

[GitHub] [flink] lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex

2019-04-25 Thread GitBox
lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex URL: https://github.com/apache/flink/pull/8268#discussion_r278663085 ## File path:

[GitHub] [flink] lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex

2019-04-25 Thread GitBox
lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex URL: https://github.com/apache/flink/pull/8268#discussion_r278663085 ## File path:

[GitHub] [flink] lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex

2019-04-25 Thread GitBox
lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex URL: https://github.com/apache/flink/pull/8268#discussion_r278663085 ## File path:

[GitHub] [flink] lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex

2019-04-25 Thread GitBox
lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex URL: https://github.com/apache/flink/pull/8268#discussion_r278663085 ## File path:

[GitHub] [flink] lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex

2019-04-25 Thread GitBox
lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex URL: https://github.com/apache/flink/pull/8268#discussion_r278663085 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-25 Thread GitBox
bowenli86 commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#discussion_r278654915 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-25 Thread GitBox
bowenli86 commented on a change in pull request #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#discussion_r278654915 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-25 Thread GitBox
azagrebin commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#discussion_r278627976 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-25 Thread GitBox
azagrebin commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#discussion_r278618535 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-25 Thread GitBox
azagrebin commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#discussion_r278620145 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-25 Thread GitBox
azagrebin commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#discussion_r278636171 ## File path:

[GitHub] [flink] art4ul commented on a change in pull request #8179: [FLINK-12200] [Table-planner] Support UNNEST for MAP types

2019-04-25 Thread GitBox
art4ul commented on a change in pull request #8179: [FLINK-12200] [Table-planner] Support UNNEST for MAP types URL: https://github.com/apache/flink/pull/8179#discussion_r278625671 ## File path:

[GitHub] [flink] lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486731333 @tillrohrmann, BTW, if you want to get the NPE stacktrace, you need to use

[GitHub] [flink] lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486731333 @tillrohrmann, BTW, if you want to get the NPE stacktrace, you need to use log4j

[GitHub] [flink] azagrebin commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-25 Thread GitBox
azagrebin commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#discussion_r278615592 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-25 Thread GitBox
zhijiangW commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#discussion_r278614937 ## File path:

[GitHub] [flink] lamber-ken removed a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
lamber-ken removed a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486716231 @tillrohrmann, here is original NPE stacktrace. ```

[GitHub] [flink] lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486714974 hi, @tillrohrmann **First**, the original exception is NPE which as

[GitHub] [flink] lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486714974 hi, @tillrohrmann **First**, the original exception is NPE which as

[GitHub] [flink] zhijiangW commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-25 Thread GitBox
zhijiangW commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#discussion_r278611563 ## File path:

[GitHub] [flink] lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486723700 > The `HistoryServerArchivist` is not supposed to throw any exceptions. If

[GitHub] [flink] zhijiangW commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-25 Thread GitBox
zhijiangW commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#discussion_r278610658 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-25 Thread GitBox
zhijiangW commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#discussion_r278610383 ## File path:

[GitHub] [flink] lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486723700 > The `HistoryServerArchivist` is not supposed to throw any exceptions. If it

[GitHub] [flink] TisonKun commented on issue #8264: [hotfix][yarn] userJarFiles can be a local variable

2019-04-25 Thread GitBox
TisonKun commented on issue #8264: [hotfix][yarn] userJarFiles can be a local variable URL: https://github.com/apache/flink/pull/8264#issuecomment-486719685 @tillrohrmann thanks for your review! I accidentally added a force push on this pr. Sorry and please check if conflict :(

[jira] [Commented] (FLINK-12152) Make the vcore that Application Master used configurable for Flink on YARN

2019-04-25 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826150#comment-16826150 ] vinoyang commented on FLINK-12152: -- [~till.rohrmann] We tried to view JobManager's log from Flink web

[GitHub] [flink] lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486716231 @tillrohrmann, here is original NPE stacktrace. ```

[jira] [Created] (FLINK-12333) Add documentation around save point with cancel lifecycle through REST

2019-04-25 Thread Vishal Santoshi (JIRA)
Vishal Santoshi created FLINK-12333: --- Summary: Add documentation around save point with cancel lifecycle through REST Key: FLINK-12333 URL: https://issues.apache.org/jira/browse/FLINK-12333

[GitHub] [flink] lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486714974 hi, @tillrohrmann **First**, the original exception is NEP which as

[GitHub] [flink] link3280 commented on issue #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem

2019-04-25 Thread GitBox
link3280 commented on issue #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem URL: https://github.com/apache/flink/pull/8068#issuecomment-486714206 @tillrohrmann Thanks for your review. I've updated the PR as requested :)

[GitHub] [flink] tillrohrmann commented on a change in pull request #8264: [hotfix][yarn] userJarFiles can be a local variable

2019-04-25 Thread GitBox
tillrohrmann commented on a change in pull request #8264: [hotfix][yarn] userJarFiles can be a local variable URL: https://github.com/apache/flink/pull/8264#discussion_r278591668 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java

[GitHub] [flink] tillrohrmann commented on issue #8105: [FLINK-11309][core] Make blocking result partitions consumable

2019-04-25 Thread GitBox
tillrohrmann commented on issue #8105: [FLINK-11309][core] Make blocking result partitions consumable URL: https://github.com/apache/flink/pull/8105#issuecomment-486706800 @eaglewatcherwb would it be ok to close this PR until we have resolved the discussion on the respective JIRA issue?

[GitHub] [flink] lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex

2019-04-25 Thread GitBox
lamber-ken commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex URL: https://github.com/apache/flink/pull/8268#discussion_r278589801 ## File path:

[jira] [Updated] (FLINK-12329) Netty thread deadlock bug of the SpilledSubpartitionView

2019-04-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-12329: -- Priority: Critical (was: Major) > Netty thread deadlock bug of the SpilledSubpartitionView >

[jira] [Commented] (FLINK-12152) Make the vcore that Application Master used configurable for Flink on YARN

2019-04-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826130#comment-16826130 ] Till Rohrmann commented on FLINK-12152: --- Which rest handler are you calling in your example? Do

[GitHub] [flink] tillrohrmann commented on a change in pull request #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem

2019-04-25 Thread GitBox
tillrohrmann commented on a change in pull request #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem URL: https://github.com/apache/flink/pull/8068#discussion_r278584311 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem

2019-04-25 Thread GitBox
tillrohrmann commented on a change in pull request #8068: [FLINK-12042][StateBackends] Fix RocksDBStateBackend's mistaken usage of default filesystem URL: https://github.com/apache/flink/pull/8068#discussion_r278583994 ## File path:

[GitHub] [flink] tillrohrmann commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-25 Thread GitBox
tillrohrmann commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-486700679 The `HistoryServerArchivist` is not supposed to throw any exceptions. If it

[GitHub] [flink] tillrohrmann commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex

2019-04-25 Thread GitBox
tillrohrmann commented on a change in pull request #8268: [FLINK-12246][runtime] Fix can't get max_attempts_history_size value when create ExecutionVertex URL: https://github.com/apache/flink/pull/8268#discussion_r278579197 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-25 Thread GitBox
azagrebin commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#discussion_r278558571 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-25 Thread GitBox
azagrebin commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#discussion_r278556540 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-25 Thread GitBox
azagrebin commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#discussion_r278550998 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes

2019-04-25 Thread GitBox
azagrebin commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes URL: https://github.com/apache/flink/pull/8181#discussion_r278547875 ## File path:

  1   2   3   >