Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45970656
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java
---
@@ -44,16 +45,30 @@
/** The schema (ie, ordered
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45970389
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/FlinkTopologyContext.java
---
@@ -27,13 +27,12 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45965523
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/FlinkTopologyContext.java
---
@@ -27,13 +27,12 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45965316
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/print/PrintSampleStream.java
---
@@ -0,0 +1,61 @@
+/**
+ * Licensed
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45896492
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,474 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45895556
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,474 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45894573
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/StormTupleTest.java
---
@@ -613,29 +611,29 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45894174
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java
---
@@ -44,16 +45,30 @@
/** The schema (ie, ordered
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45893951
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/SpoutWrapperTest.java
---
@@ -21,7 +21,6 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45893875
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/util/TestSink.java
---
@@ -16,16 +16,16 @@
*/
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45893806
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/TestSpout.java
---
@@ -16,13 +16,13 @@
*/
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45893834
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/util/TestDummyBolt.java
---
@@ -26,6 +24,8 @@
import backtype.storm.tuple.Tuple
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45893853
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/util/TestDummySpout.java
---
@@ -26,6 +24,8 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45893736
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/FlinkTopologyTest.java
---
@@ -14,50 +14,70 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45893790
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/TestBolt.java
---
@@ -16,14 +16,14 @@
*/
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45893753
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/FlinkTopologyTest.java
---
@@ -14,50 +14,70 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45892009
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/FlinkTopologyTest.java
---
@@ -14,50 +14,70 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45891849
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/api/FlinkOutputFieldsDeclarerTest.java
---
@@ -18,9 +18,7 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45891225
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java
---
@@ -44,16 +45,30 @@
/** The schema (ie, ordered
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45891117
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/SpoutWrapper.java
---
@@ -33,7 +30,8 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45891069
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/SpoutCollector.java
---
@@ -18,7 +18,6 @@
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45891019
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/SetupOutputFieldsDeclarer.java
---
@@ -17,12 +17,12 @@
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45890996
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/FlinkTopologyContext.java
---
@@ -27,13 +27,12 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45890935
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapperTwoInput.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed to
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45890812
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapperTwoInput.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed to
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45890399
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -108,20 +112,19 @@ public BoltWrapper(final
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45890269
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -89,17 +94,16 @@ public BoltWrapper(final IRichBolt
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45890289
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -108,20 +112,19 @@ public BoltWrapper(final
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45890041
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -89,17 +94,16 @@ public BoltWrapper(final IRichBolt
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45889924
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -77,11 +80,13 @@
*
* @param bolt
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45889838
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -53,21 +51,26 @@
private static final long
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45889473
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltCollector.java
---
@@ -19,7 +19,6 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45889142
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,474 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r4594
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,474 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45888777
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,474 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45887969
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkOutputFieldsDeclarer.java
---
@@ -20,11 +20,9 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45887487
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkLocalCluster.java
---
@@ -99,6 +111,7 @@ public void rebalance(final String
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45886799
--- Diff:
flink-contrib/flink-storm-examples/src/test/java/org/apache/flink/storm/split/SplitBolt.java
---
@@ -17,8 +17,6 @@
*/
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45886615
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/operators/WordCountFileSpout.java
---
@@ -17,10 +17,9
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45886597
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/operators/WordCountDataPojos.java
---
@@ -17,10 +17,10
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45886536
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/SpoutSourceWordCount.java
---
@@ -19,7 +19,6 @@
import
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45886387
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/wordcount/WordCountLocal.java
---
@@ -57,16 +57,13 @@ public static void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45885615
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/split/operators/RandomSpout.java
---
@@ -17,9 +17,6 @@
*/
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45885626
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/split/operators/VerifyAndEnrichBolt.java
---
@@ -17,8 +17,6
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45885529
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/print/PrintSampleStream.java
---
@@ -0,0 +1,61 @@
+/**
+ * Licensed
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45758926
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45744427
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45742093
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45740805
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/join/SingleJoinExample.java
---
@@ -0,0 +1,86 @@
+/**
+ * Licensed
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45735762
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/BoltFileSink.java
---
@@ -18,20 +18,23 @@
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45734993
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FileSpout.java
---
@@ -38,6 +38,8 @@
protected String path
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45733970
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/StormTupleTest.java
---
@@ -595,7 +593,7 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45733444
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/join/SingleJoinExample.java
---
@@ -0,0 +1,86 @@
+/**
+ * Licensed
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45733215
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45732952
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/StormTupleTest.java
---
@@ -595,7 +593,7 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45732428
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -187,14 +190,15 @@ static synchronized
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45732371
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -150,7 +153,7 @@ static synchronized
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45732254
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java
---
@@ -44,6 +45,21 @@
/** The schema (ie, ordered
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45731988
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -75,11 +78,13 @@
*
* @param bolt
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45731894
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,468 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45731878
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,468 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45731544
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkLocalCluster.java
---
@@ -48,12 +49,10 @@
private static final
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45731351
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkClient.java
---
@@ -183,10 +183,10 @@ public void submitTopologyWithOpts
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45731348
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkClient.java
---
@@ -183,10 +183,10 @@ public void submitTopologyWithOpts
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45731264
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FiniteFileSpout.java
---
@@ -32,46 +23,17 @@
public class
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45731094
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FileSpout.java
---
@@ -38,6 +38,8 @@
protected String path
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45730899
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/BoltFileSink.java
---
@@ -40,16 +43,17 @@ public BoltFileSink(final
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45730807
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/BoltFileSink.java
---
@@ -18,20 +18,23 @@
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45728449
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,468 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45727477
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/WrapperSetupHelperTest.java
---
@@ -180,8 +178,6 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45727399
--- Diff:
flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/StormTupleTest.java
---
@@ -595,7 +593,7 @@ public void
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45727164
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -187,14 +190,15 @@ static synchronized
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45727099
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/WrapperSetupHelper.java
---
@@ -150,7 +153,7 @@ static synchronized
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45727062
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/StormTuple.java
---
@@ -44,6 +45,21 @@
/** The schema (ie, ordered
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45726840
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/wrappers/BoltWrapper.java
---
@@ -75,11 +78,13 @@
*
* @param bolt
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45726600
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,468 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45726538
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkTopology.java
---
@@ -15,75 +16,468 @@
* See the License for the
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45726196
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkLocalCluster.java
---
@@ -48,12 +49,10 @@
private static final
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45726133
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkClient.java
---
@@ -183,10 +183,10 @@ public void submitTopologyWithOpts
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45726093
--- Diff:
flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkClient.java
---
@@ -183,10 +183,10 @@ public void submitTopologyWithOpts
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45725866
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FiniteFileSpout.java
---
@@ -32,46 +23,17 @@
public class
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45725806
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/FileSpout.java
---
@@ -38,6 +38,8 @@
protected String path
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45725539
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/BoltFileSink.java
---
@@ -40,16 +43,17 @@ public BoltFileSink(final
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45725506
--- Diff:
flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/util/BoltFileSink.java
---
@@ -18,20 +18,23 @@
package
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45724616
--- Diff: docs/apis/storm_compatibility.md ---
@@ -57,20 +57,22 @@ See *WordCount Storm* within
`flink-storm-examples/pom.xml` for an example how t
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1398#discussion_r45720083
--- Diff: docs/apis/storm_compatibility.md ---
@@ -57,20 +57,22 @@ See *WordCount Storm* within
`flink-storm-examples/pom.xml` for an example how t
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1387#issuecomment-159226912
@StephanEwen In the original code that was actually the case. The
`BoltWrapper` receiving the data was able to extract the tuples by itself. This
got changed as I
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r45640243
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.jade ---
@@ -43,6 +43,10 @@
nav.navbar.navbar-default.navbar-fixed-top.navbar-main(ng-if=&quo
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r45639008
--- Diff: flink-runtime-web/web-dashboard/web/partials/jobs/job.html ---
@@ -32,7 +32,7 @@
-
{{ job['end-time'] | amDateFormat:&
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r45635645
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -188,9 +189,12 @@ public WebRuntimeMonitor
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r45635435
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
---
@@ -188,9 +189,12 @@ public WebRuntimeMonitor
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/750#discussion_r45635078
--- Diff: flink-runtime-web/web-dashboard/app/partials/jobs/job.jade ---
@@ -43,6 +43,10 @@
nav.navbar.navbar-default.navbar-fixed-top.navbar-main(ng-if=&quo
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1387#issuecomment-158952162
That's actually not a stupid question. I did not do it in the first place
to avoid "redundant" code (I was not aware that Flink changes names). I just
cha
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-158929824
I just investigated the failing test. The test is new and passed up to
know. @uce changed `ExecutionGraph.cancel()` recently, allowing to cancel a job
when it is in state
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-158913013
@sachingoel0101 Is the UI change ok?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/750#issuecomment-158912414
Just rebased. Can you please review @StephanEwen @tillrohrmann
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1387#issuecomment-158538344
Btw: Travis fails due to a instable test -- I already create a JIRA for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1387#issuecomment-158538063
I don't understand you comment? What you describe is exactly how it works
(even before this PR). The problem was actually just a missing
`TypeInformation` I added
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1157#issuecomment-158127308
@HuangWHWHW What is the state of this PR? If you don't want to finish this,
please close the PR (you can reopen a new PR any time later if you start to
work on it
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1387#issuecomment-158126101
In `FlinkTopologyBuilder` I had to introduce a *token* for operator names
which is used in `WrapperSetupHelper` to get the original name of an operator
(Flink changes
301 - 400 of 735 matches
Mail list logo
