GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/5132
[FLINK-8203] [FLINK-7681] [table] Make schema definition of
DataStream/DataSet to Table conversion more flexible
## What is the purpose of the change
This PR makes the schema definition
[
https://issues.apache.org/jira/browse/FLINK-8089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281726#comment-16281726
]
ASF GitHub Bot commented on FLINK-8089:
---
Github user GJL commented on a diff in the pull request:
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5090#discussion_r155495322
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotPoolTest.java
---
@@ -383,6 +386,76 @@ public void
Github user harborl closed the pull request at:
https://github.com/apache/flink/pull/5047
---
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5068#discussion_r155490712
--- Diff:
flink-connectors/flink-orc/src/test/java/org/apache/flink/orc/OrcTableSourceTest.java
---
@@ -155,11 +160,14 @@ public void testProjectFields()
[
https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281719#comment-16281719
]
ASF GitHub Bot commented on FLINK-8122:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281722#comment-16281722
]
ASF GitHub Bot commented on FLINK-8122:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281717#comment-16281717
]
ASF GitHub Bot commented on FLINK-8122:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281721#comment-16281721
]
ASF GitHub Bot commented on FLINK-8122:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281716#comment-16281716
]
ASF GitHub Bot commented on FLINK-8122:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281720#comment-16281720
]
ASF GitHub Bot commented on FLINK-8122:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281718#comment-16281718
]
ASF GitHub Bot commented on FLINK-8122:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5068#discussion_r155491207
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/TableSink.scala
---
@@ -45,6 +45,10 @@ trait TableSink[T] {
/**
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5068#discussion_r155493818
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/TableSinkITCase.scala
---
@@ -583,7 +583,7 @@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5068#discussion_r155489738
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSinkTestBase.java
---
@@ -54,6
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5068#discussion_r155492981
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraAppendTableSink.java
---
@@
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5068#discussion_r155493746
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/table/TableSourceITCase.scala
---
@@ -58,7 +58,7 @@ class
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5068#discussion_r155489914
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSourceTestBase.java
---
@@ -62,13
[
https://issues.apache.org/jira/browse/FLINK-7681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timo Walther reassigned FLINK-7681:
---
Assignee: Timo Walther
> Support arbitrary TypeInformation in Table API
>
[
https://issues.apache.org/jira/browse/FLINK-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281652#comment-16281652
]
ASF GitHub Bot commented on FLINK-8133:
---
Github user kl0u commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281655#comment-16281655
]
ASF GitHub Bot commented on FLINK-8133:
---
Github user kl0u commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281651#comment-16281651
]
ASF GitHub Bot commented on FLINK-8133:
---
Github user kl0u commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281653#comment-16281653
]
ASF GitHub Bot commented on FLINK-8133:
---
Github user kl0u commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281654#comment-16281654
]
ASF GitHub Bot commented on FLINK-8133:
---
Github user kl0u commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281658#comment-16281658
]
ASF GitHub Bot commented on FLINK-8133:
---
Github user kl0u commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281657#comment-16281657
]
ASF GitHub Bot commented on FLINK-8133:
---
Github user kl0u commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281656#comment-16281656
]
ASF GitHub Bot commented on FLINK-8133:
---
Github user kl0u commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281659#comment-16281659
]
ASF GitHub Bot commented on FLINK-8133:
---
Github user kl0u commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281648#comment-16281648
]
ASF GitHub Bot commented on FLINK-8133:
---
Github user zentol commented on the issue:
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5052#discussion_r155482395
--- Diff: flink-docs/README.md ---
@@ -0,0 +1,36 @@
+
+
+# Documentation generators
+
+This module contains generators that create HTML
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5052#discussion_r155482662
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestServerEndpoint.java
---
@@ -317,7 +317,21 @@ public int compare(
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5052#discussion_r155482491
--- Diff: flink-docs/README.md ---
@@ -0,0 +1,36 @@
+
+
+# Documentation generators
+
+This module contains generators that create HTML
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5052#discussion_r155483634
--- Diff:
flink-docs/src/main/java/org/apache/flink/docs/rest/RestAPIDocGenerator.java ---
@@ -0,0 +1,315 @@
+/*
+ * Licensed to the Apache Software
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5052#discussion_r155483740
--- Diff:
flink-docs/src/main/java/org/apache/flink/docs/rest/RestAPIDocGenerator.java ---
@@ -0,0 +1,315 @@
+/*
+ * Licensed to the Apache Software
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5052#discussion_r155482310
--- Diff: flink-docs/README.md ---
@@ -0,0 +1,36 @@
+
+
+# Documentation generators
+
+This module contains generators that create HTML
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5052#discussion_r155482231
--- Diff: flink-docs/README.md ---
@@ -0,0 +1,36 @@
+
+
+# Documentation generators
+
+This module contains generators that create HTML
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5052#discussion_r155482058
--- Diff: flink-docs/README.md ---
@@ -0,0 +1,36 @@
+
+
+# Documentation generators
+
+This module contains generators that create HTML
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5052#discussion_r155483284
--- Diff:
flink-docs/src/main/java/org/apache/flink/docs/rest/RestAPIDocGenerator.java ---
@@ -0,0 +1,315 @@
+/*
+ * Licensed to the Apache Software
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5052
Since you found no errors I would like to merge it as is (including the
changes to `rest_api.md`) and iterate upon it in follow-ups. My goal was not to
provide a picture-perfect documentation, but to
[
https://issues.apache.org/jira/browse/FLINK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281628#comment-16281628
]
ASF GitHub Bot commented on FLINK-8139:
---
Github user fhueske commented on the issue:
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5065
Hmm, I agree with @twalthr. Adding these checks when a DataSet/DataStream
is imported would prevent valid queries (e.g., those that to simple
transformations). I would not add a config switch to
[
https://issues.apache.org/jira/browse/FLINK-8205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281624#comment-16281624
]
Kostas Kloudas edited comment on FLINK-8205 at 12/7/17 10:13 AM:
-
Actually
[
https://issues.apache.org/jira/browse/FLINK-8205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281624#comment-16281624
]
Kostas Kloudas commented on FLINK-8205:
---
Actually if you want to work on it, I would be more than
[
https://issues.apache.org/jira/browse/FLINK-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281579#comment-16281579
]
ASF GitHub Bot commented on FLINK-8133:
---
Github user kl0u commented on the issue:
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5052
From what I understand, this PR is just for the tooling, and not for the
actual content.
So the changes in the `test_api.md` are just a mock to see how it would
look.
If this is correct,
[
https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281560#comment-16281560
]
ASF GitHub Bot commented on FLINK-7468:
---
Github user zhijiangW commented on the issue:
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/4559
Or we make the backlog as `AtomicInteger` to keep the current process,
otherwise we may need to call `decreaseStatistics` in different parts in the
region of `synchronized(buffers)` . What do you
[
https://issues.apache.org/jira/browse/FLINK-8215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281537#comment-16281537
]
Timo Walther commented on FLINK-8215:
-
I think the Table API should not support automatic type
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/4559
@NicoK @pnowojski , for backlog thread-safe issue, the current
implementation is not thread-safe and we should restore my previous
implementation that calls `decreaseStatistics` inside the method
[
https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281505#comment-16281505
]
ASF GitHub Bot commented on FLINK-7468:
---
Github user zhijiangW commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281502#comment-16281502
]
ASF GitHub Bot commented on FLINK-7468:
---
Github user zhijiangW commented on a diff in the pull
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r155458048
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionView.java
---
@@ -145,6 +145,10 @@ public Buffer
[
https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281490#comment-16281490
]
ASF GitHub Bot commented on FLINK-7468:
---
Github user zhijiangW commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281492#comment-16281492
]
ASF GitHub Bot commented on FLINK-7468:
---
Github user zhijiangW commented on a diff in the pull
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r155454935
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultSubpartitionView.java
---
@@ -22,32 +22,57 @@
import
Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r155454886
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartitionView.java
---
@@ -39,13 +39,15 @@
[
https://issues.apache.org/jira/browse/FLINK-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281480#comment-16281480
]
ASF GitHub Bot commented on FLINK-8218:
---
GitHub user bowenli86 opened a pull request:
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5131
[FLINK-8218] move flink-connector-kinesis examples from /src to /test
## What is the purpose of the change
just saw there are runnable examples in src tree and traced back to this
PR. I
[
https://issues.apache.org/jira/browse/FLINK-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281477#comment-16281477
]
ASF GitHub Bot commented on FLINK-7749:
---
Github user pnowojski commented on a diff in the pull
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/5069
My apologies! Silly mistake at late night when the brain is quite
inactive I forgot to check the files history, and thought this PR (which
shows as latest commit) added those examples...
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5127#discussion_r155451532
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
@@ -187,8 +187,6 @@
private final ResultPartition[]
[
https://issues.apache.org/jira/browse/FLINK-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281476#comment-16281476
]
ASF GitHub Bot commented on FLINK-8149:
---
Github user bowenli86 commented on the issue:
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/5129
+1, LGTM.
---
[
https://issues.apache.org/jira/browse/FLINK-8216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281473#comment-16281473
]
ASF GitHub Bot commented on FLINK-8216:
---
Github user tzulitai commented on a diff in the pull
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5130#discussion_r155451196
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/testutils/TestUtils.java
---
@@ -0,0 +1,39
101 - 165 of 165 matches
Mail list logo
