[jira] [Created] (FLINK-8392) Simplify termination future completion

Till Rohrmann created FLINK-8392: Summary: Simplify termination future completion Key: FLINK-8392 URL: https://issues.apache.org/jira/browse/FLINK-8392 Project: Flink Issue Type: Sub-task

[jira] [Updated] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-8317: Description: Enable triggering of savepoints in FLIP-6 mode via RestfulGateway: * Add method to

[jira] [Updated] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-8317: Description: Enable triggering of savepoints in FLIP-6 mode via RestfulGateway: * Add method to

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318688#comment-16318688 ] ASF GitHub Bot commented on FLINK-8325: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160454995 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala --- @@ -278,7 +278,14 @@

[jira] [Commented] (FLINK-8234) Cache JobExecutionResult from finished JobManagerRunners

[ https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318683#comment-16318683 ] ASF GitHub Bot commented on FLINK-8234: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5184#discussion_r160453714 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -357,6 +360,31 @@ public void start() throws Exception {

[jira] [Commented] (FLINK-8316) The CsvTableSink and the CsvInputFormat are not in sync

[ https://issues.apache.org/jira/browse/FLINK-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318641#comment-16318641 ] ASF GitHub Bot commented on FLINK-8316: --- Github user xccui commented on the issue:

[GitHub] flink issue #5210: [FLINK-8316] [table] The CsvTableSink and the CsvInputFor...

Github user xccui commented on the issue: https://github.com/apache/flink/pull/5210 Hi @sunjincheng121, yes, the reported issue should be solved with FLINK-8331. In addition, maybe we can add the trailing delimiter as a new feature (like the

[GitHub] flink issue #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT support...

Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/5202 Thanks @dubin555, The PR looks pretty good. +1 to merged. Thanks, Jincheng ---

[jira] [Commented] (FLINK-8302) Support shift_left and shift_right in TableAPI

[ https://issues.apache.org/jira/browse/FLINK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318635#comment-16318635 ] ASF GitHub Bot commented on FLINK-8302: --- Github user sunjincheng121 commented on the issue:

[jira] [Comment Edited] (FLINK-8355) DataSet Should not union a NULL row for AGG without GROUP BY clause.

[ https://issues.apache.org/jira/browse/FLINK-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318619#comment-16318619 ] Fabian Hueske edited comment on FLINK-8355 at 1/9/18 3:47 PM: -- The motivation

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318629#comment-16318629 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160442930 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala --- @@ -278,7 +278,14 @@ class

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318622#comment-16318622 ] ASF GitHub Bot commented on FLINK-8325: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160442170 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/JoinITCase.scala --- @@ -254,7 +254,7 @@ class

[jira] [Commented] (FLINK-8355) DataSet Should not union a NULL row for AGG without GROUP BY clause.

[ https://issues.apache.org/jira/browse/FLINK-8355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318619#comment-16318619 ] Fabian Hueske commented on FLINK-8355: -- The motivation for the {{DataSetAggregateWithNullValuesRule}}

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318607#comment-16318607 ] ASF GitHub Bot commented on FLINK-8325: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160439631 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala --- @@ -278,7 +278,14 @@

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318603#comment-16318603 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160438113 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/JoinITCase.scala --- @@ -254,7 +254,7 @@ class JoinITCase(

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318597#comment-16318597 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160437205 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala --- @@ -278,7 +278,14 @@ class

[jira] [Commented] (FLINK-8316) The CsvTableSink and the CsvInputFormat are not in sync

[ https://issues.apache.org/jira/browse/FLINK-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318596#comment-16318596 ] ASF GitHub Bot commented on FLINK-8316: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #5210: [FLINK-8316] [table] The CsvTableSink and the CsvInputFor...

Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/5210 Hi, @xccui thanks for tell me more about the background of this issue. But if we improved the `CsvInputFormat` to support that case. Just like FLINK-8331 did. I think we do not need this

[GitHub] flink pull request #5261: [FLINK-8371][network] always recycle Buffers when ...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5261 ---

[jira] [Commented] (FLINK-8375) Remove unnecessary synchronization in ResultPartition

[ https://issues.apache.org/jira/browse/FLINK-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318574#comment-16318574 ] ASF GitHub Bot commented on FLINK-8375: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-7468) Implement sender backlog logic for credit-based

[ https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318572#comment-16318572 ] ASF GitHub Bot commented on FLINK-7468: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-8252) Convert network benchmarks to streaming benchmarks

[ https://issues.apache.org/jira/browse/FLINK-8252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318571#comment-16318571 ] ASF GitHub Bot commented on FLINK-8252: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-8371) Buffers are not recycled in a non-spilled SpillableSubpartition upon release

[ https://issues.apache.org/jira/browse/FLINK-8371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318573#comment-16318573 ] ASF GitHub Bot commented on FLINK-8371: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5260: [FLINK-8375][network] Remove unnecessary synchroni...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5260 ---

[GitHub] flink pull request #5259: [FLINK-8252][benchmarks] convert network benchmark...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5259 ---

[GitHub] flink pull request #4559: [FLINK-7468][network] Implement sender backlog log...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4559 ---

[jira] [Commented] (FLINK-8317) Enable Triggering of Savepoints via RestfulGateway

[ https://issues.apache.org/jira/browse/FLINK-8317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318563#comment-16318563 ] ASF GitHub Bot commented on FLINK-8317: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5223: [FLINK-8317][flip6] Implement Triggering of Savepo...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r160431822 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlersTest.java --- @@ -0,0 +1,276 @@ +/* + *

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318558#comment-16318558 ] ASF GitHub Bot commented on FLINK-8325: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160430205 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala --- @@ -278,7 +278,14 @@

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318548#comment-16318548 ] ASF GitHub Bot commented on FLINK-8325: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160428673 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1130,259 +1134,263 @@

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318538#comment-16318538 ] ASF GitHub Bot commented on FLINK-8325: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160426130 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/JoinITCase.scala --- @@ -254,7 +254,7 @@ class

[GitHub] flink pull request #:

Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/a03cdfabe6eab48509b42a6831a21e488b9c3e80#commitcomment-26740277 In .travis.yml: In .travis.yml on line 93: So far, each profile had a different cache identifier. That way profiles

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318501#comment-16318501 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160421752 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala --- @@ -278,7 +278,14 @@ class

[jira] [Commented] (FLINK-6951) Incompatible versions of httpcomponents jars for Flink kinesis connector

[ https://issues.apache.org/jira/browse/FLINK-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318500#comment-16318500 ] ASF GitHub Bot commented on FLINK-6951: --- Github user casidiablo commented on the issue:

[GitHub] flink issue #4150: [FLINK-6951] Incompatible versions of httpcomponents jars...

Github user casidiablo commented on the issue: https://github.com/apache/flink/pull/4150 This actually worked for me. I ran it on EMR 5.10, compiling the kinesis connector from the release-1.3 branch (since EMR provides Flink 1.3) ---

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318495#comment-16318495 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160420917 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/JoinITCase.scala --- @@ -254,7 +254,7 @@ class JoinITCase(

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318487#comment-16318487 ] ASF GitHub Bot commented on FLINK-8325: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160419117 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala --- @@ -278,7 +278,14 @@

[jira] [Commented] (FLINK-8385) Fix exceptions in AbstractEventTimeWindowCheckpointingITCase

[ https://issues.apache.org/jira/browse/FLINK-8385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318478#comment-16318478 ] ASF GitHub Bot commented on FLINK-8385: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5256: [FLINK-8385] Fix exceptions in AbstractEventTimeWi...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5256 ---

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318475#comment-16318475 ] ASF GitHub Bot commented on FLINK-8325: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160416641 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala --- @@ -278,7 +278,14 @@

[GitHub] flink pull request #5264: [FLINK-8352][web-dashboard] Flink UI Reports No Er...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5264 ---

[jira] [Commented] (FLINK-8352) Flink UI Reports No Error on Job Submission Failures

[ https://issues.apache.org/jira/browse/FLINK-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318470#comment-16318470 ] ASF GitHub Bot commented on FLINK-8352: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318461#comment-16318461 ] ASF GitHub Bot commented on FLINK-8325: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160414914 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/JoinITCase.scala --- @@ -254,7 +254,7 @@ class

[jira] [Updated] (FLINK-8354) Flink Kafka connector ignores Kafka message headers

[ https://issues.apache.org/jira/browse/FLINK-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Abareghi updated FLINK-8354: - Priority: Major (was: Minor) > Flink Kafka connector ignores Kafka message headers >

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318457#comment-16318457 ] ASF GitHub Bot commented on FLINK-8325: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160413930 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -145,6

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318456#comment-16318456 ] ASF GitHub Bot commented on FLINK-8325: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160413762 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -359,12 +359,17 @@ class

[jira] [Commented] (FLINK-8234) Cache JobExecutionResult from finished JobManagerRunners

[ https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318431#comment-16318431 ] ASF GitHub Bot commented on FLINK-8234: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5184#discussion_r160408755 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobExecutionResult.java --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-8234) Cache JobExecutionResult from finished JobManagerRunners

[ https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318430#comment-16318430 ] ASF GitHub Bot commented on FLINK-8234: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5184#discussion_r160408734 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobExecutionResult.java --- @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-8234) Cache JobExecutionResult from finished JobManagerRunners

[ https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318407#comment-16318407 ] ASF GitHub Bot commented on FLINK-8234: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5184#discussion_r160407686 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -956,23 +958,29 @@ private void jobStatusChanged(

[jira] [Commented] (FLINK-5982) Refactor AbstractInvokable and StatefulTask

[ https://issues.apache.org/jira/browse/FLINK-5982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318396#comment-16318396 ] ASF GitHub Bot commented on FLINK-5982: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3633: [FLINK-5982] [runtime] Refactor AbstractInvokable and Sta...

Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3633 I finally found the time to look at this. Have rebased it and applied some simplifications: - convenience constructors for stateless tasks - test utils that provide mock

[jira] [Updated] (FLINK-8389) Release all slots when terminating the JobMaster

[ https://issues.apache.org/jira/browse/FLINK-8389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-8389: - Description: The {{JobMaster}} should free all allocated slots before terminating. This will make

[jira] [Updated] (FLINK-8389) Release all slots when terminating the JobMaster

[ https://issues.apache.org/jira/browse/FLINK-8389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-8389: - Summary: Release all slots when terminating the JobMaster (was: Release all slots upon closing

[jira] [Commented] (FLINK-8385) Fix exceptions in AbstractEventTimeWindowCheckpointingITCase

[ https://issues.apache.org/jira/browse/FLINK-8385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318394#comment-16318394 ] ASF GitHub Bot commented on FLINK-8385: --- Github user StefanRRichter commented on the issue:

[jira] [Commented] (FLINK-8385) Fix exceptions in AbstractEventTimeWindowCheckpointingITCase

[ https://issues.apache.org/jira/browse/FLINK-8385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318392#comment-16318392 ] ASF GitHub Bot commented on FLINK-8385: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink issue #5256: [FLINK-8385] Fix exceptions in AbstractEventTimeWindowChe...

Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5256 Thanks for the fast review @tillrohrmann ! I will address your comments and merge. ---

[GitHub] flink pull request #5256: [FLINK-8385] Fix exceptions in AbstractEventTimeWi...

Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5256#discussion_r160403824 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateUtil.java --- @@ -63,10 +65,16 @@ public static void

[jira] [Commented] (FLINK-7475) support update() in ListState

[ https://issues.apache.org/jira/browse/FLINK-7475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318391#comment-16318391 ] ASF GitHub Bot commented on FLINK-7475: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #4963: [FLINK-7475] [core][DataStream API] support update() in L...

Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/4963 Alright, I think this looks good to me now. @bowenli86 would you also like to work on the followup issues that you created? I will merge this today or tomorrow. ---

[GitHub] flink pull request #4587: [FLINK-7511] [cep] Remove dead code after dropping...

Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r160395375 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -150,16 +126,13 @@ */ private boolean

[jira] [Commented] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2

[ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318370#comment-16318370 ] ASF GitHub Bot commented on FLINK-7511: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2

[ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318371#comment-16318371 ] ASF GitHub Bot commented on FLINK-7511: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4587: [FLINK-7511] [cep] Remove dead code after dropping...

Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r160397308 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/AndFilterFunction.java --- @@ -1,55 +0,0 @@ -/* - * Licensed to

[jira] [Commented] (FLINK-7797) Add support for windowed outer joins for streaming tables

[ https://issues.apache.org/jira/browse/FLINK-7797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318351#comment-16318351 ] ASF GitHub Bot commented on FLINK-7797: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5140: [FLINK-7797] [table] Add support for windowed oute...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5140 ---

[jira] [Comment Edited] (FLINK-3089) State API Should Support Data Expiration (State TTL)

[ https://issues.apache.org/jira/browse/FLINK-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318309#comment-16318309 ] Xavier Fournet edited comment on FLINK-3089 at 1/9/18 12:04 PM: I fully

[jira] [Commented] (FLINK-3089) State API Should Support Data Expiration (State TTL)

[ https://issues.apache.org/jira/browse/FLINK-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318309#comment-16318309 ] Xavier Fournet commented on FLINK-3089: --- I fully agree to adopt a relaxed TTL policy. In one of our

[jira] [Closed] (FLINK-7578) WindowStream should support rich AggregateFunction

[ https://issues.apache.org/jira/browse/FLINK-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hequn Cheng closed FLINK-7578. -- Resolution: Fixed fixed by FLINK-7490 > WindowStream should support rich AggregateFunction >

[jira] [Commented] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2

[ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318249#comment-16318249 ] ASF GitHub Bot commented on FLINK-7511: --- Github user dawidwys commented on a diff in the pull

[GitHub] flink pull request #4587: [FLINK-7511] [cep] Remove dead code after dropping...

Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r160375193 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/AndFilterFunction.java --- @@ -1,55 +0,0 @@ -/* - * Licensed to the

[jira] [Commented] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2

[ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318239#comment-16318239 ] ASF GitHub Bot commented on FLINK-7511: --- Github user dawidwys commented on a diff in the pull

[GitHub] flink pull request #4587: [FLINK-7511] [cep] Remove dead code after dropping...

Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r160372500 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -150,16 +126,13 @@ */ private boolean

[jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based

[ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318232#comment-16318232 ] ASF GitHub Bot commented on FLINK-7456: --- Github user zhijiangW commented on a diff in the pull

[GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...

Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4552#discussion_r160371761 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java --- @@ -88,6 +93,35 @@ public void run() {

[jira] [Resolved] (FLINK-8381) Document more flexible schema definition

[ https://issues.apache.org/jira/browse/FLINK-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-8381. - Resolution: Fixed Fix Version/s: 1.5.0 Fixed in 1.5:

[jira] [Commented] (FLINK-8381) Document more flexible schema definition

[ https://issues.apache.org/jira/browse/FLINK-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318225#comment-16318225 ] ASF GitHub Bot commented on FLINK-8381: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5257: [FLINK-8381] [table] Document more flexible schema...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5257 ---

[jira] [Commented] (FLINK-8288) Register the web interface url to yarn for yarn job mode

[ https://issues.apache.org/jira/browse/FLINK-8288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318220#comment-16318220 ] ASF GitHub Bot commented on FLINK-8288: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8381) Document more flexible schema definition

[ https://issues.apache.org/jira/browse/FLINK-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318221#comment-16318221 ] ASF GitHub Bot commented on FLINK-8381: --- Github user twalthr commented on the issue:

[GitHub] flink issue #5257: [FLINK-8381] [table] Document more flexible schema defini...

Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5257 Thanks for your feedback @fhueske. I hope I could address all your comments. I will merge this now... ---

<    1   2   3   >