[GitHub] [phoenix] priyankporwal commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs

2020-01-14 Thread GitBox
priyankporwal commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683#discussion_r366729041 ## File path:

[GitHub] [phoenix] abhishek-chouhan commented on issue #685: PHOENIX-5676 Inline-verification from IndexTool does not handle TTL/r…

2020-01-14 Thread GitBox
abhishek-chouhan commented on issue #685: PHOENIX-5676 Inline-verification from IndexTool does not handle TTL/r… URL: https://github.com/apache/phoenix/pull/685#issuecomment-574534652 Sorry for that miss. Have updated to use TreeSet with appropriate comparator @kadirozde and verified the

[GitHub] [phoenix] kadirozde commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs

2020-01-14 Thread GitBox
kadirozde commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683#discussion_r366727610 ## File path:

[GitHub] [phoenix] kadirozde commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs

2020-01-14 Thread GitBox
kadirozde commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683#discussion_r366727146 ## File path:

[jira] [Commented] (PHOENIX-5645) BaseScannerRegionObserver should prevent compaction from purging very recently deleted cells

2020-01-14 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015692#comment-17015692 ] Hadoop QA commented on PHOENIX-5645: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-5644) IndexUpgradeTool should sleep only once if there is at least one immutable table provided

2020-01-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015679#comment-17015679 ] Hudson commented on PHOENIX-5644: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3303

[jira] [Commented] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan

2020-01-14 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015678#comment-17015678 ] Hadoop QA commented on PHOENIX-5678: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-5651) IndexScrutiny does not handle TTL/row-expiry

2020-01-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015680#comment-17015680 ] Hudson commented on PHOENIX-5651: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3303

[GitHub] [phoenix-queryserver] asfgit closed pull request #16: PHOENIX-5680 remove psql.py from phoenix-queryserver

2020-01-14 Thread GitBox
asfgit closed pull request #16: PHOENIX-5680 remove psql.py from phoenix-queryserver URL: https://github.com/apache/phoenix-queryserver/pull/16 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [phoenix] priyankporwal commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs

2020-01-14 Thread GitBox
priyankporwal commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683#discussion_r366713145 ## File path:

[GitHub] [phoenix] priyankporwal commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs

2020-01-14 Thread GitBox
priyankporwal commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683#discussion_r366710379 ## File path:

[jira] [Commented] (PHOENIX-5656) Make Phoenix scripts work with Python 3

2020-01-14 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015655#comment-17015655 ] Lars Hofhansl commented on PHOENIX-5656: -v4 after PHOENIX-5454 > Make Phoenix scripts work

[GitHub] [phoenix] priyankporwal commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs

2020-01-14 Thread GitBox
priyankporwal commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683#discussion_r366709551 ## File path:

[jira] [Commented] (PHOENIX-5520) Phoenix-level HBase ReplicationEndpoint

2020-01-14 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015647#comment-17015647 ] Bharath Vissapragada commented on PHOENIX-5520: --- I think one solution is to prototype on

[GitHub] [phoenix] kadirozde commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs

2020-01-14 Thread GitBox
kadirozde commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683#discussion_r366699764 ## File path:

[GitHub] [phoenix] kadirozde commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs

2020-01-14 Thread GitBox
kadirozde commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683#discussion_r366698209 ## File path:

[jira] [Commented] (PHOENIX-5520) Phoenix-level HBase ReplicationEndpoint

2020-01-14 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015634#comment-17015634 ] Bharath Vissapragada commented on PHOENIX-5520: --- I've started prototyping this and was

[GitHub] [phoenix] kadirozde commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs

2020-01-14 Thread GitBox
kadirozde commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683#discussion_r366697826 ## File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java

[jira] [Commented] (PHOENIX-5644) IndexUpgradeTool should sleep only once if there is at least one immutable table provided

2020-01-14 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015633#comment-17015633 ] Hadoop QA commented on PHOENIX-5644: {color:red}-1 overall{color}. Here are the results of testing

[GitHub] [phoenix] kadirozde commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs

2020-01-14 Thread GitBox
kadirozde commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683#discussion_r366697483 ## File path:

[GitHub] [phoenix] kadirozde commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs

2020-01-14 Thread GitBox
kadirozde commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683#discussion_r366696867 ## File path:

[jira] [Commented] (PHOENIX-5645) BaseScannerRegionObserver should prevent compaction from purging very recently deleted cells

2020-01-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015621#comment-17015621 ] Hudson commented on PHOENIX-5645: - SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBase-1.5 #246 (See

[jira] [Commented] (PHOENIX-5644) IndexUpgradeTool should sleep only once if there is at least one immutable table provided

2020-01-14 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015619#comment-17015619 ] Hadoop QA commented on PHOENIX-5644: {color:red}-1 overall{color}. Here are the results of testing

[GitHub] [phoenix] kadirozde commented on a change in pull request #685: PHOENIX-5676 Inline-verification from IndexTool does not handle TTL/r…

2020-01-14 Thread GitBox
kadirozde commented on a change in pull request #685: PHOENIX-5676 Inline-verification from IndexTool does not handle TTL/r… URL: https://github.com/apache/phoenix/pull/685#discussion_r366688528 ## File path:

[jira] [Commented] (PHOENIX-5645) BaseScannerRegionObserver should prevent compaction from purging very recently deleted cells

2020-01-14 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015610#comment-17015610 ] Hadoop QA commented on PHOENIX-5645: {color:red}-1 overall{color}. Here are the results of testing

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683#discussion_r366674366 ## File path:

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683#discussion_r366680083 ## File path:

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683#discussion_r366672514 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683#discussion_r366675047 ## File path:

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683#discussion_r366681561 ## File path:

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683#discussion_r366674451 ## File path:

[GitHub] [phoenix] abhishek-chouhan opened a new pull request #685: PHOENIX-5676 Inline-verification from IndexTool does not handle TTL/r…

2020-01-14 Thread GitBox
abhishek-chouhan opened a new pull request #685: PHOENIX-5676 Inline-verification from IndexTool does not handle TTL/r… URL: https://github.com/apache/phoenix/pull/685 …ow-expiry This is an automated message from the Apache

[jira] [Comment Edited] (PHOENIX-5644) IndexUpgradeTool should sleep only once if there is at least one immutable table provided

2020-01-14 Thread Swaroopa Kadam (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015567#comment-17015567 ] Swaroopa Kadam edited comment on PHOENIX-5644 at 1/15/20 2:42 AM: --

[GitHub] [phoenix] gjacoby126 merged pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
gjacoby126 merged pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679 This is an automated message from the Apache Git Service. To

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366671228 ## File path:

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366671228 ## File path:

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366671327 ## File path:

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r36667 ## File path:

[jira] [Commented] (PHOENIX-4266) Avoid scanner caching in Phoenix

2020-01-14 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015575#comment-17015575 ] Andrew Kyle Purtell commented on PHOENIX-4266: -- Do you mean setCaching or setBatch()?

[jira] [Commented] (PHOENIX-5651) IndexScrutiny does not handle TTL/row-expiry

2020-01-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015569#comment-17015569 ] Hudson commented on PHOENIX-5651: - ABORTED: Integrated in Jenkins build PreCommit-PHOENIX-Build #3298

[jira] [Commented] (PHOENIX-5644) IndexUpgradeTool should sleep only once if there is at least one immutable table provided

2020-01-14 Thread Swaroopa Kadam (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015567#comment-17015567 ] Swaroopa Kadam commented on PHOENIX-5644: - Since the patch didn't apply cleanly on the master,

[GitHub] [phoenix] swaroopak opened a new pull request #684: PHOENIX-5644 and PHOENIX-5651 addendum patch

2020-01-14 Thread GitBox
swaroopak opened a new pull request #684: PHOENIX-5644 and PHOENIX-5651 addendum patch URL: https://github.com/apache/phoenix/pull/684 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (PHOENIX-5634) Use 'phoenix.default.update.cache.frequency' from connection properties at query time

2020-01-14 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015540#comment-17015540 ] Hadoop QA commented on PHOENIX-5634: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Comment Edited] (PHOENIX-5265) [UMBRELLA] Phoenix Test should use gold files for result comparison instead of using hard-corded comparison.

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015527#comment-17015527 ] Viraj Jasani edited comment on PHOENIX-5265 at 1/15/20 1:16 AM:

[GitHub] [phoenix] priyankporwal commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
priyankporwal commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366653511 ## File path:

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366649341 ## File path:

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366649113 ## File path:

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366649181 ## File path:

[jira] [Commented] (PHOENIX-5265) [UMBRELLA] Phoenix Test should use gold files for result comparison instead of using hard-corded comparison.

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015531#comment-17015531 ] Viraj Jasani commented on PHOENIX-5265: --- I will create sub-tasks to provide gold files covering

[jira] [Commented] (PHOENIX-5265) [UMBRELLA] Phoenix Test should use gold files for result comparison instead of using hard-corded comparison.

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015527#comment-17015527 ] Viraj Jasani commented on PHOENIX-5265: --- {quote}It would also be useful if explain plans had an

[jira] [Commented] (PHOENIX-5265) [UMBRELLA] Phoenix Test should use gold files for result comparison instead of using hard-corded comparison.

2020-01-14 Thread Geoffrey Jacoby (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015510#comment-17015510 ] Geoffrey Jacoby commented on PHOENIX-5265: -- It would also be useful if explain plans had an

[jira] [Commented] (PHOENIX-4845) Support using Row Value Constructors in OFFSET clause for paging in tables where the sort order of PK columns varies

2020-01-14 Thread Daniel Wong (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015504#comment-17015504 ] Daniel Wong commented on PHOENIX-4845: -- Checked the tests that appears to be a environmental

[GitHub] [phoenix-connectors] brfrn169 commented on issue #11: PHOENIX-5619 CREATE TABLE AS SELECT for Phoenix table doesn't work co…

2020-01-14 Thread GitBox
brfrn169 commented on issue #11: PHOENIX-5619 CREATE TABLE AS SELECT for Phoenix table doesn't work co… URL: https://github.com/apache/phoenix-connectors/pull/11#issuecomment-574431615 Thank you @joshelser . I'm stuck and can't get a test showing the issue actually. Please commit this if

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366634151 ## File path:

[GitHub] [phoenix] priyankporwal commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
priyankporwal commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366634040 ## File path:

[GitHub] [phoenix] kadirozde opened a new pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs

2020-01-14 Thread GitBox
kadirozde opened a new pull request #683: PHOENIX-5674 IndexTool to not write already correct index rows/CFs URL: https://github.com/apache/phoenix/pull/683 This is an automated message from the Apache Git Service. To

[GitHub] [phoenix] swaroopak closed pull request #678: PHOENIX-5644 and PHOENIX-5651 addendum patch

2020-01-14 Thread GitBox
swaroopak closed pull request #678: PHOENIX-5644 and PHOENIX-5651 addendum patch URL: https://github.com/apache/phoenix/pull/678 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [phoenix] swaroopak closed pull request #669: PHOENIX-5651: IndexScrutiny does not handle TTL/row-expiry

2020-01-14 Thread GitBox
swaroopak closed pull request #669: PHOENIX-5651: IndexScrutiny does not handle TTL/row-expiry URL: https://github.com/apache/phoenix/pull/669 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [phoenix] swaroopak opened a new pull request #682: Phoenix 5675

2020-01-14 Thread GitBox
swaroopak opened a new pull request #682: Phoenix 5675 URL: https://github.com/apache/phoenix/pull/682 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #671: PHOENIX-4845 Support using Row Value Constructors in OFFSET clause fo…

2020-01-14 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #671: PHOENIX-4845 Support using Row Value Constructors in OFFSET clause fo… URL: https://github.com/apache/phoenix/pull/671#discussion_r366630961 ## File path: phoenix-core/src/test/java/org/apache/phoenix/util/TestUtil.java

[GitHub] [phoenix] dbwong commented on a change in pull request #671: PHOENIX-4845 Support using Row Value Constructors in OFFSET clause fo…

2020-01-14 Thread GitBox
dbwong commented on a change in pull request #671: PHOENIX-4845 Support using Row Value Constructors in OFFSET clause fo… URL: https://github.com/apache/phoenix/pull/671#discussion_r366630326 ## File path: phoenix-core/src/main/java/org/apache/phoenix/compile/OrderByCompiler.java

[GitHub] [phoenix] swaroopak merged pull request #681: PHOENIX-5651_master: IndexScrutiny does not handle TTL/row-expiry

2020-01-14 Thread GitBox
swaroopak merged pull request #681: PHOENIX-5651_master: IndexScrutiny does not handle TTL/row-expiry URL: https://github.com/apache/phoenix/pull/681 This is an automated message from the Apache Git Service. To respond to

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366627476 ## File path:

[GitHub] [phoenix] kadirozde commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
kadirozde commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366627276 ## File path:

[GitHub] [phoenix] dbwong commented on a change in pull request #671: PHOENIX-4845 Support using Row Value Constructors in OFFSET clause fo…

2020-01-14 Thread GitBox
dbwong commented on a change in pull request #671: PHOENIX-4845 Support using Row Value Constructors in OFFSET clause fo… URL: https://github.com/apache/phoenix/pull/671#discussion_r366626790 ## File path: phoenix-core/src/main/java/org/apache/phoenix/compile/OffsetCompiler.java

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366626438 ## File path:

[GitHub] [phoenix] swaroopak commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
swaroopak commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366625000 ## File path:

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366625069 ## File path:

[GitHub] [phoenix] swaroopak commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
swaroopak commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366624734 ## File path:

[jira] [Comment Edited] (PHOENIX-5672) Unable to find cached index metadata with large UPSERT/SELECT and local index.

2020-01-14 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015368#comment-17015368 ] Lars Hofhansl edited comment on PHOENIX-5672 at 1/14/20 11:17 PM: --

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366622629 ## File path:

[GitHub] [phoenix] priyankporwal commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
priyankporwal commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366622515 ## File path:

[GitHub] [phoenix] priyankporwal commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
priyankporwal commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366622394 ## File path:

[GitHub] [phoenix] kadirozde commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
kadirozde commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366622507 ## File path:

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
gjacoby126 commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366622118 ## File path:

[jira] [Comment Edited] (PHOENIX-5645) BaseScannerRegionObserver should prevent compaction from purging very recently deleted cells

2020-01-14 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015474#comment-17015474 ] Lars Hofhansl edited comment on PHOENIX-5645 at 1/14/20 11:11 PM: --

[jira] [Commented] (PHOENIX-5645) BaseScannerRegionObserver should prevent compaction from purging very recently deleted cells

2020-01-14 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015474#comment-17015474 ] Lars Hofhansl commented on PHOENIX-5645: This is breaking MaxLookbackIT. It went unnoticed

[GitHub] [phoenix] swaroopak commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
swaroopak commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366621634 ## File path:

[GitHub] [phoenix] kadirozde commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg…

2020-01-14 Thread GitBox
kadirozde commented on a change in pull request #679: PHOENIX-5645 - BaseScannerRegionObserver should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366620077 ## File path:

[jira] [Comment Edited] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan

2020-01-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015437#comment-17015437 ] Viraj Jasani edited comment on PHOENIX-5678 at 1/14/20 10:12 PM: - The

[GitHub] [phoenix] gokceni commented on issue #679: PHOENIX-5645 - GlobalIndexChecker should prevent compaction from purg…

2020-01-14 Thread GitBox
gokceni commented on issue #679: PHOENIX-5645 - GlobalIndexChecker should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#issuecomment-574393825 Couple of nits. Don't we want a test on index tables as well?

[GitHub] [phoenix] gokceni commented on a change in pull request #679: PHOENIX-5645 - GlobalIndexChecker should prevent compaction from purg…

2020-01-14 Thread GitBox
gokceni commented on a change in pull request #679: PHOENIX-5645 - GlobalIndexChecker should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366593957 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/MaxLookbackIT.java

[GitHub] [phoenix] gokceni commented on a change in pull request #679: PHOENIX-5645 - GlobalIndexChecker should prevent compaction from purg…

2020-01-14 Thread GitBox
gokceni commented on a change in pull request #679: PHOENIX-5645 - GlobalIndexChecker should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366594061 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/MaxLookbackIT.java

[GitHub] [phoenix] gokceni commented on a change in pull request #679: PHOENIX-5645 - GlobalIndexChecker should prevent compaction from purg…

2020-01-14 Thread GitBox
gokceni commented on a change in pull request #679: PHOENIX-5645 - GlobalIndexChecker should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366589942 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/MaxLookbackIT.java

[GitHub] [phoenix] gokceni commented on a change in pull request #679: PHOENIX-5645 - GlobalIndexChecker should prevent compaction from purg…

2020-01-14 Thread GitBox
gokceni commented on a change in pull request #679: PHOENIX-5645 - GlobalIndexChecker should prevent compaction from purg… URL: https://github.com/apache/phoenix/pull/679#discussion_r366589265 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/MaxLookbackIT.java

[jira] [Commented] (PHOENIX-5644) IndexUpgradeTool should sleep only once if there is at least one immutable table provided

2020-01-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015417#comment-17015417 ] Hudson commented on PHOENIX-5644: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #649 (See

[jira] [Commented] (PHOENIX-5651) IndexScrutiny does not handle TTL/row-expiry

2020-01-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015418#comment-17015418 ] Hudson commented on PHOENIX-5651: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #649 (See

[jira] [Commented] (PHOENIX-5651) IndexScrutiny does not handle TTL/row-expiry

2020-01-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015416#comment-17015416 ] Hudson commented on PHOENIX-5651: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.4 #365 (See

[jira] [Commented] (PHOENIX-5644) IndexUpgradeTool should sleep only once if there is at least one immutable table provided

2020-01-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015415#comment-17015415 ] Hudson commented on PHOENIX-5644: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.4 #365 (See

[jira] [Commented] (PHOENIX-5644) IndexUpgradeTool should sleep only once if there is at least one immutable table provided

2020-01-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015411#comment-17015411 ] Hudson commented on PHOENIX-5644: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.5 #245 (See

[jira] [Commented] (PHOENIX-5651) IndexScrutiny does not handle TTL/row-expiry

2020-01-14 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015412#comment-17015412 ] Hudson commented on PHOENIX-5651: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.5 #245 (See

[jira] [Commented] (PHOENIX-5644) IndexUpgradeTool should sleep only once if there is at least one immutable table provided

2020-01-14 Thread Geoffrey Jacoby (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015383#comment-17015383 ] Geoffrey Jacoby commented on PHOENIX-5644: -- [~larsh] - the remaining test failures are mine,

[jira] [Commented] (PHOENIX-5672) Unable to find cached index metadata with large UPSERT/SELECT and local index.

2020-01-14 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015368#comment-17015368 ] Lars Hofhansl commented on PHOENIX-5672: Btw. I have been disabling this via the setting, and

[jira] [Commented] (PHOENIX-5629) Phoenix Function to Return HBase Timestamp of Column Cell

2020-01-14 Thread Priyank Porwal (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015367#comment-17015367 ] Priyank Porwal commented on PHOENIX-5629: - [~sakshamgangwar], [~tkhurana] has already started

[jira] [Commented] (PHOENIX-5651) IndexScrutiny does not handle TTL/row-expiry

2020-01-14 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015354#comment-17015354 ] Hadoop QA commented on PHOENIX-5651: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-5644) IndexUpgradeTool should sleep only once if there is at least one immutable table provided

2020-01-14 Thread Swaroopa Kadam (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015343#comment-17015343 ] Swaroopa Kadam commented on PHOENIX-5644: - Thank you, Lars!  Appreciate your help and patience. 

[GitHub] [phoenix] swaroopak opened a new pull request #681: PHOENIX-5651_master: IndexScrutiny does not handle TTL/row-expiry

2020-01-14 Thread GitBox
swaroopak opened a new pull request #681: PHOENIX-5651_master: IndexScrutiny does not handle TTL/row-expiry URL: https://github.com/apache/phoenix/pull/681 This is an automated message from the Apache Git Service. To

[jira] [Comment Edited] (PHOENIX-5644) IndexUpgradeTool should sleep only once if there is at least one immutable table provided

2020-01-14 Thread Lars Hofhansl (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015331#comment-17015331 ] Lars Hofhansl edited comment on PHOENIX-5644 at 1/14/20 7:20 PM: -

[GitHub] [phoenix] ntshmah edited a comment on issue #659: PHOENIX-5634: Use 'phoenix.default.update.cache.frequency' from conne…

2020-01-14 Thread GitBox
ntshmah edited a comment on issue #659: PHOENIX-5634: Use 'phoenix.default.update.cache.frequency' from conne… URL: https://github.com/apache/phoenix/pull/659#issuecomment-574323990 Hi @ChinmaySKulkarni I will be squashing my commits together and force pushing here since quite a few

[GitHub] [phoenix] ntshmah commented on issue #659: PHOENIX-5634: Use 'phoenix.default.update.cache.frequency' from conne…

2020-01-14 Thread GitBox
ntshmah commented on issue #659: PHOENIX-5634: Use 'phoenix.default.update.cache.frequency' from conne… URL: https://github.com/apache/phoenix/pull/659#issuecomment-574323990 Hi @ckulkarni I will be squashing my commits together and force pushing here since quite a few things changed

  1   2   >