/#comment35567
There is no such parameter?
- Kai Uwe Broulik
On Feb. 23, 2014, 9:56 a.m., David Faure wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115959
On June 19, 2014, 8:42 p.m., David Edmundson wrote:
Note: The property names don't line up 100% in the merge.
flickableItem has now become contentItem (which is a default property)
All instances in plasma-workspace/plasma-desktop are now updated.
Kai Uwe Broulik wrote
On Aug. 9, 2013, 2:55 p.m., David Edmundson wrote:
tier1/kconfig/src/gui/kconfigloader.cpp, line 65
http://git.reviewboard.kde.org/r/111908/diff/3/?file=177535#file177535line65
This would be best with use of QLatin1String() thoughout this file.
QStringLiteral?
- Kai Uwe
checkbox in
battery monitor has become quite small here now.
- Kai Uwe Broulik
On Aug. 20, 2014, 6:51 nachm., Marco Martin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119846
/119975/#comment45731
objectPath.remove(QLatin1Char('-'));
- Kai Uwe Broulik
On Aug. 28, 2014, 3:18 nachm., Aleix Pol Gonzalez wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r
Diff: https://git.reviewboard.kde.org/r/120092/diff/
Testing
---
Works.
Thanks,
Kai Uwe Broulik
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120092/#review65987
---
On Sept. 7, 2014, 1:49 nachm., Kai Uwe Broulik wrote
/util/kformat.h 7a6a418
src/lib/util/kformat.cpp d62240e
Diff: https://git.reviewboard.kde.org/r/120092/diff/
Testing
---
Works.
Thanks,
Kai Uwe Broulik
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
://git.reviewboard.kde.org//r/120360/#fcomment268
What is that gray are at the bottom? It's not present in the before
screenshot.
- Kai Uwe Broulik
On Sept. 25, 2014, 12:33 nachm., Hugo Pereira Da Costa wrote
/#comment47051
if (widget-layout()) {
widget-layout()-setMargin(0);
}
- Kai Uwe Broulik
On Sept. 25, 2014, 12:33 nachm., Hugo Pereira Da Costa wrote:
---
This is an automatically generated e-mail. To reply, visit
/knotification.h
https://git.reviewboard.kde.org/r/120887/#comment48517
Maybe iconName ? To me setIcon implies it accepts a QIcon(), how is this
handled in other places?
src/notifybypopup.cpp
https://git.reviewboard.kde.org/r/120887/#comment48520
*override
- Kai Uwe Broulik
On Okt. 29, 2014
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120887/#review69424
---
Ship it!
Ship It!
- Kai Uwe Broulik
On Okt. 29, 2014, 11
into figuring out the
miemtype for remotes url but now it is not
Is this the reason I don't get folder icons on FTP anymore either?
- Kai Uwe Broulik
On Okt. 30, 2014, 10:42 nachm., Àlex Fiestas wrote:
---
This is an automatically generated
- initializer lists
Unsupported on VS2012.
Again, seems to be that CTP thingie, damn. (though, again, the initializer
lists should also be tested - maybe they also work if the number of arguments
is less than ...)
I've had problems with them even on VS2013, like return QHashint,
Am Donnerstag, 27. November 2014, 21:28:21 schrieb Jan Grulich:
As I know, skype is only 32-bit so if you have 64-bit system, you need
32-bit version of sni-qt. I had the same problem on Fedora and installing
sni-qt.i686 solved this problem.
Uh! Thanks for the tip. That made Skype's tray icon
---
In conjunction with Review 121300 these are now ontop of fullscreen windows.
Thanks,
Kai Uwe Broulik
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
16ba4b3
src/netwm.cpp 1ccba32
src/netwm_def.h 0352f33
Diff: https://git.reviewboard.kde.org/r/121299/diff/
Testing
---
In conjunction with Review 121300 these are now ontop of fullscreen windows.
Thanks,
Kai Uwe Broulik
___
Kde
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121299/#review71479
---
Ping?
- Kai Uwe Broulik
On Dez. 1, 2014, 6:49 nachm., Kai
/netwm.cpp 1ccba32
src/netwm_def.h 0352f33
Diff: https://git.reviewboard.kde.org/r/121299/diff/
Testing
---
In conjunction with Review 121300 these are now ontop of fullscreen windows.
Thanks,
Kai Uwe Broulik
___
Kde-frameworks-devel mailing
On Dez. 8, 2014, 9:34 vorm., Kai Uwe Broulik wrote:
the autotest for NET::Supported is not extended for the new supported type
Martin Gräßlin wrote:
I'm still missing the extension of the autotest. In fact I'd expect that
at least one autotest is currently failing.
Could you be more
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121299/#review72290
---
Ping
- Kai Uwe Broulik
On Dez. 9, 2014, 6:16 nachm., Kai
and I'd like to get
this in for Plasma 5.2
- Kai Uwe Broulik
On Dez. 9, 2014, 6:16 nachm., Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121299
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/
---
(Updated May 5, 2011, 3:57 p.m.)
Review request for KDE Base Apps.
. To reply, visit:
http://git.reviewboard.kde.org/r/101282/#review3137
---
On May 5, 2011, 3:57 p.m., Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply, visit
., Christoph Feck wrote:
kdialog/kdialog.cpp, line 378
http://git.reviewboard.kde.org/r/101282/diff/2/?file=16137#file16137line378
Could you add the icon argument to this fallback call, too? See API
docs for KPassivePopup.
Kai Uwe Broulik wrote:
KPassivePopup requires a QPixmap, so I
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/
---
(Updated May 6, 2011, 12:16 p.m.)
Review request for KDE Base Apps.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/#review3158
---
On May 6, 2011, 12:16 p.m., Kai Uwe Broulik wrote
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/
---
(Updated May 6, 2011, 12:15 p.m.)
Review request for KDE Base Apps.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/
---
(Updated May 6, 2011, 2:52 p.m.)
Review request for KDE Base Apps.
---
On May 6, 2011, 2:52 p.m., Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/
---
(Updated May 10, 2011, 10:16 a.m.)
Review request for KDE Base Apps.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101800/
---
Review request for kdelibs.
Summary
---
On IRC this evening somebody
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101800/
---
(Updated June 29, 2011, 9:39 a.m.)
Review request for kdelibs.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101810/
---
Review request for KDE Base Apps.
Summary
---
I always found
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101810/#review4284
---
On June 30, 2011, 5:48 p.m., Kai Uwe Broulik wrote
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101810/
---
(Updated June 30, 2011, 8:47 p.m.)
Review request for KDE Base Apps.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101810/
---
(Updated June 30, 2011, 9:02 p.m.)
Review request for KDE Base Apps.
---
On June 29, 2011, 9:39 a.m., Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101800
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101800/
---
(Updated June 30, 2011, 10:34 p.m.)
Review request for kdelibs.
Changes
/101800/#review4495
---
On June 30, 2011, 10:34 p.m., Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101800
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102149/
---
Review request for kdelibs.
Summary
---
This patch improves the
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102149/
---
(Updated July 30, 2011, 2:51 p.m.)
Review request for kdelibs.
Changes
it once
I'm back
- Kai Uwe
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102149/#review5482
---
On July 30, 2011, 2:51 p.m., Kai Uwe
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102523/
---
(Updated Sept. 3, 2011, 4:22 p.m.)
Review request for KDE Runtime and
---
On Sept. 3, 2011, 4:22 p.m., Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102523
the feature to make the individual activities
selectable, i.e. you can choose in which particular activities an entry should
appear, similar to KWin’s Activity menu in the window title where you can
assign a window to multiple activities.
- Kai Uwe Broulik
On June 1, 2011, 6:07 a.m., Jeffery
ab210c8
Diff: http://git.reviewboard.kde.org/r/102523/diff/
Testing
---
Thanks,
Kai Uwe Broulik
---
On May 23, 2012, 3:25 p.m., Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102523
/
Testing
---
Tested and works. Works with linebreaks and other parameters as well.
Screenshots
---
a sample message
http://git.reviewboard.kde.org/r/105304/s/606/
Thanks,
Kai Uwe Broulik
---
Works.
Thanks,
Kai Uwe Broulik
popping out of nowhere with no context. FTR: I
already made a patch half a year ago or so but was told there was going to be a
major refactor in this area and so I left it.
- Kai Uwe Broulik
On Aug. 26, 2012, 8:40 a.m., Frederik Gladhorn wrote
://git.reviewboard.kde.org/r/106124/#comment15387
When the lock screen comes up I get a brief blickering.
In LightDM and KSplashQML we use
setAttribute(Qt::WA_OpaquePaintEvent);
setAttribute(Qt::WA_NoSystemBackground);
to prevent this. Can you try if this solves the issue?
- Kai Uwe
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105304/#review15735
---
On June 20, 2012, 12:06 a.m., Kai Uwe Broulik wrote
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102523/#review15658
---
On May 23, 2012, 3:25 p.m., Kai Uwe Broulik wrote
http://git.reviewboard.kde.org/r/102657/#comment17603
Can you ensure that devices are not shown duplicated (ie. from the Places
and then from the Harddrive letters)
- Kai Uwe Broulik
On Dec. 4, 2012, 6:25 p.m., Rajeesh K Nambiar wrote
On Dec. 21, 2012, 12:28 a.m., Kai Uwe Broulik wrote:
plasma/generic/wallpapers/image/image.cpp, lines 752-756
http://git.reviewboard.kde.org/r/107821/diff/1/?file=100482#file100482line752
Did I overlook something or where is the non-randomized wallpaper
change now happening
-nativeWidget()-size().width();
- Kai Uwe Broulik
On Jan. 6, 2013, 1:36 p.m., Xuetian Weng wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108222
On Jan. 6, 2013, 3:45 p.m., Kai Uwe Broulik wrote:
Just applied the patch from Review 107983 and your patch resolves the
issue. Would you mind if I use that code to fix KMix OSD?
Xuetian Weng wrote:
Well.. actually I have a review for kmix :P
https://git.reviewboard.kde.org/r
System Settings with Retina settings
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/15/systemsettingstooltips.png
Thanks,
Kai Uwe Broulik
fonts
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/colorbigsizebefore.png
After with huge fonts
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/colorbigsizeafter.png
Thanks,
Kai Uwe Broulik
/uploaded/files/2013/01/16/iconding.png
Thanks,
Kai Uwe Broulik
/colornormalsize.png
Before with huge fonts
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/colorbigsizebefore.png
After with huge fonts
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/colorbigsizeafter.png
Thanks,
Kai Uwe Broulik
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108433/#review25637
---
On Jan. 16, 2013, 1:56 a.m., Kai Uwe Broulik wrote
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108434/#review25636
---
On Jan. 16, 2013, 1:34 a.m., Kai Uwe Broulik wrote
, while probably even
setting one would be sufficient
Kai Uwe Broulik wrote:
minHeight is calculated by the Varies button which is the biggest element
here (font + margin), the font is equal, yes.
Also, all rows are getting a minHeight (it's a for..next loop)
Thomas Lübking wrote
On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote:
instead of maintoolbar (which could be 128px on even a netbook) maybe
relate it to the font height? (what seems to be the idea behind 22px)
Kai Uwe Broulik wrote:
Main toolbar icon size is only settable from 16 to 48 pixels
with Retina settings
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/iconbutton.png
Thanks,
Kai Uwe Broulik
Icon Dialog with 200dpi
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/icondialog.png
Icon Dialog with 200dpi (without patch)
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/icondialog2.png
Thanks,
Kai Uwe Broulik
/108504/#comment19726
Didn't help here
- Kai Uwe Broulik
On Jan. 20, 2013, 11:13 a.m., Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108504
to 4 rows and done.
File Attachments
Icon Dialog with 200dpi
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/icondialog.png
Icon Dialog with 200dpi (without patch)
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/20/icondialog2.png
Thanks,
Kai Uwe
---
On Jan. 20, 2013, 11:15 a.m., Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108504
and this time, desktop icons /can/ be assigned to 256px through the GUI -
even on a 72dpi screen - and that's unlikely the intended size here.
Kai Uwe Broulik wrote:
From what I can tell all the iconButtons are using Desktop icon sizes
(either properly or some constant), so using
/108504/#comment19799
I should've googl'd a bit more thorougly.
Using q-setInitialSize works here :)
- Kai Uwe Broulik
On Jan. 20, 2013, 11:15 a.m., Kai Uwe Broulik wrote:
---
This is an automatically generated e-mail. To reply
On July 12, 2012, 4:17 p.m., David Faure wrote:
Looks good. For master only, though, given feature+message freeze in 4.9.
Kai Uwe Broulik wrote:
Totally forgot to commit this :( Will do for master (4.10) once my ssh
key for my new notebook got imported.
Albert Astals Cid wrote
On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote:
instead of maintoolbar (which could be 128px on even a netbook) maybe
relate it to the font height? (what seems to be the idea behind 22px)
Kai Uwe Broulik wrote:
Main toolbar icon size is only settable from 16 to 48 pixels
On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote:
instead of maintoolbar (which could be 128px on even a netbook) maybe
relate it to the font height? (what seems to be the idea behind 22px)
Kai Uwe Broulik wrote:
Main toolbar icon size is only settable from 16 to 48 pixels
On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote:
instead of maintoolbar (which could be 128px on even a netbook) maybe
relate it to the font height? (what seems to be the idea behind 22px)
Kai Uwe Broulik wrote:
Main toolbar icon size is only settable from 16 to 48 pixels
On Jan. 16, 2013, 10:01 a.m., Thomas Lübking wrote:
instead of maintoolbar (which could be 128px on even a netbook) maybe
relate it to the font height? (what seems to be the idea behind 22px)
Kai Uwe Broulik wrote:
Main toolbar icon size is only settable from 16 to 48 pixels
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108442/#review27639
---
Ping?
- Kai Uwe Broulik
On Jan. 16, 2013, 6:18 p.m., Kai
:)
File Attachments
Before
http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmessagebefore.png
After
http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmsgafter.png
Thanks,
Kai Uwe Broulik
.
- Kai Uwe
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110084/#review31289
---
On April 19, 2013, 1:08 p.m., Kai Uwe Broulik wrote
Hi there,
I've written a patch for Dolphin that de-clutters the Places panel context menu
entries. Most entries redundandly contain the item's name and there are also
menu entries that affect the general Panel behavior/look and feel (such as Icon
Size) which are not available on the generic
://git.reviewboard.kde.org/r/110266/diff/
Testing
---
Tested in the Open File dialog of Kolourpaint. Looks nice, works.
File Attachments
Comparison (left old, right new)
http://git.reviewboard.kde.org/media/uploaded/files/2013/05/02/kdelibsplaces.png
Thanks,
Kai Uwe Broulik
/110266/#comment23765
Forgot to remove the label argument everywhere. (Wouldn't i18n normally
spawn an I18N_EXCESS_ARGUMENTS then? weird.)
- Kai Uwe Broulik
On May 2, 2013, 8:05 a.m., Kai Uwe Broulik wrote
Attachments
Before
http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmessagebefore.png
After
http://git.reviewboard.kde.org/media/uploaded/files/2013/04/19/ftpmsgafter.png
Thanks,
Kai Uwe Broulik
On May 7, 2013, 12:50 p.m., Dominik Haumann wrote:
The patch itself is fine and most likely does not introduce regressions in
terms of misbehavior.
Still, is never showing an icon the way to go? Another way to work around
this by default would be an additional function called
the upper (main) line (h2
or maybe just b), get rid of the empty line(s? - trailing one) and ideally
get the close button top aligned (esp. since it almost looks like the icon...)
Kai Uwe Broulik wrote:
I have no idea how long that message can actually get and if it will
always start
the upper (main) line (h2
or maybe just b), get rid of the empty line(s? - trailing one) and ideally
get the close button top aligned (esp. since it almost looks like the icon...)
Kai Uwe Broulik wrote:
I have no idea how long that message can actually get and if it will
always start
scales perfectly and looks good. See screenshot.
File Attachments
KPropertiesDialog with Retina settings
http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/iconbutton.png
Thanks,
Kai Uwe Broulik
working on a
remote file won't appear anymore after the first save progress.
- Kai Uwe Broulik
On July 11, 2013, 1:54 p.m., Cedric Bellegarde wrote:
---
This is an automatically generated e-mail. To reply, visit:
http
it to show the
currently played track again.
Imho this should somehow be fixed in Amarok, it is the only app I know that has
this issue.
- Kai Uwe Broulik
On July 16, 2013, 12:01 p.m., Cedric Bellegarde wrote
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112529/#review39399
---
There seems to be no patch attached
- Kai Uwe Broulik
.
- Kai Uwe Broulik
On Oct. 8, 2013, 3:13 p.m., Sven Brauch wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113175
-
kio/kssl/kcm/kcm_ssl.desktop c1cebd6
Diff: http://git.reviewboard.kde.org/r/108312/diff/
Testing
---
kbuildsycoca4 doesn't complain :-)
Thanks,
Kai Uwe Broulik
/
Thanks,
Kai Uwe Broulik
-baseapps]
dolphin/src/panels/places/placesitemmodel.cpp then.
- Kai Uwe Broulik
On Oct. 27, 2013, 7:07 p.m., Xuetian Weng wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104222
On Oct. 27, 2013, 7:09 p.m., Kai Uwe Broulik wrote:
Note that this needs similar adjustments in Dolphin [kde-baseapps]
dolphin/src/panels/places/placesitemmodel.cpp then.
Belay that, I guess showing Recent places in Dolphin isn't that needed. Sorry
for the noise.
- Kai Uwe
the images
- Kai Uwe Broulik
On Nov. 4, 2013, 8:22 p.m., Martin Klapetek wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113630
://git.reviewboard.kde.org/r/113885/#comment31524
Add a doxygen comment about the blurBehindEffect param
tier1/kwindowsystem/src/kwindoweffects_x11.cpp
http://git.reviewboard.kde.org/r/113885/#comment31523
Unused include?
- Kai Uwe Broulik
On Nov. 15, 2013, 2:54 p.m., Marco Martin wrote
On Dec. 13, 2013, 2:27 p.m., Frank Reininghaus wrote:
Thanks for looking into this, Dawit! I greatly appreciate this effort.
Two questions come to my mind:
1. Why should these dialogs be modal at all? Everything that KIO does is
asynchronous, so it could very well be that the
1 - 100 of 2510 matches
Mail list logo
