D17631: class Message: Use inclass member initialization

loh.tar accepted this revision. loh.tar added a comment. This revision is now accepted and ready to land. I'm surprised. Obviously have you change something previous (?) REPOSITORY R39 KTextEditor BRANCH message_inclass_member_initializationa REVISION DETAIL https://phabricator.kde.org

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

loh.tar created this revision. loh.tar added reviewers: KTextEditor, VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Without this patch is in "Dynamic Wrap Mode" the text alway

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

loh.tar added a comment. - No sure if there must be something at other places considered - This is my second version where the wrap is done ether at the static setting or the view width, whatever is smaller. At first is was always wrapped at the static setting. Then I thought it may this wa

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47843. loh.tar added a comment. - Fix too much stretching of Cancel|Find/Replace button (I misunderstood probably Andres above :-) - Add S&R progress hint, Rename showInfoMessage(..) -> showResultMessage() and move logic in what text to show Notes:

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY The first attempt was to add these chars to the auto bracket co

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

loh.tar added a comment. Should you dislike the auto bracket code changes can I remove them from this patch. They are not needed for this one and only be the byproduct of my code studying. As always, poor tested :-) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D17459 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

loh.tar added a comment. > the change from QChar to const QChar & does not improve the amount of copied data. Argh! OK. Was just an impulse to do it as usual and to follow isStartBracket(..) and isBracket(..) Will wait for further advice REPOSITORY R39 KTextEditor REVISION DETAIL

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47891. loh.tar added a comment. - Workaround to keep binary compatibility > It's exported class you cannot... Argh! How can I see this quickly the next time? KTEXTEDITOR_EXPORT ? - Seams still to work so far, but looks not so lovely - Fixed

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47907. loh.tar added a comment. Fixed/Simplified as suggested - I noticed a reproducible crash when e.g. Kate will closed while a S&R is running. Happens also when a split view is closed (so far so good) and then Kate will closed . I will try to solv

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47963. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Fix crash when the document will closed while a S&R job is running - Fix crash when the view will closed while a S&R job is running These fixes seems t

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added a comment. I have tried to run two S&R jobs at the same time on the same document, seems to works nicely - view 1 -> S&R "tab" -> "-" - view 2 -> S&R "0" -> "+" I had canceled both jobs and then resume, that's why at the pic are already replacents to see while the jo

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added inline comments. INLINE COMMENTS > anthonyfieroni wrote in katesearchbar.cpp:860-865 > Maybe not an issue, but you can try to cache value preventing unwanted lookup > > auto dd = d(this); > dd->... Only here or everywhere? At this particular place may that optimized by the com

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47966. loh.tar added a comment. Improve the readability and prevent unwanted lookup by caching d(this) as dd REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17459?vs=47963&id=47966 REVISION DETAIL https://phabricat

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

loh.tar created this revision. loh.tar added reviewers: KTextEditor, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.o

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

loh.tar added a comment. Nothing else was done REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17729 To: loh.tar, #ktexteditor, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - KateStatusBar: Do actions on labels by single click instead o

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar updated this revision to Diff 47998. loh.tar edited the summary of this revision. loh.tar added a comment. - KateStatusBar: Don't treat click in empty area as click on mode-label REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17730?vs=47997&id=47

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar added a comment. Oops, have now the first commit omitted in this update. Perhaps not too bad this way(?) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh,

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar added a comment. How about to change the "action-labels" to buttons? Thisway would it be less "quirky" and we would have a feedback that there is an action available when hovered by mouse REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar,

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar updated this revision to Diff 48000. loh.tar edited the summary of this revision. loh.tar added a comment. - KateStatusBar: Move the modified-label from far right to far left Once again without all other patches REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://pha

D17733: ViewPrivate: Don't hide 'Clear Dictionary Ranges' action

loh.tar created this revision. loh.tar added reviewers: KTextEditor, VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Toggle the action instead enable/disable ensure the user kn

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

loh.tar added a comment. - It's a prearrangement for more changes D17730 - In the meantime I noticed that these astyle command did not move/fix to place "*&" to the right. I will update/fix this before someone like to commit REPOSITORY R39 KTextEditor

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

loh.tar updated this revision to Diff 48054. loh.tar added a comment. - Run astyle again, this time with "--align-pointer=name" - Omit changes done in the signal/slot connect code because these need a port to the new style. Well, was somehow pointless because these code is changed anyway bu

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar added a comment. > My main intent is to add somehow a spell check button/hint Here a snapshot how it looks currently F6503235: 1545570321.png Sadly stuck I now, every help is appreciated I like to show on the button the current use

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar updated this revision to Diff 48236. loh.tar edited the summary of this revision. loh.tar added a comment. - Only show lineColLabel context menu when click on it and not somewhere on the bar As "usual" without all other patches. > No idea how the spell-checking code handles t

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar updated this revision to Diff 48237. loh.tar edited the test plan for this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - All in one diff - Rebased on master - Removed test plan - Will update Summary/Title before you commit R

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

loh.tar added a comment. > Btw., have you perhaps played a bit with the https://phabricator.kde.org/D12295 patch? No, but noticed it sometime in the past > If you use it, could you try that patch, too? Will try it REPOSITORY R39 KTextEditor REVISION DETAIL https://phabrica

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

loh.tar added a comment. @cullmann wrote: > Actually, if there is a astyle commandline that enforces the right style, could you paste it here? Um (?) I had in mind it was on the Kate HP but couln'd find it now. But it's there https://community.kde.org/Policies/Kdelibs_Coding_Style#

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar added a comment. > For the "should we use buttons": I think I tried that in the past and it did look horrible in many styles, but perhaps I am wrong ;) I see. May it in the meantime not an issue anymore, due to new designs elsewhere? And what's up with the existing buttons, they

D12295: Supporting nested brackets for Kate autobrackets

loh.tar added a comment. His original post with some more text/hints/questions https://mail.kde.org/pipermail/kwrite-devel/2018-April/000345.html He got the advice from @brauch to post here. For me a little bit hard to follow, not only there but also here. I could apply this patc

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar added a comment. > ..as soon as you split (and as the statusbar dictates the minimum size), you will get in trouble. My first thought was, "Oops, right!" But while I verifying this I notice that the status bar has the full width of the window, not only the split view.

D17730: [WIP] Review KateStatusBar

loh.tar updated this revision to Diff 48285. loh.tar retitled this revision from "[WIP] Review KateStatusBar (based on D17729)" to "[WIP] Review KateStatusBar ". loh.tar edited the summary of this revision. loh.tar added a comment. - Introduce StatusBarButton - Don't gray out m_modifiedLabel

D17730: [WIP] Review KateStatusBar

loh.tar updated this revision to Diff 48334. loh.tar edited the summary of this revision. loh.tar added a comment. - Change to new signal/slot style (Idea how to fix the two missing ones?) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17730?vs=48285&id=48334 REVISION DETAIL https

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY BUG: 402594 REPOSITORY R39 KTextEditor REVISION DETAIL ht

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at aned of file

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ...when 'Allow scrolling past the end of the document' is set

D17730: [WIP] Review KateStatusBar

loh.tar updated this revision to Diff 48374. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Fix remaining signal/slot, Thanks for the hint! :-) > Beside that, I tried the patch, the status bar looks nice ;=) :-) > I would have no issue

D17730: Review KateStatusBar

loh.tar updated this revision to Diff 48387. loh.tar retitled this revision from "[WIP] Review KateStatusBar " to "Review KateStatusBar ". loh.tar edited the summary of this revision. loh.tar added a comment. - Remove seemingly unneeded spacing. Well, there is a change but tiny and perhaps to

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar retitled this revision from "DocumentPrivate: Don't scroll view when add auto-bracket at aned of file" to "DocumentPrivate: Don't scroll view when add auto-bracket at end of file". loh.tar edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://pha

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar added a comment. As always poor tested and only in "normal mode", not vi INLINE COMMENTS > katedocument.cpp:3073 > const auto insertedAt(view->cursorPosition()); > -view->setCursorPosition(cursorPos); > m_currentAutobraceRange.reset(ne

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added a comment. Do I have to revert this d-stuff? If so, some other tweak, or just as it was? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17459 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, kd

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar added a comment. In D17857#383865 , @dhaumann wrote: > Is this related to bug https://bugs.kde.org/show_bug.cgi?id=306745 ? I don't think so. Here is it auto-bracket stuff, there general "is visible" stuff :-) (Yeah, my English ro

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 48391. loh.tar added a comment. - Revert d-stuff - Remove BCI stuff I'm still looking for a better name for "m_cancelFindOrReplace", suggestions? CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17459?vs=47966&id=48391 REVISION DETAIL htt

D17730: Review KateStatusBar

loh.tar added a comment. I'm pretty baffled. What does the status bar which may break some input (mode) ? These report says nothing to me. Well, ok, the vi-mode can enabled/disabled :-/ REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar, #ktexted

D17730: Review KateStatusBar

loh.tar added a comment. One idea: Now you have only to click once to change some setting, not twice (double-click). So if these test simulate a clicks... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar, #ktexteditor, cullmann Cc: zetazeta, cull

D17730: Review KateStatusBar

loh.tar added a comment. Harr, one more issue :-/ F6516314: 1546186710.png Idea how to fix this? I had in the past often such trouble, but so far I remember no solution. So my fix would be to remove the emphasis. Is it OK to update this diff here

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

loh.tar updated this revision to Diff 48486. loh.tar retitled this revision from "DocumentPrivate: Remove comment mark when joining lines" to "WIP DocumentPrivate: Remove all from next line which may annoying when joining lines". loh.tar edited the summary of this revision. loh.tar added a commen

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

loh.tar added a comment. It's almost untested, will try to use it on daily basis. After think a little about it, I came to this variant. Code lines are unlikely to "join", so why test for comments? A little off topic: Would it OK to modify the wrap stuff that it behaves differently? Th

D17949: ViewPrivate: Make applyWordWrap() more comfortable

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Don't wrap entire document when nothing is selected but wrap

D17730: Review KateStatusBar

loh.tar added a comment. > Do we loose this property by using real buttons instead of labels as this patch proposes? I don't think so. The buttons are not entire new, only some labels are now ALSO buttons. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D1773

D17956: DocumentPrivate: Fix broken doc links in qCWarning

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17956

D17956: DocumentPrivate: Fix broken doc links in qCWarning

loh.tar added a comment. How about to change this logging into a warning message in the view? Or will it displayed(?) I have noticed these while investigating https://bugs.kde.org/show_bug.cgi?id=397956 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17956 To:

D17956: DocumentPrivate: Fix broken doc links in qCWarning

loh.tar updated this revision to Diff 48671. loh.tar added a comment. Requested modified link CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17956?vs=48655&id=48671 REVISION DETAIL https://phabricator.kde.org/D17956 AFFECTED FILES src/document/katedocument.cpp To: loh.tar, #kt

D17970: Fix broken Emmet

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Improve warning message with line number BUG: 386151 RE

D17970: Fix broken Emmet

loh.tar added a comment. Well, if it is fixed I can't say. At least the error is gone and "Increment/Decrement" works. May some guru investigate if its fixed. Obviously is there a problem with these string constants. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.o

D17730: Review KateStatusBar

loh.tar added a comment. That can I not really imagine :-/ Wouldn't that not somehow to be notice in normal use? Let's try this. Shot without bar, Now choose "Show bar", The window didn't change. (Sorry, no tool at hand to paste pics together) The bar can shrink almost endless. REPOSITO

D17970: Fix broken Emmet

loh.tar added a comment. May I ask a stupid question? Is the entire function needed? That's looks to me somehow like image/picture stuff but I don't find picture stuff in the Tool->Emmet menu. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17970 To: loh.tar, #k

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY With this option is the cursor not moved to the mouse position

D17730: Review KateStatusBar

loh.tar added a comment. @zetazeta wrote > I find it annoying that the status bar imposes a limit on the minimum width of the window @dhaumann wrote > Maybe with this patch, the status bar grows and forces a different width me wrote > The bar can shrink almost endless

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. Please provide also a tooltip/whats-this text, if useful. My QtDesigner did not show the needed widget stuff, so the text is not set. A look at that bug report may give more hints/ideas REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D179

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar updated this revision to Diff 48778. loh.tar edited the summary of this revision. loh.tar added a comment. Change checkbox text as suggested CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17999?vs=48764&id=48778 REVISION DETAIL https://phabricator.kde.org/D17999 AFFECTED

D17730: Review KateStatusBar

loh.tar updated this revision to Diff 48781. loh.tar added a comment. Allow StatusBarButton to shrink Ah! Strange! :-/ But somehow the more usual behavior, these "crunching" is unlikely. Couldn't find a hint where it is done in Kate, but after some digging around I have some solution whi

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. In D17999#387370 , @dhaumann wrote: > Hm, didn't you switch the meaning... I hope you mean @ngraham :-) I just typed overslept what he wrote...yes he has. Before I only kill that "mouse" I like to ask the native

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

loh.tar added a comment. > Will wait for further advice Still waiting if I have to undo these reference stuff. (Yes your are busy. Just only wanted it to emphasize) Besides, I like to add some more chars to this special handling: _ : # @ ~ * ! $ % / \ Some of these may handy

D12295: Supporting nested brackets for Kate autobrackets

loh.tar added a comment. I didn't test it even more but think on it from time to time. If my slightly negative comment was OK or too fast judged. And yes it may. On the other hand I ask me if the approach to track each key stroke and change the behavior on that record is right or a wrong

D17730: Review KateStatusBar

loh.tar updated this revision to Diff 48813. loh.tar edited the summary of this revision. loh.tar added a comment. - Remove not supported Rich Text from [BLOCK] hint - Add word count info to line label F6530066: pic.png CHANGES SINCE LAST UPDATE

D17310: Use a Kile Icon that is similar to the original

loh.tar added a comment. Yes looks nice. Would be good as icon for the Kile Handbook, for the application I would omit/avoid the "Notebook" look. REPOSITORY R266 Breeze Icons BRANCH improve-kile-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D17310 To: tri

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. I agree, it's on the first sight pretty clear. But then can you force this "style" for every bool option. In the above linked pic is this obviously only used for Normal vs Vi-Mode [1] A drawback of that "style" may that you can't say for sure "which is what" in

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

loh.tar updated this revision to Diff 48994. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. Try to be smart REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17128?vs=48486&id=48994 REVISION DETAIL https://phabr

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

loh.tar added inline comments. INLINE COMMENTS > katedocument.cpp:4016 > // behavior when deleting from the start of a line, just when > explicitly > // calling the join command > Kate::TextLine tl = kateTextLine(line + 1); Can one point me why this is needed/desired?

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. To avoid further comments I like to add that I don't like to do the requested change. Please improve it later, if needed. REVISION DETAIL https://phabricator.kde.org/D17999 To: loh.tar, #ktexteditor, dhaumann Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frame

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. Sure, can do it. Which one have it to be ? - Paste clipboard contents at cursor location - Paste clipboard contents at cursor position - Paste by mouse at cursor position (This one was liked by Dominik, IIRC) REVISION DETAIL https://phabricator.kde.org/D1799

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar updated this revision to Diff 48999. loh.tar added a comment. Back to "Paste by mouse at cursor position" CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17999?vs=48778&id=48999 REVISION DETAIL https://phabricator.kde.org/D17999 AFFECTED FILES src/dialogs/editconfigwidge

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. In D17999#389148 , @cullmann wrote: > "Paste by mouse at cursor position" should be ok, then I will push this, ok? Well, a last close look is nerver bad. REVISION DETAIL https://phabricator.kde.org/D17999 To: l

D18116: Don't show document load trouble twice

loh.tar created this revision. loh.tar added reviewers: KTextEditor, cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Since there are fancy "in view" messages whi

D18116: Don't show document load trouble twice

loh.tar added a comment. I have it only poor tested with our big S&R file, so no test was made with other trouble causing stuff. This need a patch in Kate, will try to link that KateBuffer::openFile - There is no distingues from 1. "create new file by command line" and 2. "

D17730: Review KateStatusBar

loh.tar added a comment. > It was stated that it broke tests, should this be addressed now? As shown in the pic, the bar forces no width anymore (at least it seems so) Your comments at the bug report are interesting, but I'm not sure to do it. I had Christoph promised to add options to

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

loh.tar added a comment. Nice trick ;-) Can't promise to do it, will see REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17852 To: loh.tar, #ktexteditor Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, cull

D18125: KateStatusBar: Add dictionary button

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ...to indicate the current dictionary and for the handy access

D18125: KateStatusBar: Add dictionary button

loh.tar added a comment. The shown dictionary is sometimes "wrong" - Mark a word by double-click and choose a dictionary different from the default for that word - Click/move into the word -> The shown dictionary fit - Double-Click that word again -> The shown dictionary is the defaul

D18125: KateStatusBar: Add dictionary button

loh.tar added a comment. > Isn't en_US too cryptic? Well, yes. > I suggest to use the just added KLanguageName (see D10446 ). With this, you can get a nice name like "English (USA)". Alternatively, you may use QLocale("en_US").nativeLanguageName(

D18125: KateStatusBar: Add dictionary button

loh.tar updated this revision to Diff 49099. loh.tar added a comment. - Add missing signals to watch dict changes - Ensure button is set on first show Looks fixed, give it a try. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18125?vs=49078&id=49099 REVISION DETAIL https://

D18164: Review KateGotoBar

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Set minimum value of spin-box to 1 - Don't force minimum wi

D18125: KateStatusBar: Add dictionary button

loh.tar added a comment. I'm very much against such a label, and against the full name. "UTF-8" has also no label and that's good. The only stuff where a description label is needed are these line/column/word hints. Without a label are you almost lost to know which is what. However, i

D18164: Review KateGotoBar

loh.tar added a comment. I was about to move StatusBarButton into kateviewhelpers, so that this button can used elsewhere too, like here. But got stuck. However, I think such button would be handy. Perhaps also a KateViewBarLayout. Here shot regarding 'Change label text to be less redunda

D18164: Review KateGotoBar

loh.tar updated this revision to Diff 49243. loh.tar added a comment. - Use 120 as wheel-delta threshold - Use member instead of static local > If not do it right you can end up in partial value when it used finer-resolution wheels and mishmash. I have problems to see that hazard,

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

loh.tar added a comment. Sadly is the benefit, to reduce the menu entries, not "optimal". In the pics you have now 3 sub-entries for one "Variant" entry, effectively only 2 less per topic. I may like it if these "Variant-Action" could be avoided and merged with one of the "Normal-Action

D17730: Review KateStatusBar

loh.tar added a comment. > I like the new status bar. Thanks :-) > In "modified" state it would be cool to be able to click to save the document Yes, that was also my idea. IIRC I had somewhere asked but got no response. Will do it soon. > Move the modified label from far

D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

loh.tar updated this revision to Diff 49452. loh.tar retitled this revision from "DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection" to "DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection". loh.tar edited the

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

loh.tar updated this revision to Diff 49530. loh.tar added a comment. Add autotest CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17852?vs=48340&id=49530 REVISION DETAIL https://phabricator.kde.org/D17852 AFFECTED FILES autotests/src/kateview_test.cpp autotests/src/kateview_t

D17949: ViewPrivate: Make applyWordWrap() more comfortable

loh.tar added subscribers: cullmann, dhaumann. loh.tar added a comment. > please add proper tests for this functionality No idea how Because there are a couple of bug reports where often the response was like "No, can't be done" need this a closer look from @dhaumann and @cullmann

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

loh.tar added a comment. > can you please rephrase the title of this review to make it understandable? Of course, if I could, I would have done it :-) "Remove all what is not nice text" ? It may help you to read all posts to get a hint of my intention. It turned out that this here ist s

D18164: Review KateGotoBar

loh.tar added a comment. > I have the feeling it adds more clutter than it helps by default: Code clutter or what? The functionality is lovely and I can't see in which way It may someone jar > I thinkis quite fast. For a keyboard-virtuoso for sure. I'm one of those who use o

D17949: ViewPrivate: Make applyWordWrap() more comfortable

loh.tar added a comment. Interesting. Didn't know that such function exist. Well, it may help to read the handbook... Is there no GUI way to access such stuff? "Read the handbook" lala... Well, word/text wrapping is a field which has many room for improvements. - Adjust as block by

D18164: Review KateGotoBar

loh.tar updated this revision to Diff 49636. loh.tar added a comment. - Fix typo of member vars - Add missing setView(m_view) - Remove FIXME hint about timer, however would a comment for me nice - Use QString() Things which could be improved or not - The up/down buttons are a li

D18125: KateStatusBar: Add dictionary button

loh.tar added a subscriber: cullmann. loh.tar added a comment. @cullmann @dhaumann A short not how to progress would be nice. - Keep codes as they are - Shorten codes as suggested - Replace codes by flags/ensign (no idea how) - Add (unneeded) label - Show (unneeded long) full name

D18164: Review KateGotoBar

loh.tar updated this revision to Diff 49653. loh.tar edited the summary of this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Morph updateData() into a slot - connect to Document::textChanged signal REPOSITORY R39 KTextEditor CHANGES

D18164: Review KateGotoBar

loh.tar updated this revision to Diff 49665. loh.tar added a comment. - Connect/Disconnect - Remove m_gotoRange->setFocus Like this? :-/ I noticed bad behavior and have remove these setFocus, test it if its OK. On edit was always the focus set to the spinbox. CHANGES SINCE LAST U

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 49754. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Fix to pass autotest 97% tests passed, 2 tests failed out of 67 Total Test time (real) = 137.70 sec The following tests FAILED: 24 - kat

D18317: Don't fail if defaultLanguage dictionary can't be loaded

loh.tar added a comment. Just my thoughts: - I think there shouldn't be the (default) dictionary changed by some smart logic. Just hint the user that the setting is not applicable. - To set the dict to the system locale seems to me the less smartest trick. If everybody want such "auto-

<    1   2   3   4   5   >