D24226: bitbake: handle embedded shell and python

This revision was automatically updated to reflect the committed changes. Closed by commit R216:53187de4a78a: bitbake: handle embedded shell and python (authored by mnauwelaerts). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24226?vs=66835=66837

D24226: bitbake: handle embedded shell and python

mnauwelaerts created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. mnauwelaerts requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH syntax-bitbake (branched from master) REVISION DETAIL

D18563: Don't create directory tree when a new folder has a '/' in the name

markg added a comment. In D18563#402216 , @ngraham wrote: > It's rather ironic that in D18571 , I endorse a hidden productivity booster feature, but here, I reject one. :) > > I think I'm reconsidering.

D18563: Don't create directory tree when a new folder has a '/' in the name

markg added a comment. In D18563#401979 , @shubham wrote: > @ndavis UNIX does not allow / in any valid identifier name. > Also looking at the bug report, it feels like people wanted to create a folder named "a/b/c" which UNEXPECTEDLY created

D18380: KIO: make file dialog columns resizable again (and movable)

markg added a comment. In D18380#400910 , @rjvbb wrote: > > But still, isn't there another way? Now the header and view are locked together. One doesn't work without the other. > > What's the problem with that? The custom header class isn't

D18380: KIO: make file dialog columns resizable again (and movable)

markg added a comment. In D18380#400903 , @ngraham wrote: > In D18380#400896 , @markg wrote: > > > In QHeaderView code, what we want is "QHeaderView::Interactive" [1] followed by

D18380: KIO: make file dialog columns resizable again (and movable)

markg requested changes to this revision. markg added a comment. This revision now requires changes to proceed. I too would quite like the to have resizeable columns back. But the approach you've chosen looks a little too complicated. Also, the fact that KDirOperatorDetailView::event needs

D15071: Don't draw frames and shadows around images with transparency

markg added a comment. (repost from D15069 ) Hi Nate, I'm afraid this will give inconsistent frames, at least that will be the perception of the user. The hasAlpha function on a QPixmap (probably) boils down to executing this function:

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

markg added a comment. It "looks" oke to me, but i don't know this code one bit. INLINE COMMENTS > recentdocuments.cpp:82-83 > +if (urlInside.scheme() == "recentdocuments" > +// Filter out things that can't be viewed in a file > manager because they don't

D13814: Speedup sort

markg added a comment. In D13814#290512 , @bruns wrote: > The code looks fine now, but the summary is incorrect. > > The savings is not from using a lambda, but caused by initializing it once. If the old code had used

D13814: Speedup sort

markg added a comment. Somehow i'm inclined to think that m_collator is wrong. But inspecting the code shows no issue as far as i can tell. It's a normal class member that lives as long as the KFileItemModel instance lives. Now here's a tricky part. KFileItemModel is new'ed for each

D13814: Speedup sort

markg added a comment. In D13814#287959 , @jtamate wrote: > I really, really hate these things. > I've been testing this patch more than one month without any problem. > And now, after pushing it, I got crashes everytime I start dolphin

D13124: Add Share action to Dolphin context menu

markg added a comment. In D13124#286263 , @elvisangelaccio wrote: > In D13124#286115 , @broulik wrote: > > > Check out `KFileItemActions::addServiceActionsTo` > > > Actually,

D13124: Add Share action to Dolphin context menu

markg added a comment. This looks great! But i don't get how it is magically included in Dolphin.. Perhaps someone could explain? I get that it's a fileitemaction plugin and that it's being loaded by dolphin (somehow), i take that for granted. But even so, if i look in the dolphin

D13814: Speedup sort

markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. 2x +1 = +2 Ship it :) REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13814 To: jtamate, #dolphin, #frameworks, markg Cc: apol, bruns, markg, kfm-devel, spoorun,

D13814: Speedup sort

markg added a comment. In D13814#285686 , @bruns wrote: > In D13814#285660 , @markg wrote: > > > > I don't know if that's still an issue or if your patch re-introduces whatever the problem was (race

D13814: Speedup sort

markg added a comment. > I don't know if that's still an issue or if your patch re-introduces whatever the problem was (race conditions?). You could look back in the commit log when that was added to figure out more about it. To answer that myself, it was done in this commit:

D13814: Speedup sort

markg added a comment. +1 Great! :) Back to the good old fast performance it once had! Please do get rid of the underscore before the name. Nothing (afaict) does that in Dolphin, lets not introduce it. Just lessThan is fine. Also, note that this was done for a reason. I think it

D13211: Enable comparing KFileItems by url

markg added a comment. While this works, there is a newer en better way for it. It's new in C++14 and called "transparent compare". In "this" case it won't change the resulting code of how you compare, but it might be worth checking that out. Read this:

D13358: Add new class that is a model of numbers between two values

markg added a comment. This basically is the equivalent of the C++ range iterator (https://github.com/ryanhaining/cppitertools#range, but more libraries have a "range" iterator like that). In all the documentation blocks you miss the argument and return value documentation. I'm

D10702: Always use a job to delete files to avoid freezing process waiting on IO

markg added a comment. In D10702#273040 <https://phabricator.kde.org/D10702#273040>, @meven wrote: > Great suggestion Mark ! > > I am a C++ beginner, I did not consider this neat C++ 14 feature. > > This will necessitate a c++ compiler dependency change thoug

D13124: [RFC] Add Share action to Dolphin context menu

markg added a comment. In D13124#272698 , @nicolasfella wrote: > Friendly ping? ? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, #dolphin, apol, elvisangelaccio Cc: markg,

D10702: Always use a job to delete files to avoid freezing process waiting on IO

have built on the assumption (knowingly or not) that the function only returns after the file(s) have been removed, which would not the case after this patch. > An opt-in boolean option could be needed to trigger the new behavior while keeping the old one for applications that have been up

D12218: Remove Reload button from the file dialogs' toolbar

markg added a comment. In D12218#271375 , @rkflx wrote: > In D12218#271290 , @davidedmundson wrote: > > > > It can be useful for network views, but those are a minority of use cases > > > >

D12765: Use a more intuitive, user-friendly name for Samba share access

markg added a comment. In D12765#260054 , @ngraham wrote: > Which ones, and where do they live? I would have expected it for NFS (same repository), but it apparently doesn't have a .desktop file at all. FTP (lives in the mina kio repo

D12765: Use a more intuitive, user-friendly name for Samba share access

markg accepted this revision. markg added a comment. Please do note that you have more protocols with shared folders that likely deserve a name change in the same fashion. REPOSITORY R320 KIO Extras BRANCH friendlier-samba-share-name (branched from master) REVISION DETAIL

D12321: Hide file preview when icon is too small

markg resigned from this revision. markg added a comment. This revision is now accepted and ready to land. I guess it's time for me to resign from this one. Good luck folks :) REPOSITORY R241 KIO BRANCH conditional_preview (branched from master) REVISION DETAIL

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#253839 , @rkflx wrote: > @markg I just read the whole thing again. As far as I can see, your main concerns were: > > - Not being able to show previews for icon sets of small PNG files. I initially

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#252393 , @rkflx wrote: > In D12321#252374 , @markg wrote: > > > The blown up way of looking at it (resized version) does not give you an accurate representation of

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#252366 , @ngraham wrote: > In D12321#252365 , @markg wrote: > > > > Browse... grid view... small size... previews... icons... so you want to be able to do this? >

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#252369 , @rkflx wrote: > In D12321#252337 , @markg wrote: > > > In those cases where you just browse through a gazillion icons (nothing with an icon picker or

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#252346 , @ngraham wrote: > In D12321#252337 , @markg wrote: > > > In D12321#252299 , @rkflx wrote: > > > > > > Then

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#252299 , @rkflx wrote: > > Then you make it impossible (ultimately, not with this patch though) to for instance browse through folders with small icons (say icon sets). > > We have an explicit icon chooser

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#252285 , @rkflx wrote: > In D12321#252283 , @markg wrote: > > > In D12321#252282 , @rkflx wrote: > > > > > In

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#252282 , @rkflx wrote: > In D12321#252281 , @markg wrote: > > > I agree but not for a button that the user controls. > > > We already disable options where they

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#252264 , @rkflx wrote: > In D12321#252261 , @markg wrote: > > > That is unexpected behavior. > > > I disagree, adapting the interface dynamically is good

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#252259 , @anemeth wrote: > In D12321#252238 , @markg wrote: > > > You are overwriting a setting that the user had explicitly set (show preview). That will result in

D12321: Hide file preview when icon is too small

markg requested changes to this revision. markg added a comment. This revision now requires changes to proceed. That looks really fancy! :) Yet i have to give it a -1.. You are overwriting a setting that the user had explicitly set (show preview). That will result in a "huh, why is the

D11768: Add Desktop and Downloads to the default list of Places

markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Blocking it any longer seems rude to me :) REPOSITORY R241 KIO BRANCH add-desktop-and-downloads (branched from master) REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham,

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

markg added a comment. In D12337#249814 , @rkflx wrote: > In D12337#249528 , @rkflx wrote: > > > F5812548: KIO-toolbar-sort-button.png > > > @broulik

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

markg added a comment. In D12337#249784 , @ngraham wrote: > In D12337#249782 , @markg wrote: > > > Sort already is "right in front" of the user. They merely have to click the column headers. > >

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

markg added a comment. Sort already is "right in front" of the user. They merely have to click the column headers. These column headers used to (before the breeze theme, i think the air theme had it) show arrows indicating if something was sorted in ascending or descending. I don't know

D12218: Remove Reload button from the file dialogs' toolbar

markg added a comment. In D12218#247481 , @ngraham wrote: > In D12218#247400 , @markg wrote: > > > As i said, it's all relative. I barely use any of the buttons but the one i do use is refresh. >

D12218: Remove Reload button from the file dialogs' toolbar

markg added a comment. >> Refresh on the other hand is something i use relatively often, more then any of the other buttons. > > Curious to know: What do you need Refresh for? Maybe there's need for some changes so you won't have to hit that button manually so often? As i said,

D12218: Remove Reload button from the file dialogs' toolbar

markg added a comment. I personally find the reload button much more useful to have there. ... (looking at the buttons) ... Why not removing back, forward and up? This is not an ironic or sarcastic suggestion! Just be frank, how often do you use back? How often do you use forward

D11204: Support NTFS hidden files

markg added a comment. In D11204#247248 , @vonreth wrote: > The commit broke the build on mac. > > 11:43:10

D11768: Add Desktop and Downloads to the default list of Places

markg requested changes to this revision. markg added a comment. This revision now requires changes to proceed. I don't know why, but i already have this by default in my Dolphin... (ArchLinux user here, i don't think they add it explicitly as they try to stay as true to upstream as

D11204: Support NTFS hidden files

markg resigned from this revision. markg added a comment. This revision is now accepted and ready to land. In D11204#233997 , @dfaure wrote: > Thanks ! > > Do you have a contributor account for pushing the commit, or do you need someone else

D11204: Support NTFS hidden files

markg added inline comments. INLINE COMMENTS > rominf wrote in file_unix.cpp:546-550 > The logic behind this is that `getxattr` exists only on Linux > (https://www.gnu.org/software/gnulib/manual/html_node/getxattr.html#getxattr) > and `file_unix.cpp` is more Linux-y than `file.cpp`. If you

D11204: Support NTFS hidden files

markg added a comment. Ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11204 To: rominf, #dolphin, #frameworks, markg, dfaure Cc: dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks, #dolphin, michaelh, ngraham

D11204: Support NTFS hidden files

markg added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11204 To: rominf, #dolphin, #frameworks, markg, dfaure Cc: dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks, #dolphin, michaelh, ngraham

D11204: Support NTFS hidden files

markg requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11204 To: rominf, #dolphin, #frameworks, markg Cc: dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks,

D11204: Support NTFS hidden files

markg added a subscriber: dfaure. markg added a comment. @dfaure I've been looking over the file.cpp and file_unix.cpp code a bit and i'm rather surprised that UDS_HIDDEN isn't being set at all here. Which makes me wonder, why is the hidden logic missing and how is it working now? I don't

D11204: Support NTFS hidden files

markg requested changes to this revision. markg added a comment. This revision now requires changes to proceed. -2 in my opinion. KFileItem should know nothing about NTFS. You already have isHidden in there which should handle it. If it doesn't then you might have found a bug.

D10446: Add KLanguageName

markg added a comment. Isn't this better suited for KCoreAddons? On a related note, i did make this bug report for Qt: https://bugreports.qt.io/browse/QTBUG-64942 with regard to ISO 3166 country names. But language names also came up, see this

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

markg added a comment. In D10742#218171 , @dfaure wrote: > Can someone explain to me how switching from pointers to values is making anything faster, or is a first step towards making anything faster? This step in itself can only make things

D10857: Change qSort to std::sort in simplifiedUrlList

markg added a comment. In D10857#216725 , @dfaure wrote: > I cannot confirm that stable_sort is faster, on the contrary. http://www.davidfaure.fr/2018/qsort_performance.cpp updated, says (repeatedly) > "std::sort took: 5003 ms" >

D10857: Change qSort to std::sort in simplifiedUrlList

markg added a comment. In D10857#214867 , @jtamate wrote: > In D10857#214607 , @dfaure wrote: > > > I'm not opposed to the idea, but measuring CPU usage is a rather misleading indicator. What if it

D10857: Change qSort to std::sort in simplifiedUrlList

markg added a comment. +1, also for what @apol said. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10857 To: jtamate, #frameworks, dfaure Cc: markg, apol, michaelh

D10414: Add move semantics support to KIO::UDSEntry.

markg added a comment. I seem to be making a mess of this commit. Sorry for that. https://p.sc2.nl/B13Etcldf with the changes. Regarding arc to push a change back here again, how do you do that for something that is already committed? REPOSITORY R241 KIO REVISION DETAIL

D10702: Always use a job to delete files to avoid freezing process waiting on IO

markg added a comment. In D10702#213845 , @dfaure wrote: > "unlink() in most of the modern filesystems is not affected by the size of the file" doesn't match my experience, I have seen konqueror/dolphin freeze for 10s while deleting a 8GB file

D10702: Always use a job to delete files to avoid freezing process waiting on IO

markg added a comment. In D10702#212753 , @meven wrote: > In D10702#211236 , @markg wrote: > > > While this might give you the expected result, it feels like a workaround. > > > > I'm assuming

D10771: Save some memory allocations by using the right API

markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D10771 To: apol, #frameworks, markg Cc: markg, michaelh

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

markg added a comment. I unfortunately have no clue how to answer your questions. INLINE COMMENTS > kcoredirlister.cpp:825-829 > +// If take remove the element from the list. > +if (take) { > +dirItem->lstItems.erase(it); > +

D10702: Always use a job to delete files to avoid freezing process waiting on IO

markg added a comment. While this might give you the expected result, it feels like a workaround. I'm assuming the fast path is there for a reason and is really substantially faster then going through the job route. If that is the case then the proper fix would be to make that code

D10414: Add move semantics support to KIO::UDSEntry.

markg added a comment. @bcooksley Ah, i see you **just** fixed this by using kiotesthelper.h (which includes kioglobal_p.h). According to Jenkins, all is OK now :) Thank you very much! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10414 To: markg, dfaure Cc:

D10414: Add move semantics support to KIO::UDSEntry.

markg added a comment. In D10414#208515 , @bcooksley wrote: > Looks like QT_LSTAT doesn't exist on Windows - see https://git.reviewboard.kde.org/r/127727/ Would including "kioglobal_p.h" perhaps fix this? #ifndef QT_LSTAT

D10617: Fix "ambiguous shortcut" issue introduced with D10314

markg added a comment. In D10617#208703 , @elvisangelaccio wrote: > In D10617#208513 , @ngraham wrote: > > > The shortcut won't affect other apps since the file dialog its its own context. Even if

D10414: Add move semantics support to KIO::UDSEntry.

markg added a comment. Right, it didn't fix it... https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/195/console Could someone with a windows setup (compiler and kio) compile kio and tell me what is wrong here? REPOSITORY R241 KIO REVISION DETAIL

D10414: Add move semantics support to KIO::UDSEntry.

markg added a comment. Right, this one is my fault: https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/193/ Weird that QT_LSTAT is no problem on linux without including qplatformdefs.h, on windows it apparently is. I pushed the fix:

D10414: Add move semantics support to KIO::UDSEntry.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:d8414425acc5: Add move semantics support to KIO::UDSEntry. (authored by markg). REPOSITORY R241 KIO CHANGES SINCE

D10414: Add move semantics support to KIO::UDSEntry.

markg marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10414 To: markg, dfaure Cc: apol, #frameworks, michaelh

D10414: Add move semantics support to KIO::UDSEntry.

markg updated this revision to Diff 27431. markg added a comment. Add @since lines where for the move assignment operator and constructor. Typo fix. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10414?vs=27028=27431 BRANCH udsentry_move REVISION DETAIL

D10616: Add Ctrl+H to the list of shortcuts for "show/hide hidden files"

markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Fine by me. I do wonder why it used to be in an if statement though. It would have added a nullptr if the "if (showHidden)" check failed (which would fail when it's a nullptr). REPOSITORY

D10617: Fix "ambiguous shortcut" issue introduced with D10314

markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R241 KIO BRANCH solve-file-dialog-ambiguous-shortcut-issue (branched from master) REVISION DETAIL https://phabricator.kde.org/D10617 To: ngraham,

D10380: Refactor KCoreDirLister(Cache) to use KFileItemListV2 where possible.

markg abandoned this revision. markg added a comment. As this is a no-go, rightfully so! Abandoning it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10380 To: markg, dfaure Cc: #frameworks, michaelh

D10378: Deprecate KFileItemList and introduce KFileItemListV2

markg added a comment. @dfaure What's your preference here? I do "want" to work on this, no promises though. It could take a very long while ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10378 To: markg, dfaure Cc: #frameworks, michaelh

D10414: Add move semantics support to KIO::UDSEntry.

markg added a comment. Ahh, will fix that when i get home. I missed the @since lines in KFileITem as well. Is it OK if i just add them outside of phabricator? They will get an "@since 5.43" i think. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10414 To: markg,

D10414: Add move semantics support to KIO::UDSEntry.

markg marked 2 inline comments as done. markg added a comment. I'm not afraid of the compiler generating wrong code. That is the least of my worries :) What i am afraid of (which is why i suggested the copy test) is a wrong optimization at some point (like adding a pointer member but

D10414: Add move semantics support to KIO::UDSEntry.

markg updated this revision to Diff 27028. markg added a comment. Fix a typo and replace QCOMPARE with QVERIFY for the file open check. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10414?vs=26868=27028 BRANCH udsentry_reductions REVISION DETAIL

D10437: Limit the use of file.so for privilege operation to one application

markg added a comment. In D10437#204416 , @chinmoyr wrote: > In D10437#204402 , @markg wrote: > > > I just tried this: > > kdesu gwenview (type root password and go to the root homefolder). > >

D10437: Limit the use of file.so for privilege operation to one application

markg added a comment. I just tried this: kdesu gwenview (type root password and go to the root homefolder). In gwenview i can now go to that folder. In dolphin (started as user, not root) i can't get into that folder. I don't really see what you try to fix here as it seems to be

D10414: Add move semantics support to KIO::UDSEntry.

markg added a comment. @dfaure i can make the test much more complete if you want.. But it's more complex thus i left it out. I can store the UDSEntry in a QDataStream which would be backed by a QByteArray. That can be hashed! Then i can do the same after moving operations and compare

D10414: Add move semantics support to KIO::UDSEntry.

markg marked 7 inline comments as done. markg added a comment. Seems my unittest skills have become a bit rusty over the years of basically not contributing patches to KDE ;) Thank you for the comments, David! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10414 To:

D10414: Add move semantics support to KIO::UDSEntry.

markg updated this revision to Diff 26868. markg added a comment. Update test. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10414?vs=26839=26868 BRANCH udsentry_reductions REVISION DETAIL https://phabricator.kde.org/D10414 AFFECTED FILES

D10414: Add move semantics support to KIO::UDSEntry.

markg marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10414 To: markg, dfaure Cc: apol, #frameworks, michaelh, ngraham

D10414: Add move semantics support to KIO::UDSEntry.

markg updated this revision to Diff 26839. markg added a comment. Remove comment about compiler generated functions. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10414?vs=26838=26839 BRANCH udsentry_move REVISION DETAIL

D10414: Add move semantics support to KIO::UDSEntry.

markg added a comment. Just a note. The fact that currently no code is structured in a way that move semantics are used is... slightly annoying ;) No as in not when running dolphin with it and profiling it to see UDSEntry uses. There "might" be code that uses move semantics when this

D10414: Add move semantics support to KIO::UDSEntry.

markg updated this revision to Diff 26838. markg added a comment. Fix indentation. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10414?vs=26836=26838 BRANCH udsentry_move REVISION DETAIL https://phabricator.kde.org/D10414 AFFECTED FILES

D10414: Add move semantics support to KIO::UDSEntry.

markg created this revision. markg added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. markg requested review of this revision. REVISION SUMMARY Adds move semantics support and a testcase (only useful in

D10378: Deprecate KFileItemList and introduce KFileItemListV2

markg added a comment. Based on the comment you made in https://phabricator.kde.org/D10380 it's logical that this commit won't make it as it currently is implemented. The using line is probably also not the best option if you want to keep the convenience functions, inheriting would be

D10341: Allow move semantics to be generated for KFileItem. The existing copy constructor, destructor and copy assignment operator are now also generated by the compiler.

This revision was automatically updated to reflect the committed changes. Closed by commit R241:80ccfabb06ff: Allow move semantics to be generated for KFileItem. The existing copy… (authored by markg). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D10341: Allow move semantics to be generated for KFileItem. The existing copy constructor, destructor and copy assignment operator are now also generated by the compiler.

n issue with that... I don't quite remember what it was. Let me try again... (to be continued) - continued -- It doesn't compile... I don't know why or how to fix it, you might :) This is the message: In file included from /usr/include/qt/QtCore/QSharedData:1:0,

D10380: Refactor KCoreDirLister(Cache) to use KFileItemListV2 where possible.

markg updated this revision to Diff 26739. markg added a comment. Get rid of the temp file. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10380?vs=26738=26739 BRANCH refactor_dirlistercache REVISION DETAIL https://phabricator.kde.org/D10380 AFFECTED

D10380: Refactor KCoreDirLister(Cache) to use KFileItemListV2 where possible.

markg created this revision. markg added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. markg requested review of this revision. REVISION SUMMARY This refactors KFileItemList uses to KFileItemListV2 where possible.

D10378: Deprecate KFileItemList and introduce KFileItemListV2

markg created this revision. markg added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. markg requested review of this revision. REVISION SUMMARY Summary Deprecate KFileItemList. It's using QList and lacks move

D10341: Allow move semantics to be generated for KFileItem. The existing copy constructor, destructor and copy assignment operator are now also generated by the compiler.

markg added a comment. In https://phabricator.kde.org/D10341#202704, @dfaure wrote: > I like the idea of enabling moves for KFileItem very much. > > But here's a fun fact: your unittest passes even without the rest of the patch. > > PASS : KFileItemTest::testMove() > >

Re: Possible regression in kio with data loss

On Tue, Feb 6, 2018 at 4:17 PM, Jaime wrote: > Hi all, this is becoming urgent if next release is this weekend. > It still happens to me (with kio just compiled from master) > If it is then add the KIO master (aka, David Faure) in cc :) As i just did. > > > 2018-02-05 8:18

D10341: Allow move semantics to be generated for KFileItem. The existing copy constructor, destructor and copy assignment operator are now also generated by the compiler.

markg created this revision. markg added reviewers: dfaure, mwolff. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. markg requested review of this revision. REVISION SUMMARY This allows the compiler to generate: - Move constructor

D10325: [KFileWidget] Hide places frame and header

markg added a comment. In https://phabricator.kde.org/D10325#201884, @broulik wrote: > > Would it be possible to show it as if it were locked? That would solve all the issues with it, right? > > I don't get it. That "lock" feature is entirely a Dolphin invention. It does exactly

  1   2   3   4   >