[Linuxwacom-devel] [PATCH 1/2 v3] Support pen and MT on the same logical port

2011-03-21 Thread Ping Cheng
post MT valuators while pen events are posted. Some code refactoring is needed to add a new channel to store the pen data as well as the 2FGT data. Defering the code refactoring until we support XInput 2.1. Signed-off-by: Ping Cheng pingli...@gmail.com Reviewed-by: Peter Hutterer peter.hutte

Re: [Linuxwacom-devel] [PATCH] test: drop glib dependency

2011-03-21 Thread Ping Cheng
Thank you for the patch. Acked-by: Ping Cheng pingli...@gmail.com Ping On Mon, Mar 21, 2011 at 7:02 PM, Peter Hutterer peter.hutte...@who-t.netwrote: We weren't really using any of the glib-specific stuff anyway, so just replace g_assert with normal assert and drop the dependency. Signed

Re: [Linuxwacom-devel] [PATCH 1/2 v2] Support pen and MT on the same logical port

2011-03-19 Thread Ping Cheng
On Fri, Mar 18, 2011 at 4:37 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Fri, Mar 18, 2011 at 5:04 PM, Ping Cheng pingli...@gmail.com wrote: Serial ISDv4 kernel driver, wacom_w8001.ko, provides both pen and touch events on the same logical port. Filtering touch events when pen

Re: [Linuxwacom-devel] [PATCH] Input: wacom - rework graphire pad buttons logic

2011-03-19 Thread Ping Cheng
On Fri, Mar 18, 2011 at 6:07 PM, Chris Bagwell ch...@cnpbagwell.com wrote: You suggested we stay with BTN_# for pad, right? So, if we do not move PAD buttons to BTN_LEFT/RIGHT. No issues here either. Because Bamboo's are using BTN_LEFT/RIGHT on bad, all generic's are routing those

Re: [Linuxwacom-devel] [PATCH 2/2 v2] Enable left click for MT touchscreen

2011-03-19 Thread Ping Cheng
some time for the unified solution. but wanted to get your opinion. Yes, I like it very much. Thank you. Ping On Fri, Mar 18, 2011 at 5:04 PM, Ping Cheng pingli...@gmail.com wrote: Tools that are in absolute mode emit left click when the tool touches the surface. However, tools

Re: [Linuxwacom-devel] [PATCH] Input: wacom - rework graphire pad buttons logic

2011-03-19 Thread Ping Cheng
On Sat, Mar 19, 2011 at 5:14 PM, Chris Bagwell ch...@cnpbagwell.com wrote: As long as we keep it protocol 4, I think all that is really needed is to BTN_TOOL_FINGER and MSC_SERIAL to set to zero when out-of-proximity. I think a forced sync in between tool types will be required as well. So

[Linuxwacom-devel] [PATCH 2/2 v2] Enable left click for MT touchscreen

2011-03-18 Thread Ping Cheng
tools. Tools on touchscreen is in absolute mode. So, send left click down/up when the first finger touches/leaves the tablet. Signed-off-by: Ping Cheng pingli...@gmail.com Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- v2 changes: Updated macro MOD_BUTTONS and commit comments. Added

[Linuxwacom-devel] [PATCH] Remove one FIXME

2011-03-18 Thread Ping Cheng
to the desktop. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmValidateDevice.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c index 69bb3a3..65fbdf9 100644 --- a/src/wcmValidateDevice.c +++ b/src/wcmValidateDevice.c

Re: [Linuxwacom-devel] [PATCH] Input: wacom - rework graphire pad buttons logic

2011-03-17 Thread Ping Cheng
On Thu, Mar 17, 2011 at 9:41 AM, Chris Bagwell ch...@cnpbagwell.com wrote: finger event never toggled back to zero. Its serial number also never transition to zero. This approach had some issues in user land when switching between stylus and pad buttons and initial event was usually

Re: [Linuxwacom-devel] Set keystrokes by xsetwacom

2011-03-16 Thread Ping Cheng
On Tue, Mar 15, 2011 at 5:23 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Tue, Mar 15, 2011 at 12:42:18PM -0700, Ping Cheng wrote: I am lost in my own backyard ;(. Can we still set a keystroke which has one of these keys: NumLock, PgUp, PgDn, End? Any key that's a valid X

[Linuxwacom-devel] [PATCH 2/3] Ignore MT touch events when pen is in proximity

2011-03-16 Thread Ping Cheng
This patch will need to be updated when XInput 2.1 is ready to process MT events. Signed-off-by: Ping Cheng pinglin...@gmail.com --- src/wcmUSB.c | 62 - 1 files changed, 60 insertions(+), 2 deletions(-) diff --git a/src/wcmUSB.c b/src

[Linuxwacom-devel] Set keystrokes by xsetwacom

2011-03-15 Thread Ping Cheng
I am lost in my own backyard ;(. Can we still set a keystroke which has one of these keys: NumLock, PgUp, PgDn, End? Also, do we plan to display the keys when user issues xsetwacom get when a keystroke is defined? If we want desktop UI to convert the keycodes to its localized language, how do

Re: [Linuxwacom-devel] Graphire's and PAD issues

2011-03-14 Thread Ping Cheng
On Mon, Mar 14, 2011 at 2:08 PM, Chris Bagwell ch...@cnpbagwell.com wrote: Hi all, This is related to thread on linuxwacom-discuss about older Bamboo's PAD not working right with recent xf86-input-wacom's. This device is handled by Graphire driver in kernel. The reason is related to

Re: [Linuxwacom-devel] Graphire's and PAD issues

2011-03-14 Thread Ping Cheng
On Mon, Mar 14, 2011 at 2:54 PM, Ping Cheng pingli...@gmail.com wrote: On Mon, Mar 14, 2011 at 2:08 PM, Chris Bagwell ch...@cnpbagwell.comwrote: I obviously need some help here since I'm flying blind without the problem device. I can make a kernel patch but can't test it. Part

Re: [Linuxwacom-devel] [PATCH] Provide Intuos4 LED ioctl for kernel 2.6.24ff

2011-03-13 Thread Ping Cheng
On Sun, Mar 13, 2011 at 7:48 AM, Eduard Hasenleithner ehase...@gmail.comwrote: f9300ca1356f6b46af27d13f8141b8a5c915e6c6 introduced support of LEDs on Intuos4 on kernels 2.6.24, 2.6.26 and 2.6.27 by means of merging Nicholas Hirsch's Intuos4 OLED Support.

Re: [Linuxwacom-devel] [PATCH] Remove XWACOM_MAX_SAMPLES

2011-03-11 Thread Ping Cheng
Reviewed-by: Ping Cheng pingli...@gmail.com Ping --- include/Xwacom.h|2 -- src/wcmValidateDevice.c |4 ++-- src/wcmXCommand.c |2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/include/Xwacom.h b/include/Xwacom.h index b06e8ff..3ca8573 100644

Re: [Linuxwacom-devel] [PATCH 3/4] Keep an enabled flag in the tool to avoid racy startup.

2011-03-11 Thread Ping Cheng
On Thu, Mar 10, 2011 at 7:45 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Thu, Mar 10, 2011 at 05:51:34PM -0800, Ping Cheng wrote: On Wed, Mar 2, 2011 at 10:06 PM, Peter Hutterer peter.hutte...@who-t.netwrote: There is a small time window where a device may try to send an event

Re: [Linuxwacom-devel] [PATCH 3/7] Document wcmTilt2R (and add a fixme)

2011-03-10 Thread Ping Cheng
; else ds-rotation = -ds-rotation; + + /* FIXME: shouldn't we reset tilt? */ Since tilt is only used as raw value to calculate rotation for I4 mouse, i.e., they are not posted as valuators, resetting them or not does not make a difference. Acked-by: Ping Cheng pingli

Re: [Linuxwacom-devel] [PATCH 3/4] Keep an enabled flag in the tool to avoid racy startup.

2011-03-10 Thread Ping Cheng
On Wed, Mar 2, 2011 at 10:06 PM, Peter Hutterer peter.hutte...@who-t.netwrote: There is a small time window where a device may try to send an event even though it is not fully setup to send events yet, causing a server crash. This window opens when the tool is added to the list of devices in

Re: [Linuxwacom-devel] [PATCH] remove per-device filter function

2011-03-09 Thread Ping Cheng
seems like it would result in jitter. Removed RawFilter() from WacomDevice structure and call wcmFilterCoord() directly from wcmCommon.c. Signed-off-by: Chris Bagwell ch...@cnpbagwell.com Reviewed-by: Ping Cheng pingli...@gmail.com. Thank you Chris. Ping --- Updated an older patch

[Linuxwacom-devel] [PATCH v2] Decide scroll direction according to tablet orientation

2011-03-07 Thread Ping Cheng
From: Andrzej Pronobis a.prono...@gmail.com Signed-off-by: Andrzej Pronobis a.prono...@gmail.com Signed-off-by: Ping Cheng pingli...@gmail.com --- v2: Refomat a few lines --- src/wcmTouchFilter.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src

Re: [Linuxwacom-devel] Intuos4 L on Ubuntu 10.04

2011-03-06 Thread Ping Cheng
On Mon, Mar 7, 2011 at 6:27 AM, Eduard Hasenleithner ehase...@gmail.comwrote: 2011/3/6 Ping Cheng pingli...@gmail.com: Just as a note: I compiled xf86-input-wacom-0.10.8 which is the last release before commit 19c24dc4e852bae384f16411d5f59add487be5f0 and it appears to work correctly

Re: [Linuxwacom-devel] [PATCH] Decide scroll direction according to tablet orientation

2011-03-06 Thread Ping Cheng
On Mon, Mar 7, 2011 at 7:57 AM, Peter Hutterer peter.hutte...@who-t.netwrote: On Fri, Mar 04, 2011 at 12:39:52PM -0800, Ping Cheng wrote: From: Andrzej Pronobis a.prono...@gmail.com Signed-off-by: Ping Cheng pingli...@gmail.com --- Hi Andrzej, I changed your original patch a little

Re: [Linuxwacom-devel] [PATCH 1/5] xsetwacom: print error if an unknown keyword is given.

2011-03-06 Thread Ping Cheng
https://sourceforge.net/tracker/?func=detailatid=525124aid=3054502group_id=69596 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Ping Cheng pingli...@gmail.com for the whole series. Thank you. Ping --- tools/xsetwacom.c |6 ++ 1 files changed, 6 insertions(+), 0

Re: [Linuxwacom-devel] [PATCH 05/11] Rewrite wcmCheckSuppress

2011-03-05 Thread Ping Cheng
On Thu, Mar 3, 2011 at 10:17 PM, Ping Cheng pingli...@gmail.com wrote: On Thu, Mar 3, 2011 at 6:35 PM, Peter Hutterer peter.hutte...@who-t.net wrote: there's still a valid reason for having suppress Another solution about suppress is to move it to the kernel driver as what Bamboo

[Linuxwacom-devel] [PATCH] conf: Add Fujitsu ISDV4 device ID FUJ02e9 to matches

2011-03-04 Thread Ping Cheng
From: David Foley favux...@gmail.com Signed-off-by: David Foley favux...@gmail.com Reviewed-by: Ping Cheng pingli...@gmail.com --- conf/50-wacom.conf |2 +- conf/wacom.fdi |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/conf/50-wacom.conf b/conf/50-wacom.conf

[Linuxwacom-devel] [PATCH] Decide scroll direction according to tablet orientation

2011-03-04 Thread Ping Cheng
From: Andrzej Pronobis a.prono...@gmail.com Signed-off-by: Ping Cheng pingli...@gmail.com --- Hi Andrzej, I changed your original patch a little and made it into git patch format. If you agree with my changes, please reply to this email with: Signed-off-by: Andrzej Pronobis a.prono...@gmail.com

Re: [Linuxwacom-devel] [PATCH 3/4] Keep an enabled flag in the tool to avoid racy startup.

2011-03-03 Thread Ping Cheng
On Thu, Mar 3, 2011 at 2:35 AM, Peter Hutterer peter.hutte...@who-t.netwrote: On 3/03/11 17:07 , Ping Cheng wrote: On Wed, Mar 2, 2011 at 10:06 PM, Peter Hutterer peter.hutte...@who-t.net mailto:peter.hutte...@who-t.net wrote: There is a small time window where a device may try to send

Re: [Linuxwacom-devel] [PATCH 02/11] Document findTool()

2011-03-03 Thread Ping Cheng
Shouldn't we merge 8/11 to this one? Ping On Thu, Mar 3, 2011 at 4:56 PM, Peter Hutterer peter.hutte...@who-t.netwrote: And rename tooldef to tooldefault, I always get confused by that. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmCommon.c | 16 1

Re: [Linuxwacom-devel] [PATCH 05/11] Rewrite wcmCheckSuppress

2011-03-03 Thread Ping Cheng
On Thu, Mar 3, 2011 at 6:35 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Thu, Mar 03, 2011 at 06:06:01PM -0800, Ping Cheng wrote: On Thu, Mar 3, 2011 at 4:56 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Instead of returning rather ambiguous 0, 1 and 2, return enums

Re: [Linuxwacom-devel] Patches for supporting Wacom Bamboo Fun CTH-661SE-NL

2011-03-02 Thread Ping Cheng
On Sun, Feb 27, 2011 at 12:16 PM, Pander pan...@users.sourceforge.netwrote: Hi all, Here are some patches for supporting Wacom Bamboo Fun CTH-661SE-NL. These are created on a system with Ubuntu 10.10 Maverick. The USB ID has been added to the USB ID Repository at

Re: [Linuxwacom-devel] Small patch to improve comment

2011-03-02 Thread Ping Cheng
On Tue, Mar 1, 2011 at 2:32 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Tue, Mar 01, 2011 at 09:58:40AM +0100, Pander wrote: Hi all, Small patch to improve comment in src/wcmUSB.c line 200 CTH-661 - Bamboo Fun CTH-661SE-NL See attachment. Can someone take this patch under

Re: [Linuxwacom-devel] Sample xsetwacom scripts vetting

2011-03-02 Thread Ping Cheng
On Tue, Mar 1, 2011 at 5:42 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Tue, Mar 01, 2011 at 07:35:02PM -0600, Favux ... wrote: Alright, looks good. I think I like the new tip appearance. Intriguing anyway. If we do a separate Bamboo page do we pull the examples along and put

Re: [Linuxwacom-devel] [PATCH] Move VCOPY storage out of the function.

2011-03-02 Thread Ping Cheng
the routine is returned, the pointer is out of the scope. To return a valid pointer, the array has to be declared outside of VCOPY. You could declare it in the calling routine if you don't like it as a global variable. With that said, Reviewed-by: Ping Cheng pingli...@gmail.com Ping

Re: [Linuxwacom-devel] Heading towards regular releases

2011-03-02 Thread Ping Cheng
On Tue, Mar 1, 2011 at 5:55 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Following up on this, I just bumped the version in git to 0.10.99. New release versioning scheme until we settle on a stable 1.0: - 0.x.99 is the version number in-between releases - 0.x.99.901 is the first RC -

[Linuxwacom-devel] [PATCH 1/2] Don't discard the first 2 USB events

2011-03-02 Thread Ping Cheng
number, etc, are missing. This would require quite some changes in wcmUSB.c. And, the challenge is that linux-input doesn't provide the means for us to retrieve all of the events that posted from the kernel. At least, we can not retrieve serial number and MT events yet. Signed-off-by: Ping Cheng pingli

[Linuxwacom-devel] [PATCH 2/2] Set ISDV4 to PROTOCOL_GENERIC in isdv4ProbeKeys

2011-03-02 Thread Ping Cheng
isdv4ProbeKeys is the place we set all tool types and other keys. Reset the ProtocolLevel to PROTOCOL_GENERIC here as well. Otherwise, it would be overwrote by the default. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmISDV4.c |5 +++-- 1 files changed, 3 insertions(+), 2

Re: [Linuxwacom-devel] Heading towards regular releases

2011-03-02 Thread Ping Cheng
On Wed, Mar 2, 2011 at 4:24 PM, Peter Hutterer peter.hutte...@who-t.netwrote: the problem with that patch was IIRC that it was based on some mistaken assumptions. e.g. the refcounting was working completely different to what you tried to do. so it was more a problem with the patch itself than

Re: [Linuxwacom-devel] Heading towards regular releases

2011-03-02 Thread Ping Cheng
On Wed, Mar 2, 2011 at 5:31 PM, Ping Cheng pingli...@gmail.com wrote: On Wed, Mar 2, 2011 at 4:24 PM, Peter Hutterer peter.hutte...@who-t.netwrote: the problem with that patch was IIRC that it was based on some mistaken assumptions. e.g. the refcounting was working completely different

Re: [Linuxwacom-devel] [PATCH] allow button events while touch is disabled

2011-02-27 Thread Ping Cheng
On Wed, Feb 23, 2011 at 6:49 AM, Chris Bagwell ch...@cnpbagwell.com wrote: On Tue, Feb 22, 2011 at 1:32 PM, Ping Cheng pingli...@gmail.com wrote: On Tue, Feb 22, 2011 at 7:01 AM, Chris Bagwell ch...@cnpbagwell.com wrote: On Mon, Feb 21, 2011 at 9:09 PM, Ping Cheng pingli...@gmail.com

Re: [Linuxwacom-devel] [PATCH] Disable KeepShape - it's currently unsupported.

2011-02-24 Thread Ping Cheng
On Wed, Feb 23, 2011 at 9:30 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Will come back once it's hooked up properly again. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Ping Cheng pingli...@gmail.com Ping --- src/wcmValidateDevice.c |7 +++ 1 files

Re: [Linuxwacom-devel] [PATCH] Update README with a few pointers to website, etc.

2011-02-23 Thread Ping Cheng
On Wed, Feb 23, 2011 at 6:11 AM, Gaetan Nadon mems...@videotron.ca wrote: On Tue, 2011-02-22 at 21:21 -0800, Ping Cheng wrote: It was discussed here in 2009. The conclusion was it depends on which distro the user uses. I didn't understand it well then. But I thought I am not a distro

Re: [Linuxwacom-devel] Sample xsetwacom scripts vetting - off-topic

2011-02-23 Thread Ping Cheng
I removed the contents of this thread on purpose since I am not going to comment on any specific topics. So far, both sides have showed the passion about this project, which is great for the project. Both sides have also showed their strength in dealing with technical issues, which is essential

Re: [Linuxwacom-devel] [PATCH] allow button events while touch is disabled

2011-02-22 Thread Ping Cheng
On Tue, Feb 22, 2011 at 7:01 AM, Chris Bagwell ch...@cnpbagwell.com wrote: On Mon, Feb 21, 2011 at 9:09 PM, Ping Cheng pingli...@gmail.com wrote: On Mon, Feb 21, 2011 at 9:19 AM, ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com PROTOCOL_GENERIC devices send pad

Re: [Linuxwacom-devel] Division by zero in wcmInitArea

2011-02-22 Thread Ping Cheng
Peter, What's your plan for KeepShape? With the removal of Screen concept in the driver, KeepShape can not be supported by the current approach any more. We need to remove KeepShape or to provide a new way for the feature. Ping On Sun, Feb 20, 2011 at 5:21 AM, Bruno Vasselle

Re: [Linuxwacom-devel] [PATCH] Update README with a few pointers to website, etc.

2011-02-22 Thread Ping Cheng
On Tue, Feb 22, 2011 at 9:07 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Tue, Feb 22, 2011 at 08:41:12PM -0600, Chris Bagwell wrote: On Tue, Feb 22, 2011 at 8:29 PM, Gaetan Nadon mems...@videotron.ca wrote: On Wed, 2011-02-23 at 10:00 +1000, Peter Hutterer wrote: +$

Re: [Linuxwacom-devel] [PATCH] Make 1 finger tap work based on finger release.

2011-02-21 Thread Ping Cheng
Hi Andrzej, Looks like you have tested this patch yourself. Can you report back here with your testing result and a Tested-by tag? I am willing to put Acked-by once I see Tested-by. Thank you. Ping On Mon, Feb 21, 2011 at 12:49 PM, ch...@cnpbagwell.com wrote: From: Chris Bagwell

Re: [Linuxwacom-devel] [PATCH] Make 1 finger tap work based on finger release.

2011-02-21 Thread Ping Cheng
, Andrzej. Tested-by: Andrzej Giniewicz ggi...@gmail.com Acked-by: Ping Cheng pingli...@gmail.com Ping tested on kernel 2.6.37.1 with input-wacom 0.10.10_2 and xf86-input-wacom 0.10.11, tapping with single now works. On Mon, Feb 21, 2011 at 12:49 PM, ch...@cnpbagwell.com wrote: From

Re: [Linuxwacom-devel] [PATCH] allow button events while touch is disabled

2011-02-21 Thread Ping Cheng
On Mon, Feb 21, 2011 at 9:19 AM, ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com PROTOCOL_GENERIC devices send pad buttons along with touchscreen/touchpad events. Since we are emulating pad device concept, we need to let pad events go through when touch is disabled.

Re: [Linuxwacom-devel] [PATCH 1/2] Doxygen: use $PACKAGE_VERSION for the release number

2011-02-19 Thread Ping Cheng
...@videotron.ca Reviewed-by: Ping Cheng pingli...@gmail.com for the series. Looks sensible to me. Thanks. Ping --- configure.ac |1 + doc/.gitignore|1 + doc/Makefile.am |4 ++-- doc/{doxygen.conf = doxygen.conf.in

Re: [Linuxwacom-devel] Retiring CVS

2011-02-17 Thread Ping Cheng
On Thu, Feb 17, 2011 at 12:46 PM, Andrzej Giniewicz ggi...@gmail.comwrote: Good news, especially after later sf.net cvs troubles. Does it mean input-wacom is also moving to git, or just linuxwacom for now? Both input-wacom and linuxwacom. Thanks for asking ;). Ping On Thu, Feb 17, 2011

Re: [Linuxwacom-devel] Retiring CVS

2011-02-17 Thread Ping Cheng
On Thu, Feb 17, 2011 at 2:30 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Thu, Feb 17, 2011 at 12:53:18PM -0800, Ping Cheng wrote: On Thu, Feb 17, 2011 at 12:46 PM, Andrzej Giniewicz ggi...@gmail.com wrote: Good news, especially after later sf.net cvs troubles. Does it mean

Re: [Linuxwacom-devel] [PATCH 2/2] Doxygen: add description on the main html page

2011-02-17 Thread Ping Cheng
On Fri, Feb 18, 2011 at 9:30 AM, Gaetan Nadon mems...@videotron.ca wrote: Rather than staring at a blank screen. To be completed. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- include/Xwacom.h |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git

Re: [Linuxwacom-devel] [PATCH] Update release script to deal with SF's shell service

2011-02-16 Thread Ping Cheng
On Wed, Feb 16, 2011 at 5:40 PM, Peter Hutterer peter.hutte...@who-t.netwrote: I get auth. failures if I log in too often. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Ping Cheng pingli...@gmail.com Ping --- release.sh |7 +++ 1 files changed, 7 insertions

Re: [Linuxwacom-devel] [PATCH] Require doxygen.

2011-02-16 Thread Ping Cheng
On Wed, Feb 16, 2011 at 8:57 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Ping Cheng pingli...@gmail.com --- As threatened ;) Not sure what that means to me yet. Ping configure.ac |1 + 1 files changed, 1

Re: [Linuxwacom-devel] Retiring CVS

2011-02-16 Thread Ping Cheng
On Wed, Feb 16, 2011 at 7:05 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Wed, Feb 16, 2011 at 06:18:32PM -0800, Jason Gerecke wrote: After consulting with Ping, the CVS repositories are going to be retired. With SourceForge hinting at a possible end-of-life for CVS service it

Re: [Linuxwacom-devel] Heading towards regular releases

2011-02-16 Thread Ping Cheng
On Wed, Feb 16, 2011 at 7:45 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Looking back at the release history of xf86-input-wacom 0.10.x, we have the following release windows (rough approximations): 0.10.1 - baseline 0.10.2 ~2 weeks 0.10.3 ~3 weeks 0.10.4 ~4 weeks 0.10.5 ~8 weeks

Re: [Linuxwacom-devel] Support for multiple separate pens hotplug in new X driver with wip patch

2011-02-15 Thread Ping Cheng
On Sat, Dec 11, 2010 at 9:59 AM, Alexia Death alexiade...@gmail.com wrote: Hi, Second iteration of my patches. These just concentrate on the driver side config snipplet support. I belive prop system hooks and solutions should be a separate issue in a separate patch after this is done. I

Re: [Linuxwacom-devel] [PATCH] Fix a racing condition that causes hotplugging crash occasionally

2011-02-15 Thread Ping Cheng
On Tue, Feb 15, 2011 at 11:56 AM, Jason Gerecke killert...@gmail.comwrote: On Mon, Feb 14, 2011 at 9:07 PM, Ping Cheng pingli...@gmail.com wrote: On Mon, Feb 14, 2011 at 6:03 PM, Peter Hutterer peter.hutte...@who-t.net quote: init in the config is quite different to init during

Re: [Linuxwacom-devel] [PATCH] Fix a racing condition that causes hotplugging crash occasionally

2011-02-15 Thread Ping Cheng
On Tue, Feb 15, 2011 at 2:03 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Tue, Feb 15, 2011 at 12:54:26PM -0800, Ping Cheng wrote: On Tue, Feb 15, 2011 at 11:56 AM, Jason Gerecke killert...@gmail.com wrote: On Mon, Feb 14, 2011 at 9:07 PM, Ping Cheng pingli...@gmail.com wrote

Re: [Linuxwacom-devel] [PATCH] Remove ABS() macro, just use abs()

2011-02-15 Thread Ping Cheng
On Tue, Feb 15, 2011 at 2:24 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Ping Cheng pingli...@gmail.com Ping --- src/wcmCommon.c | 22 +++--- src/xf86Wacom.h |6 -- 2 files changed, 11

Re: [Linuxwacom-devel] [PATCH 1/3] test: remove _X_RESTRICT_KYWD from definitions

2011-02-15 Thread Ping Cheng
On Tue, Feb 15, 2011 at 2:44 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Undefined in earlier server versions, breaks distcheck. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Ping Cheng pingli...@gmail.com for the series. All these test features will help us reach

Re: [Linuxwacom-devel] [PATCH] Move a read error to DBG to silent hotplugging messages

2011-02-13 Thread Ping Cheng
On Sun, Feb 13, 2011 at 7:53 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Fri, Feb 11, 2011 at 05:07:46PM -0800, Ping Cheng wrote: Error reading wacom device : device not found is displayed in Xorg.0.log 10 times each time a device is unplugged. This is too much for those who

Re: [Linuxwacom-devel] [PATCH] test: fix indentation to be in-line with the rest of the driver

2011-02-13 Thread Ping Cheng
On Sun, Feb 13, 2011 at 9:22 PM, Peter Hutterer peter.hutte...@who-t.netwrote: And add the vim tags so this doesn't happen again. Sorry. You are talking to yourself, aren't you ;). Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Ping Cheng pingli...@gmail.com Ping

Re: [Linuxwacom-devel] [PATCH 1/4] xsetwacom: remove separate modifier list in is_modifier.

2011-02-13 Thread Ping Cheng
On Sun, Feb 13, 2011 at 9:25 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Simply parse through the existing modifier list. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Ping Cheng pingli...@gmail.com Thank you, Ping --- tools/xsetwacom.c | 22

Re: [Linuxwacom-devel] [PATCH 1/3] xsetwacom: hook up to unittests.

2011-02-13 Thread Ping Cheng
On Sun, Feb 13, 2011 at 9:23 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Includes simple test for is_modifier(). Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Ping Cheng pingli...@gmail.com for the series. Thank you, Ping --- tools/Makefile.am | 10

Re: [Linuxwacom-devel] [PATCH] Move a read error to DBG to silent hotplugging messages

2011-02-13 Thread Ping Cheng
On Sun, Feb 13, 2011 at 9:21 PM, Peter Hutterer peter.hutte...@who-t.netwrote: - /* for all other errors, hope that the hotplugging code will - * remove the device */ - if (errno != EAGAIN errno != EINTR) -

[Linuxwacom-devel] [PATCH] Fix a racing condition that causes hotplugging crash occasionally

2011-02-11 Thread Ping Cheng
to cover both static defined (in xorg.conf) and hotplugged/dynamic allocated devices with the code. Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Ping Cheng pingli...@gmail.com --- Peter, I added your if (!pInfo-dev || !pInfo-dev-enabled) check as a safeguard for the crash issue

[Linuxwacom-devel] [PATCH] Move a read error to DBG to silent hotplugging messages

2011-02-11 Thread Ping Cheng
like to see the errno instead of just the strerror. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/xf86Wacom.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/xf86Wacom.c b/src/xf86Wacom.c index 03eb8df..d31c9f3 100644 --- a/src/xf86Wacom.c +++ b/src

Re: [Linuxwacom-devel] [PATCH] Check if the device has been initalised before processing the events.

2011-02-10 Thread Ping Cheng
to the if statement below. Thank you. Ping On Tue, Feb 8, 2011 at 6:00 PM, Ping Cheng pingli...@gmail.com wrote: I have a patch for linuxwacom to deal with this issue. The patch has been under an automated testing for some time and it has survived close to 40k hotpluggings. I'll make a patch

Re: [Linuxwacom-devel] [PATCH] Fix spelling error

2011-02-08 Thread Ping Cheng
On Mon, Feb 7, 2011 at 11:29 PM, Jason Gerecke killert...@gmail.com wrote: s/none /non-/ Signed-off-by: Jason Gerecke killert...@gmail.com Acked-by: Ping Cheng pingli...@gmail.com Thank you, Jason. Ping ---  man/wacom.man     |    2 +-  tools/xsetwacom.c |    2 +-  2 files changed, 2

Re: [Linuxwacom-devel] [PATCH 4/4] Interpret threshold for button click relative to pressure curve.

2011-02-08 Thread Ping Cheng
I have to understand why we need this patch before I can make a comment. I will share what I understood about the Threshold and PressureCurve first. Threshold is the minimal pressure before a button 1 click is posted. PressureCurve is used to soften (increase the pressure) or harden (decrease the

Re: [Linuxwacom-devel] [PATCH] xsetwacom: print warnings for deprecated parameters.

2011-02-07 Thread Ping Cheng
On Mon, Feb 7, 2011 at 7:39 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Ping Cheng pingli...@gmail.com Thank you for being so user friendly :). Ping --- I added ClickForce too, not just the recently changed ones. Ping

Re: [Linuxwacom-devel] [PATCH 00/10] xsetwacom UI changes

2011-02-05 Thread Ping Cheng
On Thu, Feb 3, 2011 at 1:54 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Thu, Feb 03, 2011 at 01:10:21PM -0600, Favux ... wrote: I for one am not excited by the proposed changes.  I just finished updating most of the xsetwacom scripts to be xf86-input-wacom compatible and going

Re: [Linuxwacom-devel] [PATCH 2/2] Prepare for Tablet PC MT format

2011-02-03 Thread Ping Cheng
On Wed, Feb 2, 2011 at 9:05 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Wed, Feb 2, 2011 at 5:54 PM, Ping Cheng pingli...@gmail.com wrote: On Tue, Feb 1, 2011 at 6:44 PM, Chris Bagwell ch...@cnpbagwell.com wrote: Been out of action with a cold.  Trying slowing to get back online. Sorry

Re: [Linuxwacom-devel] [PATCH 00/10] xsetwacom UI changes

2011-02-03 Thread Ping Cheng
On Wed, Feb 2, 2011 at 9:13 PM, Peter Hutterer peter.hutte...@who-t.net wrote: This series will be more controversial than the last 8 but let's see. The patches here change the xsetwacom parameter names into something that's slighly more self-explanatory. Yes, we know what RelWDn means, but

Re: [Linuxwacom-devel] [PATCH 2/2] Prepare for Tablet PC MT format

2011-02-03 Thread Ping Cheng
On Thu, Feb 3, 2011 at 5:31 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Thu, Feb 3, 2011 at 4:55 PM, Ping Cheng pingli...@gmail.com wrote: On Thu, Feb 3, 2011 at 2:09 PM, Chris Bagwell ch...@cnpbagwell.com wrote: What limitation or benefit do we offer to application by not sending

[Linuxwacom-devel] [PATCH v2] Prepare for Tablet PC MT format

2011-02-03 Thread Ping Cheng
to v1: 1. Replace usbGenericTPCQuirks with usbGenericTouchscreenQuirks 2. Remove USB from the second item above as suggested by Chris Bagwell. Signed-off-by: Ping Cheng pingli...@gmail.com Acked-by: Chris Bagwell ch...@cnpbagwell.com --- src/wcmUSB.c | 21 + 1 files changed

[Linuxwacom-devel] [PATCH] Process USB 1FGT data through BTN_TOUCH

2011-02-03 Thread Ping Cheng
Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmUSB.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index 689378a..017e3a0 100644 --- a/src/wcmUSB.c +++ b/src/wcmUSB.c @@ -1025,7 +1025,22 @@ static int

Re: [Linuxwacom-devel] [PATCH 2/2] Prepare for Tablet PC MT format

2011-02-02 Thread Ping Cheng
On Tue, Feb 1, 2011 at 6:44 PM, Chris Bagwell ch...@cnpbagwell.com wrote: Been out of action with a cold.  Trying slowing to get back online. Sorry to hear that. Hope you are getting warmed up here ;). I'll just comment on this patch in series. On Tue, Feb 1, 2011 at 3:36 PM, Ping Cheng

Re: [Linuxwacom-devel] [PATCH 1/8] xsetwacom: use device name instead of dev_name in help output.

2011-02-02 Thread Ping Cheng
On Wed, Feb 2, 2011 at 7:40 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Easier to understand, and also illustrates better that most times the device name needs to be in quotes. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Acked-by: Ping Cheng pingli...@gmail.com for the whole

[Linuxwacom-devel] [PATCH 1/2] Convert ISDV4 resolution to points/m

2011-02-01 Thread Ping Cheng
Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmISDV4.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/wcmISDV4.c b/src/wcmISDV4.c index 7080f5b..54d47ec 100644 --- a/src/wcmISDV4.c +++ b/src/wcmISDV4.c @@ -31,6 +31,10 @@ #define

[Linuxwacom-devel] [PATCH 2/2] Prepare for Tablet PC MT format

2011-02-01 Thread Ping Cheng
. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmUSB.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index 8343032..cc9ff72 100644 --- a/src/wcmUSB.c +++ b/src/wcmUSB.c @@ -1340,6 +1340,25 @@ static void

[Linuxwacom-devel] [PATCH 1/3] Convert ISDV4 resolution to points/m

2011-01-31 Thread Ping Cheng
Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmISDV4.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/wcmISDV4.c b/src/wcmISDV4.c index 7bab7d4..a0c9b3b 100644 --- a/src/wcmISDV4.c +++ b/src/wcmISDV4.c @@ -31,6 +31,10 @@ #define RESET_RELATIVE

[Linuxwacom-devel] [PATCH 3/3] Add a new Fujitsu 1FGT model

2011-01-31 Thread Ping Cheng
Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmISDV4.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/src/wcmISDV4.c b/src/wcmISDV4.c index 9b3beee..13775aa 100644 --- a/src/wcmISDV4.c +++ b/src/wcmISDV4.c @@ -1,6 +1,6 @@ /* * Copyright 1995-2002

Re: [Linuxwacom-devel] [PATCH] Define default resolutions in xf86WacomDefs.h

2011-01-30 Thread Ping Cheng
On Sun, Jan 30, 2011 at 3:06 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Fri, Jan 28, 2011 at 10:49:04AM -0800, Ping Cheng wrote: On Thu, Jan 27, 2011 at 8:57 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Jan 26, 2011 at 10:20:39AM -0800, Ping Cheng wrote: This change

Re: [Linuxwacom-devel] [PATCH] Define default resolutions in xf86WacomDefs.h

2011-01-28 Thread Ping Cheng
On Thu, Jan 27, 2011 at 8:57 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Jan 26, 2011 at 10:20:39AM -0800, Ping Cheng wrote: This change makes some of the lines in WacomModelDesc a bit too long. Since we plan to move the table to the kernel driver soon, I updated the table

Re: [Linuxwacom-devel] [PATCH] Convert ISDV4 resolution to points/m

2011-01-26 Thread Ping Cheng
On Tue, Jan 25, 2011 at 9:54 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Tue, Jan 25, 2011 at 09:26:50PM -0800, Ping Cheng wrote: Signed-off-by: Ping Cheng pingli...@gmail.com ---  src/wcmISDV4.c |   10 +-  1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src

[Linuxwacom-devel] [PATCH] Define default resolutions in xf86WacomDefs.h

2011-01-26 Thread Ping Cheng
to the kernel, the defines can be moved to wcmISDV4.c. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmISDV4.c |6 +- src/wcmUSB.c| 242 +- src/xf86WacomDefs.h | 12 +++ 3 files changed, 136 insertions(+), 124 deletions(-) diff

Re: [Linuxwacom-devel] [PATCH] Streamline the touch resolution

2011-01-25 Thread Ping Cheng
On Tue, Jan 25, 2011 at 6:15 AM, Chris Bagwell ch...@cnpbagwell.com wrote: On Mon, Jan 24, 2011 at 10:43 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, Jan 24, 2011 at 03:07:19PM -0800, Ping Cheng wrote: Resolution uses different units in the kernel (point/mm), XInput (point/m

[Linuxwacom-devel] [PATCH] Streamline the touch resolution

2011-01-25 Thread Ping Cheng
older than 2.6.30, resolution is not part of absinfo. For kernels older than 2.6.35, kernel does not pass resolution to the userland. This patch addresses those issues and correct a conversion bug introduced by the RX/RY workaround. Signed-off-by: Ping Cheng pingli...@gmail.com Reviewed-by: Chris

[Linuxwacom-devel] [PATCH] Convert ISDV4 resolution to points/m

2011-01-25 Thread Ping Cheng
Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmISDV4.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/wcmISDV4.c b/src/wcmISDV4.c index 2c3ca9a..7bab7d4 100644 --- a/src/wcmISDV4.c +++ b/src/wcmISDV4.c @@ -317,10 +317,10 @@ static void

Re: [Linuxwacom-devel] [PATCH 1/2] Fix the touch resolution conversion issue

2011-01-24 Thread Ping Cheng
).  Then it reduces to: resolution in units per meter = logical_size / physical_size I have one more comment below. On Mon, Jan 24, 2011 at 1:39 AM, Ping Cheng pingli...@gmail.com wrote: resolution = logical size / physical size The touch physical size we get from the kernel is in thousandth cm

[Linuxwacom-devel] [PATCH 2/2] Retrieve resolution directly from input_absinfo

2011-01-23 Thread Ping Cheng
Resolution is added to input_absinfo in kernel 2.6.30. Let's Retrieve it directly from there if available. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmUSB.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index

Re: [Linuxwacom-devel] [RFC PATCH 0/5] Wacom testing framework

2011-01-22 Thread Ping Cheng
I agree. Acked-by: Ping Cheng pingli...@gmail.com Ping On Sat, Jan 22, 2011 at 12:58 PM, Chris Bagwell ch...@cnpbagwell.com wrote: I like the idea.  It would be nice to get as far as injecting fake packet and testing resulting movement or button posts. There are a hand full of times I'd

Re: [Linuxwacom-devel] [PATCH 10/11] Remove useless else block.

2011-01-20 Thread Ping Cheng
On Tue, Jan 18, 2011 at 6:09 PM, Chris Bagwell ch...@cnpbagwell.com wrote: Same here.  This was the same patch that I dropped related to relative fixes. I did test removing the else statement and it worked fine on my bamboo even with small movements. Yes, it should be since Today factorX/Y

Re: [Linuxwacom-devel] [PATCH] Check MT_TOOL_FINGER for WCM_2FGT -withdraw

2011-01-20 Thread Ping Cheng
On Wed, Jan 19, 2011 at 12:46 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Wed, Jan 19, 2011 at 12:41 PM, Ping Cheng pingli...@gmail.com wrote: On Tue, Jan 18, 2011 at 6:19 PM, Chris Bagwell ch...@cnpbagwell.com wrote: Is there driver your interested in?  Its difficult to talk in abstract

Re: [Linuxwacom-devel] [PATCH] Check MT_TOOL_FINGER for WCM_2FGT -withdraw

2011-01-20 Thread Ping Cheng
On Thu, Jan 20, 2011 at 11:31 AM, Chris Bagwell ch...@cnpbagwell.com wrote: Lets try to solve the ABSOLUTE mode problem and then I think it helps solves 1FGT as well.  In wcmDeviceTypeKeys(), I was thinking we should add something like this: /* Detect older convention for touchscreen inputs

Re: [Linuxwacom-devel] [PATCH] Check MT_TOOL_FINGER for WCM_2FGT -withdraw

2011-01-19 Thread Ping Cheng
On Tue, Jan 18, 2011 at 6:19 PM, Chris Bagwell ch...@cnpbagwell.com wrote: Is there driver your interested in?  Its difficult to talk in abstract. I'm moving the existing _TAP_ based USB TPC to _MT_ based format. That's why I don't want to reuse _TAP_ again. OK. Thanks.  That clears up some

Re: [Linuxwacom-devel] [PATCH] Check MT_TOOL_FINGER for WCM_2FGT -withdraw

2011-01-19 Thread Ping Cheng
On Wed, Jan 19, 2011 at 12:46 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Wed, Jan 19, 2011 at 12:41 PM, Ping Cheng pingli...@gmail.com wrote: On Tue, Jan 18, 2011 at 6:19 PM, Chris Bagwell ch...@cnpbagwell.com wrote: Is there driver your interested in?  Its difficult to talk in abstract

<    1   2   3   4   5   6   7   8   >