> On April 29, 2017, 11:01 vorm., Dennis Nienhüser wrote:
> > Sounds promising! We have switched to Phabricator for Code Review some time
> > ago. Can you please file the same review request at
> > https://phabricator.kde.org/differential/? Thanks!
Plea
tested compilation.
Thanks,
Dennis Nienhüser
> On Feb. 4, 2017, 11:30 vorm., Albert Astals Cid wrote:
> > Seems this patch was not commited and does not apply anymore.
>
> Marius Stanciu wrote:
> If this is something we still need, I can surely update it!
>
> Albert Astals Cid wrote:
> marblers?
Yes, this is still useful. Would
download at [2]. I plan to release it soon unless crash reports or
similar serious issues are reported.
Regards,
Dennis
[1] https://play.google.com/apps/testing/org.kde.marble.maps
[2]
http://files.kde.org/marble/downloads/android/MarbleMaps-1.1.0_24.apk
Am 04.02.2017 14:39, schrieb Dennis Nienhüser
Hi there,
I'm currently preparing another release of Marble Maps for Android. The
current version was released on December 11th, 2016. Changes since then
include
- public transport routes can be highlighted (use the toggle in the new
side panel)
- many more features shown in the map, among
eos (~tsdgeos@kde/aacid) hat #marble verlassen ("Konversation
terminated!")
marble (master) Android/v1.0.0-20-193-g48d990bbd * Dennis
Nienhüser: src/lib/marble/declarative/Placemark.cpp
l10n fun
https://commits.kde.org/marble/48d990bbdb16b1a9ca1b9bc5d15293cd2c864b11
Am 27.12.2016
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129690/#review101553
---
Ship it!
Looks good to me.
- Dennis Nienhüser
On Dec
edia/uploaded/files/2015/08/15/52f287fa-481d-4013-b8a8-962eea0a2e7f__marble-budapest-hu.png
German locale rendering
https://git.reviewboard.kde.org/media/uploaded/files/2015/08/15/23d5ea78-dc3c-48fb-9410-833e7a8c4fca__marble-budapest-de.png
Thanks,
Dennis Nienhüser
) or Torsten
(tackat) in #marble in Freenode for details. Thanks for your patience
:-)
Regards,
Dennis
[1] https://phabricator.kde.org/project/view/38/
Am 26.09.2016 22:36, schrieb Dennis Nienhüser:
Hi all,
we made some good progress with vector tiles in the last weeks/months:
- tile levels 0-9
Hi all,
we made some good progress with vector tiles in the last weeks/months:
- tile levels 0-9 are basically done now from natural earth data and
Marble tools.
- the remaining tile levels 11-17 can be created with Marble tools now
as well. We need some development still to be able to deal
Hi Farzad,
right now we only use the MBTiles format on the server side. I created a
task [0] earlier today to add support for MBTiles as local storage.
You're probably looking for something slightly different though, a way
to open a .mbtiles file directly and see the images/tiles inside. Is
nienhueser created this revision.
nienhueser added reviewers: Marble, rahn.
nienhueser set the repository for this revision to rMARBLE Marble.
REVISION SUMMARY
This is a quick hack (not meant to be committed) to give a first impression
of how a Sentinel 2 satellite background would look like
nienhueser created this revision.
nienhueser added reviewers: Marble, rahn.
nienhueser set the repository for this revision to rMARBLE Marble.
nienhueser added a project: Marble.
REVISION SUMMARY
The Vector OSM map theme has some rendering order problems right now that
result in some item
Hi,
your Qt installation lacks some header files. This often happens with
distribution packages which split Qt into several packages, e.g. Debian
or Ubuntu. To fix it install the missing ones (sth like
qtdeclarative5-dev, qtscript5-dev, libqt5svg5-dev).
Regards,
Dennis
Am 29.01.2016 19:27,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125377/#review88912
---
Ship it!
Ship It!
- Dennis Nienhüser
On Nov. 23, 2015, 12
Hi Torsten,
commit 5b989a8 fails in ViewportParamsTest and therefore we have Jenkins
complain about broken tests for more than four weeks on each single
commit. The effect is that people ignore Jenkins mails, which hides
other potential issues. I see these options:
- (1) revert commit
is just a placeholder, not intended to be committed).
Diffs
-
readme.txt PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/126065/diff/
Testing
---
Thanks,
Dennis Nienhüser
___
Marble-devel mailing list
Marble-devel@kde.org
https
nienhueser created this revision.
nienhueser added a reviewer: Marble.
nienhueser added a subscriber: Marble.
nienhueser set the repository for this revision to rMARBLE Marble.
nienhueser added a project: Marble.
REVISION SUMMARY
Please use https://phabricator.kde.org/ for any new review
to me.
- Dennis Nienhüser
On Nov. 2, 2015, 5:28 nachm., Imran Tatriev wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125880/#review87770
---
Ship it!
Ship It!
- Dennis Nienhüser
On Oct. 30, 2015, 11
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125572/#review87539
---
Ship it!
Ship It!
- Dennis Nienhüser
On Oct. 9, 2015, 7
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125807/#review87540
---
Ship it!
Ship It!
- Dennis Nienhüser
On Oct. 26, 2015
/runner/osm/OsmRelation.cpp (line 117)
<https://git.reviewboard.kde.org/r/125740/#comment59948>
Can you comment that one? I expect quite some debug spam from it.
- Dennis Nienhüser
On Oct. 21, 2015, 5:57 p.m., Mihail Ivchenko
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124807/#review85778
---
Ship it!
Ship It!
- Dennis Nienhüser
On Sept. 21, 2015, 7
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125011/#review85660
---
Ship it!
Ship It!
- Dennis Nienhüser
On Sept. 16, 2015
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125299/#review85661
---
Ship it!
Ship It!
- Dennis Nienhüser
On Sept. 18, 2015, 2
NDROID_TOOLCHAIN@",
+ "tool-prefix": "@ANDROID_TOOLCHAIN@",
+ "toolchain-version": "@ANDROID_GCC_VERSION@",
+ "ndk-host": "@_HOST@",
"target-architecture": "@ANDROID_ABI@",
"application-binary": "@QT_ANDROID_
.)
>
>
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
>
>
> Bugs: 344364
> http://bugs.kde.org/show_bug.cgi?id=344364
>
>
> Repository: marble
>
>
> Description
> ---
>
> Allow changing angle unit with right click on st
Hi there,
Marble Maps is optimized for touch interfaces. Currently Android, but
Plasma Mobile might follow. It's useful on the Desktop mostly for
developers to verify compilation outside Android and to test things
without deploying to a mobile device. It doesn't add any value to
Desktop
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124669/#review84562
---
Ship it!
Ship It!
- Dennis Nienhüser
On Aug. 9, 2015, 9
rendering speed.
I would rather extend drawLabelPixmap to take another argument isSelected and
then cache two pixmaps, one for the selected case and one for the not selected.
Then return the right one based on the value of m_selected.
- Dennis Nienhüser
On Aug. 30, 2015, 12:02 vorm., Constantin
wrong.
- Dennis Nienhüser
On Aug. 25, 2015, 4:53 p.m., Gábor Péterffy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124808
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124781/#review84381
---
Ship it!
Ship It!
- Dennis Nienhüser
On Aug. 25, 2015, 9
.
- Dennis Nienhüser
On Aug. 25, 2015, 8:33 p.m., Marius Stanciu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124780
/lib/marble/osm/OsmRelationManagerWidget_p.cpp (line 115)
https://git.reviewboard.kde.org/r/124822/#comment58430
logic reversed, see other review
`Q_ASSERT(m_allRelations);`
- Dennis Nienhüser
On Aug. 25, 2015, 9:10 p.m., Marius Stanciu wrote
on it in master.
- Dennis Nienhüser
On Aug. 21, 2015, 8:47 a.m., Gábor Péterffy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666
on it in master.
- Dennis Nienhüser
On Aug. 20, 2015, 10:08 p.m., Gábor Péterffy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124808
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124820/#review84177
---
Ship it!
Ship It!
- Dennis Nienhüser
On Aug. 19, 2015, 3
for m_osmRelationManagerWidget
- Dennis Nienhüser
On Aug. 19, 2015, 5:07 p.m., Marius Stanciu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124781
://git.reviewboard.kde.org/r/124808/#comment58314
is nullptr valid QML?
src/lib/marble/declarative/MarbleQuickItem.h (line 56)
https://git.reviewboard.kde.org/r/124808/#comment58315
I think direction or heading is a better name
- Dennis Nienhüser
On Aug. 20, 2015, 10:08 p.m., Gábor
On Aug. 3, 2015, 11:22 a.m., Dennis Nienhüser wrote:
src/lib/marble/osm/OsmPlacemarkData.cpp, line 181
https://git.reviewboard.kde.org/r/124570/diff/1/?file=388971#file388971line181
Did you consider moving from the QHash to a QVector (where the keys are
implicitly given as (0
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124570/#review84172
---
Ship it!
Ship It!
- Dennis Nienhüser
On Aug. 16, 2015, 4
://git.reviewboard.kde.org/r/124666/#comment58268
what about calling `root.selected(type)` in each WaypointImage?
src/apps/marble-maps/MainScreen.qml (line 35)
https://git.reviewboard.kde.org/r/124666/#comment58271
startRoutingButton does not exist
- Dennis Nienhüser
On Aug. 21, 2015, 8:47
On Aug. 21, 2015, 5:22 p.m., Dennis Nienhüser wrote:
src/lib/marble/GeoPainter.cpp, line 181
https://git.reviewboard.kde.org/r/124511/diff/6/?file=396498#file396498line181
this normalization seems a bit overcomplicated, what's the intention?
Dávid Kolozsvári wrote
On Aug. 21, 2015, 5:22 p.m., Dennis Nienhüser wrote:
src/lib/marble/GeoPainter.cpp, line 181
https://git.reviewboard.kde.org/r/124511/diff/6/?file=396498#file396498line181
this normalization seems a bit overcomplicated, what's the intention?
Dávid Kolozsvári wrote
projection (usually that's the case when the viewport's projection is not
Mercator) since we won't reach a sharp display there?
Torsten, any opinion on this?
- Dennis Nienhüser
On Aug. 20, 2015, 4:54 a.m., Dávid Kolozsvári wrote
)
https://git.reviewboard.kde.org/r/124808/#comment58246
doesn't look like a slot and is private. So better remove this method and
use d-model() directly.
- Dennis Nienhüser
On Aug. 20, 2015, 11:01 a.m., Gábor Péterffy wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124787/#review83959
---
Ship it!
Ship It!
- Dennis Nienhüser
On Aug. 17, 2015, 1
/
---
(Updated Aug. 16, 2015, 2:12 p.m.)
Review request for Marble, Mihail Ivchenko and Dennis Nienhüser.
Repository: marble
Description
---
- Working back button
- Reworked navigation setup
Diffs
-
data/android/drawable-xxxhdpi/circular_menu_backdrop.png PRE-CREATION
)
https://git.reviewboard.kde.org/r/124775/#comment58113
We might also call it `isNull` which a couple of Qt classes use to
distinguish default constructed instances from other ones.
- Dennis Nienhüser
On Aug. 16, 2015, 3:20 p.m., Marius Stanciu wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124522/#review83892
---
Ship it!
Ship It!
- Dennis Nienhüser
On Aug. 16, 2015, 4
On Aug. 6, 2015, 6:23 p.m., Marius Stanciu wrote:
Can you check the various documentation snippets whether the mx: namespace
is consistently included?
Marius Stanciu wrote:
you mean check marble's documentation ? or make sure KML standards allow
declaring a namespace?
Marius
here. Isn't
this problematic already when `else if ( ( category =
OsmPresetLibrary::OsmVisualCategory( key ) ) )` is called below?
Generally I wonder if passing key and value separately would be better
(feel free to ignore in this review request).
- Dennis Nienhüser
On Aug. 16, 2015
On Aug. 10, 2015, 6:17 p.m., Dennis Nienhüser wrote:
Yes, I like the idea of having interactive waypoint items. Design-wise I
wonder if we get the message across by just using different colors for
markers. Also the circular popup menu looks stylish, but might be annoying
to extend
/2015/08/15/23d5ea78-dc3c-48fb-9410-833e7a8c4fca__marble-budapest-de.png
Thanks,
Dennis Nienhüser
___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel
departure/arrival text
Von meinem iPhone 5s gesendet
Am 15.08.2015 um 13:41 schrieb Dennis Nienhüser
den...@nienhueser.de:
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124666/ [1]
On August 10th, 2015, 6:17 p.m. UTC, DENNIS NIENHÜSER wrote:
Yes
? destination : waypoint)
Rectangle {
color: palette.base
```
- Dennis Nienhüser
On Aug. 15, 2015, 1:30 p.m., Gábor Péterffy wrote:
---
This is an automatically generated e-mail
On Aug. 12, 2015, 1:13 p.m., Dennis Nienhüser wrote:
src/apps/marble-maps/package/src/org/kde/marble/maps/TextToSpeechClient.java,
line 19
https://git.reviewboard.kde.org/r/124703/diff/1/?file=393526#file393526line19
Is this supposed to be a singleton? Then it's not implemented
);
} else {
Log.i(TAG, Text to speech language + m_language + is
not available);
}
}
}
```
fixes that.
- Dennis Nienhüser
On Aug. 13, 2015, 8:48 p.m., Gábor Péterffy wrote
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124640/#review83816
---
Ship it!
(or is it shipped already?)
- Dennis Nienhüser
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124627/#review83764
---
Ship it!
Ship It!
- Dennis Nienhüser
On Aug. 13, 2015, 9
On Aug. 12, 2015, 1:13 p.m., Dennis Nienhüser wrote:
src/apps/marble-maps/package/src/org/kde/marble/maps/TextToSpeechClient.java,
line 19
https://git.reviewboard.kde.org/r/124703/diff/1/?file=393526#file393526line19
Is this supposed to be a singleton? Then it's not implemented
On Aug. 13, 2015, 7:10 p.m., Dennis Nienhüser wrote:
src/lib/marble/layers/GeometryLayer.cpp, line 277
https://git.reviewboard.kde.org/r/124511/diff/4/?file=394341#file394341line277
Extending my previous comment wrt using qStableSort instead of qSort: I
wonder if we should really
from O(n log n) due to the sorting to O(n).
- Dennis Nienhüser
On Aug. 13, 2015, 12:19 a.m., Dávid Kolozsvári wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124511
://git.reviewboard.kde.org/r/124703/#comment57952
else print a warning to the shell / some log?
- Dennis Nienhüser
On Aug. 12, 2015, 2:02 vorm., Gábor Péterffy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
in between updates.
src/lib/marble/declarative/Routing.cpp (line 144)
https://git.reviewboard.kde.org/r/124627/#comment57961
This seems wrong (in general, see comments above.)
- Dennis Nienhüser
On Aug. 8, 2015, 9:38 a.m., Gábor Péterffy wrote
On Aug. 10, 2015, 11:25 a.m., Dennis Nienhüser wrote:
src/lib/marble/geodata/graphicsitem/GeoPolygonGraphicsItem.cpp, line 80
https://git.reviewboard.kde.org/r/124511/diff/2/?file=390457#file390457line80
Can you check some zoo mappings in OSM to see if this is a building
usually
their order. In that case replacing
qSort here with qStableSort should solve it.
- Dennis Nienhüser
On Aug. 5, 2015, 7:31 nachm., Dávid Kolozsvári wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Aug. 9, 2015, 8:49 nachm., Dennis Nienhüser wrote:
In https://git.reviewboard.kde.org/r/124154/ I suggested to change the
algorithm to compute the offsets to avoid that they get too large for small
buildings. Looking at the result of that I realized that my suggestion was
a bad
. The patch prevents
modifications if a placemark uses one of the OSM visual categories.
Diffs
-
src/lib/marble/FileLoader.cpp 6245f0f
Diff: https://git.reviewboard.kde.org/r/124673/diff/
Testing
---
Thanks,
Dennis Nienhüser
the current review requests I'd like to discuss bringing the routing elements
closer together in the user interface.
- Dennis Nienhüser
On Aug. 8, 2015, 8:24 p.m., Gábor Péterffy wrote:
---
This is an automatically generated e-mail. To reply
(e.g. while panning the map).
- Dennis Nienhüser
On Aug. 5, 2015, 7:31 p.m., Dávid Kolozsvári wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124511
On Aug. 8, 2015, 5:46 a.m., Dennis Nienhüser wrote:
Thanks, the code looks much nicer now.
Some quick usage questions:
- How do I hide the Modify Route dialog to get back to the map? There is
no menu item or button (shown) for it.
- What about making the current position
using the plugin last time.
src/lib/marble/geodata/data/GeoDataFeature.cpp (line 643)
https://git.reviewboard.kde.org/r/124663/#comment57851
wouldn't this have to set `d-m_style` to `nullptr` here? See remainder of
the method and `GeoDataFeature::style()`
- Dennis Nienhüser
On Aug. 8
marked as submitted.
Review request for Marble.
Changes
---
Submitted with commit aca7cc243c284b5f75b0a048dd32b57b1fb8c538 by Dennis
Nienhüser to branch master.
Repository: marble
Description
---
Prefers passing a file path to instantiate GeoDataIconStyle instead of passing
marked as submitted.
Review request for Marble.
Changes
---
Submitted with commit 4d58ee7b64254146d282b34aa5f5e61898703455 by Dennis
Nienhüser to branch master.
Repository: marble
Description
---
Some minor improvements for the search field:
- add a clear button
- add a busy
also be a one-liner:
`qSwap(d-m_route[index1], d-m_route[index2]);`
- Dennis Nienhüser
On Aug. 7, 2015, 9:35 p.m., Gábor Péterffy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124622/#review83483
---
Ship it!
Looks good to me.
- Dennis Nienhüser
On Aug. 5
to
determine what to do with it.
- Dennis Nienhüser
On Aug. 6, 2015, 7:36 a.m., Gábor Péterffy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124627
an error. There are a couple of
handlers that do that.
Can you check the various documentation snippets whether the mx: namespace is
consistently included?
- Dennis Nienhüser
On July 31, 2015, 5:37 p.m., Marius Stanciu wrote
based apps.
- Dennis Nienhüser
On Aug. 5, 2015, 1:49 p.m., Gábor Péterffy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124622
://git.reviewboard.kde.org/r/124627/#comment57699
This file is missing in the patch, can you add it?
- Dennis Nienhüser
On Aug. 5, 2015, 11:57 p.m., Gábor Péterffy wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124609/#review83410
---
Ship it!
Ship It!
- Dennis Nienhüser
On Aug. 4, 2015, 6
marked as submitted.
Review request for Marble.
Changes
---
Submitted with commit 520558da3f0b48ac77c6f95851e509d5ab05f681 by Dennis
Nienhüser to branch master.
Repository: marble
Description
---
Qt's plugin loading mechanism is unable to load plugins from the assets virtual
file
On Aug. 3, 2015, 5:11 p.m., Dennis Nienhüser wrote:
The patch does not apply, it contains some changes that are already in
master. How did you generate it? One way how this could happen is when you
work on a branch, update it with the latest changes from master, and then
create
it on the device :-)
- Dennis Nienhüser
On Aug. 3, 2015, 6:23 p.m., Gábor Péterffy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124519
origin/master` instead.
- Dennis Nienhüser
On Aug. 3, 2015, 4:07 p.m., Gábor Péterffy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124519
marked as submitted.
Review request for Marble.
Changes
---
Submitted with commit 3e0ca75f78b0b46326b88afd1e3960f93d056274 by Dennis
Nienhüser to branch master.
Repository: marble
Description
---
At the moment GPS stays turned on when switching to a different app on Android
://git.reviewboard.kde.org/r/124519/#comment57584
Bounding boxes aren't the only thing we can center on. Just use
`d-centerOn(coordinates);` as a replacement for the four lines here.
- Dennis Nienhüser
On Aug. 2, 2015, 3:36 p.m., Gábor Péterffy wrote
and some plugins).
Thanks,
Dennis Nienhüser
___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124541/#review83302
---
Ship it!
Ship It!
- Dennis Nienhüser
On Aug. 1, 2015, 3
accordingly.
Diffs
-
src/lib/marble/declarative/MarbleQuickItem.h cca3297
src/lib/marble/declarative/MarbleQuickItem.cpp 9dac123
Diff: https://git.reviewboard.kde.org/r/124583/diff/
Testing
---
Switching between Marble Maps, homescreen and other apps on a Nexus 4.
Thanks,
Dennis
is in the background. This will drain the battery,
and we need to be able to operate in several modes: During tracking or
turn-by-turn navigation GPS needs to stay on, but for regular map browsing etc
it should go off once Marble gets suspended.
- Dennis Nienhüser
On July 31, 2015, 11:23 p.m
On July 29, 2015, 7:31 a.m., Dennis Nienhüser wrote:
src/lib/marble/MarbleQuickItem.cpp, line 347
https://git.reviewboard.kde.org/r/124519/diff/1/?file=388506#file388506line347
can't we use `!coordinates.isValid()` here?
Gábor Péterffy wrote:
The coordinate is valid
to sanitize placemark icon
path handling inside Marble (wrt location and sizes). Let's deal with that
outside of this review request.
http://nienhueser.de/marble/android-search-resultlist.png
- Dennis Nienhüser
On July 31, 2015, 12:12 p.m., Gábor Péterffy wrote:
It also works for me too. I like how fast is it on slow connection too.
I would like to suggest as background color the palette.window, because in
this case it is in harmony with the search field, this is my favourite
version from
d027af9
src/apps/marble-maps/Search.qml 896f266
src/lib/marble/declarative/SearchBackend.h b041de3
src/lib/marble/declarative/SearchBackend.cpp 5c80cc3
Diff: https://git.reviewboard.kde.org/r/124550/diff/
Testing
---
Tested on the Nexus 4 and Desktop
Thanks,
Dennis Nienhüser
/r/124553/#comment57482
I'd move the increment to its own line again
src/plugins/runner/osm/writers/OsmRelationTagWriter.cpp (line 42)
https://git.reviewboard.kde.org/r/124553/#comment57483
++index (prefer prefix increment)
- Dennis Nienhüser
On July 31, 2015, 3:14 p.m., Marius
,
Dennis Nienhüser
___
Marble-devel mailing list
Marble-devel@kde.org
https://mail.kde.org/mailman/listinfo/marble-devel
/#comment57464
const QVariant
- Dennis Nienhüser
On July 31, 2015, 7:25 a.m., Mihail Ivchenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124541
1 - 100 of 281 matches
Mail list logo
