D2133: py3: replace file() with open() in test-convert-git.t

2018-02-12 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > yuja wrote in test-convert-git.t:423 > We'll need b"' and make `chr()` return bytes. To make chr() return bytes, I did chr().encode('latin-1') but there is `UnicodeDecodeError: 'ascii' codec can't decode byte 0x80 in position 0: ordinal not in ra

D2131: py3: replace file() with open() in test-encoding-align.t

2018-02-12 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 5480. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2131?vs=5394&id=5480 REVISION DETAIL https://phab.mercurial-scm.org/D2131 AFFECTED FILES tests/test-encoding-align.t

D2132: py3: replace file() with open() in test-convert-hg-source.t

2018-02-12 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 5481. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2132?vs=5395&id=5481 REVISION DETAIL https://phab.mercurial-scm.org/D2132 AFFECTED FILES tests/test-convert-hg-source

D2109: py3: make sure we return str from __repr__

2018-02-12 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 5478. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2109?vs=5372&id=5478 REVISION DETAIL https://phab.mercurial-scm.org/D2109 AFFECTED FILES mercurial/match.py CHANGE DETAILS diff --git a/mercurial/match.py b/me

D2130: py3: replace file() with open() in test-encoding.t

2018-02-12 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 5479. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2130?vs=5393&id=5479 REVISION DETAIL https://phab.mercurial-scm.org/D2130 AFFECTED FILES tests/test-encoding.t CHANG

D1755: logexchange: introduce helper function to get remote path name

2018-02-12 Thread pulkit (Pulkit Goyal)
pulkit added a comment. I will like to get this series review and iterated upon early in cycle so that we can ship remotenames in the next release. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1755 To: pulkit, #hg-reviewers, durin42 Cc: durin42, mercurial-dev

Re: [PATCH] test-merge-tools: stabilize for Windows

2018-02-12 Thread Yuya Nishihara
On Sun, 11 Feb 2018 21:39:14 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1518400775 18000 > # Sun Feb 11 20:59:35 2018 -0500 > # Node ID 29c42f65c6b609a6bc429fc6d0963d1eb7cc951b > # Parent f91b7f26c68ac87961aa6ef883ba96e5a2822ad3 > test-merge-tools: sta

Re: [PATCH 6 of 6 V2] merge: invoke cmdutil.fileprefetchhooks() prior to applying updates

2018-02-12 Thread Yuya Nishihara
On Sun, 11 Feb 2018 22:58:08 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1518373556 18000 > # Sun Feb 11 13:25:56 2018 -0500 > # Node ID add5bc8012bbedd24d2b9d3a301bfe0eba892ca4 > # Parent d05ecbfd419747d580100f86a3ffdc3b85574166 > merge: invoke cmdutil

Re: [PATCH 4 of 4] log: add TODO comments about --line-range processing

2018-02-12 Thread Yuya Nishihara
On Mon, 12 Feb 2018 08:20:29 +0100, Denis Laxalde wrote: > > if linerange and pats: > > +# TODO: take pats as patterns with no line-range filter > > Do you mean handling "--line-range file1,from:to file2", where "file2" > would be "a pattern with no line-range filter"? Yes. I think

D2133: py3: replace file() with open() in test-convert-git.t

2018-02-12 Thread yuja (Yuya Nishihara)
yuja added inline comments. INLINE COMMENTS > pulkit wrote in test-convert-git.t:423 > To make chr() return bytes, I did chr().encode('latin-1') but there is > `UnicodeDecodeError: 'ascii' codec can't decode byte 0x80 in position 0: > ordinal not in range(128) `error while writing to file. Pyth

D2158: py3: use raw string for open() mode

2018-02-12 Thread yuja (Yuya Nishihara)
yuja added a comment. I wanna leave it with no prefix as possible. I think we'll have to bulk-replace `''`s to `b''`s at some point so we can leverage static analysis tools, where `r''` will be unneeded. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2158 T

Re: [PATCH 4 of 4] log: add TODO comments about --line-range processing

2018-02-12 Thread Denis Laxalde
Yuya Nishihara a écrit : > This is totally unrelated topic, but how would we do if we want to support > non-contiguous range? > > -L file,a:b,c:d > > is ambiguous because file may contain ",". I guess we could iteratively rsplit(",", 1) the file pattern and try to parse "from:to" until it fail

D2109: py3: make sure we return str from __repr__

2018-02-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc4fa47f880d3: py3: make sure we return str from __repr__ (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2109?vs=5478&id=5482

D2130: py3: replace file() with open() in test-encoding.t

2018-02-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG035af48b2903: py3: replace file() with open() in test-encoding.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2130?vs=5479&

D2131: py3: replace file() with open() in test-encoding-align.t

2018-02-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGaf9cb761b5f3: py3: replace file() with open() in test-encoding-align.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2131?vs

D2132: py3: replace file() with open() in test-convert-hg-source.t

2018-02-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3c9f2d4dbb39: py3: replace file() with open() in test-convert-hg-source.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2132

Re: [PATCH 4 of 4] log: add TODO comments about --line-range processing

2018-02-12 Thread Yuya Nishihara
On Mon, 12 Feb 2018 12:04:21 +0100, Denis Laxalde wrote: > Yuya Nishihara a écrit : > > This is totally unrelated topic, but how would we do if we want to support > > non-contiguous range? > > > > -L file,a:b,c:d > > > > is ambiguous because file may contain ",". > > I guess we could iterative

Re: [PATCH 4 of 4] log: add TODO comments about --line-range processing

2018-02-12 Thread Denis Laxalde
Yuya Nishihara a écrit : > On Mon, 12 Feb 2018 12:04:21 +0100, Denis Laxalde wrote: >> Yuya Nishihara a écrit : >>> This is totally unrelated topic, but how would we do if we want to support >>> non-contiguous range? >>> >>> -L file,a:b,c:d >>> >>> is ambiguous because file may contain ",". >> >>

Re: [PATCH] test-merge-tools: stabilize for Windows

2018-02-12 Thread Matt Harbison
> On Feb 12, 2018, at 5:27 AM, Yuya Nishihara wrote: > >> On Sun, 11 Feb 2018 21:39:14 -0500, Matt Harbison wrote: >> # HG changeset patch >> # User Matt Harbison >> # Date 1518400775 18000 >> # Sun Feb 11 20:59:35 2018 -0500 >> # Node ID 29c42f65c6b609a6bc429fc6d0963d1eb7cc951b >> # Paren

[PATCH hglib] [b] ignore close() on non-open clients (issue5751)

2018-02-12 Thread Gábor Stefanik
# HG changeset patch # User Gábor Stefanik # Date 1518443649 -3600 # Mon Feb 12 14:54:09 2018 +0100 # Node ID fe38aeeb1586464769caa6e9bb819078028fc858 # Parent 1085c904d8c04d51c6897027fe9c7bae0964b64b [b] ignore close() on non-open clients (issue5751) Closing a client twice currently trigge

Re: [PATCH] test-merge-tools: stabilize for Windows

2018-02-12 Thread Yuya Nishihara
On Mon, 12 Feb 2018 08:06:12 -0500, Matt Harbison wrote: > > > On Feb 12, 2018, at 5:27 AM, Yuya Nishihara wrote: > > > >> On Sun, 11 Feb 2018 21:39:14 -0500, Matt Harbison wrote: > >> # HG changeset patch > >> # User Matt Harbison > >> # Date 1518400775 18000 > >> # Sun Feb 11 20:59:35 20

Re: [PATCH 4 of 4] log: add TODO comments about --line-range processing

2018-02-12 Thread Yuya Nishihara
On Mon, 12 Feb 2018 13:42:54 +0100, Denis Laxalde wrote: > Yuya Nishihara a écrit : > > On Mon, 12 Feb 2018 12:04:21 +0100, Denis Laxalde wrote: > >> Yuya Nishihara a écrit : > >>> This is totally unrelated topic, but how would we do if we want to support > >>> non-contiguous range? > >>> > >>> -

Re: [PATCH hglib] [b] ignore close() on non-open clients (issue5751)

2018-02-12 Thread Yuya Nishihara
On Mon, 12 Feb 2018 14:55:57 +0100, Gábor Stefanik wrote: > # HG changeset patch > # User Gábor Stefanik > # Date 1518443649 -3600 > # Mon Feb 12 14:54:09 2018 +0100 > # Node ID fe38aeeb1586464769caa6e9bb819078028fc858 > # Parent 1085c904d8c04d51c6897027fe9c7bae0964b64b > [b] ignore close()

D2177: bdiff: add to clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This file didn't require any complex fixes, so we may as well enable clang-format while I'm editing it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab

D1973: bdiff: write a native version of splitnewlines

2018-02-12 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5487. durin42 marked an inline comment as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1973?vs=5160&id=5487 REVISION DETAIL https://phab.mercurial-scm.org/D1973 AFFECTED FILES mercurial/cext/bdiff.c merc

D1973: bdiff: write a native version of splitnewlines

2018-02-12 Thread durin42 (Augie Fackler)
durin42 marked an inline comment as done. durin42 added a comment. Good catches. This should be ready now. I also added bdiff.c to clang-format oversight in a newly inserted parent, because the file is simple enough that doing so was easy. REPOSITORY rHG Mercurial REVISION DETAIL ht

D2180: charencode: adjust clang-format enable/disable comments

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We're pretty close to being able to let clang-format manage most of these files. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D218

D2178: pathencode: allow clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Only had to add two trailing commas to make the file format acceptably! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2178 AFFECTED

D2181: charencode: allow clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Nice and easy. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2181 AFFECTED FILES contrib/clang-format-blacklist mercurial/cext/

D2179: diffhelpers: allow clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY One trailing comma! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2179 AFFECTED FILES contrib/clang-format-blacklist mercurial/

D2182: base85: allow clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2182 AFFECTED FILES contrib/clang-format-blacklist mercurial/cext/base85.c CHANGE DETAILS diff --gi

D2183: mpatch: allow clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2183 AFFECTED FILES contrib/clang-format-blacklist mercurial/cext/mpatch.c CHANGE DETAILS diff --gi

[PATCH 1 of 2 STABLE] label: enforce the lack of leading or trailing white space

2018-02-12 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1518448171 -3600 # Mon Feb 12 16:09:31 2018 +0100 # Branch stable # Node ID 23d835f2d32dfc2aac772a443d2061a57a8aa997 # Parent 7b2b82f891bf6355ed87c06ed9198bfcd033fe7d # EXP-Topic noname # Available At https://bitbucket.org/octobus/mercurial-devel

[PATCH 2 of 2 STABLE] revset: skip old style lookup if external whitespace are detected

2018-02-12 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1518448909 -3600 # Mon Feb 12 16:21:49 2018 +0100 # Branch stable # Node ID 475525edc7da195b7df93c980df322eacb0a41bb # Parent 23d835f2d32dfc2aac772a443d2061a57a8aa997 # EXP-Topic noname # Available At https://bitbucket.org/octobus/mercurial-devel

Re: [PATCH 2 of 2 STABLE] revset: skip old style lookup if external whitespace are detected

2018-02-12 Thread Feld Boris
Just saw that the changesets are on stable somehow, sorry ignore this, I will send a V2. On 12/02/2018 17:19, Boris Feld wrote: # HG changeset patch # User Boris Feld # Date 1518448909 -3600 # Mon Feb 12 16:21:49 2018 +0100 # Branch stable # Node ID 475525edc7da195b7df93c980df322eacb0a41

[PATCH 1 of 2 V2] label: enforce the lack of leading or trailing white space

2018-02-12 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1518448171 -3600 # Mon Feb 12 16:09:31 2018 +0100 # Node ID f02fd7ca256d044c4a51c3f3fc0ecaf95d23e03d # Parent 80e5210df25c330bd2a4e8f12385422545cb69bf # EXP-Topic noname # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

2018-02-12 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1518448909 -3600 # Mon Feb 12 16:21:49 2018 +0100 # Node ID b0f45e1376e2d0f32023e197c51802bc21c60490 # Parent f02fd7ca256d044c4a51c3f3fc0ecaf95d23e03d # EXP-Topic noname # Available At https://bitbucket.org/octobus/mercurial-devel/ #

D2177: bdiff: add to clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb4fdc6177b29: bdiff: add to clang-format oversight (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2177?vs=5486&id=5494 REVI

D1973: bdiff: write a native version of splitnewlines

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. I'm happy with this as a first revision. While I'm accepting as hg-reviewers, I think C code should have an extra set of eyes. So I'll defer to @yuja to queue it. For the record, I'm no fan of not having braces for all bodies

D2178: pathencode: allow clang-format oversight

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > pathencode.c:129-130 > charcopy(dest, &destlen, destsize, src[i++]); > - } > - else state = DDE

D2181: charencode: allow clang-format oversight

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. I want a second opinion about the `#include` order. INLINE COMMENTS > charencode.h:11-12 > > +#include "compat.h" > #include > Huh? Why is it putting a system include a

D2178: pathencode: allow clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG44cb058bc0d3: pathencode: allow clang-format oversight (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2178?vs=5488&id=5495

D2179: diffhelpers: allow clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7f8338b87c88: diffhelpers: allow clang-format oversight (authored by durin42, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2179?vs=5489&id=5496#toc REPOSITORY rHG Mercuria

D2180: charencode: adjust clang-format enable/disable comments

2018-02-12 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG81199632fa42: charencode: adjust clang-format enable/disable comments (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2180?vs

D1974: narrow: import experimental extension from narrowhg revision cb51d673e9c5

2018-02-12 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5498. durin42 marked 12 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1974?vs=5095&id=5498 REVISION DETAIL https://phab.mercurial-scm.org/D1974 AFFECTED FILES hgext/narrow/__init__.py h

D2187: manifest: clean up dirlog() to take a d parameter to avoid shadowing dir()

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2187 AFFECTED FILES hgext/narrow/narrowrevlog.py mercurial/manifest.py CHANGE DETAILS diff --git a/

D2188: narrowrevlog: add what little I can remember about rename filtering

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2188 AFFECTED FILES hgext/narrow/narrowrevlog.py CHANGE DETAILS diff --git a/hgext/narrow/narrowrevlo

D2008: revlog: move ELLIPSIS_NODE_FLAG to core from narrowrevlog

2018-02-12 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5499. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2008?vs=5158&id=5499 REVISION DETAIL https://phab.mercurial-scm.org/D2008 AFFECTED FILES hgext/narrow/narrowchangegroup.py hgext/narrow/narrowrevlog.py hgex

D2189: narrowrevlog: add a TODO around remotefilelog moving to core

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We should clean this up considerably when remotefilelog lands, which we expect to try and accomplish in the near-ish future. REPOSITORY rHG Mercurial REVISION

D2190: narrowspec: document constraints when validating patterns

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2190 AFFECTED FILES hgext/narrow/narrowspec.py CHANGE DETAILS diff --git a/hgext/narrow/narrowspec.py

D2191: narrowspec: consistently use set() to copy sets

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2191 AFFECTED FILES hgext/narrow/narrowspec.py CHANGE DETAILS diff --git a/hgext/narrow/narrowspec.py

D2193: narrowwirepeer: rename expandnarrow capability to exp-expandnarrow

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The expandnarrow functionality lets a client have a shorthand (for Google it's a reference to a checked-in file) for a set of includes and excludes. For testing

D2186: narrowrevlog: replace AssertionError with ProgrammingError

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2186 AFFECTED FILES hgext/narrow/narrowrevlog.py CHANGE DETAILS diff --git a/hgext/narrow/narrowrevlo

D2185: narrowrevlog: document excludeddir class and friends

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2185 AFFECTED FILES hgext/narrow/narrowrevlog.py CHANGE DETAILS diff --git a/hgext/narrow/narrowrevlo

D2184: narrowrepo: add docstring for narrowpats

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2184 AFFECTED FILES hgext/narrow/narrowrepo.py CHANGE DETAILS diff --git a/hgext/narrow/narrowrepo.py

D2195: tests: use `hello` not `capabilities` over ssh

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2195 AFFECTED FILES tests/test-narrow-clone-non-narrow-server.t CHANGE DETAILS diff --git a/tests/tes

D2192: narrow: make restrictpatterns a little more idiomatic

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm not sure why invalid_includes was an out-param, but it doesn't look like there's any reason for it to be now. REPOSITORY rHG Mercurial REVISION DETAIL ht

D2194: narrowwirepeer: add TODO about how we add wireproto args to unbundle :(

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2194 AFFECTED FILES hgext/narrow/narrowwirepeer.py CHANGE DETAILS diff --git a/hgext/narrow/narrowwir

D2181: charencode: allow clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > indygreg wrote in charencode.h:11-12 > Huh? Why is it putting a system include after a local include? This feels > wrong to me. Per a colleague, https://clang.llvm.org/docs/ClangFormatStyleOptions.html - look for IncludeCategories. Basically, i

D2196: narrow: add a TODO document

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These are things that are bigger than we want to handle right now, but are pretty important to get narrowing to be non-experimental. REPOSITORY rHG Mercurial R

D1974: narrow: import experimental extension from narrowhg revision cb51d673e9c5

2018-02-12 Thread durin42 (Augie Fackler)
durin42 added a comment. Okay, I've pushed more followups. The bulk of the TODOs are recorded in a file introduced in https://phab.mercurial-scm.org/D2196, but there are also some added inline in the code. Let me know how I can help - I'll make time to video conference this week if it'd

D1977: narrow: this code should assume REVIDX_FLAGS_ORDER exists

2018-02-12 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > martinvonz wrote in narrowrevlog.py:16-20 > looks like you can instead drop all of this since we have now (since > https://phab.mercurial-scm.org/rHG08b34c3a6f74800b5b357f371568177827963e2b) > defined the flag in revlog.py (and just use revlog.R

D2009: narrowtemplates: update to use registrar mechanism

2018-02-12 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5514. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2009?vs=5159&id=5514 REVISION DETAIL https://phab.mercurial-scm.org/D2009 AFFECTED FILES hgext/narrow/__init__.py hgext/narrow/narrowtemplates.py CHANGE DETA

D2008: narrow: move from ELLIPSIS_NODE_FLAG to revlog.REVIDX_ELLIPSIS

2018-02-12 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5513. durin42 edited the summary of this revision. durin42 retitled this revision from "revlog: move ELLIPSIS_NODE_FLAG to core from narrowrevlog" to "narrow: move from ELLIPSIS_NODE_FLAG to revlog.REVIDX_ELLIPSIS". REPOSITORY rHG Mercurial CHANGES SINCE

D2186: narrowrevlog: replace AssertionError with ProgrammingError

2018-02-12 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5516. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2186?vs=5502&id=5516 REVISION DETAIL https://phab.mercurial-scm.org/D2186 AFFECTED FILES hgext/narrow/narrowrevlog.py CHANGE DETAILS diff --git a/hgext/narrow

D2187: manifest: clean up dirlog() to take a d parameter to avoid shadowing dir()

2018-02-12 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5517. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2187?vs=5503&id=5517 REVISION DETAIL https://phab.mercurial-scm.org/D2187 AFFECTED FILES hgext/narrow/narrowrevlog.py mercurial/manifest.py CHANGE DETAILS d

D2185: narrowrevlog: document excludeddir class and friends

2018-02-12 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5515. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2185?vs=5501&id=5515 REVISION DETAIL https://phab.mercurial-scm.org/D2185 AFFECTED FILES hgext/narrow/narrowrevlog.py CHANGE DETAILS diff --git a/hgext/narrow

D2188: narrowrevlog: add what little I can remember about rename filtering

2018-02-12 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5518. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2188?vs=5504&id=5518 REVISION DETAIL https://phab.mercurial-scm.org/D2188 AFFECTED FILES hgext/narrow/narrowrevlog.py CHANGE DETAILS diff --git a/hgext/narrow

D2189: narrowrevlog: add a TODO around remotefilelog moving to core

2018-02-12 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5519. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2189?vs=5505&id=5519 REVISION DETAIL https://phab.mercurial-scm.org/D2189 AFFECTED FILES hgext/narrow/narrowrevlog.py CHANGE DETAILS diff --git a/hgext/narrow

Re: [PATCH 4 of 4] log: add TODO comments about --line-range processing

2018-02-12 Thread Denis Laxalde
Yuya Nishihara a écrit : On Mon, 12 Feb 2018 13:42:54 +0100, Denis Laxalde wrote: Yuya Nishihara a écrit : On Mon, 12 Feb 2018 12:04:21 +0100, Denis Laxalde wrote: Yuya Nishihara a écrit : This is totally unrelated topic, but how would we do if we want to support non-contiguous range? -L

D2088: wireprototypes: move wire protocol response types to new module

2018-02-12 Thread durin42 (Augie Fackler)
durin42 added a comment. I wonder if these should move to being attrs-generated at some point. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2088 To: indygreg, #hg-reviewers, durin42 Cc: mercurial-devel ___ Mercurial-

buidrpm --withpython embeds 2.7.10. Should it be bumped?

2018-02-12 Thread muxator via Mercurial-devel
Hi, when building for older platforms (centos5, centos6) via our Makefile, we embed a custom version of python 2.7 in the rpm ("buildrpm --withpython"). At the moment, this version is "2.7.10" (which is from 2015):   $ grep -rin "2\.7\.10"   contrib/Makefile.python:1:PYTHONVER=2.7.10   contri

D2083: wireprotoserver: remove redirect() and restore() (API)

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG56fe8a3b2d52: wireprotoserver: remove redirect() and restore() (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2083?vs

D2091: wireprotoserver: extract SSH response handling functions

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5767664d39a5: wireprotoserver: extract SSH response handling functions (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2091?

Re: buidrpm --withpython embeds 2.7.10. Should it be bumped?

2018-02-12 Thread Augie Fackler
> On Feb 12, 2018, at 16:18, muxator via Mercurial-devel > wrote: > > Hi, > > when building for older platforms (centos5, centos6) via our Makefile, we > embed a custom version of python 2.7 in the rpm ("buildrpm --withpython"). > At the moment, this version is "2.7.10" (which is from 2015):

D1755: logexchange: introduce helper function to get remote path name

2018-02-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG62a428bf6359: logexchange: introduce helper function to get remote path name (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1

D1759: remotenames: introduce new template keywords for remotenames

2018-02-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5a53af7d09aa: remotenames: introduce new template keywords for remotenames (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D175

D1758: remotenames: add new namespaces for remotebookmarks and remotebranches

2018-02-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG382aefea8faf: remotenames: add new namespaces for remotebookmarks and remotebranches (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-sc

D1757: remotenames: introduce a class to lazily resolve remotnames

2018-02-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbe72f6420f3c: remotenames: introduce a class to lazily resolve remotnames (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1757

D2080: wireprotoserver: split ssh protocol handler and server

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbf676267f64f: wireprotoserver: split ssh protocol handler and server (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2080?vs

D2087: wireprotoserver: move responsetype() out of http handler

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG341c886e411e: wireprotoserver: move responsetype() out of http handler (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2087?

D2088: wireprototypes: move wire protocol response types to new module

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcd6ab329c5c7: wireprototypes: move wire protocol response types to new module (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org

D2092: wireprotoserver: add version to SSH protocol names (API)

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGac33dc94e1d5: wireprotoserver: add version to SSH protocol names (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2092?

D2081: wireprotoserver: add context manager mechanism for redirecting stdio

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2ad145fbde54: wireprotoserver: add context manager mechanism for redirecting stdio (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-sc

D2084: wireprotoserver: rename _client to client (API)

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG957e773614d0: wireprotoserver: rename _client to client (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2084?vs=5347&i

D2085: wireprotoserver: rename getfile() to forwardpayload() (API)

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG90ca4986616c: wireprotoserver: rename getfile() to forwardpayload() (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D20

D2086: wireproto: remove unused proto argument from supportedcompengines (API)

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG038bcb759b75: wireproto: remove unused proto argument from supportedcompengines (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial

D2082: wireproto: use maybecapturestdio() for push responses (API)

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcaca3ac2ac04: wireproto: use maybecapturestdio() for push responses (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D20

D1756: remotenames: introduce class to encapsulate remotenames info in an extension

2018-02-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcabe8ef5c71e: remotenames: introduce class to encapsulate remotenames info in an extension (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercur

D2089: wireproto: introduce type for raw byte responses (API)

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2f7290555c96: wireproto: introduce type for raw byte responses (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2089?vs

D2094: wireprotoserver: define and use parse_qs from urllib

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa3d42d1865f1: wireprotoserver: define and use parse_qs from urllib (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2094?vs=5

D2093: tests: add tests for sending recognized command before handshake

2018-02-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG465858451347: tests: add tests for sending recognized command before handshake (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.or

D2088: wireprototypes: move wire protocol response types to new module

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D2088#36287, @durin42 wrote: > I wonder if these should move to being attrs-generated at some point. Probably. I'm half considering blowing up all these types because they are... not well-defined and behavior is overloade

D2108: infinitepush: drop the `--to` flag to push and use `-B` instead

2018-02-12 Thread durham (Durham Goode)
durham added a comment. > There are things which I am not sure whether to keep or not: > > - the --bundle-store flag to push command This is useful for scripts or tools that want to upload a commit to the cloud without having to give it a name. For instance, you can use it to push a

D2197: python3: whitelist another four passing tests

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2197 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --

D2197: python3: whitelist another four passing tests

2018-02-12 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7f68235f23ff: python3: whitelist another four passing tests (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2197?vs=5539&id=5

D2108: infinitepush: drop the `--to` flag to push and use `-B` instead

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D2108#36335, @durham wrote: > > There are things which I am not sure whether to keep or not: > > > > - the --bundle-store flag to push command > > This is useful for scripts or tools that want to upload a commit to the c

mercurial@35957: 7 new changesets

2018-02-12 Thread Mercurial Commits
7 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/8b6dd3922f70 changeset: 35951:8b6dd3922f70 parent: 35949:80e5210df25c user:Yuya Nishihara date:Sun Feb 04 10:28:03 2018 +0900 summary: patch: unify check_binary and binary flags https://www.mercur

RE: [PATCH hglib] [b] ignore close() on non-open clients (issue5751)

2018-02-12 Thread Gábor STEFANIK
> -Original Message- > From: Yuya Nishihara [mailto:you...@gmail.com] On Behalf Of Yuya > Nishihara > Sent: Monday, February 12, 2018 3:50 PM > To: Gábor STEFANIK > Cc: mercurial-devel@mercurial-scm.org > Subject: Re: [PATCH hglib] [b] ignore close() on non-open clients (issue5751) > > On

D1974: narrow: import experimental extension from narrowhg revision cb51d673e9c5

2018-02-12 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. I think I've seen enough follow-ups to feel comfortable taking this in core. There's still a ton of work that needs to get done. But it will be easier to iterate and for others to get i

  1   2   >