Re: [Mesa-dev] [PATCH 5/5] ac: use correct LLVM opcodes for ordered comparisons

On Wed, Feb 14, 2018 at 11:53 PM, Timothy Arceri wrote: > > > On 15/02/18 04:39, Marek Olšák wrote: >> >> Reviewed-by: Marek Olšák >> >> Marek >> >> On Wed, Feb 14, 2018 at 7:29 AM, Timothy Arceri >> wrote: >>> >>> Fixes

Re: [Mesa-dev] [PATCH 5/5] ac: use correct LLVM opcodes for ordered comparisons

On 15/02/18 04:39, Marek Olšák wrote: Reviewed-by: Marek Olšák Marek On Wed, Feb 14, 2018 at 7:29 AM, Timothy Arceri wrote: Fixes glsl-1.30/execution/isinf-and-isnan* piglit tests for radeonsi and should fix SPIRV errors when LLVM optimises away

[Mesa-dev] [PATCH] radeonsi/nir: set TGSI_PROPERTY_FS_EARLY_DEPTH_STENCIL correctly

We set this for post_depth_coverage in addition to early_fragment_tests. --- This doesn't fix any piglit tests but it's what the glsl->tgsi state tracker does. src/gallium/drivers/radeonsi/si_shader_nir.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH] svga: call tgsi_scan_shader() for dummy shaders

If we fail to compile the normal VS or FS we fall back to a simple/ dummy shader. We need to rescan the the shader to update the shader info. Otherwise, this can lead to further translations failures because the shader info doesn't match the actual shader. Found by adding some extra debug

Re: [Mesa-dev] [PATCH 1/3] svga: call tgsi_scan_shader() for dummy shaders

On 02/14/2018 03:46 PM, Charmaine Lee wrote: From: Brian Paul Sent: Wednesday, February 14, 2018 1:15 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 1/3] svga: call tgsi_scan_shader() for dummy shaders If we fail to compile the

Re: [Mesa-dev] [PATCH 0/6] OpenGL 3.1 + ARB_compatibility and related stuff (v2)

For the series: Tested-by: Dieter Nützel on RX580 with SPECviewperf from the phoronix test suite. ;-) Viewset Composite Mulitsample Performance 3dsmax-0411.97 no result catia-02 9.19 no result ensight-03 not Successful maya-02 41.69 no

Re: [Mesa-dev] [PATCH 0/6] OpenGL 3.1 + ARB_compatibility and related stuff (v2)

i965 doesn't report GL 3.1 because it doesn't expose TBOs in the default GL profile. Marek On Thu, Feb 15, 2018 at 2:49 AM, Mike Lothian wrote: > On 15 February 2018 at 00:11, Marek Olšák wrote: >> Hi, >> >> This is the second version of GL 3.1

Re: [Mesa-dev] [Clover] compilation error (WriteBitcodeToFile) with latest LLVM git version

On Thu, 2018-02-15 at 01:18 +0100, Dieter Nützel wrote: > Hello Jan, > > new compilation error with latest LLVM git (7.0.0). > Without --enable-opencl build is fine. > > make[4]: Verzeichnis „/opt/mesa/src/gallium/state_trackers/clover“ wird > betreten >CXX

Re: [Mesa-dev] [PATCH] nir: add is_used_once for fmul(fexp2(a), fexp2(b)) to fexp2(fadd(a, b))

On 02/14/2018 05:36 PM, Ian Romanick wrote: > Do you have shader-db results? Did you try having only one is_used_once? I think you sent out a hastebin link with results before, but it's not loading now. > On 02/05/2018 07:07 AM, Samuel Pitoiset wrote: >> Otherwise the code size increases

Re: [Mesa-dev] [PATCH 0/6] OpenGL 3.1 + ARB_compatibility and related stuff (v2)

On 15 February 2018 at 00:11, Marek Olšák wrote: > Hi, > > This is the second version of GL 3.1 compatibility support patches. > There is also ARB_enhanced_layouts for the compatibility context and > other related changes. > > Please review. > > Thanks, > Marek >

Re: [Mesa-dev] [PATCH 08/17] loader: Fix compiler warnings about truncating the PCI ID path.

On 02/13/2018 02:31 AM, Eric Anholt wrote: > Ian Romanick writes: > >> On 02/10/2018 08:33 AM, Eric Anholt wrote: >>> My build was producing: >>> >>> ../src/loader/loader.c:121:67: warning: ‘%1u’ directive output may be >>> truncated writing between 1 and 3 bytes into a

[Mesa-dev] [PATCH libdrm] intel/intel_chipset.h: Sync Cannonlake IDs.

Let's sync CNL ids with Spec and kernel. Sync with kernel commit '3f43031b1693 ("drm/i915/cnl: Add Cannonlake PCI IDs for another SKU.")' and commit 'e3890d05b342 ("drm/i915/cnl: Sync PCI ID with Spec.")' Cc: James Ausmus Cc: Lucas De Marchi

Re: [Mesa-dev] [PATCH] nir: add is_used_once for fmul(fexp2(a), fexp2(b)) to fexp2(fadd(a, b))

Do you have shader-db results? Did you try having only one is_used_once? On 02/05/2018 07:07 AM, Samuel Pitoiset wrote: > Otherwise the code size increases because the original fexp2() > instructions can't be deleted. > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH] mesa: don't clamp just based on ARB_viewport_array extension

Pushed, thanks! Marek On Thu, Feb 15, 2018 at 1:12 AM, Gurchetan Singh wrote: > On Wed, Feb 14, 2018 at 3:57 PM, Marek Olšák wrote: >> Do you have commit access? > > No, would appreciate a merge ;-) > >> Marek >> >> On Thu, Feb 15, 2018 at 12:40

[Mesa-dev] [Bug 105098] [RADV] GPU freeze with simple Vulkan App

https://bugs.freedesktop.org/show_bug.cgi?id=105098 --- Comment #4 from Lukas Kahnert --- I use a Vega64 Liquid Edition I found out that if you change fragColor or outColor in the shader source to a fixed value the issue is not triggered(it doesn't freeze

[Mesa-dev] [Clover] compilation error (WriteBitcodeToFile) with latest LLVM git version

Hello Jan, new compilation error with latest LLVM git (7.0.0). Without --enable-opencl build is fine. make[4]: Verzeichnis „/opt/mesa/src/gallium/state_trackers/clover“ wird betreten CXX llvm/codegen/libclllvm_la-bitcode.lo llvm/codegen/bitcode.cpp: In function ‘std::vector

[Mesa-dev] [Bug 105105] Suffixless KHR_robustness functions aren't exposed in ES 3.2

https://bugs.freedesktop.org/show_bug.cgi?id=105105 Bug ID: 105105 Summary: Suffixless KHR_robustness functions aren't exposed in ES 3.2 Product: Mesa Version: git Hardware: Other OS: All

[Mesa-dev] [Bug 105098] [RADV] GPU freeze with simple Vulkan App

https://bugs.freedesktop.org/show_bug.cgi?id=105098 Bas Nieuwenhuizen changed: What|Removed |Added Status|NEEDINFO|NEW ---

Re: [Mesa-dev] [PATCH] mesa: don't clamp just based on ARB_viewport_array extension

On Wed, Feb 14, 2018 at 3:57 PM, Marek Olšák wrote: > Do you have commit access? No, would appreciate a merge ;-) > Marek > > On Thu, Feb 15, 2018 at 12:40 AM, gurchetansi...@chromium.org > wrote: >> From: Gurchetan Singh

[Mesa-dev] [PATCH 5/6] mesa: replace some API_OPENGL_CORE checks with _mesa_is_desktop_gl

From: Marek Olšák This is more accurate with respect to the compatibility profile. --- src/mesa/main/get.c | 2 +- src/mesa/main/varray.c| 6 +++--- src/mesa/vbo/vbo_attrib_tmp.h | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 0/6] OpenGL 3.1 + ARB_compatibility and related stuff (v2)

Hi, This is the second version of GL 3.1 compatibility support patches. There is also ARB_enhanced_layouts for the compatibility context and other related changes. Please review. Thanks, Marek ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 2/6] mesa: enable OpenGL 3.1 with ARB_compatibility

From: Marek Olšák --- docs/features.txt | 8 docs/relnotes/18.1.0.html | 5 +++-- src/mesa/drivers/dri/common/dri_util.c | 8 src/mesa/main/version.c| 16 ++-- 4 files changed, 17

[Mesa-dev] [PATCH 4/6] mesa: add some of missing compatibility support for ARB_bindless_texture

From: Marek Olšák The extension is exposed in the compatibility profile. --- src/mapi/glapi/gen/apiexec.py | 2 +- src/mesa/main/api_loopback.c | 8 src/mesa/main/vtxfmt.c| 9 + 3 files changed, 10 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH 6/6] mesa: rename has_core_gs -> has_gs in get_programiv

From: Marek Olšák This is also true for GLES. --- src/mesa/main/shaderapi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index d0d2ef9..37d99b5 100644 --- a/src/mesa/main/shaderapi.c +++

[Mesa-dev] [PATCH 3/6] mesa: expose ARB_enhanced_layouts in the compatibility profile

From: Marek Olšák GLSL 1.40 is required. --- src/mesa/drivers/dri/i965/intel_extensions.c | 3 ++- src/mesa/main/extensions_table.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_extensions.c

[Mesa-dev] [PATCH 1/6] mesa: implement ARB_compatibility

From: Marek Olšák --- src/compiler/glsl/builtin_functions.cpp | 2 +- src/compiler/glsl/builtin_types.cpp | 2 +- src/compiler/glsl/builtin_variables.cpp | 2 +- src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 2 ++

[Mesa-dev] [Bug 105098] [RADV] GPU freeze with simple Vulkan App

https://bugs.freedesktop.org/show_bug.cgi?id=105098 --- Comment #2 from Lukas Kahnert --- >From the VulkanTutorial source most demos trigger the freeze. For example the triangle demo 15_hello_triangle.cpp with 09_shader_base.frag and 09_shader_base.vert as shaders.

Re: [Mesa-dev] [PATCH] mesa: don't clamp just based on ARB_viewport_array extension

Do you have commit access? Marek On Thu, Feb 15, 2018 at 12:40 AM, gurchetansi...@chromium.org wrote: > From: Gurchetan Singh > > The ARB_viewport_array spec says: > > "Dependencies > OpenGL 1.0 is required. > > OpenGL 3.2 or

Re: [Mesa-dev] [PATCH v3 18/18] anv/cmd_buffer: Avoid unnecessary transitions before fast clears

On Wed, Feb 14, 2018 at 12:16:33PM -0800, Jason Ekstrand wrote: > Previously, we would always apply the layout transition at the beginning > of the subpass and then do the clear whether fast or slow. This meant > that there were some cases, specifically when the initial layout is >

[Mesa-dev] [PATCH] mesa: don't clamp just based on ARB_viewport_array extension

From: Gurchetan Singh The ARB_viewport_array spec says: "Dependencies OpenGL 1.0 is required. OpenGL 3.2 or the EXT_geometry_shader4 or ARB_geometry_shader4 extensions are required. This extension is written against the OpenGL 3.2 (Compatibility)

Re: [Mesa-dev] [PATCH] mesa: don't clamp just based on ARB_viewport_array extension

On Wed, Feb 14, 2018 at 6:22 PM, gurchetansi...@chromium.org wrote: > From: Gurchetan Singh > > The ARB_viewport_array spec says: > > "Dependencies > OpenGL 1.0 is required. > > OpenGL 3.2 or the EXT_geometry_shader4 or

Re: [Mesa-dev] [PATCH] mesa: don't clamp just based on ARB_viewport_array extension

Reviewed-by: Marek Olšák Marek On Thu, Feb 15, 2018 at 12:22 AM, gurchetansi...@chromium.org wrote: > From: Gurchetan Singh > > The ARB_viewport_array spec says: > > "Dependencies > OpenGL 1.0 is required. > >

[Mesa-dev] [PATCH] mesa: don't clamp just based on ARB_viewport_array extension

From: Gurchetan Singh The ARB_viewport_array spec says: "Dependencies OpenGL 1.0 is required. OpenGL 3.2 or the EXT_geometry_shader4 or ARB_geometry_shader4 extensions are required. This extension is written against the OpenGL 3.2 (Compatibility)

Re: [Mesa-dev] [PATCH] i965: Drop EXEC_OBJECT_CAPTURE defines.

rb On Wed, Feb 14, 2018 at 2:19 PM, Kenneth Graunke wrote: > These only existed to avoid making people update libdrm for new uABI > headers. A while ago we imported those headers into the Mesa repo, > so the dependency is gone and these are no longer useful. > --- >

Re: [Mesa-dev] [PATCH v3 04/18] anv: Use framebuffer layers for implicit subpass transitions

On Wed, Feb 14, 2018 at 2:27 PM, Nanley Chery wrote: > On Wed, Feb 14, 2018 at 12:16:19PM -0800, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/genX_cmd_buffer.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > We should probabably add: > > Fixes:

Re: [Mesa-dev] [PATCH v3 10/18] anv/cmd_buffer: Move the rest of clear_subpass into begin_subpass

On Wed, Feb 14, 2018 at 2:51 PM, Nanley Chery wrote: > On Wed, Feb 14, 2018 at 12:16:25PM -0800, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_blorp.c | 242 -- > --- > > src/intel/vulkan/anv_private.h | 17 ++- > >

Re: [Mesa-dev] [PATCH v3 02/18] anv: Be more careful about fast-clear colors

On Wed, Feb 14, 2018 at 12:16:17PM -0800, Jason Ekstrand wrote: > Previously, we just used all the channels regardless of the format. > This is less than ideal because some channels may have undefined values > and this should be ok from the client's perspective. Even though the > driver should do

Re: [Mesa-dev] [PATCH v3 15/18] anv/cmd_buffer: Sync clear values in begin_subpass

On Wed, Feb 14, 2018 at 12:16:30PM -0800, Jason Ekstrand wrote: > This is quite a bit cleaner because we now sync the clear values at the > same time as we do the fast clear. For loading the clear values into > the surface state, we now do it once when we handle the LOAD_OP_LOAD > instead of

Re: [Mesa-dev] [PATCH v3 11/18] anv/cmd_buffer: Decide whether or not to HiZ clear up-front

On Wed, Feb 14, 2018 at 12:16:26PM -0800, Jason Ekstrand wrote: > This moves the decision out of begin_subpass and into BeginRenderPass > like the decision for color clears. We use a similar name for the > function for depth/stencil as for color even though no aux usage is > really getting

Re: [Mesa-dev] [PATCH v3 10/18] anv/cmd_buffer: Move the rest of clear_subpass into begin_subpass

On Wed, Feb 14, 2018 at 12:16:25PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/anv_blorp.c | 242 > - > src/intel/vulkan/anv_private.h | 17 ++- > src/intel/vulkan/genX_cmd_buffer.c | 68 ++- > 3 files changed, 186 insertions(+),

Re: [Mesa-dev] [PATCH 3/3] svga: move duplicated code for setting fillmode/flatshade state

For patch 2 and 3, Reviewed-by: Charmaine Lee From: Brian Paul Sent: Wednesday, February 14, 2018 1:15:14 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH 3/3] svga: move

Re: [Mesa-dev] [PATCH 1/3] svga: call tgsi_scan_shader() for dummy shaders

>From: Brian Paul >Sent: Wednesday, February 14, 2018 1:15 PM >To: mesa-dev@lists.freedesktop.org >Cc: Charmaine Lee; Neha Bhende >Subject: [PATCH 1/3] svga: call tgsi_scan_shader() for dummy shaders >If we fail to compile the normal VS or FS we fall back to a simple/ >dummy

Re: [Mesa-dev] [PATCH 16/16] i965/icl: Add render target flush after uploading binding table

On Tue, Feb 13, 2018 at 4:17 PM, Kenneth Graunke wrote: > On Tuesday, February 13, 2018 11:15:16 AM PST Anuj Phogat wrote: >> From PIPE_CONTROL command description in gfxspecs: >> >> "Whenever a Binding Table Index (BTI) used by a Render Taget Message >> points to a

Re: [Mesa-dev] [PATCH v3 04/18] anv: Use framebuffer layers for implicit subpass transitions

On Wed, Feb 14, 2018 at 12:16:19PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/genX_cmd_buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > We should probabably add: Fixes: de3be618016 "anv/cmd_buffer: Rework aux tracking" This patch is Reviewed-by: Nanley Chery

[Mesa-dev] [PATCH] i965: Drop EXEC_OBJECT_CAPTURE defines.

These only existed to avoid making people update libdrm for new uABI headers. A while ago we imported those headers into the Mesa repo, so the dependency is gone and these are no longer useful. --- src/mesa/drivers/dri/i965/brw_bufmgr.h | 3 --- 1 file changed, 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] radv: compact varyings after removing unused ones

On 15/02/18 01:10, Samuel Pitoiset wrote: It makes no sense to compact before, and the description of nir_compact_varyings() confirms that. Reviewed-by: Timothy Arceri Your right this seems to be in the wrong place. There was a lot of restructuring around the time

Re: [Mesa-dev] [PATCH 14/16] i965/icl: Disable HiZ surface sampling

On Tue, Feb 13, 2018 at 4:25 PM, Kenneth Graunke wrote: > On Tuesday, February 13, 2018 11:15:14 AM PST Anuj Phogat wrote: >> On gen11+ AUX_HIZ is not a supported value for surfaces being >> sampled by the 3D sampler. >> >> Signed-off-by: Anuj Phogat

Re: [Mesa-dev] [PATCH] svga: s/unsigned/enum pipe_shader_type/

Looks good. Reviewed-by: Neha Bhende Regards, Neha From: Brian Paul Sent: Wednesday, February 14, 2018 1:53:52 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee; Neha Bhende Subject: [PATCH] svga: s/unsigned/enum

[Mesa-dev] [PATCH] svga: s/unsigned/enum pipe_shader_type/

--- src/gallium/drivers/svga/svga_tgsi.c| 3 ++- src/gallium/drivers/svga/svga_tgsi.h| 5 +++-- src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi.c

[Mesa-dev] [PATCH 08/15] glsl: Switch ast_type_qualifier to a 128-bit bitset.

This should end the drought of bits in the ast_type_qualifier object. The bitset_t type works pretty much as a drop-in replacement for the current uint64_t bitset. The only catch is that the bitset_t type as defined in the previous commit doesn't have a trivial constructor (because it has a

[Mesa-dev] [PATCH 15/15] mesa: Expose EXT_shader_framebuffer_fetch(_non_coherent) on desktop and embedded GL.

--- docs/relnotes/18.1.0.html| 2 ++ src/mesa/main/extensions_table.h | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/relnotes/18.1.0.html b/docs/relnotes/18.1.0.html index b8a0cd0d02c..f5564e9b8fe 100644 --- a/docs/relnotes/18.1.0.html +++

[Mesa-dev] [PATCH 07/15] util/bitset: Add C++ wrapper for static-size bitsets.

--- src/util/bitset.h | 114 ++ 1 file changed, 114 insertions(+) diff --git a/src/util/bitset.h b/src/util/bitset.h index 2404ce7f630..7bb5f3c83cf 100644 --- a/src/util/bitset.h +++ b/src/util/bitset.h @@ -132,4 +132,118 @@

[Mesa-dev] [PATCH 09/15] glsl: Replace MESA_shader_framebuffer_fetch extension flags with EXT ones.

--- src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 9 +++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/compiler/glsl/glsl_parser_extras.cpp b/src/compiler/glsl/glsl_parser_extras.cpp index 57589843776..68ad54db8ab 100644 ---

[Mesa-dev] [PATCH 10/15] glsl: Initialize ir_variable_data::fb_fetch_output earlier for GL(ES) 2.

At the same point where it is initialized on GL(ES) 3.0+ so we can implement some common layout qualifier handling in a future commit. Until now the fb_fetch_output flag would be inherited from the original implicit gl_LastFragData declaration at a later point in the AST to GLSL IR translation.

[Mesa-dev] [PATCH 11/15] glsl: Allow layout token for EXT_shader_framebuffer_fetch_non_coherent.

EXT_shader_framebuffer_fetch_non_coherent requires layout qualifiers even on GL(ES) 2. --- src/compiler/glsl/glsl_lexer.ll | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/glsl_lexer.ll b/src/compiler/glsl/glsl_lexer.ll index 4b36574b73a..2c2098129fd 100644

[Mesa-dev] [PATCH 12/15] glsl: Add support for the framebuffer fetch layout(noncoherent) qualifier.

This allows the application to request framebuffer fetch coherency with per-fragment output granularity. Coherent framebuffer fetch outputs (which is the default if no qualifier is present for compatibility with older versions of the EXT_shader_framebuffer_fetch extension) will have

[Mesa-dev] [PATCH 14/15] glsl: Silence warnings when reading from a framebuffer fetch output.

Framebuffer fetch outputs are implicitly initialized upon entry to the fragment shader. --- src/compiler/glsl/ast_to_hir.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index 5acbaa321a9..badfbe6816f 100644 ---

[Mesa-dev] [PATCH 04/15] glapi: Update XML for last revision of EXT_shader_framebuffer_fetch.

Desktop GL is now supported, and there is an additional entry-point for EXT_shader_framebuffer_fetch_non_coherent. --- src/mapi/glapi/gen/es_EXT.xml | 5 - src/mapi/glapi/gen/gl_API.xml | 6 ++ 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/mapi/glapi/gen/es_EXT.xml

[Mesa-dev] [PATCH 03/15] mesa: Rename MESA_shader_framebuffer_fetch gl_extensions bits to EXT.

The changes I had originally planned for the MESA_shader_framebuffer_fetch extension have been merged into the EXT spec, there's no point in keeping MESA_shader_framebuffer_fetch extension enables. --- src/mesa/drivers/dri/i965/brw_draw.c | 2 +-

[Mesa-dev] [PATCH 02/15] mesa: Rename dd_function_table::BlendBarrier to match latest EXT spec.

This GL entry point was renamed to glFramebufferFetchBarrier() in the EXT extension on request from Khronos members. Update the Mesa codebase to match the latest spec. --- src/mesa/drivers/dri/i965/brw_program.c | 4 ++-- src/mesa/main/barrier.c | 2 +-

[Mesa-dev] [PATCH 06/15] util: Add EXPLICIT_CONVERSION macro.

This can be used to specify that a C++ conversion operator is not meant to be used for implicit conversions, which can lead to unintended loss of information in some cases. Implemented as a macro in order to keep old GCC versions happy. --- src/util/macros.h | 10 ++ 1 file changed, 10

[Mesa-dev] [PATCH 01/15] i965: Fix KHR_blend_equation_advanced with some render targets.

This reverts two bogus and seemingly useless changes from the commits referenced below, which broke KHR_blend_equation_advanced (and EXT_shader_framebuffer_fetch_non_coherent which wasn't exposed yet) for any kind of render target surface that would cause the get_isl_surf() call in

[Mesa-dev] [PATCH 05/15] mesa: Implement glFramebufferFetchBarrierEXT entry point.

--- src/mesa/main/barrier.c | 17 +++-- src/mesa/main/barrier.h | 3 +++ src/mesa/main/tests/dispatch_sanity.cpp | 6 ++ 3 files changed, 24 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/barrier.c b/src/mesa/main/barrier.c index

[Mesa-dev] [PATCH 13/15] glsl: Specify framebuffer fetch coherency mode in lower_blend_equation_advanced().

This requires passing an extra argument to the lowering pass because the KHR_blend_equation_advanced specification doesn't seem to define any mechanism for the implementation to determine at compile-time whether coherent blending can ever be used (not even an "#extension

[Mesa-dev] [PATCH 00/15] Implement latest version of EXT_shader_framebuffer_fetch.

This series implements version 7 of the EXT_shader_framebuffer_fetch specification, which includes a number of changes I had originally planned for a MESA extension but which ended up queued for inclusion into an EXT extension after months-long discussion with several Khronos members. The most

[Mesa-dev] [Bug 105098] [RADV] GPU freeze with simple Vulkan App

https://bugs.freedesktop.org/show_bug.cgi?id=105098 Bas Nieuwenhuizen changed: What|Removed |Added Status|NEW |NEEDINFO

[Mesa-dev] [PATCH 3/3] svga: move duplicated code for setting fillmode/flatshade state

Move the calls to svga_hwtnl_set_fillmode() and svga_hwtnl_set_flatshade() out of the two retry_draw_*() functions to the svga_draw_vbo() function. --- src/gallium/drivers/svga/svga_pipe_draw.c | 30 ++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git

[Mesa-dev] [PATCH 1/3] svga: call tgsi_scan_shader() for dummy shaders

If we fail to compile the normal VS or FS we fall back to a simple/ dummy shader. We need to rescan the the shader to update the shader info. Otherwise, this can lead to further translations failures because the shader info doesn't match the actual shader. Found by adding some extra debug

[Mesa-dev] [PATCH 2/3] svga: move svga_update_state() call in draw code

This fixes a few Piglit transform feedback regressions caused by commit 7a1401938b351. In that change I moved the moved svga_update_state() into the loops, after the calls to svga_hwtnl_set_flatshade(). But svga_hwtnl_set_flatshade() actually depends on some derived shader state. This patch

[Mesa-dev] [PATCH v3 14/18] anv/pass: Store usage in each subpass attachment

This requires us to ditch the VkAttachmentReference struct in favor of an anv-specific struct. However, we can now easily identify from just the subpass attachment what kind of an attachment it is. This will make iteration over anv_subpass::attachments a little easier in some case. Reviewed-by:

[Mesa-dev] [PATCH v3 17/18] anv/cmd_buffer: Do subpass image transitions in begin/end_subpass

Reviewed-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 220 +++-- 1 file changed, 88 insertions(+), 132 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 310c01f..7f06441

[Mesa-dev] [PATCH v3 15/18] anv/cmd_buffer: Sync clear values in begin_subpass

This is quite a bit cleaner because we now sync the clear values at the same time as we do the fast clear. For loading the clear values into the surface state, we now do it once when we handle the LOAD_OP_LOAD instead of every subpass. --- src/intel/vulkan/genX_cmd_buffer.c | 148

[Mesa-dev] [PATCH v3 13/18] anv/cmd_buffer: Add a concept of pending load aspects

These are the same as pending clear aspects only for the "load" operation. Reviewed-by: Nanley Chery --- src/intel/vulkan/anv_private.h | 1 + src/intel/vulkan/genX_cmd_buffer.c | 22 -- 2 files changed, 17 insertions(+), 6 deletions(-) diff

[Mesa-dev] [PATCH v3 07/18] anv/cmd_buffer: Pass a subpass id into begin_subpass

This is a bit less awkward than passing in the subpass because it means we don't have to extract the subpass id from the subpass. Reviewed-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff

[Mesa-dev] [PATCH v3 16/18] anv/cmd_buffer: Mark depth/stencil surfaces written in begin_subpass

Reviewed-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 50 ++ 1 file changed, 29 insertions(+), 21 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 793f590..310c01f

[Mesa-dev] [PATCH v3 09/18] intel/blorp: Add a blorp_hiz_clear_depth_stencil helper

This is similar to blorp_gen8_hiz_clear_attachments except that it takes actual images instead of trusting in the already set depth state. Reviewed-by: Nanley Chery --- src/intel/blorp/blorp.h | 11 + src/intel/blorp/blorp_clear.c | 53

[Mesa-dev] [PATCH v3 18/18] anv/cmd_buffer: Avoid unnecessary transitions before fast clears

Previously, we would always apply the layout transition at the beginning of the subpass and then do the clear whether fast or slow. This meant that there were some cases, specifically when the initial layout is VK_IMAGE_LAYOUT_UNDEFINED, where we would end up doing a fast-clear or ambiguate

[Mesa-dev] [PATCH v3 12/18] anv/cmd_buffer: Iterate all subpass attachments when clearing

This unifies things a bit because we now handle depth and stencil at the same time. Reviewed-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 78 -- 1 file changed, 33 insertions(+), 45 deletions(-) diff --git

[Mesa-dev] [PATCH v3 06/18] anv/cmd_buffer: Add begin/end_subpass helpers

Having begin/end_subpass is a bit nicer than the begin/next/end hooks that Vulkan gives us. Reviewed-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 55 +- 1 file changed, 31 insertions(+), 24 deletions(-) diff --git

[Mesa-dev] [PATCH v3 08/18] anv/cmd_buffer: Move the color portion of clear_subpass into begin_subpass

This doesn't really change much now but it will give us more/better control over clears in the future. The one interesting functional change here is that we are now re-emitting 3DSTATE_DEPTH_BUFFERS and friends for each clear. However, this only happens at begin_subpass time so it shouldn't be

[Mesa-dev] [PATCH v3 10/18] anv/cmd_buffer: Move the rest of clear_subpass into begin_subpass

--- src/intel/vulkan/anv_blorp.c | 242 - src/intel/vulkan/anv_private.h | 17 ++- src/intel/vulkan/genX_cmd_buffer.c | 68 ++- 3 files changed, 186 insertions(+), 141 deletions(-) diff --git a/src/intel/vulkan/anv_blorp.c

[Mesa-dev] [PATCH v3 11/18] anv/cmd_buffer: Decide whether or not to HiZ clear up-front

This moves the decision out of begin_subpass and into BeginRenderPass like the decision for color clears. We use a similar name for the function for depth/stencil as for color even though no aux usage is really getting computed. v2 (Jason Ekstrand): - Don't always disable HiZ clears by accident

[Mesa-dev] [PATCH v3 05/18] anv/cmd_buffer: Apply subpass flushes before set_subpass

This seems slightly more correct because it means that the flushes happen before any clears or resolves implied by the subpass transition. Reviewed-by: Nanley Chery --- src/intel/vulkan/genX_cmd_buffer.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[Mesa-dev] [PATCH v3 02/18] anv: Be more careful about fast-clear colors

Previously, we just used all the channels regardless of the format. This is less than ideal because some channels may have undefined values and this should be ok from the client's perspective. Even though the driver should do the correct thing regardless of what is in the undefined value, it

[Mesa-dev] [PATCH v3 03/18] intel/blorp: Use the hardware op for CCS ambiguate on gen10+

Cannonlake hardware adds a new resolve type in 3DSTATE_PS called FAST_CLEAR_0 which does an ambiguate. Now that the hardware can do it directly, we should use that instead of binding the CCS as a render target and doing it manually. This was tested with a full Vulkan CTS run on Cannonlake. ---

[Mesa-dev] [PATCH v3 00/18] Rework subpass clears and transitions

This is another version of my patch series to rework subpass clears and transitions. It's fairly similar to the other one I sent out except that it's been rebased on top of the resolve reworks and has some fixes from Nanley. There are also two patches on the front side to remove some potential

[Mesa-dev] [PATCH v3 04/18] anv: Use framebuffer layers for implicit subpass transitions

--- src/intel/vulkan/genX_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 8b1816a..a16b742 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_cmd_buffer.c @@

[Mesa-dev] [PATCH v3 01/18] intel/isl: Add an isl_color_value_is_zero helper

Cc: mesa-sta...@lists.freedesktop.org --- src/intel/isl/isl.c | 20 src/intel/isl/isl.h | 3 +++ 2 files changed, 23 insertions(+) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 59f512f..f4b0502 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@

[Mesa-dev] [Bug 105098] [RADV] GPU freeze with simple Vulkan App

https://bugs.freedesktop.org/show_bug.cgi?id=105098 Bug ID: 105098 Summary: [RADV] GPU freeze with simple Vulkan App Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH] i965: Add gl_state_index casts for PATCH_VERTICES_IN

On Wednesday, February 14, 2018 10:17:07 AM PST Jason Ekstrand wrote: > On Wed, Feb 14, 2018 at 10:12 AM, Kenneth Graunke > wrote: > > > On Wednesday, February 14, 2018 6:05:22 AM PST Marek Olšák wrote: > > > On Wed, Feb 14, 2018 at 7:57 AM, Kenneth Graunke

Re: [Mesa-dev] [PATCH] i965: Add gl_state_index casts for PATCH_VERTICES_IN

On Wed, Feb 14, 2018 at 10:12 AM, Kenneth Graunke wrote: > On Wednesday, February 14, 2018 6:05:22 AM PST Marek Olšák wrote: > > On Wed, Feb 14, 2018 at 7:57 AM, Kenneth Graunke > wrote: > > > On Tuesday, February 13, 2018 2:57:07 PM PST Jason

Re: [Mesa-dev] [PATCH] i965: Add gl_state_index casts for PATCH_VERTICES_IN

On Wednesday, February 14, 2018 6:05:22 AM PST Marek Olšák wrote: > On Wed, Feb 14, 2018 at 7:57 AM, Kenneth Graunke > wrote: > > On Tuesday, February 13, 2018 2:57:07 PM PST Jason Ekstrand wrote: > >> This fixes the build in clang > >> --- > >>

Re: [Mesa-dev] [PATCH 13/16] anv/image: Add support for modifiers for WSI

On 14 February 2018 at 17:58, Jason Ekstrand wrote: > I've added the following to the top of wsi_create_native_image: > > + /* If we don't support modifiers, the winsys code shouldn't be asking > for > +* an image with modifiers. > +*/ > +

Re: [Mesa-dev] [PATCH 2/2] anv/pipeline: Set the correct binding count for compute shaders

On Wednesday, February 14, 2018 8:28:54 AM PST Jason Ekstrand wrote: > On Tue, Feb 13, 2018 at 11:06 PM, Kenneth Graunke > wrote: > > > On Monday, February 12, 2018 7:35:05 PM PST Jason Ekstrand wrote: > > > --- > > > src/intel/vulkan/genX_pipeline.c | 2 +- > > > 1 file

Re: [Mesa-dev] [PATCH 13/16] anv/image: Add support for modifiers for WSI

On Wed, Feb 14, 2018 at 8:35 AM, Daniel Stone wrote: > On 14 February 2018 at 16:21, Jason Ekstrand wrote: > > On Wed, Feb 14, 2018 at 4:13 AM, Daniel Stone > wrote: > >> Suggested fixup: https://hastebin.com/zaheyoriwa > >> >

Re: [Mesa-dev] [PATCH 12/16] anv/image: Separate modifiers from legacy scanout

On Wed, Feb 14, 2018 at 9:42 AM, Ville Syrjälä < ville.syrj...@linux.intel.com> wrote: > On Wed, Feb 14, 2018 at 04:43:15PM +, Daniel Stone wrote: > > On 14 February 2018 at 16:27, Jason Ekstrand > wrote: > > > On Wed, Feb 14, 2018 at 3:39 AM, Daniel Stone

Re: [Mesa-dev] [PATCH 2/2] st: add NIR GL_ARB_get_program_binary support

For the series: Reviewed-by: Marek Olšák Marek On Tue, Feb 13, 2018 at 4:27 AM, Timothy Arceri wrote: > --- > src/mesa/state_tracker/st_context.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 12/16] anv/image: Separate modifiers from legacy scanout

On Wed, Feb 14, 2018 at 04:43:15PM +, Daniel Stone wrote: > On 14 February 2018 at 16:27, Jason Ekstrand wrote: > > On Wed, Feb 14, 2018 at 3:39 AM, Daniel Stone wrote: > >> > On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone >

Re: [Mesa-dev] [PATCH] radeonsi/nir: fix si_nir_load_tcs_varyings() for outputs

Reviewed-by: Marek Olšák Marek On Wed, Feb 14, 2018 at 2:22 AM, Timothy Arceri wrote: > We were incorrectly using the input info for outputs. > --- > src/gallium/drivers/radeonsi/si_shader.c | 13 +++-- > 1 file changed, 11 insertions(+), 2

Re: [Mesa-dev] [PATCH] ac: implement nir_intrinsic_image_samples

Reviewed-by: Marek Olšák Marek On Tue, Feb 13, 2018 at 7:01 AM, Timothy Arceri wrote: > Fixes cts test: > KHR-GL45.shader_texture_image_samples_tests.image_functional_test > --- > src/amd/common/ac_nir_to_llvm.c | 23 +++ > 1

  1   2   >