Re: [Mesa-dev] [PATCH 1/2] spirv: allow specialization constants with bitsize different than 32 bits

This patch is Reviewed-by: Ian Romanick On 11/20/2017 10:25 PM, Samuel Iglesias Gonsálvez wrote: > Signed-off-by: Samuel Iglesias Gonsálvez > --- > src/compiler/spirv/spirv_to_nir.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/compiler/spirv/spirv_to_nir.c > b/src/compiler/spi

Re: [Mesa-dev] [PATCH 2/2] spirv: fix bug when OpSpecConstantOp calls a conversion

On 11/20/2017 10:25 PM, Samuel Iglesias Gonsálvez wrote: > In that case, nir_eval_const_opcode() will evaluate the conversion > but as it was using destination's bit_size, the resulting > value was just a cast of the source constant value. By passing the > source's bit size, it does the conversion

[Mesa-dev] [PATCH 4/6] radeonsi: add a workaround for blending with DCC and MSAA

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index dea4d46..4eee778 100644 --- a/src/gallium/dr

[Mesa-dev] [PATCH 3/6] radeonsi: clear PIPE_IMAGE_ACCESS_WRITE when it's invalid to be on the safe side

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index 69371ea..471c93a 100644 --- a/src/gallium/drivers/radeonsi/si_descr

[Mesa-dev] [PATCH 2/6] ac/surface: enable DCC computation for MSAA

From: Marek Olšák --- src/amd/common/ac_surface.c | 6 ++ src/amd/vulkan/radv_image.c | 3 ++- src/gallium/drivers/radeon/r600_texture.c | 3 ++- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface

[Mesa-dev] [PATCH 0/6] RadeonSI DCC for MSAA on VI

Hi, This series enables DCC for MSAA on VI. MSAA array textures don't enable DCC because the fast clear would be slightly more complicated. GFX9 doesn't enable DCC for MSAA at all, because the only way to do fast clear is to use a compute shader and manual DCC addressing. Please review. Thanks,

[Mesa-dev] [PATCH 1/6] radeonsi: fix layered DCC fast clear

From: Marek Olšák Cc: 17.2 17.3 --- src/gallium/drivers/radeon/r600_texture.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index 3fa5f5e..933a4a9 100644 --- a/src/gallium/drivers/ra

[Mesa-dev] [PATCH 6/6] radeonsi: enable DCC with MSAA for VI

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 2 ++ src/gallium/drivers/radeon/r600_pipe_common.h | 3 +++ src/gallium/drivers/radeon/r600_texture.c | 4 +++- src/gallium/drivers/radeonsi/si_pipe.c| 5 + src/gallium/drivers/radeonsi/si_state.c | 3 ++

[Mesa-dev] [PATCH 5/6] radeonsi: implement fast color clear for DCC with MSAA for VI

From: Marek Olšák --- src/gallium/drivers/radeon/r600_texture.c | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index 0c30b62..139f735 100644 --- a/src/gall

[Mesa-dev] [PATCH 05/23] radeonsi: clean up si_do_fast_color_clear parameters

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_clear.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_clear.c b/src/gallium/drivers/radeonsi/si_clear.c index d99947f..29e63c7 100644 --- a/src/gallium/drivers/radeonsi/s

[Mesa-dev] [PATCH 00/24] RadeonSI huge cleanup

Hi, Most of this series deals with the dissolution of the drivers/radeon directory, but this is just one small iteration of that. Patch 7 should be the only functional change and it's an optimization. Please review. Thanks, Marek ___ mesa-dev mailin

[Mesa-dev] [PATCH 03/23] radeonsi: move r600_test_dma.c into si_test_dma.c

From: Marek Olšák --- src/gallium/drivers/radeon/Makefile.sources| 1 - src/gallium/drivers/radeon/r600_pipe_common.h | 3 --- src/gallium/drivers/radeonsi/Makefile.sources | 1 + src/gallium/drivers/radeonsi/meson.build | 1 + src/gallium/drivers/radeonsi/si_pipe

[Mesa-dev] [PATCH 01/23] radeonsi: move all clear() code into si_clear.c

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 13 +- src/gallium/drivers/radeon/r600_texture.c | 547 +-- src/gallium/drivers/radeonsi/Makefile.sources | 1 + src/gallium/drivers/radeonsi/meson.build | 1 + src/gallium/drivers/radeonsi/si_bli

[Mesa-dev] [PATCH 02/23] radeonsi: move si_pipe_clear_buffer into si_cp_dma.c

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c | 61 src/gallium/drivers/radeonsi/si_cp_dma.c | 61 2 files changed, 61 insertions(+), 61 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_blit.c b/src/gal

[Mesa-dev] [PATCH 07/23] radeonsi: don't use fast color clear for small surfaces

From: Marek Olšák This removes 35+ clear eliminate passes from DOTA 2. --- src/gallium/drivers/radeonsi/si_clear.c | 17 + 1 file changed, 17 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_clear.c b/src/gallium/drivers/radeonsi/si_clear.c index 00589ca..4663fc2 1006

[Mesa-dev] [PATCH 04/23] radeonsi: remove r600_common_context::clear_buffer

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 11 --- src/gallium/drivers/radeon/r600_pipe_common.h | 4 src/gallium/drivers/radeonsi/si_cp_dma.c | 1 - src/gallium/drivers/radeonsi/si_pipe.c| 6 +++--- src/gallium/drivers/radeonsi/si_test_dma

[Mesa-dev] [PATCH 09/23] radeonsi: just include si_pipe.h in r600_query.c

From: Marek Olšák --- src/gallium/drivers/radeon/Makefile.am | 1 + src/gallium/drivers/radeon/r600_query.c | 9 +++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/radeon/Makefile.am b/src/gallium/drivers/radeon/Makefile.am index 7f64b76..d557092 10064

[Mesa-dev] [PATCH 12/23] radeonsi: move/remove ac_shader_binary helpers

From: Marek Olšák --- src/amd/common/ac_binary.c| 13 + src/amd/common/ac_binary.h| 1 + src/gallium/drivers/radeon/r600_pipe_common.c | 22 -- src/gallium/drivers/radeon/r600_pipe_common.h | 3 --- src/gallium/drivers/rad

[Mesa-dev] [PATCH 13/23] radeonsi: remove more functions from r600_pipe_common.c

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 31 --- src/gallium/drivers/radeon/r600_pipe_common.h | 2 -- src/gallium/drivers/radeonsi/si_hw_context.c | 6 -- 3 files changed, 4 insertions(+), 35 deletions(-) diff --git a/src/gallium/driv

[Mesa-dev] [PATCH 16/23] radeonsi: set all pipe buffer functions in r600_buffer_common.c

From: Marek Olšák --- src/gallium/drivers/radeon/r600_buffer_common.c | 48 +++-- src/gallium/drivers/radeon/r600_pipe_common.c | 19 -- src/gallium/drivers/radeon/r600_pipe_common.h | 19 +++--- src/gallium/drivers/radeonsi/si_pipe.c | 3 +- 4 files

[Mesa-dev] [PATCH 17/23] radeonsi: document our vendor string situation

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_get.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/si_get.c index 9d38636..56030f7 100644 --- a/src/gallium/drivers/radeonsi/si_get.c +++ b/src/gallium/drivers/ra

[Mesa-dev] [PATCH 15/23] radeonsi/uvd: don't call ws->query_info

From: Marek Olšák --- src/gallium/drivers/radeon/radeon_uvd.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_uvd.c b/src/gallium/drivers/radeon/radeon_uvd.c index 3e060e2..cd58c66 100644 --- a/src/gallium/drivers/radeon/rade

[Mesa-dev] [PATCH 21/23] radeonsi: remove r600_pipe_common::barrier_flags::compute_to_L2

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 5 - src/gallium/drivers/radeon/r600_query.c | 2 +- src/gallium/drivers/radeonsi/si_pipe.c| 2 -- 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.h

[Mesa-dev] [PATCH 06/23] radeonsi: unify code setting dirty_level_mask for fast clear

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_clear.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_clear.c b/src/gallium/drivers/radeonsi/si_clear.c index 29e63c7..00589ca 100644 --- a/src/gallium/drivers

[Mesa-dev] [PATCH 10/23] radeonsi: remove R600_CONTEXT_* flags

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 7 - src/gallium/drivers/radeon/r600_query.c | 2 +- src/gallium/drivers/radeonsi/si_hw_context.c | 2 +- src/gallium/drivers/radeonsi/si_pipe.h| 32 +-- src/gallium/dr

Re: [Mesa-dev] [PATCH 00/24] RadeonSI huge cleanup

Oh and BTW, there is no patch 24 (typo). Marek On Tue, Nov 28, 2017 at 10:38 PM, Marek Olšák wrote: > Hi, > > Most of this series deals with the dissolution of the drivers/radeon > directory, but this is just one small iteration of that. > > Patch 7 should be the only functional change and it's

[Mesa-dev] [PATCH 23/23] r300, r600, radeonsi: replace RADEON_FLUSH_* with PIPE_FLUSH_*

From: Marek Olšák and handle PIPE_FLUSH_HINT_FINISH in r300. --- src/gallium/drivers/r300/r300_blit.c| 2 +- src/gallium/drivers/r300/r300_flush.c | 7 --- src/gallium/drivers/r300/r300_query.c | 2 +- src/gallium/drivers/r300/r300_render.c | 2 +-

[Mesa-dev] [PATCH 08/23] radeonsi: remove some definitions and helpers from r600_pipe_common.h

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 102 -- src/gallium/drivers/radeonsi/si_blit.c| 6 +- src/gallium/drivers/radeonsi/si_clear.c | 2 +- src/gallium/drivers/radeonsi/si_compute.c | 9 +- src/gallium/dr

[Mesa-dev] [PATCH 11/23] radeonsi: move all get functions to si_get.c; disk_cache_create to si_pipe.c

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 411 + src/gallium/drivers/radeonsi/Makefile.sources | 1 + src/gallium/drivers/radeonsi/meson.build | 1 + src/gallium/drivers/radeonsi/si_get.c | 852 ++ src/gallium/drive

[Mesa-dev] [PATCH 19/23] radeonsi: move shader debug helpers out of r600_pipe_common.c

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 11 --- src/gallium/drivers/radeon/r600_pipe_common.h | 4 src/gallium/drivers/radeonsi/si_compute.c | 2 +- src/gallium/drivers/radeonsi/si_pipe.h | 13 + src/gall

[Mesa-dev] [PATCH 18/23] radeonsi: dismantle si_common_screen_init/destroy

From: Marek Olšák --- src/amd/common/ac_gpu_info.c | 55 + src/amd/common/ac_gpu_info.h | 1 + src/gallium/drivers/radeon/r600_pipe_common.c | 154 -- src/gallium/drivers/radeon/r600_pipe_common.h | 3 - src/gallium/drivers/r

[Mesa-dev] [PATCH 20/23] radeonsi: remove query/apply_opaque_metadata callbacks

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.h | 8 -- src/gallium/drivers/radeon/r600_texture.c | 110 -- src/gallium/drivers/radeonsi/si_state.c | 98 --- 3 files changed, 102 insertions(+), 114 deletions(-) diff --

[Mesa-dev] [PATCH 14/23] radeonsi: move video queries into si_get.c

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 6 -- src/gallium/drivers/radeon/radeon_video.c | 149 - src/gallium/drivers/radeon/radeon_video.h | 14 +-- src/gallium/drivers/radeonsi/si_get.c | 150 +- 4

Re: [Mesa-dev] [PATCH 00/24] RadeonSI huge cleanup

Patch 22 is too large and you can find it here: https://cgit.freedesktop.org/~mareko/mesa/commit/?h=master&id=201f43780ba1d0bd3b99936799b6bc35798e1185 Whole series: https://cgit.freedesktop.org/~mareko/mesa/log/?h=master Marek On Tue, Nov 28, 2017 at 10:40 PM, Marek Olšák wrote: > Oh and BTW, t

Re: [Mesa-dev] [PATCH 00/24] RadeonSI huge cleanup

Strange, I hoped this one appears on Patchwork, but there is 'only' a newer old one with 23 pieces... https://patchwork.freedesktop.org/series/2283/ But your former of today 'RadeonSI DCC for MSAA on VI' is still, there. Greetings, Dieter Am 28.11.2017 22:38, schrieb Marek Olšák: Hi, Most

[Mesa-dev] [PATCH 01/14] meson: Combine gallium target subdirs

So that state trackers, targets, and special winsys requirements are all in a single if statement. This is a cosmetic only cleanup with no functional changes. Signed-off-by: Dylan Baker --- src/gallium/meson.build | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git

[Mesa-dev] [PATCH 02/14] meson: sort gallium drivers after winsys

This is a requirement of the next patch. Since meson does not have forward declarations, and we're going to define the driver dependencies in the drivers folder they need to be after the winsys so that the winsys libs are defined first. Signed-off-by: Dylan Baker --- src/gallium/meson.build | 16

[Mesa-dev] [PATCH 12/14] meson: build gallium va state tracker

Signed-off-by: Dylan Baker --- meson.build | 41 +- meson_options.txt | 13 ++ src/gallium/meson.build | 7 ++- src/gallium/state_trackers/va/meson.build | 39 + src/gallium/targets/va/mes

[Mesa-dev] [PATCH 03/14] meson: define driver dependencies

This allow us to encapsulate the compiler and linkage requirements of each driver in a reusable way. The result will be that each target that needs a specific driver can simply add `driver_` to its dependencies line and the necessary libraries and compiler args will be added. This will allow for a

[Mesa-dev] [PATCH 05/14] meson: Use driver dependencies for libgl-xlib target

Signed-off-by: Dylan Baker --- src/gallium/targets/libgl-xlib/meson.build | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/gallium/targets/libgl-xlib/meson.build b/src/gallium/targets/libgl-xlib/meson.build index 825b7b4a0f1..c7e51a0f26d 100644 --- a/src/gal

[Mesa-dev] [PATCH 04/14] meson: use the driver dependencies for the gallium dri target

Signed-off-by: Dylan Baker --- src/gallium/targets/dri/meson.build | 126 1 file changed, 26 insertions(+), 100 deletions(-) diff --git a/src/gallium/targets/dri/meson.build b/src/gallium/targets/dri/meson.build index 323b337266f..42033a16211 100644 --- a/sr

[Mesa-dev] [PATCH 00/14] meson: most of gallium

This series is the gallium media state trackers, the "nine" Direct3D state tracker, and an architectural change in the way gallium drivers are linked into the final targets. This architectural change results in a good deal of code savings, as well as ensuring that generated targets are generated b

[Mesa-dev] [PATCH 06/14] meson: use driver_deps for gallium osmesa

Signed-off-by: Dylan Baker --- src/gallium/targets/osmesa/meson.build | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/gallium/targets/osmesa/meson.build b/src/gallium/targets/osmesa/meson.build index 72f77724e44..e8e8e4822d8 100644 --- a/src/gallium/targets

[Mesa-dev] [PATCH 13/14] meson: build gallium xa state tracker

Signed-off-by: Dylan Baker --- meson.build | 22 meson_options.txt | 7 src/gallium/meson.build | 7 +++- src/gallium/state_trackers/xa/meson.build | 45 +++ src/gallium/targets/xa/meso

[Mesa-dev] [PATCH 09/14] meson: build gallium vdpau state tracker

Signed-off-by: Dylan Baker --- meson.build | 46 +- meson_options.txt| 13 + src/gallium/meson.build | 7 ++- src/gallium/state_trackers/vdpau/meson.build | 32 + src/gallium/targets

[Mesa-dev] [PATCH 08/14] meson: drop gallium-media argument

This argument is the wrong approach for handling gallium media state trackers, since it doesn't allow for an auto option. Instead we'll use tristates, which do allow for auto. This option has never been wired to anything anyway. Signed-off-by: Dylan Baker Reviewed-by: Eric Engestrom --- meson.

[Mesa-dev] [PATCH 07/14] meson: extend install_megadrivers script to handle symmlinking

Which is required for the gallium media state trackers. Signed-off-by: Dylan Baker Reviewed-by: Eric Engestrom --- bin/install_megadrivers.py | 8 1 file changed, 8 insertions(+) diff --git a/bin/install_megadrivers.py b/bin/install_megadrivers.py index a98d7dd177b..587a1f6726d 100755

[Mesa-dev] [PATCH 11/14] meson: build gallium omx state tracker

Signed-off-by: Dylan Baker --- meson.build| 60 +- meson_options.txt | 13 + src/gallium/meson.build| 7 ++- .../state_trackers/omx_bellagio/meson.build| 30 ++

[Mesa-dev] [PATCH 10/14] meson: build gallium xvmc state tracker

Signed-off-by: Dylan Baker --- meson.build | 40 +- meson_options.txt | 13 ++ src/gallium/meson.build | 7 +++- src/gallium/state_trackers/xvmc/meson.build | 53 +++ src/gallium

[Mesa-dev] [PATCH 14/14] meson: build gallium nine state_tracker

Signed-off-by: Dylan Baker --- include/meson.build| 8 ++ meson.build| 17 +++- meson_options.txt | 12 +++ src/gallium/meson.build| 7 +- .../gallium/state_track

Re: [Mesa-dev] [PATCH 09/23] radeonsi: just include si_pipe.h in r600_query.c

Quoting Marek Olšák (2017-11-28 13:38:37) > From: Marek Olšák > > --- > src/gallium/drivers/radeon/Makefile.am | 1 + > src/gallium/drivers/radeon/r600_query.c | 9 +++-- > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/src/gallium/drivers/radeon/Makefile.am > b/src/gal

Re: [Mesa-dev] [PATCH 0/3] OpenGL 3.1 with ARB_compatibility

For some reason I did not see this in my inbox until your other series hit. There's something weird going on with my procmail filters, so I'll just blame that. I think this hits all the bits that I was worried about for at least OpenGL 3.1. Series is Reviewed-by: Ian Romanick On 10/21/2017 05

[Mesa-dev] [PATCH 3/3] aubinator: add support for aubinating memtrace aubs

Memtrace aubs are similar to classic aubs, with the major difference being how command submission is serialized (as register writes instead of a high-level submit message). Some internal tools generate or consume only memtrace aubs. --- src/intel/tools/aubinator.c | 117 +++

[Mesa-dev] [PATCH 1/3] aubinator: honor --color option when printing the header

--- src/intel/tools/aubinator.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 48d4456cc1..f1ad3a948b 100644 --- a/src/intel/tools/aubinator.c +++ b/src/intel/tools/aubinator.c @@ -837,6 +837,8 @@ handle_tra

[Mesa-dev] [PATCH 2/3] aubinator: extract aubinator_init() out of the header handler function

A later patch will use the aubinator_init() function from the memtrace aub header handler. --- src/intel/tools/aubinator.c | 39 +++ 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index f

Re: [Mesa-dev] [PATCH] i965: Listen to BRW_NEW_*_PROGRAM in L3 state atom.

It would be helpful to add a /* BRW_NEW_*_PROGRAM */ comment to get_pipeline_state_l3_weights. With that, Reviewed-by: Jason Ekstrand On Wed, Nov 15, 2017 at 1:29 PM, Kenneth Graunke wrote: > This looks at prog->*. You don't get to do that unless you listen to > BRW_NEW_*_PROGRAM, which is a

[Mesa-dev] [PATCH 4/6] i965: Reorganize batch/state BO fields into a 'brw_growing_bo' struct.

We're about to add more of them, and need to pass the whole lot of them around together when growing them. Putting them in a struct makes this much easier. brw->batch.batch.bo is a bit of a mouthful, but it's nice to have things labeled 'batch' and 'state' now that we have multiple buffers. Fixe

[Mesa-dev] [PATCH 1/6] i965: Don't grow batch/state buffer on every emit after an overflow.

Once we reach the intended size of the buffer (BATCH_SZ or STATE_SZ), we try and flush. If we're not allowed to flush, we resort to growing the buffer so that there's space for the data we need to emit. We accidentally got the threshold wrong. The first non-wrappable call beyond (e.g.) STATE_SZ

[Mesa-dev] [PATCH 5/6] i965: Avoid problems from referencing orphaned BOs after growing.

Growing the batch/state buffer is a lot more dangerous than I thought. A number of places emit multiple state buffer sections, and then write data to the returned pointer, or save a pointer to brw->batch.state.bo and then use it in relocations. If each call can grow, this can result in stale map

[Mesa-dev] [PATCH 6/6] i965: Add some batchbuffer debugging code.

Uncommenting these blocks stress tests the batch/state growth code by trying to "grow" a buffer to the same size at least once per batch. When anything goes wrong with this code, dumping the validation list is a useful way to figure out what's happening. --- src/mesa/drivers/dri/i965/intel_batchb

[Mesa-dev] [PATCH 3/6] i965: Preserve EXEC_OBJECT_CAPTURE when growing the BO.

The original state buffer was marked with EXEC_OBJECT_CAPTURE. When growing it, we want to preserve that flag so we continue to capture it in GPU hang reports. Fixes: 2dfc119f22f257082ab0 "i965: Grow the batch/state buffers if we need space and can't flush." Bugzilla: https://bugs.freedesktop.or

[Mesa-dev] [PATCH 2/6] i965: Use old_bo->align when growing batch/state buffer instead of 4096.

The intention here is make the new BO use the same alignment as the old BO. This isn't strictly necessary, but we would have to update the 'alignment' field in the validation list when swapping it out, and we don't bother today. The batch and state buffers use an alignment of 4096, so this should

[Mesa-dev] [PATCH v2 01/32] vulkan/wsi: Add a wsi_image structure

From: Daniel Stone This is used to hold information about the allocated image, rather than an ever-growing function argument list. v2 (Jason Ekstrand): - Rename wsi_image_base to wsi_image Signed-off-by: Daniel Stone Reviewed-by: Jason Ekstrand --- src/amd/vulkan/radv_wsi.c | 31 +

[Mesa-dev] [PATCH v2 02/32] vulkan/wsi/x11: Handle the geometry check earlier in create_swapchain

This fixes a potential leak if allocating the swapchain fails. Since geometry checking and bit-depth fetching is self-contained, it makes sense to just do it first so we can delete the geometry reply. --- src/vulkan/wsi/wsi_common_x11.c | 19 ++- 1 file changed, 10 insertions(+),

[Mesa-dev] [PATCH v2 04/32] vulkan/wsi: Add wsi_swapchain_init/finish functions

--- src/vulkan/Makefile.sources | 1 + src/vulkan/wsi/meson.build | 1 + src/vulkan/wsi/wsi_common.c | 23 ++- src/vulkan/wsi/wsi_common.h | 1 + src/vulkan/wsi/wsi_common_private.h | 37 + src/vulkan/wsi/w

[Mesa-dev] [PATCH v2 00/32] vulkan/wsi: Rework WSI to look a lot more like a layer

This patch series is a v2 of the one I sent out a couple weeks ago to rewrite Vulkan window system integration. The original patch series can be found on patchwork here: https://patchwork.freedesktop.org/series/33961/ This series can be found as a git branch here: https://cgit.freedesktop.org/~

[Mesa-dev] [PATCH v2 08/32] anv/image: Add a drm_format_mod field

At the moment, this is always initialized to DRM_FORMAT_MOD_INVALID. --- src/intel/vulkan/anv_image.c | 2 ++ src/intel/vulkan/anv_private.h | 5 + 2 files changed, 7 insertions(+) diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c index 7e89f75..d986395 100644 --- a/s

[Mesa-dev] [PATCH v2 03/32] vulkan/wsi: Add a wsi_device_init function

This gives the opportunity to collect some function pointers if we'd like which will be very useful in future. --- src/amd/vulkan/radv_wsi.c | 10 +- src/intel/vulkan/anv_wsi.c | 11 ++- src/vulkan/Makefile.sources | 1 + src/vulkan/wsi/meson.build | 1 + src/vulkan/wsi/wsi_c

[Mesa-dev] [PATCH v2 12/32] radv: Move wsi initialization later in physical_device_init

We need it to happen after memory type setup so that we can query memory types in wsi_device_init. --- src/amd/vulkan/radv_device.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index b715014..e147cb8 1

[Mesa-dev] [PATCH v2 05/32] vulkan/wsi: Add a mock image creation extension

--- src/vulkan/wsi/wsi_common.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/vulkan/wsi/wsi_common.h b/src/vulkan/wsi/wsi_common.h index 15142f3..243bc6f 100644 --- a/src/vulkan/wsi/wsi_common.h +++ b/src/vulkan/wsi/wsi_common.h @@ -30,6 +30,24 @@ #include #includ

[Mesa-dev] [PATCH v2 10/32] anv/image: Implement the wsi "extension"

--- src/intel/vulkan/anv_device.c | 11 ++- src/intel/vulkan/anv_image.c | 30 +++--- 2 files changed, 37 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index d82d1f7..9b499b6 100644 --- a/src/intel/vulkan/

[Mesa-dev] [PATCH v2 14/32] vulkan/wsi: Do image creation in common code

This uses the mock extension created in a previous commit to tell the driver that the image it's just been asked to create is, in fact, a window system image with whatever assumptions that implies. There was a lot of redundant code between the two drivers to do basically exactly the same thing. --

[Mesa-dev] [PATCH v2 15/32] radv/wsi: drop allocate memory special case

From: Dave Airlie Just check if image has scanout flag set v2 (Jason Ekstrand): - Rebase - Also drop the now unused radv_mem_flag_bits enum --- src/amd/vulkan/radv_device.c | 16 ++-- src/amd/vulkan/radv_private.h | 10 -- 2 files changed, 6 insertions(+), 20 deletions(-)

[Mesa-dev] [PATCH v2 11/32] radv/image: Implement the wsi "extension"

--- src/amd/vulkan/radv_device.c | 6 ++ src/amd/vulkan/radv_image.c | 8 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 4517227..b715014 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/

[Mesa-dev] [PATCH v2 06/32] anv: Implement VK_EXT_external_memory_dma_buf

This is a modified version of the patch originally sent by Chad Versace. The primary difference is that this version claims that OPQAUE_FD and DMA_BUF are compatible handle types. --- src/intel/vulkan/anv_device.c | 13 ++--- src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan

[Mesa-dev] [PATCH v2 18/32] vulkan/wsi: Refactor result handling in queue_present

--- src/vulkan/wsi/wsi_common.c | 54 +++-- 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/src/vulkan/wsi/wsi_common.c b/src/vulkan/wsi/wsi_common.c index 5920359..f149846 100644 --- a/src/vulkan/wsi/wsi_common.c +++ b/src/vulkan/wsi/wsi_com

[Mesa-dev] [PATCH v2 13/32] vulkan/wsi: Implement prime in a completely generic way

--- src/amd/vulkan/radv_wsi.c | 137 +++ src/intel/vulkan/anv_wsi.c | 14 +- src/vulkan/wsi/wsi_common.c | 341 +++- src/vulkan/wsi/wsi_common.h | 54 +- src/vulkan/wsi/wsi_common_private.h | 16 ++ src/vulkan/ws

[Mesa-dev] [PATCH v2 21/32] anv/wsi: Use the common QueuePresent code

--- src/intel/vulkan/anv_wsi.c | 63 +- 1 file changed, 6 insertions(+), 57 deletions(-) diff --git a/src/intel/vulkan/anv_wsi.c b/src/intel/vulkan/anv_wsi.c index b654db9..4d9f7df 100644 --- a/src/intel/vulkan/anv_wsi.c +++ b/src/intel/vulkan/anv_wsi.c

[Mesa-dev] [PATCH v2 20/32] vulkan/wsi: Set a proper pWaitDstStageMask on the dummy submit

Neither mesa driver really cares, but we should set it none the less for the sake of correctness. --- src/vulkan/wsi/wsi_common.c | 17 + 1 file changed, 17 insertions(+) diff --git a/src/vulkan/wsi/wsi_common.c b/src/vulkan/wsi/wsi_common.c index 4f6648f..e5a9a28 100644 --- a/src

[Mesa-dev] [PATCH v2 16/32] vulkan/wsi: Add a WSI_FROM_HANDLE macro

--- src/vulkan/wsi/wsi_common.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vulkan/wsi/wsi_common.h b/src/vulkan/wsi/wsi_common.h index a5e7e65..229d398 100644 --- a/src/vulkan/wsi/wsi_common.h +++ b/src/vulkan/wsi/wsi_common.h @@ -177,6 +177,9 @@ struct wsi_callbacks { retur

[Mesa-dev] [PATCH v2 17/32] radv/wsi: Move the guts of QueuePresent to wsi common

From: Dave Airlie v2 (Jason Ekstrand): - Better comit message - Rebase - Re-indent to follow wsi_common style - Drop the unneeded _swapchain from the newly added helper - Make the clone more true to the original (as per the rebase) --- src/amd/vulkan/radv_wsi.c | 92 +++---

[Mesa-dev] [PATCH v2 07/32] radv: Implement VK_EXT_external_memory_dma_buf

--- src/amd/vulkan/radv_device.c | 8 ++-- src/amd/vulkan/radv_extensions.py | 1 + src/amd/vulkan/radv_formats.c | 8 ++-- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 8e5ae0b..4517227 100644 ---

[Mesa-dev] [PATCH v2 09/32] anv: Require a dedicated allocation for modified images

This lets us set the BO tiling when we allocate the memory. This is required for GL to work properly. --- src/intel/vulkan/anv_device.c | 53 +++ 1 file changed, 49 insertions(+), 4 deletions(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan

[Mesa-dev] [PATCH v2 26/32] vulkan/wsi: Add a helper for AcquireNextImage

Unfortunately, due to the fact that AcquireNextImage does not take a queue, the ANV trick for triggering the fence won't work in general. We leave dealing with the fence up to the caller for now. --- src/amd/vulkan/radv_wsi.c | 15 ++- src/intel/vulkan/anv_wsi.c | 19 +++---

[Mesa-dev] [PATCH v2 32/32] radv: Implement VK_KHR_get_surface_capabilities2

The WSI core code does all the hard work. Just add the wrappers and turn it on. --- src/amd/vulkan/radv_extensions.py | 1 + src/amd/vulkan/radv_wsi.c | 26 ++ 2 files changed, 27 insertions(+) diff --git a/src/amd/vulkan/radv_extensions.py b/src/amd/vulkan/radv

[Mesa-dev] [PATCH v2 24/32] vulkan/wsi: Move prime blitting into queue_present

This lets us save a QueueSubmit and it also makes prime a lot less X11-specific. Also, it means we can only wait on the semaphores once instead of on every blit. --- src/vulkan/wsi/wsi_common.c | 41 + src/vulkan/wsi/wsi_common.h | 5 ++--- src

[Mesa-dev] [PATCH v2 27/32] vulkan/wsi: Move wsi_swapchain to wsi_common_private.h

The drivers no longer poke at this directly. --- src/vulkan/wsi/wsi_common.h | 46 + src/vulkan/wsi/wsi_common_private.h | 46 + 2 files changed, 47 insertions(+), 45 deletions(-) diff --git a/src/vulkan/wsi/wsi_commo

[Mesa-dev] [PATCH v2 25/32] vulkan/wsi: move swapchain create/destroy to common code

From: Dave Airlie v2 (Jason Ekstrand): - Rebase - Alter the names of the helpers to better match the vulkan entrypoints - Use the helpers in anv --- src/amd/vulkan/radv_wsi.c | 42 -- src/intel/vulkan/anv_wsi.c | 35 +-

[Mesa-dev] [PATCH v2 30/32] vulkan/wsi: Drop some unneeded cruft from the API

This drops the unneeded callbacks struct as well as the queue_get_family callback we were using before we'd pulled QueuePresent inside. --- src/amd/vulkan/radv_wsi.c | 18 +- src/intel/vulkan/anv_wsi.c | 19 +-- src/vulkan/wsi/wsi_common.c

[Mesa-dev] [PATCH v2 23/32] vulkan/wsi: Move get_images into common code

This moves bits out of all four corners (anv, radv, x11, wayland) and into the wsi common code. We also switch to using an outarray to ensure we get our return code right. --- src/amd/vulkan/radv_wsi.c | 7 +++ src/intel/vulkan/anv_wsi.c | 7 +++ src/vulkan/wsi/wsi_co

[Mesa-dev] [PATCH v2 31/32] vulkan/wsi: Initialize individual WSI interfaces in wsi_device_init

Now that we have anv_device_init/finish functions, there's no reason to have the individual driver do any more work than that. --- src/amd/vulkan/radv_wsi.c | 36 ++-- src/intel/vulkan/anv_wsi.c | 36 ++-- src/vulka

[Mesa-dev] [PATCH v2 28/32] vulkan/wsi: Drop the can_handle_different_gpu parameter from get_support

Both anv and radv can handle prime now. --- src/amd/vulkan/radv_wsi.c | 2 +- src/intel/vulkan/anv_wsi.c | 2 +- src/vulkan/wsi/wsi_common.h | 1 - src/vulkan/wsi/wsi_common_wayland.c | 1 - src/vulkan/wsi/wsi_common_x11.c | 5 - 5 files changed, 2 insertions(+),

[Mesa-dev] [PATCH v2 29/32] vulkan/wsi: Add wrappers for all of the surface queries

This lets us move wsi_interface to wsi_common_private.h --- src/amd/vulkan/radv_wsi.c | 41 ++-- src/intel/vulkan/anv_wsi.c | 51 +++- src/vulkan/wsi/wsi_common.c | 77 + src/vulkan/wsi/wsi_common.h

[Mesa-dev] [PATCH v2 19/32] vulkan/wsi: Only wait on semaphores on the first swapchain

--- src/vulkan/wsi/wsi_common.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/vulkan/wsi/wsi_common.c b/src/vulkan/wsi/wsi_common.c index f149846..4f6648f 100644 --- a/src/vulkan/wsi/wsi_common.c +++ b/src/vulkan/wsi/wsi_common.c @@ -541,9 +541,14 @@ wsi_common_q

[Mesa-dev] [PATCH v2 22/32] anv/wsi: Enable prime support

Now that we're using the same common code as radv, we get prime support for free. Just enable it. --- src/intel/vulkan/anv_wsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_wsi.c b/src/intel/vulkan/anv_wsi.c index 4d9f7df..975ad18 100644 --- a/src/inte

[Mesa-dev] [PATCH 2/3] meson: Add lmsensors support

Signed-off-by: Dylan Baker --- meson.build | 11 +++ meson_options.txt | 7 +++ src/gallium/drivers/etnaviv/meson.build | 2 +- src/gallium/drivers/freedreno/meson.build | 1 + src/gallium/drivers/nouveau/meson.build | 2 +-

[Mesa-dev] [PATCH 1/3] meson: Add support for gallium extra hud

Signed-off-by: Dylan Baker --- meson.build | 4 meson_options.txt | 6 ++ 2 files changed, 10 insertions(+) diff --git a/meson.build b/meson.build index e2ba3cb0524..e3c201d7b87 100644 --- a/meson.build +++ b/meson.build @@ -916,6 +916,10 @@ if with_platform_x11 endif endif

[Mesa-dev] [PATCH 3/3] meson: use dep_thread instead of dependency('threads') in freedreno

They are the same thing, but this is more consistent with the rest of the project. Signed-off-by: Dylan Baker --- src/gallium/drivers/freedreno/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/meson.build b/src/gallium/drivers/freedre

Re: [Mesa-dev] [PATCH v2 00/32] vulkan/wsi: Rework WSI to look a lot more like a layer

On 29 November 2017 at 10:28, Jason Ekstrand wrote: > This patch series is a v2 of the one I sent out a couple weeks ago to > rewrite Vulkan window system integration. The original patch series can be > found on patchwork here: > > https://patchwork.freedesktop.org/series/33961/ > > This series c

[Mesa-dev] V3 i965/Gallium ARB_get_program_binary support

V3: This is basically the V2 that Jordan sent with feedback addressed, gallium support added, some minor functional changes such as only storing the default uniforms to either disk or program binary cache (rather than fixing them up later) and some refactoring to allow greater code sharing between

<    1   2   3   4   >