[mpd-devel] New developer mailing list

2014-01-20 Thread Max Kellermann
Hi, I've moved the developer mailing list from SourceForge to a new server. SourceForge has been a pain all the time, but has become completely unacceptable last year. All subscribers have been moved to the new server. List info: http://mailman.blarg.de/listinfo/mpd-devel New address: mpd-deve

Re: [mpd-devel] [Musicpd-dev-team] Music corruption when playing http://... WAV files - Analysis

2014-01-20 Thread Max Kellermann
On 2014/01/19 13:14, Marcello Desantis wrote: > when I try to play a WAV file streamed by a media server I get a corrupted > playback. The same file, retrieved with "curl -o ? http://?"; and played as a > local file works flawlessly. [...] > The problem itself is very simple: libsndfile needs th

Re: [mpd-devel] New developer mailing list

2014-01-20 Thread Max Kellermann
On 2014/01/20 22:28, Ben Boeckel wrote: > Could gmane.org[1] be updated with the new list address/info? Thanks. No, I don't have write access to gmane.org, and I'm not interested in this web site. Somebody who is can try to get it changed. ___ mpd-deve

Re: [mpd-devel] [PATCH] fixed leaked LocalDirectoryReader *const reader in UpdateWalk::UpdateDirectory

2014-02-06 Thread Max Kellermann
On 2014/02/06 23:02, geneticdrift wrote: > - LocalDirectoryReader *const reader = > - storage.OpenDirectory(directory.GetPath(), error); > - if (reader == nullptr) { > + const std::auto_ptr reader( > + storage.OpenDirectory(directory.GetPath(), error)); > +

Re: [mpd-devel] [PATCH] fixed possible format_context not closed in ffmpeg_decode

2014-02-07 Thread Max Kellermann
On 2014/02/07 11:54, geneticdrift wrote: > > --- > src/decoder/plugins/FfmpegDecoderPlugin.cxx |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Also merged. Please check your mail client, I had to manually repair both of your patches because whitespace got corrupted.

Re: [mpd-devel] Adding a key to my account

2014-02-08 Thread Max Kellermann
On 2014/02/09 07:19, Kaleb Elwert wrote: > I previously had an account on git.musicpd.org, but I don't have the keys > that are set up with it any more. Replaced. ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-deve

Re: [mpd-devel] Stop after playing

2014-02-16 Thread Max Kellermann
On 2014/02/17 05:13, Ben Boeckel wrote: > I've been having issues recently with my scripts where mpd will stop > after playing each song. It's a feature[tm]. You have enabled "single" mode. ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailma

Re: [mpd-devel] Stop after playing

2014-02-17 Thread Max Kellermann
On 2014/02/17 10:48, Chris Rees wrote: > is this a new feature? It was added 5 years ago in MPD 0.15. So, no, it's not a new feature. ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] random vs shuffle?

2014-02-20 Thread Max Kellermann
On 2014/02/20 09:50, Daniel Cartron wrote: > Sorry if i may seem stupid but i found nowhere any explanation about > the difference between random and shuffle. "shuffle" is a *command* that reorders the queue, and "random" is a *mode* that changes the way MPD chooses the next song. __

Re: [mpd-devel] random vs shuffle?

2014-02-20 Thread Max Kellermann
On 2014/02/20 10:40, Daniel Cartron wrote: > So if i want to listen only once each song of my playlist, i should > use shuffle and no random? And if i choose random and no shuffle i can > sometimes hear twice (or more) the same song before the end of the > list. No. MPD ensures that you hear

Re: [mpd-devel] move to

2014-02-21 Thread Max Kellermann
On 2014/02/21 12:26, Daniel Cartron wrote: > #!/bin/bash > DEFPLACE=1 > CURPLACE=$(mpc | grep '#' | sed -e 's/^[^#]\+#\([^/]\+\).*/\1/') > mpc move $CURPLACE $DEFPLACE mpc move `mpc current -f %position%` 1 ___ mpd-devel mailing list mpd-devel@musicpd.

Re: [mpd-devel] seek in AAC file

2014-02-23 Thread Max Kellermann
On 2014/02/23 19:21, Uwe Tantz wrote: > Hi, > here is a patch that allows for seeking in aac files. Please split this into separate documented patches. It is nearly impossible to review a patch consisting of many independent changes. For example, it is not clear why you delete the following str

Re: [mpd-devel] generic decoder

2014-02-28 Thread Max Kellermann
On 2014/02/28 17:22, mtm kmkz wrote: > If possible, I want to make an effort to merge it into master branch. > What do you think? No. I'm completely unimpressed by this idea. This will never work as well as "native" decoders. There will always be difficult problems. For example: - your code

Re: [mpd-devel] git.musicpd.org account

2014-03-04 Thread Max Kellermann
On 2014/03/04 15:13, Pete Beardmore wrote: > as per Max's suggestion, could I request access to push to 'mpd' and > (possibly) 'ncmpcpp' repositories. preferably i could create > throw-away branches for merging mods post code review, rather than > suffer the embarrassment of breaking master http:

Re: [mpd-devel] pull request

2014-03-05 Thread Max Kellermann
On 2014/03/05 18:26, Pete Beardmore wrote: > > hi, > > with Max Kellermann's excellent explanation and direction > (hand-holding).. please consider merging > > http://git.musicpd.org/cgit/elbeardmorez/mpd.git/commit/?h=pulse.thread.fix.2&id=9da57e7458ed2e539ba1693ca748c0e5c7969585 Merged, than

Re: [mpd-devel] Supported versions of OSX

2014-03-07 Thread Max Kellermann
On 2014/03/07 15:08, Michael Paquier wrote: > My first post on this ML, and with a simple question: what are the > versions of OSX officially supported by the latest version of mpd? > 10.6 is the oldest one? No OSX version is "supported" because there appears to be no developer who owns a Mac. H

Re: [mpd-devel] recent releases often stop to play

2014-03-14 Thread Max Kellermann
On 2014/03/14 16:12, Reindl Harald wrote: > please let me know if there is any info i can provide to help debug Report a bug on the bug tracker. This is the developer mailing list which is for developers, not a user support mailing list. ___ mpd-devel

Re: [mpd-devel] pull request: 'PulseOutputPlugin: support non-static output sinks'

2014-03-14 Thread Max Kellermann
On 2014/03/06 19:12, Pete Beardmore wrote: > i've recently started using my secondary (internal) sound card for > headphones output, and regularly move the mpd pulseaudio stream back > and forth between the two outputs > > the issue i have/had is that when a playlist contains files with > multipl

Re: [mpd-devel] pull request: 'MultipleOutputs: ensure input_audio_format is zero-initialised'

2014-03-14 Thread Max Kellermann
On 2014/03/09 21:08, Pete Beardmore wrote: > > [branch: 'init.paused.fix'] > > hi, > > this single commit fixes the SIGABRT i experience when: > > 1. state file contains 'state: pause' > 2. i start a new mpd instance Good catch, I've merged this. I changed this to be initialized with AudioFo

Re: [mpd-devel] pull request: 'PulseOutputPlugin: support non-static output sinks'

2014-03-15 Thread Max Kellermann
On 2014/03/15 18:51, Pete Beardmore wrote: > [multiple sighs]. verified, you're absolutely right yes, however, > the same issue would occur if a sink set in the config was removed, > hence it's an existing issue That's not a valid argument. If the user tells MPD to use a specific sink and then r

Re: [mpd-devel] pull request: 'PulseOutputPlugin: support non-static output sinks'

2014-03-15 Thread Max Kellermann
On 2014/03/15 23:49, Pete Beardmore wrote: > again i disagree. it seems pretty fundamental too, so maybe we've > just got slightly different ideas/expectations of what pulseaudio > support entails for a client It appears we can't resolve our opposing opinions. I disagree with everything you wrot

Re: [mpd-devel] mpd: .wav file and ffmpeg 2.1

2014-03-17 Thread Max Kellermann
On 2014/03/17 16:09, Ricky Xian <2006...@qq.com> wrote: > Hi, all, > > > As I try to use ffmpeg 2.1 with latest mpd 0.18.9, I found some issues below: > > > 1.) seeking function doesn't work, I found that av_seek_frame function should > be upgraded to avformat_seek_file, attached the patch. W

Re: [mpd-devel] mpd: .wav file and ffmpeg 2.1

2014-03-17 Thread Max Kellermann
On 2014/03/17 18:22, Ricky Xian <2006...@qq.com> wrote: > Hi, > > > Could you please advise the stable version of ffmpeg working with > mpd? See configure.ac: MPD_AUTO_PKG(ffmpeg, FFMPEG, [libavformat >= 53.17 libavcodec >= 53.25 libavutil >= 51.17], I don't have ffmpeg, as Debian ships with

Re: [mpd-devel] mpd: .wav file and ffmpeg 2.1

2014-03-18 Thread Max Kellermann
On 2014/03/18 02:19, Ricky Xian <2006...@qq.com> wrote: > Can you please have a simple test? Load a wav file, try to play and seek with > "mpc seek 20", and "mpc status". Thanks for your help! Works. [playing] #1/1 0:20/1:36 (20%) (Using libav 9.11) __

Re: [mpd-devel] mpd: .wav file and ffmpeg 2.1

2014-03-18 Thread Max Kellermann
On 2014/03/18 02:19, Ricky Xian <2006...@qq.com> wrote: > I think it's a issue of using ffmpeg Maybe you're right about this, but I believe your solution and all your assumptions are wrong. Check if commit 8e39cf62e7f84eca6f8b431bf721281d50653892 solves your problem. Your (undocumented!) patch s

Re: [mpd-devel] add .mpdrootignore fallback giving recursive ignore

2014-05-12 Thread Max Kellermann
On 2014/04/17 23:12, Maxime Daniel wrote: > Hi, > > Here is a patch I just made which add a .mpdrootignore on root directory. > How does it works ? This file a like a .mpdignore but only on music root > directory. This file is parsed and used only if a .mpdignore file is not > found (it's a fal

Re: [mpd-devel] [PATCH] mpc: allow to specify which playlist to print

2014-05-13 Thread Max Kellermann
On 2014/04/18 23:01, Consus wrote: > Hi guys, > > I was missing this feature so I wrote a simple patch to enhance mpc a > little. I think you may find it useful too. Merged. ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listi

Re: [mpd-devel] [ncmpc PATCH] Flush stdout to change xterm title.

2014-05-13 Thread Max Kellermann
On 2014/04/25 16:48, noname wrote: > If stdout is not flushed, printf may not terminate control string > properly. This way xterm title changes only sometimes. Merged. ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mp

Re: [mpd-devel] mpc: format string fixes

2014-05-13 Thread Max Kellermann
On 2014/05/11 23:51, Zev Weiss wrote: > Hello, > > The branch 'formatstrings' of git://github.com/zevweiss/mpc has two small > fixes for mpc's --format option, addressing mis-handling of format strings > ending in escape sequences and an inability to include literal bracket > characters. Merg

Re: [mpd-devel] mpd-website request pull

2014-06-20 Thread Max Kellermann
On 2014/06/20 13:11, kaliko wrote: > Hi, > > I've made some editing on mpd-website to add python modules. > > Please review, comment. > > see ref pythonlib : http://git.kaliko.me/?p=mpd-website.git Can't. "fatal: remote error: access denied or repository not exported: /mpd-website.git"

Re: [mpd-devel] mpd-website request pull

2014-06-20 Thread Max Kellermann
On 2014/06/20 13:35, kaliko wrote: > Le 20/06/2014 13:29, Max Kellermann a écrit : > > On 2014/06/20 13:11, kaliko wrote: > >> see ref pythonlib : http://git.kaliko.me/?p=mpd-website.git > > > > Can't. > > > > "fatal: remote error:

Re: [mpd-devel] Git Access "buggyct" as requested in IRC-Chat with cirrus

2014-06-27 Thread Max Kellermann
On 2014/06/27 17:38, buggy wrote: > I talked to cirrus (Max) in the IRC and would like to apply for git access. http://git.musicpd.org/cgit/buggyct/mpd.git/ ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Crossfade during song changes

2014-07-07 Thread Max Kellermann
On 2014/07/07 05:43, Igor Chernyshev wrote: > There's one feature that is important for a loud party music - automatic > cross-fading during song change. However, it seems to be missing in MPD: > 1. http://bugs.musicpd.org/view.php?id=1515 > 2. http://bugs.musicpd.org/view.php?id=3215 > 3. h

Re: [mpd-devel] [PATCH 0/4] gcc 4.9.x build fixes

2014-07-09 Thread Max Kellermann
On 2014/07/08 15:46, Gustavo Zacarias wrote: > These patches fix gcc 4.9.x build issues for the v0.18.x branch. > AudiofileDecoderPlugin & OpusDecoderPlugin use SEEK_* definitions, and > HttpdClient & PlsPlaylistPlugin use snprintf without including stdio.h All merged. ___

Re: [mpd-devel] Crossfade during song changes

2014-07-09 Thread Max Kellermann
On 2014/07/07 20:31, Igor Chernyshev wrote: > Hello Max, > > Could you help clarifying a few things for me: > > 1. What commit or git tag should I branch off for building MPD? The goal is > stability. Everybody likes stability, but that doesn't mean you should use the stable branch, it wouldn't

Re: [mpd-devel] [PATCH 0/3] gcc 4.9.x build fixes for master

2014-07-09 Thread Max Kellermann
On 2014/07/09 19:48, Gustavo Zacarias wrote: > These patches fix gcc 4.9.x build issues for the master branch. > FlacIOHandle uses SEEK_* definitions, and HttpdClient & > DespotifyPlaylistPlugin use snprintf without including stdio.h Merged, too. ___ mp

Re: [mpd-devel] [PATCH] Makefile.am: fix dependencies for win32

2014-08-01 Thread Max Kellermann
On 2014/08/01 22:07, François Revol wrote: > Instead we use EXTRA_src_mpd_DEPENDENCIES which is meant for this. Merged to v0.18.x ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] util: Fix header for strcasecmp

2014-08-15 Thread Max Kellermann
On 2014/08/15 21:22, François Revol wrote: > According to POSIX and both OSX and Linux manpages, > strcasecmp comes from strings.h, not string.h. > > Most OSes also have them available in string.h, > but we just fixed the headers on Haiku and it now > only provides them in strings.h. > > We migh

Re: [mpd-devel] mpc: Shell completion of files in subdirectories

2014-08-17 Thread Max Kellermann
On 2014/08/16 20:56, Kevin Locke wrote: > If this seems like a reasonable solution, I would be happy to provide > a patch. Yes, sounds reasonable. Max ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] OHU/OHM SongCast Stream Decoder

2014-08-28 Thread Max Kellermann
On 2014/08/28 21:49, Craig Tolley wrote: > Ok, not had any responses as yet I did reply to you. However, you only re-posted the same text until now. > 1.I am creating an Input Plugin, how do I tell MPD that ohu:// and > ohm:// are valid URIs? Somewhere I need to create the link between the

Re: [mpd-devel] aMPD: MPD on android

2014-08-29 Thread Max Kellermann
On 2014/08/29 12:35, Mike wrote: > Dude I just wanted to tell you how thankful I am that you ported mpd. I have > now turned an old android device into something useful thanks to your hard > work and you have been forever immortalized in my guide I put together for it > here http://www.htpcguid

Re: [mpd-devel] Debug connection for Win32

2014-08-30 Thread Max Kellermann
On 2014/08/31 05:36, zw g wrote: > Here is what i get from the command line after i set the log level to ' > *verbose*' on Windows 7: [...] Please use the forum for user support requests. This mailing list is for developers only. ___ mpd-devel mailing

Re: [mpd-devel] Git account

2014-09-22 Thread Max Kellermann
On 2014/09/22 16:07, Maxim Anisiutkin wrote: > I'd like to get git account for the SACD ISO plug-in project. By the moment > I have a working prototype of this plugin. I've never heard of this project. How is it related to MPD? Max ___ mpd-devel maili

Re: [mpd-devel] Git account

2014-09-22 Thread Max Kellermann
On 2014/09/22 16:07, Maxim Anisiutkin wrote: > I'd like to get git account for the SACD ISO plug-in project. By the moment > I have a working prototype of this plugin. http://git.musicpd.org/cgit/manisiutkin/mpd.git/ ___ mpd-devel mailing list mpd-devel

Re: [mpd-devel] Patches to support the MusicBrainz Release Track ID tag

2014-09-27 Thread Max Kellermann
On 2014/09/27 18:38, Wieland Hoffmann wrote: > the following two patches add support for the Release Track ID tag to > MPD and libmpdclient. This tag is a unique identifier for a specific > track on a release. The (similarly named) Track ID is not unique enough > to do that since there can be mult

Re: [mpd-devel] [PATCH] Add MPD_TAG_MUSICBRAINZ_RELEASETRACKID

2014-10-03 Thread Max Kellermann
Wieland, please check this bug report on your patch: http://bugs.musicpd.org/view.php?id=4132 ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Communicating over TLS

2014-10-03 Thread Max Kellermann
On 2014/10/04 05:05, Ben Boeckel wrote: > Has anyone tried communicating to the mpd server over SSL/TLS? Would > patches to do so be accepted? If so, is there a library preference > (OpenSSL, GnuTLS, etc.)? I have no interest in writing or maintaining TLS support, but if you do, and do it right (

Re: [mpd-devel] Communicating over TLS

2014-10-03 Thread Max Kellermann
On 2014/10/04 05:05, Ben Boeckel wrote: > If so, is there a library preference (OpenSSL, GnuTLS, etc.)? One more thing: I would prefer OpenSSL over GnuTLS any day. A few years ago, I had to switch a (daytime) project from GnuTLS to OpenSSL because GnuTLS was too bad. However: OpenSSL's license

Re: [mpd-devel] Communicating over TLS

2014-10-06 Thread Max Kellermann
On 2014/10/06 15:20, Ben Boeckel wrote: > Bleh. Only Debian really does this though, right? I think Red Hat and > Fedora both say that OpenSSL is part of the system and that's that > (similar to how the Microsoft C Runtime is "compatible"). Not sure what > other "major" binary distros say. That i

Re: [mpd-devel] Communicating over TLS

2014-10-06 Thread Max Kellermann
On 2014/10/06 22:34, Chris Rees wrote: > Hm, though aren't you the copyright holder? You could (if you > really wanted to) add an exception for OpenSSL in the licence. I'm one of a hundred copyright holders (I didn't even start the MPD project, in the first place). I cannot change the license,

Re: [mpd-devel] libicu

2014-10-14 Thread Max Kellermann
On 2014/10/14 11:37, Jörg Krause wrote: > Is there any good reason to favour libicu for collation instead of > glib? Yes. To get rid of GLib completely one day. ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Unicode collation [Was: libicu]

2014-10-18 Thread Max Kellermann
On 2014/10/17 07:48, Ian Zimmerman wrote: > This is a bit tangential, but are folks here aware of debian bug #698676 > [1] ? I filed it against the client (ncmpcpp) because I believed for > some reason that artist and album name sorting was done by the client. > Was I wrong? No idea, but in any

Re: [mpd-devel] Unicode collation [Was: libicu]

2014-10-19 Thread Max Kellermann
On 2014/10/19 03:12, Ian Zimmerman wrote: > The version I have installed now is 0.17.6, and the problem is still > present. MPD 0.17.6 has been out of support for a year. Now, would you please not send user support requests this mailing list? This is for developers only. ___

Re: [mpd-devel] Pull request for previously mangled patches

2014-10-24 Thread Max Kellermann
On 2014/10/18 16:48, Steven Newbury wrote: > [PATCH v3] Pulseaudio support for other sample formats What happens if probing fails? Previously, that could not happen, but now, the probe_formats list can exhaust, and you have no check for it. ___ mpd-dev

Re: [mpd-devel] [PATCH] Support S24_P32/S32/FLOAT sample formats on Pulse

2014-10-24 Thread Max Kellermann
On 2014/10/14 07:35, Ian Scott wrote: > + ss.format = PA_SAMPLE_FLOAT32NE; [...] > ss.format = PA_SAMPLE_S16NE; This cannot work. No matter what you write to ss.format, it will be overwritten right after the switch. But I like how simple this patch looks, compared to Steven's

Re: [mpd-devel] [PATCH] settings: add support for reading ~/.authinfo file

2014-10-24 Thread Max Kellermann
On 2014/10/15 17:09, Michal Nazarewicz wrote: > + goto next_line; Ugh! No. ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] patch for extra sox recipes in SoxrResampler.cxx

2014-10-24 Thread Max Kellermann
On 2014/10/25 02:01, Frederic Vanden Poel wrote: > please find my patch attached. Patch has no description. When you submit a patch, don't write ANY text in the email. If there is need for further explanation in the email body, it means there is not enough description in the patch file itself.

Re: [mpd-devel] Pull request for previously mangled patches

2014-10-25 Thread Max Kellermann
On 2014/10/25 22:21, Steven Newbury wrote: > I that case the sample spec will have PA_SAMPLE_INVALID as its format > type, which will cause the stream open to fail*. This can happen for > example if the sample rate is out of range for a given format, where > the pa_sample_spec_valid() will rej

[mpd-devel] Licensing conflict with libmp4v2

2014-11-02 Thread Max Kellermann
Hi Andree, the Debian project has found a licensing conflict between MPD and libmp4v2: http://bugs.debian.org/767504 Because you submitted the plugin to MPD, I'd like you to figure out a solution. As I wrote in reply to the Debian bug report, the plugin must be deleted from MPD (0.19.3) if the

Re: [mpd-devel] patch for extra sox recipes in SoxrResampler.cxx

2014-11-02 Thread Max Kellermann
On 2014/10/26 15:54, Frederic Vanden Poel wrote: > Here's a new version. Not sure how to properly format comments in the > heading lines of the patch, but the info should be > > "add new soxr recipes: libsamplerate equivalent SOXR_LSR0Q, SOXR_LSR1Q > and SOXR_LSR2Q" Now where's all the informati

Re: [mpd-devel] [PATCH] Main: fix compilation on OS X using non-Apple compilers

2014-11-10 Thread Max Kellermann
On 2014/11/11 04:38, Misty De Meo wrote: > Commit d42c0f1dc5063d50a62817b63a1c2a4507c46071 added an OS X-specific > method of calling mpd_main_after_fork(), which uses Grand Central > Dispatch. Since this uses a block literal, it breaks compilation on > compilers which don't support the block exte

Re: [mpd-devel] Small doc patch for mpc

2014-11-10 Thread Max Kellermann
On 2014/11/05 13:27, Michael Paquier wrote: > Hi all, > > While looking at the documentation of mpc, I found a small typo. Patch is > attached. > Thanks, Merged ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Updated/Added files listing

2014-11-13 Thread Max Kellermann
On 2014/11/12 05:18, Michael Blumenkrantz wrote: > Is there some way to get this info using the protocol? No, because MPD does not know, and it cannot possibly give information it doesn't have to clients. ___ mpd-devel mailing list mpd-devel@musicpd.or

Re: [mpd-devel] Hi! I'd like to contribute to MPD dev

2014-11-13 Thread Max Kellermann
On 2014/11/13 03:09, Ted Yin wrote: > Hi everyone, > > I???m a fanatic MPD user. Recently I???m interested in providing with extra > functionalities instead of solely using the software. My first try is to > write a client which triggers a command when MPD changes its state: > https://github.c

Re: [mpd-devel] patch for extra sox recipes in SoxrResampler.cxx

2014-11-14 Thread Max Kellermann
On 2014/11/11 18:02, Frederic Vanden Poel wrote: > Just saw the changelog, any idea when the extra sox recipes will be > integrated? I did not see a new patch that includes a description. ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.b

Re: [mpd-devel] MPD locked by state file

2014-11-22 Thread Max Kellermann
On 2014/11/22 15:38, Jörg Krause wrote: > I'm not sure how to handle this and I would be glad about any comment or > advice. What you described is expected behavior, and not a problem (you did not mention it being a problem). There is nothing to "handle". > I had a quick look at the sources of

Re: [mpd-devel] [PATCH] settings: add support for reading ~/.authinfo file

2014-11-28 Thread Max Kellermann
On 2014/11/29 02:02, Michal Nazarewicz wrote: > + static const char *filenames[] = { Missing "const". > + char *pwd = NULL, *path, *str; > + unsigned i; > + FILE *fd; Please declare variables where they are used. > + i = strlen(str); As you see here, "i" has the wrong type

Re: [mpd-devel] [Patch] Database proxy plugin: retry connection attempts at startup

2014-11-30 Thread Max Kellermann
On 2014/11/30 19:52, Piotr Koz??owski wrote: > Hi, > > I've written a patch that allows configurable number of attempts to connect > to remote MPD server if there are any errors. > > I'm running MPD proxy on a headless single board computer. It often happens > that the first connection attempt f

Re: [mpd-devel] [Patch] Database proxy plugin: retry connection attempts at startup

2014-11-30 Thread Max Kellermann
On 2014/11/30 20:20, Piotr Koz??owski wrote: > > Use of sleep() is unacceptable. > > Could you explain why? I've seen usage of usleep() in other parts of > the code - would it be better here? Otherwise what do you suggest? I'm > new to MPD development, so any advice is welcome. All uses of uslee

Re: [mpd-devel] [PATCHv3 1/2] settings: support service names in MPD_PORT variable

2014-12-01 Thread Max Kellermann
On 2014/12/01 15:00, Michal Nazarewicz wrote: > From: Michal Nazarewicz > > If $MPD_PORT is not a number, i.e. does not start with a digit, > attempt to resolve it using getservbyname, i.e. by reading the > /etc/services database. Build failure on Windows: src/settings.c:32:23: fatal error: ar

Re: [mpd-devel] [PATCH] Output: start with a null mixer.

2014-12-01 Thread Max Kellermann
On 2014/11/24 14:02, Nix wrote: > There are code paths (mostly error cases) in which it is possible to > initialize an AudioOutput and then kill it without ever calling > audio_output_new(). In such a case, its destructor will attempt to > free a mixer that was never initialized, leading to an at

Re: [mpd-devel] systemd and "zeroconf: No global port, disabling zeroconf"

2014-12-02 Thread Max Kellermann
On 2014/12/02 08:13, Punky wrote: > Since jessie now uses systemd instead of sysvinit, But does it enable socket activation by default? > listen_systemd_activation() is true. Then the function exit > immediately without setting listen_port = port. Correct. Which value do you expect it to have

Re: [mpd-devel] PATCH: Add support for configuration specified optional headers in HTTP output plugins

2014-12-02 Thread Max Kellermann
On 2014/12/02 14:05, X Ryl wrote: > As the subject says, this patch adds support for optional headers for > the HTTP output plugins. These headers are required for allowing cross > origin resource sharing (for one, but it can be used in reverse proxy > mode to identify the server sources). > This

Re: [mpd-devel] systemd and "zeroconf: No global port, disabling zeroconf"

2014-12-02 Thread Max Kellermann
On 2014/12/03 02:56, Punky wrote: > In zeroconf module, listen_port variable is used. listen_port variable > should be set to the value that MPD (successfully) listens to, and if TCP > port (default 6600) is being configured But listen_port is ignored when systemd socket activation is used. With

Re: [mpd-devel] systemd and "zeroconf: No global port, disabling zeroconf"

2014-12-03 Thread Max Kellermann
On 2014/12/03 16:49, Ben Boeckel wrote: > On Wed, Dec 03, 2014 at 08:17:39 +0100, Max Kellermann wrote: > > Thus, MPD currently does not enable zeroconf when socket activation is > > used, because MPD does not know what port to announce. > > Would getsockname(2) help? Yes,

Re: [mpd-devel] PATCH: Add support for configuration specified optional headers in HTTP output plugins

2014-12-03 Thread Max Kellermann
On 2014/12/03 17:00, X Ryl wrote: > I don't see a single whitespace change in this patch. I do. Proof: -# type"httpd" +# type "httpd" > Also, I didn't know what were the project policies, but the content of > the initial email is summed up in the commit messa

Re: [mpd-devel] [PATCHv4 1/2] settings: support service names in MPD_PORT variable

2014-12-03 Thread Max Kellermann
On 2014/12/03 21:13, Michal Nazarewicz wrote: > From: Michal Nazarewicz > > If $MPD_PORT is not a number, i.e. does not start with a digit, > attempt to resolve it using getservbyname, i.e. by reading the > /etc/services database. This now passes the build test, but I don't like how this adds u

Re: [mpd-devel] [PATCHv4 1/2] settings: support service names in MPD_PORT variable

2014-12-03 Thread Max Kellermann
On 2014/12/03 21:13, Michal Nazarewicz wrote: > From: Michal Nazarewicz > > If $MPD_PORT is not a number, i.e. does not start with a digit, > attempt to resolve it using getservbyname, i.e. by reading the > /etc/services database. One more thing: I'd like to know what is the point of this patch

Re: [mpd-devel] PATCH: Add support for configuration specified optional headers in HTTP output plugins

2014-12-03 Thread Max Kellermann
On 2014/12/03 22:00, X Ryl wrote: > Please find attached a new patch, with your other remarks fixed. How is this change related to your patch description? -# encoder "vorbis"# optional, vorbis or lame +# encoder "vorbis"# optional, vorbis

Re: [mpd-devel] PATCH: Add support for configuration specified optional headers in HTTP output plugins

2014-12-03 Thread Max Kellermann
On 2014/12/03 23:09, X Ryl wrote: > Actually, it's useful to clients but not only. In my use case, MPD is > on a headless server. Without it, it's not possible to receive this > stream in Javascript context due to Cross Origin protection in > browsers. That prevents using HTTPD plugin as a audio s

Re: [mpd-devel] Inotify setup on startup

2014-12-05 Thread Max Kellermann
On 2014/12/06 06:29, Andrej Falout wrote: > I am wondering, if there is anything I can do to speed this up, or if this > setup function could be moved into a separate thread perhaps - so that it > does not block startup? Nothing can be done to speed this up, because that's how inotify was designe

Re: [mpd-devel] [PATCH 2/2] decoder/plugins/FfmpegDecoderPlugin.cxx: remove uint8_t cast

2014-12-07 Thread Max Kellermann
On 2014/12/07 22:40, Jörg Krause wrote: > This patch fix a build error with FFmpeg 2.5. But it breaks the build with older versions. That is not acceptable, because many MPD users will not upgrade ffmpeg right now. ___ mpd-devel mailing list mpd-devel@

Re: [mpd-devel] [PATCH 1/2] thread/Id.hxx: fix musl build error

2014-12-08 Thread Max Kellermann
On 2014/12/07 22:40, Jörg Krause wrote: > This patch fix a build error with the musl C library. The patch is originally > taken from Alpine Linux: > http://git.alpinelinux.org/cgit/aports/tree/main/mpd/fix-musl.patch. > > musl declares pthread_equal both as a macro and as a function. Without the

Re: [mpd-devel] [PATCH 1/2] thread/Id.hxx: fix musl build error

2014-12-08 Thread Max Kellermann
On 2014/12/09 00:10, Ben Boeckel wrote: > On Mon, Dec 08, 2014 at 22:14:16 +0100, Jörg Krause wrote: > > FYI: This is the statement of a musl maintainer about this issue: > > http://www.openwall.com/lists/musl/2014/12/08/15 > > That is???unfortunate. Macros are basically evil and with this kind o

Re: [mpd-devel] [PATCH 1/2] thread/Id.hxx: fix musl build error

2014-12-09 Thread Max Kellermann
On 2014/12/09 17:06, Ben Boeckel wrote: > On Tue, Dec 09, 2014 at 07:21:47 +0100, Max Kellermann wrote: > > This is C code, while the former is NOT C code - it escapes from the > > "raw" C language into the preprocessor language. My version is > > type-safe. A

Re: [mpd-devel] Tags from Input plugins

2014-12-14 Thread Max Kellermann
On 2014/12/15 00:14, Pizzocel wrote: > Hi, > > I'm trying to write an input plugin. It determines the content of the > tag at the time the stream is opened. I thought, the tag should then be > delivered as the result of the first call to ReadTag. Subsequent calls > should return nullptr, as the t

Re: [mpd-devel] Build error w/libavutil 52.3.0

2014-12-23 Thread Max Kellermann
On 2014/12/23 06:47, Jan Brittenson wrote: > Cloned the git master (last commit 7f3fecbdf581faf7e98135d5cac535dee6faedf5) > and when building get the > following error with libavutil 52.3.0 installed: > > make all-am > make[1]: Entering directory `/home/bson/src/mpd' > g++ -DHAVE_CONFIG_H -I.

Re: [mpd-devel] DSF ID3 tags hitting 4k size limit

2014-12-23 Thread Max Kellermann
On 2014/12/23 07:26, Jan Brittenson wrote: > Here???s a change to dynamically allocate the DSD ID3 tag buffer. Pretty > much anything with cover art > is going to exceed the existing, static 4k limit... Here???s a change to > dynamically allocate the buffer and > sanity check it at some upper

Re: [mpd-devel] git account request (fixed)

2014-12-23 Thread Max Kellermann
On 2014/12/21 22:06, Michael Van Buren wrote: > real name: Michael Van Buren > email: mike...@gmx.com > user: mikevb1 > projects: mpc > public ssh key attached http://git.musicpd.org/cgit/mikevb1/mpc.git/ ___ mpd-devel mailing list mpd-devel@musicpd.org

Re: [mpd-devel] Build error w/libavutil 52.3.0

2014-12-24 Thread Max Kellermann
On 2014/12/24 08:46, Jan Brittenson wrote: > Fix: always include both libavutil/mem.h and libavcodec/avcodec.h regardless > of whether we have > av_fast_malloc or avcodec.h or not. But why include libavcodec/avcodec.h when none of its symbols is used?

Re: [mpd-devel] Build error w/libavutil 52.3.0

2014-12-24 Thread Max Kellermann
On 2014/12/24 22:13, Jan Brittenson wrote: > > But why include libavcodec/avcodec.h when none of its symbols is used? > > avcodec.h declares av_fast_malloc() and av_fast_realloc(). No. Only older versions do. Recent versions move these functions to libavutil. That's why there's the #ifdef. __

Re: [mpd-devel] [PATCH] Fixing the systemd service file against systemd>205

2015-01-01 Thread Max Kellermann
On 2015/01/01 18:30, Reventlov wrote: > Hello. > Since Systemd 205, the low-level cgroup configuration options > ControlGroup= and ControlGroupAttribute= have been removed. > > Relevant upstream changelog: > http://lists.freedesktop.org/archives/systemd-devel/2013-July/011679.html > > Thoses opti

Re: [mpd-devel] [PATCH] Fixing the systemd service file against systemd>205

2015-01-01 Thread Max Kellermann
On 2015/01/01 20:02, Reindl Harald wrote: > >Thoses options should be disabled. Preserving the pre-systemd > >205 behavior toward realtime is behind my scope, but I think it can be > >achieved by using (I guess) IOSchedulingClass > > Nice=-10 No, that's also wrong. Even if it were right - it wo

Re: [mpd-devel] [PATCH] Fixing the systemd service file against systemd>205

2015-01-01 Thread Max Kellermann
On 2015/01/01 20:04, Reindl Harald wrote: > it has nothing to do with systemd itself, it's just about upstream kernel > and re-design of cgroups Yes it does. A systemd feature was removed, and this is what Reventlov's patch is about. What you're trying to do is talk about the reasons the system

Re: [mpd-devel] [PATCHv4 2/2] settings: add support for reading ~/.authinfo file

2015-01-12 Thread Max Kellermann
On 2015/01/13 06:20, Avuton Olrich wrote: > Was this ever committed? No. I asked a question that was left unreplied, therefore I never returned to this patch. ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] PATCH : Add option to set cache size of libcdio_paranoia

2015-01-14 Thread Max Kellermann
On 2014/12/28 18:05, Vincent Mussard wrote: > Dear all > > Here is a little patch that add an option "cache_size" to the cdio_paranoia > plugin. > This option set the libcdio_paranoia cache size (in sector), which is by > default very high (1200 sectors == 16 seconds). > On my setup (raspberry pi

Re: [mpd-devel] [PATCH] doc/protocol.xml: Fix a typo

2015-01-14 Thread Max Kellermann
Merged. ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Fwd: mpc diff - mpc git diff

2015-01-15 Thread Max Kellermann
On 2015/01/15 22:03, Alexander Hall wrote: > Fix use-after-free in mpc / cmd_seek() Merged, thanks. ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Fwd: mpc diff - mpc git diff

2015-01-15 Thread Max Kellermann
On 2015/01/15 22:44, Alexander Hall wrote: > Is that extra hyphen intentional or a typo? D'oh. It's a ty-po ;) ___ mpd-devel mailing list mpd-devel@musicpd.org http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] thread/Name: include stdio.h for prctl as well

2015-01-26 Thread Max Kellermann
On 2015/01/26 14:42, Gustavo Zacarias wrote: > We're still using snprintf so we need it, otherwise it leads to build > failure. This one has been fixed already in the stable branch, but it has not yet been merged to master. Thanks anyway for trying to help. __

  1   2   3   >