Re: [PATCH 11/11] iscsi: force destroy sesions when a network namespace exits

2023-04-12 Thread Hannes Reinecke
On 4/11/23 20:19, Chris Leech wrote: On Tue, Apr 11, 2023 at 08:21:22AM +0200, Hannes Reinecke wrote: On 4/10/23 21:10, Chris Leech wrote: The namespace is gone, so there is no userspace to clean up. Force close all the sessions. This should be enough for software transports, there's

Re: [RFC PATCH 5/9] iscsi: set netns for iscsi_tcp hosts

2023-04-11 Thread Hannes Reinecke
On 4/11/23 02:21, Chris Leech wrote: On Tue, Mar 14, 2023 at 05:29:25PM +0100, Hannes Reinecke wrote: On 2/8/23 18:40, Lee Duncan wrote: From: Lee Duncan This lets iscsi_tcp operate in multiple namespaces. It uses current during session creation to find the net namespace, but it might

Re: [RFC PATCH 4/9] iscsi: make all iSCSI netlink multicast namespace aware

2023-04-11 Thread Hannes Reinecke
122 ++-- 1 file changed, 79 insertions(+), 43 deletions(-) Thanks a lot! That's precisely what I had been looking for. But you really shouldn't have mentioned iSCSI offloads; that was too large an opening to _not_ comment on :-) Cheers, Hannes -- Dr. Hannes ReineckeKernel Stor

Re: [PATCH 11/11] iscsi: force destroy sesions when a network namespace exits

2023-04-11 Thread Hannes Reinecke
, 18 insertions(+) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev

Re: [PATCH 10/11] iscsi: make session and connection lists per-net

2023-04-11 Thread Hannes Reinecke
insertions(+), 43 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg

Re: [RFC PATCH 9/9] iscsi: filter flashnode sysfs by net namespace

2023-03-14 Thread Hannes Reinecke
| 4 2 files changed, 34 insertions(+), 4 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an emai

Re: [RFC PATCH 8/9] iscsi: rename iscsi_bus_flash_* to iscsi_flash_*

2023-03-14 Thread Hannes Reinecke
++-- include/scsi/scsi_transport_iscsi.h | 48 ++--- 3 files changed, 102 insertions(+), 100 deletions(-) Can be merged with the previous patch, but otherwise: Reviewed-by: Hannes Reinecke Cheers, Hannes -- You received this message because you are subscribed

Re: [RFC PATCH 7/9] iscsi: convert flashnode devices from bus to class

2023-03-14 Thread Hannes Reinecke
-by: Hannes Reinecke Cheers, Hannes -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To view this discussion

Re: [RFC PATCH 6/9] iscsi: check net namespace for all iscsi lookup

2023-03-14 Thread Hannes Reinecke
/scsi/scsi_transport_iscsi.h | 5 +- 8 files changed, 149 insertions(+), 87 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiv

Re: [RFC PATCH 5/9] iscsi: set netns for iscsi_tcp hosts

2023-03-14 Thread Hannes Reinecke
On 2/8/23 18:40, Lee Duncan wrote: From: Lee Duncan This lets iscsi_tcp operate in multiple namespaces. It uses current during session creation to find the net namespace, but it might be better to manage to pass it along from the iscsi netlink socket. And indeed, I'd rather use the

Re: [RFC PATCH 4/9] iscsi: make all iSCSI netlink multicast namespace aware

2023-03-14 Thread Hannes Reinecke
printk(KERN_WARNING "Send reply failed, error %d\n", err); As discussed with Lee: you should tear down sessions related to this namespace from the pernet ->exit callback, otherwise you end up with session which can no longer been reached as the netlink soc

Re: [RFC PATCH 3/9] iscsi: sysfs filtering by network namespace

2023-03-14 Thread Hannes Reinecke
in the iscsi_cls_host structure. Signed-off-by: Chris Leech Signed-off-by: Lee Duncan --- drivers/scsi/scsi_transport_iscsi.c | 124 include/scsi/scsi_transport_iscsi.h | 1 + 2 files changed, 110 insertions(+), 15 deletions(-) Reviewed-by: Hannes Reinecke Cheers

Re: [RFC PATCH 2/9] iscsi: associate endpoints with a host

2023-03-14 Thread Hannes Reinecke
On 2/8/23 18:40, Lee Duncan wrote: From: Lee Duncan Right now the iscsi_endpoint is only linked to a connection once that connection has been established. For net namespace filtering of the sysfs objects, associate an endpoint with the host that it was allocated for when it is created.

Re: [RFC PATCH 1/9] iscsi: create per-net iscsi netlink kernel sockets

2023-03-14 Thread Hannes Reinecke
On 2/8/23 18:40, Lee Duncan wrote: From: Lee Duncan Prepare iSCSI netlink to operate in multiple namespaces. Signed-off-by: Chris Leech Signed-off-by: Lee Duncan Reviewed-by: Hannes Reinecke Cheers, Hannes -- You received this message because you are subscribed to the Google Groups

Re: [RFC 0/9] Make iscsid-kernel communications namespace-aware

2023-03-14 Thread Hannes Reinecke
On 2/8/23 18:40, Lee Duncan wrote: From: Lee Duncan This is a request for comment on a set of patches that modify the kernel iSCSI initiator communications so that they are namespace-aware. The goal is to allow multiple iSCSI daemon (iscsid) to run at once as long as they are in separate

Re: [PATCH 24/24] osst: add a SPDX tag to osst.c

2019-05-03 Thread Hannes Reinecke
On 5/2/19 9:55 PM, Willem Riede wrote: On Thu, May 2, 2019 at 7:19 AM Hannes Reinecke <mailto:h...@suse.de>> wrote: On 5/2/19 2:53 PM, Christoph Hellwig wrote: > On Thu, May 02, 2019 at 08:06:38AM +0200, Hannes Reinecke wrote: >> On 5/1/19 6:14 PM, Chris

Re: [PATCH 24/24] osst: add a SPDX tag to osst.c

2019-05-02 Thread Hannes Reinecke
On 5/2/19 2:53 PM, Christoph Hellwig wrote: On Thu, May 02, 2019 at 08:06:38AM +0200, Hannes Reinecke wrote: On 5/1/19 6:14 PM, Christoph Hellwig wrote: osst.c is the only osst file missing licensing information. Add a GPLv2 tag for the default kernel license. Signed-off-by: Chriosstoph

Re: [PATCH 24/24] osst: add a SPDX tag to osst.c

2019-05-02 Thread Hannes Reinecke
. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürn

Re: [PATCH 22/24] sr: add a SPDX tag to sr.c

2019-05-02 Thread Hannes Reinecke
/sr.c index 039c27c2d7b3..701d1e68d86e 100644 --- a/drivers/scsi/sr.c +++ b/drivers/scsi/sr.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * sr.c Copyright (C) 1992 David Giller * Copyright (C) 1993, 1994, 1995, 1999 Eric Youngdale Reviewed-by: Hannes Reinecke Cheers

Re: [PATCH 23/24] st: add a SPDX tag to st.c

2019-05-02 Thread Hannes Reinecke
-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) -- You rece

Re: [PATCH 20/24] ses: switch to SPDX tags

2019-05-02 Thread Hannes Reinecke
Software -** Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. -** -**- -*/ + */ #include #include Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage

Re: [PATCH 21/24] sg: switch to SPDX tags

2019-05-02 Thread Hannes Reinecke
later version. - * */ static int sg_version_num = 30536; /* 2 digits for each component */ Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX

Re: [PATCH 18/24] sd: add a SPDX tag to sd.c

2019-05-02 Thread Hannes Reinecke
/sd.c index 2b2bc4b49d78..4852c2223359 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0 /* * sd.c Copyright (C) 1992 Drew Eckhardt * Copyright (C) 1993, 1994, 1995, 1999 Eric Youngdale Reviewed-by: Hannes Reinecke

Re: [PATCH 19/24] sd: switch remaining files to SPDX tags

2019-05-02 Thread Hannes Reinecke
(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürn

Re: [PATCH 16/24] libsas: switch sas_ata.[ch] to SPDX tags

2019-05-02 Thread Hannes Reinecke
. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 - * USA */ #include Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes

Re: [PATCH 17/24] libsas: switch remaining files to SPDX tags

2019-05-02 Thread Hannes Reinecke
changed, 12 insertions(+), 193 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer,

Re: [PATCH 15/24] libsas: add a SPDX tag to sas_task.c

2019-05-02 Thread Hannes Reinecke
Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) -

Re: [PATCH 14/24] libiscsi: switch to SPDX tags

2019-05-02 Thread Hannes Reinecke
+ include/scsi/iscsi_proto.h| 13 + include/scsi/libiscsi.h | 15 +-- include/scsi/libiscsi_tcp.h | 13 + include/scsi/scsi_bsg_iscsi.h | 16 +--- 7 files changed, 7 insertions(+), 91 deletions(-) Reviewed-by: Hannes Reinecke

Re: [PATCH 12/24] libfc: switch to SPDX tags

2019-05-02 Thread Hannes Reinecke
/fc_fip.h | 14 +- include/scsi/fc/fc_ms.h | 17 +++-- include/scsi/libfc.h | 14 +- 17 files changed, 19 insertions(+), 222 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage

Re: [PATCH 13/24] libfcoe: switch to SPDX tags

2019-05-02 Thread Hannes Reinecke
| 14 +- drivers/scsi/fcoe/fcoe_sysfs.c | 14 +- drivers/scsi/fcoe/fcoe_transport.c | 14 +- include/scsi/libfcoe.h | 14 +- 6 files changed, 6 insertions(+), 78 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr

Re: [PATCH 10/24] scsi_transport_srp: switch to SPDX tags

2019-05-02 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_transport_srp.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) Reviewed-by: Hannes Reinecke Cheers

Re: [PATCH 11/24] libfc: remove duplicate GPL boilerplate text

2019-05-02 Thread Hannes Reinecke
/scsi/fc/fc_gs.h | 13 - include/uapi/scsi/fc/fc_ns.h | 13 - 4 files changed, 52 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053

Re: [PATCH 08/24] scsi_transport_sas: switch to SPDX tags

2019-05-02 Thread Hannes Reinecke
On 5/1/19 6:14 PM, Christoph Hellwig wrote: Use the the GPLv2 SPDX tag instead of a free form blurb. Signed-off-by: Christoph Hellwig --- drivers/scsi/scsi_transport_sas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes

Re: [PATCH 09/24] scsi_transport_spi: switch to SPDX tags

2019-05-02 Thread Hannes Reinecke
(+), 28 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah

Re: [PATCH 07/24] scsi_transport_iscsi: switch to SPDX tags

2019-05-02 Thread Hannes Reinecke
insertions(+), 28 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Ra

Re: [PATCH 06/24] scsi_transport_fc: switch to SPDX tags

2019-05-02 Thread Hannes Reinecke
insertions(+), 34 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Ra

Re: [PATCH 05/24] scsi_transport_fc: remove duplicate GPL boilerplate text

2019-05-02 Thread Hannes Reinecke
--- 2 files changed, 30 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendör

Re: [PATCH 04/24] scsi_transport.h: switch to SPDX tags

2019-05-02 Thread Hannes Reinecke
On 5/1/19 6:13 PM, Christoph Hellwig wrote: Use the the GPLv2+ SPDX tag instead of verbose boilerplate text. Signed-off-by: Christoph Hellwig --- include/scsi/scsi_transport.h | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) Reviewed-by: Hannes Reinecke Cheers

Re: [PATCH 03/24] scsi_netlink: remove duplicate GPL boilerplate text

2019-05-01 Thread Hannes Reinecke
Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) -- You rece

Re: [PATCH 02/24] scsi: switch the remaining scsi midlayer files to use SPDX tags

2019-05-01 Thread Hannes Reinecke
insertions(+), 16 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins,

Re: [PATCH 01/24] scsi: add SPDX tags to scsi midlayer files missing licensing information

2019-05-01 Thread Hannes Reinecke
+ drivers/scsi/scsi_error.c | 1 + drivers/scsi/scsi_ioctl.c | 1 + drivers/scsi/scsi_lib.c | 1 + drivers/scsi/scsi_pm.c | 1 + drivers/scsi/scsi_sysfs.c | 1 + 8 files changed, 8 insertions(+) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke

Re: [4.10, panic, regression] iscsi: null pointer deref at iscsi_tcp_segment_done+0x20d/0x2e0

2016-12-24 Thread Hannes Reinecke
want to head to; I might be able to work on this start of January. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer,

Re: RFC: iscsid shutdown hangs with system when service manually killed

2016-11-22 Thread Hannes Reinecke
On 11/21/2016 06:41 PM, Lee Duncan wrote: > >> On Nov 21, 2016, at 6:14 AM, Hannes Reinecke <h...@suse.de >> <mailto:h...@suse.de>> wrote: >> >> On 11/19/2016 08:46 PM, The Lee-Man wrote: >>> In this wonderful new world of systemd, I have an

Re: RFC: iscsid shutdown hangs with system when service manually killed

2016-11-21 Thread Hannes Reinecke
omesuch, indicating that the socket isn't present. The socket _is_ present, it's just not sending any responses back. Attached is a patch for open-iscsi to use 'poll()' before recv(), and terminating it if we didn't get a response in time. This doesn't do anything from the mention

Re: [PATCH 1/3] scsi_transport_iscsi: Add stats support for iscsi host

2016-04-24 Thread Hannes Reinecke
s submitting patches. > > I can see why the get stats approach is nasty, because it is difficult > to extend. If we want to go sysfs based approach then we should probably > make it more like the other transports where there is a stats dir and a > reset admin file. > > Lee

Re: [PATCH] remove sysfs attr_list

2016-03-02 Thread Hannes Reinecke
On 03/01/2016 04:27 PM, Ferenc Wágner wrote: > Hannes Reinecke <h...@suse.de> writes: > >> On 02/29/2016 10:58 PM, Bart Van Assche wrote: >> >>> On 02/28/16 23:59, Hannes Reinecke wrote: >>> >>>> libudev has a _massive_ static memory fo

Re: [PATCH] remove sysfs attr_list

2016-02-29 Thread Hannes Reinecke
On 02/29/2016 10:58 PM, Bart Van Assche wrote: > On 02/28/16 23:59, Hannes Reinecke wrote: >> libudev has a _massive_ static memory footprint >> (Kay doesn't believe in memory allocation). >> So when using libudev you might end up having a really large memory >> footpr

Re: DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers)

2015-09-17 Thread Hannes Reinecke
something. Seems like a topic for KS; Johannes had a larger patchset recently to clean up idr, which run into very much the same issues. Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, M

[PATCH] firmware: ACPI iBFT firmware support on EFI machines

2015-06-10 Thread Hannes Reinecke
The iBFT firmware tables can also be specified via ACPI tables when using EFI firmware. The 'iscsi_ibft_find' module is only for legacy X86 BIOS, so it needs to be skipped for all other architectures. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/firmware/Kconfig | 2 +- 1 file changed

Re: [RFC PATCH 0/4] Make iSCSI network namespace aware

2015-05-21 Thread Hannes Reinecke
to be running in a system. Cheers, Hannes -- Dr. Hannes ReineckezSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG

Re: [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-07 Thread Hannes Reinecke
for iscsi/TCP but then I've figured my network implementation knowledge doesn't spread that far. So yeah, a discussion here would be good. Mike? Any comments? Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX

Re: [PATCH] Allow modifications for iface.gateway and iface.subnet_mask

2014-02-01 Thread Hannes Reinecke
On 02/01/2014 06:37 AM, Mike Christie wrote: On 1/29/14 4:19 AM, Hannes Reinecke wrote: For proper operations we need to set gateway and subnet_mask of the individual interfaces. Not every target is connected to the local network. Signed-off-by: Hannes Reinecke h...@suse.de --- usr/idbm.c

[PATCH] Allow modifications for iface.gateway and iface.subnet_mask

2014-01-29 Thread Hannes Reinecke
For proper operations we need to set gateway and subnet_mask of the individual interfaces. Not every target is connected to the local network. Signed-off-by: Hannes Reinecke h...@suse.de --- usr/idbm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/usr/idbm.c b/usr/idbm.c index 1ade099

[PATCH] Add missing DESTDIR

2014-01-29 Thread Hannes Reinecke
From: Lee Duncan ldun...@suse.com Several Makefile targets are missing DESTDIR, making it hard for packagers. Signed-off-by: Lee Duncan ldun...@suse.com Signed-off-by: Hannes Reinecke h...@suse.de --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b

Re: [PATCHv2 0/3] iscsiuio: Update autoconf

2014-01-29 Thread Hannes Reinecke
On 01/29/2014 07:27 PM, Eddie Wai wrote: The patchset works great on my system. Forcing an autoreconf and untrack all autogen files makes sense. Thanks for the work. Although I would be more inclined to put all .gitignore entries into a single .gitignore file in the trunk, separating them

Re: Multipath or not ?

2013-03-13 Thread Hannes Reinecke
On 03/12/2013 11:30 PM, Mike Christie wrote: On 03/12/2013 08:11 AM, Guillaume wrote: Hello Mike On 12 mar, 02:54, Mike Christie micha...@cs.wisc.edu wrote: On 03/09/2013 05:58 AM, Guillaume wrote: Hello, I have a virtual tape library and a iscsi SAN. All have multiple ethernet

Re: [PATCH] Do not run configure for open-isns on every build

2011-10-11 Thread Hannes Reinecke
On 10/11/2011 05:05 AM, Mike Christie wrote: On 10/07/2011 09:09 AM, Hannes Reinecke wrote: We only need to run configure in open-isns if either the configure script or Makefile.in has changed. Otherwise it's perfectly okay just to call a plain 'make' here. Signed-off-by: Hannes Reineckeh

[PATCH] Do not run configure for open-isns on every build

2011-10-07 Thread Hannes Reinecke
We only need to run configure in open-isns if either the configure script or Makefile.in has changed. Otherwise it's perfectly okay just to call a plain 'make' here. Signed-off-by: Hannes Reinecke h...@suse.de diff --git a/Makefile b/Makefile index 8dd64c7..de7ef65 100644 --- a/Makefile +++ b

Re: iscsi_sysfs_read_iface

2011-07-27 Thread Hannes Reinecke
On 07/26/2011 09:44 PM, Mike Christie wrote: On 07/26/2011 01:38 AM, Hannes Reinecke wrote: Hi Eddie, you beat me to it ... On 07/26/2011 02:28 AM, Eddie Wai wrote: Hello Mike, The following snippet from the 39d4ceb04f051c208ae7509d268a3871ffa194c5 commit is preventing bnx2i from being able

Re: iscsi_sysfs_read_iface

2011-07-26 Thread Hannes Reinecke
; any offloading engine _not_ listing the initiatorname as a host attribute will fail. Not nice. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J

Re: [PATCH 4/8] Keep startup mode in sync when specified in config file

2011-06-28 Thread Hannes Reinecke
On 06/28/2011 06:44 AM, Mike Christie wrote: On 06/21/2011 04:23 AM, Hannes Reinecke wrote: When the startup mode has been specified in iscsid.conf it needs to be kept in sync for both settings, 'node.startup' and 'node.conn[0].startup'. References: bnc#458142 Signed-off-by: Hannes Reineckeh

Re: [PATCH 1/8] ibft scanning fails on newer kernels

2011-06-22 Thread Hannes Reinecke
On 06/21/2011 11:39 PM, Mike Christie wrote: On 06/21/2011 04:23 AM, Hannes Reinecke wrote: Newer kernels provide the 'net' link as a directory, instead of the 'net:XX' link with previous kernels. The sysfs scanning code has enablement to work with this, but the directory lookup doesn't work

[PATCH] iscsid sends SIGTERM to PID 0

2011-06-21 Thread Hannes Reinecke
handler installed, for which the internal pid is always '0'. So when a SIGTERM is send to the logging thread, it'll forward the signal to PID 0. References: bnc#589064 Signed-off-by: Hannes Reinecke h...@suse.de diff --git a/usr/iscsid.c b/usr/iscsid.c index 50c9b58..2e234fc 100644 --- a/usr/iscsid.c

[PATCH 0/8] SUSE SLES resync

2011-06-21 Thread Hannes Reinecke
from my local tree and they won't apply properly. Hannes Reinecke (8): ibft scanning fails on newer kernels iscsid sends SIGTERM to PID 0 iscsid: Implement --no-pid-file Keep startup mode in sync when specified in config file Allow LOCK_DIR to be set via CFLAGS Allow 'onboot' as loginall

[PATCH 1/8] ibft scanning fails on newer kernels

2011-06-21 Thread Hannes Reinecke
Newer kernels provide the 'net' link as a directory, instead of the 'net:XX' link with previous kernels. The sysfs scanning code has enablement to work with this, but the directory lookup doesn't work properly. References: bnc#561596 Signed-off-by: Hannes Reinecke h...@suse.de --- utils

[PATCH 2/8] iscsid sends SIGTERM to PID 0

2011-06-21 Thread Hannes Reinecke
handler installed, for which the internal pid is always '0'. So when a SIGTERM is send to the logging thread, it'll forward the signal to PID 0. References: bnc#589064 Signed-off-by: Hannes Reinecke h...@suse.de --- usr/iscsid.c | 16 usr/log.c|6 -- 2 files changed, 12

[PATCH 3/8] iscsid: Implement --no-pid-file

2011-06-21 Thread Hannes Reinecke
For root on iSCSI scenarios the /var directory might not exist. And we don't need the pid file anyway as the daemon is synchronized via the IPC connection. Signed-off-by: Hannes Reinecke h...@suse.de --- doc/iscsid.8 |3 +++ usr/iscsid.c | 40 2

[PATCH 5/8] Allow LOCK_DIR to be set via CFLAGS

2011-06-21 Thread Hannes Reinecke
For root on iSCSI we have to move idbm's LOCK_DIR to eg /etc/iscsi, as the /var directory might not be available. So make it configurable during compile-time. Signed-off-by: Hannes Reinecke h...@suse.de --- usr/initiator.h |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff

[PATCH 6/8] Allow 'onboot' as loginall parameter

2011-06-21 Thread Hannes Reinecke
We are using to 'onboot' parameter to setup iscsi connections in the initrd. Thus we should be able to use 'onboot' as a valid parameter for loginall, too. References: 449108 Signed-off-by: Hannes Reinecke h...@suse.de --- usr/iscsiadm.c | 19 +-- 1 files changed, 5 insertions

[PATCH 7/8] Update SUSE init script

2011-06-21 Thread Hannes Reinecke
Rework the iSCSI shutdown logic to tear down the block device stack correctly. Signed-off-by: Hannes Reinecke h...@suse.de --- etc/initd/initd.suse | 452 +++--- 1 files changed, 354 insertions(+), 98 deletions(-) diff --git a/etc/initd/initd.suse b

[PATCH 8/8] boot.suse: Update with latest fixes

2011-06-21 Thread Hannes Reinecke
Include latest fixes from SUSE. Signed-off-by: Hannes Reinecke h...@suse.de --- etc/initd/boot.suse | 35 +++ 1 files changed, 15 insertions(+), 20 deletions(-) diff --git a/etc/initd/boot.suse b/etc/initd/boot.suse index df64e21..ac6abcc 100644 --- a/etc/initd

Re: Kernel NULL pointer dereference [when using iser]

2011-03-28 Thread Hannes Reinecke
for iscsi nowadays, Hannes, is that still you? If and when customer escalations leave me some leeway to move, yes, that'll be me. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5

Re: iscsiadm: discovery record not found

2011-02-23 Thread Hannes Reinecke
QA :-( ) don't see a reason why should draw a blank here. So after long hours of debugging I came up with this patch, which resolves the hostname into the IP address and uses this for lookup. Mike, comments? Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de

iSCSI connection errors with SLES10 SP3 update

2010-12-20 Thread Hannes Reinecke
. Sorry about this. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) -- You received this message because you are subscribed

Re: iSCSI connection errors with SLES10 SP3 update

2010-12-20 Thread Hannes Reinecke
On 12/20/2010 09:56 AM, Hannes Reinecke wrote: Hi all, I just noticed that I've botched up header digests with the latest update for SLES10 SP3. So if you got trouble connecting and get loads of 'iscsi: detected conn error (1011)' please switch off header digests. I'm working on fixing

Re: DCB support for iSCSI

2010-12-20 Thread Hannes Reinecke
for iscsid to simply send a file descriptor to the lldpad socket and have lldpad set the socket options itself? Ugh. No. As mentioned, I fear we would need to setup a VLAN interface here, in which case we would be running off a totally different socket anyway. Cheers, Hannes -- Dr. Hannes Reinecke

Re: Antw: Re: Q: RAID1 with open-iscsi

2010-10-08 Thread Hannes Reinecke
from ... Might be a stale info back from older version. I'll investigate. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG

Re: [PATCH RFC/RFT] add iscsi dev loss timeout and device removal

2010-10-07 Thread Hannes Reinecke
and dev_loss_tmo and implement a new handling for fast_io_fail, which would be quite attractive to iscsi, too. Apart from that: good point. I was on the verge of updating multipath-tools to checking/modifying recovery_tmo for iSCSI, but maybe I'll wait for a few days. Cheers, Hannes -- Dr. Hannes

Re: detected conn error (1011)

2010-09-02 Thread Hannes Reinecke
never reaches the upper layers. In your case it looks as if the 'tapdisk' thing runs on the raw disks, not the multipathed device. So of course it'll register the error. Maybe it's an idea to have the 'tapdisk' run on the multipath device-mapper device ... Cheers, Hannes -- Dr. Hannes Reinecke

Re: detected conn error (1011)

2010-08-31 Thread Hannes Reinecke
= DID_TRANSPORT_DISRUPTED 16; - break; case ISCSI_STATE_IN_RECOVERY: reason = FAILURE_SESSION_IN_RECOVERY; sc-result = DID_IMM_RETRY 16; HTH, Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h

Re: detected conn error (1011)

2010-08-30 Thread Hannes Reinecke
Goncalo Gomes wrote: Hi, On Fri, 2010-08-06 at 15:57 +0100, Hannes Reinecke wrote: Mike Christie wrote: ccing Hannes from suse, because this looks like a SLES only bug. Hey Hannes, The user is using Linux 2.6.27 x86 based on SLES + Xen 3.4 (as dom0) running a couple of RHEL 5.5 VMs

Re: [PATCH] support NIC configuration in iBFT

2010-01-15 Thread Hannes Reinecke
in the iBFT BIOS are not picked up once the machines are installed. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg) -- You

Re: SLES10 SP3 x86_64 - connection2:0: detected conn error (1011)

2010-01-13 Thread Hannes Reinecke
-client-2.14.47-0.4.9 yast2-iscsi-server-2.13.26-0.3 Please try with the latest update kernel. I made quite some fixes which should help here. cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH

Re: open-iscsi on SUSE 11

2010-01-13 Thread Hannes Reinecke
recompiling the latest open-iscsi code by hand for OpenSUSE. Sorry for this, but I fear I'm slightly overloaded... Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg

Re: [PATCH] Allow empty username for CHAP

2009-09-30 Thread Hannes Reinecke
Mike Christie wrote: On 09/29/2009 08:46 AM, Hannes Reinecke wrote: Some iSCSI implementations (eg HP) is using an empty username for CHAP negotiations. So we should be allowing the same. Do we need this support for discovery? There is one other one auth setup function

[PATCH] Allow update of discovery records.

2009-09-30 Thread Hannes Reinecke
We should allow updating of discovery records, too. This enables open-iscsi to use different settings during discovery to different targets. Signed-off-by: Hannes Reinecke h...@suse.de diff --git a/usr/idbm.c b/usr/idbm.c index ee38e64..ca5479e 100644 --- a/usr/idbm.c +++ b/usr/idbm.c

Resolved: CHAP login with HP mpx100

2009-09-29 Thread Hannes Reinecke
Hi all, finally I managed to login to a HP mpx100 bridge with CHAP enabled. Turned out that the HP is not using a CHAP username at all, just the password. So we need to tweak open-iscsi to allow empty usernames. Patch to follow. Cheers, Hannes -- Dr. Hannes Reinecke zSeries

Re: SLES10 SP2 x64, two iSCSI targets, I/O hangs

2009-09-23 Thread Hannes Reinecke
open-iscsi compiled on SLES10? There has been a backport patch at one point, but this got removed as it conflicted with RHEL. I see to have another one prepared. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688

Re: [PATCH] I/O stall finally solved

2009-08-17 Thread Hannes Reinecke
Mike Christie wrote: On 08/14/2009 07:01 AM, Hannes Reinecke wrote: Hi Mike, finally I've found the mysterious I/O stall I've been chasing for the last two months. Problem is iscsi_conn_queue_work(); we're just calling queue_work() without checking the return value. However, queue_work

Re: [PATCH 1/4] libiscsi: Check TMF state before sending PDU

2009-08-17 Thread Hannes Reinecke
Mike Christie wrote: I think something got dropped by accident when you redid your patchset. There is a missing memset(hdr, 0, sizeof(*hdr)); for iscsi_eh_device_reset. Oh, correct. Will be redoing the patch. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h

Re: [PATCH 3/4] libiscsi: Set the 'FINAL' bit to terminate data transfer on TMF

2009-08-17 Thread Hannes Reinecke
Mike Christie wrote: On 08/14/2009 01:42 AM, Hannes Reinecke wrote: Mike Christie wrote: Hannes Reinecke wrote: Whenever we send a Data-Out response to an affected LUN during LU Reset, we should be setting the 'FINAL' bit. This will indicate to the target that we consider this transfer

Re: [PATCH 1/4] libiscsi: Check TMF state before sending PDU

2009-08-14 Thread Hannes Reinecke
Mike Christie wrote: Hannes Reinecke wrote: Before we're trying to send a PDU we have to check whether a TMF is active. If so and if the PDU will be affected by the TMF we should allow only Data-out PDUs to be sent, or, if fast_abort is set, no PDUs at all. You sort of changed

Re: [PATCH 3/4] libiscsi: Set the 'FINAL' bit to terminate data transfer on TMF

2009-08-14 Thread Hannes Reinecke
Mike Christie wrote: Hannes Reinecke wrote: Whenever we send a Data-Out response to an affected LUN during LU Reset, we should be setting the 'FINAL' bit. This will indicate to the target that we consider this transfer finished. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers

Re: [RFC] Dynamically adjust shost-can_queue

2009-08-14 Thread Hannes Reinecke
it's hardly worth it. Well, for me :-) Might be different when using iSCSI HBAs. Anyway, I'll update the patch. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg

[PATCH] I/O stall finally solved

2009-08-14 Thread Hannes Reinecke
have had some changes to the lists as someone called queue_work in the meantime. Comments etc welcome. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF

Re: [PATCH 4/4] libiscsi: Flush workqueue before suspend

2009-08-14 Thread Hannes Reinecke
didn't do it, but used the simpler approach :-) Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Markus Rex, HRB 16746 (AG Nürnberg

[PATCH 4/4] libiscsi: Flush workqueue before suspend

2009-08-13 Thread Hannes Reinecke
If 'fast_abort' is not set we should be sending all outstanding Data-out PDUs to the target, even after we have received the tmf response. So we should make sure that the workqueue is really flushed and all PDUs have been processed before setting the 'SUSPEND' bit. Signed-off-by: Hannes

[PATCH 1/4] libiscsi: Check TMF state before sending PDU

2009-08-13 Thread Hannes Reinecke
Before we're trying to send a PDU we have to check whether a TMF is active. If so and if the PDU will be affected by the TMF we should allow only Data-out PDUs to be sent, or, if fast_abort is set, no PDUs at all. Signed-off-by: Mike Christie micha...@cs.wisc.edu Signed-off-by: Hannes Reinecke

[PATCH 0/4] Update LU Reset handling (take #2)

2009-08-13 Thread Hannes Reinecke
would be to check the possible return codes and only break out on the non-retryable ones only, but continue for others. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409

Re: [PATCH 5/5] libiscsi: Flush workqueue before suspend

2009-08-10 Thread Hannes Reinecke
Mike Christie wrote: On 08/07/2009 05:27 AM, Hannes Reinecke wrote: We should be flushing the workqueue before setting the suspend bit. If we don't a LU Reset might kill commands which are already in the queue and waiting to be send, causing the target to barf. What do you mean here? What

  1   2   >