Hi,
On Mon, Nov 28, 2022 at 02:35:24PM +0100, Gert Doering wrote:
> Now testing the actual patch.
Doesn't work...
without 3/3, I have the
ubuntu2004 kernel: [22034799.495703] ovpn_udp_encap_recv: received data from
unknown peer (id: 1114473)
on reconnect, but at least TLS h
Hi,
On Mon, Nov 28, 2022 at 02:26:31PM +0100, Gert Doering wrote:
> On Wed, Oct 12, 2022 at 03:34:56PM +0200, Arne Schwabe wrote:
> > This allows a reconnect in p2p mode and has the side effect of updating
> > the peer address with the peerid
>
> Maybe I am just holding it
me out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP sign
Hi,
On Mon, Nov 28, 2022 at 12:55:54PM +0100, Gert Doering wrote:
> 2022-11-28 12:55:25 us=199080 ERROR: failed to negotiate cipher with peer and
> --data-ciphers-fallback not enabled. No usable data channel cipher
> 2022-11-28 12:55:25 us=199092 ERROR: Failed to apply P2P negotiated
l I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
___
Thanks for the review.
Patch has been applied to the master branch.
commit 16d773eb1f94179b60d718f1eb92cb14ace67779
Author: Gert Doering
Date: Mon Nov 28 12:16:42 2022 +0100
Update PORTS
Signed-off-by: Gert Doering
Acked-by: Frank Lichtenheld
Message-Id
Instead of fully removing PORTS, keep "this is what you want to do for
porting OpenVPN to a new platform" section, and update the PLATFORMS
part to better reflect current status.
v2:
drop "2.2+" from Linux, and name the fruitish thing "macOS"
Signed-off-by:
Acked-by: Gert Doering
This patch survived all tests I threw at it (Linux and FreeBSD client
and server, with and without DCO, including multiple p2mp clients on
the server under test).
The "main" code change (dco_peer_id) is fairly straightforward, if
one checks for the right val
ction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany
Instead of fully removing PORTS, keep "this is what you want to do for
porting OpenVPN to a new platform" section, and update the PLATFORMS
part to better reflect current status.
Signed-off-by: Gert Doering
---
PORTS | 43 +--
1 file c
Acked-by: Gert Doering
Straightforward enough :-) - we discussed this at the hackathon today,
and FreeBSD DCO does not "consume" the socket, it just hooks into it and
takes out "interesting" packet - so normal userland operation is still
possible. Support for "floati
was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany
out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_
to sock->info.lsa.actual
Signed-off-by: Arne Schwabe
Acked-by: Antonio Quartulli
Message-Id: <20221124162642.3173118-1-a...@rfc2549.org>
URL:
https://www.mail-archive.com/search?l=mid&q=20221124162642.3173118-1-a...@rfc2549.org
Signed-off-by: Gert Doering
ve.com/openvpn-devel@lists.sourceforge.net/msg25530.html
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
___
Ope
kups. This is fully reproduceable, so if you
want me to increas debug, just let me know.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a
Hi,
On Tue, Nov 22, 2022 at 07:32:29PM +0100, Gert Doering wrote:
> - use getrrsetbyname(), and add that via "compat" source if a target
> platform does not have it - this is what OpenSSH does
>
> - add #ifdefs to disable --srv functionality on OpenBSD
> (whi
From: Vladislav Grishenko
DNS SRV remote host discovery allows to have multiple OpenVPN servers for
a single domain w/o explicit profile enumeration, to move services from
host to host with little fuss, and to designate hosts as primary servers
for a service and others as backups.
Feature has bee
ople took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany
Acked-by: Gert Doering
The discussion in the mail thread and on IRC explains why we need
to check the full EARLY_NEG_START value (because it's "0x0f" in the
topmost byte, not "just one bit set"). This is because it was done
that way initially, and now it is what it
Acked-by: Gert Doering
Stared-at-code, discussed on IRC, and dropped "Changes.rst" entry, as
user-visible behaviour is no longer changed (no default-MTU change).
Tested on the server testbed, having one instance do "tun-mtu 1400 1500"
now, and depending on client version,
Acked-by: Gert Doering
This is a step towards being able to adjust MTU in a server-controlled
way, and to either enable large-MTU setups (9000), or to reduce MTU
to "outside packets never need to be fragmented". This does not change
defaults, so no behavioural changes are to b
Hi,
following up on this one:
On Mon, Dec 06, 2021 at 04:41:17PM +0100, Gert Doering wrote:
> commit 766044507497c41f0319159c37992788ecb681e6
> Author: Arne Schwabe
> Date: Wed Dec 1 19:07:19 2021 +0100
>
> Implement optional cipher in --data-ciphers prefixed with ?
>
: support AES-192-GCM
Signed-off-by: Kristof Provost
Acked-by: Arne Schwabe
Message-Id: <2022102031.8402-2-kprov...@netgate.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25506.html
Signed-off-by: Gert Doering
--
kind regards,
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25508.html
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net
h.
commit 199081c24a1bb4b9066e542165de9b4a6ce1a8fd
Author: Gert Doering
Date: Tue Nov 8 14:45:23 2022 +0100
Improve documentation for --dev and --dev-node.
Signed-off-by: Gert Doering
Acked-by: Antonio Quartulli
Message-Id: <20221108134523.2325-1-g...@greenie.muc.de>
URL:
https://www.
Acked-by: Gert Doering
My first thought was "trivial enough", the second thought was "oh wait"
- the old code copies "src->addr" to "dst->addr", while the new code copies
"src" to "dst". Now, src/dst are "struct openvp
Acked-by: Gert Doering
"Yes, this is much nicer" :-)
Master Encrypt (cipher, AES-256-GCM, 256 bits): da62213e a3d13f7c ...
Master Encrypt (hmac, [null-digest], 0 bits):
Master Decrypt (cipher, AES-256-GCM, 256 bits): 4aec936c 1eb1c231 ...
Master Decrypt (hmac, [n
Acked-by: Gert Doering
Verified that this fixes the (mbedtls-only) crash I was seeing
with --verb 7 - and verified again that it does not happen with
OpenSSL builds:
Master Encrypt (cipher): 6359ae14 b7069ef7 ...
Master Encrypt (hmac):
Master Decrypt (cipher): 5217f7a8 c3f80df5
elow?
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is
Acked-by: Gert Doering
This is a useful addition. It works...
2022-11-08 17:39:46 us=399783 Connection Attempt Valid packet (P_CONTROL_V1)
with HMAC challenge from peer ([AF_INET6]:::194.97.140.21:61081), accepting
new connection.
.. and uncovered a new bug...
2022-11-08 17:39:46 us
Acked-by: Gert Doering
Most of it is actually straightforward (if no workable key is
found, go to the "print fail" function, find the right key slot
*again*, print "not initialized" or "not authorized" according
to ks->state / ks->authenticated - and if
tches up on the documentation.
v2: disambiguate Linux ("all drivers") and FreeBSD ("only DCO"), add
comment about --dev-type being necessary for devices not starting with
tun* or tap*
Signed-off-by: Gert Doering
---
doc/man-sections/vpn-network-options.rst | 38 +++-
Acked-by: Gert Doering
The tester's echo was really overwhelming here... so I've stared-at-code
and fed this to my github instance for test building with msvc & mingw
(builds fine).
Compareing the patch to MS documentation (IsWow64Process2() etc.) - the
code seems to be reasonabl
Acked-by: Gert Doering
As usual, I have no idea what this all does, but is not changing code,
and seems to match the commit description (which sounds reasonable).
Your patch has been applied to the master branch.
commit f98aa0c76a45b8dea047fd60d687c2d377a2df06
Author: Lev Stipakov
Date: Wed
Acked-by: Gert Doering
This is straightforward. The detection "what makes a softether server?"
is a bit annoying... and this code will be with us forever...
I have not specifically tested this ("no softether server around") but
ran the normal server/client tests.
Your pa
Date: Fri Nov 4 13:56:55 2022 +0100
Allow setting control channel packet size with max-packet-size
Signed-off-by: Arne Schwabe
Acked-by: Frank Lichtenheld
Message-Id: <20221104125655.656150-2-a...@rfc2549.org>
URL:
https://www.mail-archive.com/openvpn-dev
Signed-off-by: Arne Schwabe
Acked-by: Frank Lichtenheld
Message-Id: <20220831134140.913337-1-a...@rfc2549.org>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25143.html
Signed-off-by: Gert Doering
--
k
eld
Message-Id: <20220921104930.3452270-3-a...@rfc2549.org>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25292.html
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
___
Openvpn-devel mailing list
Openvpn-devel@l
Acked-by: Gert Doering
This is a slightly complicated ACK - this is a respin of 1/3 v4 with
the "Ensure that control channel packet are respecting maximum packet size"
patch, which has an ACK from Frank Lichtenheld. During testing of v4
I noticed that it it brings a regression for &
ot;If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Ha
Hi,
... and here we go:
On Thu, Oct 27, 2022 at 09:02:52PM +0200, Gert Doering wrote:
> Your patch has been applied to the master branch, for now - it needs
> to go to 2.5 as well, but we're right in the middle of a 2.5.8
> release, and I need to check with Samuli & Frank if
Acked-by: Gert Doering
Testing this was fairly easy - I added a msg() call in that if()
branch, connected to a server with auth-token and verified that it did
the strncpynt() only on the "I have a real username here" call. And
that token reauth still works ("username properly cop
Hi,
On Thu, Oct 27, 2022 at 11:18:07AM -0400, Selva Nair wrote:
> On Thu, Oct 27, 2022 at 2:08 AM Gert Doering wrote:
>
> > Looking at the code, I'd say your commit description makes a lot of
> > sense, and explains the observed "funnies" quite well (which
Acked-by: Gert Doering
Thanks. Based on our mail thread on v1, this now clears the token on
"management related events" (forget-password, management disconnect)
and does not affect other code paths. I have not submitted this to
extremely thorough testing, just basic t_client tests f
igned-off-by: Selva Nair
Acked-by: Arne Schwabe
Message-Id: <20221023195105.31714-1-selva.n...@gmail.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25452.html
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
nted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@gre
get-disconnect? Just asking :-)
(This whole token thing is really great when it works, but it is
obvious that it wasn't there from day one, and not all combinations
of use cases, options and "events" seemt o really make sense)
gert
--
"If was one thing all people took for granted,
thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Hein
Acked-by: Gert Doering
Tested on Linux with/without --disable-dco, and the expected message
shows up. Test compiled on FreeBSD (without DCO) and nothing breaks.
Your patch has been applied to the master branch.
commit 77829be280b3b280f35d1ca4947900f3c5e5dd26
Author: Antonio Quartulli
Date
conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@
-devel@lists.sourceforge.net/msg24550.html
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Acked-by: Gert Doering
Glad that this obscure AS option caught this breakage... *sigh* - that's
what you get for "just fix this compiler warning" (which I am usually
quite reluctant to do, but "it looked straightforward enough").
The new code is less magic, and much ea
been applied to the master branch.
commit 22bc63c78439ed23b974b8f822330d75ec79c7fc
Author: Gert Doering
Date: Wed Oct 12 16:59:15 2022 +0200
FreeBSD DCO: introduce real subnet mode
Signed-off-by: Gert Doering
Acked-by: Kristof Provost
Message-Id: <20221012145915.2581
d to the master branch.
commit 94db32616597497e57eb2fa6fab05297da314a53
Author: Gert Doering
Date: Wed Oct 12 16:59:14 2022 +0200
FreeBSD: for topology subnet, put tun interface into IFF_BROADCAST mode
Signed-off-by: Gert Doering
Acked-by: Kristof Provost
Message-Id: <202210
Acked-by: Gert Doering
"That's what I get for testing the core of the patch, and ignoring all
the little details..." - fixes are straightforward. Only compile-tested.
Your patch has been applied to the master branch.
commit 92db3227b682518ff8c5dc691ee15a1641899729
Author: Ar
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Acked-by: Gert Doering
The feature itself is really in the "we are a swiss army knife and can
do everything" side of things. It does not introduce a new option and
no new #ifdef, and the actual code change is not very intrusive.
I should point out that there is potential for conflic
was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert D
Acked-by: Gert Doering
Tested the whole lot again. Only difference to v1 is in p2mp mode with
incoming TLS EEN, which now logs
10:15:34 cron2-freebsd-tc-amd64/194.97.140.21:53341 Exit message received by
peer
10:15:34 cron2-freebsd-tc-amd64/194.97.140.21:53341 Delayed exit in 5 seconds
10:15
ion that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g..
All the rest sets "-1", AFAICS, just the if() here is weird)
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor.&quo
d 7.4
To actually work with ovpn(4) / FreeBSD DCO, a followup patch for
kernel ovpn(4) and OpenVPN dco_freebsd.c is needed.
Signed-off-by: Gert Doering
---
Changes.rst | 5 +
src/openvpn/tun.c | 37 -
2 files changed, 17 insertions(+), 25 deletion
DE on the
other side - with an older kernel, OpenVPN will just fail now)
Signed-off-by: Gert Doering
---
src/openvpn/dco_freebsd.c | 36 ++
src/openvpn/ovpn_dco_freebsd.h | 1 +
2 files changed, 37 insertions(+)
diff --git a/src/openvpn/dco_freebsd.c b/s
Hi,
people have alreadycomplained at me that I write so long e-mails today,
so I can write more...
On Wed, Oct 12, 2022 at 08:39:31AM +0200, Gert Doering wrote:
> Factor 1: single-peer (client or p2p) vs. multi-peer
>
> single-peer -> DCO has only 1 peer, all packets that
Hi,
On Tue, Oct 11, 2022 at 09:11:25PM +0200, Gert Doering wrote:
> OTOH, in "not peer2peer mode", we only support topology subnet anyway,
> so maybe it should autoconfigure that, depending on the mode OpenVPN
> requests (p2p mode -> IFF_POINTOPOINT, p2mp mode -> IFF_
Hi,
On Fri, Oct 07, 2022 at 11:56:52AM +0200, Gert Doering wrote:
> I'll dig into the POINTTOPOINT issue... configure a real MULTIPOINT
> interface for --topology subnet (which is something I've always avoided
> so far, because "we know the other stuff works")
This
et/msg25379.html
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Acked-by: Gert Doering
Thanks for providing a v3, and following our sometimes difficult rules
for patch submission.
I have tested this with v4 and v6 connections, and it looks good:
PLUGIN AUTH-PAM: BACKGROUND: REMOTE: 2001:608:0:814::f000:21
PLUGIN AUTH-PAM: BACKGROUND: REMOTE
tion that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie
Hi,
On Sun, Oct 09, 2022 at 03:51:36PM +0200, Gert Doering wrote:
> Recording David's and Heiko's ACK, they have done the stare-at-code
> and actual testing (I have run t_client tests, but they do not excercise
> this problem with my current test servers - need to add more v
We do not permit username changes on renegotiation (= username is
"locked" after successful initial authentication).
Unfortunately the way this is written this gets in the way of using
auth-user-pass-optional + pushing "auth-token-user" from client-connect
(and most likely also "from management")
Acked-by: Gert Doering
Tested on "master + this patch" via my GitHub fork. Builds all green!
https://github.com/cron2/openvpn/actions/runs/3214397115
Your patch has been applied to the master branch.
commit 0ff633f750a57d0a4d48481be0bd915196a0bd32 (master)
Author: Arne Schwabe
D
ne Schwabe
Acked-by: David Sommerseth
Acked-by: Heiko Hund
Message-Id: <20221009130805.1556517-1-a...@rfc2549.org>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25367.html
Signed-off-by: Gert Doering
--
kind regard
met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
___
Op
Hi,
On Sun, Oct 09, 2022 at 10:13:32AM +0200, Gert Doering wrote:
> This patch was still sitting "unanswered" in the list archives (though
> it never landed in patchwork, as far as I can see).
*sigh*
More coffee on a sunday morning, it seems - this was actually merged
just
t a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
___
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh
Acked-by: Gert Doering
Amazingly trivial, as soon as one understands the intricacies of
get_user_pass_cr() ;-) - of course I have tested this. Without the
patch, with no password will send an empty password,
with the patch, it will query on stdin and things will succeed
(hard to test in an
Acked-by: Gert Doering
This is, amazingly, quite straightforward. I assumed major complications
but our magic "ask for username and password" function *already* supports
inline, we just didn't use it for --aup yet...
I have stared at the code for a bit (looks good, though the m
Acked-by: Gert Doering
This is a useful addition for situations with external constraints
("this VPN access may only be used between 10:00 and 18:00", so you
can ensure the session ends at 17:59:59 without having extra managmeent
logic around). Whether it's overly useful in
ut functions
Signed-off-by: Arne Schwabe
Acked-by: Frank Lichtenheld
Message-Id: <20221006122940.1202712-1-a...@rfc2549.org>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25348.html
Signed-off-by: Gert Doering
Hi,
On Fri, Oct 07, 2022 at 10:47:08AM +0100, Kristof Provost wrote:
> On 6 Oct 2022, at 16:39, Gert Doering wrote:
> > FreeBSD DCO has the open issue of "iroute with the same netmask as
> > route, so we want metric/weight/... to differenciate"
> I???ll try to dig in
_RHOST environment variable */
> +if (*(up->remote))
> +{
> +status = pam_set_item(pamh, PAM_RHOST, up->remote);
> +}
... which would work nicely together with this check for a non-empty
string on the other end of the pipeline.
options=8
inet 10.114.2.1 --> 10.114.2.2 netmask 0xff00
inet6 fd00:abcd:114:2::1 prefixlen 64
inet6 fe80::250:56ff:fe9c:41b%tun1 prefixlen 64 scopeid 0x5
groups: openvpn
So, started out with one solution, now I have two new problems...
gert
--
; is getting a bit
long.
What about "/* force-kill session after n seconds */"?
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with
entries that are also in the iroute-ipv6 list
Signed-off-by: Antonio Quartulli
Acked-by: Heiko Hund
Message-Id: <20220628082024.19059-...@unstable.cc>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24577.html
Signed-off-by: Gert Doering
--
kind regards,
Gert Doering
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
eople took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doerin
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@gree
Thanks for review & finding the "some shells do, some don't" wart in v1.
Patch has been applied to the master branch.
commit 977e0650c11500d3696419afbedf4a8f42ab6760
Author: Gert Doering
Date: Tue Oct 4 15:14:03 2022 +0200
denoise tests/t_lpback.sh
Signed-o
For sanity reasons, tested on the oldest system I have around
(FreeBSD 7.4). No complaints (none expected).
Patch has been applied to the master branch.
commit facb6fffb35f51e67eefaab8ba357b676b3c6328
Author: Gert Doering
Date: Tue Oct 4 16:51:42 2022 +0200
use boolean '||' t
Verified that it doesn't break any other platforms using buildbot
on all platforms.
Patch has been applied to the master branch (offending code is not in 2.5).
commit d4c34b5246e58f83ee8b87249173521a28de6993 (master)
Author: Gert Doering
Date: Tue Oct 4 17:31:27 2022 +0200
un-
mentation of undo_ifconfig_*()
for TARGET_FREEBSD ("ifconfig tunX $ip -alias"), and brings back the
old "do nothing" behaviour for all other unixoid platforms. Tested
on FreeBSD 7.4, 12.3, 14.0.
v2: use #elif defined(TARGET_FREEBSD), otherwise it breaks other platforms
Signed-o
mentation of undo_ifconfig_*()
for TARGET_FREEBSD ("ifconfig tunX $ip -alias"), and brings back the
old "do nothing" behaviour for all other unixoid platforms. Tested
on FreeBSD 7.4, 12.3, 14.0.
Signed-off-by: Gert Doering
---
src/openvpn/tun.c | 23 +-
platform_state_group)
^~~
init.c:3530:13: note: cast one or both operands to int to silence this warning
1 warning generated.
.. so do what it wants us to do.
Signed-off-by: Gert Doering
---
src/openvpn/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/openvpn/init.c
the actual testing code is streamlined.
v2:
replace indent tabs with spaces
change [ $V == 1 ] expression to [ $V = 1 ] (POSIXly correct)
Signed-off-by: Gert Doering
---
tests/t_lpback.sh | 88 ++-
1 file changed, 57 insertions(+), 31 deletions(-)
the actual testing code is streamlined.
Signed-off-by: Gert Doering
---
tests/t_lpback.sh | 88 ++-
1 file changed, 57 insertions(+), 31 deletions(-)
diff --git a/tests/t_lpback.sh b/tests/t_lpback.sh
index 67952994..4cf29d26 100755
--- a/tests/t_lpbac
ed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@gre
Thanks for the review & testing ;-)
Patch has been applied to the master branch.
commit 398f73094a692ba46be7e3205b65d915d2593a64
Author: Gert Doering
Date: Tue Sep 20 15:23:51 2022 +0200
introduce V= level to manage t_client.sh output verbosity
Signed-off-by: Gert Doe
801 - 900 of 4851 matches
Mail list logo
