Re: [ovs-dev] [PATCH] ofp-actions: Report an error if there are too many actions to parse.

From: Alin-Gabriel Serdean >Not a very important fix, but fuzzer times out trying to test parsing >of a huge number of actions. Fixing that by reporting an error as >soon as ofpacts oversized. > >It would be great to use ofpacts_oversized() function instead of manual >size checking, but

Re: [ovs-dev] [PATCH] Python: Fix Idl.run change_seqno update

From: Alin Gabriel Serdean >Fix an issue where Idl.run() returned False even if there was a change. >If Idl.run() reads multiple messages from the database server, some >may constitute changes and some may not. Changed the way change_seqno >is reset: if a message is not a change, reset

Re: [ovs-dev] [PATCH v2 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

> -Original Message- > From: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> On Behalf Of Justin Pettit > Sent: Tuesday, August 6, 2019 8:28 AM > To: Yi-Hung Wei > Cc: ovs dev ; Alin Gabriel Serdean > > Subject: Re: [ovs-dev] [PATCH v2 4/9] ct-dpif, dpif-netlink: Add

Re: [ovs-dev] [PATCH v3 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

> -Original Message- > From: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> On Behalf Of Yi-Hung Wei > Sent: Tuesday, August 13, 2019 3:52 AM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH v3 4/9] ct-dpif, dpif-netlink: Add conntrack > timeout policy support > > This

Re: [ovs-dev] [PATCH] [windows][wmi] Switch from internal port to all ports defined

Thanks! Applied on master and backported back until branch-2.10. Alin. From: Anand Kumar Sent: Thursday, August 1, 2019 5:41 AM To: Alin Serdean ; d...@openvswitch.org Cc: Danting Liu Subject: Re: [ovs-dev] [PATCH] [windows][wmi] Switch from internal port to all ports defined

Re: [ovs-dev] [PATCH] AUTHORS: Add Dumitru Ceara.

Subject: [ovs-dev] [PATCH] AUTHORS: Add Dumitru Ceara. From: Numan Siddique Signed-off-by: Numan Siddique --- AUTHORS.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.rst b/AUTHORS.rst index ee2a3d4e9..d0d9e9ab7 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -118,6 +118,7 @@

Re: [ovs-dev] [PATCH v2] datapath-windows: Add Win10Analyze target

Applied on master. -Original Message- From: ovs-dev-boun...@openvswitch.org On Behalf Of Anand Kumar via dev Sent: Wednesday, May 1, 2019 8:04 PM To: Alin Gabriel Serdean ; d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v2] datapath-windows: Add Win10Analyze target Thanks for the

Re: [ovs-dev] [PATCH v2] datapath-windows: Address memory allocation issues for OVS_BUFFER_CONTEXT

-Original Message- From: ovs-dev-boun...@openvswitch.org On Behalf Of Anand Kumar via dev Sent: Thursday, March 21, 2019 1:55 AM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH v2] datapath-windows: Address memory allocation issues for OVS_BUFFER_CONTEXT With current implementation,

Re: [ovs-dev] [PATCH v2] python: Fix package requirements with old setuptools

Thanks for the patch, applied on master! -Original Message- From: ovs-dev-boun...@openvswitch.org On Behalf Of aserd...@ovn.org Sent: Friday, March 22, 2019 4:26 PM To: 'Timothy Redaelli' ; d...@openvswitch.org Cc: Lucian Petrut Subject: Re: [ovs-dev] [PATCH v2] python: Fix package

Re: [ovs-dev] [PATCH v2] python: Fix package requirements with old setuptools

Acked-by: Alin Gabriel Serdean -Original Message- From: Timothy Redaelli Sent: Friday, March 22, 2019 4:02 PM To: d...@openvswitch.org Cc: Alin Serdean ; Lucian Petrut Subject: [PATCH v2] python: Fix package requirements with old setuptools Commit 00fcc832d598 ("Update Python package

Re: [ovs-dev] [PATCH v2] checkpatch: Normalize exit code for Windows

> > because of: > > ./checkpatch.at:32: exit code was 0, expected 255 > > > > This patch introduces a positive constant for the default exit code. > > > > Signed-off-by: Alin Gabriel Serdean > > Acked-by: Ben Pfaff > > Acked-by: Aaron Conole > > I'm pretty sure that this is just for exit on

Re: [ovs-dev] [PATCH] datapath-windows: Guard vport usage in user.c

Applied on master and branch-2.11 > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Sairam Venugopal via dev > Trimis: Tuesday, March 12, 2019 8:20 PM > Către: Alin Gabriel Serdean ; d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH]

Re: [ovs-dev] [PATCH] datapath-windows: Add annotations to find vport functions

Applied on master and branch-2.11. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Sairam Venugopal via dev > Trimis: Tuesday, March 12, 2019 8:20 PM > Către: Alin Gabriel Serdean ; d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH]

Re: [ovs-dev] [PATCH] faq: Update features supported on Hyper-V

Thanks for the patch. Applied on master > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Sairam Venugopal via dev > Trimis: Tuesday, March 12, 2019 8:21 PM > Către: Anand Kumar ; d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] faq:

Re: [ovs-dev] [PATCH v2] datapath-windows: Fix potential deadlock in event subscription

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele aserd...@ovn.org > Trimis: Wednesday, February 27, 2019 3:45 PM > Către: 'Sairam Venugopal' ; d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH v2] datapath-windows: Fix potential deadlock >

Re: [ovs-dev] [PATCH] datapath-windows: Guard vport usage in user.c

> Do we need to keep the dispatchLock for reading vport structures? [Alin Serdean] We need to make sure that port is not deleted since we use it for processing. >If that's > the case, then we will need to fix it in other areas of the code too. [Alin Serdean] I sent out

Re: [ovs-dev] [PATCH v2] datapath-windows: Fix potential deadlock in event subscription

> > Move the EventQueue lock acquisition after the dispatchLock to prevent a > potential deadlock in port creation pipeline. There could be a case where a > port event could try to take up the Dispatch Lock before the Event Queue > lock and the subscription queue event could take up the event

Re: [ovs-dev] [PATCH] datapath-windows: Fix race condition during port creation

> > Hold the dispatch lock until port-add operations are completed. > > Found by inspection. > > Signed-off-by: Sairam Venugopal [Alin Serdean] Thanks a lot for the patch! For some reason the author seems to be ovs-dev@openvswitch.org, can you try to respin the patch? Acked-by: Alin Gabriel

Re: [ovs-dev] [PATCH] checkpatch: Normalize exit code for Windows

> De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Aaron Conole > Trimis: Tuesday, February 5, 2019 10:39 PM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] checkpatch: Normalize exit code for Windows > > Alin Gabriel Serdean

Re: [ovs-dev] [PATCH] Fix test 'testing ovn -- IP packet buffering' on Windows

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Wednesday, January 23, 2019 5:33 PM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] Fix test 'testing ovn -- IP packet buffering'

Re: [ovs-dev] [PATCH] datapath-windows: Add support for 'OVS_KEY_ATTR_ENCAP' key attribute.

> > -Mesaj original- > > De la: ovs-dev-boun...@openvswitch.org > boun...@openvswitch.org> În numele Anand Kumar > > Trimis: Friday, January 11, 2019 2:45 AM > > Către: d...@openvswitch.org > > Subiect: [ovs-dev] [PATCH] datapath-windows: Add support for > > 'OVS_KEY_ATTR_ENCAP' key

Re: [ovs-dev] [PATCH] datapath-windows: Add support for 'OVS_KEY_ATTR_ENCAP' key attribute.

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Anand Kumar > Trimis: Friday, January 11, 2019 2:45 AM > Către: d...@openvswitch.org > Subiect: [ovs-dev] [PATCH] datapath-windows: Add support for > 'OVS_KEY_ATTR_ENCAP' key attribute. > > Add

Re: [ovs-dev] [PATCH] datapath-windows: Use layers info to extract IP header in IpFragment

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Anand Kumar > Trimis: Friday, November 9, 2018 9:09 PM > Către: d...@openvswitch.org > Subiect: [ovs-dev] [PATCH] datapath-windows: Use layers info to extract IP > header in IpFragment > > -

Re: [ovs-dev] [RFC] cirrus: Add Cirrus CI integration for FreeBSD build

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ilya Maximets > Trimis: Wednesday, December 12, 2018 6:59 PM > Către: aserd...@ovn.org; 'Ben Pfaff' > Cc: ovs-dev@openvswitch.org > Subiect: Re: [ovs-dev] [RFC] cirrus: Add Cirrus CI

Re: [ovs-dev] [RFC] cirrus: Add Cirrus CI integration for FreeBSD build

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ilya Maximets > Trimis: Wednesday, December 12, 2018 6:36 PM > Către: Ben Pfaff > Cc: ovs-dev@openvswitch.org; Alin Gabriel Serdean > Subiect: Re: [ovs-dev] [RFC] cirrus: Add Cirrus CI

Re: [ovs-dev] [PATCH] pcap: Fix reading regular old Ethernet pcap files.

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, November 15, 2018 7:39 PM > Către: d...@openvswitch.org > Cc: Ben Pfaff ; Alin Gabriel Serdean > Subiect: [ovs-dev] [PATCH] pcap: Fix reading regular old

Re: [ovs-dev] [PATCH] datapath-windows: Fix invalid reference in Buffermgmt.c

Thanks for the fix! Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Sairam Venugopal > Trimis: Wednesday, November 14, 2018 10:07 PM > Către: d...@openvswitch.org > Subiect: [ovs-dev] [PATCH]

Re: [ovs-dev] [PATCH] Tests: Fix testing bridge - add port after stopping controller on Windows

Applied on master, branch-2.10, branch-2.9. -- Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele aserd...@ovn.org > Trimis: Thursday, November 15, 2018 3:23 PM > Către: 'Sairam Venugopal' ; 'Alin Gabriel Serdean' > ;

Re: [ovs-dev] [PATCH] [RFC][windows]: Remap VPORT socket pool

Answers inlined. > Subiect: Re: [ovs-dev] [PATCH] [RFC][windows]: Remap VPORT socket pool > > Hi Alin, > > Thanks for the patch. Shashank is giving it a run. How do we prevent this > issue in the future? [Alin Serdean] Thanks for trying it out, and I'm sorry I haven't caught this issue in

Re: [ovs-dev] [RFC PATCH v2] datapath-windows: Remove IP neighbor entries when internal adapter is down.

Thanks for the patch Anand! Applied on master. Alin > > > > Remove the IP neighboring entries when adapter is down, so that when > > 'OVS_IPHELPER_INSTANCE' is deleted, no stale entries are present > > > > Also fix accessing iphelper instance without acquiring the lock. > > > > Signed-off-by:

Re: [ovs-dev] [RFC PATCH v2] datapath-windows: Remove IP neighbor entries when internal adapter is down.

> > Remove the IP neighboring entries when adapter is down, so that when > 'OVS_IPHELPER_INSTANCE' is deleted, no stale entries are present > > Also fix accessing iphelper instance without acquiring the lock. > > Signed-off-by: Anand Kumar > --- Thanks for incorporating the comments: Acked-by:

Re: [ovs-dev] [PATCH] datapath-windows: Fix payload length calculation in Conntrack.h

Thanks! I applied this on master and branch-2.10. Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Anand Kumar > Trimis: Thursday, September 20, 2018 5:30 AM > Către: Alin Gabriel Serdean ; d...@openvswitch.org > Subiect: Re: [ovs-dev]

Re: [ovs-dev] [PATCH v4] datapath-windows: Add support to configure ct zone limits

I applied the patch on master and branch-2.10. Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Alin Gabriel Serdean > Trimis: Thursday, September 20, 2018 1:23 AM > Către: Anand Kumar > Cc: d...@openvswitch.org > Subiect: Re:

Re: [ovs-dev] [PATCH 1/2] windows: Add set_deatch function to daemon-windows.c

> On Tue, 21 Aug 2018 at 11:19, Ben Pfaff wrote: > > > On Tue, Aug 21, 2018 at 05:57:47PM +0300, Alin Gabriel Serdean wrote: > > > The daemon-windows file is missing a `set_detach` routine, so add it. > > > > > > This will be useful in the long run. > > > > > > Signed-off-by: Alin Gabriel

Re: [ovs-dev] [PATCH] tunnel, tests: Sort flow output in ERSPAN v1/v2 metadata

> > On Tue, Aug 21, 2018 at 11:01 AM Ben Pfaff wrote: > > > > On Tue, Aug 21, 2018 at 05:18:06PM +0300, Alin Gabriel Serdean wrote: > > > Sort the flows by input port in the test: > > > tunnel.at:512: testing tunnel - ERSPAN v1/v2 metadata ... > > > > > > This tests fails on Windows due to the

Re: [ovs-dev] [PATCH] ofctl: Fixup compare_flows function

Can you also provide a Signed-off-by pls? > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Tuesday, August 7, 2018 12:40 AM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] ofctl:

Re: [ovs-dev] [PATCH] meta-flow: Make mf_vl_mff_mf_from_nxm_header() require a valid field.

> > All the users of mf_vl_mff_mf_from_nxm_header() expect it to always > obtain a valid field or to report an error. In practice, it did not report an error > in the case where the field was unknown (although it did report an error in > some other cases). This commit fixes the problem. > >

Re: [ovs-dev] [PATCH] pcap-file: Fix formatting of log message.

> Signed-off-by: Ben Pfaff > --- > lib/pcap-file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/pcap-file.c b/lib/pcap-file.c index 981d56d48830..ea5cfa3b274e > 100644 > --- a/lib/pcap-file.c > +++ b/lib/pcap-file.c > @@ -163,7 +163,7 @@ ovs_pcap_read(FILE *file,

Re: [ovs-dev] [PATCH 3/4] unixctl: Make path to unixctl_server socket available to the client.

> Signed-off-by: Ben Pfaff > --- <---B<--> > if (error) { > -ovs_error(error, "could not initialize control socket %s", punix_path); [Alin Serdean] Changing the log message will make the following test fail: 130. daemon.at:148: testing daemon

Re: [ovs-dev] [PATCH] Add opterr and optopt to Windows headers

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Tuesday, July 31, 2018 7:37 PM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] Add opterr and optopt to Windows headers > > On

Re: [ovs-dev] build: Add gitattribute file to build-aux

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Aaron Conole > Trimis: Wednesday, July 18, 2018 6:02 PM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] build: Add gitattribute file to build-aux > > Hi Alin,

Re: [ovs-dev] [PATCH] dpif-netlink: Add meter support.

> > From: Andy Zhou > > To work with kernel datapath that supports meter. > > Signed-off-by: Andy Zhou > Co-authored-by: Justin Pettit > Signed-off-by: Justin Pettit > --- > Documentation/faq/releases.rst | 1 + > lib/dpif-netlink.c | 302 ++--- >

Re: [ovs-dev] [PATCH v5 0/3] Optimize conntrack performance

> This patch series is primarily to refactor conntrack code for better throughput > with conntrack. > > With this patch series TCP throughput with conntrack increased by ~50%. > > Anand Kumar (3): > datapath-windows: Use spinlock instead of RW lock for ct entry > datapath-windows: Implement

Re: [ovs-dev] [PATCH v4 3/3] datapath-windows: Compute ct hash based on 5-tuple and zone

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Anand Kumar > Trimis: Tuesday, June 19, 2018 8:33 PM > Către: d...@openvswitch.org > Subiect: [ovs-dev] [PATCH v4 3/3] datapath-windows: Compute ct hash > based on 5-tuple and zone > >

Re: [ovs-dev] [PATCH v4 1/3] datapath-windows: Use spinlock instead of RW lock for ct entry

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Anand Kumar > Trimis: Tuesday, June 19, 2018 8:33 PM > Către: d...@openvswitch.org > Subiect: [ovs-dev] [PATCH v4 1/3] datapath-windows: Use spinlock instead of > RW lock for ct entry > > This

Re: [ovs-dev] [PATCH] Embrace anonymous unions.

> > On May 24, 2018, at 10:32 AM, Ben Pfaff wrote: > > > > Several OVS structs contain embedded named unions, like this: > > > > struct { > >... > >union { > >... > >} u; > > }; > > > > C11 standardized a feature that many compilers already implemented > >

Re: [ovs-dev] [PATCH] ovn.at: Fix IPv6 periodic RA test on Windows

Apparently I needed the '\n'. I retested with tip of master on Ubuntu and Windows and it was fine. I applied it on master. Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele aserd...@ovn.org > Trimis: Tuesday, January 23, 2018 11:02 PM

Re: [ovs-dev] [PATCH] RFC datapath-windows: Create com device only when extension is enabled

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Shashank Ram > Trimis: Wednesday, April 4, 2018 8:31 PM > Către: Alin Gabriel Serdean ; d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] RFC datapath-windows: Create com

Re: [ovs-dev] [PATCH] tests: Skip tests that need "normal" diff if not available.

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Monday, April 2, 2018 8:15 PM > Către: d...@openvswitch.org > Cc: Ben Pfaff ; Stuart Cardall > Subiect: [ovs-dev] [PATCH] tests:

Re: [ovs-dev] [PATCH] netlink-socket: don't check for namespace id under Windows

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Flavio Leitner > Trimis: Tuesday, April 3, 2018 2:48 AM > Către: Aaron Conole > Cc: d...@openvswitch.org; Alin Gabriel Serdean > Subiect: Re: [ovs-dev]

Re: [ovs-dev] [PATCH] netlink-socket: Fix broken build on Windows

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Monday, April 2, 2018 7:35 PM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] netlink-socket: Fix broken build on

Re: [ovs-dev] [PATCH] v2, python-windows: Fix unicode python tests on Windows

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Saturday, March 31, 2018 10:46 PM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] v2, python-windows: Fix unicode

Re: [ovs-dev] [PATCH] Windows: Fix broken build caused by a bad file extension

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Saturday, March 31, 2018 10:47 PM > Către: Alin Gabriel Serdean > Cc: ovs-dev@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] Windows: Fix broken build

Re: [ovs-dev] [PATCH v3] ovsdb-client: Set binary mode when doing backup/restore

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Wednesday, March 14, 2018 8:11 PM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH v3] ovsdb-client: Set binary

Re: [ovs-dev] [PATCH] ovsdb-client.at: Fix ovsdb-client backup test on Win

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 8:55 PM > Către: aserd...@ovn.org > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] ovsdb-client.at: Fix ovsdb-client backup test > on Win >

Re: [ovs-dev] [PATCH] ovsdb-client.at: Fix ovsdb-client backup test on Win

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 8:45 PM > Către: aserd...@ovn.org > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] ovsdb-client.at: Fix ovsdb-client backup test > on Win

Re: [ovs-dev] [PATCH] ovsdb-client.at: Fix ovsdb-client backup test on Win

It's been a while . I sent a patch as you suggested: https://patchwork.ozlabs.org/patch/883250/ . Mind taking a look? Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele aserd...@ovn.org > Trimis: Tuesday, January 23, 2018 11:01 PM >

Re: [ovs-dev] *** SPAM *** [PATCH] [RFC] build-windows: Add pthread to windows build

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 2:12 AM > Către: aserd...@ovn.org > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] *** SPAM *** [PATCH] [RFC] build-windows: Add > pthread to

Re: [ovs-dev] [PATCH] tests-windows: Add OpenSSL directory to autotest path

Thanks for the review! Applied on master. Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 3:09 AM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re:

Re: [ovs-dev] [PATCH] ovs-bugtool: Fix ambiguous variable flake8 warnings

No worries! > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 3:25 AM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] ovs-bugtool: Fix

Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is hanging

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 3:07 AM > Către: aserd...@ovn.org > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is > hanging >

Re: [ovs-dev] [PATCH] tests-windows: Make flow extractor work on Windows

Thanks for the quick review. I removed the import and changed a bit the message. Applied on master. Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Wednesday, March 7, 2018 11:07 PM > Către: Alin Gabriel Serdean

Re: [ovs-dev] [PATCH v2] datapath-windows: Do not drop Ip fragments less than MIN_FRAGMENT_SIZE

Applied on master! Thanks, Alin. > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Anand Kumar > Trimis: Thursday, March 8, 2018 2:16 AM > Către: aserd...@ovn.org; d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH v2] datapath-windows: Do

Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is hanging

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Thursday, March 8, 2018 2:11 AM > Către: aserd...@ovn.org > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is > hanging >

Re: [ovs-dev] [PATCH 2/2] ovsdb-server: Don't be picky about particular error in test.

Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Wednesday, March 7, 2018 11:19 PM > Către: d...@openvswitch.org > Cc: Ben Pfaff ; Alin Gabriel Serdean

Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb test which is hanging

> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Wednesday, March 7, 2018 11:20 PM > Către: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] tests-windows: Fix SSL ovsdb

Re: [ovs-dev] [PATCH 1/2] tests: Fix hang when "SSL db: implementation" test failed.

Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Ben Pfaff > Trimis: Wednesday, March 7, 2018 11:19 PM > Către: d...@openvswitch.org > Cc: Ben Pfaff ; Alin Gabriel Serdean

Re: [ovs-dev] *** SPAM *** [PATCH] [RFC] build-windows: Add pthread to windows build

-Mesaj original- De la: ovs-dev-boun...@openvswitch.org În numele Ben Pfaff Trimis: Wednesday, March 7, 2018 10:53 PM Către: Alin Gabriel Serdean Cc: d...@openvswitch.org Subiect: Re: [ovs-dev] *** SPAM *** [PATCH] [RFC]

Re: [ovs-dev] [PATCH v2] datapath-windows: Do not drop Ip fragments less than MIN_FRAGMENT_SIZE

Acked-by: Alin Gabriel Serdean Alin. -Mesaj original- De la: ovs-dev-boun...@openvswitch.org În numele Anand Kumar Trimis: Wednesday, March 7, 2018 1:48 AM Către: d...@openvswitch.org Subiect: [ovs-dev] [PATCH v2] datapath-windows: Do

Re: [ovs-dev] [PATCH] [RFC] build-windows: Add pthread to windows build

Adding Ben to thread also. The footprint isn't that bad compares to the MSI images: alin@DESKTOP-IUDEFLM /c/_2018/march/temp/ovs/windows $ ls -lh ovs-windows-installer/images/ total 582K -rw-r--r-- 1 alin Administrators 132K Mar 6 20:00 bannrbmp.bmp -rw-r--r-- 1 alin Administrators 450K Mar 6

Re: [ovs-dev] [PATCH] datapath-windows: Fix static analysis in Stt.c

Thanks. Applied on master. Alin. -Mesaj original- De la: ovs-dev-boun...@openvswitch.org În numele Sairam Venugopal Trimis: Tuesday, March 6, 2018 7:56 PM Către: Alin Gabriel Serdean ; d...@openvswitch.org Subiect: Re: [ovs-dev]

Re: [ovs-dev] [PATCH] datapath-windows: Do not drop Ip fragments less than MIN_FRAGMENT_SIZE

I guess you can also remove the define (https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/IpFr agment.c#L30) since it is not used anywhere else. Thanks, Alin. -Mesaj original- De la: ovs-dev-boun...@openvswitch.org În numele Anand

Re: [ovs-dev] [PATCH] AppVeyor: Add Win10 compilation to the build

-Mesaj original- De la: ovs-dev-boun...@openvswitch.org În numele Shashank Ram Trimis: Monday, March 5, 2018 6:44 AM Către: Alin Gabriel Serdean Cc: d...@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] AppVeyor: Add Win10 compilation to

Re: [ovs-dev] [PATCH v2] datapath-windows: Support to selectively compile targets

Applied on master with the following incremental: 60c66 < + MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win10$(VSTUDIO_CONFIG)" /property:Version="$(PACKAGE_VERSION)" //p:Platform=$(ARCH) --- > +MSBuild.exe //nologo

Re: [ovs-dev] [PATCH v2] datapath-windows: Support to selectively compile targets

There is a small nit, win 10 targets contain regular ' ' instead of a '\t' in the Makefile. I will change it and apply on master. Thanks a lot for the patch. Acked-by: Alin Gabriel Serdean -Mesaj original- De la: ovs-dev-boun...@openvswitch.org

Re: [ovs-dev] [PATCH v2] datapath-windows: On Debug builds, dump NBL info based on OVS_DBG_DEFAULT macro

Thanks for the patch Anand. I applied it on master. Alin. -Mesaj original- De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] În numele Anand Kumar Trimis: Wednesday, February 28, 2018 7:00 AM Către: d...@openvswitch.org Subiect: [ovs-dev] [PATCH v2]

Re: [ovs-dev] [PATCH v2] datapath-windows: On Debug builds, dump NBL info based on OVS_DBG_DEFAULT macro

Acked-by: Alin Gabriel Serdean -Mesaj original- De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] În numele Anand Kumar Trimis: Wednesday, February 28, 2018 7:00 AM Către: d...@openvswitch.org Subiect: [ovs-dev] [PATCH v2] datapath-windows:

Re: [ovs-dev] [PATCH] datapath-windows: fix hash creation on ct mark

Thanks Ben and Anand. I applied from master to branch-2.6. Thanks, Alin. -Mesaj original- De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] În numele Ben Pfaff Trimis: Wednesday, February 21, 2018 8:41 PM Către: Alin Gabriel Serdean Cc:

Re: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets

Trimming the message a bit. -Mesaj original- De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] În numele Shashank Ram Trimis: Thursday, February 8, 2018 7:50 PM Către: aserd...@ovn.org; d...@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] datapath-windows:

Re: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets

It looks a bit complicated. What do you think about the following approach: git diff datapath-windows/automake.mk diff --git a/datapath-windows/automake.mk b/datapath-windows/automake.mk index 3820041f6..164567734 100644 --- a/datapath-windows/automake.mk +++ b/datapath-windows/automake.mk @@

Re: [ovs-dev] [PATCH v1 1/2] datapath-windows: Allow compiling all targets using SDK 10.0

I applied the patch set on master. Thanks! -Mesaj original- De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] În numele aserd...@ovn.org Trimis: Tuesday, February 6, 2018 5:49 PM Către: 'Shashank Ram' ; d...@openvswitch.org Subiect: Re:

Re: [ovs-dev] [PATCH v1 2/2] datapath-windows: Specify platform arch during compilation

Acked-by: Alin Gabriel Serdean -Mesaj original- De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] În numele Shashank Ram Trimis: Thursday, February 1, 2018 4:59 AM Către: d...@openvswitch.org Subiect: [ovs-dev] [PATCH v1 2/2]

Re: [ovs-dev] [PATCH v1 1/2] datapath-windows: Allow compiling all targets using SDK 10.0

Thanks a lot for the series. Acked-by: Alin Gabriel Serdean -Mesaj original- De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] În numele Shashank Ram Trimis: Thursday, February 1, 2018 4:59 AM Către: d...@openvswitch.org Subiect: [ovs-dev]

Re: [ovs-dev] [PATCH v2] datapath-windows: Add trace level logs in conntrack for invalid ct state.

Much better  Acked-by: Alin Gabriel Serdean -Mesaj original- De la: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] În numele Anand Kumar Trimis: Saturday, February 3, 2018 12:43 AM Către: d...@openvswitch.org Subiect: [ovs-dev] [PATCH v2]

Re: [ovs-dev] [PATCH] datapath-windows: Add trace level logs in conntrack for invalid ct state.

-Mesaj original- De la: Anand Kumar [mailto:kumaran...@vmware.com] Trimis: Saturday, February 3, 2018 12:28 AM Către: Alin Serdean ; d...@openvswitch.org Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Add trace level logs in conntrack for invalid ct

Re: [ovs-dev] [PATCH] ovn.at: Fix IPv6 periodic RA test on Windows

Thanks for the review! I have a "\n" which isn't OK. Also, even with that changed I get the following: +++ /c/_2018/january/23/ovs/tests/testsuite.dir/at-groups/2378/stdout 2018-01-23 22:58:49 +0200 @@ -1 +1 @@ -ff4001010001050105dc03044080fff

Re: [ovs-dev] [PATCH] ovsdb-client.at: Fix ovsdb-client backup test on Win

(facepalm). Thanks for pointing me to the right direction. I will look into it. Thanks, Alin. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, January 23, 2018 2:24 AM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re:

Re: [ovs-dev] [PATCH] ovn-northd.at: Fix MSYS IPv6 interpretation

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, January 10, 2018 11:16 PM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] ovn-northd.at: Fix MSYS IPv6 interpretation > > On Wed, Jan 10, 2018 at

Re: [ovs-dev] [PATCH] appveyor: Bump OpenSSL version

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, January 10, 2018 11:19 PM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] appveyor: Bump OpenSSL version > > On Wed, Jan 10, 2018 at 09:06:16PM

Re: [ovs-dev] [PATCH] windows: Fix x64 build

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, January 10, 2018 7:30 PM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] windows: Fix x64 build > > On Wed, Jan 10, 2018 at 07:27:52PM +0200, Alin

Re: [ovs-dev] [PATCH 0/3] Fixes while compiling with 1709 and VS2017

Thanks Ben! Applied on master. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Friday, January 5, 2018 5:14 PM > To: aserd...@ovn.org > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 0/3] Fixes while compiling with 1709 and > VS2017 > > OK. > > Acked-by:

Re: [ovs-dev] [PATCH 0/3] Fixes while compiling with 1709 and VS2017

Sure. Do you mind if I add your acked-by on each one? Thanks, Alin. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Thursday, January 4, 2018 11:37 PM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 0/3] Fixes

Re: [ovs-dev] [PATCH] MSI: Use platform specific netcfg location

Thanks for the review. Applied on master. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Thursday, January 4, 2018 11:36 PM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] MSI: Use platform specific netcfg

Re: [ovs-dev] [PATCH] travis: Use pip2 instead of pip for OSX build.

I applied this on master. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of aserd...@ovn.org > Sent: Monday, December 11, 2017 4:23 PM > To: 'Ilya Maximets' ; ovs-dev@openvswitch.org > Cc: 'Lance

Re: [ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments.

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, December 12, 2017 12:40 AM > To: Alin Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 1/5] ovsdb-idl: Improve comments. > > On Mon, Dec 11, 2017 at

Re: [ovs-dev] [PATCH] datapath-windows: Correct endianness for deleting zone.

I was concerned a bit about binary compatibility between the future userspace binaries and older kernel versions. But Windows users usually just use the MSI (because of the signing issues). Thanks both! Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-

Re: [ovs-dev] [PATCH] datapath-windows: Correct endianness for deleting zone.

> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Justin Pettit > Sent: Tuesday, December 5, 2017 9:30 AM > To: d...@openvswitch.org; Alin Gabriel Serdean ; > Sairam Venugopal >

Re: [ovs-dev] [PATCH v1] datapath-windows: Add support for deleting conntrack entry by 5-tuple.

I wanted to give it a few days to see if another review pops up. Mind if I wait until tomorrow? Thanks, Alin. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, November 29, 2017 7:44 PM > To: Alin Serdean > Cc: Anand Kumar

Re: [ovs-dev] [PATCH v1 2/3] datapath-windows: Add a global level RW lock for NAT

Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Anand Kumar > Sent: Tuesday, November 14, 2017 8:48 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH v1 2/3]

Re: [ovs-dev] [PATCH] datapath-windows: Account for VLAN tag in tunnel Decap

Thanks Anand and Shashank, I applied this on master. > -Original Message- > From: Shashank Ram [mailto:r...@vmware.com] > Sent: Tuesday, November 28, 2017 8:18 AM > To: Anand Kumar ; d...@openvswitch.org; Alin > Serdean > Subject:

  1   2   >