Re: Tab completion for CREATE TABLE ... AS

2023-11-15 Thread Gilles Darold
Le 15/11/2023 à 03:58, Michael Paquier a écrit : On Thu, Nov 02, 2023 at 07:27:02PM +0300, Gilles Darold wrote: Look like the tab completion for CREATE TABLE ... AS is not proposed. + /* Complete CREATE TABLE AS with list of keywords */ + else if (TailMatches("CREATE&quo

Tab completion for CREATE TABLE ... AS

2023-11-02 Thread Gilles Darold
( AS    OF    PARTITION OF gilles=# CREATE TABLE test AS SELECT  WITH Adding the patch to current commitfest. Best regards, -- Gilles Darold http://www.darold.net/ diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c index 93742fc6ac..d793a94d6a 100644 --- a/src/bin/psql/tab

Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-03-14 Thread Gilles Darold
changed commit fest status to "Ready for committers". -- Gilles Darold

Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-03-13 Thread Gilles Darold
... ok     All tests successful.     Files=4, Tests=9531, 11 wallclock secs ( 0.33 usr  0.04 sys + 3.05 cusr  1.22 csys =  4.64 CPU)     Result: PASS Anyway this test must be fixed and this is done in version v5 of the patch attached here. Thanks for the review. -- Gilles Darold diff --git a/doc/sr

Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-03-12 Thread Gilles Darold
Le 11/03/2023 à 19:51, Gilles Darold a écrit : Le 04/03/2023 à 20:18, Tom Lane a écrit : As noted, "childs" is bad English and "partitions" is flat out wrong (unless you change it to recurse only to partitions, which doesn't seem like a better definition).  We could go wi

Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-03-11 Thread Gilles Darold
e-table-and-children     --exclude-table-data-and-children.  Documentation have been updated too. Thanks -- Gilles Darold diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml index 334e4b7fd1..e97b73194e 100644 --- a/doc/src/sgml/ref/pg_dump.sgml +++ b/doc/src/sgml/ref/pg_dump.sg

Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-03-05 Thread Gilles Darold
Le 04/03/2023 à 19:18, Tom Lane a écrit : Gilles Darold writes: But I disagree the use of --table-with-childs and --exclude-table-with-childs because we already have the --table and --exclude-table, and it will add lot of code where we just need a switch to include children tables. I quite

Re: [Proposal] Allow pg_dump to include all child tables with the root table

2023-02-25 Thread Gilles Darold
at this option also works with inheritance. Attached is a new patch v2 using the --with-partitions and the documentation fix. -- Gilles Darold diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml index 49d218905f..15ada5c8ee 100644 --- a/doc/src/sgml/ref/pg_dump.sgml +++

Re: fix and document CLUSTER privileges

2023-01-14 Thread Gilles Darold
Le 11/01/2023 à 18:54, Nathan Bossart a écrit : On Wed, Jan 11, 2023 at 02:22:26PM +0100, Gilles Darold wrote: I'm moving this commitfest entry to Ready for Committers. Thank you for reviewing. I have changed the status to "Returned with feedback" as per commit ff9618e8 this p

[Proposal] Allow pg_dump to include all child tables with the root table

2023-01-11 Thread Gilles Darold
quot; --with-childs > out.sql Here in attachment the patch that adds this feature to pg_dump. Is there is any interest for this feature? Best regards, -- Gilles Darold https://www.migops.com/ diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml index 2c938cd7e1..f9635442f9 100

Re: fix and document CLUSTER privileges

2023-01-11 Thread Gilles Darold
kip warning messages except partially in src/test/regress/sql/cluster.sql to validate the presence of the warning. I'm moving this commitfest entry to Ready for Committers. Regards, -- Gilles Darold

Re: fix and document CLUSTER privileges

2023-01-05 Thread Gilles Darold
Le 05/01/2023 à 06:12, Nathan Bossart a écrit : On Wed, Jan 04, 2023 at 11:27:05PM +0100, Gilles Darold wrote: Got it, this is patch add_cluster_skip_messages.patch . IMHO this patch should be part of this commitfest as it is directly based on this one. You could create a second patch here

Re: fix and document CLUSTER privileges

2023-01-04 Thread Gilles Darold
Le 04/01/2023 à 19:18, Nathan Bossart a écrit : On Wed, Jan 04, 2023 at 02:25:13PM +0100, Gilles Darold wrote: This is the current behavior of the CLUSTER command and current patch adds a sentence about the silent behavior in the documentation. This is good but I just want to ask if we could

Re: fix and document CLUSTER privileges

2023-01-04 Thread Gilles Darold
patch adds a sentence about the silent behavior in the documentation. This is good but I just want to ask if we could want to fix this behavior too or just keep things like that with the lack of noise. Best regards, -- Gilles Darold

Re: [PATCH] pg_dump: lock tables in batches

2023-01-03 Thread Gilles Darold
s to apply this patch I will change the commitfest status to ready for committers. Regards, -- Gilles Darold

Re: [BUG] pg_dump blocked

2022-11-18 Thread Gilles Darold
Le 17/11/2022 à 17:59, Tom Lane a écrit : Gilles Darold writes: I have an incorrect behavior with pg_dump prior PG version 15. With PostgreSQL 15, thanks to commit e3fcbbd623b9ccc16cdbda374654d91a4727d173 the problem is gone but for older versions it persists with locks on partitioned tables

Re: [BUG] pg_dump blocked

2022-11-17 Thread Gilles Darold
Le 17/11/2022 à 17:59, Tom Lane a écrit : Gilles Darold writes: I have an incorrect behavior with pg_dump prior PG version 15. With PostgreSQL 15, thanks to commit e3fcbbd623b9ccc16cdbda374654d91a4727d173 the problem is gone but for older versions it persists with locks on partitioned tables

[BUG] pg_dump blocked

2022-11-17 Thread Gilles Darold
out of a kind of backport of commit e3fcbbd623b9ccc16cdbda374654d91a4727d173 ? Best regards, -- Gilles Darold

Re: [Proposal] vacuumdb --schema only

2022-04-25 Thread Gilles Darold
goo Le 25/04/2022 à 03:27, Nathan Bossart a écrit : > On Fri, Apr 22, 2022 at 10:57:46PM -0700, Nathan Bossart wrote: >> On Fri, Apr 22, 2022 at 11:57:05AM +0200, Gilles Darold wrote: >>> Patch v10 attached. >> Thanks! I've attached a v11 with some minor editorialization

Re: [Proposal] vacuumdb --schema only

2022-04-22 Thread Gilles Darold
Le 20/04/2022 à 19:38, Nathan Bossart a écrit : Thanks for the new patch! I think this is on the right track. On Wed, Apr 20, 2022 at 05:15:02PM +0200, Gilles Darold wrote: Le 18/04/2022 à 23:56, Nathan Bossart a écrit : - if (!tables_listed) + if (!objects_listed || objfilter

Re: [Proposal] vacuumdb --schema only

2022-04-20 Thread Gilles Darold
Le 18/04/2022 à 23:56, Nathan Bossart a écrit : On Thu, Apr 14, 2022 at 10:27:46PM +0200, Gilles Darold wrote: Attached v8 of the patch that tries to address the remarks above, fixes patch apply failure to master and replace calls to pg_log_error+exit with pg_fatal. Thanks for the new patch

Re: [Proposal] vacuumdb --schema only

2022-04-14 Thread Gilles Darold
Le 11/04/2022 à 20:37, Nathan Bossart a écrit : > On Fri, Apr 08, 2022 at 05:16:06PM +0200, Gilles Darold wrote: >> Attached v7 of the patch that should pass cfbot. > Thanks for the new patch! Unfortunately, it looks like some recent changes > have broken it again. >

Re: [Proposal] vacuumdb --schema only

2022-04-08 Thread Gilles Darold
Le 08/04/2022 à 02:46, Justin Pryzby a écrit : On Wed, Apr 06, 2022 at 07:43:42PM +0200, Gilles Darold wrote: Thanks for the review, all these changes are available in new version v6 of the patch and attached here. This is failing in CI (except on macos, which is strangely passing). http

Re: [Proposal] vacuumdb --schema only

2022-04-08 Thread Gilles Darold
Le 08/04/2022 à 02:46, Justin Pryzby a écrit : On Wed, Apr 06, 2022 at 07:43:42PM +0200, Gilles Darold wrote: Thanks for the review, all these changes are available in new version v6 of the patch and attached here. This is failing in CI (except on macos, which is strangely passing). http

Re: [Proposal] vacuumdb --schema only

2022-04-06 Thread Gilles Darold
ssed in which case the user will know about it. > - */ > -if (!tables_listed) > +else > { > +/* > + * If no tables were listed, filter for the relevant relation types. > If > + * tables were given via --table, don't bother filtering b

Re: [Proposal] vacuumdb --schema only

2022-03-09 Thread Gilles Darold
Le 09/03/2022 à 22:10, Justin Pryzby a écrit : > On Mon, Mar 07, 2022 at 08:38:04AM +0100, Gilles Darold wrote: >>> Maybe it's clearer to write this with =ANY() / != ALL() ? >>> See 002. >> I have applied your changes and produced a new version v3 of the patch, >

Re: [Proposal] vacuumdb --schema only

2022-03-09 Thread Gilles Darold
Hi, New version v4 of the patch to fix a typo in a comment. -- Gilles Darold diff --git a/doc/src/sgml/ref/vacuumdb.sgml b/doc/src/sgml/ref/vacuumdb.sgml index 956c0f01cb..378328afb3 100644 --- a/doc/src/sgml/ref/vacuumdb.sgml +++ b/doc/src/sgml/ref/vacuumdb.sgml @@ -39,6 +39,40 @@ PostgreSQL

Re: [Proposal] vacuumdb --schema only

2022-03-06 Thread Gilles Darold
Le 06/03/2022 à 16:04, Justin Pryzby a écrit : > On Sun, Mar 06, 2022 at 09:39:37AM +0100, Gilles Darold wrote: >> Attached a new patch version that adds the -N | --exclude-schema option >> to the vacuumdb command as suggested. Documentation updated too. >> >> +

Re: [Proposal] vacuumdb --schema only

2022-03-06 Thread Gilles Darold
Le 04/03/2022 à 11:56, Justin Pryzby a écrit : > On Fri, Mar 04, 2022 at 10:11:28AM +0100, Gilles Darold wrote: >> The attached patch implements that. Option -n | --schema can be used >> multiple time and can not be used together with options -a or -t. > Yes, thanks. > >

Re: [Proposal] vacuumdb --schema only

2022-03-04 Thread Gilles Darold
Le 04/03/2022 à 11:56, Justin Pryzby a écrit : On Fri, Mar 04, 2022 at 10:11:28AM +0100, Gilles Darold wrote: The attached patch implements that. Option -n | --schema can be used multiple time and can not be used together with options -a or -t. Yes, thanks. I suggest there should also

[Proposal] vacuumdb --schema only

2022-03-04 Thread Gilles Darold
. But if there is interest in improving these commands I will be pleased to do that, with the syntax suggested. Best regards, -- Gilles Darold diff --git a/doc/src/sgml/ref/vacuumdb.sgml b/doc/src/sgml/ref/vacuumdb.sgml index 956c0f01cb..e4f6d32ba9 100644 --- a/doc/src/sgml/ref/vacuumdb.sgml +++ b/doc/src/sgml

Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

2021-12-15 Thread Gilles Darold
Le 15/12/2021 à 13:41, Peter Eisentraut a écrit : On 03.08.21 19:10, Tom Lane wrote: Gilles Darold writes: Sorry I have missed that, but I'm fine with this implemenation so let's keep the v6 version of the patch and drop this one. Pushed, then.  There's still lots of time to tweak

Re: Pasword expiration warning

2021-11-21 Thread Gilles Darold
lution. The people most likely to benefit from > this are the people least likely to be using psql IMNSHO. Ok, I can try to implement something at server side using a NOTICE message. -- Gilles Darold

Re: Pasword expiration warning

2021-11-19 Thread Gilles Darold
Le 19/11/2021 à 16:55, Tom Lane a écrit : Gilles Darold writes: Now that the security policy is getting stronger, it is not uncommon to create users with a password expiration date (VALID UNTIL). TBH, I thought people were starting to realize that forced password rotations are a net security

Pasword expiration warning

2021-11-19 Thread Gilles Darold
d expiration notice but with psql we don't have it for the moment. If there is interest for this psql feature I can post the patch. -- Gilles Darold

Re: [PATCH] fix references to like_regex

2021-11-02 Thread Gilles Darold
Le 02/11/2021 à 16:50, Tom Lane a écrit : Gilles Darold writes: Since we have the regexp_like operator I have found that there is two references in the documentation about PostgreSQL lacking of LIKE_REGEX implementation. Here is a patch to fix the documentation. I simply remove the reference

[PATCH] fix references to like_regex

2021-11-02 Thread Gilles Darold
"9.7.3.8 Differences from XQuery"  And try to modify chapter "9.16.2.3. SQL/JSON Regular Expressions" to mention the REGEXP_LIKE operator. For the second fix there should be better wording. Best regards, -- Gilles Darold diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.s

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-28 Thread Gilles Darold
Le 28/10/2021 à 16:31, Bruce Momjian a écrit : > On Thu, Oct 28, 2021 at 11:30:27AM +0200, Gilles Darold wrote: >> Fixed with new patch version v7 attached. It also fixes unwanted change >> of some regression tests output reported by the cfbot because I forgot >> to change

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-18 Thread Gilles Darold
Le 18/10/2021 à 17:24, Vik Fearing a écrit : > On 10/18/21 8:44 AM, Gilles Darold wrote: >> Le 17/10/2021 à 23:48, Isaac Morland a écrit : >>> On Sun, 17 Oct 2021 at 17:42, Gilles Darold >> <mailto:gil...@migops.com>> wrote: >>> >>> Note tha

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-18 Thread Gilles Darold
Le 17/10/2021 à 23:48, Isaac Morland a écrit : > On Sun, 17 Oct 2021 at 17:42, Gilles Darold <mailto:gil...@migops.com>> wrote: > > Perhaps I misunderstand what you are saying, but a no-columns table > definitely can return rows: > > psql (12.2) > Type "help&quo

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-17 Thread Gilles Darold
Le 17/10/2021 à 23:04, Vik Fearing a écrit : > On 10/17/21 11:01 PM, Gilles Darold wrote: >>   - Add a check into SET UNEXPANDED code to verify that there is at >> least one column expanded. > What is the point of this? Postgres allows column-less tables. > > Both of th

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-16 Thread Gilles Darold
ion involving other tables in the query you have to define rules. Handling a technical column through a view over the real table require lot of work, this feature will help a lot to save this time. -- Gilles Darold

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-16 Thread Gilles Darold
Le 15/10/2021 à 18:42, Aleksander Alekseev a écrit : > Hi Gilles, > >> Yes, I don't wanted to offend you or to troll. This was just to point >> that the position of "SELECT * is bad practice" is not a good argument >> in my point of view, just because it is allowed for every one. I mean >> that in

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-15 Thread Gilles Darold
Le 15/10/2021 à 21:52, Andrew Dunstan a écrit : On 10/15/21 2:51 PM, Bruce Momjian wrote: On Fri, Oct 15, 2021 at 11:32:53AM +0200, Laurenz Albe wrote: On Thu, 2021-10-14 at 13:16 +0200, Gilles Darold wrote: Here is a proposal to implement HIDDEN columns feature in PostgreSQL. The user

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-15 Thread Gilles Darold
st handle the case. -- Gilles Darold

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-15 Thread Gilles Darold
g I will never said, even if this is a bad practice so I have to find a solution to avoid showing technical columns. If we really want SELECT * to be reserved to DBA then why not removing the star from PG unless you have the admin privilege? -- Gilles Darold

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-15 Thread Gilles Darold
to hide all tsvector columns from query without having to specify it as exception in each query used can save some time. IMHO this is definitively not the same feature. -- Gilles Darold

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-14 Thread Gilles Darold
Le 14/10/2021 à 22:01, Gavin Flower a écrit : > On 15/10/21 07:01, Josef Šimánek wrote: >> čt 14. 10. 2021 v 13:17 odesílatel Gilles Darold >> napsal: >>> Hi, >>> >>> >>> Here is a proposal to implement HIDDEN columns feature in PostgreSQL.

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-14 Thread Gilles Darold
Le 14/10/2021 à 20:55, Gilles Darold a écrit : gilles=# SELECT row_to_json(t.*) FROM htest0 t;    row_to_json --  {"a":1,"b":"htest0 one"}  {"a":2,"b":"htest0 two"} (2 rows) gill

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-14 Thread Gilles Darold
y set. This feature is known like this and I'm not in favor to tear off a leg. -- Gilles Darold

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-14 Thread Gilles Darold
w_to_json --  {"a":1,"b":"htest0 one"}  {"a":2,"b":"htest0 two"} (2 rows) You should have a look at the patch, I don't think that the way it is done there could have gotchas. -- Gilles Darold

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-14 Thread Gilles Darold
g the information_schema views at all is if they're standard-compliant. Ok, I will remove it. -- Gilles Darold

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-14 Thread Gilles Darold
Le 14/10/2021 à 17:38, Jaime Casanova a écrit : On Thu, Oct 14, 2021 at 01:16:45PM +0200, Gilles Darold wrote: Hi, Here is a proposal to implement HIDDEN columns feature in PostgreSQL. Great! Actually I found this very useful, especially for those people using big fields (geometry, files

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-14 Thread Gilles Darold
We can add such filter in psql but how about other clients? They all have to implement their own filtering method. I think the HIDDEN attribute provide a common and basic way to implement that in all client application. -- Gilles Darold http://www.darold.net/

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-14 Thread Gilles Darold
an extension was possible I would not write a patch to core but an extension, this is my common behavior. Best regards, -- Gilles Darold http://www.darold.net/

Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

2021-10-14 Thread Gilles Darold
in some PostgreSQL forks if one is interested by this feature. -- Gilles Darold

Re: Schema variables - new implementation for Postgres 15

2021-09-09 Thread Gilles Darold
1 out of 210 tests. This morning I tested it. I'll recheck it. Pavel I had not this problem yesterday. -- Gilles Darold http://www.darold.net/

Re: Schema variables - new implementation for Postgres 15

2021-09-08 Thread Gilles Darold
Le 08/09/2021 à 13:41, Pavel Stehule a écrit : Hi so 28. 8. 2021 v 11:57 odesílatel Gilles Darold <mailto:gil...@darold.net>> napsal: Hi, Review resume: This patch implements Schema Variables that are database objects that can hold a single or composite value

Re: [PATCH] Hooks at XactCommand level

2021-09-04 Thread Gilles Darold
are proposing this  feature. -- Gilles Darold http://www.darold.net/

Re: Schema variables - new implementation for Postgres 15

2021-08-28 Thread Gilles Darold
LE with NOT NULL and DEFAULT I will change the status to ready for committers. -- Gilles Darold http://www.darold.net/

Re: [PATCH] Hooks at XactCommand level

2021-08-13 Thread Gilles Darold
Le 13/08/2021 à 11:58, Andres Freund a écrit : > Hi, > > On 2021-08-10 10:12:26 +0200, Gilles Darold wrote: >> Sorry for the response delay. I have though about adding this odd hook to be >> able to implement this feature through an extension because I don't think >> th

Re: [PATCH] Hooks at XactCommand level

2021-08-10 Thread Gilles Darold
well the last discussions there is no chance of having this hook included. If there is no contrary opinion I will withdraw the patch from the commitfest. However thank you so much to have taken time to review this proposal. Best regards, -- Gilles Darold diff --git a/src/backend/tcop

Re: [PATCH] Hooks at XactCommand level

2021-08-10 Thread Gilles Darold
that switching the feature on doesn't lead to xid wraparound issues. Adding odd hooks doesn't move us towards a real solution imo. I would like to help on this part but unfortunately I have no idea on how we can improve that. Best regards, -- Gilles Darold

Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

2021-08-03 Thread Gilles Darold
Le 03/08/2021 à 15:39, Tom Lane a écrit : Erik Rijkers writes: On 8/3/21 1:26 PM, Gilles Darold wrote: Le 03/08/2021 à 11:45, Gilles Darold a écrit : Actually I just found that the regexp_like() function doesn't support the start parameter which is something we should support. I saw

Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

2021-08-03 Thread Gilles Darold
Le 03/08/2021 à 11:45, Gilles Darold a écrit : Actually I just found that the regexp_like() function doesn't support the start parameter which is something we should support. I saw that Oracle do not support it but DB2 does and I think we should also support it. I will post a new version

Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

2021-08-03 Thread Gilles Darold
Le 02/08/2021 à 23:22, Gilles Darold a écrit : Le 02/08/2021 à 01:21, Tom Lane a écrit : Gilles Darold writes: [ v5-0001-regexp-foo-functions.patch ] I've gone through this whole patch now, and found quite a lot that I did not like. In no particular order: * Wrapping parentheses around

Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

2021-08-02 Thread Gilles Darold
Le 02/08/2021 à 01:21, Tom Lane a écrit : > Gilles Darold writes: >> [ v5-0001-regexp-foo-functions.patch ] > I've gone through this whole patch now, and found quite a lot that I did > not like. In no particular order: > > * Wrapping parentheses around the user's regexp

Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

2021-08-01 Thread Gilles Darold
helo world Usually a regular expression is always tested by its creator to be sure that this the right one and that it does what is expected. But I agree that it could help the writer to debug its RE. Also if I recall well Oracle and DB2 limit the number of capture groups back references

Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

2021-08-01 Thread Gilles Darold
Le 30/07/2021 à 23:38, Tom Lane a écrit : > Gilles Darold writes: >> Le 26/07/2021 à 21:56, Tom Lane a écrit : >>> I'm inclined to just drop the regexp_replace additions. I don't think >>> that the extra parameters Oracle provides here are especially useful. >&g

Re: Case expression pushdown

2021-07-28 Thread Gilles Darold
one doesn't fail on cfbot too. Best regards, -- Gilles Darold

Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

2021-07-27 Thread Gilles Darold
Le 26/07/2021 à 21:56, Tom Lane a écrit : > Gilles Darold writes: >> [ v4-0001-regexp-foo-functions.patch ] > I started to work through this and was distressed to realize that > it's trying to redefine regexp_replace() in an incompatible way. > We already have > > regress

Re: [PATCH] Hooks at XactCommand level

2021-07-16 Thread Gilles Darold
Le 14/07/2021 à 21:26, Tom Lane a écrit : Gilles Darold writes: I have renamed the patch and the title of this proposal registered in the commitfest "Xact/SubXact event callback at command start" to reflect the last changes that do not include new hooks anymore. Hmm, it doesn't

Re: [PATCH] Hooks at XactCommand level

2021-07-15 Thread Gilles Darold
Le 15/07/2021 à 09:44, Gilles Darold a écrit : Le 14/07/2021 à 21:26, Tom Lane a écrit : Gilles Darold writes: I have renamed the patch and the title of this proposal registered in the commitfest "Xact/SubXact event callback at command start" to reflect the last changes that do n

Re: [PATCH] Hooks at XactCommand level

2021-07-15 Thread Gilles Darold
Le 14/07/2021 à 21:26, Tom Lane a écrit : Gilles Darold writes: I have renamed the patch and the title of this proposal registered in the commitfest "Xact/SubXact event callback at command start" to reflect the last changes that do not include new hooks anymore. Hmm, it doesn't

Re: [PATCH] Hooks at XactCommand level

2021-07-14 Thread Gilles Darold
ROLLBACK TO savepoint). [1] https://github.com/darold/pg_statement_rollbackv2 -- Gilles Darold http://www.darold.net/ diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c index 441445927e..3b5f6bfc2d 100644 --- a/src/backend/access/transam/xact.c +++ b/src/back

Re: Introduce pg_receivewal gzip compression tests

2021-07-12 Thread Gilles Darold
he following instead: +    is (scalar(@gzip_wals), 1, "one gzip compressed WAL was created"); +    is (scalar(@gzip_partial_wals), 1, +        "one partial gzip compressed WAL was created"); -- Gilles Darold http://www.darold.net/

Re: Case expression pushdown

2021-07-07 Thread Gilles Darold
Le 07/07/2021 à 18:55, Gilles Darold a écrit : Le 07/07/2021 à 18:50, Gilles Darold a écrit : Great, I changing the state in the commitfest to "Ready for committers". I'm attaching the v5 patch again as it doesn't appears in the Latest attachment list in the commitfest. And

Re: Case expression pushdown

2021-07-07 Thread Gilles Darold
Le 07/07/2021 à 18:50, Gilles Darold a écrit : Great, I changing the state in the commitfest to "Ready for committers". I'm attaching the v5 patch again as it doesn't appears in the Latest attachment list in the commitfest. -- Gilles Darold MigOps Inc diff --git a/contrib/po

Re: Case expression pushdown

2021-07-07 Thread Gilles Darold
Le 07/07/2021 à 17:39, Alexander Pyhalov a écrit : Hi. Gilles Darold писал 2021-07-07 15:02: Le 22/06/2021 à 15:39, Alexander Pyhalov a écrit : Seino Yuki писал 2021-06-22 16:03: On 2021-06-16 01:29, Alexander Pyhalov wrote: Hi. Ashutosh Bapat писал 2021-06-15 16:24: Looks quite useful

Re: Case expression pushdown

2021-07-07 Thread Gilles Darold
4) = 0 THEN 1 ELSE 2 END) FROM ft1; -- Same but without the ELSE clause EXPLAIN (VERBOSE, COSTS OFF) SELECT sum(CASE WHEN mod(c1, 4) = 0 THEN 1 END) FROM ft1; For convenience I'm attaching a new patch v5 that change the code following my comments above, fix the nested CASE issue and

Re: [PATCH][postgres_fdw] Add push down of CASE WHEN clauses

2021-07-06 Thread Gilles Darold
Le 07/07/2021 à 06:59, David Rowley a écrit : > On Wed, 7 Jul 2021 at 10:18, Gilles Darold wrote: >> I have noticed that postgres_fdw do not push down the CASE WHEN clauses. In >> the following case this normal: > This looks very similar to [1] which is in the current commi

[PATCH][postgres_fdw] Add push down of CASE WHEN clauses

2021-07-06 Thread Gilles Darold
 Planning Time: 0.745 ms  Execution Time: 3.860 ms (5 rows) I don't see a good reason to never push the CASE WHEN clause but perhaps I'm missing something, any though? Best regards, -- Gilles Darold MigOps Inc (http://migops.com) diff --git a/contrib/postgres_fdw/deparse.c b/contrib/p

Re: [PATCH] Hooks at XactCommand level

2021-07-05 Thread Gilles Darold
I'm joining a new patch v4 that removes the need of any hook and adds a new events XACT_EVENT_COMMAND_START and SUBXACT_EVENT_COMMAND_START that can be cautch in the xact callbacks when a new command is to be executed. -- Gilles Darold http://www.darold.net/ diff --git a/src/backend/access/

Re: [PATCH] Hooks at XactCommand level

2021-07-03 Thread Gilles Darold
uted before any command even if the transaction is in abort state to be able to inject the rollback to savepoint, maybe I'm not looking at the right place to do that. Thanks -- Gilles Darold http://www.darold.net/ diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c index 8cea10

Re: Deparsing rewritten query

2021-06-28 Thread Gilles Darold
Le 28/06/2021 à 18:41, Julien Rouhaud a écrit : > Thanks for the feedback Gilles! > > On Mon, Jun 28, 2021 at 04:06:54PM +0200, Gilles Darold wrote: >> If we could at least call get_query_def()through an extension if we didn't >> have a functionit would be ideal for DBAs.I

Re: Deparsing rewritten query

2021-06-28 Thread Gilles Darold
be ideal for DBAs.I agree this is unusual but when it does happen to you being able to call get_query_def () helps a lot. -- Gilles Darold http://www.darold.net/

Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

2021-03-21 Thread Gilles Darold
Le 21/03/2021 à 15:53, Tom Lane a écrit : > Chapman Flack writes: >> If this turns out to be a case of "attached the wrong patch, here's >> the one that does implement foo_regex functions!" then I reserve an >> objection to that. :) >> And the patch renamed. diff --git a/doc/src/sgml/func.sgml

Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

2021-03-21 Thread Gilles Darold
used by regex_replace() and regex_matches(). All regexp modifiers can be used. [1] https://github.com/orafce/orafce/blob/master/orafce--3.14--3.15.sql -- Gilles Darold http://www.darold.net/

Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

2021-03-21 Thread Gilles Darold
Le 21/03/2021 à 12:07, e...@xs4all.nl a écrit : >> On 2021.03.20. 19:48 Gilles Darold wrote: >> >> This is a new version of the patch that now implements all the XQUERY >> regexp functions as described in the standard, minus the differences of >> PostgerSQL re

Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

2021-03-21 Thread Gilles Darold
Le 20/03/2021 à 19:48, Gilles Darold a écrit : > > Hi, > > > This is a new version of the patch that now implements all the XQUERY > regexp functions as described in the standard, minus the differences > of PostgerSQL regular expression explain in [1]. > > > The s

Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

2021-03-20 Thread Gilles Darold
#FUNCTIONS-POSIX-REGEXP [2] https://www.postgresql.org/message-id/flat/bfd5-909d-408b-8531-95b32f18d4ab%40www.fastmail.com#3ec8ba658eeabcae2ac6ccca33bd1aed -- Gilles Darold LzLabs GmbH http://www.lzlabs.com/ diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index fee0561961

Re: [PATCH] Hooks at XactCommand level

2021-03-19 Thread Gilles Darold
Le 12/03/2021 à 06:55, Julien Rouhaud a écrit : > Hi, > > On Tue, Dec 08, 2020 at 11:15:12AM +0100, Gilles Darold wrote: >> Based on a PoC reported in a previous thread [1] I'd like to propose new >> hooks around transaction commands. The objective of this patch is to >>

Re: MultiXact\SLRU buffers configuration

2021-03-15 Thread Gilles Darold
Le 12/03/2021 à 13:44, Andrey Borodin a écrit : > >> 11 марта 2021 г., в 20:50, Gilles Darold написал(а): >> >> >> The patch doesn't apply anymore in master cause of error: patch failed: >> src/backend/utils/init/globals.c:150 >> >> >> &g

Re: MultiXact\SLRU buffers configuration

2021-03-11 Thread Gilles Darold
Le 15/02/2021 à 18:17, Andrey Borodin a écrit : 23 дек. 2020 г., в 21:31, Gilles Darold написал(а): Sorry for the response delay, we have run several others tests trying to figure out the performances gain per patch but unfortunately we have very heratic results. With the same parameters

Re: [PATCH] regexp_positions ( string text, pattern text, flags text ) → setof int4range[]

2021-03-04 Thread Gilles Darold
all start/end positions of an occurrence chained in an integer array {start1,end1,start2,end2,..}. Regards, -- Gilles Darold

Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

2021-03-03 Thread Gilles Darold
My apologies for the links in the head, the email formatting and the missing patch, I accidently send the email too early. -- Gilles diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index bf99f82149..88e08b40d2 100644 --- a/doc/src/sgml/func.sgml +++ b/doc/src/sgml/func.sgml @@

[PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace

2021-03-03 Thread Gilles Darold
ious functions.   - REGEXP_REPLACE( string text, pattern text, replace_string text, [, position int] [, occurrence int] [, flags text ] )     Extend PostgreSQL regexp_replace() by adding position and occurrence capabilities. The patch is ready for testing with documentation and regression tests

Re: MultiXact\SLRU buffers configuration

2020-12-23 Thread Gilles Darold
Le 13/12/2020 à 18:24, Andrey Borodin a écrit : 13 дек. 2020 г., в 14:17, Gilles Darold написал(а): I've done more review on these patches. Thanks, Gilles! I'll incorporate all your fixes to patchset. Can you also benchmark conditional variable sleep? The patch "Add conditional var

Re: [BUG] orphaned function

2020-12-18 Thread Gilles Darold
Le 18/12/2020 à 00:26, Tom Lane a écrit : Gilles Darold writes: The same problem applies if the returned type or the procedural language is dropped. I have tried to fix that in ProcedureCreate() by using an AccessSharedLock for the data types and languages involved in the function declaration

Re: [UNVERIFIED SENDER] Re: [BUG] orphaned function

2020-12-17 Thread Gilles Darold
as it fixes the bug reported. -- Gilles Darold LzLabs GmbH https://www.lzlabs.com/ diff --git a/src/backend/catalog/pg_proc.c b/src/backend/catalog/pg_proc.c index 1dd9ecc063..9b305896a3 100644 --- a/src/backend/catalog/pg_proc.c +++ b/src/backend/catalog/pg_proc.c @@ -34,6 +34,7 @@ #includ

  1   2   >