Re: [HACKERS] monolithic distro

2006-07-14 Thread Lukas Smith
Peter Eisentraut wrote: Lukas Kahwe Smith wrote: whereas PostgreSQL is continuously complaing that MySQL is inferior yet way more popular. Maybe MySQL's popularity is not even PostgreSQL's goal, but I am sure a bit more would be welcome. Does MySQL have a monolithic distribution? Well

[HACKERS] ShmemAlloc() alignment patch

2006-07-14 Thread Qingqing Zhou
In ShmemAlloc() we have: newStart = BUFFERALIGN(newStart); newSpace = (void *) (ShmemBase + newStart); return newSpace; Notice that though newStart is ALIGNOF_BUFFER, ShmemBase is not. Thus the newSpace is not aligned as we disired. Attached please find the patch. Regards, Qingqing

Re: [HACKERS] monolithic distro

2006-07-14 Thread Lukas Smith
Lukas Smith wrote: Peter Eisentraut wrote: Lukas Kahwe Smith wrote: whereas PostgreSQL is continuously complaing that MySQL is inferior yet way more popular. Maybe MySQL's popularity is not even PostgreSQL's goal, but I am sure a bit more would be welcome. Does MySQL have a monolithic

Re: [HACKERS] Fwd: Three weeks left until feature freeze

2006-07-14 Thread Peter Eisentraut
Joshua D. Drake wrote: For example there is NOT an PostgreSQL 8.1 for Ubuntu Breezy. http://packages.ubuntu.com/breezy-backports/misc/ -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 9: In versions below

Re: [HACKERS] ShmemAlloc() alignment patch

2006-07-14 Thread Martijn van Oosterhout
On Fri, Jul 14, 2006 at 02:50:31PM +0800, Qingqing Zhou wrote: In ShmemAlloc() we have: newStart = BUFFERALIGN(newStart); newSpace = (void *) (ShmemBase + newStart); return newSpace; Notice that though newStart is ALIGNOF_BUFFER, ShmemBase is not. Thus the newSpace is not aligned

Re: [HACKERS] pgsql-patches considered harmful

2006-07-14 Thread Hannu Krosing
Ühel kenal päeval, K, 2006-07-12 kell 23:04, kirjutas Marc G. Fournier: On Wed, 12 Jul 2006, Magnus Hagander wrote: There are list servers out there capable of simply ripping any attachments to a message (possibly over a certain size) and stick it on a website, replacing it with a link

Re: [HACKERS] Three weeks left until feature freeze

2006-07-14 Thread Hannu Krosing
Ühel kenal päeval, K, 2006-07-12 kell 17:48, kirjutas Thomas Hallgren: Andrew Dunstan wrote: There is in effect no API at all, other than what is available to all backend modules. If someone wants to create an API which will be both sufficiently stable and sufficiently complete to meet

Re: [HACKERS] monolithic distro

2006-07-14 Thread Lukas Smith
Lukas Smith wrote: Lukas Smith wrote: Peter Eisentraut wrote: Lukas Kahwe Smith wrote: whereas PostgreSQL is continuously complaing that MySQL is inferior yet way more popular. Maybe MySQL's popularity is not even PostgreSQL's goal, but I am sure a bit more would be welcome. Does MySQL have

Re: [HACKERS] monolithic distro

2006-07-14 Thread Andrew Dunstan
Lukas Smith wrote: Since I appreantly like monologs .. MySQL also has other features that are not available via pgfoundery like being able to determine the default charset on the database, table and column level, as well as COLLATE support to determine the sort order at runtime. Anyways

Re: [HACKERS] monolithic distro

2006-07-14 Thread Thomas Hallgren
Andrew Dunstan wrote: The topic here is NOT what features are missing from postgres. Of course it is ;-) Regards, Thomas Hallgren ---(end of broadcast)--- TIP 6: explain analyze is your friend

[HACKERS] xlogdump enhancements

2006-07-14 Thread Diogo Biazus
I'm working on Tom's xlogdump tool to add some functionality.IMHO some useful improvements would be and an idea of implementation:- have an options to output only the transactions with their status and some aggregate data (transaction size). When the user pass a -t parameter, instead of printing

Re: [HACKERS] pgsql-patches considered harmful

2006-07-14 Thread Marc G. Fournier
On Fri, 14 Jul 2006, Hannu Krosing wrote: Ühel kenal päeval, K, 2006-07-12 kell 23:04, kirjutas Marc G. Fournier: On Wed, 12 Jul 2006, Magnus Hagander wrote: There are list servers out there capable of simply ripping any attachments to a message (possibly over a certain size) and stick it on

Re: [HACKERS] xlogdump enhancements

2006-07-14 Thread Martijn van Oosterhout
On Fri, Jul 14, 2006 at 10:43:15AM -0300, Diogo Biazus wrote: I'm working on Tom's xlogdump tool to add some functionality. IMHO some useful improvements would be and an idea of implementation: snip Neato. Looks like good stuff there. - Extract the exact SQL statement in cases of xlog

Re: [HACKERS] xlogdump enhancements

2006-07-14 Thread Jonah H. Harris
On 7/14/06, Martijn van Oosterhout kleptog@svana.org wrote: If you really want to tackle this the hard way, find some other program that does it. Here one written in Perl that can decode most tuples, but not all. It fails because it doesn't recognise all the types. Yep Diogo, Martijn is

Re: [HACKERS] 8.2 features?

2006-07-14 Thread Bernd Helmle
--On Freitag, Juli 14, 2006 01:23:11 +0200 Peter Eisentraut [EMAIL PROTECTED] wrote: . multiple values clauses for INSERT Susanne Ebrecht [EMAIL PROTECTED] was last heard to work on it. Updates, Susanne? I've talked to Susanne today and she's just back from hospital and not available

Re: [HACKERS] [PATCHES] include compile problems

2006-07-14 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Patch applied. Thanks. I suspect the point was that limits.h is needed *instead of* math.h, not *in addition to*. How many of those headers had math.h before? The issue was that an include file included another include file that had

Re: [HACKERS] Fwd: Three weeks left until feature freeze

2006-07-14 Thread Joshua D. Drake
Peter Eisentraut wrote: Joshua D. Drake wrote: For example there is NOT an PostgreSQL 8.1 for Ubuntu Breezy. http://packages.ubuntu.com/breezy-backports/misc/ Thanks Peter :), I knew about backports but didn't know what was in there. But what about when 8.2 comes out? Doubtful that they

Re: [HACKERS] 8.2 features?

2006-07-14 Thread Andrew Dunstan
Bernd Helmle wrote: --On Freitag, Juli 14, 2006 01:23:11 +0200 Peter Eisentraut [EMAIL PROTECTED] wrote: . multiple values clauses for INSERT Susanne Ebrecht [EMAIL PROTECTED] was last heard to work on it. Updates, Susanne? I've talked to Susanne today and she's just back from

[HACKERS] contrib promotion?

2006-07-14 Thread Andrew Dunstan
There has been action to clean up and remove some contrib modules, and this is good. I would like to suggest that we should try to move one or two the other way, namely right into the core proper, on the ground that they have widespread applicability and should have maximum visibility. I'm

Re: [HACKERS] xlogdump enhancements

2006-07-14 Thread Diogo Biazus
On 7/14/06, Jonah H. Harris [EMAIL PROTECTED] wrote: On 7/14/06, Martijn van Oosterhout kleptog@svana.org wrote: If you really want to tackle this the hard way, find some other program that does it. Here one written in Perl that can decode most tuples, but not all. It fails because it doesn't

Re: [HACKERS] monolithic distro

2006-07-14 Thread Joshua D. Drake
Since I appreantly like monologs .. MySQL also has other features that are not available via pgfoundery like being able to determine the default charset on the database, table and column level, as well as COLLATE support to determine the sort order at runtime. SHOW ALL; ? Anyways what I

Re: [HACKERS] [PATCHES] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()

2006-07-14 Thread Tom Lane
Charles Duffy [EMAIL PROTECTED] writes: On 7/12/06, Qingqing Zhou [EMAIL PROTECTED] wrote: the problem here is that 29247 doesn't look like a big number so I can't see why your patch solved the problem, unless the qsort_comparetup() function of the data type eats too many circles or the cpu is

Re: [HACKERS] ShmemAlloc() alignment patch

2006-07-14 Thread Tom Lane
Martijn van Oosterhout kleptog@svana.org writes: On Fri, Jul 14, 2006 at 02:50:31PM +0800, Qingqing Zhou wrote: Notice that though newStart is ALIGNOF_BUFFER, ShmemBase is not. Thus the newSpace is not aligned as we disired. How can ShmemBase not be aligned? Surely it's page-aligned? That's

Re: [HACKERS] ShmemAlloc() alignment patch

2006-07-14 Thread Bruce Momjian
Tom Lane wrote: Martijn van Oosterhout kleptog@svana.org writes: On Fri, Jul 14, 2006 at 02:50:31PM +0800, Qingqing Zhou wrote: Notice that though newStart is ALIGNOF_BUFFER, ShmemBase is not. Thus the newSpace is not aligned as we disired. How can ShmemBase not be aligned? Surely it's

Re: [HACKERS] ShmemAlloc() alignment patch

2006-07-14 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: How can ShmemBase not be aligned? Surely it's page-aligned? Should we add an assert? No, because even if it's not page-aligned, there's no correctness issue here. (Besides, how would you know what the page size is on any given platform?)

[HACKERS] Forcing wal rotation

2006-07-14 Thread Florian G. Pflug
Hi For my warm-standby-cluster I'm now saving the currently used wal using rsync, to avoid loosing data from a few hours (or days) ago, when there is little traffic, and thus the wal isn't rotated. For online backups, the problem is even worse, because a backup might me unuseable even hours

Re: [HACKERS] Forcing wal rotation

2006-07-14 Thread Florian G. Pflug
A.M. wrote: On Fri, July 14, 2006 11:20 am, Florian G. Pflug wrote: Hi For my warm-standby-cluster I'm now saving the currently used wal using rsync, to avoid loosing data from a few hours (or days) ago, when there is little traffic, and thus the wal isn't rotated. For online backups, the

Re: [HACKERS] Forcing wal rotation

2006-07-14 Thread Martijn van Oosterhout
On Fri, Jul 14, 2006 at 05:36:58PM +0200, Florian G. Pflug wrote: That was the idea - providing pg_rotate_wal(), which would guarantee that the wal is rotatted at least once if called. Thinking further about this, for a first prove of concept, I'd be enough to write a C function

Re: [HACKERS] Forcing wal rotation

2006-07-14 Thread Florian G. Pflug
Martijn van Oosterhout wrote: On Fri, Jul 14, 2006 at 05:36:58PM +0200, Florian G. Pflug wrote: That was the idea - providing pg_rotate_wal(), which would guarantee that the wal is rotatted at least once if called. Thinking further about this, for a first prove of concept, I'd be enough to

Re: [HACKERS] contrib promotion?

2006-07-14 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: There has been action to clean up and remove some contrib modules, and this is good. I would like to suggest that we should try to move one or two the other way, namely right into the core proper, on the ground that they have widespread applicability

Re: [HACKERS] [COMMITTERS] pgsql: Have find_static skip main() functions.

2006-07-14 Thread Tom Lane
[EMAIL PROTECTED] (Bruce Momjian) writes: Have find_static skip main() functions. Uh-oh, don't tell me you are cranking up to run *that* thing again. This time around, please do not remove API functions just because you can't find a reference to them in the core code. I would like to see a

Re: [HACKERS] Forcing wal rotation

2006-07-14 Thread Tom Lane
Florian G. Pflug [EMAIL PROTECTED] writes: I've now thought about how to fix that without doing that rather crude rsync-pg_xlog-hack. I've read through the code, and learned that wal-segments are expected to have a specific size - thus rotating them early is not that easy. Simon was

Re: [HACKERS] Forcing wal rotation

2006-07-14 Thread Dave Page
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Florian G. Pflug Sent: 14 July 2006 16:37 To: Postgresql-General Cc: A.M. Subject: Re: [HACKERS] Forcing wal rotation How about an SQL-level function that calls the wal scripts? This would

Re: [HACKERS] contrib promotion?

2006-07-14 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: There has been action to clean up and remove some contrib modules, and this is good. I would like to suggest that we should try to move one or two the other way, namely right into the core proper, on the ground that they have

Re: [HACKERS] [PATCHES] [patch 0/9] annual pgcrypto update

2006-07-14 Thread Marko Kreen
On 7/13/06, Neil Conway [EMAIL PROTECTED] wrote: Marko, can you take a look at what is causing this regression test failure? The failing machine is kudu: Seems you have skipped the CAST5 patch. Could you recheck? -- marko ---(end of

Re: [HACKERS] contrib promotion?

2006-07-14 Thread Joshua D. Drake
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: There has been action to clean up and remove some contrib modules, and this is good. I would like to suggest that we should try to move one or two the other way, namely right into the core proper, on the ground that they have widespread

Re: [HACKERS] contrib promotion?

2006-07-14 Thread Tom Lane
Joshua D. Drake [EMAIL PROTECTED] writes: Tom Lane wrote: I don't see a strong need for moving pgcrypto into core, and there's at least one argument against it: if someone needs a crypto-free version of postgres for use someplace with benighted laws, they would be screwed. Doesn't our

Re: [HACKERS] Forcing wal rotation

2006-07-14 Thread Simon Riggs
On Fri, 2006-07-14 at 12:09 -0400, Tom Lane wrote: Florian G. Pflug [EMAIL PROTECTED] writes: I've now thought about how to fix that without doing that rather crude rsync-pg_xlog-hack. I've read through the code, and learned that wal-segments are expected to have a specific size -

Re: [HACKERS] contrib promotion?

2006-07-14 Thread John DeSoi
On Jul 14, 2006, at 12:32 PM, Joshua D. Drake wrote: Doesn't our inclusion of md5() pretty much blow that argument away? (Just asking). I don't think so because md5 is just a one way hash function. There is no method to decrypt anything :). John DeSoi, Ph.D. http://pgedit.com/ Power

Re: [HACKERS] contrib promotion?

2006-07-14 Thread Peter Eisentraut
Andrew Dunstan wrote: I don't see a strong need for moving pgcrypto into core, and there's at least one argument against it: if someone needs a crypto-free version of postgres for use someplace with benighted laws, they would be screwed. Could that be handled with a configure option? In

Re: [HACKERS] [PATCHES] build with different options than Bruce

2006-07-14 Thread Tom Lane
Kris Jurka [EMAIL PROTECTED] writes: When building with --enable-cassert, without --enable-thread-safety, or when the OS supports USE_WIDE_UPPER_LOWER we need some more include files. Done, thanks. regards, tom lane ---(end of

Re: [HACKERS] [PATCHES] c.h is the problem of msvc.

2006-07-14 Thread Tom Lane
Hiroshi Saito [EMAIL PROTECTED] writes: --- src/include/c.h.orig Sat Jul 15 01:38:59 2006 +++ src/include/c.h Sat Jul 15 01:40:04 2006 @@ -60,7 +60,9 @@ #if defined(_MSC_VER) || defined(__BORLANDC__) #define WIN32_ONLY_COMPILER #define errcode __vc_errcode +#if (_MSC_VER

Re: [HACKERS] [PATCHES] [patch 0/9] annual pgcrypto update

2006-07-14 Thread Tom Lane
I wrote: Applied, thanks. What I now see is that pgp-pubkey-decrypt passes on a 32-bit machine but dumps core on a 64-bit machine, with SIGSEGV here: Addendum: seems it only fails without openssl. regards, tom lane ---(end of

Re: [HACKERS] contrib promotion?

2006-07-14 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Doesn't our inclusion of md5() pretty much blow that argument away? (Just asking). I don't think so because md5 is just a one way hash function. There is no method to decrypt anything :). Actually, I've had to install pgcrypto on more than one

Re: [HACKERS] contrib promotion?

2006-07-14 Thread Stefan Kaltenbrunner
Greg Sabino Mullane wrote: Doesn't our inclusion of md5() pretty much blow that argument away? (Just asking). I don't think so because md5 is just a one way hash function. There is no method to decrypt anything :). Actually, I've had to install pgcrypto on more than one occasion for

[HACKERS] src/tools/pginclude considered harmful (was Re: [PATCHES] toast index entries again)

2006-07-14 Thread Tom Lane
Kris Jurka [EMAIL PROTECTED] writes: The inclusion of access/tuptoaster.h in access/common/indextuple.c brought in the define of TOAST_INDEX_HACK which compresses large index entries. When this was removed the entries were no longer compressed which caused btree_gist to fail. This is

Re: [HACKERS] [PATCHES] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()

2006-07-14 Thread Tom Lane
Charles Duffy [EMAIL PROTECTED] writes: [ CHECK_FOR_INTERRUPTS inside qsort comparison routine ] It occurs to me that there's a nonzero risk of problems here, because if the interrupt occurs qsort() will lose control. I'm wondering whether there are any implementations of qsort() that allocate

Re: [HACKERS] contrib promotion?

2006-07-14 Thread Andrew Dunstan
Peter Eisentraut wrote: Quite apart from anything else, it's important that we do get better docco on these modules. I'm willing to help with DocBook options. What do you have in mind? Well, if we could make provision for sucking in a chapter per contrib module if it exists that

Re: [HACKERS] [PATCHES] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()

2006-07-14 Thread Peter Eisentraut
Tom Lane wrote: We might have to just tolerate this, but if it occurs on a lot of platforms I'd have second thoughts about applying the patch. Anyone familiar with the internals of glibc's qsort, in particular? Doesn't look like it's allocating any nonlocal memory:

Re: [HACKERS] [PATCHES] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()

2006-07-14 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: Tom Lane wrote: We might have to just tolerate this, but if it occurs on a lot of platforms I'd have second thoughts about applying the patch. Anyone familiar with the internals of glibc's qsort, in particular? Doesn't look like it's allocating any

Re: [HACKERS] src/tools/pginclude considered harmful (was Re: [PATCHES]

2006-07-14 Thread Andrew Dunstan
Tom Lane wrote: In combination with the amount of time wasted over the past two days, it is now perfectly clear that the existing pginclude tools are not NEARLY good enough to detect what they are breaking. I would like to propose that we revert all the include-related changes of the past two

Re: [HACKERS] [PATCHES] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()

2006-07-14 Thread Peter Eisentraut
Tom Lane wrote: Doesn't look like it's allocating any nonlocal memory: http://sourceware.org/cgi-bin/cvsweb.cgi/libc/stdlib/qsort.c?rev=1. 12content-type=text/x-cvsweb-markupcvsroot=glibc But this file defines _quicksort() not qsort(). I was under the impression that the latter is

Re: [HACKERS] src/tools/pginclude considered harmful (was Re: [PATCHES]

2006-07-14 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: I agree with reverting. The tool looks pretty broken anyway, with hardcoded paths and all sorts of stuff quite apart from logic problems. Well, it's only intended to work on Bruce's system, so until someone else takes over the position of chief

Re: [HACKERS] Three weeks left until feature freeze

2006-07-14 Thread Zoltan Boszormenyi
Hi, Bruce Momjian írta: There are roughly three weeks left until the feature freeze on August 1. If people are working on items, they should be announced before August 1, and the patches submitted by August 1. If the patch is large, it should be discussed now and an intermediate patch posted

Re: [HACKERS] src/tools/pginclude considered harmful (was Re: [PATCHES]

2006-07-14 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: I agree with reverting. The tool looks pretty broken anyway, with hardcoded paths and all sorts of stuff quite apart from logic problems. Well, it's only intended to work on Bruce's system, so until someone else takes over the

Re: [HACKERS] [PATCHES] putting CHECK_FOR_INTERRUPTS in qsort_comparetup()

2006-07-14 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: The merge sort is here: http://sourceware.org/cgi-bin/cvsweb.cgi/libc/stdlib/msort.c?rev=1.21content-type=text/x-cvsweb-markupcvsroot=glibc It uses alloca, so we're good here. Uh ... but it also uses malloc, and potentially a honkin' big malloc at

Re: [HACKERS] src/tools/pginclude considered harmful (was Re:

2006-07-14 Thread Bruce Momjian
Tom Lane wrote: Martijn van Oosterhout kleptog@svana.org writes: On Fri, Jul 14, 2006 at 04:24:59PM -0400, Tom Lane wrote: After some reflection it seems that there is only one case where removal of a needed include file would not lead to a compiler error or warning, assuming gcc with

Re: [HACKERS] src/tools/pginclude considered harmful (was Re:

2006-07-14 Thread Bruce Momjian
Andrew Dunstan wrote: Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: I agree with reverting. The tool looks pretty broken anyway, with hardcoded paths and all sorts of stuff quite apart from logic problems. Well, it's only intended to work on Bruce's system, so

Re: [HACKERS] src/tools/pginclude considered harmful (was Re:

2006-07-14 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: BTW, one of the remaining holes in pgrminclude is that it compiles with -fsyntax-only, which apparently causes it to fail to detect some errors of significance --- I assume that's how it managed to foul up lmgr.c,

Re: [HACKERS] src/tools/pginclude considered harmful (was Re: [PATCHES]

2006-07-14 Thread Martijn van Oosterhout
On Fri, Jul 14, 2006 at 04:24:59PM -0400, Tom Lane wrote: After some reflection it seems that there is only one case where removal of a needed include file would not lead to a compiler error or warning, assuming gcc with ordinary -W settings (notably -Wmissing-prototypes). That case is exactly

Re: [HACKERS] Three weeks left until feature freeze

2006-07-14 Thread Tom Lane
Zoltan Boszormenyi [EMAIL PROTECTED] writes: I am working on adding a new column contraint, namely the GENERATED [ALWAYS | BY DEFAULT ] AS [ IDENTITY ( sequence_options ) | ( expression )] Doesn't this still have the issue that we're taking over spec-defined syntax to represent behavior that

Re: [HACKERS] src/tools/pginclude considered harmful (was Re:

2006-07-14 Thread Neil Conway
On Fri, 2006-07-14 at 14:20 -0400, Tom Lane wrote: I would like to propose that we revert all the include-related changes of the past two days, and that src/tools/pginclude be removed from the CVS tree, until such time as it is rewritten to be much smarter about what it is doing. Rather than

Re: [HACKERS] [PATCHES] c.h is the problem of msvc.

2006-07-14 Thread Hiroshi Saito
Ooops, I am uncertain at the reason for not knowing __BORLANDC__... It will be sure if __BORLANDC__ has the definition. Thanks. Regards, Hiroshi Saito From: Tom Lane Hiroshi Saito [EMAIL PROTECTED] writes: --- src/include/c.h.orig Sat Jul 15 01:38:59 2006 +++ src/include/c.h Sat Jul 15

Re: [HACKERS] src/tools/pginclude considered harmful (was Re: [PATCHES]

2006-07-14 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: BTW, one of the remaining holes in pgrminclude is that it compiles with -fsyntax-only, which apparently causes it to fail to detect some errors of significance --- I assume that's how it managed to foul up lmgr.c, inet_net_ntop.c, etc.

Re: [HACKERS] src/tools/pginclude considered harmful (was Re: [PATCHES]

2006-07-14 Thread Tom Lane
Martijn van Oosterhout kleptog@svana.org writes: On Fri, Jul 14, 2006 at 04:24:59PM -0400, Tom Lane wrote: After some reflection it seems that there is only one case where removal of a needed include file would not lead to a compiler error or warning, assuming gcc with ordinary -W settings

Re: [HACKERS] contrib promotion?

2006-07-14 Thread Teodor Sigaev
tsearch2 is functionality that definitely should be in core eventually, but even Oleg still says it's not done. Aside from the documentation issue, it's not clear that we've got a stable API for it. Issues/TODO to move tsearch2 into core (by fast look) * memory management. Dictionaries and

Re: [HACKERS] Forcing wal rotation

2006-07-14 Thread Florian G. Pflug
Simon Riggs wrote: On Fri, 2006-07-14 at 12:09 -0400, Tom Lane wrote: Florian G. Pflug [EMAIL PROTECTED] writes: I've now thought about how to fix that without doing that rather crude rsync-pg_xlog-hack. I've read through the code, and learned that wal-segments are expected to have a

Re: [HACKERS] src/tools/pginclude considered harmful (was Re: [PATCHES] toast index entries again)

2006-07-14 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: On Fri, 2006-07-14 at 14:20 -0400, Tom Lane wrote: I would like to propose that we revert all the include-related changes of the past two days, and that src/tools/pginclude be removed from the CVS tree, until such time as it is rewritten to be much smarter

Re: [HACKERS] Patch to mark items as static or not used

2006-07-14 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: This time around, please do not remove API functions just because you can't find a reference to them in the core code. I would like to see a posted, discussed patch first. OK, here is my match to mark items as static or not used:

Re: [HACKERS] Patch to mark items as static or not used

2006-07-14 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: This time around, please do not remove API functions just because you can't find a reference to them in the core code. I would like to see a posted, discussed patch first. OK, here is my match to mark items as

Re: [HACKERS] Patch to mark items as static or not used

2006-07-14 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: The fundamental problem with find_static is that it hasn't got a clue about likely future changes, nor about what we think external add-ons might want ... OK, I don't really have a clue either. Is any of it valid? I don't object to

Re: [HACKERS] Patch to mark items as static or not used

2006-07-14 Thread Neil Conway
On Sat, 2006-07-15 at 00:05 -0400, Tom Lane wrote: The fundamental problem with find_static is that it hasn't got a clue about likely future changes, nor about what we think external add-ons might want We could annotate the source to indicate that some functions are deliberately intended to be