[HACKERS] Assignment of valid collation for SET operations on queries with UNKNOWN types.

2016-11-16 Thread Rahila Syed
Following UNION of two queries with constant literals runs successfully. CASE 1: postgres=# SELECT 'abc' UNION SELECT 'bcd' ; ?column? -- abc bcd (2 rows) whereas when these literals are part of a view, the UNION fails. CASE 2: postgres=# create view v as select 'abc' a; 2016-11-16

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Erik Rijkers
On 2016-11-17 02:15, Peter Eisentraut wrote: On 11/16/16 1:14 PM, Erik Rijkers wrote: real5m21.348s -- for 'make -j 8 html' versus real1m8.502s -- for 'make -j 8 oldhtml' Centos 6.6 - I suppose it's getting a bit old, I don't know if that's the cause of the discrepancy with other's

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Craig Ringer
On 17 November 2016 at 12:23, Michael Paquier wrote: > On Wed, Nov 16, 2016 at 6:54 PM, Craig Ringer wrote: >> In all seriousness, though, lets query the buildfarm database for Perl >> versions. Let it answer. > > castoroides, Solaris 10 and perl

Re: [HACKERS] Exclude pg_largeobject form pg_dump

2016-11-16 Thread Amul Sul
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:tested, passed Patch v6 looks good to me, passing to committer. Thanks ! The

Re: [HACKERS] [bug fix] Cascading standby cannot catch up and get stuck emitting the same message repeatedly

2016-11-16 Thread Tsunakawa, Takayuki
From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Amit Kapila > I think it beginning of segment (aka the first page of the segment), even > the comment indicates the same. > > /* > * Whenever switching to a new WAL segment, we read the first page

Re: [HACKERS] Push down more full joins in postgres_fdw

2016-11-16 Thread Etsuro Fujita
On 2016/11/16 18:14, Ashutosh Bapat wrote: (1) You added the following comments to deparseSelectSql: + /* +* For a non-base relation, use the input tlist. If a base relation is +* being deparsed as a subquery, use input tlist, if the caller has passed +* one. The

Re: [HACKERS] Remove the comment on the countereffectiveness of large shared_buffers on Windows

2016-11-16 Thread Tsunakawa, Takayuki
From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Amit Kapila > > I think the reason why increasing shared_buffers didn't give better > performance for read-only tests than you expect is that the relation files > are cached in the filesystem cache.

Re: [HACKERS] Unlogged tables cleanup

2016-11-16 Thread Michael Paquier
On Wed, Nov 16, 2016 at 7:09 PM, Robert Haas wrote: > On Wed, Nov 16, 2016 at 3:54 PM, Michael Paquier > wrote: >> Indeed I missed this comment block. Please let me suggest the following >> instead: >> /* >> * Set up an init fork for an

Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol

2016-11-16 Thread Michael Paquier
On Wed, Nov 16, 2016 at 8:04 PM, Michael Paquier wrote: > In the current set of patches, the sha2 functions would not get used > until the main patch for SCRAM gets committed so that's a couple of > steps and many months ahead.. And --as-needed/--no-as-needed are not >

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Michael Paquier
On Wed, Nov 16, 2016 at 6:54 PM, Craig Ringer wrote: > In all seriousness, though, lets query the buildfarm database for Perl > versions. Let it answer. castoroides, Solaris 10 and perl 5.8.4, no?

Re: [HACKERS] Re: [sqlsmith] FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)", File: "xlog.c", Line: 10200)

2016-11-16 Thread Michael Paquier
On Mon, Nov 7, 2016 at 6:18 PM, Kyotaro HORIGUCHI wrote: > I will mark this as "Ready for Committer". I have just noticed that Robert has switched this patch to "needs review" by mistake (I think that there was a mistake with another patch), so I have switched it

Re: [HACKERS] Fun fact about autovacuum and orphan temp tables

2016-11-16 Thread Michael Paquier
On Wed, Nov 16, 2016 at 5:24 PM, Haribabu Kommi wrote: > This is a gentle reminder. > > you assigned as reviewer to the current patch in the 11-2016 commitfest. > But you haven't shared your review yet. Can you please try to share your > views > about the patch. This

Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol

2016-11-16 Thread Michael Paquier
On Wed, Nov 16, 2016 at 6:51 PM, Robert Haas wrote: > So, it seems that the linker is willing to drop archive members if the > entire .o file is used, but not individual symbols. That explains why > Michael thinks we need to do something special here, because with his >

Re: [HACKERS] pg_dump versus rules, once again

2016-11-16 Thread Robert Haas
On Wed, Nov 16, 2016 at 10:14 PM, Tom Lane wrote: > Robert Haas writes: >> On Wed, Nov 16, 2016 at 10:00 PM, Tom Lane wrote: >>> The changes in pg_backup_archiver.c would have to be back-patched >>> into all versions supporting

Re: [HACKERS] Improve OOM handling in pg_locale.c

2016-11-16 Thread Mithun Cy
On Thu, Oct 13, 2016 at 1:40 PM, Michael Paquier wrote: > I am attaching that to the next CF. I have tested this patch. Now we error out as OOM instead of crash. postgres=# SELECT '12.34'::money; ERROR: out of memory

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Kyotaro HORIGUCHI 
Hello,

At Thu, 17 Nov 2016 11:59:02 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI 
 wrote in 
<20161117.115902.224922490.horiguchi.kyot...@lab.ntt.co.jp>
> My only concern is the fact that 'make check-world' runs the TAP
> tests as a part if

Re: [HACKERS] pg_dump versus rules, once again

2016-11-16 Thread Tom Lane
Robert Haas writes: > On Wed, Nov 16, 2016 at 10:00 PM, Tom Lane wrote: >> The changes in pg_backup_archiver.c would have to be back-patched >> into all versions supporting --if-exists, so that they don't fail >> on dump archives produced by patched

Re: [HACKERS] Unlogged tables cleanup

2016-11-16 Thread Robert Haas
On Wed, Nov 16, 2016 at 3:54 PM, Michael Paquier wrote: > On Wed, Nov 16, 2016 at 11:45 AM, Robert Haas wrote: >> The header comment for heap_create_init_fork() says this: >> >> /* >> * Set up an init fork for an unlogged table so that it can be

Re: [HACKERS] pg_dump versus rules, once again

2016-11-16 Thread Robert Haas
On Wed, Nov 16, 2016 at 10:00 PM, Tom Lane wrote: > The changes in pg_backup_archiver.c would have to be back-patched > into all versions supporting --if-exists, so that they don't fail > on dump archives produced by patched versions. Even if you patch future minor releases,

Re: [HACKERS] pg_dump versus rules, once again

2016-11-16 Thread Tom Lane
I wrote: > We've talked before about replacing this _RETURN-rule business with > CREATE OR REPLACE VIEW, ie the idea would be for pg_dump to first emit > a dummy view with the right column names/types, say > CREATE VIEW vv AS SELECT null::int AS f1, null::text AS f2; > and then later when it's

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Kyotaro HORIGUCHI
At Thu, 17 Nov 2016 10:42:54 +0800, Craig Ringer wrote in > On 17 November 2016 at 10:31, Kyotaro HORIGUCHI > wrote: > > > > > I vote +1 to upgrading perl, but I'm not

Re: [HACKERS] Patch: Implement failover on libpq connect level.

2016-11-16 Thread Robert Haas
On Wed, Nov 16, 2016 at 9:00 PM, Tsunakawa, Takayuki wrote: > Do we really want to enable libpq failover against pre-V10 servers? I don't > think so, as libpq is a part of PostgreSQL and libpq failover is a new > feature in PostgreSQL 10. At least, as one user,

Re: [HACKERS] Patch: Implement failover on libpq connect level.

2016-11-16 Thread Tsunakawa, Takayuki
From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Robert Haas > Hmm, let's go back to the JDBC method, then. "show transaction_read_only" > will return true on a standby, but presumably also on any other non-writable > node. You could even force

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Craig Ringer
On 17 November 2016 at 10:42, Craig Ringer wrote: > But sure, if it's easier, we can have 5.8.0 in the README. What's five > extra years matter anyway? Hey, while we're at it, lets change Pg to > build on Borland C and require K style! Sorry. That was unnecessary. I

Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol

2016-11-16 Thread Robert Haas
On Wed, Nov 16, 2016 at 7:36 PM, Andres Freund wrote: > With -Wl,--as-neeeded the linker will dismiss unused symbols found in a > static library. Maybe that's the difference? The man page --as-needed says that --as-needed modifies the behavior of dynamic libraries, not static

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Craig Ringer
On 17 November 2016 at 10:31, Kyotaro HORIGUCHI wrote: > > I vote +1 to upgrading perl, but I'm not sure if all supporting > platforms other than linux support the version of perl. > > Anyway ./configure is saying as the following. > > | *** The installed version

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Kyotaro HORIGUCHI
Hello, At Thu, 17 Nov 2016 10:00:53 +0800, Craig Ringer wrote in > On 17 November 2016 at 00:01, Michael Paquier > wrote: > > On Tue, Nov 15, 2016 at 11:32 PM, Noah Misch

Re: [HACKERS] Patch: Implement failover on libpq connect level.

2016-11-16 Thread Tsunakawa, Takayuki
From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Tatsuo Ishii > In my understanding pg_is_in_recovery() returns true if it's a standby node. > However, even if it returns other than true, the server is not necessarily > a primary. Even it's not

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Craig Ringer
On 17 November 2016 at 00:01, Michael Paquier wrote: > On Tue, Nov 15, 2016 at 11:32 PM, Noah Misch wrote: >> On Wed, Nov 16, 2016 at 12:48:03PM +0800, Craig Ringer wrote: >>> --- a/src/test/perl/README >>> +++ b/src/test/perl/README >>> @@ -64,3

Re: [HACKERS] Patch: Implement failover on libpq connect level.

2016-11-16 Thread Tsunakawa, Takayuki
From: pgsql-hackers-ow...@postgresql.org > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Robert Haas > On Mon, Nov 14, 2016 at 8:09 PM, Tsunakawa, Takayuki > wrote: > > From: pgsql-hackers-ow...@postgresql.org > >>

Re: [HACKERS] [PATCH] Better logging of COPY queries if log_statement='all'

2016-11-16 Thread Haribabu Kommi
Hi Dmitry, This is a gentle reminder. you assigned as reviewer to the current patch in the 11-2016 commitfest. But you haven't shared your review yet. Can you please try to share your views about the patch. This will help us in smoother operation of commitfest. some people are against to the

Re: [HACKERS] Fun fact about autovacuum and orphan temp tables

2016-11-16 Thread Haribabu Kommi
Hi Dilip, This is a gentle reminder. you assigned as reviewer to the current patch in the 11-2016 commitfest. But you haven't shared your review yet. Can you please try to share your views about the patch. This will help us in smoother operation of commitfest. Michael had sent an updated patch

[HACKERS] partial documentation builds

2016-11-16 Thread Peter Eisentraut
Here is a tip for building the documentation faster during development. With the new toolchain, you can build only a part of the documentation, like this: make html XSLTPROCFLAGS='--stringparam rootid pageinspect' where "pageinspect" is some XML id (see the top of pageinspect.sgml in this

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut
On 11/16/16 1:14 PM, Erik Rijkers wrote: > real5m21.348s -- for 'make -j 8 html' > versus > real1m8.502s -- for 'make -j 8 oldhtml' > > Centos 6.6 - I suppose it's getting a bit old, I don't know if that's > the cause of the discrepancy with other's measurements. I tested the build

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut
On 11/16/16 1:23 PM, Alvaro Herrera wrote: > Now admittedly this conversion didn't do one bit towards the goal I > wanted to achieve: that each doc source file ended up as a valid XML > file that could be processed separately with tools like xml2po. They > are still SGML only -- in particular no

Re: [HACKERS] amcheck (B-Tree integrity checking tool)

2016-11-16 Thread Thomas Munro
On Thu, Sep 8, 2016 at 6:44 AM, Peter Geoghegan wrote: > On Fri, Sep 2, 2016 at 11:19 AM, Kevin Grittner wrote: >> IMV the process is to post a patch to this list to certify that it >> is yours to contribute and free of IP encumbrances that would >> prevent us

Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol

2016-11-16 Thread Andres Freund
Hi, On 2016-11-16 19:29:41 -0500, Robert Haas wrote: > On Wed, Nov 16, 2016 at 6:56 PM, Michael Paquier > wrote: > > On Wed, Nov 16, 2016 at 11:24 AM, Robert Haas wrote: > >> diff --git a/contrib/pgcrypto/Makefile b/contrib/pgcrypto/Makefile >

Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol

2016-11-16 Thread Robert Haas
On Wed, Nov 16, 2016 at 6:56 PM, Michael Paquier wrote: > On Wed, Nov 16, 2016 at 11:24 AM, Robert Haas wrote: >> diff --git a/contrib/pgcrypto/Makefile b/contrib/pgcrypto/Makefile >> index 805db76..ddb0183 100644 >> ---

Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol

2016-11-16 Thread Michael Paquier
On Wed, Nov 16, 2016 at 11:24 AM, Robert Haas wrote: > diff --git a/contrib/pgcrypto/Makefile b/contrib/pgcrypto/Makefile > index 805db76..ddb0183 100644 > --- a/contrib/pgcrypto/Makefile > +++ b/contrib/pgcrypto/Makefile > @@ -1,6 +1,6 @@ > # contrib/pgcrypto/Makefile > >

Re: [HACKERS] Improve OOM handling in pg_locale.c

2016-11-16 Thread Haribabu Kommi
Hi Mithun, This is a gentle reminder. you assigned as reviewer to the current patch in the 11-2016 commitfest. But you haven't shared your review yet. Can you please try to share your views about the patch. This will help us in smoother operation of commitfest. Please Ignore if you already

Re: [HACKERS] pg_dump / copy bugs with "big lines" ?

2016-11-16 Thread Haribabu Kommi
Hi Tomas and Gerdan, This is a gentle reminder. you both are assigned as reviewers to the current patch in the 11-2016 commitfest. But you haven't shared any reviews yet, can you please try to share your views about the patch. This will help us in smoother operation of commitfest. Please Ignore

Re: [HACKERS] commitfest 2016-11 status summary

2016-11-16 Thread Haribabu Kommi
Hi All, The commitfest status summary after one week of progress: Needs review: 76 Waiting on author: 16 Ready for Commiter: 16 Commited: 32 Moved to next CF: 0 Rejected: 4 Returned with feedback: 3 TOTAL: 147 Overall progress of completion - 26%. week-1 progress of completion - 9%. week-2

Re: [HACKERS] WIP: About CMake v2

2016-11-16 Thread Michael Paquier
On Wed, Nov 16, 2016 at 2:14 PM, Mark Kirkwood wrote: > I see there are some patches for the putenv issue with Visual studio 2013 in > progress on this list - it is probably best to work with the author to see > if 2015 has any new issues and keep all changes for

Re: [HACKERS] WIP: About CMake v2

2016-11-16 Thread Mark Kirkwood
I see there are some patches for the putenv issue with Visual studio 2013 in progress on this list - it is probably best to work with the author to see if 2015 has any new issues and keep all changes for that *out* of the cmake patches. regards Mark On 16/11/16 21:22, Yury Zhuravlev

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Tom Lane
Erik Rijkers writes: > On 2016-11-16 21:59, Peter Eisentraut wrote: >> I have committed another patch to improve the build performance a bit. >> Could you check again? > It is indeed better (three minutes off, nice) but still: > real5m21.348s -- for 'make -j 8 html' > versus

Re: [HACKERS] Hash Indexes

2016-11-16 Thread Robert Haas
On Sat, Nov 12, 2016 at 12:49 AM, Amit Kapila wrote: > You are right and I have changed the code as per your suggestion. So... +/* + * We always maintain the pin on bucket page for whole scan operation, + * so releasing the additional pin we have

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Alvaro Herrera
Peter Eisentraut wrote: > > This xslt build takes 8+ minutes, compared to barely 1 minute for > > 'oldhtml'. > > I have committed another patch to improve the build performance a bit. > Could you check again? After the optimization, on my laptop it takes 2:31 with the new system and 1:58

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Erik Rijkers
On 2016-11-16 21:59, Peter Eisentraut wrote: On 11/16/16 6:29 AM, Erik Rijkers wrote: This xslt build takes 8+ minutes, compared to barely 1 minute for 'oldhtml'. I have committed another patch to improve the build performance a bit. Could you check again? It is indeed better (three

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut
On 11/16/16 6:46 AM, Tom Lane wrote: > What was the improvement we were hoping for, again? Get off an ancient and unmaintained tool chain. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut
On 11/16/16 12:38 PM, Alvaro Herrera wrote: > "make check" still uses DSSSL though. Is that intentional? Is it going > to be changed? It doesn't use DSSSL. Is uses nsgmls to parse the SGML, which is a different thing that will be addressed in a separate step. So, yes, but later. -- Peter

Re: [HACKERS] amcheck (B-Tree integrity checking tool)

2016-11-16 Thread Andres Freund
Hi, I think the patch could use a pgindent run. On 2016-09-07 11:44:01 -0700, Peter Geoghegan wrote: > diff --git a/contrib/amcheck/amcheck--1.0.sql > b/contrib/amcheck/amcheck--1.0.sql > new file mode 100644 > index 000..ebbd6ac > --- /dev/null > +++ b/contrib/amcheck/amcheck--1.0.sql >

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut
On 11/16/16 6:09 AM, Magnus Hagander wrote: > Btw., shouldn't the output web site pages have encoding declarations? > > That gets sent in the http header, doesn't it? That's probably alright, but it would be nicer if the documents were self-contained. -- Peter Eisentraut

Re: [HACKERS] Unlogged tables cleanup

2016-11-16 Thread Michael Paquier
On Wed, Nov 16, 2016 at 11:45 AM, Robert Haas wrote: > The header comment for heap_create_init_fork() says this: > > /* > * Set up an init fork for an unlogged table so that it can be correctly > * reinitialized on restart. Since we're going to do an immediate sync, we >

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut
On 11/16/16 6:29 AM, Erik Rijkers wrote: > On 2016-11-16 08:06, Peter Eisentraut wrote: >> Build HTML documentation using XSLT stylesheets by default >> >> The old DSSSL build is still available for a while using the make >> target >> "oldhtml". > > This xslt build takes 8+ minutes, compared

Re: [HACKERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013

2016-11-16 Thread Christian Ullrich
* Noah Misch wrote: > On Tue, Apr 26, 2016 at 07:39:29PM +0200, Christian Ullrich > wrote: > > * Christian Ullrich wrote: > Patch 1 looks good, except that it should be three patches: > > - cosmetic parts: change whitespace and s/0/NULL/ > - remove CloseHandle() call > - probe for debug CRT

[HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Alvaro Herrera
Peter Eisentraut wrote: > Build HTML documentation using XSLT stylesheets by default "make check" still uses DSSSL though. Is that intentional? Is it going to be changed? -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training &

Re: [HACKERS] Unlogged tables cleanup

2016-11-16 Thread Robert Haas
On Thu, Nov 10, 2016 at 9:25 PM, Michael Paquier wrote: > On Thu, Nov 10, 2016 at 10:52 PM, Kuntal Ghosh > wrote: >> On Thu, Nov 10, 2016 at 3:42 PM, Michael Paquier >> wrote: >>> Nah. Looking at the code the fix

[HACKERS] pg_dump versus rules, once again

2016-11-16 Thread Tom Lane
I looked into the problem reported at https://www.postgresql.org/message-id/b3690957-fd8c-6def-d3ec-e589887dd0f1%40codata.eu It's easy to reproduce. Given this simple database: create table tt (f1 int primary key, f2 text); create view vv as select * from tt group by f1; pg_dump with the

Re: [HACKERS] Remove the comment on the countereffectiveness of large shared_buffers on Windows

2016-11-16 Thread Robert Haas
On Fri, Nov 11, 2016 at 10:03 PM, Amit Kapila wrote: > Right, but for other platforms, the recommendation seems to be 25% of > RAM, can we safely say that for Windows as well? As per test results > in this thread, it seems the read-write performance degrades when >

Re: [HACKERS] proposal: psql \setfileref

2016-11-16 Thread Pavel Stehule
2016-11-16 17:58 GMT+01:00 Tom Lane : > Pavel Stehule writes: > > The Daniel's proposal has important issues: > > > 1. you need to store and hold the content in memory > > 2. you cannot use tab complete - without it this feature lost a usability > >

Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol

2016-11-16 Thread Robert Haas
On Wed, Nov 16, 2016 at 1:53 PM, Michael Paquier wrote: >> Yeah, I don't see a point to that. > > OK, by doing so here is what I have. The patch generated by > format-patch, as well as diffs generated by git diff -M are reduced > and the patch gets half in size. They

Re: [HACKERS] Patch: Implement failover on libpq connect level.

2016-11-16 Thread Robert Haas
On Wed, Nov 16, 2016 at 12:00 PM, Catalin Iacob wrote: > On Wed, Nov 16, 2016 at 2:50 PM, Robert Haas wrote: >> Hmm, let's go back to the JDBC method, then. "show >> transaction_read_only" will return true on a standby, but presumably >> also on

Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol

2016-11-16 Thread Michael Paquier
On Wed, Nov 16, 2016 at 4:46 AM, Robert Haas wrote: > On Tue, Nov 15, 2016 at 5:12 PM, Michael Paquier > wrote: >> On Tue, Nov 15, 2016 at 12:40 PM, Robert Haas wrote: >>> On Tue, Nov 15, 2016 at 2:24 PM, Michael Paquier

Re: [HACKERS] Avoiding pin scan during btree vacuum

2016-11-16 Thread Alvaro Herrera
I am ready now to backpatch this to 9.4 and 9.5; here are the patches. They are pretty similar, but some adjustments were needed due to XLog format changes in 9.5. (I kept most of Simon's original commit message.) This patch has survived in master for a long time, and in released 9.6 for a

Re: [HACKERS] Patch: Implement failover on libpq connect level.

2016-11-16 Thread Catalin Iacob
On Wed, Nov 16, 2016 at 2:50 PM, Robert Haas wrote: > Hmm, let's go back to the JDBC method, then. "show > transaction_read_only" will return true on a standby, but presumably > also on any other non-writable node. You could even force it to be > true artificially if you

Re: [HACKERS] quieting DEBUG3

2016-11-16 Thread Alvaro Herrera
Robert Haas wrote: > Right: me either. So, here is a series of three patches. +1 to the general idea of the three patches. I didn't review nor test them in detail. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training &

Re: [HACKERS] proposal: psql \setfileref

2016-11-16 Thread Tom Lane
Pavel Stehule writes: > The Daniel's proposal has important issues: > 1. you need to store and hold the content in memory > 2. you cannot use tab complete - without it this feature lost a usability > 3. you have to do two steps > 4. Depends on o.s. I think you're

Re: [HACKERS] quieting DEBUG3

2016-11-16 Thread Robert Haas
On Wed, Oct 28, 2015 at 3:10 PM, Alvaro Herrera wrote: > Robert Haas wrote: > >> Another point I want to reiterate - because nobody seems to be >> addressing it - is that some of these messages are totally useless. I >> grant that printing the transaction state (XIDs,

Re: [HACKERS] Patch to implement pg_current_logfile() function

2016-11-16 Thread Karl O. Pinc
On Mon, 7 Nov 2016 23:29:28 +0100 Gilles Darold wrote: > Here is the v13 of the patch, ... Attached is a doc patch to apply on top of v13. It adds a lot more detail regards just what is in the current_logfiles file and when it's in current_logfiles. I'd like review

Re: [HACKERS] proposal: psql \setfileref

2016-11-16 Thread Pavel Stehule
2016-11-16 16:59 GMT+01:00 Robert Haas : > On Tue, Nov 15, 2016 at 11:48 AM, Pavel Stehule > wrote: > >> For text contents, we already have this (pasted right from the doc): > >> > >> testdb=> \set content `cat my_file.txt` > >> testdb=> INSERT

Re: [HACKERS] Document how to set up TAP tests for Perl 5.8.8

2016-11-16 Thread Michael Paquier
On Tue, Nov 15, 2016 at 11:32 PM, Noah Misch wrote: > On Wed, Nov 16, 2016 at 12:48:03PM +0800, Craig Ringer wrote: >> --- a/src/test/perl/README >> +++ b/src/test/perl/README >> @@ -64,3 +64,20 @@ For available PostgreSQL-specific test methods and some >> example tests read

Re: [HACKERS] proposal: psql \setfileref

2016-11-16 Thread Robert Haas
On Tue, Nov 15, 2016 at 11:48 AM, Pavel Stehule wrote: >> For text contents, we already have this (pasted right from the doc): >> >> testdb=> \set content `cat my_file.txt` >> testdb=> INSERT INTO my_table VALUES (:'content'); >> >> Maybe we might look at why it doesn't

Re: [HACKERS] Use of pg_proc.probin is legal?

2016-11-16 Thread Tom Lane
Kohei KaiGai writes: > On the other hands, interpret_AS_clause() raises an ereport if SQL > function tries to use probin except > for C-language. Is it illegal for other languages to use probin field > to store something useful? Well, there's no convention about how to use

Re: [HACKERS] WIP: About CMake v2

2016-11-16 Thread Robert Haas
On Tue, Nov 8, 2016 at 9:12 PM, Michael Paquier wrote: > On Wed, Nov 9, 2016 at 7:54 AM, Craig Ringer > wrote: >> On 9 Nov. 2016 06:37, "Yury Zhuravlev" wrote: >>> This approach I see only in Postgres project

Re: [HACKERS] Parallel execution and prepared statements

2016-11-16 Thread Robert Haas
On Tue, Nov 15, 2016 at 3:57 PM, Tobias Bussmann wrote: > As the patch in [1] targeting the execution of the plan in ExecutePlan > depending on the destination was declined, I hacked around a bit to find > another way to use parallel mode with SQL prepared statements while

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Robert Haas
On Wed, Nov 16, 2016 at 10:16 AM, Andrew Dunstan wrote: > On the buildfarm crake has gone from about 2 minutes to about 3.5 minutes to > run "make doc". That's not good but it's not an eight-fold increase either. On my MacBook, "time make docs" as of

Re: [HACKERS] Parallel execution and prepared statements

2016-11-16 Thread Tobias Bussmann
> Can you once test by just passing CURSOR_OPT_PARALLEL_OK in > PrepareQuery() and run the tests by having forc_parallel_mode=regress? > It seems to me that the code in the planner is changed for setting a > parallelModeNeeded flag, so it might work as it is. Do you mean running a "make

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Robert Haas
On Wed, Nov 16, 2016 at 9:46 AM, Tom Lane wrote: > Erik Rijkers writes: >> This xslt build takes 8+ minutes, compared to barely 1 minute for >> 'oldhtml'. > > I'm just discovering the same. > >> I'd say that is a strong disadvantage. > > I'd say that is flat

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Andrew Dunstan
On 11/16/2016 09:46 AM, Tom Lane wrote: Erik Rijkers writes: This xslt build takes 8+ minutes, compared to barely 1 minute for 'oldhtml'. I'm just discovering the same. I'd say that is a strong disadvantage. I'd say that is flat out unacceptable. I won't ever use this

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Tom Lane
Erik Rijkers writes: > This xslt build takes 8+ minutes, compared to barely 1 minute for > 'oldhtml'. I'm just discovering the same. > I'd say that is a strong disadvantage. I'd say that is flat out unacceptable. I won't ever use this toolchain if it's that much slower than

[HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Erik Rijkers
On 2016-11-16 08:06, Peter Eisentraut wrote: Build HTML documentation using XSLT stylesheets by default The old DSSSL build is still available for a while using the make target "oldhtml". This xslt build takes 8+ minutes, compared to barely 1 minute for 'oldhtml'. I'd say that is a

Re: [HACKERS] switching documentation build to XSLT

2016-11-16 Thread Peter Eisentraut
On 11/10/16 5:49 AM, Peter Eisentraut wrote: > We are now proposing that we change the way the HTML documentation is > built from jade/openjade+docbook-dsssl to xsltproc+docbook-xsl. > The actual patch to make this change is attached. For the build > process, nothing changes, e.g., 'make' or

[HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut
On 11/16/16 1:38 AM, Magnus Hagander wrote: > AFAICT this is because the output is now UTF8 and it used to be LATIN1. > The current output actually has it in the html tags that it's utf8,but > since the old one had no tags specifying it's encoding we hardcoded it > to LATIN1. The old output has

[HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Magnus Hagander
On Wed, Nov 16, 2016 at 3:02 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 11/16/16 1:38 AM, Magnus Hagander wrote: > > AFAICT this is because the output is now UTF8 and it used to be LATIN1. > > The current output actually has it in the html tags that it's utf8,but > >

Re: [HACKERS] Patch: Implement failover on libpq connect level.

2016-11-16 Thread Kevin Grittner
[moving this branch of discussion to pgsql-jdbc] On Tue, Nov 15, 2016 at 10:31 PM, Mithun Cy wrote: > JDBC is sending "show transaction_read_only" to find whether it > is master or not. If true, that's insane. That can be different on each connection to the cluster

Re: [HACKERS] Patch: Implement failover on libpq connect level.

2016-11-16 Thread Robert Haas
On Tue, Nov 15, 2016 at 11:31 PM, Mithun Cy wrote: >> > So I am tempted to just >> > hold my nose and hard-code the SQL as JDBC is presumably already >> doing. > > JDBC is sending "show transaction_read_only" to find whether it is master or > not. > Victor's patch also

Re: [HACKERS] Parallel execution and prepared statements

2016-11-16 Thread Robert Haas
On Tue, Nov 15, 2016 at 10:41 AM, Albe Laurenz wrote: > Tobias Bussmann has discovered an oddity with prepared statements. > > Parallel scan is used with prepared statements, but only if they have > been created with protocol V3 "Parse". > If a prepared statement has been

Re: [HACKERS] Parallel execution and prepared statements

2016-11-16 Thread Amit Kapila
On Wed, Nov 16, 2016 at 7:10 PM, Amit Kapila wrote: > On Wed, Nov 16, 2016 at 2:27 AM, Tobias Bussmann wrote: >> As the patch in [1] targeting the execution of the plan in ExecutePlan >> depending on the destination was declined, I hacked around a

Re: [HACKERS] Parallel execution and prepared statements

2016-11-16 Thread Amit Kapila
On Wed, Nov 16, 2016 at 2:27 AM, Tobias Bussmann wrote: > As the patch in [1] targeting the execution of the plan in ExecutePlan > depending on the destination was declined, I hacked around a bit to find > another way to use parallel mode with SQL prepared statements while

Re: [HACKERS] Snapshot too old logging

2016-11-16 Thread Kevin Grittner
On Wed, Nov 16, 2016 at 6:12 AM, Magnus Hagander wrote: > On Tue, Nov 15, 2016 at 9:23 PM, Alvaro Herrera > wrote: >> Can this happen for relation types other than tables, say materialized >> views? (Your suggested wording omits relation type so

Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol

2016-11-16 Thread Robert Haas
On Tue, Nov 15, 2016 at 5:12 PM, Michael Paquier wrote: > On Tue, Nov 15, 2016 at 12:40 PM, Robert Haas wrote: >> On Tue, Nov 15, 2016 at 2:24 PM, Michael Paquier >> wrote: >>> How do you plug in that with OpenSSL? Are

Re: [HACKERS] Snapshot too old logging

2016-11-16 Thread Robert Haas
On Tue, Nov 15, 2016 at 2:25 PM, Magnus Hagander wrote: > On Tue, Nov 15, 2016 at 8:22 PM, Robert Haas wrote: >> >> On Tue, Nov 15, 2016 at 2:21 PM, Kevin Grittner wrote: >> > On Tue, Nov 15, 2016 at 12:43 PM, Robert Haas

Re: [HACKERS] Snapshot too old logging

2016-11-16 Thread Magnus Hagander
On Tue, Nov 15, 2016 at 9:23 PM, Alvaro Herrera wrote: > Magnus Hagander wrote: > > On Tue, Nov 15, 2016 at 8:22 PM, Robert Haas > wrote: > > > > > On Tue, Nov 15, 2016 at 2:21 PM, Kevin Grittner > wrote: > > > > > That

Re: [HACKERS] Performance degradation in Bitmapscan (commit 75ae538bc3168bf44475240d4e0487ee2f3bb376)

2016-11-16 Thread Dilip Kumar
On Wed, Nov 16, 2016 at 12:58 AM, Andres Freund wrote: > It's not really related to lossy pages, it's just that due to deletions > / insertions a lot more "shapes" of the hashtable are hit. Okay.. > > I suspect that this is with parallelism disabled? Without that the query >

Re: [HACKERS] pg_hba_file_settings view patch

2016-11-16 Thread Ashutosh Bapat
make check run with this patch shows server crashes. regression.out attached. I have run make check after a clean build, tried building it after running configure, but the problem is always reproducible. Do you see this problem? Also the patch has a white space error. git diff --check

Re: [HACKERS] Fractal tree indexing

2016-11-16 Thread Andrew Borodin
Hi hackers! Here is prototype of procrastinating GiST. Or lazy GiST. Or buffered GiST. Indeed, there is nothing fractal about it. The concept is leaf tuples stall on internal pages. From time to time they are pushed down in batches. This code is far from perfect, I've coded this only for the

Re: [HACKERS] Gather Merge

2016-11-16 Thread Rushabh Lathia
On Mon, Nov 14, 2016 at 3:51 PM, Thomas Munro wrote: > On Sat, Nov 12, 2016 at 1:56 AM, Rushabh Lathia > wrote: > > On Fri, Nov 4, 2016 at 8:30 AM, Thomas Munro < > thomas.mu...@enterprisedb.com> > > wrote: > >> + * Portions Copyright

[HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Magnus Hagander
This seems to have broken our website build a bit. If you check https://www.postgresql.org/docs/devel/static/index.html, you'll notice a bunch of bad characters. AFAICT this is because the output is now UTF8 and it used to be LATIN1. The current output actually has it in the html tags that it's

Re: [HACKERS] Push down more full joins in postgres_fdw

2016-11-16 Thread Ashutosh Bapat
Thanks. > except for few things; (1) You added the > following comments to deparseSelectSql: > > + /* > +* For a non-base relation, use the input tlist. If a base relation > is > +* being deparsed as a subquery, use input tlist, if the caller has > passed > +* one.

Re: [HACKERS] WIP: About CMake v2

2016-11-16 Thread Yury Zhuravlev
Mark Kirkwood wrote: Yeah, there seems to be a lot of these. Looking through them almost all concern the addition of piece of code to wrap putenv. e.g: I made this small wrapper special for MSVC 2015 without Service Packs because postgres macross were in conflict with MS internal functions.

  1   2   >