[HACKERS] Query plan optimization for CHECK NO INHERIT and single table?

2012-08-30 Thread Matthias
Hey, I tried out the new CHECK NO INHERIT feature for inherited tables. There seems to be an opportunity to generate slightly better query plans sometimes. E.g. when I do SELECT * FROM base WHERE partition_id = 3 and there exists only one child table for which partition_id = 3 is true I guess

Re: [HACKERS] HEAD crashes on windows when doing VACUUM ANALYZE

2012-08-30 Thread Albe Laurenz
Matthias wrote: when running VACUUM ANALYZE on my database built on win32-x86 from yesterday's git checkout I always get this at some point during VACUUM ANALYZE: LOG: server process (PID 5880) was terminated by exception 0xC094 DETAIL: Failed process was running: VACUUM VERBOSE

Re: [HACKERS] Skip checkpoint on promoting from streaming replication

2012-08-30 Thread Kyotaro HORIGUCHI
Hello, sorry for long absense. At first I was unhappy that you'd removed the restriction that timelines only change on a shutdown checkpoint. But the reality is timelines change at any point in the WAL stream - the only way to tell between end of WAL and a timeline change is by looking for

Re: [HACKERS] Chronic performance issue with Replication Failover and FSM.

2012-08-30 Thread Daniel Farina
On Tue, Mar 13, 2012 at 4:53 PM, Josh Berkus j...@agliodbs.com wrote: 4. On a high-UPDATE workload, this means that the replica assumes tables have no free space until it starts to build a new FSM or autovacuum kicks in on some of the tables, much later on. 5. If your hosting is such that you

Re: [HACKERS] Draft release notes complete

2012-08-30 Thread Magnus Hagander
On Thu, Aug 30, 2012 at 5:20 AM, Peter Eisentraut pete...@gmx.net wrote: On Wed, 2012-08-29 at 22:23 -0400, Alvaro Herrera wrote: Where are we on building the development docs more frequently? Still waiting for details on how it works to set that up on the buildfarm client. Where

Re: [HACKERS] Use of systable_beginscan_ordered in event trigger patch

2012-08-30 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: I find $SUBJECT fairly scary, because systable_beginscan_ordered() is dependent on having a working, non-corrupt index. If you are trying to run the backend with ignore_system_indexes so that you can rebuild corrupt indexes, uses of

Re: [HACKERS] multi-master pgbench?

2012-08-30 Thread Dimitri Fontaine
Tatsuo Ishii is...@postgresql.org writes: Does it support extended query? Does it support V3 protocol? Yes. It also has a proxy mode where it captures the queries sent by the client along with think times and outputs that in the session format it reads from its setup, which is very useful.

[HACKERS] _USE_32BIT_TIME_T Patch

2012-08-30 Thread Owais Khan
Hello, We are getting crash while using plperl on Win32 as ActiveState perl(Win32) uses 32-bit time_t structures. So, We have to compile DB Server's code also with 32-bit time_t structure. Patch is adding _USE_32BIT_TIME_T in preprocessor definitions in case platform is Windows-32 for all

Re: [HACKERS] _USE_32BIT_TIME_T Patch

2012-08-30 Thread Dave Page
On Thu, Aug 30, 2012 at 6:34 AM, Owais Khan owais.k...@enterprisedb.com wrote: Hello, We are getting crash while using plperl on Win32 as ActiveState perl(Win32) uses 32-bit time_t structures. So, We have to compile DB Server's code also with 32-bit time_t structure. Patch is adding

Re: [HACKERS] MySQL search query is not executing in Postgres DB

2012-08-30 Thread David Fetter
On Wed, Aug 29, 2012 at 06:39:37PM -0400, Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On the more general issue, I continue to see minimal risk of harm in allowing things like LPAD() to implicitly cast the first argument to text. Well, I see your point about LPAD(), but the

Re: [HACKERS] MySQL search query is not executing in Postgres DB

2012-08-30 Thread Robert Haas
On Wed, Aug 29, 2012 at 6:39 PM, Tom Lane t...@sss.pgh.pa.us wrote: Well, I see your point about LPAD(), but the problem is how to tell the difference between a harmless cast omission and an actual mistake that the user will be very grateful if we point out. If we allow implicit casts to text

Re: [HACKERS] Getting rid of cheap-startup-cost paths earlier

2012-08-30 Thread Bruce Momjian
On Tue, May 22, 2012 at 08:29:48AM -0400, Robert Haas wrote: On Tue, May 22, 2012 at 1:50 AM, Tom Lane t...@sss.pgh.pa.us wrote: Currently, the planner keeps paths that appear to win on the grounds of either cheapest startup cost or cheapest total cost.  It suddenly struck me that in many

Re: [HACKERS] wal_buffers

2012-08-30 Thread Robert Haas
On Wed, Aug 29, 2012 at 10:25 PM, Peter Geoghegan pe...@2ndquadrant.com wrote: On 19 February 2012 05:24, Robert Haas robertmh...@gmail.com wrote: I have attached tps scatterplots. The obvious conclusion appears to be that, with only 16MB of wal_buffers, the buffer wraps around with some

Re: [HACKERS] Query plan optimization for CHECK NO INHERIT and single table?

2012-08-30 Thread Robert Haas
On Thu, Aug 30, 2012 at 2:00 AM, Matthias nitrogen...@gmail.com wrote: Hey, I tried out the new CHECK NO INHERIT feature for inherited tables. There seems to be an opportunity to generate slightly better query plans sometimes. E.g. when I do SELECT * FROM base WHERE partition_id = 3 and

Re: [HACKERS] Chronic performance issue with Replication Failover and FSM.

2012-08-30 Thread Tom Lane
Daniel Farina dan...@heroku.com writes: but just today we promoted another system via streaming replication to pick up the planner fix in 9.1.5 (did you know: that planner bug seems to make GIN FTS indexes un-used in non-exotic cases, and one goes to seqscan?), and then a 40MB GIN index

[HACKERS] rows modified in current transaction

2012-08-30 Thread Miroslav Šimulčík
Hi, is there any way to check if row have already been modified by the current transaction? I tried condition txid_current() = xmin, but there is problem with the savepoints. After every savepoint rows are getting higher xmin values, but txid_current() remains the same. Regards, Miroslav

Re: [HACKERS] Minor comment fixups

2012-08-30 Thread Robert Haas
On Mon, Aug 27, 2012 at 11:21 PM, Jeff Davis pg...@j-davis.com wrote: I noticed a couple comments that look wrong to me. Patch attached. Thanks, committed. But I updated the parenthesized comment in the first fix instead of removing it. Let me know if you see an issue with that. -- Robert

[HACKERS] pg_operator.oprcode in 9.2rc1

2012-08-30 Thread Joe Abbate
Hello hackers, I've been testing Pyrseas against 9.2rc1. A test that does a CREATE OPERATOR is giving a small difference. Specifically, the test issues the statement: CREATE OPERATOR + (PROCEDURE = upper, RIGHTARG = text); Pyrseas then queries the pg_operator catalog to map the procedure for

Re: [HACKERS] Event Triggers reduced, v1

2012-08-30 Thread Robert Haas
On Mon, Aug 27, 2012 at 7:52 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: I've been reviewing your changes and here's a very small patch with some details I would have spelled out differently. See what you think, I mostly needed to edit some code to get back in shape :) I guess I don't

Re: [HACKERS] hunspell and tsearch2 ?

2012-08-30 Thread Robert Haas
On Mon, Aug 27, 2012 at 8:31 AM, Dirk Lutzebäck dirk.lutzeba...@thinkproject.com wrote: we have issues with compound words in tsearch2 using the german (ispell) dictionary. This has been discussed before but there is no real solution using the recommended german dictionary at

Re: [HACKERS] PATCH: pgbench - random sampling of transaction written into log

2012-08-30 Thread Robert Haas
On Sun, Aug 26, 2012 at 1:04 PM, Tomas Vondra t...@fuzzy.cz wrote: Attached is an improved patch, with a call to rand() replaced with getrand(). I was thinking about the counter but I'm not really sure how to handle cases like 39% - I'm not sure a plain (counter % 100 37) is not a good

Re: [HACKERS] PATCH: optimized DROP of multiple tables within a transaction

2012-08-30 Thread Robert Haas
On Fri, Aug 24, 2012 at 6:36 PM, Tomas Vondra t...@fuzzy.cz wrote: attached is a patch that improves performance when dropping multiple tables within a transaction. Instead of scanning the shared buffers for each table separately, the patch removes this and evicts all the tables in a single

Re: [HACKERS] PATCH: pgbench - aggregation of info written into log

2012-08-30 Thread Robert Haas
On Fri, Aug 24, 2012 at 5:25 PM, Tomas Vondra t...@fuzzy.cz wrote: This patch is a bit less polished (and more complex) than the other pgbench patch I've sent a while back, and I'm not sure how to handle the Windows branch. That needs to be fixed during the commit fest. What's the problem with

Re: [HACKERS] rows modified in current transaction

2012-08-30 Thread Robert Haas
On Thu, Aug 30, 2012 at 10:36 AM, Miroslav Šimulčík simulcik.m...@gmail.com wrote: is there any way to check if row have already been modified by the current transaction? I tried condition txid_current() = xmin, but there is problem with the savepoints. After every savepoint rows are getting

Re: [HACKERS] rows modified in current transaction

2012-08-30 Thread Andres Freund
On Thursday, August 30, 2012 06:06:59 PM Robert Haas wrote: On Thu, Aug 30, 2012 at 10:36 AM, Miroslav Šimulčík simulcik.m...@gmail.com wrote: is there any way to check if row have already been modified by the current transaction? I tried condition txid_current() = xmin, but there is

Re: [HACKERS] splitting *_desc routines

2012-08-30 Thread Andres Freund
On Wednesday, August 29, 2012 10:06:16 PM Tom Lane wrote: Alvaro Herrera alvhe...@alvh.no-ip.org writes: I looked at Andres' patch and the general idea is rather horrible: it links all backend files into the output executable. This is so that the *_desc functions can be used from their

Re: [HACKERS] rows modified in current transaction

2012-08-30 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Aug 30, 2012 at 10:36 AM, Miroslav Šimulčík simulcik.m...@gmail.com wrote: is there any way to check if row have already been modified by the current transaction? I tried condition txid_current() = xmin, but there is problem with the

Re: [HACKERS] rows modified in current transaction

2012-08-30 Thread Andres Freund
On Thursday, August 30, 2012 06:09:43 PM Andres Freund wrote: On Thursday, August 30, 2012 06:06:59 PM Robert Haas wrote: On Thu, Aug 30, 2012 at 10:36 AM, Miroslav Šimulčík simulcik.m...@gmail.com wrote: is there any way to check if row have already been modified by the current

Re: [HACKERS] pg_operator.oprcode in 9.2rc1

2012-08-30 Thread Tom Lane
Joe Abbate j...@freedomcircle.com writes: Hello hackers, I've been testing Pyrseas against 9.2rc1. A test that does a CREATE OPERATOR is giving a small difference. Specifically, the test issues the statement: CREATE OPERATOR + (PROCEDURE = upper, RIGHTARG = text); Pyrseas then queries

Re: [HACKERS] HEAD crashes on windows when doing VACUUM ANALYZE

2012-08-30 Thread Andres Freund
On Thursday, August 30, 2012 06:50:13 PM Matthias wrote: 2012/8/30 Albe Laurenz laurenz.a...@wien.gv.at: Matthias wrote: when running VACUUM ANALYZE on my database built on win32-x86 from yesterday's git checkout I always get this at some point during VACUUM ANALYZE: LOG: server

Re: [HACKERS] HEAD crashes on windows when doing VACUUM ANALYZE

2012-08-30 Thread Matthias
2012/8/30 Albe Laurenz laurenz.a...@wien.gv.at: Matthias wrote: when running VACUUM ANALYZE on my database built on win32-x86 from yesterday's git checkout I always get this at some point during VACUUM ANALYZE: LOG: server process (PID 5880) was terminated by exception 0xC094 DETAIL:

Re: [HACKERS] pg_operator.oprcode in 9.2rc1

2012-08-30 Thread Joe Abbate
Hello Tom, On 30/08/12 12:27, Tom Lane wrote: The reason for the difference is that in 9.2 there's more than one pg_catalog.upper(): regression=# \df upper List of functions Schema | Name | Result data type | Argument data types | Type

Re: [HACKERS] Fix for gistchoose

2012-08-30 Thread Robert Haas
On Mon, Aug 20, 2012 at 12:57 PM, Alexander Korotkov aekorot...@gmail.com wrote: I found that code of gistchoose doesn't follow it's logic. Idea of gistchoose is that first column penalty is more important than penalty of second column. If we meet same penalty values of first column then we

Re: [HACKERS] Don't allow relative path for copy from file

2012-08-30 Thread Robert Haas
On Thu, Aug 16, 2012 at 2:11 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: Agreed. I'd like to withdraw the patch sent in the earlier post, and propose to update the documentation in the COPY reference page. Please find attached a patch. I think this is a good idea, but I didn't

Re: [HACKERS] pg_operator.oprcode in 9.2rc1

2012-08-30 Thread Tom Lane
Joe Abbate j...@freedomcircle.com writes: On 30/08/12 12:27, Tom Lane wrote: The reason for the difference is that in 9.2 there's more than one pg_catalog.upper(): Hmmm ... Well, I'm just doing the same thing as pg_dump, which in 9.2rc1 still outputs the same as before, namely: Well,

Re: [HACKERS] Fix for gistchoose

2012-08-30 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Mon, Aug 20, 2012 at 12:57 PM, Alexander Korotkov aekorot...@gmail.com wrote: I found that code of gistchoose doesn't follow it's logic. Idea of gistchoose is that first column penalty is more important than penalty of second column. If we meet

Re: [HACKERS] HEAD crashes on windows when doing VACUUM ANALYZE

2012-08-30 Thread Heikki Linnakangas
On 30.08.2012 19:50, Matthias wrote: It crashes in rangetypes_typeanalyze.c at line 186: delta = (non_empty_cnt - 1) / (num_hist - 1); According to the debugger num_hist = 1, so it divides by zero. I guess this is due to the new statistics collection for range types? Yep. Fixed, thanks

Re: [HACKERS] canceling autovacuum task woes

2012-08-30 Thread Robert Haas
On Mon, Aug 13, 2012 at 11:59 PM, Peter Eisentraut pete...@gmx.net wrote: On Tue, 2012-07-24 at 16:14 -0400, Robert Haas wrote: On Tue, Jul 24, 2012 at 4:09 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Yeah, you're right. So you do get the table name.

Re: [HACKERS] Fix for gistchoose

2012-08-30 Thread Robert Haas
On Thu, Aug 30, 2012 at 1:27 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Mon, Aug 20, 2012 at 12:57 PM, Alexander Korotkov aekorot...@gmail.com wrote: I found that code of gistchoose doesn't follow it's logic. Idea of gistchoose is that first column

Re: [HACKERS] SIGFPE handler is naive

2012-08-30 Thread Robert Haas
On Tue, Aug 14, 2012 at 5:46 PM, Tom Lane t...@sss.pgh.pa.us wrote: Noah Misch n...@leadboat.com writes: On Tue, Aug 14, 2012 at 08:40:06AM -0400, Robert Haas wrote: On Tue, Aug 14, 2012 at 6:50 AM, Greg Stark st...@mit.edu wrote: It is possible to check if the signal was synchronous or was

Re: [HACKERS] HEAD crashes on windows when doing VACUUM ANALYZE

2012-08-30 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On Thursday, August 30, 2012 06:50:13 PM Matthias wrote: According to the debugger num_hist = 1, so it divides by zero. Its curious though that the SIGFPE isn't properly cought though. That would only lead to a different error, but ... Not all

Re: [HACKERS] splitting *_desc routines

2012-08-30 Thread Robert Haas
On Thu, Aug 30, 2012 at 12:14 PM, Andres Freund and...@2ndquadrant.com wrote: An alternative thing that might be worth considering before you go all in on this is whether the xlogdump functionality shouldn't just be part of the regular server executable, ie you'd call it with postgres

Re: [HACKERS] Fix for gistchoose

2012-08-30 Thread Alexander Korotkov
On Thu, Aug 30, 2012 at 9:11 PM, Robert Haas robertmh...@gmail.com wrote: On Mon, Aug 20, 2012 at 12:57 PM, Alexander Korotkov aekorot...@gmail.com wrote: I found that code of gistchoose doesn't follow it's logic. Idea of gistchoose is that first column penalty is more important than

Re: [HACKERS] [WIP] Performance Improvement by reducing WAL for Update Operation

2012-08-30 Thread Robert Haas
On Fri, Aug 10, 2012 at 1:25 AM, Amit Kapila amit.kap...@huawei.com wrote: I think the property that recovery only needs to worry about each block individually is one that we want to preserve. Supporting this optimizating only when full_page_writes=off seems ugly, I think recovery needs to

Re: [HACKERS] patch: shared session variables

2012-08-30 Thread Robert Haas
On Tue, Aug 14, 2012 at 3:46 AM, Pavel Stehule pavel.steh...@gmail.com wrote: patch that implements shared client/server session variables I don't really see what we can do with this that we can't do without this. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise

Re: [HACKERS] patch: shared session variables

2012-08-30 Thread Pavel Stehule
2012/8/30 Robert Haas robertmh...@gmail.com: On Tue, Aug 14, 2012 at 3:46 AM, Pavel Stehule pavel.steh...@gmail.com wrote: patch that implements shared client/server session variables I don't really see what we can do with this that we can't do without this. a motivation for this patch was

Re: [HACKERS] pg_operator.oprcode in 9.2rc1

2012-08-30 Thread Joe Abbate
Hello Tom, On 30/08/12 13:23, Tom Lane wrote: Joe Abbate j...@freedomcircle.com writes: Hmmm ... Well, I'm just doing the same thing as pg_dump, which in 9.2rc1 still outputs the same as before, namely: Well, evidently you're *not* doing the same thing as pg_dump. I meant that the Pyrseas

Re: [HACKERS] pg_operator.oprcode in 9.2rc1

2012-08-30 Thread Tom Lane
Joe Abbate j...@freedomcircle.com writes: Yes, I suspected that an OID was stored. What I'd still quibble with is the use of the ambiguous regproc in pg_operator (also pg_type) and the still-ambiguous schema-qualified proc name. I guess it's not feasible (at least, short term), but it'd be

Re: [HACKERS] Wiki link for max_connections? (Fwd: Re: [ADMIN] PostgreSQL oom_adj postmaster process to -17)

2012-08-30 Thread Robert Haas
On Thu, Aug 9, 2012 at 1:11 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: I didn't figure it was; my emphasis was because this has been raised before and nothing happened for want of a consensus on what particular wording should be used, so users were left with no guidance. I don't

Re: [HACKERS] patch: shared session variables

2012-08-30 Thread Robert Haas
On Thu, Aug 30, 2012 at 2:18 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2012/8/30 Robert Haas robertmh...@gmail.com: On Tue, Aug 14, 2012 at 3:46 AM, Pavel Stehule pavel.steh...@gmail.com wrote: patch that implements shared client/server session variables I don't really see what we

Re: [HACKERS] Proof of concept: auto updatable views

2012-08-30 Thread Robert Haas
On Sun, Aug 12, 2012 at 5:14 PM, Dean Rasheed dean.a.rash...@gmail.com wrote: None of this new code kicks in for non-security barrier views, so the kinds of plans I posted upthread remain unchanged in that case. But now a significant fraction of the patch is code added to handle security

Re: [HACKERS] PATCH: optimized DROP of multiple tables within a transaction

2012-08-30 Thread Tomas Vondra
On 30 Srpen 2012, 17:53, Robert Haas wrote: On Fri, Aug 24, 2012 at 6:36 PM, Tomas Vondra t...@fuzzy.cz wrote: attached is a patch that improves performance when dropping multiple tables within a transaction. Instead of scanning the shared buffers for each table separately, the patch removes

Re: [HACKERS] ALTER command reworks

2012-08-30 Thread Robert Haas
On Mon, Aug 13, 2012 at 3:35 PM, Kohei KaiGai kai...@kaigai.gr.jp wrote: The attached patch is a refreshed version of ALTER command reworks towards the latest tree. Here is few big changes except for code integration of the code to rename event triggers. This seems to have bit-rotted a bit.

Re: [HACKERS] PATCH: pgbench - aggregation of info written into log

2012-08-30 Thread Tomas Vondra
On 30 Srpen 2012, 18:02, Robert Haas wrote: On Fri, Aug 24, 2012 at 5:25 PM, Tomas Vondra t...@fuzzy.cz wrote: This patch is a bit less polished (and more complex) than the other pgbench patch I've sent a while back, and I'm not sure how to handle the Windows branch. That needs to be fixed

Re: [HACKERS] Fix for gistchoose

2012-08-30 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Aug 30, 2012 at 1:27 PM, Tom Lane t...@sss.pgh.pa.us wrote: Should we backpatch that? Arguably, yes. Does the patch look sane to you? I was afraid you'd ask that. [ studies code for awhile ... ] I think this fixes the bug, but the function

Re: [HACKERS] How to form a self-defined TupleTableSlot

2012-08-30 Thread Robert Haas
On Thu, Jul 26, 2012 at 11:39 PM, chaoyong.w...@emc.com wrote: Here is my task situation: I have a TupleTableSlot, with its own TupleDesc. Now I want to extract several attributes to form a new TupleTableSlot, how can I define my own TupleDesc and the ProjectionInfo? You might get more

Re: [HACKERS] Avoiding adjacent checkpoint records

2012-08-30 Thread Robert Haas
On Mon, Aug 13, 2012 at 6:19 PM, Jeff Janes jeff.ja...@gmail.com wrote: On Sat, Jun 9, 2012 at 5:43 AM, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: So now the standard for my patches is that I must consider what will happen if the xlog is deleted? When you're

Re: [HACKERS] patch: shared session variables

2012-08-30 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Aug 30, 2012 at 2:18 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2012/8/30 Robert Haas robertmh...@gmail.com: On Tue, Aug 14, 2012 at 3:46 AM, Pavel Stehule pavel.steh...@gmail.com wrote: patch that implements shared client/server

Re: [HACKERS] effective_io_concurrency

2012-08-30 Thread Robert Haas
On Sat, Jul 28, 2012 at 4:09 PM, Jeff Janes jeff.ja...@gmail.com wrote: From my attempted reading of the thread posix_fadvise v22, it seems like modification of the planner was never discussed, rather than being discussed and rejected. So, is there a reason not to make the planner take

Re: [HACKERS] PATCH: pgbench - random sampling of transaction written into log

2012-08-30 Thread Tomas Vondra
On 30 Srpen 2012, 17:46, Robert Haas wrote: On Sun, Aug 26, 2012 at 1:04 PM, Tomas Vondra t...@fuzzy.cz wrote: Attached is an improved patch, with a call to rand() replaced with getrand(). I was thinking about the counter but I'm not really sure how to handle cases like 39% - I'm not sure a

Re: [HACKERS] Fix for gistchoose

2012-08-30 Thread Robert Haas
On Thu, Aug 30, 2012 at 3:27 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Thu, Aug 30, 2012 at 1:27 PM, Tom Lane t...@sss.pgh.pa.us wrote: Should we backpatch that? Arguably, yes. Does the patch look sane to you? I was afraid you'd ask that. [

Re: [HACKERS] Fix for gistchoose

2012-08-30 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: I noticed all that, but didn't feel like putting in the effort to make it better. I would have been happy to have someone else pick up the patch, but as it had been languishing I thought it would be better to get it committed more or less as it was

[HACKERS] 9.2rc1 build requirements

2012-08-30 Thread Joe Abbate
Hello hackers, In order to test 9.2rc1, I had to build contrib (because Pyrseas uses some of those modules). The build instructions (http://www.postgresql.org/docs/9.2/static/install-procedure.html ) state the way to build everything (contrib + docs, etc.) is gmake world Unfortunately, that

Re: [HACKERS] Fix for gistchoose

2012-08-30 Thread Robert Haas
On Thu, Aug 30, 2012 at 4:15 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: I noticed all that, but didn't feel like putting in the effort to make it better. I would have been happy to have someone else pick up the patch, but as it had been languishing I

Re: [HACKERS] effective_io_concurrency

2012-08-30 Thread Peter Geoghegan
On 30 August 2012 20:28, Robert Haas robertmh...@gmail.com wrote: On Sat, Jul 28, 2012 at 4:09 PM, Jeff Janes jeff.ja...@gmail.com wrote: But it might be better yet to make ordinary index scans benefit from effective_io_concurrency, but even if/when that gets done it would probably still be

Re: [HACKERS] --disable-shared is entirely broken these days

2012-08-30 Thread Bruce Momjian
On Mon, May 28, 2012 at 02:27:15AM +0300, Peter Eisentraut wrote: On lör, 2012-05-26 at 15:53 -0400, Tom Lane wrote: 2. Seeing that this is the first complaint since 9.0, should we decide that --disable-shared is no longer worth supporting? Seems like we should either make this case work

Re: [HACKERS] Performance patch for Win32

2012-08-30 Thread Bruce Momjian
On Tue, May 29, 2012 at 03:54:59PM -0700, Mark Dilger wrote: I was imagining that this would be a trap for linux developers who saw nothing wrong with their code until it made it to the build/test farm. That's pretty far down the development process. Of course, it is also a trap in the other

Re: [HACKERS] We're not lax enough about maximum time zone offset from UTC

2012-08-30 Thread Bruce Momjian
On Wed, May 30, 2012 at 06:10:12PM -0400, Tom Lane wrote: Currently, our datetime input code thinks that any UTC offset of more than 14:59:59 either way from Greenwich must be a mistake. However, after seeing Patric Bechtel's recent bug report, I went trolling in the Olson timezone files to

Re: [HACKERS] [PERFORM] pg_dump and thousands of schemas

2012-08-30 Thread Bruce Momjian
On Thu, May 31, 2012 at 09:20:43AM +0900, Tatsuo Ishii wrote: Yeah, Jeff's experiments indicated that the remaining bottleneck is lock management in the server. What I fixed so far on the pg_dump side should be enough to let partial dumps run at reasonable speed even if the whole database

Re: [HACKERS] Fix for gistchoose

2012-08-30 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Aug 30, 2012 at 4:15 PM, Tom Lane t...@sss.pgh.pa.us wrote: Yeah, the idea of replacing sum_grow with a boolean just occurred to me too. As is, I think the code is making some less-than-portable assumptions about what will happen if sum_grow

Re: [HACKERS] --disable-shared is entirely broken these days

2012-08-30 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: On Mon, May 28, 2012 at 02:27:15AM +0300, Peter Eisentraut wrote: We should just remove it now. --disable-shared removed, with the attached, applied patch. No documentation changes? regards, tom lane -- Sent via pgsql-hackers

Re: [HACKERS] We're not lax enough about maximum time zone offset from UTC

2012-08-30 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: On Wed, May 30, 2012 at 06:10:12PM -0400, Tom Lane wrote: However, as pointed out by Patric, if you dump and restore an old timestamptz value in one of these zones, it will fail to restore because of the sanity check. I think therefore that we'd better

Re: [HACKERS] --disable-shared is entirely broken these days

2012-08-30 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: On Thu, Aug 30, 2012 at 04:50:22PM -0400, Tom Lane wrote: No documentation changes? I couldn't find any place we document it. I did: grep _shared *.sgml and no hits were returned. Should I search for something else? It's --enable-shared, not

Re: [HACKERS] --disable-shared is entirely broken these days

2012-08-30 Thread Bruce Momjian
On Thu, Aug 30, 2012 at 04:57:30PM -0400, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: On Thu, Aug 30, 2012 at 04:50:22PM -0400, Tom Lane wrote: No documentation changes? I couldn't find any place we document it. I did: grep _shared *.sgml and no hits were returned.

Re: [HACKERS] splitting htup.h

2012-08-30 Thread Alvaro Herrera
Excerpts from Alvaro Herrera's message of mié ago 29 15:13:11 -0400 2012: Excerpts from Andres Freund's message of mié ago 29 12:10:17 -0400 2012: OK, scratch that thought then. So we seem to be down to choosing a new name for what we're going to take out of htup.h. If you don't like

Re: [HACKERS] [PERFORM] pg_dump and thousands of schemas

2012-08-30 Thread Bruce Momjian
On Thu, Aug 30, 2012 at 04:51:56PM -0400, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: On Thu, May 31, 2012 at 09:20:43AM +0900, Tatsuo Ishii wrote: Ok, I modified the part of pg_dump where tremendous number of LOCK TABLE are issued. I replace them with single LOCK TABLE with

Re: [HACKERS] 9.2rc1 build requirements

2012-08-30 Thread Jeff Janes
On Thu, Aug 30, 2012 at 1:18 PM, Joe Abbate j...@freedomcircle.com wrote: Hello hackers, In order to test 9.2rc1, I had to build contrib (because Pyrseas uses some of those modules). The build instructions (http://www.postgresql.org/docs/9.2/static/install-procedure.html ) state the way to

Re: [HACKERS] --disable-shared is entirely broken these days

2012-08-30 Thread Bruce Momjian
On Thu, Aug 30, 2012 at 05:01:39PM -0400, Bruce Momjian wrote: On Thu, Aug 30, 2012 at 04:57:30PM -0400, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: On Thu, Aug 30, 2012 at 04:50:22PM -0400, Tom Lane wrote: No documentation changes? I couldn't find any place we document

Re: [HACKERS] [PERFORM] pg_dump and thousands of schemas

2012-08-30 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: On Thu, May 31, 2012 at 09:20:43AM +0900, Tatsuo Ishii wrote: Ok, I modified the part of pg_dump where tremendous number of LOCK TABLE are issued. I replace them with single LOCK TABLE with multiple tables. With 100k tables LOCK statements took 13 minutes

Re: [HACKERS] --disable-shared is entirely broken these days

2012-08-30 Thread Bruce Momjian
On Thu, Aug 30, 2012 at 04:50:22PM -0400, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: On Mon, May 28, 2012 at 02:27:15AM +0300, Peter Eisentraut wrote: We should just remove it now. --disable-shared removed, with the attached, applied patch. No documentation changes? I

Re: [HACKERS] --disable-shared is entirely broken these days

2012-08-30 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: On Thu, Aug 30, 2012 at 05:01:39PM -0400, Bruce Momjian wrote: Oh, got -/_ mixed up. Fixed with attached applied patch. Oops, that text is talking about Python's configure, so I put the text back. Seemed we had _no_ mention of our own --enable-shared.

Re: [HACKERS] We're not lax enough about maximum time zone offset from UTC

2012-08-30 Thread Bruce Momjian
On Thu, Aug 30, 2012 at 04:51:02PM -0400, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: On Wed, May 30, 2012 at 06:10:12PM -0400, Tom Lane wrote: However, as pointed out by Patric, if you dump and restore an old timestamptz value in one of these zones, it will fail to restore

Re: [HACKERS] 9.2rc1 build requirements

2012-08-30 Thread Alvaro Herrera
Excerpts from Joe Abbate's message of jue ago 30 16:18:05 -0400 2012: Hello hackers, In order to test 9.2rc1, I had to build contrib (because Pyrseas uses some of those modules). The build instructions (http://www.postgresql.org/docs/9.2/static/install-procedure.html ) state the way to

Re: [HACKERS] 9.2rc1 build requirements

2012-08-30 Thread Tom Lane
Joe Abbate j...@freedomcircle.com writes: As an aside, I installed jade (on Debian) and tried to make world but got several errors, starting with the following: jade -wall -wno-unused-param -wno-empty -wfully-tagged -D . -D . -d stylesheet.dsl -t sgml -i output-html -V html-index

Re: [HACKERS] 9.2rc1 build requirements

2012-08-30 Thread Joe Abbate
Hello Jeff, On 30/08/12 17:05, Jeff Janes wrote: I think is probably because you don't have DocBook DTD or some of the other prerequisites listed in the URL I gave above. Indeed. I was able to build world after invoking the apt-get line in J.2.3 on that page. The only adjustment I had to

Re: [HACKERS] Pg default's verbosity?

2012-08-30 Thread Bruce Momjian
On Sun, Jun 17, 2012 at 12:00:20AM -0400, nik9...@gmail.com wrote: I've always used -1-f - file.sql. It is confusing that -1 doesn't warn you when it wont work though. This will be fixed in 9.3 with this commit: commit be690e291d59e8d0c9f4df59abe09f1ff6cc0da9 Author: Robert

Re: [HACKERS] PATCH: optimized DROP of multiple tables within a transaction

2012-08-30 Thread Robert Haas
On Thu, Aug 30, 2012 at 3:17 PM, Tomas Vondra t...@fuzzy.cz wrote: On 30 Srpen 2012, 17:53, Robert Haas wrote: On Fri, Aug 24, 2012 at 6:36 PM, Tomas Vondra t...@fuzzy.cz wrote: attached is a patch that improves performance when dropping multiple tables within a transaction. Instead of

Re: [HACKERS] PATCH: pgbench - aggregation of info written into log

2012-08-30 Thread Tomas Vondra
On 30 Srpen 2012, 23:47, Robert Haas wrote: On Thu, Aug 30, 2012 at 3:25 PM, Tomas Vondra t...@fuzzy.cz wrote: On 30 Srpen 2012, 18:02, Robert Haas wrote: On Fri, Aug 24, 2012 at 5:25 PM, Tomas Vondra t...@fuzzy.cz wrote: This patch is a bit less polished (and more complex) than the other

Re: [HACKERS] libpq compression

2012-08-30 Thread Bruce Momjian
On Sun, Jun 17, 2012 at 11:45:54PM +0800, Magnus Hagander wrote: On Sun, Jun 17, 2012 at 11:42 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: Is there a reason why we don't have a parameter on the client mirroring ssl_ciphers? Dunno, do we need one?  

Re: [HACKERS] 9.2rc1 build requirements

2012-08-30 Thread Joe Abbate
On 30/08/12 17:36, Tom Lane wrote: FWIW, that suggests that this version of jade is too old. I'm not sure that jade per se (as opposed to the successor project openjade) can be used to build our docs at all --- you should check whether this is openjade, or really the original project. It was

Re: [HACKERS] PATCH: pgbench - random sampling of transaction written into log

2012-08-30 Thread Tomas Vondra
On 30 Srpen 2012, 23:44, Robert Haas wrote: On Thu, Aug 30, 2012 at 3:48 PM, Tomas Vondra t...@fuzzy.cz wrote: That sounds like a pretty trivial patch. I've been thinking about yet another option - histograms (regular or with exponential bins). I thought about that, too, but I think

Re: [HACKERS] Fix for gistchoose

2012-08-30 Thread Robert Haas
On Thu, Aug 30, 2012 at 4:48 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Thu, Aug 30, 2012 at 4:15 PM, Tom Lane t...@sss.pgh.pa.us wrote: Yeah, the idea of replacing sum_grow with a boolean just occurred to me too. As is, I think the code is making some

Re: [HACKERS] PATCH: pgbench - aggregation of info written into log

2012-08-30 Thread Robert Haas
On Thu, Aug 30, 2012 at 3:25 PM, Tomas Vondra t...@fuzzy.cz wrote: On 30 Srpen 2012, 18:02, Robert Haas wrote: On Fri, Aug 24, 2012 at 5:25 PM, Tomas Vondra t...@fuzzy.cz wrote: This patch is a bit less polished (and more complex) than the other pgbench patch I've sent a while back, and I'm

Re: [HACKERS] [PERFORM] pg_dump and thousands of schemas

2012-08-30 Thread Robert Haas
On Thu, Aug 30, 2012 at 4:51 PM, Tom Lane t...@sss.pgh.pa.us wrote: Bruce Momjian br...@momjian.us writes: On Thu, May 31, 2012 at 09:20:43AM +0900, Tatsuo Ishii wrote: Ok, I modified the part of pg_dump where tremendous number of LOCK TABLE are issued. I replace them with single LOCK TABLE

Re: [HACKERS] PATCH: pgbench - random sampling of transaction written into log

2012-08-30 Thread Robert Haas
On Thu, Aug 30, 2012 at 3:48 PM, Tomas Vondra t...@fuzzy.cz wrote: That sounds like a pretty trivial patch. I've been thinking about yet another option - histograms (regular or with exponential bins). I thought about that, too, but I think high-outliers is a lot more useful. At least for the

Re: [HACKERS] 9.2rc1 build requirements

2012-08-30 Thread Jeff Janes
On Thu, Aug 30, 2012 at 2:05 PM, Jeff Janes jeff.ja...@gmail.com wrote: On Thu, Aug 30, 2012 at 1:18 PM, Joe Abbate j...@freedomcircle.com wrote: gmake world Unfortunately, that failed because the doc build requires jade. I managed to build contrib separately, but wanted to point out

Re: [HACKERS] 9.2rc1 build requirements

2012-08-30 Thread Jaime Casanova
On Thu, Aug 30, 2012 at 4:58 PM, Joe Abbate j...@freedomcircle.com wrote: On 30/08/12 17:36, Tom Lane wrote: FWIW, that suggests that this version of jade is too old. I'm not sure that jade per se (as opposed to the successor project openjade) can be used to build our docs at all --- you

Re: [HACKERS] 9.2rc1 build requirements

2012-08-30 Thread Jaime Casanova
On Thu, Aug 30, 2012 at 7:47 PM, Jaime Casanova ja...@2ndquadrant.com wrote: On Thu, Aug 30, 2012 at 4:58 PM, Joe Abbate j...@freedomcircle.com wrote: On 30/08/12 17:36, Tom Lane wrote: FWIW, that suggests that this version of jade is too old. I'm not sure that jade per se (as opposed to the

Re: [HACKERS] 9.2rc1 build requirements

2012-08-30 Thread Peter Eisentraut
On Thu, 2012-08-30 at 17:36 -0400, Tom Lane wrote: Joe Abbate j...@freedomcircle.com writes: As an aside, I installed jade (on Debian) and tried to make world but got several errors, starting with the following: jade -wall -wno-unused-param -wno-empty -wfully-tagged -D . -D . -d

Re: [HACKERS] emacs configuration for new perltidy settings

2012-08-30 Thread Bruce Momjian
On Thu, Jul 12, 2012 at 12:35:26AM +0300, Peter Eisentraut wrote: This might be useful for some people. Here is an emacs configuration for perl-mode that is compatible with the new perltidy settings. Note that the default perl-mode settings produce indentation that will be completely

  1   2   >