Re: [HACKERS] snapbuild woes

On Fri, Apr 21, 2017 at 10:34:58PM -0700, Andres Freund wrote: > I've a bunch of tests, but I don't quite know whether we can expose all > of them via classical tests. There are several easy ones that I > definitely want to add (import "empty" snapshot; import snapshot with > running xacts; create

Re: [HACKERS] Declarative partitioning - another take

On Mon, Apr 24, 2017 at 07:43:29PM +0900, Amit Langote wrote: > On 2017/04/21 17:00, Rajkumar Raghuwanshi wrote: > > I am able to create statement triggers at root partition, but these > > triggers, not getting fired on updating partition. > It would be great if you could check if the patches fix

Re: [HACKERS] Concurrent ALTER SEQUENCE RESTART Regression

On Fri, Apr 28, 2017 at 04:55:45PM +0900, Michael Paquier wrote: > On Thu, Apr 27, 2017 at 4:10 PM, Andres Freund wrote: > > On April 27, 2017 12:06:55 AM PDT, Michael Paquier > > wrote: > >>On Thu, Apr 27, 2017 at 3:23 PM, Andres Freund > >>wrote: > >>> More fun: > >>> > >>> A: CREATE SEQUENCE

Re: [HACKERS] .pgpass's behavior has changed

On Fri, Apr 28, 2017 at 04:54:32PM +0900, Kyotaro HORIGUCHI wrote: > I noticed that the precedence between host and hostaddr in a > connection string is reversed in regard to .pgpass lookup in > devel. > > For example the following connection string uses a .pgpass entry > with "127.0.0.1", not "ho

Re: [HACKERS] Re: logical replication and PANIC during shutdown checkpoint in publisher

On Sat, Apr 29, 2017 at 11:18:45AM -0700, Noah Misch wrote: > On Tue, Apr 25, 2017 at 03:26:06PM -0400, Peter Eisentraut wrote: > > On 4/20/17 11:30, Peter Eisentraut wrote: > > > On 4/19/17 23:04, Noah Misch wrote: > > >> This PostgreSQL 10 open item is past due f

Re: [HACKERS] snapbuild woes

On Mon, May 01, 2017 at 12:32:07PM -0400, Tom Lane wrote: > Andres Freund writes: > > On 2017-05-01 08:46:47 -0400, Tom Lane wrote: > >> 30sec is kind of a big lump from a buildfarm standpoint, especially if > >> you mean "it runs for 30s on my honkin' fast workstation". I'm fine > >> with indivi

Re: [HACKERS] Transition tables for triggers on foreign tables and views

On Fri, Apr 28, 2017 at 05:07:31AM +, Noah Misch wrote: > On Wed, Apr 26, 2017 at 11:17:05AM +1200, Thomas Munro wrote: > > My colleague Prabhat Sahu reported off list that transition tables > > don't work for views. I probably should have thought about that when > >

Re: [HACKERS] SUBSCRIPTIONS and pg_upgrade

On Thu, Apr 13, 2017 at 12:11:30PM -0400, Robert Haas wrote: > On Thu, Apr 13, 2017 at 12:05 PM, Peter Eisentraut > wrote: > > On 4/12/17 18:31, Peter Eisentraut wrote: > >> On 4/11/17 23:41, Noah Misch wrote: > >>> On Tue, Apr 11, 2017 at 11:21:24PM -0400, Pete

Re: [HACKERS] snapbuild woes

On Thu, Apr 27, 2017 at 09:42:58PM -0700, Andres Freund wrote: > > > On April 27, 2017 9:34:44 PM PDT, Noah Misch wrote: > >On Fri, Apr 21, 2017 at 10:36:21PM -0700, Andres Freund wrote: > >> On 2017-04-17 21:16:57 -0700, Andres Freund wrote: > >> > I&#

Re: [HACKERS] Time based lag tracking for logical replication

On Wed, May 03, 2017 at 08:28:53AM +0200, Simon Riggs wrote: > On 23 April 2017 at 01:10, Petr Jelinek wrote: > > Hi, > > > > The time based lag tracking commit [1] added interface for logging > > progress of replication so that we can report lag as time interval > > instead of just bytes. But the

Re: [HACKERS] Logical replication ApplyContext bloat

On Wed, May 03, 2017 at 12:02:41PM +0300, Stas Kelvich wrote: > > On 20 Apr 2017, at 17:01, Dilip Kumar wrote: > > On Thu, Apr 20, 2017 at 7:04 PM, Stas Kelvich > > wrote: > >> Thanks for noting. > >> > >> Added short description of ApplyContext and ApplyMessageContext to README. > > > > Typo

Re: [HACKERS] Logical replication - TRAP: FailedAssertion in pgstat.c

On Wed, May 03, 2017 at 01:23:19PM +0200, Erik Rijkers wrote: > On 2017-05-03 08:17, Petr Jelinek wrote: > >On 02/05/17 20:43, Robert Haas wrote: > >>On Thu, Apr 20, 2017 at 2:58 PM, Peter Eisentraut > > >>>code path that calls CommitTransactionCommand() should have one, no? > >> > >>Is there anyt

Re: [HACKERS] pg_dump emits ALTER TABLE ONLY partitioned_table

On Thu, May 04, 2017 at 05:47:02PM -0400, Stephen Frost wrote: > * Amit Langote (amitlangot...@gmail.com) wrote: > > On Wed, May 3, 2017 at 12:05 PM, Stephen Frost wrote: > > > Assuming this looks good to you, I'll push it tomorrow, possibly with > > > other minor adjustments and perhaps a few mor

Re: [HACKERS] delta relations in AFTER triggers

On Thu, May 04, 2017 at 09:51:03PM +1200, Thomas Munro wrote: > On Thu, May 4, 2017 at 9:12 PM, Prabhat Sahu > wrote: > > I have been testing this for a while and observed a server crash while > > referencing table column value in a trigger procedure for AFTER DELETE > > trigger. > > > > -- Step

Re: [HACKERS] delta relations in AFTER triggers

On Fri, May 05, 2017 at 08:23:33AM +1200, Thomas Munro wrote: > On Fri, May 5, 2017 at 12:39 AM, Neha Sharma > wrote: > > While testing the feature we encountered one more crash,below is the > > scenario to reproduce. > > > > create table t1 ( a int); > > create table t2 ( a int); > > insert into

Re: [HACKERS] Should pg_current_wal_location() become pg_current_wal_lsn()

On Fri, May 05, 2017 at 03:36:39AM +1200, David Rowley wrote: > On 2 May 2017 at 00:10, David Rowley wrote: > > On 20 April 2017 at 07:29, Euler Taveira wrote: > >> 2017-04-19 1:32 GMT-03:00 Michael Paquier : > >>> > >>> I vote for "location" -> "lsn". I would expect complains about the > >>> cur

Re: [HACKERS] SUBSCRIPTIONS and pg_upgrade

On Fri, May 05, 2017 at 11:01:57AM -0400, Peter Eisentraut wrote: > On 5/2/17 21:44, Noah Misch wrote: > >> I wonder if we should have an --no-subscriptions option, now that they > >> are dumped by default, just like we have --no-blobs, --no-owner, > >> --no-passw

[HACKERS] Re: transition table behavior with inheritance appears broken (was: Declarative partitioning - another take)

On Mon, May 01, 2017 at 11:10:52AM -0500, Kevin Grittner wrote: > On Mon, May 1, 2017 at 10:01 AM, Robert Haas wrote: > > > It seems pretty clear to me that this is busted. > > I don't think you actually tested anything that is dependent on any > of my patches there. > > > Adding this as an ope

Re: [HACKERS] Transition tables for triggers on foreign tables and views

On Tue, May 02, 2017 at 06:06:47PM -0500, Kevin Grittner wrote: > On Fri, Apr 28, 2017 at 10:56 PM, Tom Lane wrote: > > > They will fire if you have an INSTEAD OF row-level trigger; the existence > > of that trigger is what determines whether we implement DML on a view > > through the view's own

Re: [HACKERS] [BUGS] Concurrent ALTER SEQUENCE RESTART Regression

On Wed, May 03, 2017 at 11:29:29PM -0400, Peter Eisentraut wrote: > On 4/30/17 04:05, Noah Misch wrote: > > The above-described topic is currently a PostgreSQL 10 open item. Peter, > > since you committed the patch believed to have created it, you own this open > > item. If

[HACKERS] Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling)

On Tue, May 02, 2017 at 09:10:52AM -0400, Tom Lane wrote: > Robert Haas writes: > >> On Thu, Apr 20, 2017 at 7:46 AM, Petr Jelinek > >> wrote: > >>> DROP SUBSCRIPTION mysub NODROP SLOT; > > >> I'm pretty uninspired by this choice of syntax. > > Actually, this command has got much worse problems

[HACKERS] Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling)

On Tue, May 02, 2017 at 01:42:37PM -0400, Robert Haas wrote: > On Tue, May 2, 2017 at 8:45 AM, Petr Jelinek > wrote: > > I am happy to implement something different, it's quite trivial to > > change. But I am not going to propose anything different as I can't > > think of better syntax (if I could

Re: [HACKERS] Not getting error if ALTER SUBSCRIPTION syntax is wrong.

On Sat, May 06, 2017 at 02:44:27PM +0200, Petr Jelinek wrote: > On 05/05/17 19:51, Petr Jelinek wrote: > > On 05/05/17 14:40, tushar wrote: > >> Hi, > >> > >> While testing 'logical replication' against v10 , i encountered one > >> issue where data stop migrating after ALTER PUBLICATION. > >> > >>

Re: [HACKERS] [BUGS] Concurrent ALTER SEQUENCE RESTART Regression

On Sat, May 06, 2017 at 07:02:46PM +, Noah Misch wrote: > On Wed, May 03, 2017 at 11:29:29PM -0400, Peter Eisentraut wrote: > > On 4/30/17 04:05, Noah Misch wrote: > > > The above-described topic is currently a PostgreSQL 10 open item. Peter, > > > since you comm

Re: [HACKERS] Transition tables for triggers on foreign tables and views

On Sat, May 06, 2017 at 06:58:35PM +, Noah Misch wrote: > On Tue, May 02, 2017 at 06:06:47PM -0500, Kevin Grittner wrote: > > On Fri, Apr 28, 2017 at 10:56 PM, Tom Lane wrote: > > > > > They will fire if you have an INSTEAD OF row-level trigger; the existence >

Re: [HACKERS] SUBSCRIPTIONS and pg_upgrade

On Sat, May 06, 2017 at 11:50:16AM -0700, Noah Misch wrote: > On Fri, May 05, 2017 at 11:01:57AM -0400, Peter Eisentraut wrote: > > On 5/2/17 21:44, Noah Misch wrote: > > >> I wonder if we should have an --no-subscriptions option, now that they > > >> are dumped b

Re: [HACKERS] Time based lag tracking for logical replication

On Fri, May 05, 2017 at 07:07:26AM +, Noah Misch wrote: > On Wed, May 03, 2017 at 08:28:53AM +0200, Simon Riggs wrote: > > On 23 April 2017 at 01:10, Petr Jelinek > > wrote: > > > Hi, > > > > > > The time based lag tracking commit [1] added interface

Re: [HACKERS] Transition tables for triggers on foreign tables and views

On Mon, May 08, 2017 at 12:00:20AM -0700, Noah Misch wrote: > On Sat, May 06, 2017 at 06:58:35PM +0000, Noah Misch wrote: > > On Tue, May 02, 2017 at 06:06:47PM -0500, Kevin Grittner wrote: > > > On Fri, Apr 28, 2017 at 10:56 PM, Tom Lane wrote: > > > > >

Re: [HACKERS] delta relations in AFTER triggers

On Sat, May 06, 2017 at 05:33:24AM +, Noah Misch wrote: > On Thu, May 04, 2017 at 09:51:03PM +1200, Thomas Munro wrote: > > On Thu, May 4, 2017 at 9:12 PM, Prabhat Sahu > > wrote: > > > I have been testing this for a while and observed a server crash while > &

Re: [HACKERS] delta relations in AFTER triggers

On Sat, May 06, 2017 at 05:34:46AM +, Noah Misch wrote: > On Fri, May 05, 2017 at 08:23:33AM +1200, Thomas Munro wrote: > > On Fri, May 5, 2017 at 12:39 AM, Neha Sharma > > wrote: > > > While testing the feature we encountered one more crash,below is the >

Re: [HACKERS] Time based lag tracking for logical replication

On Mon, May 08, 2017 at 10:30:45PM -0700, Noah Misch wrote: > On Fri, May 05, 2017 at 07:07:26AM +0000, Noah Misch wrote: > > On Wed, May 03, 2017 at 08:28:53AM +0200, Simon Riggs wrote: > > > On 23 April 2017 at 01:10, Petr Jelinek > > > wrote: > > > >

Re: [HACKERS] Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling)

On Mon, May 08, 2017 at 05:01:00PM -0400, Peter Eisentraut wrote: > On 5/7/17 04:21, Noah Misch wrote: > > The above-described topic is currently a PostgreSQL 10 open item. Peter, > > since you committed the patch believed to have created it, you own this open > > item. If

Re: [HACKERS] Time based lag tracking for logical replication

On Sun, Apr 23, 2017 at 01:10:32AM +0200, Petr Jelinek wrote: > The time based lag tracking commit [1] added interface for logging > progress of replication so that we can report lag as time interval > instead of just bytes. But the patch didn't contain patch for the > builtin logical replication.

[HACKERS] Re: transition table behavior with inheritance appears broken (was: Declarative partitioning - another take)

On Sat, May 06, 2017 at 06:54:37PM +, Noah Misch wrote: > On Mon, May 01, 2017 at 11:10:52AM -0500, Kevin Grittner wrote: > > On Mon, May 1, 2017 at 10:01 AM, Robert Haas wrote: > > > > > It seems pretty clear to me that this is busted. > > > > I don&

Re: [HACKERS] Get stuck when dropping a subscription during synchronizing table

On Mon, May 08, 2017 at 06:27:30PM +0900, Masahiko Sawada wrote: > I encountered a situation where DROP SUBSCRIPTION got stuck when > initial table sync is in progress. In my environment, I created > several tables with some data on publisher. I created subscription on > subscriber and drop subscri

Re: [HACKERS] If subscription to foreign table valid ?

On Thu, May 11, 2017 at 05:55:02PM +0530, tushar wrote: > I observed that -we cannot publish "foreign table" in Publication > > postgres=# create foreign table t (n int) server db1_server options > (table_name 't1'); > CREATE FOREIGN TABLE > > postgres=# create publication pub for table t; > ERRO

[HACKERS] Re: [doc fix] PG10: wroing description on connect_timeout when multiple hosts are specified

On Fri, May 12, 2017 at 08:54:13AM +, Tsunakawa, Takayuki wrote: > From: pgsql-hackers-ow...@postgresql.org > > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Tsunakawa, > > Takayuki > > I found a wrong sentence here in the doc. I'm sorry, this is what I asked > > you to add... > >

Re: [HACKERS] [BUGS] Concurrent ALTER SEQUENCE RESTART Regression

On Mon, May 08, 2017 at 12:28:38PM -0400, Peter Eisentraut wrote: > On 5/8/17 02:58, Noah Misch wrote: > > IMMEDIATE ATTENTION REQUIRED. This PostgreSQL 10 open item is long past due > > for your status update. Please reacquaint yourself with the policy on open > > item

Re: [HACKERS] Removal of plaintext password type references

On Thu, May 11, 2017 at 10:08:30AM +0900, Michael Paquier wrote: > On Wed, May 10, 2017 at 10:22 PM, Michael Paquier > wrote: > > On Wed, May 10, 2017 at 10:01 PM, Tom Lane wrote: > >> Heikki Linnakangas writes: > >>> Also note that changing the signature check_password_hook_type would > >>> br

Re: [HACKERS] bumping HASH_VERSION to 3

On Wed, May 10, 2017 at 11:25:22AM +0530, Amit Kapila wrote: > On Tue, Apr 11, 2017 at 11:53 PM, Bruce Momjian wrote: > > On Fri, Mar 31, 2017 at 02:48:05PM -0400, Tom Lane wrote: > >> +1, as long as we're clear on what will happen when pg_upgrade'ing > >> an installation containing hash indexes.

[HACKERS] Re: Event triggers + table partitioning cause server crash in current master

On Mon, May 15, 2017 at 03:02:54PM +0900, Amit Langote wrote: > On 2017/05/14 12:03, Mark Dilger wrote: > > I discovered a reproducible crash using event triggers in the current > > development version, 29c7d5e483acaa74a0d06dd6c70b320bb315. > > I was getting a crash before this version, and clo

Re: [HACKERS] Get stuck when dropping a subscription during synchronizing table

On Mon, May 15, 2017 at 03:28:14AM +, Noah Misch wrote: > On Mon, May 08, 2017 at 06:27:30PM +0900, Masahiko Sawada wrote: > > I encountered a situation where DROP SUBSCRIPTION got stuck when > > initial table sync is in progress. In my environment, I created > > several

Re: [HACKERS] Improvement in log message of logical replication worker

On Thu, May 18, 2017 at 12:36:46PM +0900, Masahiko Sawada wrote: > On Thu, May 18, 2017 at 11:29 AM, Peter Eisentraut > wrote: > > On 5/12/17 00:30, Masahiko Sawada wrote: > >> I got same log messages 'starting logical replication worker for > >> subscription' total 5 times but actually 4 of them

Re: [HACKERS] OK, so culicidae is *still* broken

On Sat, Apr 15, 2017 at 02:30:18PM -0700, Andres Freund wrote: > On 2017-04-15 17:24:54 -0400, Tom Lane wrote: > > Andres Freund writes: > > > On 2017-04-15 17:09:38 -0400, Tom Lane wrote: > > >> Why doesn't Windows' ability to map the segment into the new process > > >> before it executes take ca

Re: retry shm attach for windows (WAS: Re: [HACKERS] OK, so culicidae is *still* broken)

On Wed, May 24, 2017 at 09:29:11AM -0400, Michael Paquier wrote: > On Tue, May 23, 2017 at 8:14 AM, Amit Kapila wrote: > > So it seems both you and Tom are leaning towards some sort of retry > > mechanism for shm reattach on Windows. I also think that is a viable > > option to negate the impact o

Re: retry shm attach for windows (WAS: Re: [HACKERS] OK, so culicidae is *still* broken)

On Thu, May 25, 2017 at 11:41:19AM +0900, Michael Paquier wrote: > On Thu, May 25, 2017 at 11:34 AM, Tsunakawa, Takayuki > wrote: > > From: pgsql-hackers-ow...@postgresql.org > >> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Noah Misch > >> Ten feels low

Re: [HACKERS] Get stuck when dropping a subscription during synchronizing table

On Thu, May 18, 2017 at 10:27:51PM -0400, Peter Eisentraut wrote: > On 5/18/17 11:11, Noah Misch wrote: > > IMMEDIATE ATTENTION REQUIRED. This PostgreSQL 10 open item is past due for > > your status update. Please reacquaint yourself with the policy on open item > > owners

[HACKERS] Re: transition table behavior with inheritance appears broken (was: Declarative partitioning - another take)

This PostgreSQL 10 open item is past due for your status update. Kindly send a status update within 24 hours, and include a date for your subsequent status update. Refer to the policy on open item ownership: https://www.postgresql.org/message-id/20170404140717.GA2675809%40tornado.leadboat.com -

Re: [HACKERS] Race conditions with WAL sender PID lookups

On Sat, May 20, 2017 at 09:40:57PM +0900, Michael Paquier wrote: > On Fri, May 19, 2017 at 3:01 PM, Masahiko Sawada > wrote: > > Also, as Horiguchi-san pointed out earlier, walreceiver seems need the > > similar fix. > > Actually, now that I look at it, ready_to_display should as well be > prote

Re: [HACKERS] walsender & parallelism

On Tue, May 23, 2017 at 01:45:59PM -0400, Andres Freund wrote: > On May 23, 2017 1:42:41 PM EDT, Petr Jelinek > wrote: > >Hi, > > > >so this didn't really move anywhere AFAICS, do we think the approach > >I've chosen is good or do we want to do something else here? > > Can you add it to the open

Re: [HACKERS] Why does logical replication launcher set application_name?

On Tue, May 23, 2017 at 07:50:34PM +0200, Petr Jelinek wrote: > On 20/04/17 21:33, Peter Eisentraut wrote: > > On 4/18/17 13:18, Tom Lane wrote: > >> I think you're thinking about it wrong. To my mind the issue is that > >> there should be some generic way to determine that a bgworker process > >>

[HACKERS] Re: pg_dump ignoring information_schema tables which used in Create Publication.

On Fri, May 26, 2017 at 10:46:12PM -0300, Euler Taveira wrote: > 2017-05-26 17:52 GMT-03:00 Peter Eisentraut > : > > You cannot publish a system catalog. But a user-created table in > > information_schema is not a system catalog. > > Replication of information_schema tables works. However, pg_du

Re: [HACKERS] ALTER PUBLICATION documentation

On Wed, May 24, 2017 at 07:24:08PM -0400, Peter Eisentraut wrote: > On 5/22/17 17:50, Jeff Janes wrote: > > "The first variant of this command listed in the synopsis can change all > > of the publication properties specified in CREATE PUBLICATION > >

Re: [HACKERS] PATCH: recursive json_populate_record()

On Mon, May 22, 2017 at 10:19:37PM +0300, Nikita Glukhov wrote: > Attached two small fixes for the previous committed patch: > > 1. I've noticed a difference in behavior between json_populate_record() > and jsonb_populate_record() if we are trying to populate record from a > non-JSON-object: json

[HACKERS] Re: Create subscription with `create_slot=false` and incorrect slot name

On Fri, May 26, 2017 at 05:05:37PM -0400, Peter Eisentraut wrote: > On 5/25/17 19:16, Petr Jelinek wrote: > >> The reported error is just one of many errors that can happen when DROP > >> SUBSCRIPTION tries to drop the slot (doens't exist, still active, no > >> permission, etc.). We don't want to

Re: [HACKERS] Replication status in logical replication

On Fri, May 19, 2017 at 11:33:48AM +0900, Masahiko Sawada wrote: > On Wed, Apr 12, 2017 at 5:31 AM, Simon Riggs wrote: > > On 22 March 2017 at 02:50, Masahiko Sawada wrote: > > > >> When using logical replication, I ran into a situation where the > >> pg_stat_replication.state is not updated unti

Re: [HACKERS] Server ignores contents of SASLInitialResponse

On Thu, May 25, 2017 at 10:52:23AM -0400, Michael Paquier wrote: > On Thu, May 25, 2017 at 9:32 AM, Michael Paquier > wrote: > > On Thu, May 25, 2017 at 8:51 AM, Heikki Linnakangas wrote: > >> On 05/24/2017 11:33 PM, Michael Paquier wrote: > >>> I have noticed today that the server ignores comple

[HACKERS] Re: transition table behavior with inheritance appears broken (was: Declarative partitioning - another take)

On Tue, May 30, 2017 at 01:34:33AM +, Noah Misch wrote: > This PostgreSQL 10 open item is past due for your status update. Kindly send > a status update within 24 hours, and include a date for your subsequent status > update. Refer to the policy on open item ownership

Re: [HACKERS] Get stuck when dropping a subscription during synchronizing table

On Tue, May 30, 2017 at 01:30:35AM +, Noah Misch wrote: > On Thu, May 18, 2017 at 10:27:51PM -0400, Peter Eisentraut wrote: > > On 5/18/17 11:11, Noah Misch wrote: > > > IMMEDIATE ATTENTION REQUIRED. This PostgreSQL 10 open item is past due > > > for > &

Re: [HACKERS] Race conditions with WAL sender PID lookups

On Sun, May 21, 2017 at 08:19:34AM +0200, Erik Rijkers wrote: > On 2017-05-21 06:37, Erik Rijkers wrote: > >With this patch on current master my logical replication tests > >(pgbench-over-logical-replication) run without errors for the first > >time in many days (even weeks). > > Unfortunately, ju

Re: [HACKERS] Get stuck when dropping a subscription during synchronizing table

On Thu, Jun 01, 2017 at 12:00:33AM -0400, Peter Eisentraut wrote: > On 5/31/17 02:51, Noah Misch wrote: > > On Tue, May 30, 2017 at 01:30:35AM +0000, Noah Misch wrote: > >> On Thu, May 18, 2017 at 10:27:51PM -0400, Peter Eisentraut wrote: > >>> On 5/18/17 11:11, Noah

Re: [HACKERS] [PATCH] Fixed malformed error message on malformed SCRAM message.

On Mon, May 29, 2017 at 01:43:26PM -0700, Michael Paquier wrote: > On Mon, May 29, 2017 at 1:38 PM, Daniele Varrazzo > wrote: > > Patch attached > > Right. I am adding that to the list of open items, and Heikki in CC > will likely take care of it. [Action required within three days. This is a g

Re: retry shm attach for windows (WAS: Re: [HACKERS] OK, so culicidae is *still* broken)

On Fri, May 26, 2017 at 05:50:45PM +0530, Amit Kapila wrote: > On Fri, May 26, 2017 at 5:30 AM, Tsunakawa, Takayuki > wrote: > > I guessed that the reason Noah suggested 1 - 5 seconds of retry is based > > on the expectation that the address space might be freed by the anti-virus > > software.

Re: [HACKERS] Server ignores contents of SASLInitialResponse

On Tue, May 30, 2017 at 03:04:47AM +, Noah Misch wrote: > On Thu, May 25, 2017 at 10:52:23AM -0400, Michael Paquier wrote: > > On Thu, May 25, 2017 at 9:32 AM, Michael Paquier > > wrote: > > > On Thu, May 25, 2017 at 8:51 AM, Heikki Linnakangas > > > wro

[HACKERS] Re: Alter subscription..SET - NOTICE message is coming for table which is already removed

On Wed, May 31, 2017 at 10:15:50PM -0400, Peter Eisentraut wrote: > On 5/30/17 13:25, Masahiko Sawada wrote: > > I think this cause is that the relation status entry could be deleted > > by ALTER SUBSCRIPTION REFRESH before corresponding table sync worker > > starting. Attached patch fixes issues r

Re: [HACKERS] walsender & parallelism

On Fri, Jun 02, 2017 at 11:27:55PM -0400, Peter Eisentraut wrote: > On 5/31/17 23:54, Peter Eisentraut wrote: > > On 5/29/17 22:01, Noah Misch wrote: > >> On Tue, May 23, 2017 at 01:45:59PM -0400, Andres Freund wrote: > >>> On May 23, 2017 1:42:41 PM EDT, Petr Je

Re: [HACKERS] Continuous buildfarm failures on hamster with bin-check

On Tue, Apr 18, 2017 at 09:59:26PM +0900, Michael Paquier wrote: > On Tue, Apr 18, 2017 at 9:35 PM, Andrew Dunstan > wrote: > > On 04/18/2017 08:23 AM, Michael Paquier wrote: > >> Increasing wal_sender_timeout and wal_receiver_timeout can help in > >> reducing the failures seen. > > > > OK, but y

[HACKERS] Re: BUG #14680: startup process on standby encounter a deadlock of TwoPhaseStateLock when redo 2PC xlog

On Thu, Jun 01, 2017 at 01:07:53AM -0700, Michael Paquier wrote: > On Wed, May 31, 2017 at 12:30 PM, Michael Paquier > wrote: > > On Wed, May 31, 2017 at 6:57 AM, Tom Lane wrote: > >> wangchuant...@huawei.com writes: > >>> startup process on standby encounter a deadlock of TwoPhaseStateLock when

Re: [HACKERS] BUG #14682: row level security not work with partitioned table

On Fri, Jun 02, 2017 at 09:28:16AM +0900, Michael Paquier wrote: > On Thu, Jun 1, 2017 at 11:13 AM, Mike Palmiotto > wrote: > > This is indeed a bug. fireRIRrules is currently skipping the RLS > > policy check when relkind == PARTITIONED_TABLES, so RLS policies are > > not applied. The attached pa

[HACKERS] Re: Error while creating subscription when server is running in single user mode

On Fri, Jun 02, 2017 at 11:06:52PM -0400, Peter Eisentraut wrote: > On 6/2/17 15:41, Tom Lane wrote: > > It's certainly plausible that we could have the latch code just ignore > > WL_POSTMASTER_DEATH if not IsUnderPostmaster. I think that the original > > reasoning for not doing that was that the

Re: [HACKERS] Server ignores contents of SASLInitialResponse

On Fri, Jun 02, 2017 at 09:58:40PM -0700, Noah Misch wrote: > On Tue, May 30, 2017 at 03:04:47AM +0000, Noah Misch wrote: > > On Thu, May 25, 2017 at 10:52:23AM -0400, Michael Paquier wrote: > > > On Thu, May 25, 2017 at 9:32 AM, Michael Paquier > > > wrote: > >

[HACKERS] Re: transition table behavior with inheritance appears broken (was: Declarative partitioning - another take)

On Wed, May 31, 2017 at 09:14:17AM -0500, Kevin Grittner wrote: > On Wed, May 31, 2017 at 1:44 AM, Noah Misch wrote: > > > IMMEDIATE ATTENTION REQUIRED. > > I should be able to complete review and testing by Friday. If there > are problems I might not take action unti

Re: [HACKERS] [PATCH] Fixed malformed error message on malformed SCRAM message.

On Fri, Jun 02, 2017 at 05:58:59AM +, Noah Misch wrote: > On Mon, May 29, 2017 at 01:43:26PM -0700, Michael Paquier wrote: > > On Mon, May 29, 2017 at 1:38 PM, Daniele Varrazzo > > wrote: > > > Patch attached > > > > Right. I am adding that to the

Re: [HACKERS] walsender & parallelism

On Fri, Jun 02, 2017 at 11:06:29PM -0700, Andres Freund wrote: > On 2017-06-02 22:12:46 -0700, Noah Misch wrote: > > On Fri, Jun 02, 2017 at 11:27:55PM -0400, Peter Eisentraut wrote: > > > On 5/31/17 23:54, Peter Eisentraut wrote: > > > > On 5/29/17 22:01, Noah Misch

Re: [HACKERS] walsender termination error messages worse in v10

On Fri, Jun 02, 2017 at 11:51:26AM -0700, Andres Freund wrote: > commit 7c4f52409a8c7d85ed169bbbc1f6092274d03920 > Author: Peter Eisentraut > Date: 2017-03-23 08:36:36 -0400 > > Logical replication support for initial data copy > > made walreceiver emit worse messages in v10 than before wh

Re: [HACKERS] walsender & parallelism

On Wed, Jun 07, 2017 at 10:54:57PM -0700, Noah Misch wrote: > On Fri, Jun 02, 2017 at 11:06:29PM -0700, Andres Freund wrote: > > On 2017-06-02 22:12:46 -0700, Noah Misch wrote: > > > On Fri, Jun 02, 2017 at 11:27:55PM -0400, Peter Eisentraut wrote: > > > > On 5/31/17

Re: [HACKERS] Re: Alter subscription..SET - NOTICE message is coming for table which is already removed

On Tue, Jun 06, 2017 at 03:21:34PM -0400, Peter Eisentraut wrote: > On 6/3/17 01:04, Noah Misch wrote: > > On Wed, May 31, 2017 at 10:15:50PM -0400, Peter Eisentraut wrote: > >> On 5/30/17 13:25, Masahiko Sawada wrote: > >>> I think this cause is that the relation

[HACKERS] Re: [BUGS] BUG #14682: row level security not work with partitioned table

On Wed, Jun 07, 2017 at 08:45:20AM -0700, Joe Conway wrote: > On 06/07/2017 06:49 AM, Mike Palmiotto wrote: > > I ended up narrowing it down to 4 tables (one parent and 3 partitions) > > in order to demonstrate policy sorting and order of RLS/partition > > constraint checking. It should be much mor

[HACKERS] Re: BUG #14680: startup process on standby encounter a deadlock of TwoPhaseStateLock when redo 2PC xlog

On Sun, Jun 04, 2017 at 10:24:30PM +, Noah Misch wrote: > On Thu, Jun 01, 2017 at 01:07:53AM -0700, Michael Paquier wrote: > > On Wed, May 31, 2017 at 12:30 PM, Michael Paquier > > wrote: > > > On Wed, May 31, 2017 at 6:57 AM, Tom Lane wrote: > > >

[HACKERS] Re: BUG #14680: startup process on standby encounter a deadlock of TwoPhaseStateLock when redo 2PC xlog

On Thu, Jun 08, 2017 at 11:17:38PM -0700, Noah Misch wrote: > On Sun, Jun 04, 2017 at 10:24:30PM +0000, Noah Misch wrote: > > On Thu, Jun 01, 2017 at 01:07:53AM -0700, Michael Paquier wrote: > > > On Wed, May 31, 2017 at 12:30 PM, Michael Paquier > > > wrote: > >

[HACKERS] RTE_NAMEDTUPLESTORE, enrtuples and comments

While completing my annual src/backend/nodes/*funcs.c audit, I noticed defects in commit 18ce3a4 changes to RangeTblEntry: 1. Field relid is under a comment saying it is valid for RTE_RELATION only. Fields coltypes, coltypmods and colcollations are under a comment saying they are valid for R

Re: [HACKERS] Get stuck when dropping a subscription during synchronizing table

On Thu, May 25, 2017 at 01:59:51PM +0530, tushar wrote: > After applying all your patches, drop subscription no more hangs while > dropping subscription but there is an error "ERROR: tuple concurrently > updated" in the log file of > standby. > > --- > logical replication synchronization work

Re: [HACKERS] RTE_NAMEDTUPLESTORE, enrtuples and comments

On Mon, Jun 12, 2017 at 04:04:23PM +1200, Thomas Munro wrote: > On Sun, Jun 11, 2017 at 11:11 PM, Thomas Munro > wrote: > > On Sun, Jun 11, 2017 at 6:25 PM, Noah Misch wrote: > >> This fourth point is not necessarily a defect: I wonder if RangeTblEntry is > >>

Re: [HACKERS] Race conditions with WAL sender PID lookups

On Tue, Jun 13, 2017 at 11:16:54AM +0900, Michael Paquier wrote: > On Thu, Jun 8, 2017 at 1:15 PM, Michael Paquier > wrote: > > 3) In walreceiver.c's pg_stat_get_wal_receiver's: > > - Launch pg_stat_get_wal_receiver and take a checkpoint on it. > > - Pass the lookups of pid and ready_to_display. >

Re: [HACKERS] Something is rotten in publication drop

On Fri, Jun 09, 2017 at 11:45:58AM -0400, Tom Lane wrote: > Peter Eisentraut writes: > > On 6/8/17 23:53, Tom Lane wrote: > >> ! ERROR: publication "addr_pub" does not exist > > > The \d+ command attempts to print out any publications that the relation > > is part of. To find the publications i

[HACKERS] Re: [PATCH] Fix drop replication slot blocking instead of returning error

On Thu, Aug 24, 2017 at 03:38:20PM +0200, Simone Gotti wrote: > I noticed that in postgres 10beta3, calling pg_drop_replication_slot on an > active slot will block until it's released instead of returning an error > like > done in pg 9.6. Since this is a change in the previous behavior and the docs

Re: [HACKERS] More replication race conditions

On Fri, Aug 25, 2017 at 12:09:00PM +0200, Petr Jelinek wrote: > On 24/08/17 19:54, Tom Lane wrote: > > sungazer just failed with > > > > pg_recvlogical exited with code '256', stdout '' and stderr > > 'pg_recvlogical: could not send replication command "START_REPLICATION SLOT > > "test_slot" LOG

Re: [HACKERS] Back-branch release notes up for review

On Sat, Aug 26, 2017 at 03:31:12PM -0400, Tom Lane wrote: > + > + > + > + Show foreign tables > + in information_schema.table_privileges > + view (Peter Eisentraut) > + > + > + > + All other relevant information_schema views include > + foreign tables, bu

Re: [HACKERS] More replication race conditions

On Sun, Aug 27, 2017 at 02:32:49AM +, Noah Misch wrote: > On Fri, Aug 25, 2017 at 12:09:00PM +0200, Petr Jelinek wrote: > > On 24/08/17 19:54, Tom Lane wrote: > > > sungazer just failed with > > > > > > pg_recvlogical exited with code '256', stdo

Re: [HACKERS] More replication race conditions

On Tue, Aug 29, 2017 at 08:44:42PM +0900, Michael Paquier wrote: > On Mon, Aug 28, 2017 at 8:25 AM, Michael Paquier > wrote: > > Today's run has finished with the same failure: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dangomushi&dt=2017-08-27%2018%3A00%3A13 > > Attached is a pat

Re: [HACKERS] Re: [PATCH] Fix drop replication slot blocking instead of returning error

On Tue, Aug 29, 2017 at 12:04:33PM +0200, Alvaro Herrera wrote: > Noah Misch wrote: > > On Thu, Aug 24, 2017 at 03:38:20PM +0200, Simone Gotti wrote: > > > I noticed that in postgres 10beta3, calling pg_drop_replication_slot on an > > > active slot will block unt

Re: [HACKERS] Parallel worker error

On Thu, Aug 31, 2017 at 03:11:10PM -0400, Robert Haas wrote: > On Wed, Aug 30, 2017 at 11:19 AM, Robert Haas wrote: > > But since that's an established design fl^H^Hprinciple, maybe that > > means we should go with the approach of teaching SerializeGUCState() > > to ignore role altogether and inst

[HACKERS] Re: Tuple-routing for certain partitioned tables not working as expected

On Tue, Sep 05, 2017 at 08:35:13PM +0900, Etsuro Fujita wrote: > On 2017/08/30 17:20, Etsuro Fujita wrote: > >On 2017/08/30 9:13, Amit Langote wrote: > >>On 2017/08/29 20:18, Etsuro Fujita wrote: > >>>On 2017/08/25 22:26, Robert Haas wrote: > On Wed, Aug 23, 2017 at 4:55 AM, Etsuro Fujita > >>>

[HACKERS] Re: DROP SUBSCRIPTION hangs if sub is disabled in the same transaction

On Wed, Sep 06, 2017 at 03:28:47PM +0900, Masahiko Sawada wrote: > On Mon, Sep 4, 2017 at 11:43 PM, Arseny Sher wrote: > > Arseny Sher writes: > > > >> Attached patch fixes this by stopping workers before RO drop, as > >> already done in case when we drop replication slot. > > > > Sorry, here is

[HACKERS] Re: DROP SUBSCRIPTION hangs if sub is disabled in the same transaction

On Thu, Sep 07, 2017 at 04:53:12AM +, Noah Misch wrote: > On Wed, Sep 06, 2017 at 03:28:47PM +0900, Masahiko Sawada wrote: > > On Mon, Sep 4, 2017 at 11:43 PM, Arseny Sher wrote: > > > Arseny Sher writes: > > > > > >> Attached patch fixes this

Re: [HACKERS] SCRAM in the PG 10 release notes

On Wed, May 10, 2017 at 10:50:51PM -0400, Bruce Momjian wrote: > On Mon, May 1, 2017 at 08:12:51AM -0400, Robert Haas wrote: > > On Tue, Apr 25, 2017 at 10:16 PM, Bruce Momjian wrote: > > > Well, we could add "MD5 users are encouraged to switch to > > > SCRAM-SHA-256". Now whether we want to lis

[HACKERS] Re: [COMMITTERS] pgsql: Use MINVALUE/MAXVALUE instead of UNBOUNDED for range partition b

On Wed, Sep 13, 2017 at 12:06:40PM -0400, Robert Haas wrote: > On Wed, Sep 13, 2017 at 10:54 AM, Dean Rasheed > wrote: > > Oracle, MySQL and DB2 all use MINVALUE/MAXVALUE. Actually, Oracle and > > MySQL only use MAXVALUE, not MINVALUE, because they don't allow gaps > > between partitions and the

Re: [HACKERS] SCRAM in the PG 10 release notes

On Thu, Sep 14, 2017 at 09:57:36AM +0300, Heikki Linnakangas wrote: > On 09/12/2017 04:09 AM, Noah Misch wrote: > >On Wed, May 10, 2017 at 10:50:51PM -0400, Bruce Momjian wrote: > >>On Mon, May 1, 2017 at 08:12:51AM -0400, Robert Haas wrote: > >>>On Tue, Apr 25, 2

Re: [HACKERS] Back-branch release notes up for review

On Thu, Aug 31, 2017 at 02:53:45AM +, Noah Misch wrote: > On Sat, Aug 26, 2017 at 03:31:12PM -0400, Tom Lane wrote: > > + > > + > > + > > + Show foreign tables > > + in information_schema.table_privileges

[HACKERS] !USE_WIDE_UPPER_LOWER compile errors in v10+

On Sat, Sep 16, 2017 at 03:33:53PM -0700, Peter Geoghegan wrote: > On a related note, am I the only one that finds it questionable that > str_tolower() has an "#ifdef USE_WIDE_UPPER_LOWER" block that itself > contains an "#ifdef USE_ICU" block? It seems like those two things > might get conflated o

<    1   2   3   4   5   6   7   8   9   10   >