On Thu, Feb 2, 2017 at 12:24 PM, David Fetter wrote:
>> Also, somebody who wants a check like that isn't necessarily going
>> to want "no WHERE clause" training wheels. So you're going to need
>> to think about facilities to enable or disable different checks.
>
> This is just the discussion I'd
On Sun, Feb 5, 2017 at 10:08 AM, Rod Taylor wrote:
> A general SQL-Critic would be a very welcome extension.
Please no hyphen for extension names!
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/m
On Thu, Feb 2, 2017 at 11:40 AM, Alvaro Herrera
wrote:
> Pavel Stehule wrote:
>
> > Identification of unjoined tables should be very useful - but it is far
> to
> > original proposal - so it can be solved separately.
> >
> > This patch is simple - and usually we prefer more simple patches than on
On Thu, Feb 02, 2017 at 12:14:10PM -0500, Tom Lane wrote:
> Also, somebody who wants a check like that isn't necessarily going to want
> "no WHERE clause" training wheels. So you're going to need to think about
> facilities to enable or disable different checks.
WHERE-less-ness should be somethin
On Thu, Feb 02, 2017 at 12:14:10PM -0500, Tom Lane wrote:
> Alvaro Herrera writes:
> > Pavel Stehule wrote:
> >> Better to enhance this feature step by step.
>
> > Agreed -- IMO this is a reasonable first step, except that I would
> > rename the proposed extension so that it doesn't focus solely
Alvaro Herrera writes:
> Pavel Stehule wrote:
>> Better to enhance this feature step by step.
> Agreed -- IMO this is a reasonable first step, except that I would
> rename the proposed extension so that it doesn't focus solely on the
> first step.
Quite. The patch fails to make up its mind whet
Pavel Stehule wrote:
> Identification of unjoined tables should be very useful - but it is far to
> original proposal - so it can be solved separately.
>
> This patch is simple - and usually we prefer more simple patches than one
> bigger.
>
> Better to enhance this feature step by step.
Agreed
2017-02-02 16:34 GMT+01:00 Bruce Momjian :
> On Thu, Feb 2, 2017 at 07:18:45AM -0800, David Fetter wrote:
> > On Thu, Feb 02, 2017 at 03:16:29PM +, Bruce Momjian wrote:
> > > I just don't see this patch going in. I think it needs are larger
> > > approach to the problems it is trying to solv
On Thu, Feb 02, 2017 at 10:34:43AM -0500, Bruce Momjian wrote:
> On Thu, Feb 2, 2017 at 07:18:45AM -0800, David Fetter wrote:
> > On Thu, Feb 02, 2017 at 03:16:29PM +, Bruce Momjian wrote:
> > > I just don't see this patch going in. I think it needs are
> > > larger approach to the problems i
On Thu, Feb 2, 2017 at 07:18:45AM -0800, David Fetter wrote:
> On Thu, Feb 02, 2017 at 03:16:29PM +, Bruce Momjian wrote:
> > I just don't see this patch going in. I think it needs are larger
> > approach to the problems it is trying to solve. I think it then
> > will be very useful.
>
> Wh
I just don't see this patch going in. I think it needs are larger approach to
the problems it is trying to solve. I think it then will be very useful.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/p
On Thu, Feb 02, 2017 at 03:16:29PM +, Bruce Momjian wrote:
> I just don't see this patch going in. I think it needs are larger
> approach to the problems it is trying to solve. I think it then
> will be very useful.
What problems that it's trying to solve are not addressed?
Best,
David.
--
On Wed, Jan 11, 2017 at 11:55 PM, Pavel Stehule wrote:
> I'll mark this patch as ready for commiter
Moved to CF 2017-03.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Hi
2017-01-10 17:31 GMT+01:00 David Fetter :
> On Mon, Jan 09, 2017 at 07:52:11PM -0300, Alvaro Herrera wrote:
> > David Fetter wrote:
> >
> > > + if (query->commandType == CMD_UPDATE || query->commandType ==
> CMD_DELETE)
> > > + {
> > > + /* Make sure there's something to look at.
On Tue, Jan 10, 2017 at 08:31:47AM -0800, David Fetter wrote:
> On Mon, Jan 09, 2017 at 07:52:11PM -0300, Alvaro Herrera wrote:
> > David Fetter wrote:
> >
> > > + if (query->commandType == CMD_UPDATE || query->commandType ==
> > > CMD_DELETE)
> > > + {
> > > + /* Make sure there's someth
On Mon, Jan 09, 2017 at 07:52:11PM -0300, Alvaro Herrera wrote:
> David Fetter wrote:
>
> > + if (query->commandType == CMD_UPDATE || query->commandType ==
> > CMD_DELETE)
> > + {
> > + /* Make sure there's something to look at. */
> > + Assert(query->jointree != NULL);
>
On Mon, Jan 09, 2017 at 07:52:11PM -0300, Alvaro Herrera wrote:
> David Fetter wrote:
>
> > + if (query->commandType == CMD_UPDATE || query->commandType ==
> > CMD_DELETE)
> > + {
> > + /* Make sure there's something to look at. */
> > + Assert(query->jointree != NULL);
>
David Fetter wrote:
> + if (query->commandType == CMD_UPDATE || query->commandType ==
> CMD_DELETE)
> + {
> + /* Make sure there's something to look at. */
> + Assert(query->jointree != NULL);
> + if (query->jointree->quals == NULL)
> +
On Sun, Jan 08, 2017 at 06:50:12PM -0600, Jim Nasby wrote:
> On 1/5/17 12:04 AM, David Fetter wrote:
> > +errmsg("UPDATE requires a WHERE clause
> > when require_where.delete is set to on"),
>
> ISTM that message is no longer true.
>
> The second if could also
On 1/5/17 12:04 AM, David Fetter wrote:
+errmsg("UPDATE requires a WHERE clause when
require_where.delete is set to on"),
ISTM that message is no longer true.
The second if could also be an else if too.
--
Jim Nasby, Data Architect, Blue Treble Consulti
On Wed, Jan 04, 2017 at 09:58:26PM -0800, David Fetter wrote:
> On Sun, Jan 01, 2017 at 07:57:33PM +0900, Michael Paquier wrote:
> > On Sun, Jan 1, 2017 at 12:34 PM, David Fetter wrote:
> > > I've rolled your patches into this next one and clarified the commit
> > > message, as there appears to ha
On Sun, Jan 01, 2017 at 07:57:33PM +0900, Michael Paquier wrote:
> On Sun, Jan 1, 2017 at 12:34 PM, David Fetter wrote:
> > I've rolled your patches into this next one and clarified the commit
> > message, as there appears to have been some confusion about the scope.
>
> Is there actually a meani
On Tue, Jan 03, 2017 at 11:59:19AM +0100, Pavel Stehule wrote:
> Hi
> I am sending review of this patch
>
> 1. there are not any problem with patching, compiling, doc
> 2. the patch is simple, the documentation is good enough
> 3. all regress tests passed without problems
>
> My questions:
>
> 1
On Sun, Jan 01, 2017 at 07:57:33PM +0900, Michael Paquier wrote:
> On Sun, Jan 1, 2017 at 12:34 PM, David Fetter wrote:
> > I've rolled your patches into this next one and clarified the commit
> > message, as there appears to have been some confusion about the scope.
>
> Not all the comments have
Hi
2016-07-21 6:57 GMT+02:00 David Fetter :
> Folks,
>
> Please find attached a patch which makes it possible to disallow
> UPDATEs and DELETEs which lack a WHERE clause. As this changes query
> behavior, I've made the new GUCs PGC_SUSET.
>
> What say?
>
> Thanks to Gurjeet Singh for the idea an
On Sun, Jan 1, 2017 at 12:34 PM, David Fetter wrote:
> I've rolled your patches into this next one and clarified the commit
> message, as there appears to have been some confusion about the scope.
Not all the comments have been considered!
Here are some example..
=# set require_where.delete to
On Fri, Sep 30, 2016 at 04:23:13PM +1300, Thomas Munro wrote:
> On Thu, Sep 29, 2016 at 6:19 PM, David Fetter wrote:
> > On Thu, Sep 29, 2016 at 11:12:11AM +1300, Thomas Munro wrote:
> >> On Mon, Sep 26, 2016 at 5:11 PM, Thomas Munro
> >> wrote:
> >> > On Mon, Sep 26, 2016 at 1:18 PM, Thomas Munr
On Sat, Oct 1, 2016 at 5:08 AM, Thomas Munro
wrote:
> I guess you need something involving query_tree_walker or some other
> kind of recursive traversal if you want to find DELETE/UPDATE lurking
> in there.
>
> One option would be to document it as working for top level DELETE or
> UPDATE, and lea
On Sat, Oct 1, 2016 at 5:08 AM, Thomas Munro
wrote:
> Right. These cases work because they show up as CMD_DELETE/CMD_UPDATE:
>
> postgres=# set require_where.delete = on;
> SET
> postgres=# with answer as (select 42) delete from foo;
> ERROR: DELETE requires a WHERE clause when require_where.del
On Sat, Oct 1, 2016 at 8:32 AM, Julien Rouhaud
wrote:
> On 30/09/2016 21:12, David Fetter wrote:
>> On Fri, Sep 30, 2016 at 06:37:17PM +0200, Julien Rouhaud wrote:
>>> On 30/09/2016 05:23, Thomas Munro wrote:
It would be really nice to be able to set this to 'Ready for
Committer' in
On 9/29/16 11:23 PM, Thomas Munro wrote:
> The regression test fails. The expected error messages show the old
> wording, so I think you forgot to add a file. Also, should
> contrib/require_where/Makefile define REGRESS = require_where? That
> would allow 'make check' from inside that directory,
On 30/09/2016 21:12, David Fetter wrote:
> On Fri, Sep 30, 2016 at 06:37:17PM +0200, Julien Rouhaud wrote:
>> On 30/09/2016 05:23, Thomas Munro wrote:
>>>
>>> It would be really nice to be able to set this to 'Ready for
>>> Committer' in this CF. Do you want to post a v6 patch or are you
>>> happy
On Fri, Sep 30, 2016 at 06:37:17PM +0200, Julien Rouhaud wrote:
> On 30/09/2016 05:23, Thomas Munro wrote:
> >
> > It would be really nice to be able to set this to 'Ready for
> > Committer' in this CF. Do you want to post a v6 patch or are you
> > happy for me to ask a committer to look at v5 +
Thomas Munro wrote:
> On Thu, Sep 29, 2016 at 6:19 PM, David Fetter wrote:
> > Please find attached the next revision.
>
> I'm not sold on ERRCODE_SYNTAX_ERROR. There's nothing wrong with the
> syntax, since parsing succeeded. It would be cool if we could use
> ERRCODE_E_R_E_PROHIBITED_SQL_STA
On 30/09/2016 05:23, Thomas Munro wrote:
>
> It would be really nice to be able to set this to 'Ready for
> Committer' in this CF. Do you want to post a v6 patch or are you
> happy for me to ask a committer to look at v5 + these three
> corrections?
I just looked at the patch, and noticed that o
On Thu, Sep 29, 2016 at 6:19 PM, David Fetter wrote:
> On Thu, Sep 29, 2016 at 11:12:11AM +1300, Thomas Munro wrote:
>> On Mon, Sep 26, 2016 at 5:11 PM, Thomas Munro
>> wrote:
>> > On Mon, Sep 26, 2016 at 1:18 PM, Thomas Munro
>> > wrote:
>> >>
>> >> On Mon, Sep 19, 2016 at 4:02 PM, David Fetter
On Thu, Sep 29, 2016 at 11:12:11AM +1300, Thomas Munro wrote:
> On Mon, Sep 26, 2016 at 5:11 PM, Thomas Munro
> wrote:
> > On Mon, Sep 26, 2016 at 1:18 PM, Thomas Munro
> > wrote:
> >>
> >> On Mon, Sep 19, 2016 at 4:02 PM, David Fetter wrote:
> >> >
> >> > [training_wheels_004.patch]
> >>
> >> [
On Thu, Sep 29, 2016 at 11:12:11AM +1300, Thomas Munro wrote:
> On Mon, Sep 26, 2016 at 5:11 PM, Thomas Munro
> wrote:
> > On Mon, Sep 26, 2016 at 1:18 PM, Thomas Munro
> > wrote:
> >>
> >> On Mon, Sep 19, 2016 at 4:02 PM, David Fetter wrote:
> >> >
> >> > [training_wheels_004.patch]
> >>
> >> [
On Mon, Sep 26, 2016 at 5:11 PM, Thomas Munro
wrote:
> On Mon, Sep 26, 2016 at 1:18 PM, Thomas Munro
> wrote:
>>
>> On Mon, Sep 19, 2016 at 4:02 PM, David Fetter wrote:
>> >
>> > [training_wheels_004.patch]
>>
>> [review]
Ping.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-
On Mon, Sep 26, 2016 at 5:11 PM, Thomas Munro wrote:
> It seems that the version of docbook that you get if you follow the
> instructions[1] ...
>
And I mean these instructions: [1]
https://www.postgresql.org/docs/devel/static/docguide-toolsets.html
--
Thomas Munro
http://www.enterprisedb.com
On Mon, Sep 26, 2016 at 1:18 PM, Thomas Munro wrote:
> On Mon, Sep 19, 2016 at 4:02 PM, David Fetter wrote:
> >
> > [training_wheels_004.patch]
>
> openjade:filelist.sgml:144:16:E: character "_" invalid: only parameter
> literal, "CDATA", "ENDTAG", "MD", "MS", "PI", "PUBLIC", "SDATA",
> "STARTTA
On Mon, Sep 26, 2016 at 5:48 AM, Thomas Munro wrote:
> On Mon, Sep 19, 2016 at 4:02 PM, David Fetter wrote:
> >
> > [training_wheels_004.patch]
>
> openjade:filelist.sgml:144:16:E: character "_" invalid: only parameter
> literal, "CDATA", "ENDTAG", "MD", "MS", "PI", "PUBLIC", "SDATA",
> "STARTTA
On Mon, Sep 26, 2016 at 1:18 PM, Thomas Munro
wrote:
> underscore to a minus in various places. That fixes these errors:
Correction: s/these errors:/the above errors./
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make c
On Mon, Sep 19, 2016 at 4:02 PM, David Fetter wrote:
>
> [training_wheels_004.patch]
openjade:filelist.sgml:144:16:E: character "_" invalid: only parameter
literal, "CDATA", "ENDTAG", "MD", "MS", "PI", "PUBLIC", "SDATA",
"STARTTAG", "SYSTEM" and parameter separators allowed
openjade:contrib.sgml:
On 9/20/16 3:04 PM, David Fetter wrote:
> On Fri, Sep 09, 2016 at 09:57:21AM -0400, Peter Eisentraut wrote:
>> Review of the patch in the commit fest:
>>
>> - The documentation is a bit incorrect about the ways to load this
>> module. shared_preload_libraries is not necessary. session_ and
>>
On Fri, Sep 09, 2016 at 09:57:21AM -0400, Peter Eisentraut wrote:
> Review of the patch in the commit fest:
>
> - The documentation is a bit incorrect about the ways to load this
> module. shared_preload_libraries is not necessary. session_ and
> local_ (with prep) should also work.
Would y
On Mon, Sep 19, 2016 at 03:00:51PM -0400, Peter Eisentraut wrote:
> On 9/19/16 12:02 AM, David Fetter wrote:
> >> - The claim in the documentation that only superusers can do things
> >> > with this module is not generally correct.
> > I think that the claims are fixed. This is SUSET, at least i
On 9/19/16 12:02 AM, David Fetter wrote:
>> - The claim in the documentation that only superusers can do things
>> > with this module is not generally correct.
> I think that the claims are fixed. This is SUSET, at least in this
> patch, because anything short of that that changes query behavior
On Mon, Sep 19, 2016 at 12:02 AM, David Fetter wrote:
>> - The claim in the documentation that only superusers can do things
>> with this module is not generally correct.
>
> I think that the claims are fixed. This is SUSET, at least in this
> patch, because anything short of that that changes
On Fri, Sep 09, 2016 at 09:57:21AM -0400, Peter Eisentraut wrote:
> Review of the patch in the commit fest:
>
> - Various naming/spelling inconsistencies: In the source, the module
> is require_where, the documentation titles it require-where, the GUC
> parameters are requires_where.*, but inc
On 8/1/16 11:38 AM, Bruce Momjian wrote:
I am hoping for a "novice" mode that issues warnings about possible
bugs, e.g. unintentionally-correlated subselect, and this could be part
of that.
Somewhat related; I've recently been wondering about a mode that
disallows Const's in queries coming fro
Review of the patch in the commit fest:
- Various naming/spelling inconsistencies: In the source, the module
is require_where, the documentation titles it require-where, the GUC
parameters are requires_where.*, but incorrectly documented.
- Unusual indentation in the Makefile
- Needs tests
On Thu, Jul 21, 2016 at 09:49:33AM -0400, Tom Lane wrote:
> David Fetter writes:
> > Please find attached a patch which makes it possible to disallow
> > UPDATEs and DELETEs which lack a WHERE clause. As this changes query
> > behavior, I've made the new GUCs PGC_SUSET.
>
> > What say?
>
> -1.
On Wed, Jul 27, 2016 at 02:59:17PM +0200, Vik Fearing wrote:
> On 27/07/16 06:11, David Fetter wrote:
> > On Wed, Jul 27, 2016 at 03:24:28AM +0200, Vik Fearing wrote:
> >> On 27/07/16 03:15, Peter Eisentraut wrote:
> >>> On 7/26/16 6:14 PM, Vik Fearing wrote:
> As mentioned elsewhere in the th
On Tue, Jul 26, 2016 at 6:15 PM, Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 7/26/16 6:14 PM, Vik Fearing wrote:
> > As mentioned elsewhere in the thread, you can just do WHERE true to get
> > around it, so why on Earth have it PGC_SUSET?
>
> I'm not sure whether it's supposed
On 27/07/16 06:11, David Fetter wrote:
> On Wed, Jul 27, 2016 at 03:24:28AM +0200, Vik Fearing wrote:
>> On 27/07/16 03:15, Peter Eisentraut wrote:
>>> On 7/26/16 6:14 PM, Vik Fearing wrote:
As mentioned elsewhere in the thread, you can just do WHERE true
to get around it, so why on Earth
On Wed, Jul 27, 2016 at 03:24:28AM +0200, Vik Fearing wrote:
> On 27/07/16 03:15, Peter Eisentraut wrote:
> > On 7/26/16 6:14 PM, Vik Fearing wrote:
> >> As mentioned elsewhere in the thread, you can just do WHERE true
> >> to get around it, so why on Earth have it PGC_SUSET?
> >
> > I'm not sure
Peter Eisentraut writes:
> On 7/26/16 6:14 PM, Vik Fearing wrote:
>> As mentioned elsewhere in the thread, you can just do WHERE true to get
>> around it, so why on Earth have it PGC_SUSET?
> I'm not sure whether it's supposed to guard against typos and possibly
> buggy SQL string concatenation i
On 27/07/16 03:15, Peter Eisentraut wrote:
> On 7/26/16 6:14 PM, Vik Fearing wrote:
>> As mentioned elsewhere in the thread, you can just do WHERE true to get
>> around it, so why on Earth have it PGC_SUSET?
>
> I'm not sure whether it's supposed to guard against typos and possibly
> buggy SQL str
On 7/26/16 6:14 PM, Vik Fearing wrote:
> As mentioned elsewhere in the thread, you can just do WHERE true to get
> around it, so why on Earth have it PGC_SUSET?
I'm not sure whether it's supposed to guard against typos and possibly
buggy SQL string concatenation in application code. So it would h
On Tue, Jul 26, 2016 at 04:39:14PM -0400, Robert Haas wrote:
> On Mon, Jul 25, 2016 at 11:38 PM, David Fetter wrote:
> > On Mon, Jul 25, 2016 at 11:12:24PM -0400, Robert Haas wrote:
> >> On Fri, Jul 22, 2016 at 2:38 AM, David Fetter wrote:
> >> > I've renamed it to require_where and contrib-ified
On 21/07/16 06:57, David Fetter wrote:
> Folks,
>
> Please find attached a patch which makes it possible to disallow
> UPDATEs and DELETEs which lack a WHERE clause. As this changes query
> behavior, I've made the new GUCs PGC_SUSET.
>
> What say?
I say I don't like this at all.
As mentioned e
On Mon, Jul 25, 2016 at 11:38 PM, David Fetter wrote:
> On Mon, Jul 25, 2016 at 11:12:24PM -0400, Robert Haas wrote:
>> On Fri, Jul 22, 2016 at 2:38 AM, David Fetter wrote:
>> > I've renamed it to require_where and contrib-ified.
>>
>> I'm not sure that the Authors section is entirely complete.
>
On Mon, Jul 25, 2016 at 11:12:24PM -0400, Robert Haas wrote:
> On Fri, Jul 22, 2016 at 2:38 AM, David Fetter wrote:
> > I've renamed it to require_where and contrib-ified.
>
> I'm not sure that the Authors section is entirely complete.
Does this suit?
Best,
David.
--
David Fetter http://fette
On Fri, Jul 22, 2016 at 2:38 AM, David Fetter wrote:
> I've renamed it to require_where and contrib-ified.
I'm not sure that the Authors section is entirely complete.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing
On Thu, Jul 21, 2016 at 09:52:26AM -0700, David Fetter wrote:
> On Thu, Jul 21, 2016 at 12:46:29PM -0400, Robert Haas wrote:
> > On Thu, Jul 21, 2016 at 12:39 PM, David Fetter wrote:
> > > On Thu, Jul 21, 2016 at 06:20:37PM +0300, Teodor Sigaev wrote:
> > >> > Please find attached a patch which ma
On Thu, Jul 21, 2016 at 04:48:37PM -0500, Jim Nasby wrote:
> On 7/21/16 11:46 AM, David Fetter wrote:
> > > > Can't you implement this as a extension?
> > Yes. In that case, I'd want to make it a contrib extension, as it is
> > at least in theory attached to specific major versions of the backend.
On 7/21/16 11:46 AM, David Fetter wrote:
> Can't you implement this as a extension?
Yes. In that case, I'd want to make it a contrib extension, as it is
at least in theory attached to specific major versions of the backend.
Howso?
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin T
On Thu, Jul 21, 2016 at 12:49 PM, Abhijit Menon-Sen
wrote:
> At 2016-07-21 12:46:29 -0400, robertmh...@gmail.com wrote:
>>
>> I join with others in thinking it's a reasonable contrib module.
>
> I don't like the use of the term "empty" to describe an UPDATE or DELETE
> without a WHERE clause.
/m
At 2016-07-21 12:46:29 -0400, robertmh...@gmail.com wrote:
>
> I join with others in thinking it's a reasonable contrib module.
I don't like the use of the term "empty" to describe an UPDATE or DELETE
without a WHERE clause.
-- Abhijit
--
Sent via pgsql-hackers mailing list (pgsql-hackers@post
On Thu, Jul 21, 2016 at 12:51:50PM -0400, Robert Haas wrote:
> On Thu, Jul 21, 2016 at 12:49 PM, Abhijit Menon-Sen
> wrote:
> > At 2016-07-21 12:46:29 -0400, robertmh...@gmail.com wrote:
> >>
> >> I join with others in thinking it's a reasonable contrib module.
> >
> > I don't like the use of the
On Thu, Jul 21, 2016 at 12:46:29PM -0400, Robert Haas wrote:
> On Thu, Jul 21, 2016 at 12:39 PM, David Fetter wrote:
> > On Thu, Jul 21, 2016 at 06:20:37PM +0300, Teodor Sigaev wrote:
> >> > Please find attached a patch which makes it possible to disallow
> >> > UPDATEs and DELETEs which lack a WH
On Thu, Jul 21, 2016 at 09:21:55AM -0400, Jim Mlodgenski wrote:
> On Thu, Jul 21, 2016 at 12:57 AM, David Fetter wrote:
> > Please find attached a patch which makes it possible to disallow
> > UPDATEs and DELETEs which lack a WHERE clause. As this changes
> > query behavior, I've made the new GUC
On Thu, Jul 21, 2016 at 12:39 PM, David Fetter wrote:
> On Thu, Jul 21, 2016 at 06:20:37PM +0300, Teodor Sigaev wrote:
>> > Please find attached a patch which makes it possible to disallow
>> > UPDATEs and DELETEs which lack a WHERE clause. As this changes query
>> > behavior, I've made the new G
On Thu, Jul 21, 2016 at 06:20:37PM +0300, Teodor Sigaev wrote:
> > Please find attached a patch which makes it possible to disallow
> > UPDATEs and DELETEs which lack a WHERE clause. As this changes query
> > behavior, I've made the new GUCs PGC_SUSET.
> >
> > What say?
>
> DELETE FROM tbl WHERE
Please find attached a patch which makes it possible to disallow
UPDATEs and DELETEs which lack a WHERE clause. As this changes query
behavior, I've made the new GUCs PGC_SUSET.
What say?
DELETE FROM tbl WHERE true; ?
--
Teodor Sigaev E-mail: teo...@sigaev.ru
On 07/21/2016 06:49 AM, Tom Lane wrote:
David Fetter writes:
Please find attached a patch which makes it possible to disallow
UPDATEs and DELETEs which lack a WHERE clause. As this changes query
behavior, I've made the new GUCs PGC_SUSET.
What say?
-1
-1. This is an express violation
David Fetter writes:
> Please find attached a patch which makes it possible to disallow
> UPDATEs and DELETEs which lack a WHERE clause. As this changes query
> behavior, I've made the new GUCs PGC_SUSET.
> What say?
-1. This is an express violation of the SQL standard, and at least the
UPDATE
On 21 July 2016 at 15:49, Amit Kapila wrote:
> On Thu, Jul 21, 2016 at 10:27 AM, David Fetter wrote:
> > Folks,
> >
> > Please find attached a patch which makes it possible to disallow
> > UPDATEs and DELETEs which lack a WHERE clause. As this changes query
> > behavior, I've made the new GUCs
On Thu, Jul 21, 2016 at 12:57 AM, David Fetter wrote:
> Folks,
>
> Please find attached a patch which makes it possible to disallow
> UPDATEs and DELETEs which lack a WHERE clause. As this changes query
> behavior, I've made the new GUCs PGC_SUSET.
>
> What say?
>
>
Can't you implement this as a
On Thu, Jul 21, 2016 at 10:27 AM, David Fetter wrote:
> Folks,
>
> Please find attached a patch which makes it possible to disallow
> UPDATEs and DELETEs which lack a WHERE clause. As this changes query
> behavior, I've made the new GUCs PGC_SUSET.
>
> What say?
>
The use case for this functiona
Folks,
Please find attached a patch which makes it possible to disallow
UPDATEs and DELETEs which lack a WHERE clause. As this changes query
behavior, I've made the new GUCs PGC_SUSET.
What say?
Thanks to Gurjeet Singh for the idea and Andrew Gierth for the tips
implementing.
Best,
David.
--
82 matches
Mail list logo