Patch applied, thanks. I actually told somebody off roundly about this
not long ago.
cheers
andrew
Greg Sabino Mullane wrote:
Using $a and $b for temporary vars are bad form for our example,
as they have special meaning in Perl.
[snip]
---(end of broadcast)--
Greg Sabino Mullane wrote:
Tom Lane asked:
Please, tell me that isn't so. $a is a reserved name now? What was
Larry thinking?
It's not that bad, really. $a and $b have special meaning inside of
a sort subroutine as the two items being compared. Thus, you can write
something like
Small nit: please observe postgres community conventions regarding
a) indentation (BSD style, tabsize 4) and
b) diff type (context, not unidiff)
The patch itself looks ok to me.
cheers
andrew
daveg wrote:
Apologies if this is old news, but pg_autovacuum in 8.0.x has the bad habit
of SEGVin
Tom Lane wrote:
daveg <[EMAIL PROTECTED]> writes:
Below is a patch for this that should apply against any 8.0.x. The change
verifies that the catalog query returned some rows before accessing the row
data.
Surely this is completely broken? AFAICT you are testing the result
from a V
The attached small patch removes the useless struct timezone argument to
gettimeofday() in a few places and replaces it with NULL, bringing it
into line with the rest of the code.
If noone objects I will apply this soon.
cheers
andrew
Index: src/backend/postmaster/postmaster.c
=
I wrote:
The attached small patch removes the useless struct timezone argument
to gettimeofday() in a few places and replaces it with NULL, bringing
it into line with the rest of the code.
If noone objects I will apply this soon.
applied.
cheers
andrew
---(end
Well, I personally almost always use indirect file handles rather than
globals. But I don't know that using globals file handles (which is what
I gather you are objecting to) is deprecated, is it? The perl docs are
absolutely littered with examples.
(I also use BSD style intentation consiste
Greg Sabino Mullane wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Well, I personally almost always use indirect file handles rather than
globals. But I don't know that using globals file handles (which is what
I gather you are objecting to) is deprecated, is it? The perl docs are
Alvaro Herrera said:
> Hi,
>
> (It also allows PL/php to compile without having to patch
> PHP nor PostgreSQL sources).
>
That will make some people I know happy ;-)
cheers
andrew
---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster
[patches removed]
Tom Lane wrote:
Simon Riggs <[EMAIL PROTECTED]> writes:
It seems straightforward enough to put in an additional test, similar to
the ones already there so that if its too big for a decimal we make it a
float straight away - only a float can be that big in that case. After
Christopher Browne wrote:
Actually, there is a reason NOT to apply the patch in general on all
platforms; it introduces logic (an if {} else {} statement) in a place
where there wasn't previously one, which *presumably* slows things
down somewhat. I don't know if the memcpy() calls are invoke
Hiroshi Saito wrote:
Hi.
Although this is a comment, it is bad condition.
The syntax interpretation of a conf editor gets confused.
We wish correction of postgresql.conf.sample.
Fix (missing quote mark) applied to head and 8.1 branches. Thanks
andrew
---(end
Ther attached patch is for comment. It implements "drop if exists" as
has recently been discussed. Illustration:
andrew=# drop table blurflx;
ERROR: table "blurflx" does not exist
andrew=# drop table if exists blurflx;
DROP TABLE
andrew=# create table blurflx ( x text);
CREATE TABLE
andrew=#
exists blurflx;
DROP TABLE
andrew=# drop table blurflx;
ERROR: table "blurflx" does not exist
andrew=#
revised patch attached.
cheers
andrew
Tom Lane wrote:
Andrew Dunstan <[EMAIL PROTECTED]> writes:
andrew=# drop table blurflx;
ERROR: table "blurflx" does not exi
I am wondering we should make this warning more prominent - it would be
easily missed buried on the Oracle porting section, and I have seen
people caught by it lots of times.
cheers
andrew
Philip Yarra wrote:
Hi, I supplied a minor doco patch relating to porting pl/SQL to pl/pgSQL:
http:/
Christopher Kings-Lynne said:
> Will we get this functionality for ALL objects?
>
The patch does these: table, view, index, sequence, schema, type, domain,
and conversion. The reason is that these are all dealt with using the same
bit of the grammar, and the first 4 are pretty much completely done
Christopher Kings-Lynne wrote:
I think anything else will have to be done individually, although the
pattern can be copied.
Perhaps we should take bids on what should/should not be covered.
Everything should be covered, otherwise it's just annoying for users...
Well, that's arguably mor
Joshua D. Drake wrote:
With Slony and Replicator I don't really see the need for in place
upgrades.
Maintaining a replica is hardly a cost-free exercise.
However, I don't think we can promise never to change the ondisk
representation of data, nor the page layout. Sometimes an inplace
up
I will apply the attached patch tomorrow, barring objection. This covers
drop if exists for the following objects:
table view index sequence schema type domain conversion
I have a simple test script as show below, but I am not sure where to
put it in the regression tests - add a new one may
Tom Lane wrote:
New test seems reasonable.
done.
A few other minor comments:
* The NOTICEs should probably not carry an ERRCODE; usually you just
want a notice to go out with the default "not an error" SQLSTATE.
done.
* The "Assert(missing_ok)"s are a waste of code space --- if
Bruce Momjian wrote:
Let's go ahead and apply the patch. While this change isn't very
significant, I bet there will be other changes in 8.2 where we will want
to change the database for a significant benefit, like reducing the
tuple header by 4 bytes by recompressing the four xid/cid fields
here's a patch for "drop database if exists". Barring objections I will
apply it in a day or two.
cheers
andrew
Index: doc/src/sgml/ref/drop_database.sgml
===
RCS file: /cvsroot/pgsql/doc/src/sgml/ref/drop_database.sgml,v
retr
Tom Lane wrote:
Andrew Dunstan <[EMAIL PROTECTED]> writes:
here's a patch for "drop database if exists". Barring objections I will
apply it in a day or two.
Please try to remember the src/backend/nodes/ files this time.
(In general, when modifying a widely-k
Nice analysis, but we can't hack configure like that. It has to be able
to be fully generated from its sources. I think the other source file
you would need to look at is config/programs.m4. (Not sure about quoting
$ac_popdir - why only that one?)
Also, I suspect we'd want to enable the libe
Martijn van Oosterhout wrote:
Regarding the other, this is the kind of thing the buildfarm would be
good for. Would it be possible to arrange for each buildfarm machine to
execute the following after successful completion and capture the
output? It only needs to be run once.
cd $SOURCEDIR/src
Tom Lane wrote:
Bruce Momjian writes:
I trimmed it down to:
--with-prefer-libedit prefer libedit over readline
OK, I can live with that.
I think it's ugly. Can't we just say --prefer-libedit ?
If must be a --with-foo flag, maybe --with-libedit-pre
Magnus Hagander wrote:
BTW, has anyone checked Command Prompt's Subversion
repository? It's a mirror of our anonymous CVS (AFAICT).
I'm using it for reading diffs lately, and it's much nicer to
look at the whole patch as a single diff rather than going a
single file at a time.
http://pr
Bruce Momjian wrote:
One question I have is why ecpglib didn't need to use our snprintf.c in
the past. Didn't our macros spill in to ecpglib before?
The problem really only happened on Windows, I believe, and we had
disabled use of our macros there.
cheers
andrew
--
Sergey E. Koposov wrote:
I also wanted this feature for a long time.
And I agree that it is rather simple to just remove the \n when writing to the
readline history file, but I don't think that's what everybody wants. I
think that people want to preserve the original formatting...
So in tha
Dmitry,
please supply documentation (i.e. a patch to the SGML) to accompany this
patch, or at the very least a description of how it works, with the
promise of proper documentation to follow.
cheers
andrew
---(end of broadcast)---
TIP 2: Don'
Dmitry Karasik wrote:
Dmitry,
please supply documentation (i.e. a patch to the SGML) to accompany this
patch, or at the very least a description of how it works, with the
promise of proper documentation to follow.
I am willing to write a proper documentation, but I haven't found the
Tom Lane said:
>
> I'm not sure why this is in TODO; it's a stupid if not outright
> dangerous idea.
I agree, in this case ... BUT ...
This is what bothers me about having such an informal TODO list. There is a
danger that people will work in items only to have them shot down, which is
a great w
Bruce Momjian wrote:
Mahmoud Taghizadeh wrote:
I have updated the FAQ. both text version and html version are attached
to this mail. please update the CVS
Uh, the master for Farsi is in HTML, not in text format, which is what
you supplied. See doc/src/FAQ/FAQ_farsi.html.
The reas
Tom Lane said:
> "Pavel Stehule" <[EMAIL PROTECTED]> writes:
>> x, y := r;
>
> That strikes me as a really bad idea. It weakens both syntax and
> semantic error checking, to accomplish how much?
>
Where does the idea come from anyway? Has it been discussed on -hackers? I
don't recall seeing
I wrote:
Tom Lane wrote:
Andrew Dunstan <[EMAIL PROTECTED]> writes:
Nearly everyone seems to agree that the default for max_fsm_pages is
woefully low, so I would like to have the default for this set
unconditionally to 200,000 rather than 20,000. The cost would be
just over
er patch attached this time
Andrew Dunstan wrote:
I wrote:
Tom Lane wrote:
Andrew Dunstan <[EMAIL PROTECTED]> writes:
Nearly everyone seems to agree that the default for max_fsm_pages
is woefully low, so I would like to have the default for this set
unconditionally to 2
daveg wrote:
On Fri, Dec 23, 2005 at 03:38:56PM -0500, Andrew Dunstan wrote:
What numbers would you like? If what I suggested seems odd, how about
targets of 400 connections, 4000 shared_buffers and 200,000
max_fsm_pages?
Here's a patch that does what I had in mind. On my m
Bruce Momjian wrote:
The big problem is that \. is also a valid
CSV data value (though not a valid non-CSV data value). So, the
solution we came up with was to require \. to appear alone on a line in
CSV mode for it to be treated as end-of-copy.
According to the docs, that's the way to s
Jim C. Nasby wrote:
On Tue, Jan 10, 2006 at 11:31:13AM +0100, Joachim Wieland wrote:
No, cancelling the sleep works (at least for Unix). Isn't cancelling
implemented via a signal that interrupts select() ?
Anyway, I've changed it, removing the ~2000s limit is a good point.
+ while (
Tom Lane said:
> Andrew Dunstan <[EMAIL PROTECTED]> writes:
>> Jim C. Nasby wrote:
>>> Won't this result in a call to pg_sleep with a long sleep time ending
>>> up sleeping noticeably longer than requested?
>
>> Looks like it to me.
>
> Somethin
On Thu, 2006-01-19 at 15:33 -0500, Tom Lane wrote:
> Bruce Momjian writes:
> > The difference between Magnus's and Andrew's is
> > that Magnus used MODULE_big (which means create a shared library), while
> > Andrew used MODULES. So, Magnus's only worked because he was creating a
> > DLL and that
I was reminded today of the outstanding issue with plperl setting the
locale on Windows, and our environment workaround not working there.
There has been NO response to the bug I filed (#38193) at rt.perl.org
about this issue.
The attached patch adapts one I previously tested as working, bu
Martijn van Oosterhout wrote:
Shift/reduce and reduce/reduce errors still produce valid working
parsers, it's just that bison has to resolve an ambiguity by the
default (shift, otherwise earliest rule wins. maximum munch rule
really).
If you don't like relying on file order to resolve this, a
Martijn van Oosterhout wrote:
On Sun, Jan 22, 2006 at 09:04:14AM -0500, Andrew Dunstan wrote:
If you don't like relying on file order to resolve this, appropriate
use of %prec would have the same effect (just like for operator
precedence). The output file tell you which way bison
Tom Lane wrote:
The effect of this, as Andrew says, is that in this particular context
you can't write SET as an alias unless you write AS first. This is
probably not going to surprise anyone in the UPDATE case, since the
ambiguity inherent in writing
UPDATE foo set SET ...
is pretty
I have now tested the patch. It passes regression and the test case Tom
previously posted. Unless there's an objection I will apply it and
backport it in the next few days.
cheers
andrew
I wrote:
I was reminded today of the outstanding issue with plperl setting the
locale on Windows, an
On Wed, 2006-01-25 at 16:08 +0200, Devrim GUNDUZ wrote:
> Hi,
>
> Attached is a patch which adds --quiet and --q option to initdb. I
> personally needed this option while writing a document and taking
> screenshot :) It only shows the error and warning messages, as well as
> the last lines.
>
> I
applied to HEAD, 8.1 and 8.0.
cheers
andrew
I wrote:
I have now tested the patch. It passes regression and the test case
Tom previously posted. Unless there's an objection I will apply it and
backport it in the next few days.
cheers
andrew
I wrote:
I was reminded today of the outs
This patch provides DROP ... IF EXISTS for user/group/role.
If there's no objection I will apply it soon and document it.
cheers
andrew
Index: src/backend/commands/user.c
===
RCS file: /cvsroot/pgsql/src/backend/commands/user.c,v
David Fetter wrote:
+ /* Disallow BADCHARS characters */
+ if (strcspn(cstate->delim, BADCHARS) != 1)
+ ereport(ERROR,
+ (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+errmsg("COPY delimiter cannot be \"%#02x\"",
+
David Fetter said:
> On Tue, Jan 31, 2006 at 08:03:41PM -0500, Bruce Momjian wrote:
>> Uh, couldn't the delimiter be a backslash in CVS mode?
>
> I don't think so. Folks?
Using backslash as a delimiter in CSV would be odd, to say the least. As an
escape char it is occasionally used, but not as a
David Fetter wrote:
Anyhow, Bruce's patch still allows backslash as a delimiter, which can
cause *all* kinds of fun if not disallowed.
Yes, I'm puzzled by that. I can't really see any case for allowing it.
And if we do, it should only be allowed in CSV mode, where its use will
be mere
On Wed, 2006-02-01 at 17:20 -0500, Stephen Frost wrote:
> * Bruce Momjian (pgman@candle.pha.pa.us) wrote:
> > Stephen Frost wrote:
> > > Great! It'd be really nice to have this fix in 8.1.3... :)
> >
> > No, it will not be in 8.1.3. It is a new feature.
>
> I'd really appriciate it if you could
Tom Lane said:
>
> Also, it might be possible to depend on whether libpq has entered the
> "copy in" state. I'm not sure this works very well, because if there's
> an error in the COPY command itself (not in the following data) then we
> probably don't ever get into "copy in" state.
>
Could we n
On Wed, 2006-02-01 at 23:48 -0500, Bruce Momjian wrote:
> I have researched your report, and you are right, there are two ecpg
> bugs here. First, dollar quoting uses single-quotes internally to do
> the quoting, but it does not double any single-quotes in the
> dollar-quoted string.
>
As a matt
On Thu, 2006-02-02 at 16:41 -0500, Tom Lane wrote:
> Andrew Dunstan <[EMAIL PROTECTED]> writes:
> > As a matter of curiosity, why does ecpg handle dollar quoting like that?
> > psql, for example, happily just passes a dollar quoted string through to
> > the backend, wit
I wrote:
This patch provides DROP ... IF EXISTS for user/group/role.
If there's no objection I will apply it soon and document it.
There wasn't so I did.
cheers
andrew
---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster
Here's a first draft patch for DROP ... IF EXISTS for the remaining
cases, namely: LANGUAGE, TABLESPACE, TRIGGER OPERATOR CLASS, FUNCTION,
AGGREGATE, OPERATOR, CAST and RULE.
comments welcome - working on tests/docs now.
cheers
andrew
Index: src/backend/commands/aggregatecmds.c
Tom Lane wrote:
Andrew Dunstan <[EMAIL PROTECTED]> writes:
Here's a first draft patch for DROP ... IF EXISTS for the remaining
cases, namely: LANGUAGE, TABLESPACE, TRIGGER OPERATOR CLASS, FUNCTION,
AGGREGATE, OPERATOR, CAST and RULE.
At what point does this stop being
Bruce Momjian wrote:
However, I see CREATE ROLE doesn't have REPLACE functionality, so what
is the logic of when we need IF EXISTS and when we don't? Perhaps they
all should have it, and the REPLACE is just for objects you want to
replace but keep existing linkage in place.
That was my
Dmitry Karasik wrote:
[patch snipped]
I have cleaned this patch somewhat by removing some bitrot that occurred
since it was submitted, and adjusting formatting to something more
closely resembling postgresql style (please remember to follow our style
in future).
The attached works on HEAD
Andrew Dunstan wrote:
I wrote:
I will add some trace writes when I get a chance. I was rather hoping
something would jump out at you, but obviously it hasn't, so I'll
have to dig into it the slow way. *sigh*
Just eyeballing the code it looks to me like the problem is
the attached patch makes initdb -U username work as advertised.
Barring objection I will apply it to head and backpatch to 8.0 and 8.1
branches.
I guess nobody uses this much, or we'd surely have had reports of
breakage long before now.
cheers
andrew
Index: src/bin/initdb/initdb.c
===
Magnus Hagander wrote:
I was very surprised by this issue as well. I am just assuming that
not many people have a c:\dev directory on their machines
where they
run postgreSQL from. That is the only way that you would be able to
open the file '/dev/tty', if the cwd is c:.
If I
Neil Conway said:
> On Tue, 2006-02-28 at 22:38 -0500, Tom Lane wrote:
>> There are one or two "cannot"s that should be "could not"s in your hit
>> list, per the style guidelines.
>>
>> While you're at it -- I noticed several of the tsearch2 messages refer
>> to "lexem(s)". The word is "lexeme", t
I am waiting for an update from Dmitry.
cheers
andrew
Bruce Momjian wrote:
Is this patch going to be applied?
---
Andrew Dunstan wrote:
I have cleaned this patch somewhat by removing some bitrot that occurred
Dmitry Karasik wrote:
Bruce Momjian wrote:
Is this patch going to be applied?
I am waiting for an update from Dmitry.
cheers
andrew
I believe this is some kind of misunderstanding, sorry if from my part,
but I don't think any further updates are necessary.
OK, I'll take
Bruce Momjian wrote:
Christopher Kings-Lynne wrote:
Here's a first draft patch for DROP ... IF EXISTS for the remaining
cases, namely: LANGUAGE, TABLESPACE, TRIGGER OPERATOR CLASS,
FUNCTION, AGGREGATE, OPERATOR, CAST and RULE.
At what point does this stop being useful and beco
Andrew Dunstan wrote:
Dmitry Karasik wrote:
Bruce Momjian wrote:
Is this patch going to be applied?
I am waiting for an update from Dmitry.
cheers
andrew
I believe this is some kind of misunderstanding, sorry if from my part,
but I don't think any further update
Magnus Hagander wrote:
Awhile back, "Magnus Hagander" <[EMAIL PROTECTED]> wrote:
This patch adds native LDAP auth, for those platforms that
don't have
PAM (such as Win32, but also unixen without PAM). On Unix, uses
OpenLDAP. On win32, u
Tom Lane wrote:
=?ISO-8859-1?Q?Hans-J=FCrgen_Sch=F6nig?= <[EMAIL PROTECTED]> writes:
Peter Eisentraut wrote:
Does any SQL-like database system other than Oracle have this feature?
the most popular are: db2, max db, informix, ms sql.
in other words: all databases which are
Tom Lane wrote:
Andrew Dunstan <[EMAIL PROTECTED]> writes:
Even if they don't all have precisely the same semantics, though, is
there an objection in principle to providing synonyms?
The point I was trying to bring out is that they aren't standard,
which amounts to
Peter Eisentraut wrote:
Stefan Kaltenbrunner wrote:
looks like somebody forgot to test some changes to the pg_dumpall
code in Revision 1.70 against <8.1 installations - resulting in the
following syntax error:
Dump output is never expected to be backward compatible.
We don't exp
Stefan Kaltenbrunner wrote:
Hi!
looks like somebody forgot to test some changes to the pg_dumpall code
in Revision 1.70 against <8.1 installations - resulting in the
following syntax error:
patch applied, thanks
andrew
---(end of broadcast)---
Tom Lane wrote:
Joachim Wieland <[EMAIL PROTECTED]> writes:
I send in the appended documentation patch to fix at least the
documentation.
This is wrong according to my tests. "localhost" *does* work,
at least in some cases.
As I understand it, the only case where it doesn't is w
Tom Lane wrote:
Andrew Dunstan <[EMAIL PROTECTED]> writes:
Tom Lane wrote:
This is wrong according to my tests. "localhost" *does* work,
at least in some cases.
As I understand it, the only case where it doesn't is where an explicit
host connection
The attached tiny patch will fix the problem Greg Sabino Mullane had
with a shared lexical $_TD, by making it a global and just pushing a
local value in the trigger function.
I don't think what we had is strictly a bug, so I don't thinbk we need
top backpatch this.
It will, however, requir
Tom Lane wrote:
Andrew Dunstan <[EMAIL PROTECTED]> writes:
The attached tiny patch will fix the problem Greg Sabino Mullane had
with a shared lexical $_TD, by making it a global and just pushing a
local value in the trigger function.
...
I don't think a docs change is needed.
Zdenek Kotala wrote:
There is path implements following item from todo list: "Allow
commenting of variables in postgresql.conf to restore them to defaults".
Main idea is:
General config structure is extend with default_val attribute to keep
really default value. (There is small conflict - for
Adam Sjøgren wrote:
Hi.
Enclosed is a tiny patch for plperl that puts the schema-name of the
current table in $_TD, so triggers can access tables using
schemaname.tablename, for instance like so:
my $query='INSERT INTO ' . $_TD->{nspname} . '.' . $_TD->{relname} . '_archive
(' . $fieldname
Tom Lane wrote:
Andrew Dunstan <[EMAIL PROTECTED]> writes:
Adam Sjøgren wrote:
Enclosed is a tiny patch for plperl that puts the schema-name of the
current table in $_TD, so triggers can access tables using
schemaname.tablename, for instance like so:
This seems like
Adam Sjøgren said:
>
>
> I haven't looked at the other languages as I do not use them; let me
> know if I should take a stab at providing patches for them as well.
>
I will take it from here. Thanks.
andrew
---(end of broadcast)---
TIP 3: Have y
Please read the developers FAQ:
http://www.postgresql.org/docs/faqs.FAQ_DEV.html
For the most part, patches are probably best generated relative to the
root directory of your CVS checkout.
cheers
andrew
Gurjeet Singh wrote:
I have made the changes to implement this TODO item. I wish t
Here's a patch for tg_table_name and tg_table_schema for plpgsql, which
I would appreciate a quick review of just to make sure I haven't missed
something or done something silly. This will complete this exercise - I
have already committed analogous changes for plperl, plpython and pltcl.
che
Tom Lane wrote:
Andrew Dunstan <[EMAIL PROTECTED]> writes:
Here's a patch for tg_table_name and tg_table_schema for plpgsql, which
I would appreciate a quick review of just to make sure I haven't missed
something or done something silly.
Looks all right other than
Tom Lane wrote:
FWIW, Red Hat's legal department thinks that the FSF has "overreached"
in claiming that the GPL is incompatible with OpenSSL's license. Which
is why Red Hat isn't worrying about GPL apps that use OpenSSL, of which
there are quite a few ...
I'm quite happy if we hang onto Red
Tom Lane wrote:
Bruce Momjian writes:
Patch applied. Thanks.
I hadn't gotten around to reviewing the revised version.
Is it just me or is this happening a lot lately?
cheers
andrew
---(end of broadcast)---
TIP 1: if posting/readin
Bruce Momjian said:
>
> On Win32, patch applied to return path if GetShortPathName() fails (no
short name, path does not exist), rather than returning nothing.
>
What made you choose this rather than GetFullPathName?
cheers
andrew
---(end of broadcast)
Bruce Momjian wrote:
Andrew Dunstan wrote:
Bruce Momjian said:
On Win32, patch applied to return path if GetShortPathName() fails (no
short name, path does not exist), rather than returning nothing.
What made you choose this rather than GetFullPathName?
Sure, we
Bruce Momjian wrote:
How is it different from the path we pass to it? Aren't all
those paths full already?
If they are then it probably doesn't matter.
The reason I don't want to use GetFullPathName() is because on Unix, we
just return the specified path, not the full path, so I d
Greg Stark wrote:
As described on -hackers this is my work so far adding ADD/DROP INHERITS. It
implements the controversial "ALTER TABLE ADD/DROP INHERITS "
syntax that requires making INHERITS a reserved keyword. I haven't seen a
clear consensus yet on what the best syntax to use here would be.
Josh Berkus wrote:
Tom,
What's the consensus on this? Nobody else has chimed in, so I'm
inclined to do no more on the gounds of insufficient demand. Let's
decide before too much bitrot occurs, though.
+1 :)
+1
We were talking about this on IRC, and I feel that if we'
Bruce Momjian wrote:
Tom Lane wrote:
Bruce Momjian writes:
Tom Lane wrote:
I wonder if we should take pg_read_file (and the rest of genfile.c)
back out of the backend and stick them into contrib/adminpack.
I thought about that but what we have in the backend now is re
David Fetter wrote:
On Thu, Jun 08, 2006 at 09:43:19AM -0400, Andrew Dunstan wrote:
OK there does seem to be some demand for this, so I will rework the
patch, and hope to get it done by feature freeze - it has bitrotted
with 7 merge conflicts, including the grammar file, so I need to
look
Jim C. Nasby wrote:
Important as you are, "one swallow does not make a summer".
On the other hand, unless we want the lists filling up with a bunch of
+1 posts, it's probably better to assume that unless someone objects a
patch would be accepted.
What happened was that Tom objected
Here is an updated patch for the remaining cases of DROP objtype IF
EXISTS ... as recently discussed on -hackers.
The cases are:
language, tablespace, trigger, rule, opclass, function, aggregate.
operator, and cast.
Regression tests and docs still to come.
I wasn't quite sure how to form
Bruce Momjian wrote:
This patch implements the COPY VIEW TODO item. Do we want to apply it
for 8.2?
I thought the consensus was that it would be better to do
COPY (SELECT ...) TO ...
rather than requiring the intermediate creation of a view.
cheers
andrew
-
Bruce Momjian wrote:
Andrew Dunstan wrote:
Bruce Momjian wrote:
This patch implements the COPY VIEW TODO item. Do we want to apply it
for 8.2?
I thought the consensus was that it would be better to do
COPY (SELECT ...) TO ...
rather than requiring the intermediate
Hans-Juergen Schoenig wrote:
we agreed on the view solution as people thought that this would be
better and less intrusive. I was also in favour of the syntax your
described below but people voted for the view solution which has been
fully implemented by this patch.
Btw, it seems to be stab
Hans-Juergen Schoenig wrote:
why do we agree on a patch, implement it and reject it then?
would be easier to reject it before actually implementing it ...
it is quite hard to explain to a customer that something is rejected
after approval - even if things are written properly ...
That
501 - 600 of 941 matches
Mail list logo
